@systemfsoftware/oxlint-plugin-test-discipline 5.0.0 → 6.1.3

package/dist/no-inline-suppression.d.ts

@@ -0,0 +1 @@
+export {}

package/dist/no-inline-suppression.mjs

@@ -0,0 +1,144 @@
+#!/usr/bin/env node
+import { execFile } from "node:child_process";
+import { readFile } from "node:fs/promises";
+import { promisify } from "node:util";
+import { parseSync } from "oxc-parser";
+const LINTER_FORMS = [
+	"oxlint-disable-next-line",
+	"oxlint-disable-line",
+	"oxlint-disable",
+	"eslint-disable-next-line",
+	"eslint-disable-line",
+	"eslint-disable",
+	"@ts-expect-error",
+	"@ts-ignore",
+	"@ts-nocheck"
+].filter((form) => !form.startsWith("@"));
+const LEADING_WHITESPACE = /^\s*/u;
+/**
+* TypeScript's own recognition, rewritten over `value` (the text after `//` or `/*`). In TypeScript 6.0.3:
+* - `@ts-expect-error` / `@ts-ignore`: src/compiler/scanner.ts `commentDirectiveRegExSingleLine =
+*   /^\/\/\/?\s*@(ts-expect-error|ts-ignore)/` and `commentDirectiveRegExMultiLine =
+*   /^(?:\/|\*)*\s*@(ts-expect-error|ts-ignore)/` (lib/_tsc.js:8202-8203), matched case-sensitively and
+*   with no end anchor.
+* - `@ts-nocheck`: src/compiler/parser.ts `singleLinePragmaRegEx =
+*   /^\/\/\/?\s*@([^\s:]+)((?:[^\S\r\n]|:).*)?$/m` (lib/_tsc.js:36318); the pragma is registered
+*   `kind: SingleLine` only (lib/_tsc.js:3907-3908), so a block comment never carries it, and its name is
+*   lower-cased before lookup (lib/_tsc.js:36368), so any casing counts. TypeScript reads it only from the
+*   comments before the first token; it is refused wherever it appears, failing closed.
+*/
+const TYPESCRIPT_DIRECTIVES = [
+	["@ts-expect-error", {
+		Line: /^\/?\s*@ts-expect-error/u,
+		Block: /^[/*]*\s*@ts-expect-error/u
+	}],
+	["@ts-ignore", {
+		Line: /^\/?\s*@ts-ignore/u,
+		Block: /^[/*]*\s*@ts-ignore/u
+	}],
+	["@ts-nocheck", {
+		Line: /^\/?\s*@ts-nocheck(?:[^\S\r\n]|:|$)/iu,
+		Block: /(?!)/u
+	}]
+];
+const typeScriptForm = (comment) => TYPESCRIPT_DIRECTIVES.find(([, recognisers]) => recognisers[comment.type].test(comment.value))?.[0];
+const refusedForm = (comment) => {
+	const body = comment.value.replace(LEADING_WHITESPACE, "");
+	return LINTER_FORMS.find((form) => body.startsWith(form)) ?? typeScriptForm(comment);
+};
+//#endregion
+//#region src/rules/suppression-scan.ts
+const positionOf = (sourceText, offset) => {
+	const before = sourceText.slice(0, offset);
+	return {
+		line: before.split("\n").length,
+		column: offset - before.lastIndexOf("\n")
+	};
+};
+/**
+* Every refused comment in `sourceText`. The parser tokenises the source, so a form inside a string,
+* template or regular-expression literal is code, not a comment, and is never read. `filename` selects
+* the dialect by extension (`.ts`, `.tsx`, `.mts`, `.cts`, `.js`, `.mjs`, `.cjs`, `.jsx`).
+*/
+const scanSuppressions = (filename, sourceText) => {
+	const parsed = parseSync(filename, sourceText);
+	return {
+		suppressions: parsed.comments.flatMap((comment) => {
+			const form = refusedForm(comment);
+			return form === void 0 ? [] : [{
+				...positionOf(sourceText, comment.start),
+				form
+			}];
+		}),
+		parseErrors: [...new Set(parsed.errors.map((error) => error.message))]
+	};
+};
+//#endregion
+//#region src/no-inline-suppression.ts
+/**
+* `no-inline-suppression [file...]` — fails when any scanned file holds a comment opening with an
+* oxlint/eslint disable directive, `@ts-expect-error`, `@ts-ignore` or `@ts-nocheck`. With no arguments it scans the git-tracked
+* sources under the working directory. It reads no configuration, and no comment can exempt a file:
+* oxlint obeys a disable directive even for a JS plugin rule that names it, so this check runs outside
+* oxlint.
+*
+* Exit status: 0 clean; 1 a refused comment or an unparseable file; 2 the files could not be listed or read.
+*/
+const SCANNED_PATHSPECS = [
+	"*.ts",
+	"*.tsx",
+	"*.mts",
+	"*.cts",
+	"*.js",
+	"*.jsx",
+	"*.mjs",
+	"*.cjs"
+];
+const run = promisify(execFile);
+/** A file git still tracks but the working tree has deleted: nothing in it can suppress anything. */
+const isMissing = (error) => error instanceof Error && "code" in error && error.code === "ENOENT";
+const trackedSources = async () => {
+	const { stdout } = await run("git", [
+		"ls-files",
+		"-z",
+		"--",
+		...SCANNED_PATHSPECS
+	], { maxBuffer: 1073741824 });
+	return stdout.split("\0").filter((path) => path.length > 0);
+};
+const readTracked = async (file) => {
+	try {
+		return await readFile(file, "utf8");
+	} catch (error) {
+		if (isMissing(error)) return void 0;
+		throw error;
+	}
+};
+const describeSuppression = (file, suppression) => `${file}:${String(suppression.line)}:${String(suppression.column)}: ${suppression.form} is forbidden. Expected: code that passes lint and type-check with no inline suppression. Actual: a comment opening with ${suppression.form}. Fix: delete the comment and fix what it silenced; no comment or setting inside the file exempts it.`;
+const describeParseError = (file, message) => `${file}: cannot be parsed, so its comments cannot all be graded: ${message}. Fix: make the file parse, then rerun no-inline-suppression.`;
+const gradeFile = (file, sourceText) => {
+	const scan = scanSuppressions(file, sourceText);
+	return [...scan.suppressions.map((suppression) => describeSuppression(file, suppression)), ...scan.parseErrors.map((message) => describeParseError(file, message))];
+};
+const main = async (args) => {
+	const explicit = args.length > 0;
+	const files = explicit ? args : await trackedSources();
+	const findings = [];
+	for (const file of files) {
+		const sourceText = explicit ? await readFile(file, "utf8") : await readTracked(file);
+		const lines = sourceText === void 0 ? [] : gradeFile(file, sourceText);
+		findings.push(...lines);
+		if (lines.length > 0) process.stdout.write(`${lines.join("\n")}\n`);
+	}
+	if (findings.length === 0) return 0;
+	process.stderr.write(`no-inline-suppression: ${String(findings.length)} finding(s) in ${String(files.length)} scanned file(s).\n`);
+	return 1;
+};
+try {
+	process.exitCode = await main(process.argv.slice(2));
+} catch (error) {
+	process.stderr.write(`no-inline-suppression: ${error instanceof Error ? error.message : String(error)}\n`);
+	process.exitCode = 2;
+}
+//#endregion
+export {};

package/dist/oxlint-plugin-test-discipline-untrimmed.d.ts

@@ -21,6 +21,7 @@ declare const _default: {
         'src-property-test-cell': Rule;
         'test-file-outside-tests-dir': Rule;
         'test-suffix-outside-src': Rule;
+        'e2e-tier-placement': Rule;
         'behaviour-test-requires-gherkin': Rule;
         'behaviour-exercises-use-case': Rule;
         'behaviour-one-feature-per-file': Rule;

package/dist/oxlint-plugin-test-discipline.d.ts

@@ -21,6 +21,7 @@ declare const _default: {
         'src-property-test-cell': Rule;
         'test-file-outside-tests-dir': Rule;
         'test-suffix-outside-src': Rule;
+        'e2e-tier-placement': Rule;
         'behaviour-test-requires-gherkin': Rule;
         'behaviour-exercises-use-case': Rule;
         'behaviour-one-feature-per-file': Rule;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@systemfsoftware/oxlint-plugin-test-discipline",
   "license": "Apache-2.0",
-  "version": "5.0.0",
+  "version": "6.1.3",
   "author": "Ryan Lee <drdgvhbh@gmail.com>",
   "repository": {
     "type": "git",
@@ -27,6 +27,9 @@
     "typescript"
   ],
   "type": "module",
+  "bin": {
+    "no-inline-suppression": "./dist/no-inline-suppression.mjs"
+  },
   "files": [
     "dist"
   ],
@@ -38,34 +41,29 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@oxc-project/types": "^0.150.0",
-    "@oxlint/plugins": "~1.82.0"
+    "@oxc-project/types": "^0.155.0",
+    "@oxlint/plugins": "~1.89.0",
+    "oxc-parser": "^0.155.0"
   },
   "devDependencies": {
-    "@microsoft/api-extractor": "^7.59.1",
+    "@microsoft/api-extractor": "^7.59.4",
     "@systemfsoftware/arethetypeswrong-cli": "^4.2.0",
-    "@systemfsoftware/stryker-config": "^0.1.0",
-    "@systemfsoftware/stryker-ignorer-effect-schema-declarations": "latest",
-    "@systemfsoftware/stryker-ignorer-in-source-vitest-block": "latest",
-    "@systemfsoftware/stryker-js": "latest",
-    "@systemfsoftware/stryker-js-typescript-checker": "latest",
-    "@systemfsoftware/stryker-js-vitest-runner": "latest",
-    "@systemfsoftware/stryker-test-contribution": "latest",
-    "@systemfsoftware/tsconfig": "^2.0.1",
-    "@systemfsoftware/tsdown-config": "^0.1.0",
-    "@systemfsoftware/vitest-config": "^0.1.0",
-    "@types/node": "^26",
-    "@vitest/coverage-v8": "^5",
-    "effect": "^4",
-    "fast-check": "^4",
-    "oxlint": "~1.82.0",
+    "@systemfsoftware/oxlint-config-rule-authoring": "^3.0.1",
+    "@systemfsoftware/tsconfig": "^2.1.0",
+    "@systemfsoftware/tsdown-config": "^0.1.2",
+    "@systemfsoftware/vitest-config": "^0.1.3",
+    "@types/node": "^26.6.5",
+    "@vitest/coverage-v8": "^5.1.0",
+    "effect": "^4.1.2",
+    "fast-check": "^4.10.2",
+    "oxlint": "~1.89.0",
     "rimraf": "^6.1.3",
     "tsdown": "^0.23.0",
-    "typescript": "^7",
-    "vitest": "^5"
+    "typescript": "^7.0.2",
+    "vitest": "^5.1.0"
   },
   "peerDependencies": {
-    "effect": "^4",
+    "effect": "^4.1.2",
     "typescript": ">=5.0.0"
   },
   "publishConfig": {
@@ -77,8 +75,6 @@
     "clean": "rimraf dist",
     "typecheck": "tsc -b",
     "test": "vitest run",
-    "mutation": "stryker run",
-    "mutation:full": "stryker run --force",
     "lint": "f=${OXLINT_FORMAT:-${AGENT:+agent}}; oxlint . --format=${f:-default}",
     "attw": "attw --pack .",
     "api:check": "api-extractor-quiet run",