@synth-deploy/server 1.0.6 → 1.2.0

package/tests/orchestration.test.ts

@@ -115,14 +115,18 @@ function makeTrigger(opts: {
   version?: string;
   variables?: Record<string, string>;
 }) {
-  return {
+  const input = {
+    type: "deploy" as const,
     artifactId: opts.artifact?.id ?? "",
     artifactVersionId: opts.version ?? "2.0.0",
+  };
+  const trigger = {
     partitionId: opts.partition?.id,
     environmentId: opts.environment?.id ?? "",
     triggeredBy: "user" as const,
     ...(opts.variables ? { variables: opts.variables } : {}),
   };
+  return { input, trigger };
 }
 
 // ---------------------------------------------------------------------------
@@ -159,7 +163,7 @@ describe("Deployment Orchestration Engine", () => {
         artifact, partition, environment: env,
         variables: { LOG_LEVEL: "error" },
       });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("succeeded");
       expect(result.completedAt).not.toBeUndefined();
@@ -172,7 +176,7 @@ describe("Deployment Orchestration Engine", () => {
       });
 
       // Diary records every pipeline step
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       expect(entries.length).toBeGreaterThanOrEqual(5);
 
       // Each entry has a real decision and reasoning
@@ -195,7 +199,7 @@ describe("Deployment Orchestration Engine", () => {
       healthChecker.willReturn(HEALTHY);
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("succeeded");
       expect(result.variables).toEqual({
@@ -203,7 +207,7 @@ describe("Deployment Orchestration Engine", () => {
         PARTITION_SPECIFIC: "abc",
       });
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const completion = findDecisions(entries, "Marking deployment of")[0];
       expect(completion.reasoning).toContain("No variable conflicts");
     });
@@ -222,7 +226,7 @@ describe("Deployment Orchestration Engine", () => {
       const env = seedEnvironment("staging");
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("failed");
       expect(result.failureReason).toContain("unreachable");
@@ -230,7 +234,7 @@ describe("Deployment Orchestration Engine", () => {
       // Should have retried (initial + 1 retry = 2 calls)
       expect(healthChecker.callCount).toBe(2);
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const retryEntries = findDecisions(entries, "attempting retry");
       expect(retryEntries).toHaveLength(1);
       expect(retryEntries[0].reasoning).toContain("restarting");
@@ -250,14 +254,14 @@ describe("Deployment Orchestration Engine", () => {
       const env = seedEnvironment("staging");
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("failed");
 
       // Only called once — no retry for DNS errors
       expect(healthChecker.callCount).toBe(1);
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
 
       // Should have decided NOT to retry
       const abortEntries = findDecisions(entries, "aborting without retry");
@@ -280,11 +284,11 @@ describe("Deployment Orchestration Engine", () => {
       const env = seedEnvironment("production");
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("failed");
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const retryEntries = findDecisions(entries, "attempting retry");
       expect(retryEntries).toHaveLength(1);
 
@@ -305,11 +309,11 @@ describe("Deployment Orchestration Engine", () => {
       const env = seedEnvironment("staging");
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("failed");
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const retryEntries = findDecisions(entries, "attempting retry");
       expect(retryEntries).toHaveLength(1);
 
@@ -326,11 +330,11 @@ describe("Deployment Orchestration Engine", () => {
       const env = seedEnvironment("production");
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("succeeded");
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const recoveryEntries = findDecisions(entries, "recovered on retry");
       expect(recoveryEntries).toHaveLength(1);
       expect(recoveryEntries[0].reasoning).toContain("transient");
@@ -345,11 +349,11 @@ describe("Deployment Orchestration Engine", () => {
       const env = seedEnvironment("production");
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("succeeded");
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const retryEntries = findDecisions(entries, "attempting retry");
       expect(retryEntries).toHaveLength(1);
       // Server errors get different reasoning than connection refused
@@ -371,13 +375,13 @@ describe("Deployment Orchestration Engine", () => {
       healthChecker.willReturn(HEALTHY);
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       // Single override → agent proceeds (might be intentional)
       expect(result.status).toBe("succeeded");
       expect(result.variables.DB_HOST).toBe("prod-db.internal");
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const crossEnvEntries = findDecisions(entries, "Cross-environment");
       expect(crossEnvEntries).toHaveLength(1);
 
@@ -402,14 +406,14 @@ describe("Deployment Orchestration Engine", () => {
       healthChecker.willReturn(HEALTHY);
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       // THIS IS THE KEY BEHAVIORAL DIFFERENCE:
       // Multiple cross-env connectivity overrides → deployment blocked
       expect(result.status).toBe("failed");
       expect(result.failureReason).toContain("high-risk");
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
 
       // Agent explains WHY it blocked
       const blockEntries = findDecisions(entries, "Blocking deployment");
@@ -435,7 +439,7 @@ describe("Deployment Orchestration Engine", () => {
       healthChecker.willReturn(HEALTHY);
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       // Non-connectivity cross-env → proceeds (can't route traffic)
       expect(result.status).toBe("succeeded");
@@ -449,12 +453,12 @@ describe("Deployment Orchestration Engine", () => {
       healthChecker.willReturn(HEALTHY);
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("succeeded");
       expect(result.variables.API_SECRET).toBe("partition-secret-xyz");
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const sensitiveEntries = findDecisions(entries, "Security-sensitive");
       expect(sensitiveEntries).toHaveLength(1);
       expect(sensitiveEntries[0].reasoning).toContain("audit");
@@ -479,8 +483,8 @@ describe("Deployment Orchestration Engine", () => {
       healthChecker.willReturn(HEALTHY);
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
-      const entries = diary.getByDeployment(result.id);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
+      const entries = diary.getByOperation(result.id);
 
       for (const entry of entries) {
         expect(entry.partitionId).toBe(partition.id);
@@ -499,17 +503,17 @@ describe("Deployment Orchestration Engine", () => {
       const env = seedEnvironment("production");
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       expect(result.status).toBe("failed");
 
       for (const entryId of result.debriefEntryIds) {
         const entry = diary.getById(entryId);
         expect(entry).toBeDefined();
-        expect(entry!.deploymentId).toBe(result.id);
+        expect(entry!.operationId).toBe(result.id);
       }
 
-      const entries = diary.getByDeployment(result.id);
+      const entries = diary.getByOperation(result.id);
       const failEntry = findDecisions(entries, "Deployment failed")[0];
       expect(failEntry.context).toHaveProperty(
         "step",
@@ -525,7 +529,7 @@ describe("Deployment Orchestration Engine", () => {
       const env = seedEnvironment("production");
 
       const trigger = makeTrigger({ artifact, partition, environment: env });
-      const result = await agent.triggerDeployment(trigger);
+      const result = await agent.triggerOperation(trigger.input, trigger.trigger);
 
       const stored = deployments.get(result.id);
       expect(stored).toBeDefined();

package/tests/partition-isolation.test.ts

@@ -119,15 +119,10 @@ async function testDeployWithPartition(
 
   const artifact = getOrCreateArtifact();
 
-  const trigger = {
-    artifactId: artifact.id,
-    artifactVersionId: version,
-    partitionId: partition.id,
-    environmentId: env.id,
-    triggeredBy: "user" as const,
-    ...(variables ? { variables } : {}),
-  };
-  return agent.triggerDeployment(trigger);
+  return agent.triggerOperation(
+    { type: "deploy", artifactId: artifact.id, artifactVersionId: version },
+    { partitionId: partition.id, environmentId: env.id, triggeredBy: "user", ...(variables ? { variables } : {}) },
+  );
 }
 
 // ---------------------------------------------------------------------------

package/tests/rbac-enforcement.test.ts

@@ -18,7 +18,7 @@ import { InMemoryDeploymentStore } from "../src/agent/synth-agent.js";
 import { registerPartitionRoutes } from "../src/api/partitions.js";
 import { registerEnvironmentRoutes } from "../src/api/environments.js";
 import { registerSettingsRoutes } from "../src/api/settings.js";
-import { registerDeploymentRoutes } from "../src/api/deployments.js";
+import { registerOperationRoutes } from "../src/api/operations.js";
 import { registerArtifactRoutes } from "../src/api/artifacts.js";
 import { registerAuthMiddleware, generateTokens } from "../src/middleware/auth.js";
 
@@ -120,7 +120,7 @@ async function createTestServer(): Promise<TestContext> {
   registerPartitionRoutes(app, partitions, deployments, diary, telemetry);
   registerEnvironmentRoutes(app, environments, deployments, telemetry);
   registerSettingsRoutes(app, settings, telemetry);
-  registerDeploymentRoutes(app, deployments, diary, partitions, environments, artifactStore, settings, telemetry);
+  registerOperationRoutes(app, deployments, diary, partitions, environments, artifactStore, settings, telemetry);
   registerArtifactRoutes(app, artifactStore, telemetry);
 
   await app.ready();
@@ -175,8 +175,8 @@ describe("RBAC enforcement", () => {
   describe("unauthenticated requests return 401", () => {
     const routes: Array<{ method: "GET" | "POST" | "PUT" | "DELETE"; url: string }> = [
       // Deployments
-      { method: "GET", url: "/api/deployments" },
-      { method: "POST", url: "/api/deployments" },
+      { method: "GET", url: "/api/operations" },
+      { method: "POST", url: "/api/operations" },
       { method: "GET", url: "/api/debrief" },
       // Artifacts
       { method: "GET", url: "/api/artifacts" },
@@ -215,10 +215,10 @@ describe("RBAC enforcement", () => {
   // -------------------------------------------------------------------------
 
   describe("viewer cannot perform write operations (403)", () => {
-    it("POST /api/deployments returns 403 for viewer", async () => {
+    it("POST /api/operations returns 403 for viewer", async () => {
       const res = await ctx.app.inject({
         method: "POST",
-        url: "/api/deployments",
+        url: "/api/operations",
         headers: { authorization: `Bearer ${ctx.viewerToken}` },
         payload: { artifactId: "a1", environmentId: "e1" },
       });
@@ -318,10 +318,10 @@ describe("RBAC enforcement", () => {
   // -------------------------------------------------------------------------
 
   describe("viewer can access read-only routes (200)", () => {
-    it("GET /api/deployments returns 200 for viewer", async () => {
+    it("GET /api/operations returns 200 for viewer", async () => {
       const res = await ctx.app.inject({
         method: "GET",
-        url: "/api/deployments",
+        url: "/api/operations",
         headers: { authorization: `Bearer ${ctx.viewerToken}` },
       });
       expect(res.statusCode).toBe(200);

package/tests/ui-journey.test.ts

@@ -4,7 +4,7 @@ import type { FastifyInstance } from "fastify";
 import { DecisionDebrief, PartitionStore, EnvironmentStore, ArtifactStore, SettingsStore, TelemetryStore } from "@synth-deploy/core";
 import type { Deployment, DebriefEntry, PostmortemReport, OperationHistory } from "@synth-deploy/core";
 import { SynthAgent, InMemoryDeploymentStore } from "../src/agent/synth-agent.js";
-import { registerDeploymentRoutes } from "../src/api/deployments.js";
+import { registerOperationRoutes } from "../src/api/operations.js";
 import { registerPartitionRoutes } from "../src/api/partitions.js";
 import { registerEnvironmentRoutes } from "../src/api/environments.js";
 import { registerArtifactRoutes } from "../src/api/artifacts.js";
@@ -61,7 +61,7 @@ beforeAll(async () => {
 
   app = Fastify();
   addMockAuth(app);
-  registerDeploymentRoutes(app, deployments, diary, partitions, environments, artifactStore, settings, telemetry);
+  registerOperationRoutes(app, deployments, diary, partitions, environments, artifactStore, settings, telemetry);
   registerPartitionRoutes(app, partitions, deployments, diary, telemetry);
   registerEnvironmentRoutes(app, environments, deployments, telemetry);
   registerArtifactRoutes(app, artifactStore, telemetry);
@@ -174,7 +174,7 @@ describe("Complete UI user journey", () => {
   it("triggers a deployment", async () => {
     const res = await app.inject({
       method: "POST",
-      url: "/api/deployments",
+      url: "/api/operations",
       payload: {
         artifactId,
         partitionId,
@@ -194,7 +194,7 @@ describe("Complete UI user journey", () => {
   it("lists deployments filtered by partition", async () => {
     const res = await app.inject({
       method: "GET",
-      url: `/api/deployments?partitionId=${partitionId}`,
+      url: `/api/operations?partitionId=${partitionId}`,
     });
 
     const body = JSON.parse(res.payload);
@@ -207,7 +207,7 @@ describe("Complete UI user journey", () => {
   it("gets deployment detail", async () => {
     const res = await app.inject({
       method: "GET",
-      url: `/api/deployments/${firstDeploymentId}`,
+      url: `/api/operations/${firstDeploymentId}`,
     });
 
     const body = JSON.parse(res.payload);
@@ -219,7 +219,7 @@ describe("Complete UI user journey", () => {
   it("triggers a second deployment (version upgrade)", async () => {
     const res = await app.inject({
       method: "POST",
-      url: "/api/deployments",
+      url: "/api/operations",
       payload: {
         artifactId,
         partitionId,
@@ -239,7 +239,7 @@ describe("Complete UI user journey", () => {
   it("lists all deployments for partition showing both", async () => {
     const res = await app.inject({
       method: "GET",
-      url: `/api/deployments?partitionId=${partitionId}`,
+      url: `/api/operations?partitionId=${partitionId}`,
     });
 
     const body = JSON.parse(res.payload);
@@ -254,7 +254,7 @@ describe("Complete UI user journey", () => {
   it("lists deployments filtered by artifact", async () => {
     const res = await app.inject({
       method: "GET",
-      url: `/api/deployments?artifactId=${artifactId}`,
+      url: `/api/operations?artifactId=${artifactId}`,
     });
 
     const body = JSON.parse(res.payload);
@@ -277,7 +277,7 @@ describe("Complete UI user journey", () => {
   });
 
   it("lists all deployments", async () => {
-    const res = await app.inject({ method: "GET", url: "/api/deployments" });
+    const res = await app.inject({ method: "GET", url: "/api/operations" });
     const body = JSON.parse(res.payload);
     expect(body.deployments.length).toBeGreaterThanOrEqual(2);
   });

package/dist/api/deployments.d.ts

@@ -1,11 +0,0 @@
-import type { FastifyInstance } from "fastify";
-import type { LlmClient, IPartitionStore, IEnvironmentStore, IArtifactStore, ISettingsStore, IDeploymentStore, ITelemetryStore, DebriefWriter, DebriefReader } from "@synth-deploy/core";
-import type { ProgressEventStore } from "./progress-event-store.js";
-import { EnvoyClient } from "../agent/envoy-client.js";
-import type { EnvoyRegistry } from "../agent/envoy-registry.js";
-/**
- * REST API routes for deployments. These are the traditional (non-MCP) interface
- * for the web UI and integrations.
- */
-export declare function registerDeploymentRoutes(app: FastifyInstance, deployments: IDeploymentStore, debrief: DebriefWriter & DebriefReader, partitions: IPartitionStore, environments: IEnvironmentStore, artifactStore: IArtifactStore, settings: ISettingsStore, telemetry: ITelemetryStore, progressStore?: ProgressEventStore, envoyClient?: EnvoyClient, envoyRegistry?: EnvoyRegistry, llm?: LlmClient): void;
-//# sourceMappingURL=deployments.d.ts.map

package/dist/api/deployments.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"deployments.d.ts","sourceRoot":"","sources":["../../src/api/deployments.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,SAAS,CAAC;AAE/C,OAAO,KAAK,EAAE,SAAS,EAAE,eAAe,EAAE,iBAAiB,EAAE,cAAc,EAAE,cAAc,EAAE,gBAAgB,EAAE,eAAe,EAAE,aAAa,EAAE,aAAa,EAA+C,MAAM,oBAAoB,CAAC;AAatO,OAAO,KAAK,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAC;AACpE,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AACvD,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,4BAA4B,CAAC;AAEhE;;;GAGG;AACH,wBAAgB,wBAAwB,CACtC,GAAG,EAAE,eAAe,EACpB,WAAW,EAAE,gBAAgB,EAC7B,OAAO,EAAE,aAAa,GAAG,aAAa,EACtC,UAAU,EAAE,eAAe,EAC3B,YAAY,EAAE,iBAAiB,EAC/B,aAAa,EAAE,cAAc,EAC7B,QAAQ,EAAE,cAAc,EACxB,SAAS,EAAE,eAAe,EAC1B,aAAa,CAAC,EAAE,kBAAkB,EAClC,WAAW,CAAC,EAAE,WAAW,EACzB,aAAa,CAAC,EAAE,aAAa,EAC7B,GAAG,CAAC,EAAE,SAAS,GACd,IAAI,CAitCN"}