@syntesseraai/opencode-feature-factory 0.2.3 → 0.2.4

package/src/discovery.test.ts

@@ -1,114 +0,0 @@
-/**
- * Unit tests for discovery module
- *
- * Tests focus on the pure function:
- * - buildRunCommand: builds package manager-specific run commands
- *
- * Note: Most functions in discovery.ts require shell access ($) so they're
- * integration-tested elsewhere. This file tests the pure utility functions.
- */
-
-import type { PackageManager } from './types';
-
-// Re-implement buildRunCommand for testing since it's not exported
-function buildRunCommand(pm: PackageManager, script: string): string {
-  switch (pm) {
-    case 'pnpm':
-      return `pnpm -s run ${script}`;
-    case 'bun':
-      return `bun run ${script}`;
-    case 'yarn':
-      return `yarn -s ${script}`;
-    case 'npm':
-      return `npm run -s ${script}`;
-  }
-}
-
-describe('buildRunCommand', () => {
-  describe('pnpm', () => {
-    it('should build correct pnpm command', () => {
-      expect(buildRunCommand('pnpm', 'lint')).toBe('pnpm -s run lint');
-    });
-
-    it('should build correct pnpm command for build script', () => {
-      expect(buildRunCommand('pnpm', 'build')).toBe('pnpm -s run build');
-    });
-
-    it('should build correct pnpm command for test script', () => {
-      expect(buildRunCommand('pnpm', 'test')).toBe('pnpm -s run test');
-    });
-
-    it('should handle scripts with colons', () => {
-      expect(buildRunCommand('pnpm', 'lint:ci')).toBe('pnpm -s run lint:ci');
-    });
-  });
-
-  describe('bun', () => {
-    it('should build correct bun command', () => {
-      expect(buildRunCommand('bun', 'lint')).toBe('bun run lint');
-    });
-
-    it('should build correct bun command for build script', () => {
-      expect(buildRunCommand('bun', 'build')).toBe('bun run build');
-    });
-
-    it('should build correct bun command for test script', () => {
-      expect(buildRunCommand('bun', 'test')).toBe('bun run test');
-    });
-  });
-
-  describe('yarn', () => {
-    it('should build correct yarn command', () => {
-      expect(buildRunCommand('yarn', 'lint')).toBe('yarn -s lint');
-    });
-
-    it('should build correct yarn command for build script', () => {
-      expect(buildRunCommand('yarn', 'build')).toBe('yarn -s build');
-    });
-
-    it('should build correct yarn command for test script', () => {
-      expect(buildRunCommand('yarn', 'test')).toBe('yarn -s test');
-    });
-  });
-
-  describe('npm', () => {
-    it('should build correct npm command', () => {
-      expect(buildRunCommand('npm', 'lint')).toBe('npm run -s lint');
-    });
-
-    it('should build correct npm command for build script', () => {
-      expect(buildRunCommand('npm', 'build')).toBe('npm run -s build');
-    });
-
-    it('should build correct npm command for test script', () => {
-      expect(buildRunCommand('npm', 'test')).toBe('npm run -s test');
-    });
-  });
-
-  describe('edge cases', () => {
-    it('should handle script names with hyphens', () => {
-      expect(buildRunCommand('npm', 'type-check')).toBe('npm run -s type-check');
-    });
-
-    it('should handle script names with underscores', () => {
-      expect(buildRunCommand('pnpm', 'lint_fix')).toBe('pnpm -s run lint_fix');
-    });
-
-    it('should handle long script names', () => {
-      expect(buildRunCommand('yarn', 'test:unit:coverage')).toBe('yarn -s test:unit:coverage');
-    });
-  });
-});
-
-/**
- * PackageManager type validation tests
- * These ensure the type constraints are working correctly
- */
-describe('PackageManager type', () => {
-  it('should accept valid package manager values', () => {
-    const validManagers: PackageManager[] = ['pnpm', 'bun', 'yarn', 'npm'];
-    validManagers.forEach((pm) => {
-      expect(['pnpm', 'bun', 'yarn', 'npm']).toContain(pm);
-    });
-  });
-});

package/src/discovery.ts

@@ -1,242 +0,0 @@
-import type { CommandStep, PackageManager, QualityGateConfig } from './types';
-import {
-  DEFAULT_QUALITY_GATE,
-  fileExists,
-  hasConfiguredCommands,
-  readJsonFile,
-} from './quality-gate-config';
-
-type BunShell = any;
-
-// ============================================================================
-// Package Manager Detection
-// ============================================================================
-
-/**
- * Detect the package manager based on lockfile presence.
- * Priority: pnpm > bun > yarn > npm
- */
-async function detectPackageManager(
-  $: BunShell,
-  directory: string,
-  override?: string
-): Promise<PackageManager> {
-  if (override && override !== 'auto') {
-    return override as PackageManager;
-  }
-
-  // Priority order: pnpm > bun > yarn > npm
-  if (await fileExists($, `${directory}/pnpm-lock.yaml`)) return 'pnpm';
-  if (await fileExists($, `${directory}/bun.lockb`)) return 'bun';
-  if (await fileExists($, `${directory}/bun.lock`)) return 'bun';
-  if (await fileExists($, `${directory}/yarn.lock`)) return 'yarn';
-  if (await fileExists($, `${directory}/package-lock.json`)) return 'npm';
-
-  return 'npm'; // fallback
-}
-
-/**
- * Build the run command for a given package manager and script name
- */
-function buildRunCommand(pm: PackageManager, script: string): string {
-  switch (pm) {
-    case 'pnpm':
-      return `pnpm -s run ${script}`;
-    case 'bun':
-      return `bun run ${script}`;
-    case 'yarn':
-      return `yarn -s ${script}`;
-    case 'npm':
-      return `npm run -s ${script}`;
-  }
-}
-
-// ============================================================================
-// Node.js Discovery
-// ============================================================================
-
-/**
- * Discover Node.js lint/build/test commands from package.json scripts
- */
-async function discoverNodeCommands(
-  $: BunShell,
-  directory: string,
-  pm: PackageManager
-): Promise<CommandStep[]> {
-  const pkgJson = await readJsonFile($, `${directory}/package.json`);
-  if (!pkgJson?.scripts) return [];
-
-  const scripts = pkgJson.scripts as Record<string, string>;
-  const steps: CommandStep[] = [];
-
-  // Lint: prefer lint:ci, then lint
-  const lintScript = scripts['lint:ci'] ? 'lint:ci' : scripts['lint'] ? 'lint' : null;
-  if (lintScript) {
-    steps.push({ step: 'lint', cmd: buildRunCommand(pm, lintScript) });
-  }
-
-  // Build: prefer build:ci, then build
-  const buildScript = scripts['build:ci'] ? 'build:ci' : scripts['build'] ? 'build' : null;
-  if (buildScript) {
-    steps.push({ step: 'build', cmd: buildRunCommand(pm, buildScript) });
-  }
-
-  // Test: prefer test:ci, then test
-  const testScript = scripts['test:ci'] ? 'test:ci' : scripts['test'] ? 'test' : null;
-  if (testScript) {
-    steps.push({ step: 'test', cmd: buildRunCommand(pm, testScript) });
-  }
-
-  return steps;
-}
-
-// ============================================================================
-// Rust Discovery
-// ============================================================================
-
-/**
- * Discover Rust commands from Cargo.toml presence
- */
-async function discoverRustCommands(
-  $: BunShell,
-  directory: string,
-  includeClippy: boolean
-): Promise<CommandStep[]> {
-  if (!(await fileExists($, `${directory}/Cargo.toml`))) return [];
-
-  const steps: CommandStep[] = [{ step: 'lint (fmt)', cmd: 'cargo fmt --check' }];
-
-  if (includeClippy) {
-    steps.push({
-      step: 'lint (clippy)',
-      cmd: 'cargo clippy --all-targets --all-features',
-    });
-  }
-
-  steps.push({ step: 'build', cmd: 'cargo build' });
-  steps.push({ step: 'test', cmd: 'cargo test' });
-
-  return steps;
-}
-
-// ============================================================================
-// Go Discovery
-// ============================================================================
-
-/**
- * Discover Go commands from go.mod presence
- */
-async function discoverGoCommands($: BunShell, directory: string): Promise<CommandStep[]> {
-  if (!(await fileExists($, `${directory}/go.mod`))) return [];
-
-  return [{ step: 'test', cmd: 'go test ./...' }];
-}
-
-// ============================================================================
-// Python Discovery
-// ============================================================================
-
-/**
- * Discover Python test commands with strong signal detection
- */
-async function discoverPythonCommands($: BunShell, directory: string): Promise<CommandStep[]> {
-  // Only add pytest if we have strong signal
-  const hasPytestIni = await fileExists($, `${directory}/pytest.ini`);
-  const hasPyproject = await fileExists($, `${directory}/pyproject.toml`);
-
-  if (!hasPytestIni && !hasPyproject) return [];
-
-  // pytest.ini is strong signal
-  if (hasPytestIni) {
-    return [{ step: 'test', cmd: 'pytest' }];
-  }
-
-  // Check if pyproject.toml mentions pytest
-  if (hasPyproject) {
-    try {
-      const result = await $`cat ${directory}/pyproject.toml`.quiet();
-      const content = result.text();
-      if (content.includes('pytest')) {
-        return [{ step: 'test', cmd: 'pytest' }];
-      }
-    } catch {
-      // Ignore read errors - return empty array if file can't be read
-    }
-  }
-
-  return [];
-}
-
-// ============================================================================
-// Main Resolution Logic
-// ============================================================================
-
-/**
- * Resolve the command plan based on configuration and discovery.
- *
- * Resolution order:
- * 1. Configured commands (qualityGate.lint/build/test) - highest priority
- * 2. management/ci.sh (Feature Factory convention) - only if no configured commands
- * 3. Conventional discovery (Node/Rust/Go/Python) - only if no ci.sh
- *
- * @returns Array of command steps to execute, or empty if nothing found
- */
-export async function resolveCommands(args: {
-  $: BunShell;
-  directory: string;
-  config: QualityGateConfig;
-}): Promise<CommandStep[]> {
-  const { $, directory, config } = args;
-  const mergedConfig = { ...DEFAULT_QUALITY_GATE, ...config };
-
-  // 1. Configured commands take priority (do NOT run ci.sh if these exist)
-  if (hasConfiguredCommands(config)) {
-    const steps: CommandStep[] = [];
-    const order = mergedConfig.steps;
-
-    for (const stepName of order) {
-      const cmd = config[stepName];
-      if (cmd) {
-        steps.push({ step: stepName, cmd });
-      }
-    }
-
-    return steps;
-  }
-
-  // 2. Feature Factory CI script (only if no configured commands)
-  if (mergedConfig.useCiSh !== 'never') {
-    const ciShPath = `${directory}/management/ci.sh`;
-    if (await fileExists($, ciShPath)) {
-      return [{ step: 'ci', cmd: `bash ${ciShPath}` }];
-    }
-  }
-
-  // 3. Conventional discovery (only if no ci.sh)
-  const pm = await detectPackageManager($, directory, mergedConfig.packageManager);
-
-  // Try Node first (most common)
-  if (await fileExists($, `${directory}/package.json`)) {
-    const nodeSteps = await discoverNodeCommands($, directory, pm);
-    if (nodeSteps.length > 0) return nodeSteps;
-  }
-
-  // Rust
-  const rustSteps = await discoverRustCommands(
-    $,
-    directory,
-    mergedConfig.include?.rustClippy ?? true
-  );
-  if (rustSteps.length > 0) return rustSteps;
-
-  // Go
-  const goSteps = await discoverGoCommands($, directory);
-  if (goSteps.length > 0) return goSteps;
-
-  // Python
-  const pythonSteps = await discoverPythonCommands($, directory);
-  if (pythonSteps.length > 0) return pythonSteps;
-
-  // No commands discovered
-  return [];
-}

package/src/index.ts

@@ -1,105 +0,0 @@
-import type { Plugin, Hooks, PluginInput } from '@opencode-ai/plugin';
-import { createQualityGateHooks } from './stop-quality-gate';
-
-// Export skill and agent paths for programmatic access
-export const SKILL_PATHS = {
-  'ff-mini-plan': './skills/ff-mini-plan/SKILL.md',
-  'ff-todo-management': './skills/ff-todo-management/SKILL.md',
-  'ff-severity-classification': './skills/ff-severity-classification/SKILL.md',
-  'ff-report-templates': './skills/ff-report-templates/SKILL.md',
-};
-
-export const AGENT_PATHS = {
-  'ff-acceptance': './agents/ff-acceptance.md',
-  'ff-review': './agents/ff-review.md',
-  'ff-security': './agents/ff-security.md',
-  'ff-well-architected': './agents/ff-well-architected.md',
-  'ff-validate': './agents/ff-validate.md',
-};
-
-const SERVICE_NAME = 'feature-factory';
-
-type Client = PluginInput['client'];
-
-/**
- * Log a message using the OpenCode client's structured logging.
- * Silently fails if logging is unavailable.
- */
-async function log(
-  client: Client,
-  level: 'debug' | 'info' | 'warn' | 'error',
-  message: string,
-  extra?: Record<string, unknown>
-): Promise<void> {
-  try {
-    await client.app.log({
-      body: {
-        service: SERVICE_NAME,
-        level,
-        message,
-        extra,
-      },
-    });
-  } catch {
-    // Logging failure should not affect plugin operation
-  }
-}
-
-/**
- * Determine the project root directory.
- * Prefer worktree (git root) if available, otherwise use directory.
- */
-function resolveRootDir(input: { worktree: string; directory: string }): string {
-  const worktree = (input.worktree ?? '').trim();
-  if (worktree.length > 0) return worktree;
-  return input.directory;
-}
-
-/**
- * Stop Quality Gate Plugin
- *
- * Runs quality gate checks when the agent becomes idle after editing files.
- *
- * Behavior:
- * - Runs quality gate on session.idle (when agent finishes working)
- * - Executes management/ci.sh directly (no LLM involvement)
- * - On fast feedback: "Quality gate is running, please stand-by for results ..."
- * - On success: "Quality gate passed"
- * - On failure: passes full CI output to LLM for fix instructions
- * - If management/ci.sh does not exist, quality gate does not run
- */
-export const StopQualityGatePlugin: Plugin = async (input) => {
-  const { worktree, directory, client } = input;
-  const rootDir = resolveRootDir({ worktree, directory });
-
-  // Skip quality gate if no valid directory (e.g., global config with no project)
-  if (!rootDir || rootDir === '' || rootDir === '/') {
-    return {};
-  }
-
-  // Create quality gate hooks
-  let qualityGateHooks: Partial<Hooks> = {};
-  try {
-    qualityGateHooks = await createQualityGateHooks(input);
-  } catch (error) {
-    await log(client, 'error', 'quality-gate.init-error', {
-      error: String(error),
-    });
-  }
-
-  return {
-    ...qualityGateHooks,
-  };
-};
-
-// Default export for OpenCode plugin discovery
-export default StopQualityGatePlugin;
-
-// Export types for consumers who want to use them
-export type {
-  QualityGateConfig,
-  CommandStep,
-  StepResult,
-  SessionState,
-  PackageManager,
-} from './types';

package/src/output.test.ts

@@ -1,233 +0,0 @@
-/**
- * Unit tests for output module
- *
- * Tests focus on pure functions:
- * - extractErrorLines: extracts error-like lines from command output
- * - tailLines: returns last N lines with truncation notice
- */
-
-import { extractErrorLines, tailLines } from './output';
-
-describe('extractErrorLines', () => {
-  it('should return empty array for empty input', () => {
-    expect(extractErrorLines('', 10)).toEqual([]);
-  });
-
-  it('should return empty array when no errors found', () => {
-    const output = `
-Build started
-Compiling modules...
-Build completed successfully
-`;
-    expect(extractErrorLines(output, 10)).toEqual([]);
-  });
-
-  it('should extract lines containing "error"', () => {
-    const output = `
-Starting build
-error: Cannot find module 'missing'
-Build failed
-`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.includes('error:'))).toBe(true);
-  });
-
-  it('should extract lines containing "Error" (case insensitive)', () => {
-    const output = `
-Running tests
-TypeError: undefined is not a function
-  at test.js:10:5
-`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.includes('TypeError'))).toBe(true);
-  });
-
-  it('should extract lines containing "failed"', () => {
-    const output = `
-Test suite: MyTests
-Test failed: should work correctly
-1 test failed
-`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.toLowerCase().includes('failed'))).toBe(true);
-  });
-
-  it('should extract lines containing "FAILED"', () => {
-    const output = `
-Running: test_function
-FAILED test_function - assertion error
-`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.includes('FAILED'))).toBe(true);
-  });
-
-  it('should extract lines containing "panic"', () => {
-    const output = `
-thread 'main' panicked at 'assertion failed'
-note: run with RUST_BACKTRACE=1
-`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.includes('panic'))).toBe(true);
-  });
-
-  it('should extract lines containing "exception"', () => {
-    const output = `
-Exception in thread "main" java.lang.NullPointerException
-  at Main.main(Main.java:5)
-`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.includes('Exception'))).toBe(true);
-  });
-
-  it('should extract lines containing "traceback"', () => {
-    const output = `
-Traceback (most recent call last):
-  File "test.py", line 10
-NameError: name 'x' is not defined
-`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.includes('Traceback'))).toBe(true);
-  });
-
-  it('should include 2 lines of context after error', () => {
-    const output = `line1
-error: something went wrong
-context line 1
-context line 2
-line5`;
-    const result = extractErrorLines(output, 10);
-    expect(result).toContain('error: something went wrong');
-    expect(result).toContain('context line 1');
-    expect(result).toContain('context line 2');
-  });
-
-  it('should respect maxLines limit', () => {
-    const output = `
-error: first error
-context1
-context2
-error: second error
-context3
-context4
-error: third error
-context5
-context6
-`;
-    const result = extractErrorLines(output, 5);
-    expect(result.length).toBeLessThanOrEqual(5);
-  });
-
-  it('should handle error at end of output without enough context lines', () => {
-    const output = `line1
-line2
-error: final error`;
-    const result = extractErrorLines(output, 10);
-    expect(result).toContain('error: final error');
-  });
-
-  it('should extract ReferenceError', () => {
-    const output = `ReferenceError: x is not defined`;
-    const result = extractErrorLines(output, 10);
-    expect(result).toContain('ReferenceError: x is not defined');
-  });
-
-  it('should extract SyntaxError', () => {
-    const output = `SyntaxError: Unexpected token '}'`;
-    const result = extractErrorLines(output, 10);
-    expect(result).toContain("SyntaxError: Unexpected token '}'");
-  });
-
-  it('should extract ERR! (npm style errors)', () => {
-    const output = `npm ERR! code ENOENT
-npm ERR! path /app/package.json`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.includes('ERR!'))).toBe(true);
-  });
-
-  it('should extract FAIL (test runner style)', () => {
-    const output = `FAIL src/test.ts
-  Test suite failed to run`;
-    const result = extractErrorLines(output, 10);
-    expect(result.some((line) => line.includes('FAIL'))).toBe(true);
-  });
-
-  it('should extract multiple error types in same output', () => {
-    const output = `
-Starting build...
-error: Build failed
-TypeError: Cannot read property 'x'
-FAILED: test_something
-Build process ended
-`;
-    const result = extractErrorLines(output, 20);
-    expect(result.some((line) => line.includes('error:'))).toBe(true);
-    expect(result.some((line) => line.includes('TypeError'))).toBe(true);
-    expect(result.some((line) => line.includes('FAILED'))).toBe(true);
-  });
-});
-
-describe('tailLines', () => {
-  it('should return full output when lines count is less than maxLines', () => {
-    const output = 'line1\nline2\nline3';
-    expect(tailLines(output, 10)).toBe(output);
-  });
-
-  it('should return full output when lines count equals maxLines', () => {
-    const output = 'line1\nline2\nline3';
-    expect(tailLines(output, 3)).toBe(output);
-  });
-
-  it('should truncate and add notice when output exceeds maxLines', () => {
-    const output = 'line1\nline2\nline3\nline4\nline5';
-    const result = tailLines(output, 3);
-    expect(result).toContain('... (2 lines truncated)');
-    expect(result).toContain('line3');
-    expect(result).toContain('line4');
-    expect(result).toContain('line5');
-    expect(result).not.toContain('line1');
-    expect(result).not.toContain('line2');
-  });
-
-  it('should handle single line output', () => {
-    const output = 'single line';
-    expect(tailLines(output, 5)).toBe('single line');
-  });
-
-  it('should handle empty output', () => {
-    expect(tailLines('', 5)).toBe('');
-  });
-
-  it('should handle maxLines of 1', () => {
-    const output = 'line1\nline2\nline3';
-    const result = tailLines(output, 1);
-    expect(result).toContain('... (2 lines truncated)');
-    expect(result).toContain('line3');
-  });
-
-  it('should correctly count truncated lines', () => {
-    const lines = Array.from({ length: 100 }, (_, i) => `line${i + 1}`);
-    const output = lines.join('\n');
-    const result = tailLines(output, 10);
-    expect(result).toContain('... (90 lines truncated)');
-  });
-
-  it('should preserve line content in tail', () => {
-    const output = 'first\nsecond\nthird\nfourth\nfifth';
-    const result = tailLines(output, 2);
-    const resultLines = result.split('\n');
-    expect(resultLines[resultLines.length - 1]).toBe('fifth');
-    expect(resultLines[resultLines.length - 2]).toBe('fourth');
-  });
-
-  it('should handle output with empty lines', () => {
-    const output = 'line1\n\nline3\n\nline5';
-    const result = tailLines(output, 3);
-    expect(result).toContain('... (2 lines truncated)');
-  });
-
-  it('should handle output with only newlines', () => {
-    const output = '\n\n\n\n';
-    const result = tailLines(output, 2);
-    expect(result).toContain('... (3 lines truncated)');
-  });
-});