@syntesseraai/opencode-feature-factory 0.10.7 → 0.10.8

package/dist/workflow/gate-evaluator.d.ts

@@ -18,6 +18,7 @@ export declare function evaluatePlanningGate(consensus: ConsensusPlan): GateResu
  * Evaluate the review approval gate.
  *
  * - confidence >=95 AND unresolvedIssues == 0 → APPROVED
+ * - vacuous review (0 issues, 0 action items) → APPROVED (nothing to fix)
  * - iteration >= maxIterations → ESCALATE
  * - otherwise → REWORK
  */
@@ -26,6 +27,7 @@ export declare function evaluateReviewGate(synthesis: ReviewSynthesis, iteration
  * Evaluate the documentation approval gate.
  *
  * - confidence >95, no change requested, 0 unresolved → APPROVED
+ * - vacuous review (0 issues, 0 action items) → APPROVED (nothing to fix)
  * - iteration >= maxIterations → ESCALATE
  * - otherwise → REWORK
  */
@@ -34,6 +36,7 @@ export declare function evaluateDocGate(review: DocReview, iteration: number, ma
  * Evaluate the mini-loop implementation gate.
  *
  * - confidence >95, no change requested, 0 blocking issues → APPROVED
+ * - vacuous review (0 issues, 0 action items) → APPROVED (nothing to fix)
  * - iteration >= maxIterations → ESCALATE
  * - otherwise → REWORK
  */

package/dist/workflow/gate-evaluator.js

@@ -12,6 +12,23 @@ function formatActionItems(actionItems) {
     return actionItems.map((item, index) => `${index + 1}. ${item}`).join('\n');
 }
 // ---------------------------------------------------------------------------
+// Vacuous review detection
+// ---------------------------------------------------------------------------
+/**
+ * Detect whether a review is "vacuous" — the reviewer produced no
+ * substantive feedback.  This happens when the LLM returns no
+ * structured fields or an empty review: confidence falls back to 0,
+ * unresolvedIssues is 0, and there are no real action items.
+ *
+ * When a review is vacuous the gate should auto-approve rather than
+ * triggering an infinite rework loop with no actionable feedback.
+ */
+function isVacuousReview(unresolvedIssues, stageOutput) {
+    return (unresolvedIssues === 0 &&
+        stageOutput.actionItems.length === 0 &&
+        stageOutput.issues.length === 0);
+}
+// ---------------------------------------------------------------------------
 // Planning gate
 // ---------------------------------------------------------------------------
 /**
@@ -43,6 +60,7 @@ export function evaluatePlanningGate(consensus) {
  * Evaluate the review approval gate.
  *
  * - confidence >=95 AND unresolvedIssues == 0 → APPROVED
+ * - vacuous review (0 issues, 0 action items) → APPROVED (nothing to fix)
  * - iteration >= maxIterations → ESCALATE
  * - otherwise → REWORK
  */
@@ -50,6 +68,9 @@ export function evaluateReviewGate(synthesis, iteration, maxIterations = 10) {
     if (synthesis.overallConfidence >= 95 && synthesis.unresolvedIssues === 0) {
         return { decision: 'APPROVED' };
     }
+    if (isVacuousReview(synthesis.unresolvedIssues, synthesis.stageOutput)) {
+        return { decision: 'APPROVED' };
+    }
     if (iteration >= maxIterations) {
         return {
             decision: 'ESCALATE',
@@ -73,6 +94,7 @@ export function evaluateReviewGate(synthesis, iteration, maxIterations = 10) {
  * Evaluate the documentation approval gate.
  *
  * - confidence >95, no change requested, 0 unresolved → APPROVED
+ * - vacuous review (0 issues, 0 action items) → APPROVED (nothing to fix)
  * - iteration >= maxIterations → ESCALATE
  * - otherwise → REWORK
  */
@@ -80,6 +102,9 @@ export function evaluateDocGate(review, iteration, maxIterations = 5) {
     if (review.verdict === 'APPROVED' && review.unresolvedIssues === 0 && review.confidence > 95) {
         return { decision: 'APPROVED' };
     }
+    if (isVacuousReview(review.unresolvedIssues, review.stageOutput)) {
+        return { decision: 'APPROVED' };
+    }
     if (iteration >= maxIterations) {
         return {
             decision: 'ESCALATE',
@@ -103,6 +128,7 @@ export function evaluateDocGate(review, iteration, maxIterations = 5) {
  * Evaluate the mini-loop implementation gate.
  *
  * - confidence >95, no change requested, 0 blocking issues → APPROVED
+ * - vacuous review (0 issues, 0 action items) → APPROVED (nothing to fix)
  * - iteration >= maxIterations → ESCALATE
  * - otherwise → REWORK
  */
@@ -110,6 +136,9 @@ export function evaluateMiniLoopImplGate(review, iteration, maxIterations = 10)
     if (review.confidence > 95 && !review.changeRequested && review.unresolvedIssues === 0) {
         return { decision: 'APPROVED' };
     }
+    if (isVacuousReview(review.unresolvedIssues, review.stageOutput)) {
+        return { decision: 'APPROVED' };
+    }
     if (iteration >= maxIterations) {
         return {
             decision: 'ESCALATE',

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@syntesseraai/opencode-feature-factory",
-  "version": "0.10.7",
+  "version": "0.10.8",
   "type": "module",
   "description": "OpenCode plugin for Feature Factory agents - provides sub-agents and skills for validation, review, security, and architecture assessment",
   "license": "MIT",