@syntesseraai/opencode-feature-factory 0.1.9 → 0.1.11

package/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@syntesseraai/opencode-feature-factory",
-  "version": "0.1.9",
+  "version": "0.1.11",
   "description": "OpenCode plugin for Feature Factory agents - provides planning, implementation, review, testing, and validation agents",
   "type": "module",
   "license": "MIT",
@@ -31,4 +31,4 @@
     "@types/node": "^22.0.0",
     "typescript": "^5.0.0"
   }
-}
+}

package/src/stop-quality-gate.ts

@@ -22,6 +22,10 @@ interface ExtendedSessionState extends SessionState {
   qualityGatePassed: boolean;
   /** Debounce timer for session.idle */
   idleDebounce: ReturnType<typeof setTimeout> | null;
+  /** Parent session ID (if this is a sub-agent session) */
+  parentID?: string;
+  /** Whether this session is read-only (edit or bash denied). undefined = not yet determined */
+  isReadOnly?: boolean;
 }
 
 const sessions = new Map<string, ExtendedSessionState>();
@@ -41,6 +45,28 @@ function getSessionState(sessionId: string): ExtendedSessionState {
   return state;
 }
 
+// ============================================================================
+// Permission Helpers
+// ============================================================================
+
+/** Permission rule structure from OpenCode SDK */
+interface PermissionRule {
+  permission: string;
+  pattern: string;
+  action: 'allow' | 'deny' | 'ask';
+}
+
+/**
+ * Check if a session is read-only based on its permission rules.
+ * A session is considered read-only if either 'edit' or 'bash' permission is denied.
+ */
+function isSessionReadOnly(permission?: PermissionRule[]): boolean {
+  if (!permission) return false;
+  return permission.some(
+    (rule) => (rule.permission === 'edit' || rule.permission === 'bash') && rule.action === 'deny'
+  );
+}
+
 // ============================================================================
 // Global Execution Lock
 // ============================================================================
@@ -309,6 +335,40 @@ export async function createQualityGateHooks(input: PluginInput): Promise<Partia
   const cacheSeconds = qualityGate.cacheSeconds ?? DEFAULT_QUALITY_GATE.cacheSeconds;
   const cwd = qualityGate.cwd ? `${directory}/${qualityGate.cwd}` : directory;
 
+  /**
+   * Ensure session metadata (parentID, isReadOnly) is populated.
+   * Fetches from API if not already known (fallback for late-started plugin).
+   */
+  async function ensureSessionMetadata(
+    sessionId: string,
+    state: ExtendedSessionState
+  ): Promise<void> {
+    // Already have metadata
+    if (state.isReadOnly !== undefined) return;
+
+    try {
+      const response = await client.session.get({ path: { id: sessionId } });
+      if (response.data) {
+        state.parentID = response.data.parentID;
+        // Cast to access permission field (available in API but not in v1 SDK types)
+        const permission = (response.data as { permission?: PermissionRule[] }).permission;
+        state.isReadOnly = isSessionReadOnly(permission);
+        await log(client, 'debug', 'session.metadata-fetched', {
+          sessionId,
+          parentID: state.parentID,
+          isReadOnly: state.isReadOnly,
+        });
+      }
+    } catch (err) {
+      // If fetch fails, default to running quality gate (current behavior)
+      state.isReadOnly = false;
+      await log(client, 'warn', 'session.metadata-fetch-failed', {
+        sessionId,
+        error: String(err),
+      });
+    }
+  }
+
   /**
    * Run the quality gate checks for a session.
    * Uses a global lock to prevent concurrent executions.
@@ -432,6 +492,25 @@ export async function createQualityGateHooks(input: PluginInput): Promise<Partia
         sessionId,
         steps: results.map((r) => r.step),
       });
+
+      // Show success feedback to user
+      await client.session.prompt({
+        path: { id: sessionId },
+        body: {
+          parts: [
+            {
+              type: 'text',
+              text: `## ✅ Quality gate passed
+
+All quality checks completed successfully:
+
+${results.map((r) => `- **${r.step}**: ✓`).join('\n')}
+
+Your work meets the quality standards and is ready to proceed.`,
+            },
+          ],
+        },
+      });
     } finally {
       // Always release the lock and trigger next queued session
       const nextSession = releaseLock(sessionId);
@@ -460,15 +539,33 @@ export async function createQualityGateHooks(input: PluginInput): Promise<Partia
       const eventProps = (event as { properties?: { sessionID?: string } }).properties;
       const sessionId = eventProps?.sessionID;
 
-      if (event.type === 'session.created' && sessionId) {
-        sessions.set(sessionId, {
-          lastRunAt: 0,
-          lastResults: [],
-          dirty: true,
-          qualityGatePassed: false,
-          idleDebounce: null,
-        });
-        await log(client, 'debug', 'session.created', { sessionId });
+      if (event.type === 'session.created') {
+        // Extract full session info from the event
+        const sessionInfo = (
+          event as {
+            properties?: {
+              info?: { id: string; parentID?: string; permission?: PermissionRule[] };
+            };
+          }
+        ).properties?.info;
+        const id = sessionInfo?.id;
+        if (id) {
+          const isReadOnly = isSessionReadOnly(sessionInfo?.permission);
+          sessions.set(id, {
+            lastRunAt: 0,
+            lastResults: [],
+            dirty: true,
+            qualityGatePassed: false,
+            idleDebounce: null,
+            parentID: sessionInfo?.parentID,
+            isReadOnly,
+          });
+          await log(client, 'debug', 'session.created', {
+            sessionId: id,
+            parentID: sessionInfo?.parentID,
+            isReadOnly,
+          });
+        }
       }
 
       if (event.type === 'session.deleted' && sessionId) {
@@ -490,6 +587,24 @@ export async function createQualityGateHooks(input: PluginInput): Promise<Partia
           return;
         }
 
+        // Ensure we have session metadata (fetch if needed for late-started plugin)
+        await ensureSessionMetadata(sessionId, state);
+
+        // Skip quality gate for sub-agent sessions (sessions with a parent)
+        if (state.parentID) {
+          await log(client, 'debug', 'quality-gate.skipped (sub-agent session)', {
+            sessionId,
+            parentID: state.parentID,
+          });
+          return;
+        }
+
+        // Skip quality gate for read-only sessions (edit or bash denied)
+        if (state.isReadOnly) {
+          await log(client, 'debug', 'quality-gate.skipped (read-only session)', { sessionId });
+          return;
+        }
+
         // Debounce to avoid running multiple times
         if (state.idleDebounce) {
           clearTimeout(state.idleDebounce);