@synity/bitrix-skills 1.3.2 → 1.3.3

package/CHANGELOG.md

@@ -1,20 +1,10 @@
 # Changelog
 
-## 1.3.2
-
-### Patch Changes
-
-- Restore `--all` flag on `install` command and fix non-TTY safety guard. Both behaviors were dropped in 1.3.0 cleanup but remained under test contract — `install --all` previously errored with "unknown option", and CI runs would silently bulk-install everything. Also repairs `sync-assets.mjs` so test/build pipelines populate `assets/scripts/` correctly after the single-repo migration.
-
 ## 1.3.1
 
 ### Patch Changes
 
-- dfe3549: fix: mark stub features (bx, bx-calendar, bx-crm) as `planned`
-
-  Previously these features had `status: "active"` in feature.json but no install handler wired into `src/commands/install.ts`, causing `install --all` to print `! No install handler for feature: <name>` for each.
-
-  Now they're filtered out by the existing `f.status !== 'planned'` check (install.ts:121). Will flip back to `active` when install handlers land.
+- bx-crm: add optional deal products flow to onboard.md — findProducts → setDealProducts after createDealWithParties. Fix findProducts param (query→name), document substring keyword behavior, note Commerce catalog scope requirement.
 
 ## 1.3.0
 

package/dist/cli.js

@@ -1123,7 +1123,6 @@ var InstallCommand = class extends Command {
   });
   key = Option.String("--key", { description: "License key to unlock paid tier features" });
   featuresFlag = Option.String("--features", { description: "Comma-separated feature names" });
-  all = Option.Boolean("--all", false, { description: "Install all installable features (required in non-TTY)" });
   featureArgs = Option.Rest({ required: 0 });
   async execute() {
     const cwd = process.cwd();
@@ -1163,13 +1162,8 @@ var InstallCommand = class extends Command {
       selectedNames = this.featuresFlag.split(",").map((s) => s.trim()).filter(Boolean);
     } else if (this.featureArgs.length > 0) {
       selectedNames = this.featureArgs;
-    } else if (this.all || process.stdin.isTTY) {
-      selectedNames = installable.map((f) => f.name);
     } else {
-      this.context.stderr.write(
-        chalk.red("Refusing to install in non-TTY without explicit selection.\n") + chalk.gray("  Pass --all, --features <csv>, or feature names as positional args.\n")
-      );
-      return 1;
+      selectedNames = installable.map((f) => f.name);
     }
     const availableNames = new Set(available.map((f) => f.name));
     const invalid = selectedNames.filter((n) => !availableNames.has(n));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@synity/bitrix-skills",
-  "version": "1.3.2",
+  "version": "1.3.3",
   "description": "Multi-feature Bitrix24 tooling CLI for Synity projects",
   "type": "module",
   "bin": {
@@ -47,22 +47,15 @@
   },
   "devDependencies": {
     "@changesets/cli": "^2.31.0",
-    "@eslint/js": "^9.39.4",
     "@types/node": "^20.0.0",
-    "@typescript-eslint/eslint-plugin": "^8.59.3",
-    "@typescript-eslint/parser": "^8.59.3",
-    "eslint": "^9.39.4",
-    "globals": "^17.6.0",
     "tsup": "^8.0.0",
     "typescript": "^5.4.0",
-    "typescript-eslint": "^8.59.3",
     "vitest": "^2.1.0"
   },
   "scripts": {
     "prebuild": "node scripts/prebuild-bash-sync.mjs && node scripts/sync-assets.mjs",
     "build": "tsup --config tsup.config.ts",
     "dev": "tsup --config tsup.config.ts --watch",
-    "pretest": "node scripts/prebuild-bash-sync.mjs && node scripts/sync-assets.mjs",
     "test": "vitest run",
     "test:watch": "vitest",
     "lint": "eslint src --ext .ts",

package/src/features/bx/feature.json

@@ -4,7 +4,6 @@
   "version": "1.0.0",
   "target": "global",
   "description": "Claude Code hub skill \u2014 routes to bx:crm, bx:task, bx:calendar. Install for discovery UX.",
-  "status": "planned",
   "requires": {},
   "tier": 0
 }

package/src/features/bx-calendar/feature.json

@@ -4,7 +4,6 @@
   "version": "1.0.0",
   "target": "global",
   "description": "Claude Code skill for Bitrix24 Calendar: meetings, reminders, team availability, CRM activity sync",
-  "status": "planned",
   "requires": {
     "env": [
       "BITRIX_WEBHOOK_URL"

package/src/features/bx-crm/assets/SKILL.md

@@ -15,7 +15,7 @@ Use this skill for CRM entities only: contacts, companies, deals, leads, estimat
 
 | User intent | Load file | Key helpers |
 |---|---|---|
-| create/update contact, company, deal, lead | `onboard.md` | `upsertContact`, `upsertCompanyByTaxCode`, `createDealWithParties` |
+| create/update contact, company, deal, lead | `onboard.md` | `upsertContact`, `upsertCompanyByTaxCode`, `createDealWithParties`, `setDealProducts`, `findProducts` |
 | VN phone, honorific, address, MST format | `vn-norms.md` | normalization rules |
 | convert/qualify lead to deal | `convert.md` | `convertLeadToDeal` |
 | estimate, báo giá, invoice, payment link | `commerce.md` | `createEstimate`, `approveEstimate`, `createSmartInvoice` |

package/src/features/bx-crm/assets/onboard.md

@@ -69,6 +69,42 @@ Timeline: <start date>
 Notes: <context>
 ```
 
+## Deal — Optional Products
+
+Add products only when the user explicitly mentions product names or asks for products on the deal.
+
+```js
+// 1. Extract short keyword (1-2 words) from user's product name — do NOT pass full name
+// name = substring match; "%keyword%" wildcard syntax breaks the param
+const matches = await findProducts({ name: "<short keyword>", limit: 5 })
+// → [{ id, name, sku, price, currency, vatRate, matched }]
+
+// 2. Confirm match with user if multiple or ambiguous results
+// 3. Add to deal (currency omitted — Bitrix inherits from deal)
+await setDealProducts({
+  dealId,
+  items: [{ productId: matches[0].id, price: matches[0].price, quantity: 1 }],
+  mode: "replace"
+})
+```
+
+**MCP gap fallback** — use only when `setDealProducts` is absent from `codemode.catalog()`:
+```js
+codemode.request({
+  method: "POST",
+  path: "/crm.deal.productrows.set",
+  body: { id: dealId, rows: [{ PRODUCT_ID: id, PRICE: price, QUANTITY: quantity }] }
+})
+```
+
+**Rules:**
+- Products are optional — add only when user mentions specific product names.
+- Always `findProducts` to resolve name → id; never hardcode `PRODUCT_ID`.
+- Pass a short keyword (1-2 words) to `findProducts({ name })`, not the full product name.
+- Omit `currency` in items — Bitrix inherits it from the deal automatically.
+- Custom line items (no catalog id): pass `{ name, price, quantity }` without `id`.
+- Commerce catalog variants (SKU variants) require `catalog` scope on the MCP token; if 401, fall back to custom line item and note the MCP gap.
+
 ## Lead — Create + Products
 
 Use lead when the prospect is unqualified or missing deal-level budget/timeline.
@@ -129,6 +165,7 @@ Omit `idempotencyKey`. **Verified 2026-05-15:** D1 table `idempotency_keys` miss
 - [ ] Contact: VN phone stored with `+84`; HONORIFIC matches [vn-norms.md](./vn-norms.md).
 - [ ] Company: `RQ_VAT_ID` populated, address entity exists, MST format valid.
 - [ ] Deal: `STAGE_ID` set, `OPPORTUNITY > 0`, payer linked.
+- [ ] Deal (with products): products set; `OPPORTUNITY` matches product total.
 - [ ] Lead: `SOURCE_ID` set, phone/email present, products set when user requested products.
 - [ ] Update: only intended fields changed.
 

package/src/features/bx-crm/feature.json

@@ -4,7 +4,6 @@
   "version": "2.0.0",
   "target": "global",
   "description": "Claude Code skill for Bitrix24 CRM: contacts, companies, deals, leads, estimates, invoices, customer analysis, pipeline reports",
-  "status": "planned",
   "requires": {
     "mcp": [
       "bitrix-synity-mcp"

package/src/features/task-sync/assets/skill/SKILL.md

@@ -1,173 +0,0 @@
----
-name: bitrix-sync-install
-description: |
-  Install Bitrix Task Sync vào brownfield project (existing repo).
-  Wraps `npx @synity/bitrix-task-sync` với interactive TASK_ID setup,
-  webhook env var detection, và live verify smoke test.
-
-  Use when:
-  - User says "install bitrix sync", "setup task tracking", "thêm bitrix sync vào dự án"
-  - User asks how to enable AI session sync to Bitrix24 task chat
-  - Brownfield project not scaffolded by `create-bitrix-app`
-tools: [Bash, Read, Edit, AskUserQuestion]
----
-
-# /bitrix-sync-install — Install Bitrix Task Sync (interactive)
-
-Orchestrate installation of [@synity/bitrix-task-sync](https://www.npmjs.com/package/@synity/bitrix-task-sync) into the current project. **Skill = thin wrapper** — all file copy / settings merge / githook setup is delegated to the npm CLI. Skill only handles interactive bits CLI cannot do (CLAUDE.md edit, env var detection, user confirmation gates).
-
-## Workflow (7 steps with user confirmation)
-
-### Step 1 — Detect project state
-
-Run via Bash to inspect current dir:
-
-```bash
-pwd && ls -la .claude .githooks docs CLAUDE.md 2>/dev/null
-```
-
-Show user what already exists. **Decision:**
-- If `.claude/scripts/bitrix-*.sh` already exists → skip to Step 7 (verify only)
-- Else → proceed Step 2
-
-### Step 2 — Preflight check
-
-Confirm bash deps present:
-
-```bash
-command -v jq && command -v curl && command -v awk && echo "OK"
-```
-
-If any missing → abort, instruct user to install (`brew install jq` on macOS).
-
-### Step 3 — Dry-run install
-
-```bash
-npx -y @synity/bitrix-skills install --dry-run
-```
-
-Show planned actions. **Always pin exact version** (never `@latest`).
-
-### Step 4 — Confirm + install
-
-Use `AskUserQuestion`:
-
-```
-Question: "Proceed with install? (review the dry-run plan above)"
-Options:
-  - "Yes, install" — runs `npx ... install`
-  - "No, abort" — exit skill
-```
-
-If yes:
-
-```bash
-npx -y @synity/bitrix-skills install
-```
-
-### Step 5 — TASK_ID setup
-
-Read `CLAUDE.md` (project root). Search for `TASK_ID:` pattern.
-
-**Missing case:**
-1. `AskUserQuestion` for `PORTAL` URL (e.g. `https://yourname.bitrix24.com`)
-2. `AskUserQuestion` for `TASK_ID` (numeric task ID from Bitrix24 task URL)
-3. Validate `TASK_ID` is numeric (reject `1234abc`)
-4. Use `Edit` to insert at end of CLAUDE.md:
-
-```markdown
-
-## Bitrix Task
-
-PORTAL: {portal_url}
-TASK_ID: {task_id}
-
-<!-- AI session activity auto-syncs to this task via .claude/scripts/bitrix-*.sh hooks -->
-<!-- See docs/bitrix-task-sync.md for setup details -->
-```
-
-**Present case:** display existing TASK_ID + ask user to confirm or update.
-
-### Step 6 — Webhook env var
-
-Check current shell env:
-
-```bash
-[ -n "$BITRIX_WEBHOOK_URL" ] && echo SET || echo UNSET
-```
-
-If `UNSET`, `AskUserQuestion`:
-
-```
-Question: "Where to add BITRIX_WEBHOOK_URL?"
-Options:
-  - ".envrc (direnv)"
-  - "~/.zshrc"
-  - "~/.bashrc"
-  - "Skip — I'll do it manually"
-```
-
-Print the exact `export` command. Wait for user to confirm they ran `source <file>` (or restarted shell). **NEVER auto-edit shell rc files** — could conflict with user's setup.
-
-Example output:
-```
-Add this line to ~/.zshrc:
-  export BITRIX_WEBHOOK_URL="https://yourname.bitrix24.com/rest/USER_ID/TOKEN/"
-Then run: source ~/.zshrc
-
-(Press confirm when done)
-```
-
-### Step 7 — Verify
-
-```bash
-npx -y @synity/bitrix-skills verify
-```
-
-Interpret exit codes:
-
-| Code | Meaning | User Action |
-|------|---------|-------------|
-| 0 | Success — comment posted | Done. |
-| 1 | TASK_ID missing in CLAUDE.md | Re-run Step 5 |
-| 2 | BITRIX_WEBHOOK_URL not set | Re-run Step 6 |
-| 3 | Webhook call failed (network/token error) | Verify webhook URL is correct + has perms |
-| 4 | Manifest drift detected | Run `npx @synity/bitrix-task-sync update` to repair |
-
-## Final summary
-
-On success, print:
-
-```
-✓ Bitrix Task Sync installed and verified
-
-Next: every commit must include [B24:{TASK_ID}] tag, e.g.:
-  feat: implement deal sync [B24:{task_id}]
-
-AI activity (skills) auto-syncs to: {portal_url}/company/personal/user/USER/tasks/task/view/{task_id}/
-```
-
-## Failure modes
-
-| Symptom | Likely cause | Fix |
-|---------|--------------|-----|
-| `command not found: jq` | macOS without homebrew | `brew install jq curl` |
-| `npx: not found` | Node not installed | Install Node 20+ from nodejs.org |
-| `git: not a repository` | Not in git repo | `git init` first |
-| Webhook returns 401 | Bad token | Regenerate webhook in Bitrix24 → Apps → Webhooks |
-| `TASK_ID: 1234abc` rejected | Non-numeric value | Use ID from task URL, e.g. `12345` |
-
-## Re-run behavior
-
-Re-running on already-installed project:
-- Step 1 detects existing `.claude/scripts/bitrix-*.sh`
-- Skips to Step 7 (verify only)
-- If verify passes → "Already installed and working"
-- If verify fails → suggests `update` command
-
-## Notes
-
-- **Pin version**: every `npx` example uses `@0.1.0` exact pin. Never `@latest`. User must explicitly bump after reading CHANGELOG.
-- **Project-scope only**: skill operates on current cwd's git root. Does NOT touch other projects.
-- **Idempotent**: re-run = no-op if state is good.
-- **No secrets logged**: skill never echoes `BITRIX_WEBHOOK_URL` value, only its set/unset status.