@synergenius/flow-weaver 0.23.3 → 0.23.5

package/dist/cli/flow-weaver.mjs

@@ -9886,7 +9886,7 @@ var VERSION;
 var init_generated_version = __esm({
   "src/generated-version.ts"() {
     "use strict";
-    VERSION = "0.23.3";
+    VERSION = "0.23.5";
   }
 });
 
@@ -11198,6 +11198,15 @@ function generateControlFlowWithExecutionContext(workflow, nodeTypes, isAsync2,
       }
     }
   });
+  const topLevelSuccessFlags = /* @__PURE__ */ new Set();
+  branchRegions.forEach((region, nodeId) => {
+    if (region.successNodes.size > 0 || region.failureNodes.size > 0) {
+      const safeId = toValidIdentifier(nodeId);
+      lines.push(`  let ${safeId}_success = false;`);
+      topLevelSuccessFlags.add(safeId);
+      hasLetDeclarations = true;
+    }
+  });
   if (hasLetDeclarations) {
     lines.push("");
   }
@@ -11417,7 +11426,8 @@ function generateControlFlowWithExecutionContext(workflow, nodeTypes, isAsync2,
           "ctx",
           bundleMode,
           branchingNodesNeedingSuccessFlag,
-          production
+          production,
+          topLevelSuccessFlags
         );
         if (chainNeedsClose) {
           lines.push(`  }`);
@@ -11426,6 +11436,8 @@ function generateControlFlowWithExecutionContext(workflow, nodeTypes, isAsync2,
       }
       let branchIndent = "  ";
       let branchNeedsClose = false;
+      const nodeRegion = branchRegions.get(instanceId);
+      const promotedPreDeclared = new Set(topLevelSuccessFlags);
       if (nodesPromotedFromBranches.has(instanceId)) {
         const stepSourceConditions = [];
         workflow.connections.forEach((conn) => {
@@ -11448,7 +11460,7 @@ function generateControlFlowWithExecutionContext(workflow, nodeTypes, isAsync2,
         nodeType,
         workflow,
         nodeTypes,
-        branchRegions.get(instanceId),
+        nodeRegion,
         availableVars,
         generatedNodes,
         lines,
@@ -11459,8 +11471,8 @@ function generateControlFlowWithExecutionContext(workflow, nodeTypes, isAsync2,
         isAsync2,
         "ctx",
         bundleMode,
-        /* @__PURE__ */ new Set(),
-        branchingNodesNeedingSuccessFlag.has(instanceId),
+        promotedPreDeclared,
+        branchingNodesNeedingSuccessFlag.has(instanceId) || topLevelSuccessFlags.has(toValidIdentifier(instanceId)),
         production
       );
       if (branchNeedsClose) {
@@ -11872,13 +11884,15 @@ function buildStepSourceCondition(sourceNode, sourcePort, branchingNodes) {
   }
   return `${safeNode}Idx !== undefined`;
 }
-function generateBranchingChainCode(chain, workflow, nodeTypes, branchingNodes, branchRegions, availableVars, generatedNodes, lines, indent, isAsync2, ctxVar, bundleMode, forceTrackSuccessNodes = /* @__PURE__ */ new Set(), production = false) {
-  const preDeclaredFlags = /* @__PURE__ */ new Set();
+function generateBranchingChainCode(chain, workflow, nodeTypes, branchingNodes, branchRegions, availableVars, generatedNodes, lines, indent, isAsync2, ctxVar, bundleMode, forceTrackSuccessNodes = /* @__PURE__ */ new Set(), production = false, alreadyDeclaredFlags = /* @__PURE__ */ new Set()) {
+  const preDeclaredFlags = new Set(alreadyDeclaredFlags);
   for (let i = 0; i < chain.length; i++) {
     const isLast = i === chain.length - 1;
-    if (!isLast || forceTrackSuccessNodes.has(chain[i])) {
-      const safeId = toValidIdentifier(chain[i]);
-      lines.push(`${indent}let ${safeId}_success = false;`);
+    const safeId = toValidIdentifier(chain[i]);
+    if (!isLast || forceTrackSuccessNodes.has(chain[i]) || alreadyDeclaredFlags.has(safeId)) {
+      if (!alreadyDeclaredFlags.has(safeId)) {
+        lines.push(`${indent}let ${safeId}_success = false;`);
+      }
       preDeclaredFlags.add(safeId);
     }
   }
@@ -11928,8 +11942,8 @@ function generateBranchingChainCode(chain, workflow, nodeTypes, branchingNodes,
       ctxVar,
       bundleMode,
       preDeclaredFlags,
-      !isLast || forceTrackSuccessNodes.has(chain[i]),
-      // forceTrackSuccess for non-last chain nodes or nodes with promoted dependents
+      !isLast || forceTrackSuccessNodes.has(chain[i]) || alreadyDeclaredFlags.has(safeId),
+      // forceTrackSuccess for non-last chain nodes, nodes with promoted dependents, or nodes with pre-declared flags
       production
     );
     generateScopedChildrenExecution(
@@ -12231,6 +12245,13 @@ function generateBranchingNodeCode(instance, branchNode, workflow, allNodeTypes,
       if (!nodeType) return;
       if (branchingNodes.has(instanceId2)) {
         const nestedRegion = branchRegions.get(instanceId2);
+        const nestedSafeId = toValidIdentifier(instanceId2);
+        const nestedHasDownstream = nestedRegion.successNodes.size > 0 || nestedRegion.failureNodes.size > 0;
+        const nestedPreDeclared = new Set(preDeclaredSuccessFlags);
+        if (nestedHasDownstream && !nestedPreDeclared.has(nestedSafeId)) {
+          lines.push(`${indent}  let ${nestedSafeId}_success = false;`);
+          nestedPreDeclared.add(nestedSafeId);
+        }
         generateBranchingNodeCode(
           inst,
           nodeType,
@@ -12247,8 +12268,9 @@ function generateBranchingNodeCode(instance, branchNode, workflow, allNodeTypes,
           isAsync2,
           ctxVar,
           bundleMode,
-          /* @__PURE__ */ new Set(),
-          false,
+          nestedPreDeclared,
+          nestedPreDeclared.has(nestedSafeId),
+          // force tracking if flag was pre-declared at higher scope
           production
         );
         successExecutedNodes.push(instanceId2);
@@ -12308,6 +12330,13 @@ function generateBranchingNodeCode(instance, branchNode, workflow, allNodeTypes,
         if (!nodeType) return;
         if (branchingNodes.has(instanceId2)) {
           const nestedRegion = branchRegions.get(instanceId2);
+          const nestedSafeId = toValidIdentifier(instanceId2);
+          const nestedHasDownstream = nestedRegion.successNodes.size > 0 || nestedRegion.failureNodes.size > 0;
+          const nestedPreDeclared = new Set(preDeclaredSuccessFlags);
+          if (nestedHasDownstream && !nestedPreDeclared.has(nestedSafeId)) {
+            lines.push(`${indent}  let ${nestedSafeId}_success = false;`);
+            nestedPreDeclared.add(nestedSafeId);
+          }
           generateBranchingNodeCode(
             inst,
             nodeType,
@@ -12324,8 +12353,9 @@ function generateBranchingNodeCode(instance, branchNode, workflow, allNodeTypes,
             isAsync2,
             ctxVar,
             bundleMode,
-            /* @__PURE__ */ new Set(),
-            false,
+            nestedPreDeclared,
+            nestedPreDeclared.has(nestedSafeId),
+            // force tracking if flag was pre-declared at higher scope
             production
           );
           failureExecutedNodes.push(instanceId2);
@@ -95923,7 +95953,7 @@ var {
 // src/cli/index.ts
 init_logger();
 init_error_utils();
-var version2 = true ? "0.23.3" : "0.0.0-dev";
+var version2 = true ? "0.23.5" : "0.0.0-dev";
 var program2 = new Command();
 program2.name("fw").description("Flow Weaver Annotations - Compile and validate workflow files").option("-v, --version", "Output the current version").option("--no-color", "Disable colors").option("--color", "Force colors").on("option:version", () => {
   logger.banner(version2);

package/dist/generated-version.d.ts

@@ -1,2 +1,2 @@
-export declare const VERSION = "0.23.3";
+export declare const VERSION = "0.23.5";
 //# sourceMappingURL=generated-version.d.ts.map

package/dist/generated-version.js

@@ -1,3 +1,3 @@
 // Auto-generated by scripts/generate-version.ts — do not edit manually
-export const VERSION = '0.23.3';
+export const VERSION = '0.23.5';
 //# sourceMappingURL=generated-version.js.map

package/dist/generator/unified.js

@@ -187,6 +187,19 @@ export function generateControlFlowWithExecutionContext(workflow, nodeTypes, isA
             }
         }
     });
+    // Pre-declare _success flags for branching nodes that have downstream nodes.
+    // These flags must be at the function's top level because downstream guards
+    // (promoted nodes, chain guards) may reference them outside the branch block
+    // where the branching node is generated.
+    const topLevelSuccessFlags = new Set();
+    branchRegions.forEach((region, nodeId) => {
+        if (region.successNodes.size > 0 || region.failureNodes.size > 0) {
+            const safeId = toValidIdentifier(nodeId);
+            lines.push(`  let ${safeId}_success = false;`);
+            topLevelSuccessFlags.add(safeId);
+            hasLetDeclarations = true;
+        }
+    });
     if (hasLetDeclarations) {
         lines.push('');
     }
@@ -410,7 +423,7 @@ export function generateControlFlowWithExecutionContext(workflow, nodeTypes, isA
                         chainNeedsClose = true;
                     }
                 }
-                generateBranchingChainCode(branchingChains.get(instanceId), workflow, nodeTypes, branchingNodes, branchRegions, availableVars, generatedNodes, lines, chainIndent, isAsync, 'ctx', bundleMode, branchingNodesNeedingSuccessFlag, production);
+                generateBranchingChainCode(branchingChains.get(instanceId), workflow, nodeTypes, branchingNodes, branchRegions, availableVars, generatedNodes, lines, chainIndent, isAsync, 'ctx', bundleMode, branchingNodesNeedingSuccessFlag, production, topLevelSuccessFlags);
                 if (chainNeedsClose) {
                     lines.push(`  }`);
                 }
@@ -420,6 +433,10 @@ export function generateControlFlowWithExecutionContext(workflow, nodeTypes, isA
             // For promoted branching nodes, wrap in STEP guard from execute port source
             let branchIndent = '  ';
             let branchNeedsClose = false;
+            // Pre-declare _success flag at the outer scope so downstream guards
+            // (which may run after the promoted guard block) can access it.
+            const nodeRegion = branchRegions.get(instanceId);
+            const promotedPreDeclared = new Set(topLevelSuccessFlags);
             if (nodesPromotedFromBranches.has(instanceId)) {
                 const stepSourceConditions = [];
                 workflow.connections.forEach((conn) => {
@@ -439,7 +456,7 @@ export function generateControlFlowWithExecutionContext(workflow, nodeTypes, isA
                     branchNeedsClose = true;
                 }
             }
-            generateBranchingNodeCode(instance, nodeType, workflow, nodeTypes, branchRegions.get(instanceId), availableVars, generatedNodes, lines, branchIndent, false, branchingNodes, branchRegions, isAsync, 'ctx', bundleMode, new Set(), branchingNodesNeedingSuccessFlag.has(instanceId), production);
+            generateBranchingNodeCode(instance, nodeType, workflow, nodeTypes, nodeRegion, availableVars, generatedNodes, lines, branchIndent, false, branchingNodes, branchRegions, isAsync, 'ctx', bundleMode, promotedPreDeclared, branchingNodesNeedingSuccessFlag.has(instanceId) || topLevelSuccessFlags.has(toValidIdentifier(instanceId)), production);
             if (branchNeedsClose) {
                 lines.push(`  }`);
             }
@@ -860,16 +877,19 @@ function buildStepSourceCondition(sourceNode, sourcePort, branchingNodes) {
  *   if (A_success) { B code } else { CANCELLED for B,C and regions }
  *   if (A_success && B_success) { C code } else { CANCELLED for C and regions }
  */
-function generateBranchingChainCode(chain, workflow, nodeTypes, branchingNodes, branchRegions, availableVars, generatedNodes, lines, indent, isAsync, ctxVar, bundleMode, forceTrackSuccessNodes = new Set(), production = false) {
+function generateBranchingChainCode(chain, workflow, nodeTypes, branchingNodes, branchRegions, availableVars, generatedNodes, lines, indent, isAsync, ctxVar, bundleMode, forceTrackSuccessNodes = new Set(), production = false, alreadyDeclaredFlags = new Set()) {
     // Pre-declare success flags for all non-last chain nodes so they're
     // accessible across guard blocks (avoiding let-in-block scoping issues).
     // Also pre-declare for the last node if promoted nodes depend on its _success flag.
-    const preDeclaredFlags = new Set();
+    // Skip flags already declared at a higher scope (e.g. function top-level).
+    const preDeclaredFlags = new Set(alreadyDeclaredFlags);
     for (let i = 0; i < chain.length; i++) {
         const isLast = i === chain.length - 1;
-        if (!isLast || forceTrackSuccessNodes.has(chain[i])) {
-            const safeId = toValidIdentifier(chain[i]);
-            lines.push(`${indent}let ${safeId}_success = false;`);
+        const safeId = toValidIdentifier(chain[i]);
+        if (!isLast || forceTrackSuccessNodes.has(chain[i]) || alreadyDeclaredFlags.has(safeId)) {
+            if (!alreadyDeclaredFlags.has(safeId)) {
+                lines.push(`${indent}let ${safeId}_success = false;`);
+            }
             preDeclaredFlags.add(safeId);
         }
     }
@@ -904,7 +924,7 @@ function generateBranchingChainCode(chain, workflow, nodeTypes, branchingNodes,
             lines.push(`${indent}if (${guardCondition}) {`);
         }
         const nodeIndent = hasGuard ? indent + '  ' : indent;
-        generateBranchingNodeCode(instance, nodeType, workflow, nodeTypes, effectiveRegion, availableVars, generatedNodes, lines, nodeIndent, false, branchingNodes, branchRegions, isAsync, ctxVar, bundleMode, preDeclaredFlags, !isLast || forceTrackSuccessNodes.has(chain[i]), // forceTrackSuccess for non-last chain nodes or nodes with promoted dependents
+        generateBranchingNodeCode(instance, nodeType, workflow, nodeTypes, effectiveRegion, availableVars, generatedNodes, lines, nodeIndent, false, branchingNodes, branchRegions, isAsync, ctxVar, bundleMode, preDeclaredFlags, !isLast || forceTrackSuccessNodes.has(chain[i]) || alreadyDeclaredFlags.has(safeId), // forceTrackSuccess for non-last chain nodes, nodes with promoted dependents, or nodes with pre-declared flags
         production);
         // Generate scoped children for this chain node
         generateScopedChildrenExecution(instance, nodeType, workflow, nodeTypes, generatedNodes, availableVars, lines, nodeIndent, branchingNodes, branchRegions, isAsync, bundleMode, production);
@@ -1194,7 +1214,19 @@ bundleMode = false, preDeclaredSuccessFlags = new Set(), forceTrackSuccess = fal
                 return;
             if (branchingNodes.has(instanceId)) {
                 const nestedRegion = branchRegions.get(instanceId);
-                generateBranchingNodeCode(inst, nodeType, workflow, allNodeTypes, nestedRegion, successVars, generatedNodes, lines, `${indent}  `, false, branchingNodes, branchRegions, isAsync, ctxVar, bundleMode, new Set(), false, production);
+                // Pre-declare nested branching node's _success flag at the current
+                // scope so it remains accessible to downstream guards that may run
+                // outside this branch block. (Fixes scoping bug where the flag was
+                // declared inside a nested conditional but referenced at a higher scope.)
+                const nestedSafeId = toValidIdentifier(instanceId);
+                const nestedHasDownstream = nestedRegion.successNodes.size > 0 || nestedRegion.failureNodes.size > 0;
+                const nestedPreDeclared = new Set(preDeclaredSuccessFlags);
+                if (nestedHasDownstream && !nestedPreDeclared.has(nestedSafeId)) {
+                    lines.push(`${indent}  let ${nestedSafeId}_success = false;`);
+                    nestedPreDeclared.add(nestedSafeId);
+                }
+                generateBranchingNodeCode(inst, nodeType, workflow, allNodeTypes, nestedRegion, successVars, generatedNodes, lines, `${indent}  `, false, branchingNodes, branchRegions, isAsync, ctxVar, bundleMode, nestedPreDeclared, nestedPreDeclared.has(nestedSafeId), // force tracking if flag was pre-declared at higher scope
+                production);
                 successExecutedNodes.push(instanceId);
                 nestedRegion.successNodes.forEach((n) => successExecutedNodes.push(n));
                 nestedRegion.failureNodes.forEach((n) => successExecutedNodes.push(n));
@@ -1235,7 +1267,17 @@ bundleMode = false, preDeclaredSuccessFlags = new Set(), forceTrackSuccess = fal
                     return;
                 if (branchingNodes.has(instanceId)) {
                     const nestedRegion = branchRegions.get(instanceId);
-                    generateBranchingNodeCode(inst, nodeType, workflow, allNodeTypes, nestedRegion, failureVars, generatedNodes, lines, `${indent}  `, false, branchingNodes, branchRegions, isAsync, ctxVar, bundleMode, new Set(), false, production);
+                    // Pre-declare nested branching node's _success flag at the current
+                    // scope (same fix as success branch above).
+                    const nestedSafeId = toValidIdentifier(instanceId);
+                    const nestedHasDownstream = nestedRegion.successNodes.size > 0 || nestedRegion.failureNodes.size > 0;
+                    const nestedPreDeclared = new Set(preDeclaredSuccessFlags);
+                    if (nestedHasDownstream && !nestedPreDeclared.has(nestedSafeId)) {
+                        lines.push(`${indent}  let ${nestedSafeId}_success = false;`);
+                        nestedPreDeclared.add(nestedSafeId);
+                    }
+                    generateBranchingNodeCode(inst, nodeType, workflow, allNodeTypes, nestedRegion, failureVars, generatedNodes, lines, `${indent}  `, false, branchingNodes, branchRegions, isAsync, ctxVar, bundleMode, nestedPreDeclared, nestedPreDeclared.has(nestedSafeId), // force tracking if flag was pre-declared at higher scope
+                    production);
                     failureExecutedNodes.push(instanceId);
                     nestedRegion.successNodes.forEach((n) => failureExecutedNodes.push(n));
                     nestedRegion.failureNodes.forEach((n) => failureExecutedNodes.push(n));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@synergenius/flow-weaver",
-  "version": "0.23.3",
+  "version": "0.23.5",
   "description": "Deterministic workflow compiler for AI agents. Compiles to standalone TypeScript, no runtime dependencies.",
   "private": false,
   "type": "module",