@synergenius/flow-weaver-pack-weaver 0.9.0 → 0.9.4

package/src/node-types/validate-gate.ts

@@ -0,0 +1,112 @@
+import { execFileSync } from 'node:child_process';
+import * as path from 'node:path';
+import type { WeaverContext } from '../bot/types.js';
+
+/**
+ * Post-agent validation gate. Runs `flow-weaver validate` on all modified files
+ * and fails the task if any have errors. Don't trust the AI's self-assessment.
+ *
+ * @flowWeaver nodeType
+ * @expression
+ * @label Validate Gate
+ * @input ctx [order:0] - Weaver context (JSON)
+ * @output ctx [order:0] - Weaver context with validation result (JSON)
+ * @output onSuccess [order:-2] - All files valid
+ * @output onFailure [order:-1] [hidden] - Validation failed
+ */
+export function weaverValidateGate(ctx: string): {
+  ctx: string;
+  onSuccess: boolean;
+  onFailure: boolean;
+} {
+  const context = JSON.parse(ctx) as WeaverContext;
+  const { projectDir } = context.env;
+  const files: string[] = context.filesModified ? JSON.parse(context.filesModified) : [];
+
+  if (files.length === 0) {
+    context.validationResultJson = JSON.stringify({ skipped: true, reason: 'no files modified' });
+    return { ctx: JSON.stringify(context), onSuccess: true, onFailure: false };
+  }
+
+  // Only validate .ts files that look like workflows or node types
+  const toValidate = files.filter(f => f.endsWith('.ts'));
+  if (toValidate.length === 0) {
+    context.validationResultJson = JSON.stringify({ skipped: true, reason: 'no .ts files' });
+    return { ctx: JSON.stringify(context), onSuccess: true, onFailure: false };
+  }
+
+  const errors: Array<{ file: string; errorCount: number; errors: string[] }> = [];
+  let allValid = true;
+
+  for (const file of toValidate) {
+    const absPath = path.isAbsolute(file) ? file : path.resolve(projectDir, file);
+    try {
+      const output = execFileSync(
+        'npx',
+        ['flow-weaver', 'validate', absPath, '--json'],
+        { encoding: 'utf-8', stdio: ['pipe', 'pipe', 'pipe'], timeout: 30_000, cwd: projectDir },
+      ).trim();
+
+      // Parse JSON output — look for errors (not warnings)
+      let result: { errors?: Array<{ message: string }>; errorCount?: number };
+      try {
+        result = JSON.parse(output);
+      } catch {
+        // Non-JSON output — try to detect errors from text
+        const hasErrors = output.includes('error') && !output.includes('0 error');
+        if (hasErrors) {
+          errors.push({ file, errorCount: 1, errors: [output.slice(0, 200)] });
+          allValid = false;
+        }
+        continue;
+      }
+
+      const errorCount = result.errorCount ?? result.errors?.length ?? 0;
+      if (errorCount > 0) {
+        allValid = false;
+        errors.push({
+          file,
+          errorCount,
+          errors: (result.errors ?? []).map(e => e.message).slice(0, 5),
+        });
+      }
+    } catch (err: unknown) {
+      // validate command failed — could be a parse error, treat as validation failure
+      const msg = err instanceof Error ? err.message : String(err);
+      // But don't fail on "not a workflow" — only on actual errors
+      if (!msg.includes('No @flowWeaver annotation') && !msg.includes('not a workflow')) {
+        errors.push({ file, errorCount: 1, errors: [msg.slice(0, 200)] });
+        allValid = false;
+      }
+    }
+  }
+
+  // Also run tsc --noEmit if any .ts files were modified (catches type errors FW validate misses)
+  if (allValid && toValidate.length > 0) {
+    try {
+      execFileSync('npx', ['tsc', '--noEmit', '--pretty'], {
+        cwd: projectDir, encoding: 'utf-8', timeout: 60_000, stdio: ['pipe', 'pipe', 'pipe'],
+      });
+    } catch (err: unknown) {
+      const tscOutput = (err as { stdout?: string }).stdout ?? (err instanceof Error ? err.message : '');
+      if (tscOutput.includes('error TS')) {
+        allValid = false;
+        errors.push({ file: '(tsc)', errorCount: 1, errors: [tscOutput.slice(0, 500)] });
+      }
+    }
+  }
+
+  context.validationResultJson = JSON.stringify({ errors, allValid });
+  context.allValid = allValid;
+
+  if (!allValid && process.env.WEAVER_VERBOSE) {
+    for (const e of errors) {
+      process.stderr.write(`\x1b[31m  ✗ ${e.file}: ${e.errorCount} error(s)\x1b[0m\n`);
+      for (const msg of e.errors) {
+        process.stderr.write(`\x1b[31m    ${msg}\x1b[0m\n`);
+      }
+    }
+  }
+
+  return { ctx: JSON.stringify(context), onSuccess: allValid, onFailure: !allValid };
+}

package/src/workflows/genesis-task.ts

@@ -33,40 +33,48 @@ import { genesisEscrowGrace } from '../node-types/genesis-escrow-grace.js';
  * @flowWeaver workflow
  *
  * @node cfg       weaverLoadConfig         [color: "teal"]    [icon: "settings"]     [position: 200 200]
- * @node detect    weaverDetectProvider     [color: "cyan"]    [icon: "search"]       [position: 400 200]
+ * @node detect    weaverDetectProvider     [color: "cyan"]    [icon: "search"]       [position: 400 200] [suppress: "OBJECT_TYPE_MISMATCH", "ANNOTATION_SIGNATURE_TYPE_MISMATCH"]
  * @node gCfg      genesisLoadConfig        [color: "purple"]  [icon: "settings"]     [position: 600 200]
- * @node escRecover genesisEscrowRecover    [color: "yellow"]  [icon: "healing"]      [position: 750 200]
+ * @node escRecover genesisEscrowRecover    [color: "yellow"]  [icon: "healthAndSafety"] [position: 750 200]
  * @node observe   genesisObserve           [color: "blue"]    [icon: "visibility"]   [position: 900 200]
- * @node diffFp    genesisDiffFingerprint   [color: "cyan"]    [icon: "compare"]      [position: 1100 200]
+ * @node diffFp    genesisDiffFingerprint   [color: "cyan"]    [icon: "assessment"]   [position: 1100 200]
  * @node stabilize genesisCheckStabilize    [color: "orange"]  [icon: "lock"]         [position: 1300 200]
  * @node propose   genesisPropose           [color: "blue"]    [icon: "psychology"]   [position: 1500 200]
- * @node validate  genesisValidateProposal  [color: "teal"]    [icon: "check"]        [position: 1700 200]
+ * @node validate  genesisValidateProposal  [color: "teal"]    [icon: "checkCircle"]  [position: 1700 200]
  * @node snapshot  genesisSnapshot          [color: "cyan"]    [icon: "backup"]       [position: 1900 200]
- * @node applyRetry genesisApplyRetry       [color: "purple"]  [icon: "replay"]       [position: 2100 200] [size: 300 200]
- * @node tryApply  genesisTryApply          applyRetry.attempt [position: 2150 230]
- * @node diffWf    genesisDiffWorkflow      [color: "cyan"]    [icon: "compare"]      [position: 2440 200]
+ * @node applyRetry genesisApplyRetry       [color: "purple"]  [icon: "repeat"]       [position: 2100 200] [size: 300 200] [suppress: "DESIGN_UNBOUNDED_RETRY"]
+ * @node tryApply  genesisTryApply          applyRetry.attempt [position: 2150 230] [suppress: "DESIGN_PULL_CANDIDATE"]
+ * @node diffWf    genesisDiffWorkflow      [color: "cyan"]    [icon: "altRoute"]     [position: 2440 200]
  * @node threshold genesisCheckThreshold    [color: "orange"]  [icon: "tune"]         [position: 2640 200]
  * @node approve   genesisApprove           [color: "orange"]  [icon: "send"]         [position: 2840 200]
  * @node commit    genesisCommit            [color: "green"]   [icon: "save"]         [position: 3040 200]
- * @node escStage  genesisEscrowStage       [color: "yellow"]  [icon: "archive"]      [position: 3240 400]
+ * @node escStage  genesisEscrowStage       [color: "yellow"]  [icon: "storage"]      [position: 3240 400]
  * @node escVal    genesisEscrowValidate    [color: "yellow"]  [icon: "verified"]     [position: 3440 400]
- * @node escMig    genesisEscrowMigrate     [color: "yellow"]  [icon: "swap_horiz"]   [position: 3640 400]
- * @node history   genesisUpdateHistory     [color: "teal"]    [icon: "history"]      [position: 3840 200]
+ * @node escMig    genesisEscrowMigrate     [color: "yellow"]  [icon: "sync"]         [position: 3640 400]
+ * @node history   genesisUpdateHistory     [color: "teal"]    [icon: "receipt"]      [position: 3840 200]
  * @node escGrace  genesisEscrowGrace       [color: "yellow"]  [icon: "timer"]        [position: 4040 200]
  * @node report    genesisReport            [color: "green"]   [icon: "description"]  [position: 4240 200]
  *
  * @path Start -> cfg -> detect -> gCfg -> escRecover -> observe -> diffFp -> stabilize -> propose -> validate -> snapshot -> applyRetry -> diffWf -> threshold -> approve -> commit -> escStage -> escVal -> escMig -> history -> escGrace -> report -> Exit
  *
  * @path applyRetry:fail -> report
+ * @path observe:fail -> report
+ * @path propose:fail -> report
+ * @path approve:fail -> report
+ * @path commit:fail -> report
  * @path escStage:fail -> report
  * @path escVal:fail -> report
  * @path escMig:fail -> report
  *
  * @connect applyRetry.attemptCtx:attempt -> tryApply.ctx
  * @connect tryApply.ctx -> applyRetry.attemptCtx:attempt
+ * @connect tryApply.onSuccess -> applyRetry.success:attempt
+ * @connect tryApply.onFailure -> applyRetry.failure:attempt
  *
- * @connect history.ctx -> report.successCtx
+ * @connect escGrace.ctx -> report.successCtx
  * @connect applyRetry.ctx -> report.failCtx
+ * @connect propose.ctx -> report.proposeFailCtx
+ * @connect commit.ctx -> report.commitFailCtx
  *
  * @connect report.summary -> Exit.summary
  *
@@ -74,7 +82,7 @@ import { genesisEscrowGrace } from '../node-types/genesis-escrow-grace.js';
  * @position Exit 4440 200
  *
  * @param execute [order:-1] - Execute
- * @param projectDir [order:0] [optional] - Project directory
+ * @param [projectDir] [order:0] - Project directory
  * @returns onSuccess [order:-2] - On Success
  * @returns onFailure [order:-1] [hidden] - On Failure
  * @returns summary [order:0] - Summary text