@syncular/server 0.46.3 → 0.47.0

package/dist/errors.js

@@ -139,6 +139,15 @@ export const ERROR_CATALOG = {
         recommendedAction: 'fixRequest',
         httpStatus: 400,
     },
+    // §6.8: the whole-commit validator threw an exception that is not a
+    // deliberate rejection. A host fault; the thrown message rides the §6.3.1
+    // details and the original reaches the host's `onError`.
+    'sync.validator_error': {
+        category: 'internal',
+        retryable: false,
+        recommendedAction: 'inspectServer',
+        httpStatus: 500,
+    },
     'sync.missing_scopes': {
         category: 'internal',
         retryable: false,

package/dist/push.js

@@ -20,7 +20,7 @@ import { retainRollbackFailure } from './storage-errors.js';
  */
 import { decodeRow, decodeSparseRow, encodeRow, parseBlobRef, } from '@syncular/core';
 import { clockOf, limitsOf } from './context.js';
-import { SyncError } from './errors.js';
+import { reportError, SyncError } from './errors.js';
 import { emitEvent } from './events.js';
 import { prepareReactions, toNewReactions, } from './reactions.js';
 import { authorizeWrite, renderScopeValue, storedScopesForRow } from './scopes.js';
@@ -699,7 +699,7 @@ function commitValidationReader(tx, schema) {
         queryAuthoritative: (query) => transactionQuery(tx, query),
     };
 }
-async function runCommitValidator(validator, tx, schema, clientId, clientCommitId, actorId, partition, operations) {
+async function runCommitValidator(validator, onError, tx, schema, clientId, clientCommitId, actorId, partition, operations) {
     if (validator === undefined)
         return undefined;
     try {
@@ -722,7 +722,30 @@ async function runCommitValidator(validator, tx, schema, clientId, clientCommitI
         if (error instanceof ValidationRejection) {
             return errorRecord(operations[0]?.opIndex ?? 0, error.code, error.message, false, error.details);
         }
-        return errorRecord(operations[0]?.opIndex ?? 0, 'sync.constraint_violation', 'whole-commit validator failed');
+        // §6.8: a throw that is not a deliberate rejection is a host fault, not a
+        // rule refusal. The host's observation hook receives the original (its
+        // stack included); the client gets a distinct code and, in the §6.3.1
+        // details, the bounded thrown message. Stacks and thrown values stay off
+        // the wire.
+        reportError(error, onError, 'sync');
+        let text = '';
+        let bytes = 0;
+        const encoder = new TextEncoder();
+        const thrown = error instanceof Error ? error.message : String(error);
+        for (const char of thrown.replace(/\p{Cc}+/gu, ' ').trim()) {
+            const size = encoder.encode(char).length;
+            if (bytes + size > 256)
+                break;
+            bytes += size;
+            text += char;
+        }
+        text = text.trimEnd();
+        return errorRecord(operations[0]?.opIndex ?? 0, 'sync.validator_error', 'whole-commit validator failed', false, {
+            reason: 'validator_threw',
+            ...(text === ''
+                ? {}
+                : { references: { validator: 'commit', message: text } }),
+        });
     }
     return undefined;
 }
@@ -1129,7 +1152,7 @@ export async function processPushOperationsWithTrace(ctx, schema, resolved, clie
             }
         }
         if (terminated === undefined) {
-            const commitReject = await runCommitValidator(commitValidator, tx, schema, clientId, clientCommitId, ctx.actorId, partition, validatedOperations);
+            const commitReject = await runCommitValidator(commitValidator, ctx.onError, tx, schema, clientId, clientCommitId, ctx.actorId, partition, validatedOperations);
             if (commitReject?.kind === 'terminate') {
                 // An appended §6.11 cascade operation carries a synthetic opIndex;
                 // surface the originating client operation instead.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@syncular/server",
-  "version": "0.46.3",
+  "version": "0.47.0",
   "description": "Syncular server: handleSyncRequest + storage/auth interfaces for the sync protocol",
   "license": "Apache-2.0",
   "author": "Benjamin Kniffler",
@@ -68,7 +68,7 @@
     "verify:node": "cd ../.. && bun build ./packages/server/test/sqlite-runtime/verify-node.mjs --target=node --conditions=bun --outfile=./packages/server/.verify-node.built.mjs && node ./packages/server/.verify-node.built.mjs"
   },
   "dependencies": {
-    "@syncular/core": "0.46.3"
+    "@syncular/core": "0.47.0"
   },
   "devDependencies": {
     "@electric-sql/pglite": "^0.5.4"

package/src/errors.ts

@@ -147,6 +147,15 @@ export const ERROR_CATALOG: Readonly<Record<string, ErrorCatalogEntry>> = {
     recommendedAction: 'fixRequest',
     httpStatus: 400,
   },
+  // §6.8: the whole-commit validator threw an exception that is not a
+  // deliberate rejection. A host fault; the thrown message rides the §6.3.1
+  // details and the original reaches the host's `onError`.
+  'sync.validator_error': {
+    category: 'internal',
+    retryable: false,
+    recommendedAction: 'inspectServer',
+    httpStatus: 500,
+  },
   'sync.missing_scopes': {
     category: 'internal',
     retryable: false,

package/src/push.ts

@@ -35,7 +35,7 @@ import type { BlobStore } from './blob-store';
 import type { SyncRequestContext } from './context';
 import { clockOf, limitsOf } from './context';
 import type { CrdtMergerRegistry } from './crdt-merger';
-import { SyncError } from './errors';
+import { reportError, SyncError, type SyncularErrorHandler } from './errors';
 import { emitEvent } from './events';
 import {
   prepareReactions,
@@ -1116,6 +1116,7 @@ function commitValidationReader(
 
 async function runCommitValidator(
   validator: CommitValidator | undefined,
+  onError: SyncularErrorHandler | undefined,
   tx: StorageTransaction,
   schema: CompiledSchema,
   clientId: string,
@@ -1160,10 +1161,34 @@ async function runCommitValidator(
         error.details,
       );
     }
+    // §6.8: a throw that is not a deliberate rejection is a host fault, not a
+    // rule refusal. The host's observation hook receives the original (its
+    // stack included); the client gets a distinct code and, in the §6.3.1
+    // details, the bounded thrown message. Stacks and thrown values stay off
+    // the wire.
+    reportError(error, onError, 'sync');
+    let text = '';
+    let bytes = 0;
+    const encoder = new TextEncoder();
+    const thrown = error instanceof Error ? error.message : String(error);
+    for (const char of thrown.replace(/\p{Cc}+/gu, ' ').trim()) {
+      const size = encoder.encode(char).length;
+      if (bytes + size > 256) break;
+      bytes += size;
+      text += char;
+    }
+    text = text.trimEnd();
     return errorRecord(
       operations[0]?.opIndex ?? 0,
-      'sync.constraint_violation',
+      'sync.validator_error',
       'whole-commit validator failed',
+      false,
+      {
+        reason: 'validator_threw',
+        ...(text === ''
+          ? {}
+          : { references: { validator: 'commit', message: text } }),
+      },
     );
   }
   return undefined;
@@ -1769,6 +1794,7 @@ export async function processPushOperationsWithTrace(
     if (terminated === undefined) {
       const commitReject = await runCommitValidator(
         commitValidator,
+        ctx.onError,
         tx,
         schema,
         clientId,