@syncular/client 0.25.0 → 0.25.2

package/dist/reactive-store.js

@@ -136,6 +136,17 @@ function valuesEqual(left, right) {
         typeof right !== 'object') {
         return false;
     }
+    if (left instanceof Date || right instanceof Date) {
+        return (left instanceof Date &&
+            right instanceof Date &&
+            Object.is(left.getTime(), right.getTime()));
+    }
+    // Errors and class instances keep state outside their enumerable keys.
+    for (const value of [left, right]) {
+        const prototype = Object.getPrototypeOf(value);
+        if (prototype !== Object.prototype && prototype !== null)
+            return false;
+    }
     const leftRecord = left;
     const rightRecord = right;
     const keys = Object.keys(leftRecord);
@@ -146,7 +157,7 @@ function valuesEqual(left, right) {
 }
 function reconcileRows(previous, fresh, rowKey) {
     if (previous.length === 0)
-        return fresh;
+        return fresh.length === 0 ? previous : fresh;
     if (rowKey === undefined) {
         let changed = previous.length !== fresh.length;
         const next = fresh.map((row, index) => {
@@ -229,6 +240,27 @@ class ObservationCache {
         this.#active.clear();
     }
 }
+const EMPTY_ROWS = Object.freeze([]);
+const unreadQuerySnapshots = new Map();
+/** One frozen snapshot per phase and availability for entries that have no
+ * successful read, so switching between unread entries keeps the snapshot and
+ * `rows` identity. */
+function unreadQuerySnapshot(phase, availability) {
+    const key = canonicalValue([phase, availability]);
+    let snapshot = unreadQuerySnapshots.get(key);
+    if (snapshot === undefined) {
+        snapshot = Object.freeze({
+            rows: EMPTY_ROWS,
+            phase,
+            revision: undefined,
+            error: undefined,
+            isRefreshing: false,
+            availability,
+        });
+        unreadQuerySnapshots.set(key, snapshot);
+    }
+    return snapshot;
+}
 class QueryEntry {
     store;
     spec;
@@ -236,14 +268,9 @@ class QueryEntry {
     cache;
     #owner = Symbol('query-window-claim');
     #listeners = new Set();
-    #state = {
-        rows: [],
-        phase: 'loading',
-        revision: undefined,
-        error: undefined,
-        isRefreshing: false,
-        availability: { state: 'ready' },
-    };
+    #state = unreadQuerySnapshot('loading', {
+        state: 'ready',
+    });
     #delegate;
     #generation = 0;
     #scheduled = false;
@@ -340,14 +367,7 @@ class QueryEntry {
         this.#desiredRevision = 0n;
         this.#claimError = undefined;
         this.#claimPending = false;
-        this.#state = {
-            rows: [],
-            phase: 'loading',
-            revision: undefined,
-            error: undefined,
-            isRefreshing: false,
-            availability: { state: 'ready' },
-        };
+        this.#state = unreadQuerySnapshot('loading', { state: 'ready' });
     }
     dispose() {
         this.#listeners.clear();
@@ -374,7 +394,13 @@ class QueryEntry {
                 canonicalValue(this.#state.availability)) {
             return;
         }
-        this.#state = next;
+        this.#state =
+            next.revision === undefined &&
+                next.rows.length === 0 &&
+                next.error === undefined &&
+                !next.isRefreshing
+                ? unreadQuerySnapshot(next.phase, next.availability)
+                : next;
         for (const listener of this.#listeners)
             listener();
     }
@@ -539,7 +565,7 @@ class ValueEntry {
     }
     set(next) {
         this.invalidate();
-        if (next === this.value)
+        if (valuesEqual(next, this.value))
             return;
         this.value = next;
         for (const listener of this.#listeners)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@syncular/client",
-  "version": "0.25.0",
+  "version": "0.25.2",
   "description": "Syncular TypeScript client core — offline-first sync over SQLite (WASM/OPFS, Bun, Node)",
   "license": "Apache-2.0",
   "author": "Benjamin Kniffler",
@@ -89,10 +89,10 @@
   },
   "dependencies": {
     "@sqlite.org/sqlite-wasm": "^3.53.0-build1",
-    "@syncular/core": "0.25.0"
+    "@syncular/core": "0.25.2"
   },
   "devDependencies": {
-    "@syncular/server": "0.25.0",
+    "@syncular/server": "0.25.2",
     "playwright": "1.63.0"
   }
 }

package/src/reactive-store.ts

@@ -249,6 +249,18 @@ function valuesEqual(left: unknown, right: unknown): boolean {
   ) {
     return false;
   }
+  if (left instanceof Date || right instanceof Date) {
+    return (
+      left instanceof Date &&
+      right instanceof Date &&
+      Object.is(left.getTime(), right.getTime())
+    );
+  }
+  // Errors and class instances keep state outside their enumerable keys.
+  for (const value of [left, right]) {
+    const prototype = Object.getPrototypeOf(value);
+    if (prototype !== Object.prototype && prototype !== null) return false;
+  }
   const leftRecord = left as Record<string, unknown>;
   const rightRecord = right as Record<string, unknown>;
   const keys = Object.keys(leftRecord);
@@ -265,7 +277,7 @@ function reconcileRows<Row>(
   fresh: readonly Row[],
   rowKey: ((row: Row) => readonly SqlValue[]) | undefined,
 ): readonly Row[] {
-  if (previous.length === 0) return fresh;
+  if (previous.length === 0) return fresh.length === 0 ? previous : fresh;
   if (rowKey === undefined) {
     let changed = previous.length !== fresh.length;
     const next = fresh.map((row, index) => {
@@ -348,17 +360,38 @@ class ObservationCache {
   }
 }
 
+const EMPTY_ROWS: readonly never[] = Object.freeze([]);
+const unreadQuerySnapshots = new Map<string, LiveQueryResult<never>>();
+
+/** One frozen snapshot per phase and availability for entries that have no
+ * successful read, so switching between unread entries keeps the snapshot and
+ * `rows` identity. */
+function unreadQuerySnapshot(
+  phase: LiveQueryPhase,
+  availability: SyncAvailability,
+): LiveQueryResult<never> {
+  const key = canonicalValue([phase, availability]);
+  let snapshot = unreadQuerySnapshots.get(key);
+  if (snapshot === undefined) {
+    snapshot = Object.freeze({
+      rows: EMPTY_ROWS,
+      phase,
+      revision: undefined,
+      error: undefined,
+      isRefreshing: false,
+      availability,
+    });
+    unreadQuerySnapshots.set(key, snapshot);
+  }
+  return snapshot;
+}
+
 class QueryEntry<Row> implements ExternalStoreEntry<LiveQueryResult<Row>> {
   readonly #owner = Symbol('query-window-claim');
   readonly #listeners = new Set<() => void>();
-  #state: LiveQueryResult<Row> = {
-    rows: [],
-    phase: 'loading',
-    revision: undefined,
-    error: undefined,
-    isRefreshing: false,
-    availability: { state: 'ready' },
-  };
+  #state: LiveQueryResult<Row> = unreadQuerySnapshot('loading', {
+    state: 'ready',
+  });
   #delegate: QueryEntry<Row> | undefined;
   #generation = 0;
   #scheduled = false;
@@ -464,14 +497,7 @@ class QueryEntry<Row> implements ExternalStoreEntry<LiveQueryResult<Row>> {
     this.#desiredRevision = 0n;
     this.#claimError = undefined;
     this.#claimPending = false;
-    this.#state = {
-      rows: [],
-      phase: 'loading',
-      revision: undefined,
-      error: undefined,
-      isRefreshing: false,
-      availability: { state: 'ready' },
-    };
+    this.#state = unreadQuerySnapshot('loading', { state: 'ready' });
   }
 
   dispose(): void {
@@ -501,7 +527,13 @@ class QueryEntry<Row> implements ExternalStoreEntry<LiveQueryResult<Row>> {
     ) {
       return;
     }
-    this.#state = next;
+    this.#state =
+      next.revision === undefined &&
+      next.rows.length === 0 &&
+      next.error === undefined &&
+      !next.isRefreshing
+        ? unreadQuerySnapshot(next.phase, next.availability)
+        : next;
     for (const listener of this.#listeners) listener();
   }
 
@@ -668,7 +700,7 @@ class ValueEntry<T> implements ExternalStoreEntry<T> {
   }
   set(next: T): void {
     this.invalidate();
-    if (next === this.value) return;
+    if (valuesEqual(next, this.value)) return;
     this.value = next;
     for (const listener of this.#listeners) listener();
   }