@syncfusion/ej2-gantt 23.2.4 → 23.2.7

package/dist/global/index.d.ts

@@ -1,6 +1,6 @@
 /*!
 *  filename: index.d.ts
-*  version : 23.2.4
+*  version : 23.2.7
 *  Copyright Syncfusion Inc. 2001 - 2023. All rights reserved.
 *  Use of this code is subject to the terms of our license.
 *  A copy of the current license can be obtained at any time by e-mailing

package/package.json

@@ -1,8 +1,8 @@
 {
   "_from": "@syncfusion/ej2-gantt@*",
-  "_id": "@syncfusion/ej2-gantt@23.1.44",
+  "_id": "@syncfusion/ej2-gantt@23.2.5",
   "_inBundle": false,
-  "_integrity": "sha512-FFN4iVap1ulswXR3xbIsVZmtRPlvYeQF7a7O/z9xfGCc3PDviqLYul4Z0YBj8em9xAHq4JQw3DOnTRZm4CI2Kg==",
+  "_integrity": "sha512-dx2I2n4yLq8ObKKGEke8UMHx5jxwXvS5EXQ1f9RctJvMQPOGXzPT25Q4KBX5e2cxr33+1tGGJsu5w71LyC8gkw==",
   "_location": "/@syncfusion/ej2-gantt",
   "_phantomChildren": {},
   "_requested": {
@@ -23,8 +23,8 @@
     "/@syncfusion/ej2-react-gantt",
     "/@syncfusion/ej2-vue-gantt"
   ],
-  "_resolved": "https://nexus.syncfusion.com/repository/ej2-hotfix-new/@syncfusion/ej2-gantt/-/ej2-gantt-23.1.44.tgz",
-  "_shasum": "d3038e839389b5542cec6e67b77ad85e7169e0b8",
+  "_resolved": "https://nexus.syncfusion.com/repository/ej2-hotfix-new/@syncfusion/ej2-gantt/-/ej2-gantt-23.2.5.tgz",
+  "_shasum": "cddf93452ba28e98ba90fcc4c94ccbcea1a8ec16",
   "_spec": "@syncfusion/ej2-gantt@*",
   "_where": "/jenkins/workspace/elease-automation_release_23.1.1/packages/included",
   "author": {
@@ -35,21 +35,21 @@
   },
   "bundleDependencies": false,
   "dependencies": {
-    "@syncfusion/ej2-base": "~23.2.4",
-    "@syncfusion/ej2-buttons": "~23.2.4",
-    "@syncfusion/ej2-calendars": "~23.2.4",
+    "@syncfusion/ej2-base": "~23.2.6",
+    "@syncfusion/ej2-buttons": "~23.2.7",
+    "@syncfusion/ej2-calendars": "~23.2.7",
     "@syncfusion/ej2-data": "~23.2.4",
-    "@syncfusion/ej2-dropdowns": "~23.2.4",
-    "@syncfusion/ej2-grids": "~23.2.4",
+    "@syncfusion/ej2-dropdowns": "~23.2.7",
+    "@syncfusion/ej2-grids": "~23.2.7",
     "@syncfusion/ej2-inputs": "~23.2.4",
     "@syncfusion/ej2-layouts": "~23.2.4",
     "@syncfusion/ej2-lists": "~23.2.4",
-    "@syncfusion/ej2-navigations": "~23.2.4",
-    "@syncfusion/ej2-notifications": "~23.2.4",
+    "@syncfusion/ej2-navigations": "~23.2.7",
+    "@syncfusion/ej2-notifications": "~23.2.5",
     "@syncfusion/ej2-popups": "~23.2.4",
-    "@syncfusion/ej2-richtexteditor": "~23.2.4",
-    "@syncfusion/ej2-svg-base": "~23.2.4",
-    "@syncfusion/ej2-treegrid": "~23.2.4"
+    "@syncfusion/ej2-richtexteditor": "~23.2.7",
+    "@syncfusion/ej2-svg-base": "~23.2.5",
+    "@syncfusion/ej2-treegrid": "~23.2.7"
   },
   "deprecated": false,
   "description": "Essential JS 2 Gantt Component",
@@ -74,6 +74,6 @@
     "url": "git+https://github.com/syncfusion/ej2-gantt.git"
   },
   "typings": "index.d.ts",
-  "version": "23.2.4",
+  "version": "23.2.7",
   "sideEffects": false
 }

package/src/gantt/actions/edit.js

@@ -2559,34 +2559,42 @@ var Edit = /** @class */ (function () {
         var predecessorCollection = parentRecordTaskData.predecessor;
         var childRecord;
         var predecessorIndex;
+        var validPredecessor;
         var updatedPredecessor = [];
         for (var count = 0; count < len; count++) {
-            if (predecessorCollection[count].to === parentRecordTaskData.rowUniqueID.toString()) {
-                childRecord = this.parent.getRecordByID(predecessorCollection[count].from);
-                predecessorIndex = getIndex(predecessorCollection[count], 'from', childRecord.ganttProperties.predecessor, 'to');
-                // eslint-disable-next-line
-                var predecessorCollections = (extend([], childRecord.ganttProperties.predecessor, [], true));
-                predecessorCollections.splice(predecessorIndex, 1);
-                this.parent.setRecordValue('predecessor', predecessorCollections, childRecord.ganttProperties, true);
-            }
-            else if (predecessorCollection[count].from === parentRecordTaskData.rowUniqueID.toString()) {
-                childRecord = this.parent.getRecordByID(predecessorCollection[count].to);
-                var prdcList = (childRecord.ganttProperties.predecessorsName.toString()).split(',');
-                var str = predecessorCollection[count].from + predecessorCollection[count].type;
-                var ind = prdcList.indexOf(str);
-                prdcList.splice(ind, 1);
-                this.parent.setRecordValue('predecessorsName', prdcList.join(','), childRecord.ganttProperties, true);
-                this.parent.setRecordValue(this.parent.taskFields.dependency, prdcList.join(','), childRecord);
-                predecessorIndex = getIndex(predecessorCollection[count], 'from', childRecord.ganttProperties.predecessor, 'to');
-                // eslint-disable-next-line
-                var temppredecessorCollection = (extend([], childRecord.ganttProperties.predecessor, [], true));
-                temppredecessorCollection.splice(predecessorIndex, 1);
-                this.parent.setRecordValue('predecessor', temppredecessorCollection, childRecord.ganttProperties, true);
-                this.parent.predecessorModule.validatePredecessorDates(childRecord);
-            }
+            var fromRecord = this.parent.getRecordByID(predecessorCollection[count].from);
+            var toRecord = this.parent.getRecordByID(predecessorCollection[count].to);
+            validPredecessor = this.parent.connectorLineEditModule.validateParentPredecessor(fromRecord, toRecord);
+            if (!validPredecessor) {
+                if (predecessorCollection[count].to === parentRecordTaskData.rowUniqueID.toString()) {
+                    childRecord = this.parent.getRecordByID(predecessorCollection[count].from);
+                    predecessorIndex = getIndex(predecessorCollection[count], 'from', childRecord.ganttProperties.predecessor, 'to');
+                    // eslint-disable-next-line
+                    var predecessorCollections = (extend([], childRecord.ganttProperties.predecessor, [], true));
+                    predecessorCollections.splice(predecessorIndex, 1);
+                    this.parent.setRecordValue('predecessor', predecessorCollections, childRecord.ganttProperties, true);
+                }
+                else if (predecessorCollection[count].from === parentRecordTaskData.rowUniqueID.toString()) {
+                    childRecord = this.parent.getRecordByID(predecessorCollection[count].to);
+                    var prdcList = (childRecord.ganttProperties.predecessorsName.toString()).split(',');
+                    var str = predecessorCollection[count].from + predecessorCollection[count].type;
+                    var ind = prdcList.indexOf(str);
+                    prdcList.splice(ind, 1);
+                    this.parent.setRecordValue('predecessorsName', prdcList.join(','), childRecord.ganttProperties, true);
+                    this.parent.setRecordValue(this.parent.taskFields.dependency, prdcList.join(','), childRecord);
+                    predecessorIndex = getIndex(predecessorCollection[count], 'from', childRecord.ganttProperties.predecessor, 'to');
+                    // eslint-disable-next-line
+                    var temppredecessorCollection = (extend([], childRecord.ganttProperties.predecessor, [], true));
+                    temppredecessorCollection.splice(predecessorIndex, 1);
+                    this.parent.setRecordValue('predecessor', temppredecessorCollection, childRecord.ganttProperties, true);
+                    this.parent.predecessorModule.validatePredecessorDates(childRecord);
+                }
+            }
+        }
+        if (!validPredecessor) {
+            this.parent.setRecordValue('predecessor', updatedPredecessor, parentRecord.ganttProperties, true);
+            this.parent.setRecordValue('predecessorsName', '', parentRecord.ganttProperties, true);
         }
-        this.parent.setRecordValue('predecessor', updatedPredecessor, parentRecord.ganttProperties, true);
-        this.parent.setRecordValue('predecessorsName', '', parentRecord.ganttProperties, true);
     };
     /**
      * @param {IPredecessor[]} predecessorCollection .
@@ -3553,11 +3561,19 @@ var Edit = /** @class */ (function () {
             }
             if (this.dropPosition === 'middleSegment') {
                 if (droppedRec.ganttProperties.predecessor) {
-                    this.parent.editModule.removePredecessorOnDelete(droppedRec);
-                    droppedRec.ganttProperties.predecessor = null;
-                    droppedRec.ganttProperties.predecessorsName = null;
-                    droppedRec[this.parent.taskFields.dependency] = null;
-                    droppedRec.taskData[this.parent.taskFields.dependency] = null;
+                    var len = droppedRec.ganttProperties.predecessor.length;
+                    for (var count = 0; count < len; count++) {
+                        var fromRecord = this.parent.getRecordByID(droppedRec.ganttProperties.predecessor[count].from);
+                        var toRecord = this.parent.getRecordByID(droppedRec.ganttProperties.predecessor[count].to);
+                        var validPredecessor = this.parent.connectorLineEditModule.validateParentPredecessor(fromRecord, toRecord);
+                        if (droppedRec.ganttProperties.predecessor && !validPredecessor) {
+                            this.parent.editModule.removePredecessorOnDelete(droppedRec);
+                            droppedRec.ganttProperties.predecessor = null;
+                            droppedRec.ganttProperties.predecessorsName = null;
+                            droppedRec[this.parent.taskFields.dependency] = null;
+                            droppedRec.taskData[this.parent.taskFields.dependency] = null;
+                        }
+                    }
                 }
                 if (droppedRec.ganttProperties.isMilestone) {
                     this.parent.setRecordValue('isMilestone', false, droppedRec.ganttProperties, true);

package/src/gantt/actions/rowdragdrop.js

@@ -335,11 +335,19 @@ var RowDD = /** @class */ (function () {
                 }
                 if (this.dropPosition === 'middleSegment') {
                     if (droppedRecord.ganttProperties.predecessor) {
-                        this.parent.editModule.removePredecessorOnDelete(droppedRecord);
-                        droppedRecord.ganttProperties.predecessor = null;
-                        droppedRecord.ganttProperties.predecessorsName = null;
-                        droppedRecord[this.parent.taskFields.dependency] = null;
-                        droppedRecord.taskData[this.parent.taskFields.dependency] = null;
+                        var len = droppedRecord.ganttProperties.predecessor.length;
+                        for (var count_1 = 0; count_1 < len; count_1++) {
+                            var fromRecord = this.parent.getRecordByID(droppedRecord.ganttProperties.predecessor[count_1].from);
+                            var toRecord = this.parent.getRecordByID(droppedRecord.ganttProperties.predecessor[count_1].to);
+                            var validPredecessor = this.parent.connectorLineEditModule.validateParentPredecessor(fromRecord, toRecord);
+                            if (droppedRecord.ganttProperties.predecessor && !validPredecessor) {
+                                this.parent.editModule.removePredecessorOnDelete(droppedRecord);
+                                droppedRecord.ganttProperties.predecessor = null;
+                                droppedRecord.ganttProperties.predecessorsName = null;
+                                droppedRecord[this.parent.taskFields.dependency] = null;
+                                droppedRecord.taskData[this.parent.taskFields.dependency] = null;
+                            }
+                        }
                     }
                     if (droppedRecord.ganttProperties.isMilestone) {
                         this.parent.setRecordValue('isMilestone', false, droppedRecord.ganttProperties, true);

package/src/gantt/actions/taskbar-edit.js

@@ -1514,7 +1514,7 @@ var TaskbarEdit = /** @class */ (function (_super) {
         pStartDate.setTime(pStartDate.getTime() + (left * milliSecondsPerPixel));
         /* To render the milestone in proper date while editing */
         if (isMilestone && !isNullOrUndefined(property.predecessorsName) && property.predecessorsName !== '') {
-            pStartDate.setDate(pStartDate.getDate() - 1);
+            //   pStartDate.setDate(pStartDate.getDate()-1);
             this.parent.dateValidationModule.setTime(this.parent.defaultEndTime, pStartDate);
             pStartDate = this.parent.dateValidationModule.checkStartDate(pStartDate, property, true);
         }
@@ -1524,9 +1524,9 @@ var TaskbarEdit = /** @class */ (function (_super) {
             if (this.parent.isInDst(new Date(this.parent.timelineModule.timelineStartDate.toString())) && !this.parent.isInDst(pStartDate)) {
                 pStartDate.setTime(pStartDate.getTime() + (60 * 60 * 1000));
             }
-            else if (!this.parent.isInDst(new Date(this.parent.timelineModule.timelineStartDate.toString())) && this.parent.isInDst(pStartDate)) {
-                pStartDate.setTime(pStartDate.getTime() - (60 * 60 * 1000));
-            }
+            // else if (!this.parent.isInDst(new Date(this.parent.timelineModule.timelineStartDate.toString())) && this.parent.isInDst(pStartDate)) {
+            //     pStartDate.setTime(pStartDate.getTime() - (60 * 60 * 1000));
+            // }
         }
         return pStartDate;
     };

package/src/gantt/base/date-processor.js

@@ -67,7 +67,7 @@ var DateProcessor = /** @class */ (function () {
                     if (!this.parent.includeWeekend) {
                         var tempDate = new Date(cloneStartDate.getTime());
                         cloneStartDate = this.getNextWorkingDay(cloneStartDate);
-                        if (tempDate.getTime() !== cloneStartDate.getTime()) {
+                        if (tempDate.getTime() !== cloneStartDate.getTime() && !validateAsMilestone) {
                             this.setTime(startTime, cloneStartDate);
                         }
                     }

package/src/gantt/base/gantt-chart.js

@@ -347,7 +347,7 @@ var GanttChart = /** @class */ (function () {
         if (this.parent.editSettings.allowTaskbarEditing && this.parent.element.querySelector('.e-left-resize-gripper')) {
             isTaskbarEdited = true;
         }
-        if (!isTaskbarEdited) {
+        if (!isTaskbarEdited || e.button == 2) {
             if (this.parent.editSettings.allowEditing && this.parent.treeGrid.element.getElementsByClassName('e-editedbatchcell').length > 0) {
                 this.parent.treeGrid.endEdit();
             }

package/src/gantt/base/tree-grid.js

@@ -121,7 +121,9 @@ var GanttTreeGrid = /** @class */ (function () {
         this.parent.treeGrid.loadChildOnDemand = this.parent.loadChildOnDemand;
         this.parent.treeGrid['isFromGantt'] = true;
         this.parent.treeGrid.parentIdMapping = this.parent.taskFields.parentID;
-        this.parent.treeGrid.idMapping = this.parent.taskFields.id;
+        if (this.parent.taskFields.parentID) {
+            this.parent.treeGrid.idMapping = this.parent.taskFields.id;
+        }
         this.parent.treeGrid.showColumnMenu = this.parent.showColumnMenu;
         this.parent.treeGrid.enableCollapseAll = this.parent.collapseAllParentTasks;
         this.parent.treeGrid.columnMenuItems = this.parent.columnMenuItems;
@@ -162,7 +164,7 @@ var GanttTreeGrid = /** @class */ (function () {
             toolbarHeight = this.parent.toolbarModule.element.offsetHeight;
         }
         this.parent.treeGrid.height =
-            this.parent.element.getElementsByClassName('e-chart-scroll-container e-content')[0]['offsetHeight'] - 19;
+            this.parent.element.getElementsByClassName('e-chart-scroll-container e-content')[0]['offsetHeight'] - (this.parent.flatData.length == 0 ? 0 : 19);
     };
     GanttTreeGrid.prototype.getContentDiv = function () {
         return this.treeGridElement.querySelector('.e-content');
@@ -674,7 +676,7 @@ var GanttTreeGrid = /** @class */ (function () {
             else {
                 column.headerText = column.headerText ? column.headerText : this.parent.localeObj.getConstant('duration');
             }
-            column.valueAccessor = column.valueAccessor ? column.valueAccessor : !isNullOrUndefined(column.edit) ? null :
+            column.valueAccessor = column.valueAccessor ? column.valueAccessor : !isNullOrUndefined(column.edit) && !isNullOrUndefined(column.edit.read) ? null :
                 this.durationValueAccessor.bind(this);
             column.editType = column.editType ? column.editType : 'stringedit';
             column.type = column.type ? column.type : 'string';
@@ -821,7 +823,7 @@ var GanttTreeGrid = /** @class */ (function () {
      */
     GanttTreeGrid.prototype.composeIDColumn = function (column) {
         var isProjectView = this.parent.viewType === 'ProjectView';
-        var lengthDataSource = this.parent.dataSource['length'];
+        var lengthDataSource = this.parent.dataSource ? this.parent.dataSource['length'] : 0;
         var taskIDName;
         column.isPrimaryKey = isProjectView ? true : false;
         if (this.parent.isLocaleChanged) {

package/src/gantt/renderer/timeline.js

@@ -65,6 +65,10 @@ var Timeline = /** @class */ (function () {
         if (!this.parent.isFromOnPropertyChange) {
             this.parent.updateProjectDates(this.parent.cloneProjectStartDate, this.parent.cloneProjectEndDate, this.parent.isTimelineRoundOff);
         }
+        var timelineContainer = this.parent.element.getElementsByClassName('e-timeline-header-container')[0]['offsetHeight'];
+        this.parent.element.getElementsByClassName('e-gridcontent')[0]['style'].height = 'calc(100% - ' + timelineContainer + 'px)';
+        // eslint-disable-next-line
+        this.parent.element.getElementsByClassName('e-chart-scroll-container e-content')[0]['style'].height = 'calc(100% - ' + timelineContainer + 'px)';
     };
     /**
      * Function used to refresh Gantt rows.
@@ -279,6 +283,7 @@ var Timeline = /** @class */ (function () {
         }
         this.changeTimelineSettings(newTimeline);
         this.parent.isTimelineRoundOff = isNullOrUndefined(this.parent.projectStartDate) ? true : false;
+        this.isZoomToFit = false;
     };
     Timeline.prototype.bottomTierCellWidthCalc = function (mode, zoomLevel, date) {
         var convertedMilliSeconds;
@@ -1429,10 +1434,9 @@ var Timeline = /** @class */ (function () {
                 var validEndLeft = this.parent.dataOperation.getTaskLeft(validEndDate, false);
                 var isChanged = void 0;
                 var taskbarModule = this.parent.editModule.taskbarEditModule;
-                if (!isNullOrUndefined(maxStartLeft) && ((minStartDate < this.timelineStartDate) ||
-                    (!isNullOrUndefined(taskbarModule)) && (!isNullOrUndefined(taskbarModule.taskBarEditAction)
-                        && taskbarModule.taskBarEditAction !== 'ProgressResizing' &&
-                        taskbarModule.taskBarEditAction !== 'RightResizing')) && (maxStartLeft < this.bottomTierCellWidth || maxStartLeft <= validStartLeft)) {
+                if (!isNullOrUndefined(maxStartLeft) && ((!isNullOrUndefined(taskbarModule)) && (!isNullOrUndefined(taskbarModule.taskBarEditAction)
+                    && taskbarModule.taskBarEditAction !== 'ProgressResizing' &&
+                    taskbarModule.taskBarEditAction !== 'RightResizing' && taskbarModule.taskBarEditAction !== 'LeftResizing')) && (maxStartLeft < this.bottomTierCellWidth || maxStartLeft <= validStartLeft)) {
                     isChanged = 'prevTimeSpan';
                     minStartDate = minStartDate > this.timelineStartDate ? this.timelineStartDate : minStartDate;
                 }