@syncfusion/ej2-gantt 20.2.49 → 20.3.47

package/src/gantt/actions/edit.js

@@ -1,5 +1,5 @@
 import { isNullOrUndefined, isUndefined, extend, setValue, getValue, deleteObject, createElement } from '@syncfusion/ej2-base';
-import { DataManager, DataUtil, Query, ODataAdaptor, WebApiAdaptor } from '@syncfusion/ej2-data';
+import { DataManager, Query, ODataAdaptor, WebApiAdaptor } from '@syncfusion/ej2-data';
 import { getUid } from '@syncfusion/ej2-grids';
 import { getSwapKey, isScheduledTask, getTaskData, isRemoteData, getIndex, isCountRequired, updateDates } from '../base/utils';
 import { CellEdit } from './cell-edit';
@@ -497,7 +497,7 @@ var Edit = /** @class */ (function () {
                 this.parent.dataOperation.updateMappingData(ganttData, 'duration');
                 this.parent.dataOperation.updateMappingData(ganttData, 'endDate');
             }
-            else if (key === 'taskType') {
+            else if (key === tasks.type) {
                 ganttObj.setRecordValue('taskType', data[key], ganttData.ganttProperties, true);
                 //this.parent.dataOperation.updateMappingData(ganttData, 'taskType');
             }
@@ -806,6 +806,10 @@ var Edit = /** @class */ (function () {
                 }
                 this.parent.predecessorModule.validatePredecessor(ganttRecord, [], '');
             }
+            if (ganttRecord.hasChildRecords && this.parent.previousRecords[ganttRecord.uniqueID].ganttProperties.startDate &&
+                (args.action === "DrawConnectorLine" || args.action === "DialogEditing")) {
+                this.updateChildItems(ganttRecord);
+            }
             this.updateParentItemOnEditing();
         }
         /** Update parent up-to zeroth level */
@@ -1263,9 +1267,16 @@ var Edit = /** @class */ (function () {
         }
         for (var index = 0; index < currentLength; index++) {
             var recordIndex = [];
-            var resourceID = parseInt(currentResource[index][this.parent.resourceFields.id], 10);
+            var resourceID = parseInt(currentResource[index][this.parent.resourceFields.id], 10).toString();
+            if (resourceID === "NaN") {
+                resourceID = currentResource[index][this.parent.resourceFields.id];
+            }
             for (var i = 0; i < prevResource.length; i++) {
-                if (parseInt(prevResource[i][this.parent.resourceFields.id], 10) === resourceID) {
+                var prevResourceID = parseInt(prevResource[i][this.parent.resourceFields.id], 10).toString();
+                if (prevResourceID === "NaN") {
+                    prevResourceID = prevResource[i][this.parent.resourceFields.id];
+                }
+                if (prevResourceID === resourceID) {
                     recordIndex.push(i);
                     break;
                 }
@@ -1277,7 +1288,11 @@ var Edit = /** @class */ (function () {
                 }
             }
             else {
-                prevResource.splice(parseInt(recordIndex[0].toString(), 10), 1);
+                var record1 = parseInt(recordIndex[0].toString(), 10);
+                if (record1.toString() === "NaN") {
+                    record1 = recordIndex[0].toString();
+                }
+                prevResource.splice(record1, 1);
             }
         }
         var prevLength = prevResource ? prevResource.length : 0;
@@ -1589,14 +1604,26 @@ var Edit = /** @class */ (function () {
      */
     Edit.prototype.deleteResourceRecords = function (selectedRecords) {
         var deleteRecords = [];
-        for (var i = 0; i < selectedRecords.length; i++) {
+        var _loop_1 = function (i) {
             if (selectedRecords[i].parentItem) {
                 var data = selectedRecords[i];
                 var ids = data.ganttProperties.sharedTaskUniqueIds;
                 for (var j = 0; j < ids.length; j++) {
-                    deleteRecords.push(this.parent.flatData[this.parent.ids.indexOf(ids[j].toString())]);
+                    deleteRecords.push(this_1.parent.flatData[this_1.parent.ids.indexOf(ids[j].toString())]);
                 }
+                deleteRecords.push(this_1.parent.flatData[this_1.parent.ids.indexOf(data.ganttProperties.rowUniqueID)]);
+            }
+            else {
+                var resourceParent = this_1.parent.flatData.filter(function (data) {
+                    return (parseInt(data.ganttProperties.taskId) == parseInt(selectedRecords[i].ganttProperties.taskId) &&
+                        data.hasChildRecords);
+                })[0];
+                deleteRecords.push(resourceParent);
             }
+        };
+        var this_1 = this;
+        for (var i = 0; i < selectedRecords.length; i++) {
+            _loop_1(i);
         }
         this.deleteRow(deleteRecords);
     };
@@ -2043,6 +2070,14 @@ var Edit = /** @class */ (function () {
         eventArgs.modifiedTaskData = getTaskData(args.updatedRecordCollection, null, null, this.parent);
         setValue('action', args.action, eventArgs);
         this.parent.isOnDelete = false;
+        if (this.parent.viewType === 'ResourceView') {
+            var updateUnAssignedResources = eventArgs.data.filter(function (data) {
+                return !data.hasChildRecords;
+            });
+            for (var i = 0; i < updateUnAssignedResources.length; i++) {
+                this.checkWithUnassignedTask(updateUnAssignedResources[i]);
+            }
+        }
         this.parent.trigger('actionComplete', eventArgs);
         this.deletedTaskDetails = [];
         this.parent.initiateEditAction(false);
@@ -2054,12 +2089,34 @@ var Edit = /** @class */ (function () {
      * @private
      */
     Edit.prototype.getNewTaskId = function () {
-        var maxId = DataUtil.aggregates.max(this.parent.flatData, this.parent.taskFields.id);
-        if (!isNullOrUndefined(maxId)) {
-            return parseInt(maxId.toString(), 10) + 1;
+        var ids = this.parent.viewType === 'ResourceView' ? this.parent.getTaskIds() : this.parent.ids;
+        var maxId = ids.length;
+        var newTaskId = maxId + 1;
+        if (this.parent.viewType === 'ResourceView') {
+            if (ids.indexOf('T' + newTaskId) !== -1 || ids.indexOf('R' + newTaskId) !== -1) {
+                newTaskId = newTaskId + 1;
+                if (ids.indexOf('T' + newTaskId) !== -1 || ids.indexOf('R' + newTaskId) !== -1) {
+                    do {
+                        newTaskId = newTaskId + 1;
+                    } while (ids.indexOf('T' + newTaskId) !== -1 || ids.indexOf('R' + newTaskId) !== -1);
+                }
+            }
+        }
+        else {
+            if (ids.indexOf(newTaskId.toString()) != -1) {
+                newTaskId = newTaskId + 1;
+                if (ids.indexOf(newTaskId.toString()) != -1) {
+                    do {
+                        newTaskId = newTaskId + 1;
+                    } while (ids.indexOf(newTaskId.toString()) != -1);
+                }
+            }
+        }
+        if (this.parent.columnByField[this.parent.taskFields.id].editType === "stringedit") {
+            return newTaskId = newTaskId.toString();
         }
         else {
-            return 1;
+            return newTaskId;
         }
     };
     /**
@@ -2072,6 +2129,7 @@ var Edit = /** @class */ (function () {
     Edit.prototype.prepareNewlyAddedData = function (obj, rowPosition) {
         var taskModel = this.parent.taskFields;
         var id;
+        var newTaskIDmd;
         var ids = this.parent.ids;
         /*Validate Task Id of data*/
         if (obj[taskModel.id]) {
@@ -2079,7 +2137,13 @@ var Edit = /** @class */ (function () {
                 obj[taskModel.id] = null;
             }
             else {
-                obj[taskModel.id] = isNullOrUndefined(obj[taskModel.id]) ? null : parseInt(obj[taskModel.id], 10);
+                if (typeof (obj[taskModel.id]) === "string") {
+                    newTaskIDmd = obj[taskModel.id];
+                }
+                else {
+                    newTaskIDmd = parseInt(obj[taskModel.id], 10);
+                }
+                obj[taskModel.id] = isNullOrUndefined(newTaskIDmd) ? null : newTaskIDmd;
             }
         }
         if (!obj[taskModel.id]) {
@@ -2319,7 +2383,7 @@ var Edit = /** @class */ (function () {
                     recordIndex = currentItemIndex + dataChildCount + 1;
                     //Expand Add record's parent item for project view
                     if (!this.addRowSelectedItem.expanded && !this.parent.enableMultiTaskbar) {
-                        this.parent.expandByID(Number(this.addRowSelectedItem.ganttProperties.rowUniqueID));
+                        this.parent.expandByID(this.addRowSelectedItem.ganttProperties.rowUniqueID);
                     }
                     updatedCollectionIndex = currentViewData.indexOf(this.addRowSelectedItem) +
                         this.getVisibleChildRecordCount(this.addRowSelectedItem, 0, currentViewData) + 1;
@@ -2359,6 +2423,10 @@ var Edit = /** @class */ (function () {
         /* Record collection update */
         flatRecords.splice(recordIndex, 0, record);
         currentViewData.splice(updatedCollectionIndex, 0, record);
+        if (this.parent.viewType === 'ResourceView' && typeof (record.ganttProperties.taskId) === "number") {
+            var taskString = record.ganttProperties.taskId;
+            ids.push(taskString.toString());
+        }
         ids.splice(recordIndex, 0, record.ganttProperties.rowUniqueID.toString());
         if (this.parent.viewType === 'ResourceView') {
             var taskId = record.level === 0 ? 'R' + record.ganttProperties.taskId : 'T' + record.ganttProperties.taskId;
@@ -2460,27 +2528,27 @@ var Edit = /** @class */ (function () {
                 }
             }
         }
-        var _loop_1 = function (i) {
-            var originalData = this_1.parent.modifiedRecords[i];
-            var treeIndex = this_1.parent.allowRowDragAndDrop ? 1 : 0;
-            var uniqueTaskID = this_1.parent.taskFields.id;
-            originalIndex = this_1.parent.currentViewData.findIndex(function (data) {
+        var _loop_2 = function (i) {
+            var originalData = this_2.parent.modifiedRecords[i];
+            var treeIndex = this_2.parent.allowRowDragAndDrop ? 1 : 0;
+            var uniqueTaskID = this_2.parent.taskFields.id;
+            originalIndex = this_2.parent.currentViewData.findIndex(function (data) {
                 return (data[uniqueTaskID] == originalData[uniqueTaskID]);
             });
-            if (this_1.parent.treeGrid.getRows()[originalIndex]) {
-                this_1.parent.treeGrid.renderModule.cellRender({
-                    data: originalData, cell: this_1.parent.treeGrid.getRows()[originalIndex].cells[this_1.parent.treeColumnIndex + treeIndex],
-                    column: this_1.parent.treeGrid.grid.getColumns()[this_1.parent.treeColumnIndex],
+            if (this_2.parent.treeGrid.getRows()[originalIndex]) {
+                this_2.parent.treeGrid.renderModule.cellRender({
+                    data: originalData, cell: this_2.parent.treeGrid.getRows()[originalIndex].cells[this_2.parent.treeColumnIndex + treeIndex],
+                    column: this_2.parent.treeGrid.grid.getColumns()[this_2.parent.treeColumnIndex],
                     requestType: 'rowDragAndDrop'
                 });
-                this_1.parent.treeGrid.renderModule.RowModifier({
-                    data: originalData, row: this_1.parent.treeGrid.getRows()[originalIndex], rowHeight: this_1.parent.rowHeight
+                this_2.parent.treeGrid.renderModule.RowModifier({
+                    data: originalData, row: this_2.parent.treeGrid.getRows()[originalIndex], rowHeight: this_2.parent.rowHeight
                 });
             }
         };
-        var this_1 = this, originalIndex;
+        var this_2 = this, originalIndex;
         for (var i = 0; i < this.parent.modifiedRecords.length; i++) {
-            _loop_1(i);
+            _loop_2(i);
         }
     };
     /**
@@ -2567,6 +2635,7 @@ var Edit = /** @class */ (function () {
      */
     Edit.prototype.addRecord = function (data, rowPosition, rowIndex) {
         var _this = this;
+        var tempTaskID = this.parent.taskFields.id;
         if (this.parent.editModule && this.parent.editSettings.allowAdding) {
             this.parent.isDynamicData = true;
             var cAddedRecord_1 = [];
@@ -2588,6 +2657,12 @@ var Edit = /** @class */ (function () {
             args = this.constructTaskAddedEventArgs(cAddedRecord_1, this.parent.editedRecords, 'beforeAdd');
             this.parent.showSpinner();
             this.parent.trigger('actionBegin', args, function (args) {
+                if (!isNullOrUndefined(args.data[tempTaskID])) {
+                    if (args.data[tempTaskID] != args.data['ganttProperties']['taskId']) {
+                        args.data['ganttProperties']['taskId'] = args.data[tempTaskID];
+                        args.newTaskData[tempTaskID] = args.data[tempTaskID];
+                    }
+                }
                 if (!args.cancel) {
                     if (isRemoteData(_this.parent.dataSource)) {
                         var data_2 = _this.parent.dataSource;

package/src/gantt/actions/filter.d.ts

@@ -15,6 +15,7 @@ export declare class Filter {
     private updateCustomFilters;
     private updateModel;
     private addEventListener;
+    private wireEvents;
     private initiateFiltering;
     /**
      * To get filter menu UI
@@ -23,6 +24,8 @@ export declare class Filter {
      * @returns {IFilterMUI} .
      */
     private getCustomFilterUi;
+    private mouseClickHandler;
+    private unWireEvents;
     private getDatePickerFilter;
     private getDateTimePickerFilter;
     private getDurationFilter;
@@ -36,7 +39,6 @@ export declare class Filter {
     private actionBegin;
     closeFilterOnContextClick(element: Element): void;
     private actionComplete;
-    private setPosition;
     private updateFilterMenuPosition;
     private removeEventListener;
     /**

package/src/gantt/actions/filter.js

@@ -1,7 +1,7 @@
 import { TreeGrid, Filter as TreeGridFilter } from '@syncfusion/ej2-treegrid';
-import { filterAfterOpen, getFilterMenuPostion } from '@syncfusion/ej2-grids';
+import { filterAfterOpen } from '@syncfusion/ej2-grids';
 import { getActualProperties, getCustomDateFormat } from '@syncfusion/ej2-grids';
-import { getValue, isNullOrUndefined, remove, createElement, addClass, closest } from '@syncfusion/ej2-base';
+import { getValue, isNullOrUndefined, remove, createElement, addClass, closest, EventHandler } from '@syncfusion/ej2-base';
 import { TextBox } from '@syncfusion/ej2-inputs';
 import { DatePicker, DateTimePicker } from '@syncfusion/ej2-calendars';
 /**
@@ -45,10 +45,13 @@ var Filter = /** @class */ (function () {
         this.parent.on('actionComplete', this.actionComplete, this);
         this.parent.on('columnMenuOpen', this.columnMenuOpen, this);
     };
+    Filter.prototype.wireEvents = function (a) {
+        EventHandler.add(document.getElementById(a), 'click', this.mouseClickHandler, this);
+    };
     Filter.prototype.initiateFiltering = function (column) {
         var treeColumn = this.parent.getColumnByField(column.field, this.parent.treeGridModule.treeGridColumns);
         column.allowFiltering = column.allowFiltering === false ? false : true;
-        if (column.allowFiltering && this.parent.filterSettings.type === 'Menu' && !column.filter) {
+        if (column.allowFiltering && (this.parent.filterSettings.type === 'Menu' || this.parent.filterSettings.type === 'Excel') && !column.filter) {
             column.filter = { ui: this.getCustomFilterUi(column) };
         }
         if (treeColumn) {
@@ -78,6 +81,14 @@ var Filter = /** @class */ (function () {
         }
         return filterUI;
     };
+    Filter.prototype.mouseClickHandler = function (e) {
+        if (closest(e.target, ".e-excelfilter")) {
+            this.parent.treeGrid.grid.notify("click", e);
+        }
+    };
+    Filter.prototype.unWireEvents = function () {
+        EventHandler.remove(this.parent.element, 'click', this.mouseClickHandler);
+    };
     Filter.prototype.getDatePickerFilter = function (columnName) {
         var _this = this;
         var parent = this.parent;
@@ -199,6 +210,15 @@ var Filter = /** @class */ (function () {
         }
     };
     Filter.prototype.actionComplete = function (args) {
+        if (!isNullOrUndefined(args['filterModel'])) {
+            if (!isNullOrUndefined(args['filterModel']['dialogObj'])) {
+                if (!isNullOrUndefined(args['filterModel']['dialogObj']['element'])) {
+                    if (this.parent.filterSettings.type === 'Excel') {
+                        this.wireEvents(args['filterModel']['dialogObj']['element'].id);
+                    }
+                }
+            }
+        }
         if (args.requestType === filterAfterOpen) {
             if (this.parent.treeGrid.filterSettings.type === 'Menu') {
                 this.filterMenuElement = getValue('filterModel.dlgObj.element', args);
@@ -216,12 +236,15 @@ var Filter = /** @class */ (function () {
             if ((args.columnName === predecessor && isNullOrUndefined(getValue(predecessor, filterValues)))
                 || (args.columnName === resource && isNullOrUndefined(getValue(resource, filterValues)))) {
                 var element = this.filterMenuElement.querySelector('.e-dropdownlist');
-                var instanceObj = getValue('ej2_instances[0]', element);
-                instanceObj.index = 2;
-                instanceObj.dataBind();
+                var instanceObj = void 0;
+                if (!isNullOrUndefined(element)) {
+                    instanceObj = getValue('ej2_instances[0]', element);
+                    instanceObj.index = 2;
+                    instanceObj.dataBind();
+                }
             }
             else if (args.columnName === taskID && isNullOrUndefined(getValue(taskID, filterValues)) && this.parent.treeGrid.filterSettings.type === 'Menu') {
-                var element = this.filterMenuElement.querySelector('.e-numerictextbox');
+                var element = this.filterMenuElement.querySelector('.e-flmenu-input');
                 var instanceObj = getValue('ej2_instances[0]', element);
                 if (!isNullOrUndefined(instanceObj) && isNullOrUndefined(this.parent.columnByField[args.columnName].format)) {
                     instanceObj.format = 'n';
@@ -229,45 +252,9 @@ var Filter = /** @class */ (function () {
             }
         }
     };
-    Filter.prototype.setPosition = function (li, ul) {
-        var gridPos = this.parent.element.getBoundingClientRect();
-        var liPos = li.getBoundingClientRect();
-        var left = liPos.right + window.scrollX;
-        var top = liPos.top + window.scrollY;
-        if (gridPos.right < (left + ul.offsetWidth)) {
-            if ((liPos.left - ul.offsetWidth) > gridPos.left) {
-                left = (liPos.left - ul.offsetWidth);
-            }
-            else {
-                left -= (left + ul.offsetWidth) - gridPos.right;
-            }
-        }
-        ul.style.top = top + 'px';
-        ul.style.left = left + 'px';
-    };
     Filter.prototype.updateFilterMenuPosition = function (element, args) {
         addClass([element], 'e-gantt');
-        document.querySelector('#' + this.parent.controlId).appendChild(element);
-        var targetElement;
-        if (this.parent.showColumnMenu) {
-            targetElement = document.querySelector('#treeGrid' + this.parent.controlId + '_gridcontrol_colmenu_Filter');
-            element.style.zIndex = targetElement.parentElement.style.zIndex;
-            if (this.parent.treeGrid.filterSettings.type === 'Menu') {
-                this.setPosition(targetElement, getValue('filterModel.dlgObj.element', args));
-            }
-            else {
-                this.setPosition(targetElement, getValue('filterModel.dialogObj.element', args));
-            }
-        }
-        else {
-            targetElement = this.parent.treeGrid.grid.getColumnHeaderByField(args.columnName).querySelector('.e-filtermenudiv');
-            if (this.parent.treeGrid.filterSettings.type === 'Menu') {
-                getFilterMenuPostion(targetElement, getValue('filterModel.dlgObj', args));
-            }
-            else {
-                getFilterMenuPostion(targetElement, getValue('filterModel.dialogObj', args));
-            }
-        }
+        document.querySelector('#' + this.parent.treeGrid.grid.element.id).appendChild(element);
         if (this.parent.treeGrid.filterSettings.type === 'Menu') {
             element.querySelector('.e-valid-input').focus();
         }
@@ -288,6 +275,7 @@ var Filter = /** @class */ (function () {
      */
     Filter.prototype.destroy = function () {
         this.removeEventListener();
+        this.unWireEvents();
     };
     return Filter;
 }());

package/src/gantt/actions/keyboard.js

@@ -248,7 +248,7 @@ var FocusModule = /** @class */ (function () {
             if (ganttObj.selectionSettings.mode !== 'Cell' && ganttObj.selectedRowIndex !== -1) {
                 var selectedItem = ganttObj.currentViewData[ganttObj.selectedRowIndex];
                 var focusedRowIndex = this.parent.ganttChartModule.focusedRowIndex;
-                var selectingRowIndex = focusedRowIndex > -1 ? focusedRowIndex : expandedRecords.indexOf(selectedItem);
+                var selectingRowIndex = expandedRecords.indexOf(selectedItem);
                 var currentSelectingRecord = e.action === 'downArrow' ? expandedRecords[selectingRowIndex + 1] :
                     expandedRecords[selectingRowIndex - 1];
                 ganttObj.selectionModule.selectRow(ganttObj.currentViewData.indexOf(currentSelectingRecord), false, true);

package/src/gantt/actions/rowdragdrop.js

@@ -119,7 +119,7 @@ var RowDD = /** @class */ (function () {
     };
     RowDD.prototype.rowDragStartHelper = function (args) {
         this.parent.trigger('rowDragStartHelper', args);
-        if (this.parent.readOnly || this.parent.filterSettings.columns.length > 0) {
+        if (this.parent.readOnly) {
             args.cancel = true;
         }
         if (this.parent.viewType === 'ResourceView' && getValue('level', args.data[0]) === 0) {
@@ -255,7 +255,7 @@ var RowDD = /** @class */ (function () {
                         var uniqueTaskID_1 = this_1.parent.taskFields.id;
                         if (draggedRecord.index < droppedRecord.index) {
                             startIndex = draggedRecord.index;
-                            var _loop_2 = function (i_1) {
+                            var _loop_3 = function (i_1) {
                                 var currentData = this_1.parent.currentViewData.filter(function (e) {
                                     return e[uniqueTaskID_1] === ganttData_1[i_1][uniqueTaskID_1];
                                 })[0];
@@ -265,14 +265,14 @@ var RowDD = /** @class */ (function () {
                                 }
                             };
                             for (var i_1 = 0; i_1 < ganttData_1.length; i_1++) {
-                                var state_2 = _loop_2(i_1);
+                                var state_2 = _loop_3(i_1);
                                 if (state_2 === "break")
                                     break;
                             }
                         }
                         else {
                             startIndex = droppedRecord.index;
-                            var _loop_3 = function (i_2) {
+                            var _loop_4 = function (i_2) {
                                 var currentData = this_1.parent.currentViewData.filter(function (e) {
                                     return e[uniqueTaskID_1] === ganttData_1[i_2][uniqueTaskID_1];
                                 })[0];
@@ -282,12 +282,12 @@ var RowDD = /** @class */ (function () {
                                 }
                             };
                             for (var i_2 = 0; i_2 < ganttData_1.length; i_2++) {
-                                var state_3 = _loop_3(i_2);
+                                var state_3 = _loop_4(i_2);
                                 if (state_3 === "break")
                                     break;
                             }
                         }
-                        var _loop_4 = function (i_3) {
+                        var _loop_5 = function (i_3) {
                             if (!isNullOrUndefined(data_1[i_3])) {
                                 data_1[i_3].index = i_3;
                                 if (!isNullOrUndefined(data_1[i_3].parentItem)) {
@@ -299,7 +299,7 @@ var RowDD = /** @class */ (function () {
                             }
                         };
                         for (var i_3 = startIndex; i_3 <= endIndex; i_3++) {
-                            _loop_4(i_3);
+                            _loop_5(i_3);
                         }
                     }
                     gObj.rowDragAndDropModule.refreshDataSource();
@@ -360,6 +360,66 @@ var RowDD = /** @class */ (function () {
                         this.updateSharedResourceTask();
                     }
                 }
+                if (this.parent.taskFields.dependency) {
+                    var isValidPredecessor = true;
+                    var draggedParent = void 0;
+                    var toParent_1;
+                    if (draggedRecord.parentItem) {
+                        draggedParent = this.parent.currentViewData[this.parent.ids.indexOf(draggedRecord.parentItem.taskId)];
+                    }
+                    else {
+                        draggedParent = draggedRecord;
+                    }
+                    if (droppedRecord.parentItem) {
+                        toParent_1 = this.parent.currentViewData[this.parent.ids.indexOf(droppedRecord.parentItem.taskId)];
+                    }
+                    else {
+                        toParent_1 = droppedRecord;
+                    }
+                    var validateRecords = void 0;
+                    if (toParent_1.uniqueID === draggedParent.uniqueID || (draggedParent.parentItem &&
+                        toParent_1.uniqueID == this.parent.currentViewData[this.parent.ids.indexOf(draggedParent.parentItem.taskId)].uniqueID)) {
+                        validateRecords = this.parent.currentViewData.filter(function (data) {
+                            if ((data.ganttProperties.predecessor && data.ganttProperties.predecessor.length > 0)) {
+                                for (var i = 0; i < data.ganttProperties.predecessor.length; i++) {
+                                    return (parseInt(data.ganttProperties.predecessor[i].to) === parseInt(toParent_1.ganttProperties.taskId) ||
+                                        parseInt(data.ganttProperties.predecessor[i].from) === parseInt(toParent_1.ganttProperties.taskId));
+                                }
+                            }
+                            return null;
+                        });
+                        var predName = [];
+                        for (var i = 0; i < validateRecords.length; i++) {
+                            predName = [];
+                            if (validateRecords[i].ganttProperties.predecessor) {
+                                for (var k = 0; k < validateRecords[i].ganttProperties.predecessor.length; k++) {
+                                    if (parseInt(validateRecords[i].ganttProperties.taskId) !==
+                                        parseInt(validateRecords[i].ganttProperties.predecessor[k].from)) {
+                                        predName.push(validateRecords[i].ganttProperties.predecessor[k].from);
+                                    }
+                                    else {
+                                        predName.push(validateRecords[i].ganttProperties.predecessor[k].to);
+                                    }
+                                }
+                            }
+                            var _loop_2 = function (j) {
+                                var name_1 = predName[j].replace(/\D/g, '');
+                                var toRec = this_2.parent.currentViewData.filter(function (data) {
+                                    return parseInt(data.ganttProperties.taskId) == parseInt(name_1);
+                                });
+                                isValidPredecessor = this_2.parent.connectorLineEditModule.validateParentPredecessor(validateRecords[i], toRec[0]);
+                                if (!isValidPredecessor) {
+                                    this_2.parent.dataOperation['resetDependency'](validateRecords[i]);
+                                    this_2.parent.dataOperation['resetDependency'](toRec[0]);
+                                }
+                            };
+                            var this_2 = this;
+                            for (var j = 0; j < predName.length; j++) {
+                                _loop_2(j);
+                            }
+                        }
+                    }
+                }
                 // method to update the edited parent records
                 for (var j = 0; j < this.updateParentRecords.length; j++) {
                     this.parent.dataOperation.updateParentItems(this.updateParentRecords[j]);
@@ -740,7 +800,7 @@ var RowDD = /** @class */ (function () {
                 }
                 var idx = void 0;
                 var ganttData = dataSource.length > 0 && this.parent.viewType !== 'ResourceView' ?
-                    dataSource : this.parent.updatedRecords;
+                    dataSource : this.parent.flatData;
                 for (var i = 0; i < ganttData.length; i++) {
                     if (this.parent.viewType === 'ResourceView') {
                         if (ganttData[i].ganttProperties.rowUniqueID === deletedRow.ganttProperties.rowUniqueID) {

package/src/gantt/actions/taskbar-edit.js

@@ -102,6 +102,9 @@ var TaskbarEdit = /** @class */ (function (_super) {
         }
     };
     TaskbarEdit.prototype.mouseClickHandler = function (e) {
+        if (!this.parent.editSettings.allowTaskbarEditing) {
+            return;
+        }
         var targetElement = this.getElementByPosition(e);
         var element = parentsUntil(targetElement, cls.taskBarMainContainer);
         if (this.parent.selectionModule && this.parent.selectionModule.enableSelectMultiTouch) {
@@ -634,10 +637,13 @@ var TaskbarEdit = /** @class */ (function (_super) {
         var _this = this;
         this.stopScrollTimer();
         this.scrollTimer = window.setInterval(function () {
-            if (direction === 'right' || direction === 'bottom') {
+            if (direction === 'right') {
                 _this.timerCount = (_this.timerCount + 1) >= _this.parent.timelineModule.totalTimelineWidth ?
                     _this.parent.timelineModule.totalTimelineWidth : (_this.timerCount + 1);
             }
+            else if (direction === 'bottom') {
+                _this.timerCount = _this.timerCount + 1;
+            }
             else {
                 _this.timerCount = (_this.timerCount - 1) < 0 ? 0 : (_this.timerCount - 1);
             }
@@ -1745,8 +1751,14 @@ var TaskbarEdit = /** @class */ (function (_super) {
             }
             if ((this.parent.virtualScrollModule && this.parent.enableVirtualization &&
                 !this.elementOffsetLeft) || !this.parent.enableVirtualization) {
-                this.elementOffsetLeft = this.taskBarEditElement.offsetLeft;
-                this.elementOffsetTop = this.taskBarEditElement.offsetTop + scrollTop;
+                if (this.taskBarEditElement.children[0].classList.contains('e-manualparent-main-container')) {
+                    this.elementOffsetLeft = this.taskBarEditElement.children[0]['offsetLeft'] + this.taskBarEditElement.offsetLeft;
+                    this.elementOffsetTop = ((this.taskBarEditElement.offsetTop - 5) + this.taskBarEditElement.children[0]['offsetTop']) + scrollTop;
+                }
+                else {
+                    this.elementOffsetLeft = this.taskBarEditElement.offsetLeft;
+                    this.elementOffsetTop = this.taskBarEditElement.offsetTop + scrollTop;
+                }
                 this.elementOffsetWidth = this.taskBarEditElement.offsetWidth;
                 this.elementOffsetHeight = this.taskBarEditElement.offsetHeight;
             }

package/src/gantt/actions/toolbar.js

@@ -405,7 +405,7 @@ var Toolbar = /** @class */ (function () {
             var isDeleteSelected = gObj.selectionModule ? gObj.selectionModule.selectedRowIndexes.length > 0 ||
                 gObj.selectionModule.getSelectedRowCellIndexes().length > 0 ? true : false : false;
             // eslint-disable-next-line
-            edit.allowDeleting && isResouceParent && hasData && isDeleteSelected && !touchEdit ?
+            edit.allowDeleting && hasData && isDeleteSelected && !touchEdit ?
                 enableItems.push(gID + '_delete') : disableItems.push(gID + '_delete');
             if (gObj.editSettings.mode === 'Auto' && !isNullOrUndefined(gObj.editModule.cellEditModule)
                 && gObj.editModule.cellEditModule.isCellEdit) {

package/src/gantt/base/enum.d.ts

@@ -128,7 +128,9 @@ export declare type DialogFieldType =
  */
 export declare type FilterType = 
 /** Defines filter type as menu */
-'Menu';
+'Menu' | 
+/** Specifies the filtersetting type as excel */
+'Excel';
 /**
  * To define hierarchy mode on filter action
  */

package/src/gantt/base/gantt-chart.js

@@ -175,7 +175,7 @@ var GanttChart = /** @class */ (function () {
     GanttChart.prototype.renderTimelineContainer = function () {
         this.chartTimelineContainer =
             createElement('div', { className: cls.timelineHeaderContainer });
-        this.chartTimelineContainer.setAttribute("role", "TimelineHeader");
+        this.chartTimelineContainer.setAttribute("role", "presentation");
         this.chartElement.appendChild(this.chartTimelineContainer);
     };
     /**
@@ -301,12 +301,10 @@ var GanttChart = /** @class */ (function () {
         }
     };
     GanttChart.prototype.ganttChartMouseClick = function (e) {
-        if (this.parent.editSettings.allowTaskbarEditing) {
-            if (this.parent.autoFocusTasks) {
-                this.scrollToTarget(e); /** Scroll to task */
-            }
-            this.parent.notify('chartMouseClick', e);
+        if (this.parent.autoFocusTasks) {
+            this.scrollToTarget(e); /** Scroll to task */
         }
+        this.parent.notify('chartMouseClick', e);
     };
     GanttChart.prototype.ganttChartMouseUp = function (e) {
         if (this.parent.editSettings.allowTaskbarEditing) {
@@ -640,6 +638,10 @@ var GanttChart = /** @class */ (function () {
         this.parent.updatedConnectorLineCollection = [];
         this.parent.predecessorModule.createConnectorLinesCollection();
         this.parent.connectorLineModule.renderConnectorLines(this.parent.updatedConnectorLineCollection);
+        if (this.parent.enableCriticalPath && this.parent.criticalPathModule) {
+            var criticalModule = this.parent.criticalPathModule;
+            criticalModule.criticalConnectorLine(criticalModule.criticalPathCollection, criticalModule.detailPredecessorCollection, true, criticalModule.predecessorCollectionTaskIds);
+        }
     };
     /**
      * To collapse gantt rows