@synap-core/workspace-templates 0.12.0 → 0.23.0

package/src/builder-dev-fold.template.test.ts

@@ -0,0 +1,113 @@
+/**
+ * R7 (2026-09-27, option A): dev-dashboard and agent-fleet are RETIRED as
+ * templates; the four dev-dashboard views worth keeping were rebuilt over
+ * builder-workspace's OWN kinds, and Builder's display name became "Dev".
+ *
+ * What this guards, driven through the same seam every door uses
+ * (`toWorkspaceDefinition`, which the devplane app, CLI, browser and
+ * marketplace install all call):
+ *   1. each folded view is PRESENT and every field it names (groupBy, sortBy,
+ *      columns) is a property the scoped Builder profile actually declares —
+ *      reachability, not shape: a kanban grouped by a slug no profile has
+ *      renders one "No value" lane forever and every type still checks;
+ *   2. no folded view scopes a kind that was deliberately NOT ported
+ *      (credential / vendor / repository / service / environment from
+ *      dev-dashboard, `agent` from agent-fleet);
+ *   3. both retired slugs are gone from the bundle, so nothing can install
+ *      them and the boot reconcile resolves them to null (skipped);
+ *   4. the rename is display-only: slug + proposalId are the identity keys
+ *      (package-dependency-resolver, fingerprint, devplane door) and must not
+ *      move.
+ */
+import { describe, expect, it } from "vitest";
+import { WORKSPACE_TEMPLATES, getWorkspaceTemplate } from "./templates.js";
+import { toWorkspaceDefinition } from "./define.js";
+
+const FOLDED_VIEWS = [
+  "Service Health",
+  "Services by Type",
+  "Deploy Timeline",
+  "Provider Costs",
+] as const;
+
+const NOT_PORTED_KINDS = [
+  "credential",
+  "vendor",
+  "repository",
+  "service",
+  "environment",
+  "agent",
+];
+
+// Base properties every entity has (title is the entity's own column).
+const INTRINSIC_COLUMNS = new Set(["title"]);
+
+type View = {
+  name: string;
+  scopeProfileSlug?: string;
+  groupBy?: string;
+  sortBy?: string;
+  config?: { columns?: unknown[] };
+};
+
+const def = toWorkspaceDefinition("builder-workspace");
+const tpl = getWorkspaceTemplate("builder-workspace")!;
+const views = (def.definition as { views?: View[] }).views ?? [];
+const propsOf = (profileSlug: string): Set<string> =>
+  new Set(
+    (tpl.profiles ?? [])
+      .find((p) => p.slug === profileSlug)
+      ?.properties.map((p) => p.slug) ?? []
+  );
+
+describe("builder-workspace — dev-dashboard fold (R7)", () => {
+  it.each(FOLDED_VIEWS)("%s arrives and names only real properties", (name) => {
+    const view = views.find((v) => v.name === name);
+    expect(view, `${name} missing from the definition`).toBeDefined();
+    const scope = view!.scopeProfileSlug!;
+    const props = propsOf(scope);
+    // Non-vacuity: the scoped profile must exist AND carry properties.
+    expect(props.size, `${name} scopes "${scope}" which declares no properties`).toBeGreaterThan(0);
+
+    const named = [
+      view!.groupBy,
+      view!.sortBy,
+      ...((view!.config?.columns as string[] | undefined) ?? []),
+    ].filter((s): s is string => typeof s === "string");
+    expect(named.length, `${name} names no field at all`).toBeGreaterThan(0);
+    const unknown = named.filter((s) => !props.has(s) && !INTRINSIC_COLUMNS.has(s));
+    expect(unknown, `${name} names fields ${scope} does not declare`).toEqual([]);
+  });
+
+  it("never ports a retired kind", () => {
+    const declared = new Set((tpl.profiles ?? []).map((p) => p.slug));
+    for (const kind of NOT_PORTED_KINDS) expect(declared.has(kind), kind).toBe(false);
+    for (const name of FOLDED_VIEWS) {
+      const scope = views.find((v) => v.name === name)?.scopeProfileSlug;
+      expect(NOT_PORTED_KINDS).not.toContain(scope);
+    }
+  });
+
+  it("the Services sidebar item opens a view that exists", () => {
+    const layout = (def.definition as {
+      layoutConfig?: { sidebarItems?: Array<{ viewName?: string; label?: string }> };
+    }).layoutConfig;
+    const item = layout?.sidebarItems?.find((i) => i.label === "Services");
+    expect(item?.viewName).toBe("Service Health");
+    expect(views.some((v) => v.name === item!.viewName)).toBe(true);
+  });
+
+  it("dev-dashboard and agent-fleet are retired from the bundle", () => {
+    // Non-vacuity: the bundle is the real corpus.
+    expect(Object.keys(WORKSPACE_TEMPLATES).length).toBeGreaterThan(20);
+    expect(getWorkspaceTemplate("dev-dashboard")).toBeUndefined();
+    expect(getWorkspaceTemplate("agent-fleet")).toBeUndefined();
+  });
+
+  it('display name is "Dev"; the identity keys did not move', () => {
+    expect(tpl.meta.name).toBe("Dev");
+    expect(def.definition.workspaceName).toBe("Dev");
+    expect(tpl.meta.slug).toBe("builder-workspace");
+    expect(def.proposalId).toBe("builder-workspace-v1");
+  });
+});