@symbiote-native/engine 1.1.0 → 1.3.0

package/cpp/SymbioteTree.cpp

@@ -18,9 +18,10 @@
 #include <react/renderer/uimanager/primitives.h>
 
 // `react/renderer/dom/` is NOT among the header folders ReactAndroid copies into its prefab
-// (`ReactAndroid/build.gradle.kts` lists uimanager, mounting, core, … and no dom), so including it
-// unconditionally breaks the Android build of this same file. iOS compiles against the full
-// ReactCommon tree and has it.
+// (`ReactAndroid/build.gradle.kts` lists uimanager, mounting, core, … and no dom), though
+// libreactnative.so exports the functions. `android/CMakeLists.txt` copies `DOM.h` from the app's
+// react-native onto the include path; without it this falls back to the throwing stubs. iOS compiles
+// against the full ReactCommon tree and has it.
 //
 // Detected rather than branched on `__ANDROID__`, because the fact is about the TOOLCHAIN'S HEADERS,
 // not about the platform — and it self-heals the day upstream exports the folder. The three
@@ -73,6 +74,13 @@ constexpr int32_t kOpCreateVoid = 13;
 // The owned listener names any platform rule reads, one bit each — see `Node::pressListeners`.
 // `press` is deliberately bit 0 so the `focusable` question is the cheapest of the two.
 constexpr uint8_t kPressListenerPress = 1u << 0;
+// The four press names; `hasAnyPressListener` asks about these and nothing else.
+constexpr uint8_t kPressListenerMask = 0x0f;
+// ScrollView's `sendMomentumEvents` (`ScrollView.js:1801-1804`) asks about either of these two.
+constexpr uint8_t kMomentumListenerMask = (1u << 4) | (1u << 5);
+// Text's pressability (`Text.js:145-163`): onPress / onLongPress, plus onStartShouldSetResponder.
+constexpr uint8_t kTextPressMask = kPressListenerPress | (1u << 3);
+constexpr uint8_t kStartShouldSetResponder = 1u << 6;
 
 /** 0 for a name the host has no rule for, which is nearly all of them. */
 uint8_t pressListenerBit(const std::string &name) {
@@ -80,6 +88,9 @@ uint8_t pressListenerBit(const std::string &name) {
   if (name == "pressIn") return 1u << 1;
   if (name == "pressOut") return 1u << 2;
   if (name == "longPress") return 1u << 3;
+  if (name == "momentumScrollBegin") return 1u << 4;
+  if (name == "momentumScrollEnd") return 1u << 5;
+  if (name == "startShouldSetResponder") return kStartShouldSetResponder;
   return 0;
 }
 
@@ -327,7 +338,27 @@ struct Node : jsi::NativeState {
   //
   // The reference applier has no such window (a JS child's `parent` reference keeps the parent
   // alive), so nothing headless can reach this and there is no test to write for it.
+  /**
+   * How many nodes this process is holding, right now.
+   *
+   * The one reading nothing else can produce. Ownership here is JS-anchored — `children` is strong,
+   * `parent` is raw, and a node lives while a parent holds it or while JS names it through
+   * `NativeState` — so "JS gave its half back" IMPLIES the C++ half went with it. That is an
+   * inference from the ownership model, and the shape it would miss is the one
+   * software-mansion/react-native-reanimated#10527 describes: a container keyed by surface that
+   * nothing empties, holding a root alive after the surface is gone. We have no such container; this
+   * counter is what turns "we have no such container" from a reading of the code into a reading of
+   * the process.
+   *
+   * Not atomic, and deliberately: a commit walk is single-threaded, and the counter exists for a
+   * test rather than for a report anything acts on.
+   */
+  static inline int64_t live = 0;
+
+  Node() { live += 1; }
+
   ~Node() {
+    live -= 1;
     for (const NodePtr &child : children) {
       // A HOLE, from a detach nothing has read past yet. The destructor is the one reader that does
       // not compact first: compaction renumbers, and renumbering a vector whose owner is being
@@ -1035,15 +1066,18 @@ IOwner ownerOf(const Node &node) {
       node.parent->tagName.c_str(),
       (node.parent->pressListeners & kPressListenerPress) != 0,
       node.parent->underlayShown,
-      node.parent->pressListeners != 0};
+      (node.parent->pressListeners & kPressListenerMask) != 0};
 }
 
 /** The node's own non-prop bits, unpacked from the mask the ops maintain. See `ISelf`. */
 ISelf selfOf(const Node &node) {
   return ISelf{
       (node.pressListeners & kPressListenerPress) != 0,
-      node.pressListeners != 0,
-      node.underlayShown};
+      (node.pressListeners & kPressListenerMask) != 0,
+      node.underlayShown,
+      (node.pressListeners & kMomentumListenerMask) != 0,
+      (node.pressListeners & kTextPressMask) != 0,
+      (node.pressListeners & kStartShouldSetResponder) != 0};
 }
 
 /**
@@ -2578,6 +2612,10 @@ jsi::Value Tree::readSurfaceTelemetry(
   result.setProperty(
       runtime, "valueConversions", jsi::Value(static_cast<double>(walkCost_.valueConversions)));
   result.setProperty(runtime, "applyMs", millis(walkCost_.applyNs));
+  // NOT DRAINED ON READ, unlike every counter around it: this is a level rather than a total, and a
+  // level that zeroed itself when read would answer about nothing. `retention-after-clear.itest.ts`
+  // reads it across cycles.
+  result.setProperty(runtime, "liveNodes", jsi::Value(static_cast<double>(Node::live)));
   result.setProperty(runtime, "stringDecodeMs", millis(walkCost_.stringDecodeNs));
   result.setProperty(runtime, "structureMs", millis(walkCost_.structureNs));
   result.setProperty(runtime, "holdHandleMs", millis(walkCost_.holdHandleNs));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@symbiote-native/engine",
-  "version": "1.1.0",
+  "version": "1.3.0",
   "description": "SymbioteNative's retained shadow-tree engine — clone-on-write commit path + event normalization over React Native Fabric, shared by every framework adapter.",
   "license": "MIT",
   "repository": {
@@ -71,7 +71,7 @@
   },
   "peerDependenciesMeta": {},
   "devDependencies": {
-    "@symbiote-native/test-utils": "0.4.0"
+    "@symbiote-native/test-utils": "0.4.2"
   },
   "scripts": {
     "typecheck": "tsc --build",