@symbiote-native/angular 2.0.0 → 3.0.0

package/src/primitives/shared.ts

@@ -10,10 +10,15 @@ import {
   type SimpleChanges,
 } from '@angular/core';
 import { countAngular } from '../diagnostics';
-import { createCallbackWrapper } from '../change-detection-flush';
+import {
+  createCallbackWrapper,
+  registerViewMarker,
+  type ICallbackWrapper,
+} from '../change-detection-flush';
 import {
   flattenStyle,
   isSymbioteNode,
+  propOf,
   type IHostInstance,
   type IStyleProp,
 } from '@symbiote-native/engine';
@@ -43,7 +48,7 @@ import {
  */
 export function anchorHostStyle(elementRef: ElementRef<unknown>): unknown {
   const node = elementRef.nativeElement;
-  return isSymbioteNode(node) ? node.props.style : undefined;
+  return isSymbioteNode(node) ? propOf(node, 'style') : undefined;
 }
 
 // anchorHostStyle returns `unknown` (it reads whatever already resolved onto the anchor node's
@@ -259,10 +264,20 @@ export class SymbioteHostPropsDirective {
   // binds its result: the "pan does nothing" bug. Shared with the TAG path's `SymbioteElement`,
   // which has the identical deficit; the mechanism, the `onScroll` exemption and why the wrapper
   // is cached per original handler live in `createCallbackWrapper`.
-  private readonly wrapCallback = createCallbackWrapper(
-    this.cdr,
-    this.elementRef.nativeElement,
-  );
+  //
+  // THE REF REACHES THE WRAPPER BY THE NODE NOW, not as an argument. `SymbioteElement` stopped
+  // injecting one per element — it was ~1-2.4 us on every tag of a screen to serve the few that carry
+  // a callback — so `createCallbackWrapper` looks its marker up in `markViewFor`. This directive
+  // keeps its own injection because it is matched by an ATTRIBUTE a composed component writes
+  // deliberately, not by every element, and registers it here for the same node the wrapper holds.
+  private readonly wrapCallback = this.registerMarkerAndWrap();
+
+  private registerMarkerAndWrap(): ICallbackWrapper {
+    const node: unknown = this.elementRef.nativeElement;
+    if (typeof node === 'object' && node !== null)
+      registerViewMarker(node, this.cdr);
+    return createCallbackWrapper(node);
+  }
 
   // Values pushed by the previous bag, so a push writes only what actually moved. Copied rather
   // than aliased: a component is free to hand back the same object with mutated fields.

package/src/render/index.ts

@@ -22,6 +22,7 @@ import {
   createComponent,
   createEnvironmentInjector,
   DOCUMENT,
+  enableProdMode,
   ErrorHandler,
   RendererFactory2,
   ɵINJECTOR_SCOPE as INJECTOR_SCOPE,
@@ -137,11 +138,54 @@ function teardown(rootTag: IRootTag): void {
   disposeRoot(rootTag);
 }
 
+// Metro's build switch, and esbuild's in this repo's headless runner. Declared HERE rather than in
+// an ambient `globals.d.ts`, because the AOT tests (`elements.test.ts`, `style-input-aot.test.ts`)
+// build their own ngtsc programs from an explicit file list that an ambient declaration never
+// reaches — seven of them went red with `Cannot find name '__DEV__'`, reported as an empty
+// diagnostic set, which reads as "the template checker found nothing" and is not that.
+//
+// `declare const` emits no JavaScript, so it shadows nothing at runtime and both bundlers still
+// substitute the identifier.
+declare const __DEV__: boolean;
+
+/**
+ * Turn Angular's assertions off when — and only when — the bundler has said this is a release.
+ *
+ * `ngDevMode` is a THIRD dev switch, and neither of the two this project already handles reaches
+ * it: `initNgDevMode()` turns itself ON whenever the global is undefined (`ng_dev_mode.ts:85`), and
+ * `@react-native/babel-preset` inlines `__DEV__` while knowing nothing about Angular. So every
+ * release build made with this adapter shipped dev-mode Angular — `inject()` of a special token
+ * builds a `new NodeInjector` and emits two profiler events PER ELEMENT
+ * (`di.ts:525`, `runInInjectorProfilerContext`). Measured on `angular-elements-suite.itest.ts`,
+ * `build-release`, with the census byte-identical on both sides: a 1 000-row create went from
+ * ~300 ms to ~223 ms, all of it in pass 1.
+ *
+ * AN EXPLICIT `false` IS THE ONLY RELEASE SIGNAL. A host that never defines `__DEV__` reads
+ * `undefined`, and a `!__DEV__` test would silence every NG-code diagnostic there in exchange for a
+ * speed-up nobody asked for. Metro writes a literal `true` or `false`, so the signal exists exactly
+ * where it can be trusted.
+ *
+ * Per mount rather than once per process: `enableProdMode()` only ever writes `false`, so repeating
+ * it costs a property write and a guard that has already been taken on every surface but the first.
+ *
+ * READ AS AN IDENTIFIER, NEVER AS `globalThis.__DEV__`, and that distinction is the whole
+ * mechanism. Both Metro and esbuild deliver `__DEV__` by SUBSTITUTING the identifier for a literal,
+ * so a property lookup finds nothing whatever the build says. The first spelling of this function
+ * used `Reflect.get(globalThis, '__DEV__')`, never fired once in the bench bundle, and measured a
+ * clean zero — which reads exactly like "this optimization does not work" and is not that. The
+ * `typeof` guard is what makes the bare identifier safe where nothing declares it at all.
+ */
+function settleAngularDevMode(): void {
+  if (typeof __DEV__ === 'undefined' || __DEV__ !== false) return;
+  enableProdMode();
+}
+
 export function mount(
   rootTag: IRootTag,
   rootComponent: Type<unknown>,
   options?: IMountOptions,
 ): SymbioteSurface {
+  settleAngularDevMode();
   // A re-mount on a live rootTag starts clean; otherwise the stale app double-drives the surface.
   teardown(rootTag);