@sylphx/flow 2.18.1 → 2.18.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @sylphx/flow
 
+## 2.18.2 (2025-12-18)
+
+### ♻️ Refactoring
+
+- **commands:** align /review with /continue - skills as step 1 ([b700fa5](https://github.com/SylphxAI/flow/commit/b700fa5272d6a656cd88acf94e3851cf31d29727))
+- **commands:** simplify /continue - half the length, skills in execution flow ([b04facb](https://github.com/SylphxAI/flow/commit/b04facb60138155b0e203ac6fbf3f03d5252f226))
+- **core:** remove dead code and consolidate duplications ([ee54d3f](https://github.com/SylphxAI/flow/commit/ee54d3f885f8e7a7011e39d95e5403c70fa595be))
+
 ## 2.18.1 (2025-12-18)
 
 ### 🐛 Bug Fixes

package/assets/slash-commands/continue.md

@@ -10,85 +10,40 @@ Find what's incomplete. Finish it.
 
 ## Mandate
 
-* **Think, don't checklist.** Understand the project first. What is it trying to do? What would "done" look like?
-* **Delegate workers** for parallel research. You synthesize and verify.
-* **Fix, don't report.** Implement solutions directly.
-* **One pass.** No deferrals. Complete each fix fully.
-
-## How to Find Incomplete Work
-
-Don't grep for TODO and call it done. Incomplete work hides in:
-
-**What's explicitly unfinished** — Yes, scan for TODO/FIXME/HACK. But ask: why are they there? What was the person avoiding?
-
-**What's implicitly broken** — Code that "works" but:
-- Fails silently (empty catch blocks, swallowed errors)
-- Works only in happy path (no validation, no edge cases)
-- Works but confuses users (unclear errors, missing feedback)
-- Works but can't be debugged (no logs, no context)
-
-**What's missing entirely** — Features referenced but not implemented. UI that leads nowhere. Promises in docs that code doesn't deliver.
-
-## The Real Test
-
-For each part of the system, ask:
-
-> "If I were a user trying to accomplish their goal, where would I get stuck?"
-
-> "If this broke at 3am, could someone figure out why?"
-
-> "If requirements changed tomorrow, what would be painful to modify?"
-
-> "If we had 100x traffic, what would fall over first?"
-
-These questions reveal incompleteness that checklists miss.
+- **Think, don't checklist.** Understand the project. What would "done" look like?
+- **Delegate workers** for parallel research. You synthesize and verify.
+- **Fix, don't report.** Implement solutions directly.
 
 ## Execution
 
-1. **Understand the project** — Read README, main entry points, core flows. What is this thing supposed to do?
+1. **Understand** — Read README, entry points, core flows
 
-2. **Walk the critical paths** — Trace actual user journeys through code. Where does the path get uncertain, error-prone, or incomplete?
+2. **Find gaps** — Not just TODO/FIXME, but:
+   - Implicit broken (empty catch, happy path only, no logs)
+   - Missing entirely (referenced but not implemented)
 
-3. **Find the gaps** — Not just TODOs, but:
-   - Dead ends (code that starts something but doesn't finish)
-   - Weak spots (minimal implementation that will break under pressure)
-   - Missing pieces (what's referenced but doesn't exist)
+3. **Invoke skills** — Before fixing, load guidelines for relevant domains:
+   ```
+   auth, account-security, billing, security, database, performance, observability...
+   ```
+   Skills contain: tech stack decisions, non-negotiables, patterns, anti-patterns.
 
-4. **Prioritize by impact** — What blocks users? What causes data loss? What makes debugging impossible? Fix those first.
+4. **Fix by impact** — What blocks users? Causes data loss? Fix those first. Fix completely.
 
-5. **Fix completely** — Don't patch. Understand root cause. Implement proper solution. Test it works.
-
-## Skills (Guidelines)
-
-**Skills contain implementation guidelines** — tech stack decisions, non-negotiables, patterns, anti-patterns for each domain.
-
-Available skills:
-auth, account-security, privacy, billing, pricing, ledger, security, trust-safety, uiux, seo, pwa, performance, i18n, database, data-architecture, storage, observability, operability, delivery, growth, referral, support, admin, discovery, code-quality
-
-**You MUST invoke relevant skills** using the Skill tool before fixing. This loads the guidelines for that domain.
-
-## Loop
-
-After fixing: "Did my fixes introduce new gaps? Did fixing X reveal Y was also broken?"
-
-If yes → run `/continue` again. If no Critical/High issues remain → done.
+5. **Loop** — New gaps from fixes? → `/continue` again
 
 ## Output
 
 ```
-## What I Found
-
-[Describe the gaps discovered — not a checklist, but an understanding of what's incomplete and why]
-
-## What I Fixed
+## Found
+[What's incomplete and why]
 
-- [Description of fix and why it matters]
+## Fixed
+[Changes made]
 
-## What Remains
-
-- [Issues that need human decision or are blocked]
+## Remains
+[Needs human decision]
 
 ## Next
-
-[/continue again | done]
+[/continue | done]
 ```

package/assets/slash-commands/review.md

@@ -12,19 +12,23 @@ args:
 
 ## Mandate
 
-* **Understand first.** Absorb the principles, then apply judgment.
-* **Think like the failure mode.** Security? Think like an attacker. Performance? Think like a slow network. Auth? Think like a confused user.
-* **Delegate workers** for parallel research. You synthesize and verify.
-* **Fix, don't report.** Implement solutions directly.
+- **Think like the failure mode.** Security → attacker. Performance → slow network. Auth → confused user.
+- **Delegate workers** for parallel research. You synthesize and verify.
+- **Fix, don't report.** Implement solutions directly.
 
-## Skills (Guidelines)
+## Execution
 
-**Skills contain implementation guidelines** — tech stack decisions, non-negotiables, patterns, anti-patterns for each domain.
+1. **Invoke skills** — Load guidelines for relevant domains:
+   ```
+   auth, account-security, billing, security, database, performance, observability...
+   ```
+   Skills contain: tech stack decisions, non-negotiables, patterns, anti-patterns.
 
-Available skills:
-auth, account-security, privacy, billing, pricing, ledger, security, trust-safety, uiux, seo, pwa, performance, i18n, database, data-architecture, storage, observability, operability, delivery, growth, referral, support, admin, discovery, code-quality
+2. **Understand** — How is this implemented? Architecture, choices, tradeoffs.
 
-**You MUST invoke relevant skills** using the Skill tool before reviewing. This loads the guidelines for that domain.
+3. **Find issues** — What violates the guidelines? What's wrong and why it matters?
+
+4. **Fix** — Implement solutions directly.
 
 ## Output
 
@@ -32,14 +36,14 @@ auth, account-security, privacy, billing, pricing, ledger, security, trust-safet
 ## Review: [topic]
 
 ### Understanding
-[How this is implemented. Architecture, choices, tradeoffs.]
+[Architecture, choices, tradeoffs]
 
 ### Issues
-[What's wrong and why it matters]
+[What's wrong and why]
 
 ### Fixed
 [Changes made]
 
-### Remaining
-[Needs human decision or blocked]
+### Remains
+[Needs human decision]
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@sylphx/flow",
-	"version": "2.18.1",
+	"version": "2.18.2",
 	"description": "One CLI to rule them all. Unified orchestration layer for Claude Code, OpenCode, Cursor and all AI development tools. Auto-detection, auto-installation, auto-upgrade.",
 	"type": "module",
 	"bin": {

package/src/core/backup-manager.ts

@@ -9,7 +9,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import type { Target } from '../types/target.types.js';
 import type { ProjectManager } from './project-manager.js';
-import { targetManager } from './target-manager.js';
+import { resolveTarget, resolveTargetOrId } from './target-resolver.js';
 
 export interface BackupInfo {
   sessionId: string;
@@ -69,17 +69,6 @@ export class BackupManager {
     this.projectManager = projectManager;
   }
 
-  /**
-   * Resolve target from ID string to Target object
-   */
-  private resolveTarget(targetId: string): Target {
-    const targetOption = targetManager.getTarget(targetId);
-    if (targetOption._tag === 'None') {
-      throw new Error(`Unknown target: ${targetId}`);
-    }
-    return targetOption.value;
-  }
-
   /**
    * Create full backup of project environment
    */
@@ -88,7 +77,7 @@ export class BackupManager {
     projectHash: string,
     targetOrId: Target | string
   ): Promise<BackupInfo> {
-    const target = typeof targetOrId === 'string' ? this.resolveTarget(targetOrId) : targetOrId;
+    const target = resolveTargetOrId(targetOrId);
     const targetId = target.id;
     const sessionId = `session-${Date.now()}`;
     const timestamp = new Date().toISOString();
@@ -178,7 +167,7 @@ export class BackupManager {
     const targetId = manifest.target;
 
     // Resolve target to get config
-    const target = this.resolveTarget(targetId);
+    const target = resolveTarget(targetId);
 
     // Get target config directory
     const targetConfigDir = this.projectManager.getTargetConfigDir(projectPath, target);

package/src/core/secrets-manager.ts

@@ -9,7 +9,7 @@ import fs from 'node:fs/promises';
 import path from 'node:path';
 import type { Target } from '../types/target.types.js';
 import type { ProjectManager } from './project-manager.js';
-import { targetManager } from './target-manager.js';
+import { resolveTargetOrId } from './target-resolver.js';
 
 export interface MCPSecrets {
   version: string;
@@ -30,17 +30,6 @@ export class SecretsManager {
     this.projectManager = projectManager;
   }
 
-  /**
-   * Resolve target from ID string to Target object
-   */
-  private resolveTarget(targetId: string): Target {
-    const targetOption = targetManager.getTarget(targetId);
-    if (targetOption._tag === 'None') {
-      throw new Error(`Unknown target: ${targetId}`);
-    }
-    return targetOption.value;
-  }
-
   /**
    * Extract MCP secrets from project config
    */
@@ -49,7 +38,7 @@ export class SecretsManager {
     _projectHash: string,
     targetOrId: Target | string
   ): Promise<MCPSecrets> {
-    const target = typeof targetOrId === 'string' ? this.resolveTarget(targetOrId) : targetOrId;
+    const target = resolveTargetOrId(targetOrId);
     // configFile is at project root, not in targetDir
     const configPath = path.join(projectPath, target.config.configFile);
     const mcpPath = target.config.mcpConfigPath;
@@ -145,7 +134,7 @@ export class SecretsManager {
       return;
     }
 
-    const target = typeof targetOrId === 'string' ? this.resolveTarget(targetOrId) : targetOrId;
+    const target = resolveTargetOrId(targetOrId);
     // configFile is at project root, not in targetDir
     const configPath = path.join(projectPath, target.config.configFile);
     const mcpPath = target.config.mcpConfigPath;

package/src/core/target-resolver.ts

@@ -0,0 +1,28 @@
+/**
+ * Target Resolver
+ * Shared utility for resolving target IDs to Target objects
+ * Eliminates duplication across BackupManager and SecretsManager
+ */
+
+import type { Target } from '../types/target.types.js';
+import { targetManager } from './target-manager.js';
+
+/**
+ * Resolve a target from ID string to Target object
+ * @throws Error if target ID is not found
+ */
+export function resolveTarget(targetId: string): Target {
+  const targetOption = targetManager.getTarget(targetId);
+  if (targetOption._tag === 'None') {
+    throw new Error(`Unknown target: ${targetId}`);
+  }
+  return targetOption.value;
+}
+
+/**
+ * Resolve target, accepting either string ID or Target object
+ * Returns the Target object in both cases
+ */
+export function resolveTargetOrId(targetOrId: Target | string): Target {
+  return typeof targetOrId === 'string' ? resolveTarget(targetOrId) : targetOrId;
+}

package/src/utils/index.ts

@@ -37,13 +37,9 @@ export * from './error-handler.js';
 export * from './files/file-operations.js';
 export * from './files/sync-utils.js';
 // ============================================================================
-// FUNCTIONAL PROGRAMMING
-// ============================================================================
-export * from './functional.js';
-export * from './security/secret-utils.js';
-// ============================================================================
 // SECURITY
 // ============================================================================
+export * from './security/secret-utils.js';
 export * from './security/security.js';
 // ============================================================================
 // VERSIONING

package/src/utils/functional/array.ts

@@ -1,355 +0,0 @@
-/**
- * Functional array utilities
- * Pure array transformation functions
- *
- * DESIGN RATIONALE:
- * - Pure functions for array operations
- * - Composable transformations
- * - Type-safe operations
- * - No side effects (no mutations)
- */
-
-/**
- * Map over array
- */
-export const map =
-  <T, U>(fn: (item: T, index: number) => U) =>
-  (arr: T[]): U[] =>
-    arr.map(fn);
-
-/**
- * Filter array
- */
-export const filter =
-  <T>(predicate: (item: T, index: number) => boolean) =>
-  (arr: T[]): T[] =>
-    arr.filter(predicate);
-
-/**
- * Reduce array
- */
-export const reduce =
-  <T, U>(fn: (acc: U, item: T, index: number) => U, initial: U) =>
-  (arr: T[]): U =>
-    arr.reduce(fn, initial);
-
-/**
- * Find first element matching predicate
- */
-export const find =
-  <T>(predicate: (item: T, index: number) => boolean) =>
-  (arr: T[]): T | undefined =>
-    arr.find(predicate);
-
-/**
- * Find index of first element matching predicate
- */
-export const findIndex =
-  <T>(predicate: (item: T, index: number) => boolean) =>
-  (arr: T[]): number =>
-    arr.findIndex(predicate);
-
-/**
- * Check if any element matches predicate
- */
-export const some =
-  <T>(predicate: (item: T, index: number) => boolean) =>
-  (arr: T[]): boolean =>
-    arr.some(predicate);
-
-/**
- * Check if all elements match predicate
- */
-export const every =
-  <T>(predicate: (item: T, index: number) => boolean) =>
-  (arr: T[]): boolean =>
-    arr.every(predicate);
-
-/**
- * Flatten array one level
- */
-export const flatten = <T>(arr: T[][]): T[] => arr.flat();
-
-/**
- * Flatten array deeply
- */
-export const flattenDeep = <T>(arr: any[]): T[] => arr.flat(Number.POSITIVE_INFINITY);
-
-/**
- * Map and flatten (flatMap)
- */
-export const flatMap =
-  <T, U>(fn: (item: T, index: number) => U[]) =>
-  (arr: T[]): U[] =>
-    arr.flatMap(fn);
-
-/**
- * Take first n elements
- */
-export const take =
-  (n: number) =>
-  <T>(arr: T[]): T[] =>
-    arr.slice(0, n);
-
-/**
- * Skip first n elements
- */
-export const skip =
-  (n: number) =>
-  <T>(arr: T[]): T[] =>
-    arr.slice(n);
-
-/**
- * Take while predicate is true
- */
-export const takeWhile =
-  <T>(predicate: (item: T) => boolean) =>
-  (arr: T[]): T[] => {
-    const index = arr.findIndex((item) => !predicate(item));
-    return index === -1 ? arr : arr.slice(0, index);
-  };
-
-/**
- * Skip while predicate is true
- */
-export const skipWhile =
-  <T>(predicate: (item: T) => boolean) =>
-  (arr: T[]): T[] => {
-    const index = arr.findIndex((item) => !predicate(item));
-    return index === -1 ? [] : arr.slice(index);
-  };
-
-/**
- * Reverse array
- */
-export const reverse = <T>(arr: T[]): T[] => [...arr].reverse();
-
-/**
- * Sort array
- */
-export const sort =
-  <T>(compareFn?: (a: T, b: T) => number) =>
-  (arr: T[]): T[] =>
-    [...arr].sort(compareFn);
-
-/**
- * Sort by key
- */
-export const sortBy =
-  <T, K extends keyof T>(key: K, order: 'asc' | 'desc' = 'asc') =>
-  (arr: T[]): T[] => {
-    return [...arr].sort((a, b) => {
-      const aVal = a[key];
-      const bVal = b[key];
-
-      if (aVal < bVal) {
-        return order === 'asc' ? -1 : 1;
-      }
-      if (aVal > bVal) {
-        return order === 'asc' ? 1 : -1;
-      }
-      return 0;
-    });
-  };
-
-/**
- * Remove duplicates
- */
-export const unique = <T>(arr: T[]): T[] => [...new Set(arr)];
-
-/**
- * Remove duplicates by key
- */
-export const uniqueBy =
-  <T, K extends keyof T>(key: K) =>
-  (arr: T[]): T[] => {
-    const seen = new Set();
-    return arr.filter((item) => {
-      const value = item[key];
-      if (seen.has(value)) {
-        return false;
-      }
-      seen.add(value);
-      return true;
-    });
-  };
-
-/**
- * Partition array into two based on predicate
- */
-export const partition =
-  <T>(predicate: (item: T) => boolean) =>
-  (arr: T[]): [T[], T[]] => {
-    const pass: T[] = [];
-    const fail: T[] = [];
-
-    for (const item of arr) {
-      if (predicate(item)) {
-        pass.push(item);
-      } else {
-        fail.push(item);
-      }
-    }
-
-    return [pass, fail];
-  };
-
-/**
- * Group by key
- */
-export const groupBy =
-  <T, K extends keyof T>(key: K) =>
-  (arr: T[]): Record<string, T[]> => {
-    return arr.reduce(
-      (acc, item) => {
-        const groupKey = String(item[key]);
-        if (!acc[groupKey]) {
-          acc[groupKey] = [];
-        }
-        acc[groupKey].push(item);
-        return acc;
-      },
-      {} as Record<string, T[]>
-    );
-  };
-
-/**
- * Count occurrences
- */
-export const countBy =
-  <T>(fn: (item: T) => string) =>
-  (arr: T[]): Record<string, number> => {
-    return arr.reduce(
-      (acc, item) => {
-        const key = fn(item);
-        acc[key] = (acc[key] || 0) + 1;
-        return acc;
-      },
-      {} as Record<string, number>
-    );
-  };
-
-/**
- * Chunk array into smaller arrays
- */
-export const chunk =
-  (size: number) =>
-  <T>(arr: T[]): T[][] => {
-    const chunks: T[][] = [];
-    for (let i = 0; i < arr.length; i += size) {
-      chunks.push(arr.slice(i, i + size));
-    }
-    return chunks;
-  };
-
-/**
- * Zip arrays together
- */
-export const zip = <T, U>(arr1: T[], arr2: U[]): [T, U][] => {
-  const length = Math.min(arr1.length, arr2.length);
-  const result: [T, U][] = [];
-
-  for (let i = 0; i < length; i++) {
-    result.push([arr1[i], arr2[i]]);
-  }
-
-  return result;
-};
-
-/**
- * Unzip array of tuples
- */
-export const unzip = <T, U>(arr: [T, U][]): [T[], U[]] => {
-  const first: T[] = [];
-  const second: U[] = [];
-
-  for (const [a, b] of arr) {
-    first.push(a);
-    second.push(b);
-  }
-
-  return [first, second];
-};
-
-/**
- * Intersperse value between array elements
- */
-export const intersperse =
-  <T>(separator: T) =>
-  (arr: T[]): T[] => {
-    if (arr.length === 0) {
-      return [];
-    }
-
-    const result: T[] = [arr[0]];
-    for (let i = 1; i < arr.length; i++) {
-      result.push(separator, arr[i]);
-    }
-
-    return result;
-  };
-
-/**
- * Get first element
- */
-export const head = <T>(arr: T[]): T | undefined => arr[0];
-
-/**
- * Get last element
- */
-export const last = <T>(arr: T[]): T | undefined => arr[arr.length - 1];
-
-/**
- * Get all but first element
- */
-export const tail = <T>(arr: T[]): T[] => arr.slice(1);
-
-/**
- * Get all but last element
- */
-export const init = <T>(arr: T[]): T[] => arr.slice(0, -1);
-
-/**
- * Check if array is empty
- */
-export const isEmpty = <T>(arr: T[]): boolean => arr.length === 0;
-
-/**
- * Check if array is not empty
- */
-export const isNotEmpty = <T>(arr: T[]): boolean => arr.length > 0;
-
-/**
- * Sum numbers in array
- */
-export const sum = (arr: number[]): number => arr.reduce((a, b) => a + b, 0);
-
-/**
- * Get average of numbers in array
- */
-export const average = (arr: number[]): number => {
-  if (arr.length === 0) {
-    return 0;
-  }
-  return sum(arr) / arr.length;
-};
-
-/**
- * Get min value
- */
-export const min = (arr: number[]): number | undefined => {
-  if (arr.length === 0) {
-    return undefined;
-  }
-  return Math.min(...arr);
-};
-
-/**
- * Get max value
- */
-export const max = (arr: number[]): number | undefined => {
-  if (arr.length === 0) {
-    return undefined;
-  }
-  return Math.max(...arr);
-};

package/src/utils/functional/index.ts

@@ -1,15 +0,0 @@
-/**
- * Functional utilities
- * Pure, composable utility functions
- *
- * DESIGN RATIONALE:
- * - Pure functions for common operations
- * - Composable through currying
- * - Type-safe
- * - No side effects
- * - Point-free style support
- */
-
-export * as Arr from './array.js';
-export * as Obj from './object.js';
-export * as Str from './string.js';