@sylphx/flow 1.6.12 → 1.7.0

package/CHANGELOG.md

@@ -1,5 +1,37 @@
 # @sylphx/flow
 
+## 1.7.0
+
+### Minor Changes
+
+- Add orphaned hooks detection and removal to sync command
+
+  The sync command now properly detects and prompts for removal of hooks that exist locally but are not in the configuration. This ensures full synchronization between local settings and the Flow configuration.
+
+  **New Features:**
+
+  - Detects orphaned hooks in `.claude/settings.json`
+  - Shows orphaned hooks in sync preview
+  - Allows users to select which orphaned hooks to remove
+  - Properly cleans up settings.json after removal
+
+  **Breaking Changes:**
+
+  - Internal API: `selectUnknownFilesToRemove()` now returns `SelectedToRemove` object instead of `string[]`
+
+## 1.6.13
+
+### Patch Changes
+
+- 746d576: Fix missing chalk import in claude-code target causing ReferenceError in dry-run mode
+- ea6aa39: fix(sync): display hooks configuration in sync preview
+
+  When running `sylphx-flow --sync`, the sync preview now shows that hooks will be configured/updated. This makes it clear to users that hook settings are being synchronized along with other Flow templates.
+
+  Previously, hooks were being updated during sync but this wasn't visible in the sync preview output, leading to confusion about whether hooks were being synced.
+
+- 6ea9757: Test repository link in Slack notification
+
 ## 1.6.12
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sylphx/flow",
-  "version": "1.6.12",
+  "version": "1.7.0",
   "description": "AI-powered development workflow automation with autonomous loop mode and smart configuration",
   "type": "module",
   "bin": {

package/src/commands/flow-command.ts

@@ -380,7 +380,7 @@ async function executeSetupPhase(prompt: string | undefined, options: FlowOption
 
       // Handle sync mode - delete template files first
       if (options.sync && !options.dryRun) {
-        const { buildSyncManifest, showSyncPreview, selectUnknownFilesToRemove, showFinalSummary, confirmSync, executeSyncDelete, removeMCPServers } = await import('../utils/sync-utils.js');
+        const { buildSyncManifest, showSyncPreview, selectUnknownFilesToRemove, showFinalSummary, confirmSync, executeSyncDelete, removeMCPServers, removeHooks } = await import('../utils/sync-utils.js');
 
         // Need target to build manifest
         const targetId = await selectAndValidateTarget(initOptions);
@@ -396,7 +396,7 @@ async function executeSetupPhase(prompt: string | undefined, options: FlowOption
 
         // Show preview
         console.log(chalk.cyan.bold('━━━ 🔄 Synchronizing Files\n'));
-        showSyncPreview(manifest, process.cwd());
+        showSyncPreview(manifest, process.cwd(), target);
 
         // Select unknown files to remove
         const selectedUnknowns = await selectUnknownFilesToRemove(manifest);
@@ -415,20 +415,27 @@ async function executeSetupPhase(prompt: string | undefined, options: FlowOption
         const { templates, unknowns } = await executeSyncDelete(manifest, selectedUnknowns);
 
         // Remove MCP servers
-        const mcpServersToRemove = selectedUnknowns.filter(s => !s.includes('/'));
         let mcpRemoved = 0;
-        if (mcpServersToRemove.length > 0) {
-          mcpRemoved = await removeMCPServers(process.cwd(), mcpServersToRemove);
+        if (selectedUnknowns.mcpServers.length > 0) {
+          mcpRemoved = await removeMCPServers(process.cwd(), selectedUnknowns.mcpServers);
+        }
+
+        // Remove hooks
+        let hooksRemoved = 0;
+        if (selectedUnknowns.hooks.length > 0) {
+          hooksRemoved = await removeHooks(process.cwd(), selectedUnknowns.hooks);
         }
 
         // Summary
         console.log(chalk.green(`\n✓ Synced ${templates} templates`));
-        if (unknowns > 0 || mcpRemoved > 0) {
-          console.log(chalk.green(`✓ Removed ${unknowns + mcpRemoved} files`));
+        const totalRemoved = unknowns + mcpRemoved + hooksRemoved;
+        if (totalRemoved > 0) {
+          console.log(chalk.green(`✓ Removed ${totalRemoved} items`));
         }
-        const preserved = manifest.agents.unknown.length + manifest.slashCommands.unknown.length + manifest.rules.unknown.length + manifest.mcpServers.notInRegistry.length - selectedUnknowns.length;
+        const totalSelected = selectedUnknowns.files.length + selectedUnknowns.mcpServers.length + selectedUnknowns.hooks.length;
+        const preserved = manifest.agents.unknown.length + manifest.slashCommands.unknown.length + manifest.rules.unknown.length + manifest.mcpServers.notInRegistry.length + manifest.hooks.orphaned.length - totalSelected;
         if (preserved > 0) {
-          console.log(chalk.green(`✓ Preserved ${preserved} custom files`));
+          console.log(chalk.green(`✓ Preserved ${preserved} custom items`));
         }
         console.log('');
       } else if (!options.sync) {
@@ -725,7 +732,7 @@ async function executeFlowOnce(prompt: string | undefined, options: FlowOptions)
 
       // Handle sync mode - delete template files first
       if (options.sync && !options.dryRun) {
-        const { buildSyncManifest, showSyncPreview, selectUnknownFilesToRemove, showFinalSummary, confirmSync, executeSyncDelete, removeMCPServers } = await import('../utils/sync-utils.js');
+        const { buildSyncManifest, showSyncPreview, selectUnknownFilesToRemove, showFinalSummary, confirmSync, executeSyncDelete, removeMCPServers, removeHooks } = await import('../utils/sync-utils.js');
 
         // Need target to build manifest
         const targetId = await selectAndValidateTarget(initOptions);
@@ -741,7 +748,7 @@ async function executeFlowOnce(prompt: string | undefined, options: FlowOptions)
 
         // Show preview
         console.log(chalk.cyan.bold('━━━ 🔄 Synchronizing Files\n'));
-        showSyncPreview(manifest, process.cwd());
+        showSyncPreview(manifest, process.cwd(), target);
 
         // Select unknown files to remove
         const selectedUnknowns = await selectUnknownFilesToRemove(manifest);
@@ -760,20 +767,27 @@ async function executeFlowOnce(prompt: string | undefined, options: FlowOptions)
         const { templates, unknowns } = await executeSyncDelete(manifest, selectedUnknowns);
 
         // Remove MCP servers
-        const mcpServersToRemove = selectedUnknowns.filter(s => !s.includes('/'));
         let mcpRemoved = 0;
-        if (mcpServersToRemove.length > 0) {
-          mcpRemoved = await removeMCPServers(process.cwd(), mcpServersToRemove);
+        if (selectedUnknowns.mcpServers.length > 0) {
+          mcpRemoved = await removeMCPServers(process.cwd(), selectedUnknowns.mcpServers);
+        }
+
+        // Remove hooks
+        let hooksRemoved = 0;
+        if (selectedUnknowns.hooks.length > 0) {
+          hooksRemoved = await removeHooks(process.cwd(), selectedUnknowns.hooks);
         }
 
         // Summary
         console.log(chalk.green(`\n✓ Synced ${templates} templates`));
-        if (unknowns > 0 || mcpRemoved > 0) {
-          console.log(chalk.green(`✓ Removed ${unknowns + mcpRemoved} files`));
+        const totalRemoved = unknowns + mcpRemoved + hooksRemoved;
+        if (totalRemoved > 0) {
+          console.log(chalk.green(`✓ Removed ${totalRemoved} items`));
         }
-        const preserved = manifest.agents.unknown.length + manifest.slashCommands.unknown.length + manifest.rules.unknown.length + manifest.mcpServers.notInRegistry.length - selectedUnknowns.length;
+        const totalSelected = selectedUnknowns.files.length + selectedUnknowns.mcpServers.length + selectedUnknowns.hooks.length;
+        const preserved = manifest.agents.unknown.length + manifest.slashCommands.unknown.length + manifest.rules.unknown.length + manifest.mcpServers.notInRegistry.length + manifest.hooks.orphaned.length - totalSelected;
         if (preserved > 0) {
-          console.log(chalk.green(`✓ Preserved ${preserved} custom files`));
+          console.log(chalk.green(`✓ Preserved ${preserved} custom items`));
         }
         console.log('');
       } else {

package/src/targets/claude-code.ts

@@ -2,6 +2,7 @@ import { spawn } from 'node:child_process';
 import fs from 'node:fs';
 import fsPromises from 'node:fs/promises';
 import path from 'node:path';
+import chalk from 'chalk';
 import { FileInstaller } from '../core/installers/file-installer.js';
 import { MCPInstaller } from '../core/installers/mcp-installer.js';
 import type { AgentMetadata } from '../types/target-config.types.js';

package/src/utils/sync-utils.ts

@@ -47,6 +47,10 @@ interface SyncManifest {
     inRegistry: string[];
     notInRegistry: string[];
   };
+  hooks: {
+    inConfig: string[];      // Hooks from config (will be synced)
+    orphaned: string[];      // Hooks that exist locally but not in config (ask user)
+  };
   preserve: string[];
 }
 
@@ -82,6 +86,7 @@ export async function buildSyncManifest(cwd: string, target: Target): Promise<Sy
     slashCommands: { inFlow: [], unknown: [], missing: [] },
     rules: { inFlow: [], unknown: [], missing: [] },
     mcpServers: { inRegistry: [], notInRegistry: [] },
+    hooks: { inConfig: [], orphaned: [] },
     preserve: [],
   };
 
@@ -158,6 +163,34 @@ export async function buildSyncManifest(cwd: string, target: Target): Promise<Sy
     }
   }
 
+  // Hooks - detect orphaned hooks (only for targets that support hooks)
+  if (target.setupHooks) {
+    const settingsPath = path.join(cwd, '.claude', 'settings.json');
+    if (fs.existsSync(settingsPath)) {
+      try {
+        const content = await fs.promises.readFile(settingsPath, 'utf-8');
+        const settings = JSON.parse(content);
+
+        if (settings.hooks) {
+          const existingHookTypes = Object.keys(settings.hooks);
+
+          // Expected hooks from config (currently only Notification)
+          // In the future, this could be read from Flow config
+          const expectedHookTypes = ['Notification'];
+
+          manifest.hooks.inConfig = existingHookTypes.filter(type =>
+            expectedHookTypes.includes(type)
+          );
+          manifest.hooks.orphaned = existingHookTypes.filter(type =>
+            !expectedHookTypes.includes(type)
+          );
+        }
+      } catch (error) {
+        console.warn(chalk.yellow('⚠ Failed to read settings.json'));
+      }
+    }
+  }
+
   // Files to preserve
   manifest.preserve = [
     '.sylphx-flow/',
@@ -173,7 +206,7 @@ export async function buildSyncManifest(cwd: string, target: Target): Promise<Sy
 /**
  * Show sync preview with categorization
  */
-export function showSyncPreview(manifest: SyncManifest, cwd: string): void {
+export function showSyncPreview(manifest: SyncManifest, cwd: string, target?: Target): void {
   console.log(chalk.cyan.bold('━━━ 🔄 Sync Preview\n'));
 
   // Will sync section
@@ -183,7 +216,9 @@ export function showSyncPreview(manifest: SyncManifest, cwd: string): void {
     manifest.rules.inFlow.length > 0 ||
     manifest.mcpServers.inRegistry.length > 0;
 
-  if (hasFlowFiles) {
+  const hasHooksSupport = target?.setupHooks !== undefined;
+
+  if (hasFlowFiles || hasHooksSupport) {
     console.log(chalk.green('Will sync (delete + reinstall):\n'));
 
     if (manifest.agents.inFlow.length > 0) {
@@ -217,6 +252,20 @@ export function showSyncPreview(manifest: SyncManifest, cwd: string): void {
       });
       console.log('');
     }
+
+    // Show hooks if target supports them
+    if (hasHooksSupport) {
+      console.log(chalk.dim('  Settings:'));
+
+      if (manifest.hooks.inConfig.length > 0) {
+        manifest.hooks.inConfig.forEach((hookType) => {
+          console.log(chalk.dim(`    ✓ ${hookType} hook`));
+        });
+      } else {
+        console.log(chalk.dim(`    ✓ Hooks configuration`));
+      }
+      console.log('');
+    }
   }
 
   // Missing templates section (will be installed)
@@ -258,7 +307,8 @@ export function showSyncPreview(manifest: SyncManifest, cwd: string): void {
     manifest.agents.unknown.length > 0 ||
     manifest.slashCommands.unknown.length > 0 ||
     manifest.rules.unknown.length > 0 ||
-    manifest.mcpServers.notInRegistry.length > 0;
+    manifest.mcpServers.notInRegistry.length > 0 ||
+    manifest.hooks.orphaned.length > 0;
 
   if (hasUnknownFiles) {
     console.log(chalk.yellow('Unknown files (not in Flow templates):\n'));
@@ -294,6 +344,14 @@ export function showSyncPreview(manifest: SyncManifest, cwd: string): void {
       });
       console.log('');
     }
+
+    if (manifest.hooks.orphaned.length > 0) {
+      console.log(chalk.dim('  Hooks:'));
+      manifest.hooks.orphaned.forEach((hookType) => {
+        console.log(chalk.dim(`    ? ${hookType} hook`));
+      });
+      console.log('');
+    }
   } else {
     console.log(chalk.green('✓ No unknown files\n'));
   }
@@ -309,10 +367,19 @@ export function showSyncPreview(manifest: SyncManifest, cwd: string): void {
   console.log('');
 }
 
+/**
+ * Selected items to remove with type information
+ */
+export interface SelectedToRemove {
+  files: string[];
+  mcpServers: string[];
+  hooks: string[];
+}
+
 /**
  * Select unknown files to remove
  */
-export async function selectUnknownFilesToRemove(manifest: SyncManifest): Promise<string[]> {
+export async function selectUnknownFilesToRemove(manifest: SyncManifest): Promise<SelectedToRemove> {
   const unknownFiles: Array<{ name: string; value: string; type: string }> = [];
 
   // Collect all unknown files
@@ -348,8 +415,16 @@ export async function selectUnknownFilesToRemove(manifest: SyncManifest): Promis
     });
   });
 
+  manifest.hooks.orphaned.forEach((hookType) => {
+    unknownFiles.push({
+      name: `Hook: ${hookType}`,
+      value: hookType,
+      type: 'hook',
+    });
+  });
+
   if (unknownFiles.length === 0) {
-    return [];
+    return { files: [], mcpServers: [], hooks: [] };
   }
 
   const { default: inquirer } = await import('inquirer');
@@ -362,7 +437,27 @@ export async function selectUnknownFilesToRemove(manifest: SyncManifest): Promis
     },
   ]);
 
-  return selected;
+  // Categorize selected items by type
+  const selectedSet = new Set(selected);
+  const result: SelectedToRemove = {
+    files: [],
+    mcpServers: [],
+    hooks: [],
+  };
+
+  for (const item of unknownFiles) {
+    if (selectedSet.has(item.value)) {
+      if (item.type === 'mcp') {
+        result.mcpServers.push(item.value);
+      } else if (item.type === 'hook') {
+        result.hooks.push(item.value);
+      } else {
+        result.files.push(item.value);
+      }
+    }
+  }
+
+  return result;
 }
 
 /**
@@ -370,7 +465,7 @@ export async function selectUnknownFilesToRemove(manifest: SyncManifest): Promis
  */
 export function showFinalSummary(
   manifest: SyncManifest,
-  selectedUnknowns: string[]
+  selectedUnknowns: SelectedToRemove
 ): void {
   console.log(chalk.cyan.bold('\n━━━ 📋 Final Summary\n'));
 
@@ -395,22 +490,30 @@ export function showFinalSummary(
   }
 
   // Will remove (selected unknowns)
-  if (selectedUnknowns.length > 0) {
+  const totalToRemove = selectedUnknowns.files.length + selectedUnknowns.mcpServers.length + selectedUnknowns.hooks.length;
+  if (totalToRemove > 0) {
     console.log(chalk.red('Remove (selected):\n'));
-    selectedUnknowns.forEach((file) => {
-      const name = file.includes('/') ? path.basename(file) : file;
-      console.log(chalk.dim(`  - ${name}`));
+    selectedUnknowns.files.forEach((file) => {
+      console.log(chalk.dim(`  - ${path.basename(file)}`));
+    });
+    selectedUnknowns.mcpServers.forEach((server) => {
+      console.log(chalk.dim(`  - MCP: ${server}`));
+    });
+    selectedUnknowns.hooks.forEach((hook) => {
+      console.log(chalk.dim(`  - Hook: ${hook}`));
     });
     console.log('');
   }
 
   // Will preserve
+  const allSelected = [...selectedUnknowns.files, ...selectedUnknowns.mcpServers, ...selectedUnknowns.hooks];
   const preservedUnknowns = [
     ...manifest.agents.unknown,
     ...manifest.slashCommands.unknown,
     ...manifest.rules.unknown,
     ...manifest.mcpServers.notInRegistry,
-  ].filter((file) => !selectedUnknowns.includes(file));
+    ...manifest.hooks.orphaned,
+  ].filter((file) => !allSelected.includes(file));
 
   if (preservedUnknowns.length > 0) {
     console.log(chalk.green('Preserve:\n'));
@@ -427,7 +530,7 @@ export function showFinalSummary(
  */
 export async function executeSyncDelete(
   manifest: SyncManifest,
-  selectedUnknowns: string[]
+  selectedUnknowns: SelectedToRemove
 ): Promise<{ templates: number; unknowns: number }> {
   const flowFiles = [
     ...manifest.agents.inFlow,
@@ -454,10 +557,7 @@ export async function executeSyncDelete(
   }
 
   // Delete selected unknown files
-  for (const file of selectedUnknowns) {
-    // Skip MCP servers (handled separately)
-    if (!file.includes('/')) continue;
-
+  for (const file of selectedUnknowns.files) {
     try {
       await fs.promises.unlink(file);
       console.log(chalk.dim(`  ✓ Deleted: ${path.basename(file)}`));
@@ -530,3 +630,44 @@ export async function removeMCPServers(cwd: string, serversToRemove: string[]):
     return 0;
   }
 }
+
+/**
+ * Remove hooks from .claude/settings.json
+ */
+export async function removeHooks(cwd: string, hooksToRemove: string[]): Promise<number> {
+  if (hooksToRemove.length === 0) {
+    return 0;
+  }
+
+  const settingsPath = path.join(cwd, '.claude', 'settings.json');
+
+  try {
+    const content = await fs.promises.readFile(settingsPath, 'utf-8');
+    const settings = JSON.parse(content);
+
+    if (!settings.hooks) {
+      return 0;
+    }
+
+    let removedCount = 0;
+    for (const hookType of hooksToRemove) {
+      if (settings.hooks[hookType]) {
+        delete settings.hooks[hookType];
+        console.log(chalk.dim(`  ✓ Removed Hook: ${hookType}`));
+        removedCount++;
+      }
+    }
+
+    // Write back
+    await fs.promises.writeFile(
+      settingsPath,
+      JSON.stringify(settings, null, 2) + '\n',
+      'utf-8'
+    );
+
+    return removedCount;
+  } catch (error) {
+    console.warn(chalk.yellow('⚠ Failed to update settings.json'));
+    return 0;
+  }
+}