@sylphx/flow 1.0.5 → 1.1.0

package/assets/slash-commands/review.md

@@ -0,0 +1,39 @@
+---
+description: Review code for quality, security, and best practices
+---
+
+# Code Review
+
+## Context
+
+$ARGUMENTS
+
+## Your Task
+
+Review the code above (or at the specified location) and provide feedback on:
+
+1. **Code Quality**
+   - Readability and maintainability
+   - Code organization and structure
+   - Naming conventions
+   - Comments and documentation
+
+2. **Security**
+   - Potential vulnerabilities
+   - Input validation
+   - Authentication/authorization issues
+   - Data exposure risks
+
+3. **Performance**
+   - Algorithmic efficiency
+   - Resource usage
+   - Potential bottlenecks
+   - Scalability concerns
+
+4. **Best Practices**
+   - Language-specific idioms
+   - Design patterns
+   - Error handling
+   - Testing coverage
+
+Provide specific, actionable suggestions for improvement.

package/assets/slash-commands/test.md

@@ -0,0 +1,30 @@
+---
+description: Write comprehensive tests for code
+---
+
+# Write Tests
+
+## Context
+
+$ARGUMENTS
+
+## Your Task
+
+Write comprehensive tests for the code above (or at the specified location) that include:
+
+1. **Unit Tests**
+   - Test individual functions/methods
+   - Cover edge cases and boundary conditions
+   - Test error handling
+
+2. **Integration Tests** (if applicable)
+   - Test component interactions
+   - Test with realistic data
+
+3. **Test Coverage**
+   - Aim for high coverage of critical paths
+   - Include positive and negative test cases
+   - Test validation and error conditions
+
+Use the project's existing testing framework and follow its conventions.
+Ensure tests are readable, maintainable, and properly documented.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sylphx/flow",
-  "version": "1.0.5",
+  "version": "1.1.0",
   "description": "AI-powered development workflow automation with autonomous loop mode and smart configuration",
   "type": "module",
   "bin": {
@@ -14,7 +14,8 @@
     "start": "bun src/index.ts",
     "test": "vitest run",
     "test:watch": "vitest",
-    "type-check": "tsc --noEmit"
+    "type-check": "tsc --noEmit",
+    "prepublishOnly": "rm -rf assets && cp -r ../../assets assets"
   },
   "dependencies": {
     "commander": "^14.0.2",
@@ -38,6 +39,7 @@
   },
   "files": [
     "src",
+    "assets",
     "README.md",
     "CHANGELOG.md",
     "LOOP_MODE.md",

package/src/services/smart-config-service.ts

@@ -79,7 +79,7 @@ export class SmartConfigService {
       });
     }
 
-    // Mark setup as completed (no need for default preferences prompt)
+    // Mark setup as completed (only save API keys, no defaults)
     await ConfigService.saveHomeSettings({ hasCompletedSetup: true });
     console.log(chalk.green('\n✓ Setup complete!\n'));
   }
@@ -113,99 +113,14 @@ export class SmartConfigService {
     await ConfigService.saveHomeSettings({ apiKeys: existingApiKeys });
   }
 
-  /**
-   * Setup default preferences
-   */
-  private static async setupDefaultPreferences(): Promise<void> {
-    console.log(chalk.cyan('⚙️  Setup Default Preferences\n'));
-
-    const userSettings = await ConfigService.loadHomeSettings();
-    const availableProviders = ConfigService.getAvailableProviders(userSettings);
-
-    if (availableProviders.length === 0) {
-      console.log(chalk.yellow('⚠  No API keys configured yet. Skipping preferences setup.'));
-      return;
-    }
-
-    const { setupDefaults } = await inquirer.prompt([
-      {
-        type: 'confirm',
-        name: 'setupDefaults',
-        message: 'Set up default preferences?',
-        default: true,
-      },
-    ]);
-
-    if (!setupDefaults) {
-      console.log(chalk.dim('Skipping preferences setup.'));
-      return;
-    }
-
-    // Select default provider
-    if (availableProviders.length > 1) {
-      const { defaultProvider } = await inquirer.prompt([
-        {
-          type: 'list',
-          name: 'defaultProvider',
-          message: 'Select default provider:',
-          choices: availableProviders.map(p => ({
-            name: p.charAt(0).toUpperCase() + p.slice(1),
-            value: p,
-          })),
-          default: userSettings.defaultProvider || availableProviders[0],
-        },
-      ]);
-
-      userSettings.defaultProvider = defaultProvider;
-    }
-
-    // Set default agent (will use dynamic loading)
-    const { useDefaultAgent } = await inquirer.prompt([
-      {
-        type: 'confirm',
-        name: 'useDefaultAgent',
-        message: 'Set default agent?',
-        default: true,
-      },
-    ]);
-
-    if (useDefaultAgent) {
-      try {
-        const agents = await loadAllAgents(process.cwd());
-        if (agents.length > 0) {
-          const { defaultAgent } = await inquirer.prompt([
-            {
-              type: 'list',
-              name: 'defaultAgent',
-              message: 'Select default agent:',
-              choices: agents.map(a => ({
-                name: a.metadata.name || a.id,
-                value: a.id,
-              })),
-              default: userSettings.defaultAgent || (agents.find(a => a.id === 'coder')?.id || agents[0].id),
-            },
-          ]);
-
-          userSettings.defaultAgent = defaultAgent;
-        }
-      } catch (error) {
-        console.log(chalk.yellow('⚠  Could not load agents, using "coder" as default'));
-        userSettings.defaultAgent = 'coder';
-      }
-    }
-
-    await ConfigService.saveHomeSettings(userSettings);
-    console.log(chalk.green('✓ Default preferences saved'));
-  }
 
   /**
    * Runtime selection - choose provider and agent for this run
    *
-   * DESIGN PRINCIPLE: Smart Defaults
-   * - Has saved default → Use it (no prompt)
-   * - No saved default → Prompt user
-   * - Explicit flag (--select-provider/--select-agent) → Force prompt (override)
-   * - Explicit option (--provider/--agent) → Use specified value
+   * DESIGN PRINCIPLE: Always Ask (Simple & Explicit)
+   * - Has args (--provider/--agent) → Use them directly
+   * - No args → Always prompt user
+   * - Never save runtime choices as defaults
    */
   static async selectRuntimeChoices(options: SmartConfigOptions): Promise<RuntimeChoices> {
     const config = await ConfigService.loadConfiguration();
@@ -213,42 +128,22 @@ export class SmartConfigService {
 
     // Handle provider selection
     if (options.provider) {
-      // 1. Explicit option provided
+      // Explicit option provided via args
       choices.provider = options.provider;
-    } else if (options.selectProvider) {
-      // 2. Force selection (override defaults)
-      choices.provider = await this.selectProvider(config.user);
-    } else if (config.user.defaultProvider) {
-      // 3. Use saved default (SMART DEFAULT - no prompt needed)
-      choices.provider = config.user.defaultProvider;
-      console.log(chalk.dim(`  ✓ Provider: ${choices.provider}`));
     } else {
-      // 4. No default saved, must prompt
+      // Always prompt
       choices.provider = await this.selectProvider(config.user);
     }
 
     // Handle agent selection
     if (options.agent) {
-      // 1. Explicit option provided
+      // Explicit option provided via args
       choices.agent = options.agent;
-    } else if (options.selectAgent) {
-      // 2. Force selection (override defaults)
-      choices.agent = await this.selectAgent(config.user.defaultAgent);
-    } else if (config.user.defaultAgent) {
-      // 3. Use saved default (SMART DEFAULT - no prompt needed)
-      choices.agent = config.user.defaultAgent;
-      console.log(chalk.dim(`  ✓ Agent: ${choices.agent}`));
     } else {
-      // 4. No default saved, must prompt
-      choices.agent = await this.selectAgent(config.user.defaultAgent);
+      // Always prompt
+      choices.agent = await this.selectAgent();
     }
 
-    // Save choices for next time
-    await ConfigService.saveHomeSettings({
-      defaultProvider: choices.provider,
-      defaultAgent: choices.agent,
-    });
-
     return choices;
   }
 
@@ -265,22 +160,16 @@ export class SmartConfigService {
       { id: 'z.ai', name: 'Z.ai (Recommended)', hasKey: !!apiKeys['z.ai'] },
     ];
 
-    // Show last used provider hint
-    const lastUsed = userSettings.defaultProvider;
-    const message = lastUsed
-      ? `Select provider (last used: ${lastUsed}):`
-      : 'Select provider:';
-
     const { provider } = await inquirer.prompt([
       {
         type: 'list',
         name: 'provider',
-        message,
+        message: 'Select provider:',
         choices: allProviders.map(p => ({
           name: p.hasKey ? p.name : `${p.name} (Need API key)`,
           value: p.id,
         })),
-        default: lastUsed || 'default',
+        default: 'default',
       },
     ]);
 
@@ -309,7 +198,7 @@ export class SmartConfigService {
   /**
    * Select agent for this run
    */
-  private static async selectAgent(lastUsed?: string): Promise<string> {
+  private static async selectAgent(): Promise<string> {
     try {
       const agents = await loadAllAgents(process.cwd());
 
@@ -318,21 +207,16 @@ export class SmartConfigService {
         return 'coder';
       }
 
-      // Build message with last used hint
-      const message = lastUsed
-        ? `Select agent (last used: ${lastUsed}):`
-        : 'Select agent:';
-
       const { agent } = await inquirer.prompt([
         {
           type: 'list',
           name: 'agent',
-          message,
+          message: 'Select agent:',
           choices: agents.map(a => ({
             name: a.metadata.name || a.id,
             value: a.id,
           })),
-          default: lastUsed || agents.find(a => a.id === 'coder')?.id || agents[0].id,
+          default: agents.find(a => a.id === 'coder')?.id || agents[0].id,
         },
       ]);