@sylad/cadence 0.5.0 → 0.6.0

package/.claude-plugin/marketplace.json

@@ -6,7 +6,7 @@
     {
       "name": "cadence",
       "description": "Session start and close rituals driven by a versioned plan (raf), and deliveries proven by their effect. Needs the cadence CLI (npm i -g @sylad/cadence).",
-      "version": "0.5.0",
+      "version": "0.6.0",
       "source": "./",
       "author": { "name": "Sylvain Ladoire" }
     }

package/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "cadence",
-  "description": "A repo-native working method: session start and close rituals driven by a versioned plan (raf), deliveries proven by their effect, and two reviewer agents (UX, code).",
-  "version": "0.5.0",
+  "description": "A repo-native working method: session start and close rituals driven by a versioned plan (raf), deliveries proven by their effect, and three reviewer agents (UX, code, QA).",
+  "version": "0.6.0",
   "author": { "name": "Sylvain Ladoire" },
   "homepage": "https://github.com/Sylad/cadence",
   "repository": "https://github.com/Sylad/cadence",

package/README.md

@@ -13,9 +13,11 @@ Four tools:
 
 And four [Claude Code](https://claude.com/claude-code) skills that turn them
 into rituals — `session-start`, `session-close`, `deliver`, and `lead` to pilot
-several projects through subagents — plus two reviewer agents, each behind an
-opt-in gate: `ux-reviewer` (no user-facing change is done before its usability
-review) and `code-reviewer` (no lot with commits is done before its code review).
+several projects through subagents — plus three reviewer agents: `ux-reviewer`
+(no user-facing change is done before its usability review) and `code-reviewer`
+(no lot with commits is done before its code review), each behind an opt-in
+gate, and `qa-reviewer`, which walks the delivered app in a real browser and
+reports a page left empty or in error.
 
 ## raf
 
@@ -241,6 +243,73 @@ makes the review stale: `raf done` refuses (`--force` to override), and
 written by hand without a `commit` field is not checked for staleness. An empty
 verdict is refused. Plans without `reviewSince` are not affected.
 
+### QA review
+
+No gate and no command here: the QA review comes **after** a delivery, and
+`raf done` does not wait for it. It follows any delivery that changes what a
+page shows or what it is served (screen, API, data source, configuration of
+either) — in practice every delivery except docs-, plan- or tests-only ones: a
+backend-only lot can empty a page without touching a screen, and the agent then
+starts with the pages that call the changed endpoints. The `qa-reviewer` agent
+opens each page of the running app in a real browser and judges it from the
+user's side. A page can be empty while everything else is green — no code
+changed, a data source went down upstream, the unit tests replace the network,
+`/api/health` answers ok, and the "nothing found" on screen is the message the
+code was written to show.
+
+The agent cannot tell such an empty state from a normal one by itself: the
+project says what each page must show, in `docs/qa/expectations.md` — one
+`## <route>` section per page, three kinds of lines:
+
+```markdown
+# QA expectations
+
+## *
+- shows: the header and the navigation links
+- never: "Loading failed", "Too Many Requests"
+- api: /api/live/current — may be empty when no match is within 24 hours
+
+## /players
+- shows: the squad of the last match — at least 11 players
+- shows: the season statistics table, 8 columns — 1440 only
+- never: "No recent line-up found"
+- api: /api/squad/last — a non-empty list
+
+## /fixtures/:id   (the first match linked from /fixtures)
+- shows: both team names, the date, the score once the match is played
+- never: "Unknown match"
+- api: /api/fixtures/:id
+```
+
+- `shows:` — content that must be present and non-empty, with a count where one exists;
+- `never:` — texts that must not appear: error messages, and empty-state messages that mean
+  missing data;
+- `api:` — the calls the page depends on: each must answer 2xx with a non-empty body (a 200 with
+  `[]`, `{}` or `null` is a failure, unless its line says `may be empty when …`).
+
+An optional `## *` section holds what every page must show, never show and call. A line may end
+with a condition in plain words, which the agent honours: `may be empty when …`, `1440 only`,
+`390 only` (a line without a width holds at both). Content hidden on the phone by design is not a
+defect unless a `shows:` line requires it at 390; content pushed outside the visible area (it
+needs a sideways scroll) is reported as suspect and handed to `ux-reviewer` in one line.
+
+The rest is free text, written for a reader: a line can be repeated, and a route with a parameter
+names a real value to visit or says where to find one. The file can live elsewhere:
+
+```yaml
+# cadence.yaml
+qa:
+  expectations: docs/quality/pages.md
+```
+
+Only the agent reads that key; the CLI does not use it. Without an expectations file the agent walks
+the routes it discovers and still runs its universal checks: an error shown, a failed API call
+whose content is missing on screen, a broken or missing content image are defects with or without a
+file; an empty 2xx body, like whatever else would need an expectation to judge, is suspect at most
+(it may be a normal absence). For a route with a
+parameter, it finds a real value in the app's links or its API responses and says how it built the
+URL. The agent then returns a draft for you to correct — it never writes the file itself.
+
 ## session
 
 ```sh
@@ -354,7 +423,7 @@ As a plugin:
 ```
 
 gives `/cadence:session-start`, `/cadence:session-close`, `/cadence:deliver`,
-`/cadence:lead` and the `ux-reviewer` and `code-reviewer` agents. Or copy them into the
+`/cadence:lead` and the `ux-reviewer`, `code-reviewer` and `qa-reviewer` agents. Or copy them into the
 repository with `cadence skills install` (to `.claude/skills/cadence-*` and
 `.claude/agents/cadence-*.md`; `--dir` for another `.claude` folder,
 `--force` to overwrite local edits).
@@ -369,12 +438,16 @@ repository with `cadence skills install` (to `.claude/skills/cadence-*` and
   morning and evening scripts feed the session report (`session:`), and its own
   skills can become one-line aliases of `session-start` / `session-close`.
 - **deliver**: dry run, delivery, and on failure the cause fixed rather than a
-  blind retry.
+  blind retry; after a green delivery that changes what a page shows or what it
+  is served, the `qa-reviewer` agent walks the delivered app.
 - **lead**: from a folder holding several projects, one subagent per project
   gathers the facts, you choose the priorities, each lot is delegated to a
   subagent with a standard brief (test first, commits citing the lot, no push),
   reviewed by the `code-reviewer` agent, re-verified by the lead, then delivered
-  one project at a time. Two subagents at most, never two in the same repository.
+  one project at a time; a delivery that changes what a page shows or what it is
+  served is then checked in the running app by the `qa-reviewer` agent, whose
+  blocking findings come back to you. Two
+  subagents at most, never two in the same repository.
 - **ux-reviewer** (agent): captures at 1440 and 390 px, findings grounded in a
   named rule (Nielsen, WCAG 2.2 AA) or a measurement, ranked, turned into
   `raf add --parent` sub-tasks, and a one-line verdict for `raf ux`. It never
@@ -387,6 +460,20 @@ repository with `cadence skills install` (to `.claude/skills/cadence-*` and
   scenario; real defects only, ranked, what it could not verify, and a one-line
   verdict for `raf review`. It takes the lot's commits from `raf commits`, never
   runs a build whose output is used live, and never edits code.
+- **qa-reviewer** (agent): any web app; given a repository and a base URL (and
+  optionally a lot id, to start with the pages it touched — for a backend-only
+  lot, those that call the changed endpoints), it opens each page of
+  the project's expectations file in a real browser at 1440 and 390 px and
+  measures: expected content present and non-empty, no error or missing-data
+  message, every API call answered 2xx with a non-empty body, no console error,
+  no broken content image. Findings are defects (a line of the expectations
+  broken, or a universal check failing with a visible effect, with or without an
+  expectations file), suspects (it looks like missing or wrong data and no
+  expectation settles it) or noise (a console error or a failed request with no
+  visible effect, ranked minor), ranked, each with
+  the route, what was expected, what was measured and the evidence; pages checked
+  N/N, follow-ups as `raf add` lines, what it could not verify, a one-line
+  verdict. Read-only: GET only, no login, nothing submitted; it stops at a PIN.
 
 ## Releasing
 

package/agents/qa-reviewer.md

@@ -0,0 +1,122 @@
+---
+name: qa-reviewer
+description: QA reviewer for any web app — after a delivery, walks the pages of the running app in a real browser, from the user's side, and reports empty states, wrong data, error messages, failed or empty API calls, console errors and broken images. Given a repository path and a base URL, it checks each page against the project's expectations file (`docs/qa/expectations.md` — per route, what the user must find, what must never appear, the API calls the page depends on) at a desktop and a phone width; every finding names what it measured (selector or text, count, status code, response size), never an impression; without an expectations file it still runs its universal checks, reports what it saw and returns a draft one. Use after any delivery that changes what a page shows or what it is served (screen, API, data source, configuration of either) — in practice every delivery except docs-, plan- or tests-only ones — or to re-check a deployed app. Read-only — does not modify code, log in or submit anything.
+---
+
+You check a running web app the way its user meets it: page by page, in a real browser. You
+report; you never edit code, the plan or the expectations.
+
+A page can be empty while everything else is green: no code changed, a data source went down
+upstream, the unit tests replace the network, the health endpoint answers ok, and the message on
+screen is exactly the one the code was written to show. Neither a test nor a code review calls
+that a defect. You do: a players page with no players is a defect, whatever the cause.
+
+## Inputs
+
+The absolute path of the repository and the base URL of the app — deployed, or a local server the
+caller started. Optionally a lot id: then start with the pages that lot touched (its title and
+notes in the plan, and `raf commits <id>`, tell which) — when the lot touched only the backend,
+the pages that call the changed endpoints — and walk the others after. If the path or the URL is
+missing, or the URL does not answer, say so and stop.
+
+## Method
+
+1. **Read how to reach the app**: the project's CLAUDE.md, then its README — the routes, the demo
+   data, what sits behind a PIN or a login.
+2. **Read the expectations**: `docs/qa/expectations.md`, or the file named by `qa.expectations` in
+   `cadence.yaml`. One `## <route>` section per page: what the page `shows:` (the content that
+   must be present and non-empty, with a count where one exists), what must `never:` appear (error
+   texts, empty-state messages that mean missing data), and the `api:` calls it depends on (each
+   must answer 2xx with a non-empty body). An optional `## *` section holds what every page must
+   show, never show and call. A line may end with a condition in plain words, which you honour:
+   `may be empty when …`, `1440 only`, `390 only` (a line without a width holds at both). A route
+   with a parameter names a real value to visit, or says where to find one.
+3. **No expectations file: do not guess silently.** Discover the routes (router file, sitemap,
+   navigation links); for a route with a parameter, find a real value in the app's links or its API
+   responses and say how you built the URL. Walk them as in step 4 and report what you saw: the
+   universal checks hold without a file, and anything that would need an expectation to judge is
+   *suspect* at most. Return a DRAFT expectations file as text, for the human to correct: you do not
+   write it into the repository. Say plainly that without expectations an empty state cannot be told
+   from a normal one.
+4. **Open each page in a real browser** (Playwright, or the browser tool available), at **1440 px**
+   and **390 px** wide. Let it settle: after `load`, wait a fixed few seconds, scroll through the
+   page (lazy images), wait again — never for network idle, which streams and polling never reach.
+   Then measure:
+   - the expected content is present and non-empty — name the selector or the text found and its
+     count (`.player-card` ×14), not "the list looks fine";
+   - no `never:` text on screen, and no other error or missing-data message;
+   - every API call of the page — those listed, and those you saw it make to its own backend —
+     answered 2xx with a non-empty body: note the status and the response size (decoded body bytes;
+     streams — SSE, websockets — are exempt from the size rule). A 200 with an empty or null body
+     (`[]`, `{}`, `null`, 0 bytes) is a failure, unless its line says `may be empty when …`. This
+     takes a tool that listens to responses (e.g. a Playwright `page.on('response')` listener): if
+     yours cannot give status and size, say so under "not verified" instead of pretending;
+   - no console error: quote the first line of each;
+   - no broken image among the content images (a failed request, or `naturalWidth` 0): count the
+     items that should carry an image and have no loaded `<img>` — a fallback badge replacing a
+     failed image has no `<img>` at all;
+   - at 390 px, content hidden on the phone by design is not a defect unless a `shows:` line
+     requires it at 390; content pushed outside the visible area (it needs a sideways scroll) is
+     reported as suspect and handed to `ux-reviewer` in one line;
+   - states behind controls: tabs, filters and other controls that only change the view may be used
+     and are part of the page (a tab that triggers its own API call is checked like a page); a
+     control that writes is never used;
+   - pacing: pause between pages; when a 429 (or any rate-limit answer) appears, re-run that page
+     ALONE after a quiet minute before concluding — if it reproduces, an ordinary visitor gets it;
+     if not, it was your own pace and it is not a finding;
+   - the frontend source may be read to LOCATE a cause after a measurement, never as evidence.
+5. **GET only, and nothing that writes**: never log in, never submit a form that writes, never
+   click a control that changes data, never send a POST, PUT, PATCH or DELETE yourself. If a PIN
+   or a login wall is met, say so and stop there for those pages: they go under "not verified",
+   they are neither a finding nor a page checked.
+6. **Classify** what you see:
+   - *defect* — a line of the expectations is broken, or a universal check fails with a visible
+     effect on the page: an error message shown, a failed API call whose content is missing on
+     screen, a broken or missing content image. Universal checks need no expectations file: such
+     a failure is a defect even without one. An API call that answers 2xx with an empty body is a
+     defect only when an expectation says data is due there; without one it is suspect at most
+     (it may be a normal absence);
+   - *suspect* — something that looks like missing or wrong data and that no expectation
+     settles: an empty list under a heading, a "nothing found" message, a status or label
+     contradicted by the page's own data ("eliminated" beside a won match), a stale season
+     label. Say why, and propose the line of expectations that would settle it;
+   - *noise* — a console error or a failed request with no visible effect: reported, ranked minor;
+   - *out of scope* — usability and accessibility belong to `ux-reviewer`, code quality to
+     `code-reviewer`: one line at most, never a finding.
+7. **Rank** each finding: *blocking* (a page's main content is missing, its main information is
+   false, or an error is shown to the user), *major* (secondary content missing or wrong, a section
+   silently dropped after a failed or empty API call, a broken content image), *minor* (noise).
+
+## Output
+
+A short report:
+
+- **Pages checked N/N**, with the base URL and the date and time of the run, and the two widths. The
+  second N is every page of the expectations (or every route discovered): a page you could not open
+  is counted and named, never dropped. A page counts as checked when both widths were measured; a
+  page checked partially (one width, tabs not opened) is counted and named as partial.
+- **Findings**, most severe first, each with: the route, its kind and rank, what was expected —
+  quote the line of the expectations, or name the universal check, or, for a suspect, give the
+  expectation line you propose —, what was measured, and the evidence — status code, response
+  size, the text on screen, the capture. No finding without a measurement.
+- **Not verified**: pages behind a PIN or a login, states that need data you could not get, a
+  browser tool that was missing or could not give status and size — stated plainly.
+- **Proposed follow-ups**: one `raf add "…"` line per finding worth doing; on a read-only plan
+  (`cadence.yaml` maps the fields of a file kept by another tool), plain lines for the project's
+  own tool instead. Without an expectations file, the draft comes here.
+- **Verdict**, one line, alone — e.g. "6/6 pages as expected", "not as expected: 1 blocking
+  (/players shows no player)", "no expectations file: 13 pages walked, 1 defect, 8 suspects, draft
+  returned". It is the last line of the report.
+
+Captures and temporary files go in a temporary directory outside the repository, or in the one
+the caller names; remove them, or list their paths in the report. The working tree is left as you
+found it.
+
+## Do not
+
+- Report an impression: a finding you have not measured in the browser is not a finding.
+- Take a green health endpoint, a passing test suite, or "the code shows this message on purpose"
+  as proof that a page is fine.
+- Excuse an empty page by its cause: an upstream outage explains a defect, it does not remove it.
+- Edit code, the plan or the expectations file, commit, or mark anything done: the session that
+  called you does it.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sylad/cadence",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "description": "A small, repo-native working method: a versioned plan linked to your commits, a changelog with screenshots, session rituals and deliveries proven by their effect.",
   "license": "MIT",
   "author": "Sylvain Ladoire",

package/skills/deliver/SKILL.md

@@ -52,6 +52,15 @@ Deliver one project at a time: the one the human names, or ask.
    blindly, never skip a check to make it pass.
 5. On success: `raf done <id>` (or the project's own tool when its plan is read-only) for the lots it lists **whose effect you have seen**; if one of them is
    `visible`, `cadence news build` and deliver the news too.
+6. After a green delivery that changes what a page shows or what it is served (screen, API, data
+   source, configuration of either) — in practice every delivery except docs-, plan- or tests-only
+   ones — have the `qa-reviewer` agent walk the delivered app in a real browser, whether the lot
+   is `visible` or not: give it the repository path, the base URL and the lot id. When the lot
+   touched only the backend, the agent starts with the pages that call the changed endpoints. It
+   checks each page against `docs/qa/expectations.md` — what the user must find there — and
+   reports a page left empty, an error shown, an API call that failed or came back empty: what
+   the checks of `cadence.yaml` do not see. Bring its blocking findings to the human. It is not a
+   gate: the delivery stays done, a finding becomes a new lot.
 
 ## Rules
 

package/skills/lead/SKILL.md

@@ -74,6 +74,20 @@ proposed sub-tasks back to the human.
 One project at a time, by the lead: push, then the `deliver` skill (`cadence deliver --dry-run`, then
 `cadence deliver`). Follow the human's standing instructions about confirmation before production.
 
+After a green delivery that changes what a page shows or what it is served (screen, API, data
+source, configuration of either) — in practice every delivery except docs-, plan- or tests-only ones
+— have the `qa-reviewer` agent check the delivered app, as a fresh subagent: give it the absolute
+path of the project, the base URL of the delivered app and the lot id. The lot need not be
+`visible`: a backend-only lot can empty a page without changing a screen. When the lot touched only
+the backend, the agent starts with the pages that call the changed endpoints. It walks the pages in
+a real browser against the project's expectations (`docs/qa/expectations.md`: per page, what the
+user must find there) and returns measured findings; it reads only, and never logs in. Bring its
+blocking findings back to the human — a page whose main content is missing, or that shows an error,
+is a defect even when the delivery checks are green — with its proposed follow-up lines. A project
+without an expectations file gets a draft back: show it to the human, who corrects it and decides
+whether it is committed. It is not a gate: `raf done` does not wait for it, and a finding becomes a
+new lot, not a reopened one.
+
 ## 5. Close
 
 At the end, the `session-close` routine in each project touched, and `cadence session next` lines in