@sybilion/uilib 1.3.59 → 1.3.60

package/dist/esm/components/ui/Chat/ChatSheet/useChatPanelChromeModel.js

@@ -123,29 +123,27 @@ function useChatPanelChromeModel({ embedAsPage, presets, scopeId, onMessage, onS
         if (embedAsPage) {
             return;
         }
-        const run = () => {
-            setIsOpen(open);
-            setChatPanelOpen(open);
-        };
-        if (!isMobile &&
-            'startViewTransition' in document &&
-            document.startViewTransition) {
-            document.startViewTransition(run);
-        }
-        else {
-            run();
-        }
         if (open) {
-            // Avoid a second setSearchParams when `chat` is already set (e.g. Reports merges
-            // reportId + chat in one update). A redundant add can merge from a stale `prev`
-            // and drop other query keys.
+            setIsOpen(true);
+            setChatPanelOpen(true);
             if (!searchParams.has(CHAT_QUERY_PARAM)) {
                 addSearchParams({ [CHAT_QUERY_PARAM]: CHAT_OPEN_VALUE });
             }
+            return;
+        }
+        const applyClose = () => {
+            setIsOpen(false);
+            setChatPanelOpen(false);
+        };
+        if (!isMobile &&
+            'startViewTransition' in document &&
+            document.startViewTransition) {
+            document.startViewTransition(applyClose);
         }
         else {
-            removeSearchParams(CHAT_QUERY_PARAM);
+            applyClose();
         }
+        removeSearchParams(CHAT_QUERY_PARAM);
     };
     const isEmpty = isChatEmpty(chat) && !isLoading;
     const openNewChatWithPrefill = useCallback((prompt) => {
@@ -630,9 +628,25 @@ function useChatPanelChromeModel({ embedAsPage, presets, scopeId, onMessage, onS
         if (embedAsPage) {
             return;
         }
-        setIsOpen(chatOpen);
-        setChatPanelOpen(chatOpen);
-    }, [embedAsPage, chatOpen, setChatPanelOpen]);
+        if (!chatOpen) {
+            setIsOpen(false);
+            setChatPanelOpen(false);
+            return;
+        }
+        if (!shellChatPanelOpen && sidebarNavOpen) {
+            removeSearchParams(CHAT_QUERY_PARAM);
+            return;
+        }
+        setIsOpen(true);
+        setChatPanelOpen(true);
+    }, [
+        embedAsPage,
+        chatOpen,
+        setChatPanelOpen,
+        sidebarNavOpen,
+        shellChatPanelOpen,
+        removeSearchParams,
+    ]);
     /** Shell closed chat for space (e.g. nav opened); keep UI and URL in sync. */
     useEffect(() => {
         if (embedAsPage || shellChatPanelOpen || !isOpen) {

package/dist/esm/hooks/panelWidth.js

@@ -46,13 +46,24 @@ function clampChatWidthPx(px, shellWidth, effectiveSidebarWidthPx) {
 function defaultChatWidthPx(shellWidth) {
     return clampChatWidthPx(CHAT_WIDTH_DEFAULT_PX, shellWidth, SIDEBAR_WIDTH_DEFAULT_PX);
 }
+/**
+ * Stored width can fall below panel min when the shell was narrow (clamp cap < min).
+ * For dual-panel fit checks, treat open panels as at least their min width.
+ */
+function effectiveOpenPanelWidthPx(px, minPx, bothPanelsOpen) {
+    if (bothPanelsOpen) {
+        return Math.max(px, minPx);
+    }
+    return px > 0 ? px : minPx;
+}
 /** Minimum shell width when nav and/or chat panels are open (main column at least `CENTRAL_AREA_MIN_PX`). */
 function requiredShellWidthForSidebars(widths) {
+    const bothPanelsOpen = widths.mainSidebarOpen && widths.chatPanelOpen;
     const sidebarW = widths.mainSidebarOpen
-        ? widths.sidebarWidthPx || SIDEBAR_WIDTH_MIN_PX
+        ? effectiveOpenPanelWidthPx(widths.sidebarWidthPx, SIDEBAR_WIDTH_MIN_PX, bothPanelsOpen)
         : 0;
     const chatW = widths.chatPanelOpen
-        ? widths.chatWidthPx || CHAT_WIDTH_MIN_PX
+        ? effectiveOpenPanelWidthPx(widths.chatWidthPx, CHAT_WIDTH_MIN_PX, bothPanelsOpen)
         : 0;
     return sidebarW + CENTRAL_AREA_MIN_PX + chatW;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sybilion/uilib",
-  "version": "1.3.59",
+  "version": "1.3.60",
   "description": "Sybilion Design System — React UI components (Webpack + Stylus)",
   "publishConfig": {
     "access": "public",

package/src/components/ui/Chat/ChatSheet/useChatPanelChromeModel.tsx

@@ -287,30 +287,29 @@ export function useChatPanelChromeModel({
     if (embedAsPage) {
       return;
     }
-    const run = () => {
-      setIsOpen(open);
-      setChatPanelOpen(open);
+    if (open) {
+      setIsOpen(true);
+      setChatPanelOpen(true);
+      if (!searchParams.has(CHAT_QUERY_PARAM)) {
+        addSearchParams({ [CHAT_QUERY_PARAM]: CHAT_OPEN_VALUE });
+      }
+      return;
+    }
+
+    const applyClose = () => {
+      setIsOpen(false);
+      setChatPanelOpen(false);
     };
     if (
       !isMobile &&
       'startViewTransition' in document &&
       document.startViewTransition
     ) {
-      document.startViewTransition(run);
+      document.startViewTransition(applyClose);
     } else {
-      run();
-    }
-
-    if (open) {
-      // Avoid a second setSearchParams when `chat` is already set (e.g. Reports merges
-      // reportId + chat in one update). A redundant add can merge from a stale `prev`
-      // and drop other query keys.
-      if (!searchParams.has(CHAT_QUERY_PARAM)) {
-        addSearchParams({ [CHAT_QUERY_PARAM]: CHAT_OPEN_VALUE });
-      }
-    } else {
-      removeSearchParams(CHAT_QUERY_PARAM);
+      applyClose();
     }
+    removeSearchParams(CHAT_QUERY_PARAM);
   };
 
   const isEmpty = isChatEmpty(chat) && !isLoading;
@@ -856,9 +855,25 @@ export function useChatPanelChromeModel({
     if (embedAsPage) {
       return;
     }
-    setIsOpen(chatOpen);
-    setChatPanelOpen(chatOpen);
-  }, [embedAsPage, chatOpen, setChatPanelOpen]);
+    if (!chatOpen) {
+      setIsOpen(false);
+      setChatPanelOpen(false);
+      return;
+    }
+    if (!shellChatPanelOpen && sidebarNavOpen) {
+      removeSearchParams(CHAT_QUERY_PARAM);
+      return;
+    }
+    setIsOpen(true);
+    setChatPanelOpen(true);
+  }, [
+    embedAsPage,
+    chatOpen,
+    setChatPanelOpen,
+    sidebarNavOpen,
+    shellChatPanelOpen,
+    removeSearchParams,
+  ]);
 
   /** Shell closed chat for space (e.g. nav opened); keep UI and URL in sync. */
   useEffect(() => {

package/src/hooks/panelWidth.test.ts

@@ -37,6 +37,28 @@ describe('requiredShellWidthForSidebars', () => {
       }),
     ).toBe(SIDEBAR_WIDTH_MIN_PX + CENTRAL_AREA_MIN_PX + CHAT_WIDTH_MIN_PX);
   });
+
+  it('uses panel mins for sub-min stored widths when both panels are open', () => {
+    expect(
+      requiredShellWidthForSidebars({
+        mainSidebarOpen: true,
+        chatPanelOpen: true,
+        sidebarWidthPx: 300,
+        chatWidthPx: 37,
+      }),
+    ).toBe(300 + CENTRAL_AREA_MIN_PX + CHAT_WIDTH_MIN_PX);
+  });
+
+  it('keeps actual chat width when only chat is open', () => {
+    expect(
+      requiredShellWidthForSidebars({
+        mainSidebarOpen: false,
+        chatPanelOpen: true,
+        sidebarWidthPx: 300,
+        chatWidthPx: 337,
+      }),
+    ).toBe(CENTRAL_AREA_MIN_PX + 337);
+  });
 });
 
 describe('shellFitsSidebarsLayout', () => {
@@ -62,6 +84,17 @@ describe('shellFitsSidebarsLayout', () => {
     ).toBe(false);
   });
 
+  it('returns false when sub-min chat width would falsely fit at shell edge', () => {
+    expect(
+      shellFitsSidebarsLayout(1137, {
+        mainSidebarOpen: true,
+        chatPanelOpen: true,
+        sidebarWidthPx: 300,
+        chatWidthPx: 37,
+      }),
+    ).toBe(false);
+  });
+
   it('returns true for unknown shell width', () => {
     expect(
       shellFitsSidebarsLayout(0, {

package/src/hooks/panelWidth.ts

@@ -86,15 +86,40 @@ export type SidebarsLayoutWidths = {
   chatWidthPx: number;
 };
 
+/**
+ * Stored width can fall below panel min when the shell was narrow (clamp cap < min).
+ * For dual-panel fit checks, treat open panels as at least their min width.
+ */
+function effectiveOpenPanelWidthPx(
+  px: number,
+  minPx: number,
+  bothPanelsOpen: boolean,
+): number {
+  if (bothPanelsOpen) {
+    return Math.max(px, minPx);
+  }
+  return px > 0 ? px : minPx;
+}
+
 /** Minimum shell width when nav and/or chat panels are open (main column at least `CENTRAL_AREA_MIN_PX`). */
 export function requiredShellWidthForSidebars(
   widths: SidebarsLayoutWidths,
 ): number {
+  const bothPanelsOpen =
+    widths.mainSidebarOpen && widths.chatPanelOpen;
   const sidebarW = widths.mainSidebarOpen
-    ? widths.sidebarWidthPx || SIDEBAR_WIDTH_MIN_PX
+    ? effectiveOpenPanelWidthPx(
+        widths.sidebarWidthPx,
+        SIDEBAR_WIDTH_MIN_PX,
+        bothPanelsOpen,
+      )
     : 0;
   const chatW = widths.chatPanelOpen
-    ? widths.chatWidthPx || CHAT_WIDTH_MIN_PX
+    ? effectiveOpenPanelWidthPx(
+        widths.chatWidthPx,
+        CHAT_WIDTH_MIN_PX,
+        bothPanelsOpen,
+      )
     : 0;
   return sidebarW + CENTRAL_AREA_MIN_PX + chatW;
 }