@swmansion/argent 0.20.1-next.1 → 0.20.1-next.3

package/dist/tool-server.cjs

@@ -134485,7 +134485,7 @@ function renderCommit(summary, annotations, _sessionContext) {
   const hiddenCount = (summary.totalComponentCount ?? summary.components.length) - summary.components.length;
   if (hiddenCount > 0) {
     lines.push(
-      `- _Shown: ${roundedShown}ms self / ${summary.totalRenderMs}ms commit (${coveragePct}%) \u2014 ${hiddenCount} more components not shown. Use \`profiler-commit-query mode=by_index\` to see all._`
+      `- _Shown: ${roundedShown}ms self / ${summary.totalRenderMs}ms commit (${coveragePct}%) \u2014 ${hiddenCount} more components not shown. Use \`profiler-commit-query mode=by_index commit_index=${summary.commitIndex}\` to see all._`
     );
   } else if (coveragePct < 80) {
     lines.push(
@@ -139038,9 +139038,17 @@ async function analyzeNativeProfilerAndroid(api) {
   });
 }
 
+// ../tool-server/src/utils/debugger/device-id-param.ts
+init_zod();
+function metroDeviceIdParam(description) {
+  return external_exports.string().min(1, "device_id must not be empty").describe(description).transform((id) => canonicalDeviceId(id) ?? id);
+}
+
 // ../tool-server/src/tools/profiler/native-profiler/native-profiler-start.ts
 var zodSchema48 = external_exports.object({
-  device_id: external_exports.string().describe("Target device id from `list-devices` (iOS UDID or Android serial)."),
+  device_id: metroDeviceIdParam(
+    "Target device id from `list-devices` (iOS UDID or Android serial)."
+  ),
   app_process: external_exports.string().optional().describe(
     "iOS: the CFBundleExecutable or display name of the app to profile. Android: the app's package name. If omitted, auto-detects the currently running foreground app. Only provide this if auto-detection picks the wrong app."
   ),
@@ -139089,7 +139097,9 @@ Fails if no app is running on the device, or the profiler cannot attach to the p
 // ../tool-server/src/tools/profiler/native-profiler/native-profiler-stop.ts
 init_zod();
 var zodSchema49 = external_exports.object({
-  device_id: external_exports.string().describe("Target device id from `list-devices` (iOS UDID or Android serial).")
+  device_id: metroDeviceIdParam(
+    "Target device id from `list-devices` (iOS UDID or Android serial)."
+  )
 });
 var capability24 = {
   apple: { simulator: true, device: true },
@@ -139157,7 +139167,9 @@ Fails if no active native-profiler-start session exists for the given device_id.
 // ../tool-server/src/tools/profiler/native-profiler/native-profiler-analyze.ts
 init_zod();
 var zodSchema50 = external_exports.object({
-  device_id: external_exports.string().describe("Target device id from `list-devices` (iOS UDID or Android serial).")
+  device_id: metroDeviceIdParam(
+    "Target device id from `list-devices` (iOS UDID or Android serial)."
+  )
 });
 var capability25 = {
   apple: { simulator: true, device: true },
@@ -140326,7 +140338,7 @@ var timeWindowSchema = external_exports.object({
 });
 var zodSchema53 = external_exports.object({
   port: external_exports.coerce.number().default(8081).describe("Metro server port"),
-  device_id: external_exports.string().describe(
+  device_id: metroDeviceIdParam(
     "Device logicalDeviceId from debugger-connect (iOS simulator UDID or Android logicalDeviceId)."
   ),
   mode: external_exports.enum(["top_functions", "time_window", "call_tree", "component_cpu"]).describe(
@@ -140663,7 +140675,7 @@ var timeRangeSchema = external_exports.object({
 });
 var zodSchema54 = external_exports.object({
   port: external_exports.coerce.number().default(8081).describe("Metro server port"),
-  device_id: external_exports.string().describe(
+  device_id: metroDeviceIdParam(
     "Device logicalDeviceId from debugger-connect (iOS simulator UDID or Android logicalDeviceId)."
   ),
   mode: external_exports.enum(["by_component", "by_time_range", "by_index", "cascade_tree"]).describe(
@@ -140672,7 +140684,9 @@ var zodSchema54 = external_exports.object({
   component_name: external_exports.string().optional().describe("Component name for by_component mode"),
   time_range_ms: timeRangeSchema.optional().describe("Time range filter for by_time_range mode"),
   commit_index: external_exports.coerce.number().int().optional().describe("Commit index for by_index and cascade_tree modes"),
-  top_n: external_exports.coerce.number().int().positive().default(20).describe("Max results to return (default 20)")
+  top_n: external_exports.coerce.number().int().positive().optional().describe(
+    "Max results to return. Defaults to 20 for by_component / by_time_range, which count commits. by_index counts individual fibers and returns all of them unless this is set, because one commit's fibers collapse to far fewer distinct components \u2014 a small cap there can show less than the analyze report it is meant to expand on."
+  )
 });
 async function getCommitTree(port, deviceId) {
   const sessionPaths = getCachedProfilerPaths(port, deviceId);
@@ -140809,23 +140823,25 @@ function renderByTimeRange(commits, start2, end, topN2) {
   }
   return lines.join("\n");
 }
-function renderByIndex(commits, commitIndex) {
+function renderByIndex(commits, commitIndex, topN2) {
   const matching = commits.filter((c) => c.commitIndex === commitIndex);
   if (matching.length === 0) {
     return `_Commit #${commitIndex} not found in stored data._`;
   }
   const commitDuration = matching[0].commitDuration;
   const timestamp = matching[0].timestamp;
+  const sorted = [...matching].sort((a, b) => b.actualDuration - a.actualDuration);
+  const shown = topN2 !== void 0 ? sorted.slice(0, topN2) : sorted;
+  const hidden = sorted.length - shown.length;
   const lines = [
-    `## Commit #${commitIndex} \u2014 Full Detail`,
+    `## Commit #${commitIndex} \u2014 ${hidden > 0 ? "Top Fibers" : "Full Detail"}`,
     "",
-    `**Time:** ${timestamp.toFixed(0)}ms  **Duration:** ${commitDuration.toFixed(1)}ms  **Fibers:** ${matching.length}`,
+    `**Time:** ${timestamp.toFixed(0)}ms  **Duration:** ${commitDuration.toFixed(1)}ms  **Fibers:** ${matching.length}${hidden > 0 ? ` (showing ${shown.length})` : ""}`,
     "",
     "| Component | Duration (ms) | Self (ms) | Reason | Parent | Compiler |",
     "|---|---|---|---|---|---|"
   ];
-  const sorted = [...matching].sort((a, b) => b.actualDuration - a.actualDuration);
-  for (const c of sorted) {
+  for (const c of shown) {
     const reason = formatReason2(c);
     const parent = c.parentName ?? "\u2014";
     const compiler = c.isCompilerOptimized ? "\u2713" : "";
@@ -140833,6 +140849,12 @@ function renderByIndex(commits, commitIndex) {
       `| \`${c.componentName}\` | ${c.actualDuration.toFixed(1)} | ${c.selfDuration.toFixed(1)} | ${reason} | \`${parent}\` | ${compiler} |`
     );
   }
+  if (hidden > 0) {
+    lines.push("");
+    lines.push(
+      `_Showing the ${shown.length} costliest of ${sorted.length} fibers \u2014 ${hidden} cheaper fibers hidden. Note these are fibers, not components: the full set covers ${new Set(sorted.map((c) => c.componentName)).size} distinct components and this view covers ${new Set(shown.map((c) => c.componentName)).size}. Omit top_n for everything._`
+    );
+  }
   const withRootCause = matching.find((c) => c.rootCauseParent);
   if (withRootCause?.rootCauseChain && withRootCause.rootCauseChain.length > 0) {
     lines.push("");
@@ -140940,7 +140962,7 @@ Fails if react-profiler-stop has not been called or no commit data is stored.`,
             error_kind: "validation"
           });
         }
-        return renderByComponent(commitTree.commits, params.component_name, params.top_n);
+        return renderByComponent(commitTree.commits, params.component_name, params.top_n ?? 20);
       }
       case "by_time_range": {
         if (!params.time_range_ms) {
@@ -140955,7 +140977,7 @@ Fails if react-profiler-stop has not been called or no commit data is stored.`,
           commitTree.commits,
           params.time_range_ms.start,
           params.time_range_ms.end,
-          params.top_n
+          params.top_n ?? 20
         );
       }
       case "by_index": {
@@ -140967,7 +140989,7 @@ Fails if react-profiler-stop has not been called or no commit data is stored.`,
             error_kind: "validation"
           });
         }
-        return renderByIndex(commitTree.commits, params.commit_index);
+        return renderByIndex(commitTree.commits, params.commit_index, params.top_n);
       }
       case "cascade_tree": {
         if (params.commit_index == null) {
@@ -140995,7 +141017,7 @@ Fails if react-profiler-stop has not been called or no commit data is stored.`,
 init_zod();
 init_src();
 var zodSchema55 = external_exports.object({
-  device_id: external_exports.string().describe("iOS Simulator UDID or Android serial."),
+  device_id: metroDeviceIdParam("iOS Simulator UDID or Android serial."),
   mode: external_exports.enum(["hang_stacks", "function_callers", "thread_breakdown", "leak_stacks"]).describe(
     "Query mode: hang_stacks (full CPU context during a hang), function_callers (who calls a native function), thread_breakdown (CPU split by thread), leak_stacks (leak details by object type)"
   ),
@@ -141325,6 +141347,17 @@ Fails if native-profiler-analyze has not been run or no parsed trace data is in
   }),
   async execute(services, params) {
     const api = services.session;
+    if (!api.traceFile && !api.exportedFiles && !api.parsedData) {
+      throw new FailureError(
+        `No native profiler capture is loaded for device \`${params.device_id}\`. Run native-profiler-start \u2192 native-profiler-stop \u2192 native-profiler-analyze on this device first. (If that id came from debugger-connect, pass the id from list-devices instead \u2014 the simulator UDID or adb serial \u2014 since profiler sessions are keyed by that one.)`,
+        {
+          error_code: FAILURE_CODES.PROFILER_DATA_NOT_LOADED,
+          failure_stage: "profiler_stack_query_load_native_data",
+          failure_area: "tool_server",
+          error_kind: "not_found"
+        }
+      );
+    }
     if (api.platform === "android") {
       return executeAndroid(api, params);
     }
@@ -141370,7 +141403,7 @@ function buildPerfettoAnchor(wallClockStartMs) {
 // ../tool-server/src/tools/profiler/combined/profiler-combined-report.ts
 var zodSchema56 = external_exports.object({
   port: external_exports.coerce.number().default(8081).describe("Metro server port"),
-  device_id: external_exports.string().describe("iOS Simulator/device UDID or Android serial")
+  device_id: metroDeviceIdParam("iOS Simulator/device UDID or Android serial")
 });
 var profilerCombinedReportTool = {
   id: "profiler-combined-report",
@@ -141412,6 +141445,17 @@ Fails if either react-profiler-analyze or native-profiler-analyze has not been c
         }
       );
     }
+    if (!nativeApi.traceFile && !nativeApi.exportedFiles && !nativeApi.parsedData) {
+      throw new FailureError(
+        `No native profiler capture is loaded for device \`${params.device_id}\`. Run native-profiler-start \u2192 native-profiler-stop \u2192 native-profiler-analyze on this device first. (If that id came from debugger-connect, pass the id from list-devices instead \u2014 the simulator UDID or adb serial \u2014 since profiler sessions are keyed by that one.)`,
+        {
+          error_code: FAILURE_CODES.PROFILER_DATA_NOT_LOADED,
+          failure_stage: "profiler_combined_report_load_native_data",
+          failure_area: "tool_server",
+          error_kind: "not_found"
+        }
+      );
+    }
     let uiHangs;
     let memoryLeaks;
     if (nativeApi.platform === "android") {
@@ -141704,7 +141748,7 @@ var zodSchema57 = external_exports.object({
   port: external_exports.coerce.number().default(8081).describe(
     "Metro port \u2014 the loaded React data is cached under this port for query tools (default 8081)"
   ),
-  device_id: external_exports.string().describe(
+  device_id: metroDeviceIdParam(
     "Target device id from `list-devices`. Used to cache the loaded React session under the correct port+device key, and required to resolve the native profiler session for load_native."
   ),
   app_process: external_exports.string().optional().describe(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@swmansion/argent",
-  "version": "0.20.1-next.1",
+  "version": "0.20.1-next.3",
   "mcpName": "io.github.software-mansion/argent",
   "description": "MCP server for iOS Simulator and Android Emulator control",
   "license": "Apache-2.0",