@swmansion/argent 0.12.1 → 0.13.0

package/assets/queries/cpu-hotspots.sql

@@ -1,10 +1,19 @@
 -- Argent — CPU hotspots.
 --
 -- One output row per (thread_name, leaf_function) — the leaf frame name IS the
--- dominant function, so one SQL row maps 1:1 to one aggregateCpuHotspots group
--- (we drop leaf_mapping, which was unused and only fragmented the grouping).
+-- dominant function, so one SQL row maps 1:1 to one aggregateCpuHotspots group.
 -- The aggregator normalises the thread name and applies severity bands.
 --
+-- We ALSO carry the leaf frame's mapping (the loaded object the symbol lives in,
+-- e.g. `/system/lib64/libhwui.so` for app/framework code or `/kernel` for kernel
+-- frames) through to the classifier. Name patterns alone can't tell `writel`
+-- (a kernel MMIO write) from app code, but the mapping can: a leaf in `/kernel`
+-- is unambiguously system/emulator overhead. To keep one output row per
+-- (thread_name, leaf_function) — so the SQL→aggregator 1:1 mapping is preserved
+-- and the grouping is NOT fragmented — the mapping is folded in with MIN() (a
+-- given leaf symbol resolves to a single mapping in practice, so MIN is just a
+-- grouping-safe pick, not a lossy aggregate).
+--
 -- Burst windows are computed here in SQL rather than shipping every sample
 -- timestamp (the old `GROUP_CONCAT(ts_ns)` shipped ~54 KB of timestamps that
 -- JS re-parsed). A "burst" is a run of samples for the same (thread, function)
@@ -40,12 +49,14 @@ WITH samples AS (
     ps.ts            AS ts_ns,
     t.name           AS thread_name,
     t.is_main_thread AS is_main_thread,
-    spf.name         AS leaf_function
+    spf.name         AS leaf_function,
+    spm.name         AS leaf_mapping
   FROM perf_sample ps
   JOIN thread t USING (utid)
   JOIN process p USING (upid)
   LEFT JOIN stack_profile_callsite spc ON ps.callsite_id = spc.id
   LEFT JOIN stack_profile_frame    spf ON spc.frame_id   = spf.id
+  LEFT JOIN stack_profile_mapping  spm ON spf.mapping    = spm.id
   WHERE p.name = (SELECT target_process FROM _argent_args)
 ),
 -- Flag each sample whose gap to the previous sample of the same
@@ -53,7 +64,7 @@ WITH samples AS (
 -- NULL, so its CASE yields 0 — the opening sample never counts as a gap.
 flagged AS (
   SELECT
-    thread_name, is_main_thread, leaf_function, ts_ns,
+    thread_name, is_main_thread, leaf_function, leaf_mapping, ts_ns,
     CASE
       WHEN ts_ns - LAG(ts_ns) OVER w > (SELECT burst_gap_ns FROM _argent_args) THEN 1
       ELSE 0
@@ -65,7 +76,7 @@ flagged AS (
 -- each thread+function partition.
 ided AS (
   SELECT
-    thread_name, is_main_thread, leaf_function, ts_ns,
+    thread_name, is_main_thread, leaf_function, leaf_mapping, ts_ns,
     SUM(is_new_burst) OVER (
       PARTITION BY thread_name, leaf_function
       ORDER BY ts_ns
@@ -76,10 +87,13 @@ ided AS (
 -- Collapse each burst to [start_ns, end_ns, sample_count]. Every sample lands
 -- in exactly one burst, so summing burst counts == total samples and
 -- MIN/MAX of burst bounds == first/last sample of the (thread, function).
+-- leaf_mapping is grouping-invariant per (thread, function), so MIN() picks it
+-- without affecting the per-burst cardinality.
 per_burst AS (
   SELECT
     thread_name, leaf_function,
     MAX(is_main_thread) AS is_main_thread,
+    MIN(leaf_mapping)   AS leaf_mapping,
     MIN(ts_ns)          AS burst_start_ns,
     MAX(ts_ns)          AS burst_end_ns,
     COUNT(*)            AS burst_count
@@ -90,6 +104,9 @@ SELECT
   thread_name,
   MAX(is_main_thread) AS is_main_thread,
   leaf_function,
+  -- One mapping per (thread, function) group; MIN() keeps cardinality 1:1 with
+  -- the existing GROUP BY so the grouping is not fragmented.
+  MIN(leaf_mapping)   AS leaf_mapping,
   SUM(burst_count)    AS sample_count,
   MIN(burst_start_ns) AS first_ts_ns,
   MAX(burst_end_ns)   AS last_ts_ns,

package/dist/cli-cmds.mjs

@@ -5606,6 +5606,8 @@ var FAILURE_CODES = {
   UNINSTALL_TOOLSERVER_STOP_FAILED: "UNINSTALL_TOOLSERVER_STOP_FAILED",
   UNINSTALL_PACKAGE_ACTION_FAILED: "UNINSTALL_PACKAGE_ACTION_FAILED",
   UNINSTALL_UNCLASSIFIED_FAILED: "UNINSTALL_UNCLASSIFIED_FAILED",
+  VEGA_CLI_COMMAND_FAILED: "VEGA_CLI_COMMAND_FAILED",
+  VEGA_INPUT_UNAVAILABLE: "VEGA_INPUT_UNAVAILABLE",
   ANDROID_ADB_NOT_FOUND: "ANDROID_ADB_NOT_FOUND",
   ANDROID_EMULATOR_NOT_FOUND: "ANDROID_EMULATOR_NOT_FOUND",
   ANDROID_ADB_COMMAND_FAILED: "ANDROID_ADB_COMMAND_FAILED",
@@ -5754,6 +5756,7 @@ var FAILURE_KINDS = [
 var FAILURE_COMMANDS = [
   "adb",
   "emulator",
+  "vega",
   "xcrun_simctl",
   "xctrace",
   "native_devtools",
@@ -5794,7 +5797,7 @@ var FAILURE_SPAWN_CODE_SET = new Set(FAILURE_SPAWN_CODES);
 import { randomUUID as randomUUID2 } from "node:crypto";
 
 // ../telemetry/src/events.ts
-var PLATFORMS = ["ios", "android", "chromium"];
+var PLATFORMS = ["ios", "android", "chromium", "vega"];
 
 // ../telemetry/src/ai-identity.ts
 var AI_CLIENTS = [
@@ -5972,8 +5975,7 @@ var ALLOWED = {
     uptime_ms: DURATION_MS,
     total_tool_calls: COUNT,
     ...FAILURE_SIGNAL
-  },
-  "telemetry:opt_out": {}
+  }
 };
 function sanitize(event, raw) {
   const validators = ALLOWED[event];
@@ -6396,7 +6398,7 @@ var _CI_VENDOR_COUNT_FOR_TEST = vendors_default.length;
 var SESSION_ID2 = randomUUID3();
 function readCliVersion() {
   if (true) {
-    return "0.12.1";
+    return "0.13.0";
   }
   return "0.0.0";
 }
@@ -6828,39 +6830,12 @@ async function shutdown(timeoutMs = SHORT_FLUSH_TIMEOUT_MS) {
     state = null;
   }
 }
-function isEnabled2() {
-  return isEnabled();
-}
 function markEnabled() {
   writeConsentFlag(true);
 }
 async function markDisabled() {
   try {
-    const wasEnabled = isEnabled();
-    let client2 = getConstructedClient();
-    if (wasEnabled && peekAnonId() !== null) {
-      const built = buildPayload("telemetry:opt_out", {});
-      if (built && isDebugEnabled()) {
-        emitDebugPayload({
-          event: "telemetry:opt_out",
-          distinctId: built.distinctId,
-          properties: built.properties,
-          ts: (/* @__PURE__ */ new Date()).toISOString()
-        });
-      }
-      client2 = getClient();
-      if (built && client2) {
-        try {
-          client2.capture({
-            distinctId: built.distinctId,
-            event: "telemetry:opt_out",
-            properties: built.properties
-          });
-        } catch (err) {
-          emitDebugError("markDisabled: capture(telemetry:opt_out) failed", err);
-        }
-      }
-    }
+    const client2 = getConstructedClient();
     writeConsentFlag(false);
     if (client2) {
       try {
@@ -9719,7 +9694,7 @@ function printStatus() {
   console.log(`  anon id: ${anonLabel}`);
 }
 async function cmdEnable() {
-  const wasEnabled = isEnabled2();
+  const wasEnabled = isEnabled();
   markEnabled();
   if (wasEnabled) {
     console.log(import_picocolors3.default.dim("Telemetry was already enabled."));
@@ -9729,7 +9704,7 @@ async function cmdEnable() {
   await shutdown();
 }
 async function cmdDisable() {
-  const wasEnabled = isEnabled2();
+  const wasEnabled = isEnabled();
   if (!wasEnabled) {
     console.log(import_picocolors3.default.dim("Telemetry was already disabled."));
     await shutdown();

package/dist/installer.mjs

@@ -15907,6 +15907,8 @@ var FAILURE_CODES = {
   UNINSTALL_TOOLSERVER_STOP_FAILED: "UNINSTALL_TOOLSERVER_STOP_FAILED",
   UNINSTALL_PACKAGE_ACTION_FAILED: "UNINSTALL_PACKAGE_ACTION_FAILED",
   UNINSTALL_UNCLASSIFIED_FAILED: "UNINSTALL_UNCLASSIFIED_FAILED",
+  VEGA_CLI_COMMAND_FAILED: "VEGA_CLI_COMMAND_FAILED",
+  VEGA_INPUT_UNAVAILABLE: "VEGA_INPUT_UNAVAILABLE",
   ANDROID_ADB_NOT_FOUND: "ANDROID_ADB_NOT_FOUND",
   ANDROID_EMULATOR_NOT_FOUND: "ANDROID_EMULATOR_NOT_FOUND",
   ANDROID_ADB_COMMAND_FAILED: "ANDROID_ADB_COMMAND_FAILED",
@@ -16055,6 +16057,7 @@ var FAILURE_KINDS = [
 var FAILURE_COMMANDS = [
   "adb",
   "emulator",
+  "vega",
   "xcrun_simctl",
   "xctrace",
   "native_devtools",
@@ -16095,7 +16098,7 @@ var FAILURE_SPAWN_CODE_SET = new Set(FAILURE_SPAWN_CODES);
 import { randomUUID as randomUUID2 } from "node:crypto";
 
 // ../telemetry/src/events.ts
-var PLATFORMS = ["ios", "android", "chromium"];
+var PLATFORMS = ["ios", "android", "chromium", "vega"];
 
 // ../telemetry/src/ai-identity.ts
 var AI_CLIENTS = [
@@ -16273,8 +16276,7 @@ var ALLOWED = {
     uptime_ms: DURATION_MS,
     total_tool_calls: COUNT,
     ...FAILURE_SIGNAL
-  },
-  "telemetry:opt_out": {}
+  }
 };
 function sanitize(event, raw) {
   const validators = ALLOWED[event];
@@ -16697,7 +16699,7 @@ var _CI_VENDOR_COUNT_FOR_TEST = vendors_default.length;
 var SESSION_ID = randomUUID3();
 function readCliVersion() {
   if (true) {
-    return "0.12.1";
+    return "0.13.0";
   }
   return "0.0.0";
 }

package/dist/mcp-server.mjs

@@ -17550,6 +17550,8 @@ var FAILURE_CODES = {
   UNINSTALL_TOOLSERVER_STOP_FAILED: "UNINSTALL_TOOLSERVER_STOP_FAILED",
   UNINSTALL_PACKAGE_ACTION_FAILED: "UNINSTALL_PACKAGE_ACTION_FAILED",
   UNINSTALL_UNCLASSIFIED_FAILED: "UNINSTALL_UNCLASSIFIED_FAILED",
+  VEGA_CLI_COMMAND_FAILED: "VEGA_CLI_COMMAND_FAILED",
+  VEGA_INPUT_UNAVAILABLE: "VEGA_INPUT_UNAVAILABLE",
   ANDROID_ADB_NOT_FOUND: "ANDROID_ADB_NOT_FOUND",
   ANDROID_EMULATOR_NOT_FOUND: "ANDROID_EMULATOR_NOT_FOUND",
   ANDROID_ADB_COMMAND_FAILED: "ANDROID_ADB_COMMAND_FAILED",
@@ -17698,6 +17700,7 @@ var FAILURE_KINDS = [
 var FAILURE_COMMANDS = [
   "adb",
   "emulator",
+  "vega",
   "xcrun_simctl",
   "xctrace",
   "native_devtools",
@@ -17738,7 +17741,7 @@ var FAILURE_SPAWN_CODE_SET = new Set(FAILURE_SPAWN_CODES);
 import { randomUUID as randomUUID2 } from "node:crypto";
 
 // ../telemetry/src/events.ts
-var PLATFORMS = ["ios", "android", "chromium"];
+var PLATFORMS = ["ios", "android", "chromium", "vega"];
 
 // ../telemetry/src/ai-identity.ts
 var AI_CLIENTS = [
@@ -17937,8 +17940,7 @@ var ALLOWED = {
     uptime_ms: DURATION_MS,
     total_tool_calls: COUNT,
     ...FAILURE_SIGNAL
-  },
-  "telemetry:opt_out": {}
+  }
 };
 
 // ../telemetry/src/base-props.ts

package/dist/preview-ui/index.html

@@ -4296,24 +4296,14 @@
         const allChosen = vp.proposals.length > 0 && vp.proposals.every((p) => vp.staged[p.id]);
         footEl.classList.toggle("ready", allChosen && !vp.submitting);
 
-        // Off-screen proposals stay folded away (the "N hidden" badge) until the
-        // user opts in. Once every ON-screen choice is staged, offer to reveal
-        // the rest via a prompt above the footbar. Dismissing it collapses to a
-        // persistent pill — the hidden choices are always one click from visible.
+        // Whenever ANY proposal's element is off-screen, surface the reveal
+        // prompt above the footbar so the user can always bring the hidden
+        // choices into view. (Previously this was gated on every on-screen
+        // choice already being staged, which stranded the user with a "N hidden"
+        // count and no affordance to act on it.) `offscreenPromptCollapsed` only
+        // selects between the full card and the collapsed pill (see below).
         const offScreenCount = vp.proposals.filter((p) => !p._node).length;
-        // Every currently-on-screen choice is staged. `every` is vacuously true
-        // when NONE are on screen (e.g. all proposals target another screen), so
-        // the reveal prompt still appears in that case instead of stranding the
-        // user with inert "N hidden" cards and no way to surface them.
-        const onScreenStaged = vp.proposals.every((p) => !p._node || vp.staged[p.id]);
-        // Latch on `offscreenPromptCollapsed`: once dismissed to the pill, keep it
-        // shown even if an on-screen pick is later un-staged — the hidden choices
-        // must ALWAYS stay one click from visible (the pill never disappears).
-        const showPrompt =
-          offScreenCount > 0 &&
-          !vp.revealOffscreen &&
-          !vp.submitting &&
-          (onScreenStaged || vp.offscreenPromptCollapsed);
+        const showPrompt = offScreenCount > 0 && !vp.revealOffscreen && !vp.submitting;
         offscreenPrompt.hidden = !showPrompt;
         if (showPrompt) {
           offscreenPrompt.classList.toggle("collapsed", !!vp.offscreenPromptCollapsed);