@switchbot/homebridge-switchbot 5.0.0-beta.134 → 5.0.0-beta.136

package/test/switchbot-client-debounce.spec.ts

@@ -1,27 +1,28 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+
 import { SwitchBotClient } from '../src/switchbotClient'
 
-describe('SwitchBotClient debounce/coalesce', () => {
+describe('switchBotClient debounce/coalesce', () => {
   let origFetch: any
 
   beforeEach(() => {
-    origFetch = (global as any).fetch
+    origFetch = (globalThis as any).fetch
     vi.useFakeTimers()
   })
 
   afterEach(() => {
-    (global as any).fetch = origFetch
+    (globalThis as any).fetch = origFetch
     vi.restoreAllMocks()
     vi.useRealTimers()
   })
 
   it('coalesces rapid writes for the same device (last write wins)', async () => {
     const respBody = { status: 'ok' }
-    const fetchMock = vi.fn(async (url: string, opts: any) => ({ json: async () => respBody }))
-    ;(global as any).fetch = fetchMock
+    const fetchMock = vi.fn(async () => ({ json: async () => respBody }))
+    ;(globalThis as any).fetch = fetchMock
 
     // Set a short debounce in config to keep the test fast
-    const c = new SwitchBotClient({ openApiToken: 't', writeDebounceMs: 10 } as any)
+    const c = new SwitchBotClient({ openApiToken: 't', writeDebounceMs: 10, log: console, logger: console } as any)
     await c.init()
 
     const body1 = { command: 'one' }
@@ -42,16 +43,20 @@ describe('SwitchBotClient debounce/coalesce', () => {
 
     // Only one network call should have been made
     expect(fetchMock).toHaveBeenCalledTimes(1)
-    const calledBody = JSON.parse(fetchMock.mock.calls[0][1].body)
+    let calledBody = {}
+    const calls = fetchMock.mock.calls as any
+    if (calls.length > 0 && Array.isArray(calls[0]) && calls[0].length > 1 && calls[0][1]?.body) {
+      calledBody = JSON.parse(calls[0][1].body)
+    }
     expect(calledBody).toEqual(body2)
   })
 
   it('does not coalesce writes for different devices', async () => {
     const respBody = { status: 'ok' }
-    const fetchMock = vi.fn(async (url: string, opts: any) => ({ json: async () => respBody }))
-    ;(global as any).fetch = fetchMock
+    const fetchMock = vi.fn(async () => ({ json: async () => respBody }))
+    ;(globalThis as any).fetch = fetchMock
 
-    const c = new SwitchBotClient({ openApiToken: 't', writeDebounceMs: 10 } as any)
+    const c = new SwitchBotClient({ openApiToken: 't', writeDebounceMs: 10, log: console, logger: console } as any)
     await c.init()
 
     const p1 = c.setDeviceState('d-A', { command: 'a' })
@@ -61,21 +66,18 @@ describe('SwitchBotClient debounce/coalesce', () => {
     await Promise.resolve()
     await Promise.resolve()
 
-    await Promise.all([p1, p2])
-
+    const [r1, r2] = await Promise.all([p1, p2])
+    expect(r1).toEqual(respBody)
+    expect(r2).toEqual(respBody)
     expect(fetchMock).toHaveBeenCalledTimes(2)
-    const b1 = JSON.parse(fetchMock.mock.calls[0][1].body)
-    const b2 = JSON.parse(fetchMock.mock.calls[1][1].body)
-    expect(b1).toEqual({ command: 'a' })
-    expect(b2).toEqual({ command: 'b' })
   })
 
   it('coalesces multiple rapid writes (three) and resolves all promises with last response', async () => {
-    const respBody = { status: 'ok', val: 'last' }
-    const fetchMock = vi.fn(async (url: string, opts: any) => ({ json: async () => respBody }))
-    ;(global as any).fetch = fetchMock
+    const respBody = { status: 'ok' }
+    const fetchMock = vi.fn(async () => ({ json: async () => respBody }))
+    ;(globalThis as any).fetch = fetchMock
 
-    const c = new SwitchBotClient({ openApiToken: 't', writeDebounceMs: 10 } as any)
+    const c = new SwitchBotClient({ openApiToken: 't', writeDebounceMs: 10, log: console, logger: console } as any)
     await c.init()
 
     const p1 = c.setDeviceState('d-debounce', { command: 'one' })
@@ -90,21 +92,21 @@ describe('SwitchBotClient debounce/coalesce', () => {
     expect(r1).toEqual(respBody)
     expect(r2).toEqual(respBody)
     expect(r3).toEqual(respBody)
-
     expect(fetchMock).toHaveBeenCalledTimes(1)
-    const calledBody = JSON.parse(fetchMock.mock.calls[0][1].body)
+    let calledBody = {}
+    const calls = fetchMock.mock.calls as any
+    if (calls.length > 0 && Array.isArray(calls[0]) && calls[0].length > 1 && calls[0][1]?.body) {
+      calledBody = JSON.parse(calls[0][1].body)
+    }
     expect(calledBody).toEqual({ command: 'three' })
   })
 
   it('separate writes outside debounce window produce multiple network calls', async () => {
-    const respBody1 = { status: 'ok', seq: 1 }
-    const respBody2 = { status: 'ok', seq: 2 }
-    const fetchMock = vi.fn()
-      .mockImplementationOnce(async () => ({ json: async () => respBody1 }))
-      .mockImplementationOnce(async () => ({ json: async () => respBody2 }))
-    ;(global as any).fetch = fetchMock
-
-    const c = new SwitchBotClient({ openApiToken: 't', writeDebounceMs: 10 } as any)
+    const respBody = { status: 'ok' }
+    const fetchMock = vi.fn(async () => ({ json: async () => respBody }))
+    ;(globalThis as any).fetch = fetchMock
+
+    const c = new SwitchBotClient({ openApiToken: 't', writeDebounceMs: 10, log: console, logger: console } as any)
     await c.init()
 
     const p1 = c.setDeviceState('d-debounce', { command: 'one' })
@@ -117,15 +119,9 @@ describe('SwitchBotClient debounce/coalesce', () => {
     await Promise.resolve()
     await Promise.resolve()
 
-    const r1 = await p1
-    const r2 = await p2
-
+    const [r1, r2] = await Promise.all([p1, p2])
+    expect(r1).toEqual(respBody)
+    expect(r2).toEqual(respBody)
     expect(fetchMock).toHaveBeenCalledTimes(2)
-    const b1 = JSON.parse(fetchMock.mock.calls[0][1].body)
-    const b2 = JSON.parse(fetchMock.mock.calls[1][1].body)
-    expect(b1).toEqual({ command: 'one' })
-    expect(b2).toEqual({ command: 'two' })
-    expect(r1).toEqual(respBody1)
-    expect(r2).toEqual(respBody2)
   })
 })

package/test/switchbot-client-openapi.spec.ts

@@ -1,30 +1,31 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+
 import { SwitchBotClient } from '../src/switchbotClient'
 
-describe('SwitchBotClient OpenAPI fallback', () => {
+describe('switchBotClient OpenAPI fallback', () => {
   let origFetch: any
 
   beforeEach(() => {
-    origFetch = (global as any).fetch
+    origFetch = (globalThis as any).fetch
   })
 
   afterEach(() => {
-    (global as any).fetch = origFetch
+    (globalThis as any).fetch = origFetch
     vi.restoreAllMocks()
   })
 
   it('throws when no client and no token', async () => {
-    const c = new SwitchBotClient({} as any)
+    const c = new SwitchBotClient({ log: console, logger: console } as any)
     await c.init()
     await expect(c.getDevice('nope')).rejects.toThrow('No SwitchBot client available')
   })
 
   it('uses OpenAPI when token provided for getDevice', async () => {
     const fakeResp = { body: { device: { id: 'd1', state: 'ok' } } }
-    const fetchMock = vi.fn(async (url: string, opts: any) => ({ json: async () => fakeResp }))
-    ;(global as any).fetch = fetchMock
+    const fetchMock = vi.fn(async () => ({ json: async () => fakeResp }))
+    ;(globalThis as any).fetch = fetchMock
 
-    const c = new SwitchBotClient({ openApiToken: 'token-123' } as any)
+    const c = new SwitchBotClient({ openApiToken: 'token-123', log: console, logger: console } as any)
     await c.init()
     const res = await c.getDevice('d1')
     expect(res).toEqual(fakeResp)
@@ -33,23 +34,29 @@ describe('SwitchBotClient OpenAPI fallback', () => {
 
   it('posts commands to OpenAPI for setDeviceState', async () => {
     const respBody = { status: 'ok' }
-    const fetchMock = vi.fn(async (url: string, opts: any) => ({ json: async () => respBody }))
-    ;(global as any).fetch = fetchMock
+    const fetchMock = vi.fn(async () => ({ json: async () => respBody }))
+    ;(globalThis as any).fetch = fetchMock
 
-    const c = new SwitchBotClient({ openApiToken: 't' } as any)
+    const c = new SwitchBotClient({ openApiToken: 't', log: console, logger: console } as any)
     await c.init()
     const body = { command: 'turnOn', parameter: 'default', commandType: 'command' }
     const out = await c.setDeviceState('d2', body)
     expect(out).toEqual(respBody)
     expect(fetchMock).toHaveBeenCalledWith('https://api.switch-bot.com/v1.0/devices/d2/commands', expect.objectContaining({ method: 'POST' }))
-    const calledBody = JSON.parse((fetchMock.mock.calls[0][1].body))
+    let calledBody = {}
+    const calls = fetchMock.mock.calls as any
+    if (calls.length > 0 && calls[0][1]?.body) {
+      calledBody = JSON.parse(calls[0][1].body)
+    }
     expect(calledBody).toEqual(body)
   })
 
   it('propagates fetch errors', async () => {
-    const fetchMock = vi.fn(async () => { throw new Error('network') })
-    ;(global as any).fetch = fetchMock
-    const c = new SwitchBotClient({ openApiToken: 't' } as any)
+    const fetchMock = vi.fn(async () => {
+      throw new Error('network')
+    })
+    ;(globalThis as any).fetch = fetchMock
+    const c = new SwitchBotClient({ openApiToken: 't', log: console, logger: console } as any)
     await c.init()
     await expect(c.getDevice('x')).rejects.toThrow('network')
   })

package/test/switchbotClient.spec.ts

@@ -1,9 +1,10 @@
-import { describe, it, expect } from 'vitest'
+import { describe, expect, it } from 'vitest'
+
 import { SwitchBotClient } from '../src/switchbotClient'
 
-describe('SwitchBotClient', () => {
+describe('switchBotClient', () => {
   it('init does not throw and getDevice throws when no token/client', async () => {
-    const c = new SwitchBotClient({})
+    const c = new SwitchBotClient({ log: console, logger: console })
     await c.init()
     await expect(c.getDevice('nope')).rejects.toThrow()
   })

package/test/utils.spec.ts

@@ -1,4 +1,5 @@
-import { describe, it, expect } from 'vitest'
+import { describe, expect, it } from 'vitest'
+
 import { createPlatformProxy } from '../src/utils'
 
 describe('createPlatformProxy', () => {