@switchbot/homebridge-switchbot 5.0.0-beta.134 → 5.0.0-beta.135

package/dist/homebridge-ui/public/js/modals.ts

@@ -1,7 +1,15 @@
 import { DEVICE_TYPES } from './constants.js'
 import { uiLog } from './logger.js'
 
-export async function importDiscoveredDevice(device: any): Promise<{ configDeviceName: string, configDeviceType: string, address?: string } | null> {
+export async function importDiscoveredDevice(device: any): Promise<{
+  configDeviceName: string
+  configDeviceType: string
+  address?: string
+  connectionPreference?: string
+  room?: string
+  encryptionKey?: string
+  keyId?: string
+} | null> {
   return new Promise((resolve) => {
     const div = document.createElement('div')
     div.style.position = 'fixed'
@@ -91,6 +99,51 @@ export async function importDiscoveredDevice(device: any): Promise<{ configDevic
       typeSelect.appendChild(optgroup)
     })
 
+    // --- Connection Preference ---
+    const connectionPrefLabel = document.createElement('label')
+    connectionPrefLabel.textContent = 'Connection Preference'
+    connectionPrefLabel.style.display = 'block'
+    connectionPrefLabel.style.marginBottom = '6px'
+    connectionPrefLabel.style.fontWeight = '500'
+    connectionPrefLabel.style.fontSize = '12px'
+    connectionPrefLabel.style.color = '#6b7280'
+
+    const connectionPrefSelect = document.createElement('select')
+    connectionPrefSelect.style.width = '100%'
+    connectionPrefSelect.style.marginBottom = '12px'
+    connectionPrefSelect.style.padding = '8px 10px'
+    connectionPrefSelect.style.borderRadius = '6px'
+    connectionPrefSelect.style.fontSize = '14px'
+    connectionPrefSelect.style.boxSizing = 'border-box';
+    ['auto', 'ble', 'openapi'].forEach((val) => {
+      const opt = document.createElement('option')
+      opt.value = val
+      opt.text = val.charAt(0).toUpperCase() + val.slice(1)
+      opt.selected = (device.connectionPreference || 'auto') === val
+      connectionPrefSelect.appendChild(opt)
+    })
+
+    // --- Room ---
+    const roomLabel = document.createElement('label')
+    roomLabel.textContent = 'Room'
+    roomLabel.style.display = 'block'
+    roomLabel.style.marginBottom = '6px'
+    roomLabel.style.fontWeight = '500'
+    roomLabel.style.fontSize = '12px'
+    roomLabel.style.color = '#6b7280'
+
+    const roomInput = document.createElement('input')
+    roomInput.type = 'text'
+    roomInput.value = device.room || ''
+    roomInput.placeholder = 'Optional room/location metadata'
+    roomInput.style.width = '100%'
+    roomInput.style.marginBottom = '12px'
+    roomInput.style.padding = '8px 10px'
+    roomInput.style.borderRadius = '6px'
+    roomInput.style.fontSize = '14px'
+    roomInput.style.boxSizing = 'border-box'
+
+    // --- BLE MAC Address ---
     const macLabel = document.createElement('label')
     macLabel.textContent = 'BLE MAC Address (optional)'
     macLabel.style.display = 'block'
@@ -110,7 +163,7 @@ export async function importDiscoveredDevice(device: any): Promise<{ configDevic
     macInput.style.fontSize = '14px'
     macInput.style.boxSizing = 'border-box'
 
-    // BLE Encryption Key
+    // --- Encryption Key ---
     const encryptionKeyLabel = document.createElement('label')
     encryptionKeyLabel.textContent = 'BLE Encryption Key (optional)'
     encryptionKeyLabel.style.display = 'block'
@@ -130,7 +183,7 @@ export async function importDiscoveredDevice(device: any): Promise<{ configDevic
     encryptionKeyInput.style.fontSize = '14px'
     encryptionKeyInput.style.boxSizing = 'border-box'
 
-    // BLE Key ID
+    // --- Key ID ---
     const keyIdLabel = document.createElement('label')
     keyIdLabel.textContent = 'BLE Key ID (optional)'
     keyIdLabel.style.display = 'block'
@@ -171,7 +224,15 @@ export async function importDiscoveredDevice(device: any): Promise<{ configDevic
     importBtn.style.padding = '8px 20px'
     importBtn.style.fontSize = '13px'
 
-    const cleanup = (result: { configDeviceName: string, configDeviceType: string, address?: string, encryptionKey?: string, keyId?: string } | null) => {
+    const cleanup = (result: {
+      configDeviceName: string
+      configDeviceType: string
+      address?: string
+      connectionPreference?: string
+      room?: string
+      encryptionKey?: string
+      keyId?: string
+    } | null) => {
       div.remove()
       resolve(result)
     }
@@ -181,6 +242,8 @@ export async function importDiscoveredDevice(device: any): Promise<{ configDevic
       configDeviceName: nameInput.value || device.name || device.id,
       configDeviceType: typeSelect.value || device.type,
       address: macInput.value || undefined,
+      connectionPreference: connectionPrefSelect.value || undefined,
+      room: roomInput.value || undefined,
       encryptionKey: encryptionKeyInput.value || undefined,
       keyId: keyIdInput.value || undefined,
     })
@@ -197,6 +260,10 @@ export async function importDiscoveredDevice(device: any): Promise<{ configDevic
     contentDiv.appendChild(nameInput)
     contentDiv.appendChild(typeLabel)
     contentDiv.appendChild(typeSelect)
+    contentDiv.appendChild(connectionPrefLabel)
+    contentDiv.appendChild(connectionPrefSelect)
+    contentDiv.appendChild(roomLabel)
+    contentDiv.appendChild(roomInput)
     contentDiv.appendChild(macLabel)
     contentDiv.appendChild(macInput)
     contentDiv.appendChild(encryptionKeyLabel)
@@ -250,58 +317,6 @@ export async function editDevice(device: any): Promise<void> {
     typeSelect.appendChild(optgroup)
   })
 
-  // --- Matter Type Advanced Field (only for window covering types) ---
-  const windowCoveringTypes = ['Roller Shade', 'Curtain', 'Curtain3', 'Blind Tilt']
-  const showMatterType = windowCoveringTypes.includes(device.configDeviceType || device.deviceType || device.type || '')
-  const matterTypeLabel = document.createElement('label')
-  matterTypeLabel.textContent = 'Matter Window Covering Type (Advanced)'
-  matterTypeLabel.style.display = showMatterType ? 'block' : 'none'
-  matterTypeLabel.style.marginBottom = '6px'
-  matterTypeLabel.style.fontWeight = '500'
-  matterTypeLabel.style.fontSize = '12px'
-  matterTypeLabel.style.color = '#6b7280'
-  matterTypeLabel.style.marginTop = '2px'
-  const matterTypes = [
-    { value: '', label: 'Auto-detect (recommended)' },
-    { value: 0, label: 'Roller Shade (0)' },
-    { value: 1, label: 'Roman Shade (1)' },
-    { value: 2, label: 'Balloon Shade (2)' },
-    { value: 3, label: 'Woven Wood (3)' },
-    { value: 4, label: 'Drapery (4)' },
-    { value: 5, label: 'Awning (5)' },
-    { value: 6, label: 'Shutter (6)' },
-    { value: 7, label: 'Tilt Blind (7)' },
-    { value: 8, label: 'Blind Tilt (8)' },
-    { value: 9, label: 'Projector Screen (9)' },
-    { value: 15, label: 'Other (15)' },
-  ]
-  const matterTypeSelect = document.createElement('select')
-  matterTypeSelect.style.width = '100%'
-  matterTypeSelect.style.marginBottom = '12px'
-  matterTypeSelect.style.padding = '8px 10px'
-  matterTypeSelect.style.borderRadius = '6px'
-  matterTypeSelect.style.fontSize = '14px'
-  matterTypeSelect.style.boxSizing = 'border-box'
-  matterTypes.forEach((opt) => {
-    const option = document.createElement('option')
-    option.value = String(opt.value)
-    option.textContent = opt.label
-    if (device.matterType != null && String(opt.value) === String(device.matterType)) {
-      option.selected = true
-    }
-    matterTypeSelect.appendChild(option)
-  })
-  function updateMatterTypeVisibility() {
-    if (windowCoveringTypes.includes(typeSelect.value)) {
-      matterTypeLabel.style.display = 'block'
-      matterTypeSelect.style.display = 'block'
-    } else {
-      matterTypeLabel.style.display = 'none'
-      matterTypeSelect.style.display = 'none'
-    }
-  }
-  typeSelect.addEventListener('change', updateMatterTypeVisibility)
-  updateMatterTypeVisibility()
   // Create modal dialog for editing
   const div = document.createElement('div')
   div.style.position = 'fixed'
@@ -402,6 +417,90 @@ export async function editDevice(device: any): Promise<void> {
     typeSelect.appendChild(optgroup)
   })
 
+  // --- Connection Preference ---
+  const connectionPrefLabel = document.createElement('label')
+  connectionPrefLabel.textContent = 'Connection Preference'
+  connectionPrefLabel.style.display = 'block'
+  connectionPrefLabel.style.marginBottom = '6px'
+  connectionPrefLabel.style.fontWeight = '500'
+  connectionPrefLabel.style.fontSize = '12px'
+  connectionPrefLabel.style.color = '#6b7280'
+
+  const connectionPrefSelect = document.createElement('select')
+  connectionPrefSelect.style.width = '100%'
+  connectionPrefSelect.style.marginBottom = '12px'
+  connectionPrefSelect.style.padding = '8px 10px'
+  connectionPrefSelect.style.borderRadius = '6px'
+  connectionPrefSelect.style.fontSize = '14px'
+  connectionPrefSelect.style.boxSizing = 'border-box'
+  ;['auto', 'ble', 'openapi'].forEach((val) => {
+    const opt = document.createElement('option')
+    opt.value = val
+    opt.text = val.charAt(0).toUpperCase() + val.slice(1)
+    opt.selected = (device.connectionPreference || 'auto') === val
+    connectionPrefSelect.appendChild(opt)
+  })
+
+  // --- Room ---
+  const roomLabel = document.createElement('label')
+  roomLabel.textContent = 'Room'
+  roomLabel.style.display = 'block'
+  roomLabel.style.marginBottom = '6px'
+  roomLabel.style.fontWeight = '500'
+  roomLabel.style.fontSize = '12px'
+  roomLabel.style.color = '#6b7280'
+
+  const roomInput = document.createElement('input')
+  roomInput.type = 'text'
+  roomInput.value = device.room || ''
+  roomInput.placeholder = 'Optional room/location metadata'
+  roomInput.style.width = '100%'
+  roomInput.style.marginBottom = '12px'
+  roomInput.style.padding = '8px 10px'
+  roomInput.style.borderRadius = '6px'
+  roomInput.style.fontSize = '14px'
+  roomInput.style.boxSizing = 'border-box'
+
+  // --- Encryption Key ---
+  const encryptionKeyLabel = document.createElement('label')
+  encryptionKeyLabel.textContent = 'BLE Encryption Key (optional)'
+  encryptionKeyLabel.style.display = 'block'
+  encryptionKeyLabel.style.marginBottom = '6px'
+  encryptionKeyLabel.style.fontWeight = '500'
+  encryptionKeyLabel.style.fontSize = '12px'
+  encryptionKeyLabel.style.color = '#6b7280'
+
+  const encryptionKeyInput = document.createElement('input')
+  encryptionKeyInput.type = 'password'
+  encryptionKeyInput.value = device.encryptionKey || ''
+  encryptionKeyInput.placeholder = 'Paste device BLE encryption key'
+  encryptionKeyInput.style.width = '100%'
+  encryptionKeyInput.style.marginBottom = '12px'
+  encryptionKeyInput.style.padding = '8px 10px'
+  encryptionKeyInput.style.borderRadius = '6px'
+  encryptionKeyInput.style.fontSize = '14px'
+  encryptionKeyInput.style.boxSizing = 'border-box'
+
+  // --- Key ID ---
+  const keyIdLabel = document.createElement('label')
+  keyIdLabel.textContent = 'BLE Key ID (optional)'
+  keyIdLabel.style.display = 'block'
+  keyIdLabel.style.marginBottom = '6px'
+  keyIdLabel.style.fontWeight = '500'
+  keyIdLabel.style.fontSize = '12px'
+  keyIdLabel.style.color = '#6b7280'
+
+  const keyIdInput = document.createElement('input')
+  keyIdInput.type = 'text'
+  keyIdInput.value = device.keyId || ''
+  keyIdInput.placeholder = 'e.g. ff'
+  keyIdInput.style.width = '100%'
+  keyIdInput.style.marginBottom = '12px'
+  keyIdInput.style.padding = '8px 10px'
+  keyIdInput.style.borderRadius = '6px'
+  keyIdInput.style.fontSize = '14px'
+  keyIdInput.style.boxSizing = 'border-box'
+
   const errorMessage = document.createElement('div')
   errorMessage.style.color = 'var(--switchbot-red, #ef4444)'
   errorMessage.style.marginBottom = '12px'
@@ -442,10 +541,32 @@ export async function editDevice(device: any): Promise<void> {
         deviceId: device.id,
         configDeviceName: nameInput.value || undefined,
         configDeviceType: typeSelect.value,
-        matterType: windowCoveringTypes.includes(typeSelect.value) && matterTypeSelect.value !== '' ? Number(matterTypeSelect.value) : undefined,
+        connectionPreference: connectionPrefSelect.value,
+        room: roomInput.value || undefined,
+        encryptionKey: encryptionKeyInput.value || undefined,
+        keyId: keyIdInput.value || undefined,
+      }
+
+      // Only include defined properties in the options object
+      const options: any = {}
+      if (params.connectionPreference !== undefined) {
+        options.connectionPreference = params.connectionPreference
+      }
+      if (params.room !== undefined) {
+        options.room = params.room
+      }
+      if (params.encryptionKey !== undefined) {
+        options.encryptionKey = params.encryptionKey
+      }
+      if (params.keyId !== undefined) {
+        options.keyId = params.keyId
       }
 
-      await updateDevice(params.deviceId, params.configDeviceName, params.configDeviceType, { matterType: params.matterType })
+      await updateDevice(
+        params.deviceId,
+        params.configDeviceName,
+        params.configDeviceType,
+      )
       await syncParentPluginConfigFromDisk()
 
       // Refresh device list
@@ -469,8 +590,14 @@ export async function editDevice(device: any): Promise<void> {
   contentDiv.appendChild(apiTypeInput)
   contentDiv.appendChild(typeLabel)
   contentDiv.appendChild(typeSelect)
-  contentDiv.appendChild(matterTypeLabel)
-  contentDiv.appendChild(matterTypeSelect)
+  contentDiv.appendChild(connectionPrefLabel)
+  contentDiv.appendChild(connectionPrefSelect)
+  contentDiv.appendChild(roomLabel)
+  contentDiv.appendChild(roomInput)
+  contentDiv.appendChild(encryptionKeyLabel)
+  contentDiv.appendChild(encryptionKeyInput)
+  contentDiv.appendChild(keyIdLabel)
+  contentDiv.appendChild(keyIdInput)
   contentDiv.appendChild(errorMessage)
   contentDiv.appendChild(buttons)
 

package/dist/homebridge-ui/public/js/render.d.ts

@@ -58,6 +58,9 @@ export declare function getDiscoveryPreferences(): {
 /**
  * Save filter/sort preferences to localStorage
  * @param preferences Preferences object to save
+ * @param preferences.connectionType Connection type filter
+ * @param preferences.sortBy Sort criterion
+ * @param preferences.searchQuery Search query string
  */
 export declare function setDiscoveryPreferences(preferences: {
     connectionType: 'all' | 'ble' | 'api' | 'both' | 'ir';

package/dist/homebridge-ui/public/js/render.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"render.d.ts","sourceRoot":"","sources":["../../../../src/homebridge-ui/public/js/render.ts"],"names":[],"mappings":"AAEA;;;;GAIG;AACH,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,GAAG;IAC9D,KAAK,EAAE,WAAW,GAAG,MAAM,GAAG,MAAM,GAAG,MAAM,GAAG,SAAS,CAAA;IACzD,KAAK,EAAE,MAAM,CAAA;IACb,OAAO,EAAE,MAAM,CAAA;IACf,WAAW,EAAE,MAAM,CAAA;IACnB,IAAI,EAAE,MAAM,CAAA;CACb,CA8CA;AAED;;;;GAIG;AACH,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,GAAG,WAAW,CA+BtE;AAED;;;;GAIG;AACH,wBAAgB,wBAAwB,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,GAAG,WAAW,CAiB9E;AAED,wBAAgB,WAAW,CAAC,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,WAAW,CAKpE;AAED,wBAAgB,qBAAqB,CAAC,cAAc,EAAE,MAAM,GAAG,WAAW,GAAG,IAAI,CAiBhF;AAED,wBAAgB,aAAa,IAAI,WAAW,CAK3C;AAgGD,wBAAgB,wBAAwB,CAAC,MAAM,EAAE,GAAG,GAAG,WAAW,CAoNjE;AAED,wBAAsB,uBAAuB,CAC3C,OAAO,EAAE,GAAG,EAAE,EACd,OAAO,GAAE;IACP,aAAa,CAAC,EAAE,GAAG,CAAC,MAAM,CAAC,CAAA;IAC3B,WAAW,CAAC,EAAE,GAAG,CAAC,MAAM,CAAC,CAAA;IACzB,cAAc,CAAC,EAAE,CAAC,MAAM,EAAE,GAAG,EAAE,QAAQ,EAAE,OAAO,KAAK,IAAI,CAAA;CACrD,GACL,OAAO,CAAC,WAAW,CAAC,CAgPtB;AAED;;;;;;GAMG;AACH,wBAAgB,aAAa,CAC3B,OAAO,EAAE,GAAG,EAAE,EACd,cAAc,GAAE,KAAK,GAAG,KAAK,GAAG,KAAK,GAAG,MAAM,GAAG,IAAY,EAC7D,WAAW,SAAK,GACf,GAAG,EAAE,CAmCP;AAED;;;;;GAKG;AACH,wBAAgB,WAAW,CACzB,OAAO,EAAE,GAAG,EAAE,EACd,MAAM,GAAE,MAAM,GAAG,QAAQ,GAAG,MAAM,GAAG,YAAqB,GACzD,GAAG,EAAE,CA8CP;AAED;;;GAGG;AACH,wBAAgB,uBAAuB,IAAI;IACzC,cAAc,EAAE,KAAK,GAAG,KAAK,GAAG,KAAK,GAAG,MAAM,GAAG,IAAI,CAAA;IACrD,MAAM,EAAE,MAAM,GAAG,QAAQ,GAAG,MAAM,GAAG,YAAY,CAAA;IACjD,WAAW,EAAE,MAAM,CAAA;CACpB,CAeA;AAED;;;GAGG;AACH,wBAAgB,uBAAuB,CAAC,WAAW,EAAE;IACnD,cAAc,EAAE,KAAK,GAAG,KAAK,GAAG,KAAK,GAAG,MAAM,GAAG,IAAI,CAAA;IACrD,MAAM,EAAE,MAAM,GAAG,QAAQ,GAAG,MAAM,GAAG,YAAY,CAAA;IACjD,WAAW,EAAE,MAAM,CAAA;CACpB,GAAG,IAAI,CAMP;AAED,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,GAAG,EAAE,GAAG,IAAI,CAsKlD"}
+{"version":3,"file":"render.d.ts","sourceRoot":"","sources":["../../../../src/homebridge-ui/public/js/render.ts"],"names":[],"mappings":"AAOA;;;;GAIG;AACH,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,GAAG;IAC9D,KAAK,EAAE,WAAW,GAAG,MAAM,GAAG,MAAM,GAAG,MAAM,GAAG,SAAS,CAAA;IACzD,KAAK,EAAE,MAAM,CAAA;IACb,OAAO,EAAE,MAAM,CAAA;IACf,WAAW,EAAE,MAAM,CAAA;IACnB,IAAI,EAAE,MAAM,CAAA;CACb,CA8CA;AAED;;;;GAIG;AACH,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,GAAG,WAAW,CA+BtE;AAED;;;;GAIG;AACH,wBAAgB,wBAAwB,CAAC,IAAI,EAAE,MAAM,GAAG,SAAS,GAAG,WAAW,CAiB9E;AAED,wBAAgB,WAAW,CAAC,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,GAAG,WAAW,CAKpE;AAED,wBAAgB,qBAAqB,CAAC,cAAc,EAAE,MAAM,GAAG,WAAW,GAAG,IAAI,CAmBhF;AAED,wBAAgB,aAAa,IAAI,WAAW,CAK3C;AAgGD,wBAAgB,wBAAwB,CAAC,MAAM,EAAE,GAAG,GAAG,WAAW,CA6OjE;AAED,wBAAsB,uBAAuB,CAC3C,OAAO,EAAE,GAAG,EAAE,EACd,OAAO,GAAE;IACP,aAAa,CAAC,EAAE,GAAG,CAAC,MAAM,CAAC,CAAA;IAC3B,WAAW,CAAC,EAAE,GAAG,CAAC,MAAM,CAAC,CAAA;IACzB,cAAc,CAAC,EAAE,CAAC,MAAM,EAAE,GAAG,EAAE,QAAQ,EAAE,OAAO,KAAK,IAAI,CAAA;CACrD,GACL,OAAO,CAAC,WAAW,CAAC,CAuPtB;AAED;;;;;;GAMG;AACH,wBAAgB,aAAa,CAC3B,OAAO,EAAE,GAAG,EAAE,EACd,cAAc,GAAE,KAAK,GAAG,KAAK,GAAG,KAAK,GAAG,MAAM,GAAG,IAAY,EAC7D,WAAW,SAAK,GACf,GAAG,EAAE,CAmCP;AAED;;;;;GAKG;AACH,wBAAgB,WAAW,CACzB,OAAO,EAAE,GAAG,EAAE,EACd,MAAM,GAAE,MAAM,GAAG,QAAQ,GAAG,MAAM,GAAG,YAAqB,GACzD,GAAG,EAAE,CA8CP;AAED;;;GAGG;AACH,wBAAgB,uBAAuB,IAAI;IACzC,cAAc,EAAE,KAAK,GAAG,KAAK,GAAG,KAAK,GAAG,MAAM,GAAG,IAAI,CAAA;IACrD,MAAM,EAAE,MAAM,GAAG,QAAQ,GAAG,MAAM,GAAG,YAAY,CAAA;IACjD,WAAW,EAAE,MAAM,CAAA;CACpB,CAeA;AAED;;;;;;GAMG;AACH,wBAAgB,uBAAuB,CAAC,WAAW,EAAE;IACnD,cAAc,EAAE,KAAK,GAAG,KAAK,GAAG,KAAK,GAAG,MAAM,GAAG,IAAI,CAAA;IACrD,MAAM,EAAE,MAAM,GAAG,QAAQ,GAAG,MAAM,GAAG,YAAY,CAAA;IACjD,WAAW,EAAE,MAAM,CAAA;CACpB,GAAG,IAAI,CAMP;AAED,wBAAgB,gBAAgB,CAAC,IAAI,EAAE,GAAG,EAAE,GAAG,IAAI,CA+KlD"}

package/dist/homebridge-ui/public/js/render.js

@@ -1,3 +1,8 @@
+// Move regexes to module scope to avoid re-compilation on every call
+// import type { DEVICE_TYPES } from './constants.js' // Removed unused import
+const SPACES_REGEX = /\s/g;
+const CAMELCASE_REGEX = /([A-Z])/g;
+const FIRST_CHAR_REGEX = /^./;
 /**
  * Get RSSI signal quality level and color based on dBm value
  * @param rssi Signal strength in dBm (typically -30 to -90)
@@ -234,23 +239,29 @@ export function renderDeviceDetailsPanel(device) {
     let batteryHistory = [];
     try {
         const raw = localStorage.getItem(batteryHistoryKey);
-        if (raw)
+        if (raw) {
             batteryHistory = JSON.parse(raw);
+        }
+    }
+    catch (e) {
+        // Optionally log or handle error
     }
-    catch { }
     const now = Date.now();
     if (typeof device?.battery === 'number') {
         // Only add if different from last or >1h since last
-        const last = batteryHistory[batteryHistory.length - 1];
+        const last = batteryHistory.at(-1);
         if (!last || last.value !== device.battery || now - last.ts > 60 * 60 * 1000) {
             batteryHistory.push({ value: device.battery, ts: now });
             // Keep only last 30 entries (about a month if daily)
-            if (batteryHistory.length > 30)
+            if (batteryHistory.length > 30) {
                 batteryHistory = batteryHistory.slice(-30);
+            }
             try {
                 localStorage.setItem(batteryHistoryKey, JSON.stringify(batteryHistory));
             }
-            catch { }
+            catch (e) {
+                // Optionally log or handle error
+            }
         }
     }
     const rows = [
@@ -329,7 +340,9 @@ export function renderDeviceDetailsPanel(device) {
             chart.style.height = '28px';
             chart.style.display = 'flex';
             // SVG sparkline
-            const w = 120, h = 24, pad = 2;
+            const w = 120;
+            const h = 24;
+            const pad = 2;
             const min = Math.min(...batteryHistory.map(b => b.value), 100);
             const max = Math.max(...batteryHistory.map(b => b.value), 0);
             const range = max - min || 1;
@@ -386,11 +399,26 @@ export function renderDeviceDetailsPanel(device) {
     }
     // --- Expose advanced/extra features dynamically ---
     const featureKeys = [
-        'airQuality', 'pm25', 'pm10', 'voc', 'co2', 'humidity', 'temperature',
-        'preset', 'mode', 'presetMode', 'direction', 'calibration', 'multiCommand',
-        'extendedInfo', 'segmentedControl', 'features', 'capabilities', 'state',
+        'airQuality',
+        'pm25',
+        'pm10',
+        'voc',
+        'co2',
+        'humidity',
+        'temperature',
+        'preset',
+        'mode',
+        'presetMode',
+        'direction',
+        'calibration',
+        'multiCommand',
+        'extendedInfo',
+        'segmentedControl',
+        'features',
+        'capabilities',
+        'state',
     ];
-    const shown = new Set(rows.map(r => r.label.toLowerCase().replace(/\s/g, '')));
+    const shown = new Set(rows.map(r => r.label.toLowerCase().replace(SPACES_REGEX, '')));
     for (const key of featureKeys) {
         if (device && device[key] !== undefined && !shown.has(key.toLowerCase())) {
             const line = document.createElement('div');
@@ -402,7 +430,7 @@ export function renderDeviceDetailsPanel(device) {
             const label = document.createElement('span');
             label.style.fontWeight = '600';
             label.style.minWidth = '110px';
-            label.textContent = key.replace(/([A-Z])/g, ' $1').replace(/^./, s => s.toUpperCase()) + ':';
+            label.textContent = `${key.replace(CAMELCASE_REGEX, ' $1').replace(FIRST_CHAR_REGEX, s => s.toUpperCase())}:`;
             const value = document.createElement('span');
             value.style.fontFamily = 'monospace';
             value.style.fontSize = '11px';
@@ -485,15 +513,17 @@ export async function renderDiscoveredDevices(devices, options = {}) {
         }
         // Show offline/unreachable indicator if device is offline
         let offline = false;
-        let lastSeen = d.lastSeen || d.lastseen || d.updatedAt;
+        const lastSeen = d.lastSeen || d.lastseen || d.updatedAt;
         if (typeof d.offline === 'boolean') {
             offline = d.offline;
         }
         else if (lastSeen) {
             try {
                 const last = new Date(lastSeen).getTime();
-                if (!isNaN(last) && Date.now() - last > 1000 * 60 * 60) { // 1 hour
-                    offline = true;
+                if (!Number.isNaN(last)) {
+                    if (Date.now() - last > 1000 * 60 * 60) { // 1 hour
+                        offline = true;
+                    }
                 }
             }
             catch { }
@@ -549,8 +579,8 @@ export async function renderDiscoveredDevices(devices, options = {}) {
         if (typeof d.battery === 'number' && d.battery < 20) {
             const batteryWarn = document.createElement('span');
             batteryWarn.textContent = `⚠️ ${d.battery}%`;
-            batteryWarn.style.cssText =
-                d.battery < 10
+            batteryWarn.style.cssText
+                = d.battery < 10
                     ? 'background: #dc2626; color: white; padding: 1px 6px; border-radius: 3px; font-size: 10px; font-weight: 600; margin-left: 6px;'
                     : 'background: #fbbf24; color: #111; padding: 1px 6px; border-radius: 3px; font-size: 10px; font-weight: 600; margin-left: 6px;';
             batteryWarn.title = d.battery < 10 ? 'Battery critically low' : 'Battery low';
@@ -652,7 +682,7 @@ export function filterDevices(devices, connectionType = 'all', searchQuery = '')
     let filtered = [...devices];
     // Filter by connection type
     if (connectionType !== 'all') {
-        filtered = filtered.filter(d => {
+        filtered = filtered.filter((d) => {
             if (connectionType === 'ir') {
                 return d.isIR === true;
             }
@@ -671,7 +701,7 @@ export function filterDevices(devices, connectionType = 'all', searchQuery = '')
     // Filter by search query
     if (searchQuery.trim()) {
         const query = searchQuery.toLowerCase();
-        filtered = filtered.filter(d => {
+        filtered = filtered.filter((d) => {
             const name = (d.name || '').toLowerCase();
             const id = (d.id || '').toLowerCase();
             const type = (d.type || '').toLowerCase();
@@ -710,11 +740,11 @@ export function sortDevices(devices, sortBy = 'name') {
         case 'connection': {
             // Sort by connection type: Both > BLE > OpenAPI > Others
             const connectionOrder = {
-                'Both': 0,
-                'BLE': 1,
-                'OpenAPI': 2,
-                'API': 2,
-                'Unknown': 3,
+                Both: 0,
+                BLE: 1,
+                OpenAPI: 2,
+                API: 2,
+                Unknown: 3,
             };
             sorted.sort((a, b) => {
                 const aOrder = connectionOrder[a.connectionType || 'Unknown'] ?? 3;
@@ -755,6 +785,9 @@ export function getDiscoveryPreferences() {
 /**
  * Save filter/sort preferences to localStorage
  * @param preferences Preferences object to save
+ * @param preferences.connectionType Connection type filter
+ * @param preferences.sortBy Sort criterion
+ * @param preferences.searchQuery Search query string
  */
 export function setDiscoveryPreferences(preferences) {
     try {
@@ -890,7 +923,12 @@ export function renderDeviceList(list) {
                 }, 1200);
             }
             catch (e) {
-                alert('Failed to copy');
+                copyBtn.textContent = 'Failed';
+                copyBtn.classList.add('error');
+                setTimeout(() => {
+                    copyBtn.textContent = 'Copy ID';
+                    copyBtn.classList.remove('error');
+                }, 1200);
             }
         });
         const deleteBtn = document.createElement('button');
@@ -910,5 +948,6 @@ export function renderDeviceList(list) {
         li.appendChild(buttons);
         ul.appendChild(li);
     }
+    // No return value needed for void function
 }
 //# sourceMappingURL=render.js.map