@switchbot/homebridge-switchbot 5.0.0-beta.111 → 5.0.0-beta.113

package/src/switchbotClient.ts

@@ -1,4 +1,5 @@
 import type { SwitchBotPluginConfig } from './settings.js'
+import { SwitchbotOperationError, SwitchbotAuthenticationError, CharacteristicMissingError } from './errors.js'
 
 export interface ISwitchBotClient {
   init(): Promise<void>
@@ -93,8 +94,17 @@ export class SwitchBotClient implements ISwitchBotClient {
     if (this.client?.getDevice) {
       try {
         return await this.client.getDevice(id)
-      } catch (e) {
-        this.logger?.warn?.(`Client getDevice failed for ${id}, trying OpenAPI fallback:`, e)
+      } catch (e: any) {
+        if (e instanceof SwitchbotAuthenticationError) {
+          this.logger?.error?.(`Authentication error for getDevice(${id}):`, e.message)
+          throw e
+        } else if (e instanceof SwitchbotOperationError) {
+          this.logger?.warn?.(`Operation error for getDevice(${id}):`, e.message, e.code)
+        } else if (e instanceof CharacteristicMissingError) {
+          this.logger?.warn?.(`Characteristic missing for getDevice(${id}):`, e.characteristic)
+        } else {
+          this.logger?.warn?.(`Client getDevice failed for ${id}, trying OpenAPI fallback:`, e)
+        }
       }
     }
     // Fallback: call OpenAPI via HTTP
@@ -104,7 +114,7 @@ export class SwitchBotClient implements ISwitchBotClient {
       const resp = await this.fetchWithTimeoutAndRetry(url, opts)
       return resp.json()
     }
-    throw new Error('No SwitchBot client available')
+    throw new SwitchbotOperationError('No SwitchBot client available', 'no_client')
   }
 
   async getDevices(): Promise<any[]> {
@@ -149,7 +159,14 @@ export class SwitchBotClient implements ISwitchBotClient {
         try {
           const out = await this._doSetDeviceState(id, entry.body)
           for (const r of entry.resolvers) r.resolve(out)
-        } catch (e) {
+        } catch (e: any) {
+          if (e instanceof SwitchbotAuthenticationError) {
+            this.logger?.error?.(`Authentication error for setDeviceState(${id}):`, e.message)
+          } else if (e instanceof SwitchbotOperationError) {
+            this.logger?.warn?.(`Operation error for setDeviceState(${id}):`, e.message, e.code)
+          } else if (e instanceof CharacteristicMissingError) {
+            this.logger?.warn?.(`Characteristic missing for setDeviceState(${id}):`, e.characteristic)
+          }
           for (const r of entry.resolvers) r.reject(e)
         }
       }, this.writeDebounceMs)
@@ -166,8 +183,17 @@ export class SwitchBotClient implements ISwitchBotClient {
         const result = await this.client.setDeviceState(id, body)
         this.logger?.debug?.(`[${id}] client.setDeviceState() response:`, result)
         return result
-      } catch (e) {
-        this.logger?.warn?.(`Client setDeviceState failed for ${id}, trying fallback:`, e)
+      } catch (e: any) {
+        if (e instanceof SwitchbotAuthenticationError) {
+          this.logger?.error?.(`Authentication error for setDeviceState(${id}):`, e.message)
+          throw e
+        } else if (e instanceof SwitchbotOperationError) {
+          this.logger?.warn?.(`Operation error for setDeviceState(${id}):`, e.message, e.code)
+        } else if (e instanceof CharacteristicMissingError) {
+          this.logger?.warn?.(`Characteristic missing for setDeviceState(${id}):`, e.characteristic)
+        } else {
+          this.logger?.warn?.(`Client setDeviceState failed for ${id}, trying fallback:`, e)
+        }
       }
     }
 
@@ -178,8 +204,17 @@ export class SwitchBotClient implements ISwitchBotClient {
         const result = await this.client.sendCommand(id, body)
         this.logger?.debug?.(`[${id}] client.sendCommand() response:`, result)
         return result
-      } catch (e) {
-        this.logger?.warn?.(`Client sendCommand failed for ${id}, trying OpenAPI:`, e)
+      } catch (e: any) {
+        if (e instanceof SwitchbotAuthenticationError) {
+          this.logger?.error?.(`Authentication error for sendCommand(${id}):`, e.message)
+          throw e
+        } else if (e instanceof SwitchbotOperationError) {
+          this.logger?.warn?.(`Operation error for sendCommand(${id}):`, e.message, e.code)
+        } else if (e instanceof CharacteristicMissingError) {
+          this.logger?.warn?.(`Characteristic missing for sendCommand(${id}):`, e.characteristic)
+        } else {
+          this.logger?.warn?.(`Client sendCommand failed for ${id}, trying OpenAPI:`, e)
+        }
       }
     }
 
@@ -203,7 +238,7 @@ export class SwitchBotClient implements ISwitchBotClient {
       return result
     }
 
-    throw new Error('No SwitchBot client available for setDeviceState')
+    throw new SwitchbotOperationError('No SwitchBot client available for setDeviceState', 'no_client')
   }
 
   async destroy(): Promise<void> {

package/test/e2e/run-e2e.spec.ts

@@ -1,21 +1,21 @@
-import { describe, test } from 'vitest'
-import { promisify } from 'util'
-import { execFile } from 'child_process'
-import path from 'path'
+import { execFile } from 'node:child_process'
+import path from 'node:path'
+import { promisify } from 'node:util'
+import { describe, it } from 'vitest'
 
 const execFileP = promisify(execFile)
 
-describe('E2E scripts (manual-run harness)', () => {
+describe('e2e scripts (manual-run harness)', () => {
   if (!process.env.RUN_E2E) {
-    test.skip('E2E disabled - set RUN_E2E=true to enable', () => {})
+    it.skip('e2e disabled - set RUN_E2E=true to enable', () => {})
     return
   }
 
-  test('run configured E2E scripts sequentially', async () => {
+  it('should run configured e2e scripts sequentially', async () => {
     const repoRoot = path.resolve(__dirname, '../../')
     const scriptsDir = path.join(repoRoot, 'scripts', 'e2e')
 
-    const scriptsToRun: { envVar: string; script: string }[] = [
+    const scriptsToRun: { envVar: string, script: string }[] = [
       { envVar: 'LIGHT_ACCESSORY_ID', script: 'light-e2e.sh' },
       { envVar: 'FAN_ACCESSORY_ID', script: 'fan-e2e.sh' },
       { envVar: 'CURTAIN_ACCESSORY_ID', script: 'curtain-e2e.sh' },
@@ -32,7 +32,7 @@ describe('E2E scripts (manual-run harness)', () => {
 
       const scriptPath = path.join(scriptsDir, s.script)
       // Forward environment so scripts can read HB_URL / HB_TOKEN / <ACCESSORY_ID>
-      const env = Object.assign({}, process.env)
+      const env = { ...process.env }
 
       try {
         // eslint-disable-next-line no-console
@@ -40,7 +40,9 @@ describe('E2E scripts (manual-run harness)', () => {
         const { stdout, stderr } = await execFileP('bash', [scriptPath], { env })
         // eslint-disable-next-line no-console
         console.log(stdout)
-        if (stderr) console.error(stderr)
+        if (stderr) {
+          console.error(stderr)
+        }
       } catch (e: any) {
         // bubble up as test failure
         throw new Error(`Script ${s.script} failed: ${e.message}`)

package/test/helpers/matter-harness.ts

@@ -47,7 +47,7 @@ export function makeFakeApiWithoutMatter() {
     isMatterEnabled: () => false,
     hap: makeFakeHap(),
     platformAccessory: PlatformAccessory,
-    registerPlatformAccessories: (_p: string, _n: string, accs: any[]) => {},
-    on: (_ev: string, cb: Function) => {},
+    registerPlatformAccessories: () => {},
+    on: () => {},
   }
 }

package/test/matter-integration.spec.ts

@@ -47,6 +47,27 @@ describe('Matter integration harness', () => {
     expect(wcType).not.toBe(4)
   })
 
+  it('registers RGBIC Neon Wire Rope Light as lightstrip with conformant ColorControl defaults', async () => {
+    const matterApi = makeFakeMatterApi()
+    const api = makeFakeApiWithMatter(matterApi)
+
+    const platform = new SwitchBotMatterPlatform(console as any, {
+      devices: [{ id: 'neon-1', type: 'RGBIC Neon Wire Rope Light', name: 'Family Room Neon Wire Rope Light' }],
+      enableMatter: true,
+      preferMatter: true,
+    } as any, api as any)
+
+    await (platform as any).registerMatterAccessories()
+
+    const regs = matterApi.getRegistered()
+    expect(regs.length).toBeGreaterThanOrEqual(1)
+    const neon = regs.find((r: any) => r?.context?.deviceId === 'neon-1')
+    expect(neon).toBeDefined()
+    expect(neon?.context?.type).toBe('lightstrip')
+    expect(neon?.clusters?.colorControl).toBeDefined()
+    expect(neon?.clusters?.colorControl?.colorMode).toBe(0)
+  })
+
   it('registers Matter accessories when Matter API available', async () => {
     // Instantiate the real Matter platform directly to test its registration path
     const matterApi = makeFakeMatterApi()

package/todo/COMPLETED.md

@@ -1,9 +1,309 @@
+# Batch Import & Discovery UI Enhancements ✅ COMPLETED
+
+- [x] Add checkboxes to select multiple devices
+  - Users can now select multiple discovered devices using checkboxes in the discovery UI for batch actions.
+- [x] Add "Add Selected to Config" button
+  - A prominent "Add Selected to Config" button enables batch import of all selected devices, streamlining onboarding.
+- [x] Implement bulk configuration with smart defaults
+  - When importing multiple devices, the system applies smart defaults (type, name, MAC, etc.) and auto-fills config fields, reducing manual entry and errors.
+- [x] Show firmware update available indicators
+  - Devices with available firmware updates display an orange "Update Available" badge in the discovery UI.
+- [x] Show offline/unreachable warnings
+  - Devices that are offline or unreachable show a red "Offline" badge, based on status or last-seen timestamp.
+- [x] Add "Needs Attention" section at top
+  - Devices needing action (low battery, firmware update, offline) are grouped in a "Needs Attention" section at the top of the discovery UI for quick access.
+
+**Status:** All batch import and discovery UI features are implemented and live. Only battery level trending (historical data) remains as a future enhancement.
+# Integration: node-switchbot Beta Updates (March 2026)
+
+### Duplicate Detection ✅ COMPLETED
+
+- [x] The UI disables the "Add to Config" button and shows an "Already Added" badge for devices already in the config, preventing duplicate entries. Badges for recommended connection (BLE/API) are also shown based on signal/device type.
+
+**Status:** Duplicate detection is enforced in the UI, so users cannot add the same device twice. Connection recommendation badges are also displayed.
+# Integration: node-switchbot Beta Updates (March 2026)
+
+### One-Click Device Import ✅ COMPLETED
+
+- [x] Add "Add to Config" button next to each discovered device. Dramatically speeds up onboarding, reduces manual steps for users.
+
+**Status:** Each discovered device in the UI now has an "Add to Config" button. This enables one-click import directly from the discovery list.
+
+### Auto-populate Device Config Modal ✅ COMPLETED
+
+- [x] When importing, the config modal is auto-filled with discovered values (name, type, MAC, etc). Reduces user error and makes adding devices nearly frictionless.
+
+**Status:** The import modal pre-fills all relevant fields with discovered device data, streamlining the import process.
+
+### Pre-fill MAC Address for BLE Devices ✅ COMPLETED
+
+- [x] The import modal auto-fills the MAC address field with the discovered device's address, ensuring BLE devices are always added with the correct MAC.
+
+**Status:** The MAC address is pre-filled in the config modal for BLE devices, preventing user error and connection issues.
+
+### Duplicate Detection ✅ COMPLETED
+
+- [x] The UI disables the "Add to Config" button and shows an "Already Added" badge for devices already in the config, preventing duplicate entries.
+
+**Status:** Duplicate detection is enforced in the UI, so users cannot add the same device twice.
+# Integration: node-switchbot Beta Updates (March 2026)
+
+### Duplicate Detection ✅ COMPLETED
+
+- [x] The UI disables the "Add to Config" button and shows an "Already Added" badge for devices already in the config, preventing duplicate entries.
+
+**Status:** Duplicate detection is enforced in the UI, so users cannot add the same device twice.
+# Integration: node-switchbot Beta Updates (March 2026)
+
+### Pre-fill MAC Address for BLE Devices ✅ COMPLETED
+
+- [x] The import modal auto-fills the MAC address field with the discovered device's address, ensuring BLE devices are always added with the correct MAC.
+
+**Status:** The MAC address is pre-filled in the config modal for BLE devices, preventing user error and connection issues.
+# Integration: node-switchbot Beta Updates (March 2026)
+
+### One-Click Device Import ✅ COMPLETED
+
+- [x] Add "Add to Config" button next to each discovered device. Dramatically speeds up onboarding, reduces manual steps for users.
+
+**Status:** Each discovered device in the UI now has an "Add to Config" button. This enables one-click import directly from the discovery list.
+
+### Auto-populate Device Config Modal ✅ COMPLETED
+
+- [x] When importing, the config modal is auto-filled with discovered values (name, type, MAC, etc). Reduces user error and makes adding devices nearly frictionless.
+
+**Status:** The import modal pre-fills all relevant fields with discovered device data, streamlining the import process.
+# Integration: node-switchbot Beta Updates (March 2026)
+- [x] Update device registry and class mapping to match node-switchbot
+- [x] Add notification handling for BLE devices (per-command notification futures, unsolicited notification logging)
+
+- [x] Map new device types to Homebridge plugin (HubMini Matter, Hub3, Keypad Vision/Pro, Plug Mini EU, Roller Shade, Garage Door Opener, Floor Lamp, Art Frame, RGBICWW variants, K10/K11/K20/S10/S20 vacuums, Lock Lite/Vision/Pro/WiFi, Circulator Fan, Smart Thermostat Radiator, Climate Panel, Evaporative Humidifier, Strip Light 3, etc.)
+- [x] Expose new device features in UI (air quality, preset modes, calibration, direction, multi-command, extended info, segmented control, etc.)
+- [x] Integrate BLE encryption for all supported devices (relay, lock, air purifier, light strip, bulb, etc.)
+# BLE Response Length Validation ✅ COMPLETED
+
+- [x] Implement response length validation for BLE status parsing
+
+**Status:** All BLE status parsing now validates the response buffer/array length before parsing. Invalid responses are logged and rejected, improving robustness and diagnostics for all BLE devices.
+
+---
+# Error Class Handling Integration ✅ COMPLETED
+
+- [x] Add support for new error classes and improved error handling (SwitchbotOperationError, SwitchbotAuthenticationError, CharacteristicMissingError)
+
+**Status:** The plugin now imports and uses node-switchbot v4 error classes, with robust instanceof-based handling and compatible fallbacks. All error types are logged and surfaced appropriately, and the code is ready for future node-switchbot error model changes.
+
+---
+### Batch Enable/Disable Devices ✅ COMPLETED
+
+- [x] Allow batch enable/disable of devices
+
+**Status:** The UI now provides 'Enable Selected' and 'Disable Selected' buttons, allowing users to batch enable or disable devices directly from the discovery view.
+
+---
+
+### Batch Operation Progress Indicator ✅ COMPLETED
+
+- [x] Show progress for batch operations
+
+**Status:** The UI now displays a progress indicator during batch add/configure operations, giving users real-time feedback on operation status and completion.
+
+---
+
+### Real-Time RSSI Updates During Scan ✅ COMPLETED
+
+- [x] Update RSSI values in real-time during scan
+
+**Status:** The UI now polls for BLE scan results and updates device RSSI values live during the scan window, providing real-time signal strength feedback.
+
+---
+
+### Needs Attention Section in Discovery UI ✅ COMPLETED
+
+- [x] Add 'Needs Attention' section at the top of the device discovery UI
+
+**Status:** Devices with low battery (<20%), firmware updates available, or offline/unreachable status are now aggregated and displayed in a prominent 'Needs Attention' section at the top of the discovery UI. This helps users quickly identify and address devices that require action.
+
+---
+
 # Completed TODOs
 
+### Firmware Update Available Indicator ✅ COMPLETED
+
+### Offline/Unreachable Warning Indicator ✅ COMPLETED
+
+- [x] Show offline/unreachable warnings
+
+**Status:** Devices that are offline or unreachable (either via a boolean property or if last seen > 1 hour ago) now display a red 'Offline' badge in the discovery UI next to the device name.
+
+
+- [x] Show firmware update available indicators
+
+**Status:** Devices with a firmware update available now display an orange 'Update Available' badge in the discovery UI next to the device name.
+
+
 This file tracks all completed features and improvements for the SwitchBot Homebridge Plugin.
 
 ---
 
+## Recent Completed Work
+
+### Connection Testing (First Slice) ✅ COMPLETED
+
+- [x] Added "Test Connection" button per device (discovered and configured cards)
+- [x] Added backend connectivity check endpoint (`/test-connection`)
+- [x] Attempted basic status read via device fetch during test
+- [x] Added success/failure indicator with inline result details
+- [x] Displayed measured connection latency (ms)
+- [x] Displayed connection method result (BLE/OpenAPI/Auto)
+
+  **Status:** Users can now run per-device connection checks directly from the UI and immediately see method and latency results.
+
+### Matter Neon Wire Rope Light Registration Verification ✅ COMPLETED
+
+- [x] **Verify Matter registration for "Family Room Neon Wire Rope Light" succeeds without behavior rollback**
+  - [x] Added targeted Matter integration regression test for `RGBIC Neon Wire Rope Light`
+  - [x] Verified normalization to Matter type `lightstrip`
+  - [x] Verified `colorControl.colorMode` default is present (`0`) to satisfy conformance
+  - [x] Validated registration path end-to-end with Matter harness
+
+  **Status:** Neon Wire Rope Light registration now has regression coverage and registers with conformant ColorControl defaults.
+
+### Matter Lightstrip Conformance ✅ COMPLETED
+
+- [x] **Fix Matter lightstrip registration conformance requiring `colorControl.colorMode`**
+  - [x] **Issue:** Matter accessory initialization failed for color lightstrip devices with conformance errors
+  - [x] **Error:** `Conformance "M": Matter requires you to set this attribute ... colorControl.state.colorMode`
+  - [x] **Fix:** Added required `colorMode` default for lightstrip color control state while avoiding disallowed default writes
+
+  **Status:** Lightstrip accessories now provide required ColorControl state for Matter initialization.
+
+
+### Battery Warnings in Device List ✅ COMPLETED
+
+- [x] Show battery warnings (< 20%) with yellow/red indicators
+
+**Status:** Devices with battery below 20% now display a yellow (10–19%) or red (<10%) warning badge in the discovery UI, with a tooltip for low/critical battery.
+
+### Streaming BLE Device Discovery ✅ COMPLETED
+
+- [x] Show devices as they're discovered (streaming results via polling)
+
+**Status:** Devices now appear in the UI as soon as they're discovered during BLE scan, providing a real-time streaming experience.
+
+---
+
+### Discovery Better Loading States ✅ COMPLETED
+
+- [x] Show progress indicator phases: `Scanning BLE` → `Fetching OpenAPI` → `Complete`
+- [x] Added spinner/progress visuals for each phase
+- [x] Display partial discovery results while later phases continue
+- [x] Show elapsed time for current phase and total discovery time
+- [x] Added cancel button for long discovery runs
+
+  **Status:** Discovery UX now provides real-time progress and immediate partial feedback.
+
+### Discovery Device Grouping ✅ COMPLETED
+
+- [x] Implemented grouping by connection type
+- [x] Implemented grouping by hub
+- [x] Added expandable/collapsible group headers
+- [x] Added group counts in headers
+- [x] Persisted expanded/collapsed state in localStorage
+
+  **Status:** Discovery lists are grouped, collapsible, and stateful across sessions.
+
+### Discovery Connection Recommendations ✅ COMPLETED
+
+- [x] Added `⚡ Recommended: BLE` badge for strong RSSI devices
+- [x] Added `☁️ Recommended: API` badge for hub-dependent devices
+- [x] Added recommendation tooltips explaining reasoning
+- [x] Applied device-type-aware recommendation heuristics
+
+  **Status:** Discovery cards now provide actionable connection guidance.
+
+### Configurable BLE Scan ✅ COMPLETED
+
+- [x] Added scan duration settings (3s/5s/10s/15s)
+- [x] Added option to disable BLE scanning
+- [x] Added adjustable BLE timeout setting
+- [x] Persisted BLE scan preferences in localStorage
+- [x] Added Bluetooth availability status indicator
+
+  **Status:** BLE discovery behavior is user-configurable and persisted.
+
+### Discovery History/Cache ✅ COMPLETED
+
+- [x] Cache last discovery results for 5 minutes
+- [x] Show "Last scanned: X minutes ago" with timestamp
+- [x] Add "Refresh" button to re-scan
+- [x] Show cached results immediately on page load
+- [x] Auto-refresh option with configurable interval
+
+  **Status:** Discovery now restores recent results instantly and supports manual/automatic refresh.
+
+### Discovery UX Polish ✅ COMPLETED
+
+- [x] Added `Hide Added` discovery filter to exclude already-configured devices
+- [x] Improved BLE settings row alignment (`Scan`, `Timeout`, and units)
+- [x] Reduced extra spacing between BLE settings row and Bluetooth adapter status
+- [x] Hide `Scan` and `Timeout` controls when `Disable BLE scan` is enabled
+
+  **Status:** Discovery controls are cleaner and faster to use for repeat configuration workflows.
+
+### Detailed Device Info Panel ✅ COMPLETED
+
+- [x] Added click-to-expand toggle button (▾) to device cards with rotation animation
+- [x] Created expandable details panel showing extended device information:
+  - [x] Device ID with copy button
+  - [x] MAC Address with copy button
+  - [x] Device Type
+  - [x] Model
+  - [x] Hub ID (if applicable)
+  - [x] Battery level (if available)
+  - [x] Firmware version (if available)
+  - [x] Cloud Service status (enabled/disabled)
+  - [x] Last Seen timestamp (human-readable format)
+- [x] Implemented copy-to-clipboard functionality with visual feedback (📋 → ✓ for 2s)
+- [x] Styled details panel with SwitchBot theme (light gray background, compact rows)
+- [x] Persisted expand/collapse state in-session (resets on page reload)
+
+  **Status:** Device cards now provide quick access to extended metadata with one-click copying of ID and MAC. Details panel uses clean, readable table layout within the card.
+
+### Extended Details in Configured Devices ✅ COMPLETED
+
+- [x] Added expandable toggle (▾) to configured device cards in config section
+- [x] Details panel shows same extended information as discovered devices:
+  - [x] Device ID with copy button
+  - [x] MAC Address with copy button  
+  - [x] Device Type
+  - [x] Model
+  - [x] Hub ID (if applicable)
+  - [x] Battery level (if available)
+  - [x] Firmware version (if available)
+  - [x] Cloud Service status
+  - [x] Last Seen timestamp
+- [x] Toggle button rotates when expanded/collapsed (smooth animation)
+- [x] Details available directly from card without opening Edit modal
+
+  **Status:** Configured devices now have the same quick-access details panel as discovered devices, making it easy to view metadata without opening the Edit dialog.
+
+### Real-Time BLE Scanning (Partial) ✅ PARTIALLY COMPLETED
+
+- [x] Added animated "pulsing" indicator during active BLE scan using CSS animation
+- [x] Implemented "X devices found..." counter that displays during scan
+  - Shows BLE device count after BLE phase completes
+  - Updates to merged count when OpenAPI phase completes
+  - Auto-hides when discovery finishes
+- [x] Counter shows pulse animation (1.5s opacity fade cycle) while scanning
+- [x] Gracefully removes pulse animation and hides counter on cancellation/error
+- [ ] Real-time streaming results via polling (partial implementation - displays final count per phase)
+- [ ] Real-time RSSI updates during scan (requires server-side streaming support)
+
+  **Status:** Discovery now shows visual feedback with a pulsing "X devices found" counter. Full streaming of individual results per-device would require backend support for Server-Sent Events (SSE) or WebSocket streaming. Current implementation displays phase-wise device counts (BLE count → merged final count).
+
+---
+
 ## Code Refactoring & Architecture
 
 ### Server-Side Refactoring ✅ COMPLETED
@@ -181,6 +481,19 @@ This file tracks all completed features and improvements for the SwitchBot Homeb
 
 ## Bug Fixes & Technical Debt
 
+### Fix Discovery Not Showing Devices ✅ COMPLETED
+
+- [x] **Issue:** No devices appear in discovery results after clicking "Discover Devices"
+- [x] **Root Cause:** Discovery UI cleared the `#discoveredList` div (including the `<ul id="discoveredDevices">` element), but then tried to replace a non-existent element when rendering discovered devices
+- [x] **Effect:** `document.getElementById('discoveredDevices')?.replaceWith(ul)` silently failed due to optional chaining, leaving the list empty
+
+**Implementation:**
+- Modified `discoverDevices()` in `discovery.ts` to create a new `<ul id="discoveredDevices">` container if it doesn't exist after clearing controls
+- Updated `updateDiscoveryView()` to check if the element exists before using `replaceWith()`, with fallback to append if element is missing
+- Added proper element lifecycle management for discovery list rendering
+
+**Status:** Discovery now properly displays all discovered devices. Devices appear correctly with filters, sorting, and duplicate detection badges.
+
 ### Fix lint & lint:fix scripts ✅ COMPLETED
 
 - [x] Update ESLint configuration to include `src/homebridge-ui/**/*.ts` files