@swarmclawai/swarmclaw 1.3.5 → 1.3.6

package/README.md

@@ -204,6 +204,11 @@ Read the full setup guide in [`SWARMDOCK.md`](./SWARMDOCK.md), browse the public
 
 ## Release Notes
 
+### v1.3.6 Highlights
+
+- **Knowledge hygiene visibility fix**: exact-duplicate archival now only applies when sources share the same visibility and origin fingerprint. Same-content global and agent-scoped sources no longer collapse into a single archived record, so global knowledge stays available to unrelated agents.
+- **Release gate hardening**: the default test matrix now includes the 1.3.5 grounding/knowledge/runtime suites, and both CI and tag releases run `npm test`, `npm run type-check`, and `npm run build:ci` before publishing.
+
 ### v1.3.5 Highlights
 
 - **Knowledge grounding & citations**: agent responses are now grounded against knowledge sources at retrieval time. Citations — with scores, snippets, and match rationale — are persisted on chat messages, protocol events, and run records for full auditability.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@swarmclawai/swarmclaw",
-  "version": "1.3.5",
+  "version": "1.3.6",
   "description": "Self-hosted AI runtime for OpenClaw, delegation, autonomy, runtime skills, crypto wallets, and chat platform connectors.",
   "license": "MIT",
   "publishConfig": {
@@ -62,7 +62,7 @@
     "benchmark:autonomy": "node ./scripts/benchmark-autonomy-harness.mjs",
     "benchmark:agent-regression": "node --import tsx ./scripts/run-agent-regression-suite.ts",
     "type-check": "tsc --noEmit",
-    "test": "npm run test:cli && npm run test:setup && npm run test:openclaw",
+    "test": "npm run test:cli && npm run test:setup && npm run test:openclaw && npm run test:runtime",
     "format": "eslint --fix",
     "lint": "eslint",
     "lint:fix": "eslint --fix",
@@ -72,6 +72,7 @@
     "test:cli": "node --test src/cli/*.test.js bin/*.test.js scripts/postinstall.test.mjs",
     "test:setup": "tsx --test src/app/api/setup/check-provider/route.test.ts src/lib/server/provider-model-discovery.test.ts src/components/auth/setup-wizard/utils.test.ts src/components/auth/setup-wizard/types.test.ts src/hooks/setup-done-detection.test.ts src/lib/setup-defaults.test.ts",
     "test:openclaw": "tsx --test src/lib/openclaw/openclaw-agent-id.test.ts src/lib/openclaw/openclaw-endpoint.test.ts src/lib/server/agents/agent-runtime-config.test.ts src/lib/server/build-llm.test.ts src/lib/server/connectors/connector-routing.test.ts src/lib/server/connectors/openclaw.test.ts src/lib/server/gateway/protocol.test.ts src/lib/server/llm-response-cache.test.ts src/lib/server/mcp-conformance.test.ts src/lib/server/openclaw/agent-resolver.test.ts src/lib/server/openclaw/deploy.test.ts src/lib/server/openclaw/skills-normalize.test.ts src/lib/server/session-tools/openclaw-nodes.test.ts src/lib/server/tasks/task-quality-gate.test.ts src/lib/server/tasks/task-validation.test.ts src/lib/server/tool-capability-policy.test.ts src/lib/providers/openclaw-exports.test.ts src/app/api/openclaw/dashboard-url/route.test.ts",
+    "test:runtime": "tsx --test src/lib/server/knowledge-sources.test.ts src/lib/server/chat-execution/chat-execution-grounding.test.ts src/lib/server/protocols/protocol-service.test.ts src/lib/server/runtime/run-ledger.test.ts",
     "test:e2e": "tsx .workbench/browser-e2e/run.ts",
     "test:mcp:conformance": "node --import tsx ./scripts/mcp-conformance-check.ts",
     "prepack": "npm run build:ci",

package/src/lib/server/chat-execution/chat-execution-disabled.test.ts

@@ -1,40 +1,23 @@
 import assert from 'node:assert/strict'
-import fs from 'node:fs'
-import os from 'node:os'
-import path from 'node:path'
-import { spawnSync } from 'node:child_process'
 import test from 'node:test'
+import { runWithTempDataDir as runWithSharedTempDataDir } from '@/lib/server/test-utils/run-with-temp-data-dir'
 
-const repoRoot = path.resolve(path.dirname(new URL(import.meta.url).pathname), '../../..')
-
-function runWithTempDataDir(script: string) {
-  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'swarmclaw-chat-disabled-'))
-  try {
-    const result = spawnSync(process.execPath, ['--import', 'tsx', '--input-type=module', '--eval', script], {
-      cwd: repoRoot,
-      env: {
-        ...process.env,
-        DATA_DIR: path.join(tempDir, 'data'),
-        WORKSPACE_DIR: path.join(tempDir, 'workspace'),
-        BROWSER_PROFILES_DIR: path.join(tempDir, 'browser-profiles'),
-      },
-      encoding: 'utf-8',
-    })
-    assert.equal(result.status, 0, result.stderr || result.stdout || 'subprocess failed')
-    const lines = (result.stdout || '')
-      .trim()
-      .split('\n')
-      .map((line) => line.trim())
-      .filter(Boolean)
-    const jsonLine = [...lines].reverse().find((line) => line.startsWith('{'))
-    return JSON.parse(jsonLine || '{}')
-  } finally {
-    fs.rmSync(tempDir, { recursive: true, force: true })
-  }
+function runWithTempDataDir<T = unknown>(script: string): T {
+  return runWithSharedTempDataDir<T>(script, {
+    prefix: 'swarmclaw-chat-disabled-',
+    dataDir: 'data',
+    browserProfilesDir: 'browser-profiles',
+  })
 }
 
 test('executeSessionChatTurn persists a visible error for disabled agents', () => {
-  const output = runWithTempDataDir(`
+  const output = runWithTempDataDir<{
+    error: string | null
+    text: string | null
+    persisted: boolean
+    lastRole: string | null
+    lastText: string | null
+  }>(`
     const storageMod = await import('@/lib/server/storage')
     const storage = storageMod.default || storageMod['module.exports'] || storageMod
     const threadMod = await import('@/lib/server/agents/agent-thread-session')

package/src/lib/server/chat-execution/chat-execution-eval-history.test.ts

@@ -1,40 +1,13 @@
 import assert from 'node:assert/strict'
-import fs from 'node:fs'
-import os from 'node:os'
-import path from 'node:path'
-import { spawnSync } from 'node:child_process'
 import test from 'node:test'
-
-const repoRoot = path.resolve(path.dirname(new URL(import.meta.url).pathname), '../../..')
-
-function runWithTempDataDir(script: string) {
-  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'swarmclaw-chat-eval-history-'))
-  try {
-    const result = spawnSync(process.execPath, ['--import', 'tsx', '--input-type=module', '--eval', script], {
-      cwd: repoRoot,
-      env: {
-        ...process.env,
-        DATA_DIR: path.join(tempDir, 'data'),
-        WORKSPACE_DIR: path.join(tempDir, 'workspace'),
-        BROWSER_PROFILES_DIR: path.join(tempDir, 'browser-profiles'),
-      },
-      encoding: 'utf-8',
-    })
-    assert.equal(result.status, 0, result.stderr || result.stdout || 'subprocess failed')
-    const lines = (result.stdout || '')
-      .trim()
-      .split('\n')
-      .map((line) => line.trim())
-      .filter(Boolean)
-    const jsonLine = [...lines].reverse().find((line) => line.startsWith('{'))
-    return JSON.parse(jsonLine || '{}')
-  } finally {
-    fs.rmSync(tempDir, { recursive: true, force: true })
-  }
-}
+import { runWithTempDataDir } from '@/lib/server/test-utils/run-with-temp-data-dir'
 
 test('executeSessionChatTurn persists internal eval user turns for same-thread recall', () => {
-  const output = runWithTempDataDir(`
+  const output = runWithTempDataDir<{
+    recallText: string | null
+    roles: string[]
+    texts: string[]
+  }>(`
     const storageMod = await import('@/lib/server/storage')
     const storage = storageMod.default || storageMod['module.exports'] || storageMod
     const providersMod = await import('@/lib/providers/index')
@@ -103,7 +76,11 @@ test('executeSessionChatTurn persists internal eval user turns for same-thread r
       roles: storedSession.messages.map((entry) => entry.role),
       texts: storedSession.messages.map((entry) => entry.text),
     }))
-  `)
+  `, {
+    prefix: 'swarmclaw-chat-eval-history-',
+    dataDir: 'data',
+    browserProfilesDir: 'browser-profiles',
+  })
 
   assert.match(String(output.recallText || ''), /Sunbird/)
   assert.deepEqual(output.roles, ['user', 'assistant', 'user', 'assistant'])

package/src/lib/server/chat-execution/chat-execution-grounding.test.ts

@@ -1,40 +1,17 @@
 import assert from 'node:assert/strict'
-import fs from 'node:fs'
-import os from 'node:os'
-import path from 'node:path'
-import { spawnSync } from 'node:child_process'
 import test from 'node:test'
-
-const repoRoot = path.resolve(path.dirname(new URL(import.meta.url).pathname), '../../..')
-
-function runWithTempDataDir(script: string) {
-  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'swarmclaw-chat-grounding-'))
-  try {
-    const result = spawnSync(process.execPath, ['--import', 'tsx', '--input-type=module', '--eval', script], {
-      cwd: repoRoot,
-      env: {
-        ...process.env,
-        DATA_DIR: path.join(tempDir, 'data'),
-        WORKSPACE_DIR: path.join(tempDir, 'workspace'),
-        BROWSER_PROFILES_DIR: path.join(tempDir, 'browser-profiles'),
-      },
-      encoding: 'utf-8',
-    })
-    assert.equal(result.status, 0, result.stderr || result.stdout || 'subprocess failed')
-    const lines = (result.stdout || '')
-      .trim()
-      .split('\n')
-      .map((line) => line.trim())
-      .filter(Boolean)
-    const jsonLine = [...lines].reverse().find((line) => line.startsWith('{'))
-    return JSON.parse(jsonLine || '{}')
-  } finally {
-    fs.rmSync(tempDir, { recursive: true, force: true })
-  }
-}
+import { runWithTempDataDir } from '@/lib/server/test-utils/run-with-temp-data-dir'
 
 test('executeSessionChatTurn persists citations and retrieval traces on grounded assistant messages', () => {
-  const output = runWithTempDataDir(`
+  const output = runWithTempDataDir<{
+    persisted: boolean
+    resultCitationCount: number
+    resultSelectorStatus: string | null
+    messageCitationCount: number
+    messageTraceHitCount: number
+    messageSelectorStatus: string | null
+    messageSourceTitle: string | null
+  }>(`
     const storageMod = await import('@/lib/server/storage')
     const providersMod = await import('@/lib/providers/index')
     const threadMod = await import('@/lib/server/agents/agent-thread-session')
@@ -115,7 +92,11 @@ test('executeSessionChatTurn persists citations and retrieval traces on grounded
       messageSelectorStatus: lastMessage?.retrievalTrace?.selectorStatus || null,
       messageSourceTitle: lastMessage?.citations?.[0]?.sourceTitle || null,
     }))
-  `)
+  `, {
+    prefix: 'swarmclaw-chat-grounding-',
+    dataDir: 'data',
+    browserProfilesDir: 'browser-profiles',
+  })
 
   assert.equal(output.persisted, true)
   assert.equal(output.resultCitationCount >= 1, true)

package/src/lib/server/chat-execution/chat-execution-session-sync.test.ts

@@ -1,40 +1,24 @@
 import assert from 'node:assert/strict'
-import fs from 'node:fs'
-import os from 'node:os'
-import path from 'node:path'
-import { spawnSync } from 'node:child_process'
 import test from 'node:test'
-
-const repoRoot = path.resolve(path.dirname(new URL(import.meta.url).pathname), '../../..')
-
-function runWithTempDataDir(script: string) {
-  const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'swarmclaw-chat-session-sync-'))
-  try {
-    const result = spawnSync(process.execPath, ['--import', 'tsx', '--input-type=module', '--eval', script], {
-      cwd: repoRoot,
-      env: {
-        ...process.env,
-        DATA_DIR: path.join(tempDir, 'data'),
-        WORKSPACE_DIR: path.join(tempDir, 'workspace'),
-        BROWSER_PROFILES_DIR: path.join(tempDir, 'browser-profiles'),
-      },
-      encoding: 'utf-8',
-    })
-    assert.equal(result.status, 0, result.stderr || result.stdout || 'subprocess failed')
-    const lines = (result.stdout || '')
-      .trim()
-      .split('\n')
-      .map((line) => line.trim())
-      .filter(Boolean)
-    const jsonLine = [...lines].reverse().find((line) => line.startsWith('{'))
-    return JSON.parse(jsonLine || '{}')
-  } finally {
-    fs.rmSync(tempDir, { recursive: true, force: true })
-  }
+import { runWithTempDataDir as runWithSharedTempDataDir } from '@/lib/server/test-utils/run-with-temp-data-dir'
+
+function runWithTempDataDir<T = unknown>(script: string): T {
+  return runWithSharedTempDataDir<T>(script, {
+    prefix: 'swarmclaw-chat-session-sync-',
+    dataDir: 'data',
+    browserProfilesDir: 'browser-profiles',
+  })
 }
 
 test('executeSessionChatTurn syncs updated agent runtime fields onto its thread session', () => {
-  const output = runWithTempDataDir(`
+  const output = runWithTempDataDir<{
+    provider: string | null
+    model: string | null
+    extensions: string[]
+    heartbeatEnabled: boolean | null
+    heartbeatIntervalSec: number | null
+    connectorContext: Record<string, unknown> | null
+  }>(`
     const storageMod = await import('@/lib/server/storage')
     const storage = storageMod.default || storageMod['module.exports'] || storageMod
     const providersMod = await import('@/lib/providers/index')
@@ -126,7 +110,12 @@ test('executeSessionChatTurn syncs updated agent runtime fields onto its thread
 })
 
 test('executeSessionChatTurn keeps tool-only heartbeats off the visible main-thread history and clears stale connector state', () => {
-  const output = runWithTempDataDir(`
+  const output = runWithTempDataDir<{
+    connectorContext: Record<string, unknown> | null
+    messageCount: number
+    lastMessageText: string | null
+    heartbeatKinds: number
+  }>(`
     const storageMod = await import('@/lib/server/storage')
     const providersMod = await import('@/lib/providers/index')
     const execMod = await import('@/lib/server/chat-execution/chat-execution')
@@ -232,7 +221,11 @@ test('executeSessionChatTurn keeps tool-only heartbeats off the visible main-thr
 })
 
 test('executeSessionChatTurn hides internal main-loop followup output from the visible transcript', () => {
-  const output = runWithTempDataDir(`
+  const output = runWithTempDataDir<{
+    messageCount: number
+    lastMessageText: string | null
+    hasStreamingArtifacts: boolean
+  }>(`
     const storageMod = await import('@/lib/server/storage')
     const providersMod = await import('@/lib/providers/index')
     const execMod = await import('@/lib/server/chat-execution/chat-execution')
@@ -324,7 +317,10 @@ test('executeSessionChatTurn hides internal main-loop followup output from the v
 })
 
 test('executeSessionChatTurn forces external connector sessions onto session-scoped memory', () => {
-  const output = runWithTempDataDir(`
+  const output = runWithTempDataDir<{
+    memoryScopeMode: string | null
+    connectorContext: { isOwnerConversation?: boolean } | null
+  }>(`
     const storageMod = await import('@/lib/server/storage')
     const providersMod = await import('@/lib/providers/index')
     const execMod = await import('@/lib/server/chat-execution/chat-execution')
@@ -418,7 +414,10 @@ test('executeSessionChatTurn forces external connector sessions onto session-sco
 })
 
 test('executeSessionChatTurn applies lifecycle hooks for model resolution and message persistence', () => {
-  const output = runWithTempDataDir(`
+  const output = runWithTempDataDir<{
+    lastMessageText: string
+    marks: string[]
+  }>(`
     const storageMod = await import('@/lib/server/storage')
     const providersMod = await import('@/lib/providers/index')
     const extMod = await import('@/lib/server/extensions')

package/src/lib/server/knowledge-sources.test.ts

@@ -213,3 +213,49 @@ test('runKnowledgeHygieneMaintenance reindexes stale file sources and archives e
   assert.ok(output.recentActionKinds.includes('archive'))
   assert.ok(output.recentActionKinds.includes('reindex') || output.recentActionKinds.includes('sync'))
 })
+
+test('runKnowledgeHygieneMaintenance keeps same-content sources separate when visibility differs', () => {
+  const output = runWithTempDataDir<{
+    globalArchived: boolean
+    agentArchived: boolean
+    agent1Hits: number
+    agent2Hits: number
+  }>(`
+    const knowledgeMod = await import('./src/lib/server/knowledge-sources.ts')
+    const knowledge = knowledgeMod.default || knowledgeMod
+
+    const globalSource = await knowledge.createKnowledgeSource({
+      kind: 'manual',
+      title: 'Global Policy',
+      content: 'identical content',
+      scope: 'global',
+    })
+
+    const agentSource = await knowledge.createKnowledgeSource({
+      kind: 'manual',
+      title: 'Scoped Policy',
+      content: 'identical content',
+      scope: 'agent',
+      agentIds: ['agent-1'],
+    })
+
+    await knowledge.runKnowledgeHygieneMaintenance()
+
+    const globalDetail = await knowledge.getKnowledgeSourceDetail(globalSource.source.id)
+    const agentDetail = await knowledge.getKnowledgeSourceDetail(agentSource.source.id)
+    const agent1Hits = await knowledge.searchKnowledgeHits({ query: 'identical', viewerAgentId: 'agent-1' })
+    const agent2Hits = await knowledge.searchKnowledgeHits({ query: 'identical', viewerAgentId: 'agent-2' })
+
+    console.log(JSON.stringify({
+      globalArchived: !!globalDetail?.source?.archivedAt,
+      agentArchived: !!agentDetail?.source?.archivedAt,
+      agent1Hits: agent1Hits.length,
+      agent2Hits: agent2Hits.length,
+    }))
+  `, { prefix: 'swarmclaw-knowledge-visibility-' })
+
+  assert.equal(output.globalArchived, false)
+  assert.equal(output.agentArchived, false)
+  assert.equal(output.agent1Hits, 2)
+  assert.equal(output.agent2Hits, 1)
+})

package/src/lib/server/knowledge-sources.ts

@@ -1056,6 +1056,38 @@ function sameSourceOrigin(left: KnowledgeSource, right: KnowledgeSource): boolea
   return false
 }
 
+function duplicateOriginFingerprint(source: KnowledgeSource): string {
+  if (source.sourceUrl) return `url:${source.sourceUrl}`
+  if (source.sourcePath) return `path:${source.sourcePath}`
+  return `kind:${source.kind}`
+}
+
+function duplicateGroupKey(source: KnowledgeSource): string | null {
+  if (!source.sourceHash) return null
+  const sortedAgentIds = [...source.agentIds].sort()
+  const sortedTags = [...source.tags].map((tag) => tag.toLowerCase()).sort()
+  return [
+    source.sourceHash,
+    source.kind,
+    source.scope,
+    sortedAgentIds.join(','),
+    sortedTags.join(','),
+    duplicateOriginFingerprint(source),
+  ].join('|')
+}
+
+function collectDuplicateGroups(sources: KnowledgeSource[]): Map<string, KnowledgeSource[]> {
+  const duplicateGroups = new Map<string, KnowledgeSource[]>()
+  for (const source of sources) {
+    const groupKey = duplicateGroupKey(source)
+    if (!groupKey) continue
+    const group = duplicateGroups.get(groupKey) || []
+    group.push(source)
+    duplicateGroups.set(groupKey, group)
+  }
+  return duplicateGroups
+}
+
 function canonicalSourceForGroup(group: KnowledgeSource[]): KnowledgeSource {
   return [...group].sort((left, right) => {
     const archiveDelta = Number(sourceIsExcludedByDefault(left)) - Number(sourceIsExcludedByDefault(right))
@@ -1072,14 +1104,7 @@ function buildHygieneSummary(sources: KnowledgeSource[]): KnowledgeHygieneSummar
   const pushFinding = (finding: KnowledgeHygieneFinding) => {
     if (findings.length < MAX_HYGIENE_FINDINGS) findings.push(finding)
   }
-
-  const duplicateGroups = new Map<string, KnowledgeSource[]>()
-  for (const source of sources) {
-    if (!source.sourceHash) continue
-    const group = duplicateGroups.get(source.sourceHash) || []
-    group.push(source)
-    duplicateGroups.set(source.sourceHash, group)
-  }
+  const duplicateGroups = collectDuplicateGroups(sources)
 
   for (const source of sources) {
     if (sourceIsArchived(source)) {
@@ -1185,14 +1210,7 @@ export async function getKnowledgeHygieneSummary(): Promise<KnowledgeHygieneSumm
 export async function runKnowledgeHygieneMaintenance(): Promise<KnowledgeHygieneSummary> {
   await ensureLegacyKnowledgeBackfill()
   const sources = listStoredSources()
-
-  const duplicateGroups = new Map<string, KnowledgeSource[]>()
-  for (const source of sources) {
-    if (!source.sourceHash) continue
-    const group = duplicateGroups.get(source.sourceHash) || []
-    group.push(source)
-    duplicateGroups.set(source.sourceHash, group)
-  }
+  const duplicateGroups = collectDuplicateGroups(sources)
 
   for (const source of sources) {
     if (sourceIsExcludedByDefault(source)) continue

package/src/lib/server/test-utils/run-with-temp-data-dir.ts

@@ -10,19 +10,32 @@ export function runWithTempDataDir<T = unknown>(
   script: string,
   options: {
     prefix?: string
+    dataDir?: string
+    workspaceDir?: string
+    browserProfilesDir?: string
   } = {},
 ): T {
   const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), options.prefix || 'swarmclaw-test-'))
-  const workspaceDir = path.join(tempDir, 'workspace')
+  const resolveTempPath = (value: string | undefined, fallback: string): string =>
+    path.isAbsolute(value || '') ? String(value) : path.join(tempDir, value || fallback)
+  const dataDir = resolveTempPath(options.dataDir, '')
+  const workspaceDir = resolveTempPath(options.workspaceDir, 'workspace')
+  const browserProfilesDir = options.browserProfilesDir
+    ? resolveTempPath(options.browserProfilesDir, 'browser-profiles')
+    : null
+
+  fs.mkdirSync(dataDir, { recursive: true })
   fs.mkdirSync(workspaceDir, { recursive: true })
+  if (browserProfilesDir) fs.mkdirSync(browserProfilesDir, { recursive: true })
 
   try {
     const result = spawnSync(process.execPath, ['--import', 'tsx', '--input-type=module', '--eval', script], {
       cwd: repoRoot,
       env: {
         ...process.env,
-        DATA_DIR: tempDir,
+        DATA_DIR: dataDir,
         WORKSPACE_DIR: workspaceDir,
+        ...(browserProfilesDir ? { BROWSER_PROFILES_DIR: browserProfilesDir } : {}),
       },
       encoding: 'utf-8',
     })