@swarmclawai/swarmclaw 0.8.4 → 0.8.7

package/src/app/api/tasks/route.ts

@@ -1,21 +1,22 @@
 import { NextResponse } from 'next/server'
 import { genId } from '@/lib/id'
+import { perf } from '@/lib/server/perf'
 import { deleteTask, loadAgents, loadSettings, loadTasks, logActivity, upsertTask } from '@/lib/server/storage'
 import { TaskCreateSchema, formatZodError } from '@/lib/validation/schemas'
 import { z } from 'zod'
 import { enqueueTask, recoverStalledRunningTasks, validateCompletedTasksQueue } from '@/lib/server/queue'
-import { ensureTaskCompletionReport } from '@/lib/server/task-reports'
-import { formatValidationFailure, validateTaskCompletion } from '@/lib/server/task-validation'
 import { pushMainLoopEventToMainSessions } from '@/lib/server/main-agent-loop'
 import { notify } from '@/lib/server/ws-hub'
-import { computeTaskFingerprint, findDuplicateTask } from '@/lib/task-dedupe'
 import { resolveTaskAgentFromDescription } from '@/lib/server/task-mention'
 import { validateDag } from '@/lib/server/dag-validation'
 import { getPluginManager } from '@/lib/server/plugins'
-import { normalizeTaskQualityGate } from '@/lib/server/task-quality-gate'
+import {
+  prepareTaskCreation,
+} from '@/lib/server/task-service'
 import '@/lib/server/builtin-plugins'
 
 export async function GET(req: Request) {
+  const endPerf = perf.start('api', 'GET /api/tasks')
   // Keep completed queue integrity even if daemon is not running.
   validateCompletedTasksQueue()
   recoverStalledRunningTasks()
@@ -25,6 +26,7 @@ export async function GET(req: Request) {
   const allTasks = loadTasks()
 
   if (includeArchived) {
+    endPerf({ count: Object.keys(allTasks).length })
     return NextResponse.json(allTasks)
   }
 
@@ -35,6 +37,7 @@ export async function GET(req: Request) {
       filtered[id] = task
     }
   }
+  endPerf({ count: Object.keys(filtered).length })
   return NextResponse.json(filtered)
 }
 
@@ -71,9 +74,6 @@ export async function POST(req: Request) {
   const now = Date.now()
   const tasks = loadTasks()
   const settings = loadSettings()
-  const normalizedQualityGate = body.qualityGate
-    ? normalizeTaskQualityGate(body.qualityGate, settings)
-    : null
   const maxAttempts = Number.isFinite(Number(body.maxAttempts))
     ? Math.max(1, Math.min(20, Math.trunc(Number(body.maxAttempts))))
     : Math.max(1, Math.min(20, Math.trunc(Number(settings.defaultTaskMaxAttempts ?? 3))))
@@ -96,101 +96,89 @@ export async function POST(req: Request) {
     ? resolveTaskAgentFromDescription(body.description, body.agentId || '', loadAgents())
     : (body.agentId || '')
 
-  tasks[id] = {
+  const prepared = prepareTaskCreation({
     id,
-    title: body.title || 'Untitled Task',
-    description: body.description || '',
-    status: body.status || 'backlog',
-    agentId: resolvedAgentId,
-    projectId: typeof body.projectId === 'string' && body.projectId ? body.projectId : null,
-    goalContract: body.goalContract || null,
-    cwd: typeof body.cwd === 'string' ? body.cwd : null,
-    file: typeof body.file === 'string' ? body.file : null,
-    sessionId: typeof body.sessionId === 'string' ? body.sessionId : null,
-    result: typeof body.result === 'string' ? body.result : null,
-    error: typeof body.error === 'string' ? body.error : null,
-    outputFiles: Array.isArray(body.outputFiles)
-      ? body.outputFiles.filter((entry: unknown) => typeof entry === 'string').slice(0, 24)
-      : [],
-    artifacts: Array.isArray(body.artifacts)
-      ? body.artifacts
-          .filter((artifact: unknown) => artifact && typeof artifact === 'object')
-          .map((artifact: unknown) => {
-            const row = artifact as {
-              url?: unknown
-              type?: unknown
-              filename?: unknown
-            }
-            const normalizedType = String(row.type || '')
-            return {
-              url: String(row.url || ''),
-              type: ['image', 'video', 'pdf', 'file'].includes(normalizedType)
-                ? (normalizedType as 'image' | 'video' | 'pdf' | 'file')
-                : 'file',
-              filename: String(row.filename || ''),
-            }
-          })
-          .filter((artifact: { url: string; filename: string }) => artifact.url && artifact.filename)
-          .slice(0, 24)
-      : [],
-    createdAt: now,
-    updatedAt: now,
-    queuedAt: null,
-    startedAt: null,
-    completedAt: null,
-    archivedAt: null,
-    attempts: 0,
-    maxAttempts,
-    retryBackoffSec,
-    retryScheduledAt: null,
-    deadLetteredAt: null,
-    checkpoint: null,
-    blockedBy: Array.isArray(body.blockedBy) ? body.blockedBy.filter((s: unknown) => typeof s === 'string') : [],
-    blocks: Array.isArray(body.blocks) ? body.blocks.filter((s: unknown) => typeof s === 'string') : [],
-    tags: Array.isArray(body.tags) ? body.tags.filter((s: unknown) => typeof s === 'string') : [],
-    dueAt: typeof body.dueAt === 'number' ? body.dueAt : null,
-    customFields: body.customFields && typeof body.customFields === 'object' ? body.customFields : undefined,
-    priority: ['low', 'medium', 'high', 'critical'].includes(body.priority) ? body.priority : undefined,
-    fingerprint: computeTaskFingerprint(body.title || 'Untitled Task', body.agentId || ''),
-    qualityGate: normalizedQualityGate,
+    input: {
+      ...body,
+      agentId: resolvedAgentId,
+    },
+    tasks,
+    now,
+    settings,
+    seed: {
+      projectId: typeof body.projectId === 'string' && body.projectId ? body.projectId : null,
+      goalContract: body.goalContract || null,
+      cwd: typeof body.cwd === 'string' ? body.cwd : null,
+      file: typeof body.file === 'string' ? body.file : null,
+      sessionId: typeof body.sessionId === 'string' ? body.sessionId : null,
+      result: typeof body.result === 'string' ? body.result : null,
+      error: typeof body.error === 'string' ? body.error : null,
+      outputFiles: Array.isArray(body.outputFiles)
+        ? body.outputFiles.filter((entry: unknown) => typeof entry === 'string').slice(0, 24)
+        : [],
+      artifacts: Array.isArray(body.artifacts)
+        ? body.artifacts
+            .filter((artifact: unknown) => artifact && typeof artifact === 'object')
+            .map((artifact: unknown) => {
+              const row = artifact as {
+                url?: unknown
+                type?: unknown
+                filename?: unknown
+              }
+              const normalizedType = String(row.type || '')
+              return {
+                url: String(row.url || ''),
+                type: ['image', 'video', 'pdf', 'file'].includes(normalizedType)
+                  ? (normalizedType as 'image' | 'video' | 'pdf' | 'file')
+                  : 'file',
+                filename: String(row.filename || ''),
+              }
+            })
+            .filter((artifact: { url: string; filename: string }) => artifact.url && artifact.filename)
+            .slice(0, 24)
+        : [],
+      archivedAt: null,
+      attempts: 0,
+      maxAttempts,
+      retryBackoffSec,
+      retryScheduledAt: null,
+      deadLetteredAt: null,
+      checkpoint: null,
+      blockedBy: Array.isArray(body.blockedBy) ? body.blockedBy.filter((s: unknown) => typeof s === 'string') : [],
+      blocks: Array.isArray(body.blocks) ? body.blocks.filter((s: unknown) => typeof s === 'string') : [],
+      tags: Array.isArray(body.tags) ? body.tags.filter((s: unknown) => typeof s === 'string') : [],
+      dueAt: typeof body.dueAt === 'number' ? body.dueAt : null,
+      customFields: body.customFields && typeof body.customFields === 'object' ? body.customFields : undefined,
+      priority: ['low', 'medium', 'high', 'critical'].includes(body.priority) ? body.priority : undefined,
+    },
+  })
+  if (!prepared.ok) {
+    return NextResponse.json({ error: prepared.error }, { status: 400 })
   }
 
-  // Dedup: if a non-terminal task with same fingerprint exists, return it
-  const dupe = findDuplicateTask(tasks, { fingerprint: tasks[id].fingerprint! })
-  if (dupe && dupe.id !== id) {
-    return NextResponse.json({ ...dupe, deduplicated: true })
+  if (prepared.duplicate) {
+    return NextResponse.json({ ...prepared.duplicate, deduplicated: true })
   }
 
-  if (tasks[id].status === 'completed') {
-    const report = ensureTaskCompletionReport(tasks[id])
-    if (report?.relativePath) tasks[id].completionReportPath = report.relativePath
-    const validation = validateTaskCompletion(tasks[id], { report, settings })
-    tasks[id].validation = validation
-    if (validation.ok) {
-      tasks[id].completedAt = Date.now()
-      tasks[id].error = null
-      const agentPlugins = resolvedAgentId ? (loadAgents()[resolvedAgentId]?.plugins || []) : []
-      getPluginManager().runHook(
-        'onTaskComplete',
-        { taskId: id, result: tasks[id].result },
-        { enabledIds: agentPlugins },
-      )
-    } else {
-      tasks[id].status = 'failed'
-      tasks[id].completedAt = null
-      tasks[id].error = formatValidationFailure(validation.reasons).slice(0, 500)
-    }
+  const task = prepared.task
+  if (task.status === 'completed') {
+    const agentPlugins = resolvedAgentId ? (loadAgents()[resolvedAgentId]?.plugins || []) : []
+    getPluginManager().runHook(
+      'onTaskComplete',
+      { taskId: id, result: task.result },
+      { enabledIds: agentPlugins },
+    )
   }
 
-  upsertTask(id, tasks[id])
-  logActivity({ entityType: 'task', entityId: id, action: 'created', actor: 'user', summary: `Task created: "${tasks[id].title}"` })
+  upsertTask(id, task)
+  logActivity({ entityType: 'task', entityId: id, action: 'created', actor: 'user', summary: `Task created: "${task.title}"` })
   pushMainLoopEventToMainSessions({
     type: 'task_created',
-    text: `Task created: "${tasks[id].title}" (${id}) with status ${tasks[id].status}.`,
+    text: `Task created: "${task.title}" (${id}) with status ${task.status}.`,
   })
-  if (tasks[id].status === 'queued') {
+  if (task.status === 'queued') {
     enqueueTask(id)
   }
   notify('tasks')
-  return NextResponse.json(tasks[id])
+  return NextResponse.json(task)
 }

package/src/app/api/wallets/[id]/approve/route.ts

@@ -4,6 +4,7 @@ import { notify } from '@/lib/server/ws-hub'
 import type { AgentWallet, WalletTransaction } from '@/types'
 import { getWalletAtomicAmount } from '@/lib/wallet'
 import { sendWalletNativeAsset, validateWalletSendLimits } from '@/lib/server/wallet-service'
+import { errorMessage } from '@/lib/shared-utils'
 export const dynamic = 'force-dynamic'
 
 export async function POST(req: Request, { params }: { params: Promise<{ id: string }> }) {
@@ -68,7 +69,7 @@ export async function POST(req: Request, { params }: { params: Promise<{ id: str
     upsertWalletTransaction(transactionId, tx)
     notify('wallets')
     return NextResponse.json({
-      error: err instanceof Error ? err.message : String(err),
+      error: errorMessage(err),
       transactionId,
       status: 'failed',
     }, { status: 500 })

package/src/app/api/wallets/[id]/route.ts

@@ -1,5 +1,5 @@
 import { NextResponse } from 'next/server'
-import { loadWallets, upsertWallet, deleteWallet as deleteWalletFromStore, loadAgents, saveAgents } from '@/lib/server/storage'
+import { loadWallets, upsertWallet, deleteWallet as deleteWalletFromStore, loadAgent, loadAgents, upsertAgent } from '@/lib/server/storage'
 import { notify } from '@/lib/server/ws-hub'
 import { getWalletLimitAtomic, normalizeAtomicString } from '@/lib/wallet'
 import type { AgentWallet, WalletAssetBalance, WalletPortfolioSummary } from '@/types'
@@ -89,8 +89,7 @@ export async function PATCH(req: Request, { params }: { params: Promise<{ id: st
 
   // Reassign wallet to a different agent
   if (typeof body.agentId === 'string' && body.agentId !== wallet.agentId) {
-    const agents = loadAgents()
-    const newAgent = agents[body.agentId]
+    const newAgent = loadAgent(body.agentId)
     if (!newAgent) return NextResponse.json({ error: 'Agent not found' }, { status: 404 })
 
     // Only one wallet per chain per agent.
@@ -98,28 +97,25 @@ export async function PATCH(req: Request, { params }: { params: Promise<{ id: st
     const conflict = Object.values(allWallets).find((w) => w.agentId === body.agentId && w.id !== id && w.chain === wallet.chain)
     if (conflict) return NextResponse.json({ error: `Target agent already has a ${wallet.chain} wallet` }, { status: 409 })
 
-    const oldAgent = agents[wallet.agentId]
+    const oldAgent = loadAgent(wallet.agentId)
     if (oldAgent) {
-      unlinkWalletFromAgent(oldAgent, id)
+      unlinkWalletFromAgent(oldAgent as any, id)
       oldAgent.updatedAt = Date.now()
-      agents[wallet.agentId] = oldAgent
+      upsertAgent(wallet.agentId, oldAgent)
     }
 
-    linkWalletToAgent(newAgent, id, shouldMakeActive || getAgentActiveWalletId(newAgent) == null)
+    linkWalletToAgent(newAgent as any, id, shouldMakeActive || getAgentActiveWalletId(newAgent as any) == null)
     newAgent.updatedAt = Date.now()
-    agents[body.agentId] = newAgent
-    saveAgents(agents)
+    upsertAgent(body.agentId, newAgent)
     notify('agents')
 
     wallet.agentId = body.agentId
   } else if (shouldMakeActive) {
-    const agents = loadAgents()
-    const agent = agents[wallet.agentId]
+    const agent = loadAgent(wallet.agentId)
     if (agent) {
-      setAgentActiveWallet(agent, id)
+      setAgentActiveWallet(agent as any, id)
       agent.updatedAt = Date.now()
-      agents[wallet.agentId] = agent
-      saveAgents(agents)
+      upsertAgent(wallet.agentId, agent)
       notify('agents')
     }
   }
@@ -156,13 +152,11 @@ export async function DELETE(_req: Request, { params }: { params: Promise<{ id:
   } catch { /* ignore */ }
 
   // Unlink from agent
-  const agents = loadAgents()
-  const agent = agents[wallet.agentId]
+  const agent = loadAgent(wallet.agentId)
   if (agent) {
-    unlinkWalletFromAgent(agent, id)
+    unlinkWalletFromAgent(agent as any, id)
     agent.updatedAt = Date.now()
-    agents[wallet.agentId] = agent
-    saveAgents(agents)
+    upsertAgent(wallet.agentId, agent)
     notify('agents')
   }
 

package/src/app/api/wallets/[id]/send/route.ts

@@ -7,6 +7,7 @@ import {
   normalizeAtomicString,
 } from '@/lib/wallet'
 import { isValidWalletAddress, sendWalletNativeAsset, validateWalletSendLimits } from '@/lib/server/wallet-service'
+import { errorMessage } from '@/lib/shared-utils'
 export const dynamic = 'force-dynamic'
 
 export async function POST(req: Request, { params }: { params: Promise<{ id: string }> }) {
@@ -96,7 +97,7 @@ export async function POST(req: Request, { params }: { params: Promise<{ id: str
     upsertWalletTransaction(txId, failedTx)
     notify('wallets')
     return NextResponse.json({
-      error: err instanceof Error ? err.message : String(err),
+      error: errorMessage(err),
       transactionId: txId,
       status: 'failed',
     }, { status: 500 })

package/src/app/api/wallets/route.ts

@@ -3,6 +3,7 @@ import { loadAgents, loadWallets } from '@/lib/server/storage'
 import { createAgentWallet, getAgentActiveWalletId, getWalletPortfolioSnapshot, stripWalletPrivateKey } from '@/lib/server/wallet-service'
 import { buildEmptyWalletPortfolio } from '@/lib/server/wallet-portfolio'
 import type { AgentWallet, WalletPortfolioSummary } from '@/types'
+import { errorMessage } from '@/lib/shared-utils'
 export const dynamic = 'force-dynamic'
 const WALLET_LIST_PORTFOLIO_TIMEOUT_MS = 1500
 
@@ -73,7 +74,7 @@ export async function POST(req: Request) {
     })
     return NextResponse.json(stripWalletPrivateKey(wallet as unknown as Record<string, unknown>))
   } catch (err: unknown) {
-    const message = err instanceof Error ? err.message : String(err)
+    const message = errorMessage(err)
     if (message === 'agentId is required') {
       return NextResponse.json({ error: message }, { status: 400 })
     }

package/src/app/api/webhooks/[id]/route.ts

@@ -9,6 +9,7 @@ import { requestHeartbeatNow } from '@/lib/server/heartbeat-wake'
 import { mutateItem, deleteItem, notFound, type CollectionOps } from '@/lib/server/collection-helpers'
 import type { WebhookRetryEntry } from '@/types'
 import { triggerWebhookWatchJobs } from '@/lib/server/watch-jobs'
+import { errorMessage } from '@/lib/shared-utils'
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 const ops: CollectionOps<any> = { load: loadWebhooks, save: saveWebhooks }
@@ -250,7 +251,7 @@ export async function handleWebhookPost(
       runId: run.runId,
     })
   } catch (err: unknown) {
-    const errorMsg = err instanceof Error ? err.message : String(err)
+    const errorMsg = errorMessage(err)
 
     // Enqueue for retry with exponential backoff
     const retryId = genId()

package/src/app/api/webhooks/route.test.ts

@@ -88,12 +88,13 @@ test('handleWebhookPost creates a session, records success history, and triggers
     webhookId,
     {
       enqueueRun(input) {
-        calls.runs.push(input as Record<string, unknown>)
+        calls.runs.push(input as any)
         return {
           runId: 'run-success-smoke',
           position: 0,
           promise: Promise.resolve({} as never),
           abort: () => {},
+          unsubscribe: () => {},
         }
       },
       enqueueEvent(sessionId, text) {
@@ -166,6 +167,7 @@ test('handleWebhookPost ignores filtered events without dispatching or logging d
           position: 0,
           promise: Promise.resolve({} as never),
           abort: () => {},
+          unsubscribe: () => {},
         }
       },
       enqueueEvent() {},