@svgrid/grid 2.7.0 → 3.0.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (264) hide show
  1. package/CHANGELOG.md +116 -88
  2. package/README.md +199 -199
  3. package/dist/FlexRender.svelte +96 -96
  4. package/dist/GridFooter.svelte +181 -181
  5. package/dist/SvAutoComplete.svelte +169 -169
  6. package/dist/SvAvatar.svelte +75 -75
  7. package/dist/SvCalendar.svelte +503 -503
  8. package/dist/SvCarousel.svelte +141 -141
  9. package/dist/SvCheckBox.svelte +102 -102
  10. package/dist/SvCircularProgress.svelte +109 -109
  11. package/dist/SvColorInput.svelte +181 -181
  12. package/dist/SvComboBox.svelte +279 -279
  13. package/dist/SvContextMenu.svelte +116 -116
  14. package/dist/SvCountryInput.svelte +163 -163
  15. package/dist/SvDrawer.svelte +254 -254
  16. package/dist/SvDropDownList.svelte +378 -378
  17. package/dist/SvDurationInput.svelte +126 -126
  18. package/dist/SvField.svelte +293 -293
  19. package/dist/SvForm.svelte +437 -437
  20. package/dist/SvGridCellEditor.svelte +748 -744
  21. package/dist/SvGridChart.svelte +1716 -1716
  22. package/dist/SvGridChartPanel.svelte +485 -485
  23. package/dist/SvGridChartView.svelte +70 -70
  24. package/dist/SvGridDropdown.svelte +728 -728
  25. package/dist/SvGridSelect.svelte +270 -270
  26. package/dist/SvGroupCell.svelte +116 -116
  27. package/dist/SvListBox.svelte +334 -334
  28. package/dist/SvMaskedInput.svelte +122 -122
  29. package/dist/SvMenu.svelte +124 -124
  30. package/dist/SvMenuList.svelte +146 -146
  31. package/dist/SvMultiSelect.svelte +293 -293
  32. package/dist/SvNumberInput.svelte +172 -172
  33. package/dist/SvOtpInput.svelte +158 -158
  34. package/dist/SvPasswordInput.svelte +151 -151
  35. package/dist/SvPhoneInput.svelte +133 -133
  36. package/dist/SvPopover.svelte +197 -197
  37. package/dist/SvProgress.svelte +116 -116
  38. package/dist/SvRadioGroup.svelte +107 -107
  39. package/dist/SvRating.svelte +112 -112
  40. package/dist/SvResult.svelte +73 -73
  41. package/dist/SvRichText.svelte +211 -211
  42. package/dist/SvRowGroupPanel.svelte +170 -170
  43. package/dist/SvScrollArea.svelte +61 -61
  44. package/dist/SvSlider.svelte +203 -203
  45. package/dist/SvSwitchButton.svelte +108 -108
  46. package/dist/SvTagsInput.svelte +115 -115
  47. package/dist/SvTextInput.svelte +147 -147
  48. package/dist/SvTimePicker.svelte +245 -245
  49. package/dist/SvToaster.svelte +159 -159
  50. package/dist/SvToggleButton.svelte +85 -85
  51. package/dist/SvTooltip.svelte +161 -161
  52. package/dist/SvTour.svelte +208 -208
  53. package/dist/SvTree.svelte +444 -444
  54. package/dist/SvTreeSelect.svelte +239 -239
  55. package/dist/cdn/{GridMenus-C4oLsJyj.js → GridMenus-CYzOvmNQ.js} +3 -3
  56. package/dist/cdn/{GridMenus-yEivjNwl.js → GridMenus-DFB6iwF8.js} +3 -3
  57. package/dist/cdn/{SvDateRangeInput-DflbiP7N.js → SvDateRangeInput-CaOuMs8O.js} +1 -1
  58. package/dist/cdn/{SvDateRangeInput-Bh0A0JkF.js → SvDateRangeInput-DMLKmGEc.js} +1 -1
  59. package/dist/cdn/{SvDateTimePicker-Bivn8dAP.js → SvDateTimePicker-CCbDZNZB.js} +1 -1
  60. package/dist/cdn/{SvDateTimePicker-BWwpfB_o.js → SvDateTimePicker-sonaH0oh.js} +1 -1
  61. package/dist/cdn/{SvGridCellEditor-Ba7rY3eu.js → SvGridCellEditor-BWnTi2N7.js} +2 -2
  62. package/dist/cdn/{SvGridCellEditor-AXL8cHGO.js → SvGridCellEditor-CjEJMJKc.js} +2 -2
  63. package/dist/cdn/{SvGridChart-CwhFz7GV.js → SvGridChart-BEJmNNx9.js} +1 -1
  64. package/dist/cdn/{SvGridChart-Bs2GIR2Q.js → SvGridChart-BwVos976.js} +1 -1
  65. package/dist/cdn/{SvGridChartPanel-1WXuStzM.js → SvGridChartPanel-BOknOkrP.js} +1 -1
  66. package/dist/cdn/{SvGridChartPanel-e5_nqNP9.js → SvGridChartPanel-D2PjII4O.js} +1 -1
  67. package/dist/cdn/{SvGridChartView-SmPW10dI.js → SvGridChartView-00LPUHL1.js} +1 -1
  68. package/dist/cdn/{SvGridChartView-eSPuJE6g.js → SvGridChartView-BhUEJ5ki.js} +1 -1
  69. package/dist/cdn/{SvGridDropdown-B1ZcLpgs.js → SvGridDropdown-D0VdjeR8.js} +1 -1
  70. package/dist/cdn/{SvGridDropdown-CtdbHcIS.js → SvGridDropdown-D13MtJ2j.js} +1 -1
  71. package/dist/cdn/{date-format-DZT7T1wf.js → date-format-BNii4zeD.js} +2 -2
  72. package/dist/cdn/{date-format-CcP1tafP.js → date-format-BnnHlqGw.js} +2 -2
  73. package/dist/cdn/{row-drag-touch-Ddaa-QeB.js → row-drag-touch-CycRR65n.js} +12 -10
  74. package/dist/cdn/{src-COC0vnpg.js → src-C8QjSaq-.js} +53 -55
  75. package/dist/cdn/{src-pYGV2rMR.js → src-D0hO2eYN.js} +52 -54
  76. package/dist/cdn/svgrid.js +7 -7
  77. package/dist/cdn/svgrid.svelte-external.js +7 -7
  78. package/dist/chart-export.js +8 -8
  79. package/dist/editing.js +22 -13
  80. package/dist/row-drag-touch.d.ts +5 -1
  81. package/dist/row-drag-touch.js +15 -4
  82. package/dist/row-drag.js +7 -3
  83. package/package.json +11 -11
  84. package/src/FlexRender.svelte +96 -96
  85. package/src/GridFooter.svelte +181 -181
  86. package/src/SvAutoComplete.svelte +169 -169
  87. package/src/SvAvatar.svelte +75 -75
  88. package/src/SvCalendar.svelte +503 -503
  89. package/src/SvCalendar.test.ts +226 -226
  90. package/src/SvCarousel.svelte +141 -141
  91. package/src/SvCheckBox.svelte +102 -102
  92. package/src/SvCircularProgress.svelte +109 -109
  93. package/src/SvColorInput.svelte +181 -181
  94. package/src/SvComboBox.svelte +279 -279
  95. package/src/SvContextMenu.svelte +116 -116
  96. package/src/SvCountryInput.svelte +163 -163
  97. package/src/SvDrawer.svelte +254 -254
  98. package/src/SvDropDownList.svelte +378 -378
  99. package/src/SvDurationInput.svelte +126 -126
  100. package/src/SvField.svelte +293 -293
  101. package/src/SvForm.svelte +437 -437
  102. package/src/SvForm.test.ts +411 -411
  103. package/src/SvGrid.types.ts +2092 -2092
  104. package/src/SvGridCellEditor.svelte +748 -744
  105. package/src/SvGridChart.svelte +1716 -1716
  106. package/src/SvGridChartPanel.svelte +485 -485
  107. package/src/SvGridChartView.svelte +70 -70
  108. package/src/SvGridDropdown.svelte +728 -728
  109. package/src/SvGridSelect.svelte +270 -270
  110. package/src/SvGroupCell.svelte +116 -116
  111. package/src/SvListBox.svelte +334 -334
  112. package/src/SvMaskedInput.svelte +122 -122
  113. package/src/SvMenu.svelte +124 -124
  114. package/src/SvMenu.test.ts +97 -97
  115. package/src/SvMenuList.svelte +146 -146
  116. package/src/SvMultiSelect.svelte +293 -293
  117. package/src/SvNumberInput.svelte +172 -172
  118. package/src/SvOtpInput.svelte +158 -158
  119. package/src/SvPasswordInput.svelte +151 -151
  120. package/src/SvPhoneInput.svelte +133 -133
  121. package/src/SvPopover.svelte +197 -197
  122. package/src/SvProgress.svelte +116 -116
  123. package/src/SvRadioGroup.svelte +107 -107
  124. package/src/SvRating.svelte +112 -112
  125. package/src/SvResult.svelte +73 -73
  126. package/src/SvRichText.svelte +211 -211
  127. package/src/SvRowGroupPanel.svelte +170 -170
  128. package/src/SvScrollArea.svelte +61 -61
  129. package/src/SvSlider.svelte +203 -203
  130. package/src/SvSwitchButton.svelte +108 -108
  131. package/src/SvTagsInput.svelte +115 -115
  132. package/src/SvTextInput.svelte +147 -147
  133. package/src/SvTimePicker.svelte +245 -245
  134. package/src/SvToaster.svelte +159 -159
  135. package/src/SvToaster.test.ts +95 -95
  136. package/src/SvToggleButton.svelte +85 -85
  137. package/src/SvTooltip.svelte +161 -161
  138. package/src/SvTour.svelte +208 -208
  139. package/src/SvTree.svelte +444 -444
  140. package/src/SvTreeSelect.svelte +239 -239
  141. package/src/a11y/dismissable.test.ts +119 -119
  142. package/src/a11y/dismissable.ts +114 -114
  143. package/src/a11y.contract.test.ts +49 -49
  144. package/src/a11y.test.ts +59 -59
  145. package/src/a11y.ts +61 -61
  146. package/src/ai.test.ts +502 -502
  147. package/src/ai.ts +1419 -1419
  148. package/src/build-api.coverage.test.ts +633 -633
  149. package/src/build-api.ts +846 -846
  150. package/src/builtin-editors.grid.test.ts +83 -83
  151. package/src/cell-formatting.ts +171 -171
  152. package/src/cell-render.test.ts +513 -513
  153. package/src/cell-render.ts +496 -496
  154. package/src/cell-values.ts +148 -148
  155. package/src/chart-export.ts +202 -202
  156. package/src/chart-view.svelte.ts +36 -36
  157. package/src/chart.ts +2321 -2321
  158. package/src/collaboration.test.ts +104 -104
  159. package/src/collaboration.ts +167 -167
  160. package/src/column-groups.ts +78 -78
  161. package/src/core.performance.test.ts +30 -30
  162. package/src/core.ts +1865 -1865
  163. package/src/createAutocomplete.svelte.ts +132 -132
  164. package/src/createCombobox.svelte.ts +191 -191
  165. package/src/createCountryInput.svelte.ts +157 -157
  166. package/src/createDropdownList.svelte.ts +168 -168
  167. package/src/createForm.svelte.ts +386 -386
  168. package/src/createGrid.svelte.ts +42 -42
  169. package/src/createGrid.test.ts +10 -10
  170. package/src/createGridState.svelte.ts +17 -17
  171. package/src/createListbox.svelte.ts +250 -250
  172. package/src/createMenu.svelte.ts +224 -224
  173. package/src/createPopoverSelect.svelte.ts +213 -213
  174. package/src/createSlider.svelte.ts +191 -191
  175. package/src/createTooltip.svelte.ts +144 -144
  176. package/src/createTree.svelte.ts +322 -322
  177. package/src/datetime/date-core.ts +206 -206
  178. package/src/datetime/date-restrict.ts +61 -61
  179. package/src/datetime/timezone.ts +135 -135
  180. package/src/dock-manager-model.ts +596 -596
  181. package/src/dock-model.ts +374 -374
  182. package/src/editing.test.ts +974 -974
  183. package/src/editing.ts +618 -609
  184. package/src/editor-contract.ts +171 -171
  185. package/src/editor-registry.grid.test.ts +144 -144
  186. package/src/editor-registry.ts +122 -122
  187. package/src/export-data-api.test.ts +126 -126
  188. package/src/export-format.test.ts +107 -107
  189. package/src/export-format.ts +601 -601
  190. package/src/filter-operators.ts +160 -160
  191. package/src/filtering/excel-filters.ts +325 -325
  192. package/src/flex-render.ts +3 -3
  193. package/src/form-field.ts +127 -127
  194. package/src/group-display.test.ts +167 -167
  195. package/src/group-display.ts +200 -200
  196. package/src/headless.ts +87 -87
  197. package/src/js-scroller.svelte.ts +173 -173
  198. package/src/keyboard-handlers.ts +270 -270
  199. package/src/keyboard.test.ts +59 -59
  200. package/src/keyboard.ts +97 -97
  201. package/src/list-nav.test.ts +49 -49
  202. package/src/list-nav.ts +29 -29
  203. package/src/list-option.test.ts +56 -56
  204. package/src/list-option.ts +179 -179
  205. package/src/menus.ts +597 -597
  206. package/src/merge-objects.ts +48 -48
  207. package/src/overlays.test.ts +90 -90
  208. package/src/positioning.ts +268 -268
  209. package/src/render-component.ts +28 -28
  210. package/src/row-drag-touch.ts +226 -211
  211. package/src/row-drag.test.ts +401 -353
  212. package/src/row-drag.ts +419 -415
  213. package/src/row-resize.test.ts +524 -524
  214. package/src/row-resize.ts +228 -228
  215. package/src/scheduler-ical.ts +181 -181
  216. package/src/scheduler-model.test.ts +562 -562
  217. package/src/scheduler-model.ts +873 -873
  218. package/src/selection.test.ts +885 -885
  219. package/src/server-data-source.test.ts +383 -383
  220. package/src/server-data-source.ts +469 -469
  221. package/src/sparkline.test.ts +68 -68
  222. package/src/sparkline.ts +169 -169
  223. package/src/spreadsheet.test.ts +488 -488
  224. package/src/spreadsheet.ts +312 -312
  225. package/src/static-functions.ts +11 -11
  226. package/src/subscribe.ts +38 -38
  227. package/src/summaries.ts +113 -113
  228. package/src/svgrid-wrapper.types.ts +563 -563
  229. package/src/svgrid.async-editor-options.test.ts +273 -273
  230. package/src/svgrid.auto-row-height.test.ts +204 -204
  231. package/src/svgrid.behavior.test.ts +910 -910
  232. package/src/svgrid.charting.test.ts +534 -534
  233. package/src/svgrid.comments-autocomplete.test.ts +127 -127
  234. package/src/svgrid.context-menu.test.ts +147 -147
  235. package/src/svgrid.features.test.ts +157 -157
  236. package/src/svgrid.filter-depth.test.ts +163 -163
  237. package/src/svgrid.filter-menu-listbox.svelte.test.ts +382 -377
  238. package/src/svgrid.filter-menu-scroll.test.ts +112 -112
  239. package/src/svgrid.grand-total.test.ts +188 -188
  240. package/src/svgrid.group-display-mode.test.ts +171 -171
  241. package/src/svgrid.group-footers.test.ts +121 -121
  242. package/src/svgrid.group-pagination.test.ts +153 -153
  243. package/src/svgrid.new-features.wrapper.test.ts +251 -251
  244. package/src/svgrid.tree-data.test.ts +186 -186
  245. package/src/svgrid.wrapper.test.ts +63 -63
  246. package/src/svgriddropdown.async-panel.svelte.test.ts +195 -195
  247. package/src/test-setup.ts +62 -62
  248. package/src/themes/index.ts +288 -288
  249. package/src/toast-store.svelte.ts +250 -250
  250. package/src/toast-store.test.ts +147 -147
  251. package/src/tree-row-model.test.ts +168 -168
  252. package/src/ui-buttons.test.ts +144 -144
  253. package/src/ui-inputs.test.ts +118 -118
  254. package/src/ui-localization.test.ts +113 -113
  255. package/src/ui-range.test.ts +70 -70
  256. package/src/ui-selection.test.ts +155 -155
  257. package/src/ui-tier1.test.ts +142 -142
  258. package/src/virtual.test.ts +88 -88
  259. package/src/virtualization/column-virtualizer.test.ts +27 -27
  260. package/src/virtualization/column-virtualizer.ts +30 -30
  261. package/src/virtualization/svelte-virtualizer.svelte.ts +26 -26
  262. package/src/virtualization/types.ts +30 -30
  263. package/src/virtualization/virtualizer.test.ts +47 -47
  264. package/src/virtualization/virtualizer.ts +322 -322
@@ -1,353 +1,401 @@
1
- /**
2
- * Unit tests for the managed row-drag handlers produced by createRowDrag(ctx).
3
- *
4
- * createRowDrag is a factory closing over a mutable `ctx` handle and a
5
- * module-level singleton "bus" that carries the dragged row between grids.
6
- * Because the bus is shared, we can create TWO fake ctxs (two grids) and drive
7
- * a genuine grid-to-grid move without mounting anything.
8
- */
9
- import { afterEach, describe, expect, it, vi } from 'vitest'
10
- import { createRowDrag, rowDropZone } from './row-drag'
11
-
12
- type AnyCtx = Record<string, any>
13
- type Task = { id: number; title: string }
14
-
15
- function makeCtx(rows: Task[], props: AnyCtx = {}): AnyCtx {
16
- return {
17
- props,
18
- internalData: rows,
19
- get allRows() {
20
- // allRows tracks internalData order; each Row wraps `.original`.
21
- return (this.internalData as Task[]).map((r) => ({ original: r }))
22
- },
23
- rowDragActive: false,
24
- rowDropIndex: null,
25
- rowDropSide: null,
26
- }
27
- }
28
-
29
- function fakeEvent(clientY = 0, rectTop = 0, rectHeight = 40): any {
30
- return {
31
- clientY,
32
- preventDefault: vi.fn(),
33
- stopPropagation: vi.fn(),
34
- dataTransfer: { setData: vi.fn(), effectAllowed: '', dropEffect: '' },
35
- currentTarget: {
36
- getBoundingClientRect: () => ({ top: rectTop, height: rectHeight, bottom: rectTop + rectHeight, left: 0 }),
37
- },
38
- }
39
- }
40
-
41
- const P = { rowDragManaged: true }
42
-
43
- describe('createRowDrag - same-grid reorder', () => {
44
- it('moves a dragged row after the drop target', () => {
45
- const rows: Task[] = [
46
- { id: 1, title: 'a' },
47
- { id: 2, title: 'b' },
48
- { id: 3, title: 'c' },
49
- { id: 4, title: 'd' },
50
- ]
51
- const ctx = makeCtx(rows, { ...P })
52
- const h = createRowDrag(ctx)
53
-
54
- h.onRowDragStart(fakeEvent(), 0) // drag "a"
55
- ctx.rowDropSide = 'after'
56
- h.onRowDrop(fakeEvent(), 2) // drop after "c"
57
-
58
- expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['b', 'c', 'a', 'd'])
59
- })
60
-
61
- it('drops before the target when the side is "before"', () => {
62
- const rows: Task[] = [
63
- { id: 1, title: 'a' },
64
- { id: 2, title: 'b' },
65
- { id: 3, title: 'c' },
66
- ]
67
- const ctx = makeCtx(rows, { ...P })
68
- const h = createRowDrag(ctx)
69
- h.onRowDragStart(fakeEvent(), 2) // drag "c"
70
- ctx.rowDropSide = 'before'
71
- h.onRowDrop(fakeEvent(), 0) // before "a"
72
- expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['c', 'a', 'b'])
73
- })
74
- })
75
-
76
- describe('createRowDrag - grid-to-grid', () => {
77
- it('moves a row from source into target when groups match', () => {
78
- const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
79
- const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'g', onRowDragEnd: vi.fn() })
80
- const ha = createRowDrag(a)
81
- const hb = createRowDrag(b)
82
-
83
- ha.onRowDragStart(fakeEvent(), 1) // drag "a2" out of grid A
84
- b.rowDropSide = 'before'
85
- hb.onRowDrop(fakeEvent(), 0) // drop onto grid B before "b1"
86
-
87
- expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a1'])
88
- expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['a2', 'b1'])
89
- expect(b.props.onRowDragEnd).toHaveBeenCalledWith(
90
- expect.objectContaining({ sameGrid: false, toIndex: 0, row: expect.objectContaining({ title: 'a2' }) }),
91
- )
92
- })
93
-
94
- it('does NOT accept a drop when groups differ', () => {
95
- const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
96
- const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'other' })
97
- const ha = createRowDrag(a)
98
- const hb = createRowDrag(b)
99
-
100
- ha.onRowDragStart(fakeEvent(), 0)
101
- const ev = fakeEvent()
102
- hb.onRowDragOver(ev, 0)
103
- expect(ev.preventDefault).not.toHaveBeenCalled() // over rejected
104
- hb.onRowDrop(fakeEvent(), 0)
105
- expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['b1']) // unchanged
106
- expect((a.internalData as Task[]).length).toBe(2) // source untouched
107
- })
108
-
109
- it('appends to the target on an empty-space (container) drop', () => {
110
- const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
111
- const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'g' })
112
- const ha = createRowDrag(a)
113
- const hb = createRowDrag(b)
114
- ha.onRowDragStart(fakeEvent(), 0) // drag "a1"
115
- hb.onRowsContainerDrop(fakeEvent())
116
- expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['b1', 'a1'])
117
- expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a2'])
118
- })
119
- })
120
-
121
- describe('createRowDrag - disabled', () => {
122
- it('is inert when rowDragManaged is off', () => {
123
- const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], {})
124
- const h = createRowDrag(ctx)
125
- h.onRowDragStart(fakeEvent(), 0)
126
- ctx.rowDropSide = 'after'
127
- h.onRowDrop(fakeEvent(), 1)
128
- expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['a', 'b'])
129
- })
130
- })
131
-
132
- describe('rowDropZone (external drop target)', () => {
133
- function dropOn(el: HTMLElement) {
134
- const ev = new Event('drop', { bubbles: true, cancelable: true })
135
- el.dispatchEvent(ev)
136
- }
137
-
138
- it('removes the dragged row from its source grid and calls onDrop', () => {
139
- const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
140
- const ha = createRowDrag(a)
141
- ha.onRowDragStart(fakeEvent(), 0) // start dragging "a1"
142
-
143
- const el = document.createElement('div')
144
- const dropped: any[] = []
145
- const action = rowDropZone(el, { group: 'g', onDrop: (e) => dropped.push(e) })
146
- dropOn(el)
147
-
148
- expect(dropped.length).toBe(1)
149
- expect(dropped[0].row.title).toBe('a1')
150
- expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a2']) // removed from source
151
- action.destroy()
152
- })
153
-
154
- it('ignores drops when the group does not match', () => {
155
- const a = makeCtx([{ id: 1, title: 'a1' }], { ...P, rowDragGroup: 'g' })
156
- const ha = createRowDrag(a)
157
- ha.onRowDragStart(fakeEvent(), 0)
158
-
159
- const el = document.createElement('div')
160
- const dropped: any[] = []
161
- const action = rowDropZone(el, { group: 'other', onDrop: (e) => dropped.push(e) })
162
- dropOn(el)
163
-
164
- expect(dropped.length).toBe(0)
165
- expect((a.internalData as Task[]).length).toBe(1) // untouched
166
- action.destroy()
167
- })
168
- })
169
-
170
- /**
171
- * #69 - the drop indicator vanished mid-drag under row virtualization.
172
- *
173
- * Scrolling to the viewport edge unmounts the row the pointer is over, which
174
- * fires that row's `dragleave`. The replacement row does not fire `dragover`
175
- * until the next frame, so a synchronous clear left the user with no indicator
176
- * and no drop target until they moved the pointer.
177
- */
178
- describe('createRowDrag - drop indicator during virtualized scroll (#69)', () => {
179
- const nextFrame = () => new Promise((r) => requestAnimationFrame(() => r(null)))
180
-
181
- it('keeps the indicator when the hovered row unmounts and another takes over', async () => {
182
- const rows: Task[] = [
183
- { id: 1, title: 'a' },
184
- { id: 2, title: 'b' },
185
- { id: 3, title: 'c' },
186
- ]
187
- const ctx = makeCtx(rows, P)
188
- const d = createRowDrag(ctx)
189
-
190
- d.onRowDragStart(fakeEvent(), 0)
191
- d.onRowDragOver(fakeEvent(30, 0, 40), 1)
192
- expect(ctx.rowDropIndex).toBe(1)
193
-
194
- // Virtualization unmounts row 1 from under the pointer, firing its leave.
195
- d.onRowDragLeave(1)
196
-
197
- // THIS is the bug: the replacement row has not fired `dragover` yet, and a
198
- // synchronous clear leaves the user with no indicator and no drop target in
199
- // the meantime. The indicator must survive the gap.
200
- expect(ctx.rowDropIndex).toBe(1)
201
- expect(ctx.rowDropSide).not.toBeNull()
202
-
203
- // The row scrolled into its place then takes over on the next frame.
204
- d.onRowDragOver(fakeEvent(30, 0, 40), 2)
205
- await nextFrame()
206
- await nextFrame()
207
- expect(ctx.rowDropIndex).toBe(2)
208
- expect(ctx.rowDropSide).not.toBeNull()
209
- })
210
-
211
- it('still clears once the pointer genuinely leaves the rows', async () => {
212
- const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
213
- const d = createRowDrag(ctx)
214
-
215
- d.onRowDragStart(fakeEvent(), 0)
216
- d.onRowDragOver(fakeEvent(30, 0, 40), 1)
217
- expect(ctx.rowDropIndex).toBe(1)
218
-
219
- d.onRowDragLeave(1)
220
- // No dragover follows - the deferral must not turn into a stuck indicator.
221
- await nextFrame()
222
- await nextFrame()
223
- expect(ctx.rowDropIndex).toBeNull()
224
- expect(ctx.rowDropSide).toBeNull()
225
- })
226
-
227
- it('does not write indicator state after the grid is destroyed', async () => {
228
- const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
229
- const d = createRowDrag(ctx)
230
-
231
- d.onRowDragStart(fakeEvent(), 0)
232
- d.onRowDragOver(fakeEvent(30, 0, 40), 1)
233
- d.onRowDragLeave(1)
234
- d.destroyRowDrag()
235
- ctx.rowDropIndex = 'sentinel'
236
-
237
- await nextFrame()
238
- await nextFrame()
239
- // A frame that survived teardown would have nulled this.
240
- expect(ctx.rowDropIndex).toBe('sentinel')
241
- })
242
- })
243
-
244
- /**
245
- * #66 - row drag was dead on touch: the whole feature rode on HTML5 DragEvent,
246
- * which iOS Safari and Android Chrome never fire for touch input.
247
- *
248
- * The pointer path is a second INPUT onto the same model, so these tests drive
249
- * the real handlers and assert on the same `bus` / indicator state the mouse
250
- * path uses, then check the reorder actually happened.
251
- */
252
- describe('createRowDrag - touch (#66)', () => {
253
- const wait = (ms: number) => new Promise((r) => setTimeout(r, ms))
254
-
255
- // `stubRowAt` replaces a global. Without restoring it, every later test in
256
- // the worker inherits a fake elementFromPoint - which showed up as an
257
- // intermittent failure elsewhere in the suite, not here.
258
- const realElementFromPoint = document.elementFromPoint
259
- afterEach(() => {
260
- ;(document as any).elementFromPoint = realElementFromPoint
261
- })
262
-
263
- function pointer(type: string, clientY: number, extra: AnyCtx = {}): any {
264
- return {
265
- pointerId: 1,
266
- pointerType: type,
267
- clientX: 10,
268
- clientY,
269
- preventDefault: vi.fn(),
270
- currentTarget: { setPointerCapture: vi.fn(), closest: () => null },
271
- ...extra,
272
- }
273
- }
274
-
275
- /** Put row `index` under the pointer, the way elementFromPoint would. */
276
- function stubRowAt(index: number, top: number, height = 40) {
277
- const marker = { dataset: { svgridRow: String(index) } }
278
- const tr = {
279
- querySelector: () => marker,
280
- getBoundingClientRect: () => ({ top, height, bottom: top + height }),
281
- }
282
- ;(document as any).elementFromPoint = () => ({ closest: (s: string) => (s === 'tr.sv-grid-row' ? tr : null) })
283
- }
284
-
285
- it('ignores mouse and pen so the HTML5 path keeps owning them', () => {
286
- const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
287
- const d = createRowDrag(ctx)
288
- d.onRowPointerDown(pointer('mouse', 10), 0)
289
- d.onRowPointerDown(pointer('pen', 10), 0)
290
- expect(ctx.rowDragActive).toBe(false)
291
- })
292
-
293
- it('does not start until the long press elapses', async () => {
294
- const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
295
- const d = createRowDrag(ctx)
296
- d.onRowPointerDown(pointer('touch', 10), 0)
297
- expect(ctx.rowDragActive).toBe(false)
298
- await wait(400)
299
- expect(ctx.rowDragActive).toBe(true)
300
- d.destroyRowDrag()
301
- })
302
-
303
- it('treats an early move as a scroll and never starts the drag', async () => {
304
- const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
305
- const d = createRowDrag(ctx)
306
- d.onRowPointerDown(pointer('touch', 10), 0)
307
- window.dispatchEvent(Object.assign(new Event('pointermove'), {
308
- pointerId: 1, clientX: 10, clientY: 60, preventDefault() {},
309
- }))
310
- await wait(400)
311
- expect(ctx.rowDragActive).toBe(false)
312
- d.destroyRowDrag()
313
- })
314
-
315
- it('reorders on lift, through the same commit as the mouse path', async () => {
316
- const rows: Task[] = [
317
- { id: 1, title: 'a' },
318
- { id: 2, title: 'b' },
319
- { id: 3, title: 'c' },
320
- ]
321
- const onRowDragEnd = vi.fn()
322
- const ctx = makeCtx(rows, { ...P, onRowDragEnd })
323
- const d = createRowDrag(ctx)
324
-
325
- d.onRowPointerDown(pointer('touch', 10), 0)
326
- await wait(400)
327
- expect(ctx.rowDragActive).toBe(true)
328
-
329
- // Finger moves over the lower half of row 2.
330
- stubRowAt(2, 80, 40)
331
- window.dispatchEvent(Object.assign(new Event('pointermove'), {
332
- pointerId: 1, clientX: 10, clientY: 115, preventDefault() {},
333
- }))
334
- expect(ctx.rowDropIndex).toBe(2)
335
- expect(ctx.rowDropSide).toBe('after')
336
-
337
- window.dispatchEvent(Object.assign(new Event('pointerup'), { pointerId: 1, clientY: 115 }))
338
- expect((ctx.internalData as Task[]).map((r) => r.id)).toEqual([2, 3, 1])
339
- expect(onRowDragEnd).toHaveBeenCalledTimes(1)
340
- expect(ctx.rowDragActive).toBe(false)
341
- })
342
-
343
- it('cancels without reordering on pointercancel', async () => {
344
- const rows: Task[] = [{ id: 1, title: 'a' }, { id: 2, title: 'b' }]
345
- const ctx = makeCtx(rows, P)
346
- const d = createRowDrag(ctx)
347
- d.onRowPointerDown(pointer('touch', 10), 0)
348
- await wait(400)
349
- window.dispatchEvent(Object.assign(new Event('pointercancel'), { pointerId: 1 }))
350
- expect((ctx.internalData as Task[]).map((r) => r.id)).toEqual([1, 2])
351
- expect(ctx.rowDragActive).toBe(false)
352
- })
353
- })
1
+ /**
2
+ * Unit tests for the managed row-drag handlers produced by createRowDrag(ctx).
3
+ *
4
+ * createRowDrag is a factory closing over a mutable `ctx` handle and a
5
+ * module-level singleton "bus" that carries the dragged row between grids.
6
+ * Because the bus is shared, we can create TWO fake ctxs (two grids) and drive
7
+ * a genuine grid-to-grid move without mounting anything.
8
+ */
9
+ import { afterEach, beforeAll, describe, expect, it, vi } from 'vitest'
10
+ import { createRowDrag, rowDropZone } from './row-drag'
11
+
12
+ type AnyCtx = Record<string, any>
13
+ type Task = { id: number; title: string }
14
+
15
+ function makeCtx(rows: Task[], props: AnyCtx = {}): AnyCtx {
16
+ return {
17
+ props,
18
+ internalData: rows,
19
+ get allRows() {
20
+ // allRows tracks internalData order; each Row wraps `.original`.
21
+ return (this.internalData as Task[]).map((r) => ({ original: r }))
22
+ },
23
+ rowDragActive: false,
24
+ rowDropIndex: null,
25
+ rowDropSide: null,
26
+ }
27
+ }
28
+
29
+ function fakeEvent(clientY = 0, rectTop = 0, rectHeight = 40): any {
30
+ return {
31
+ clientY,
32
+ preventDefault: vi.fn(),
33
+ stopPropagation: vi.fn(),
34
+ dataTransfer: { setData: vi.fn(), effectAllowed: '', dropEffect: '' },
35
+ currentTarget: {
36
+ getBoundingClientRect: () => ({ top: rectTop, height: rectHeight, bottom: rectTop + rectHeight, left: 0 }),
37
+ },
38
+ }
39
+ }
40
+
41
+ const P = { rowDragManaged: true }
42
+
43
+ describe('createRowDrag - same-grid reorder', () => {
44
+ it('moves a dragged row after the drop target', () => {
45
+ const rows: Task[] = [
46
+ { id: 1, title: 'a' },
47
+ { id: 2, title: 'b' },
48
+ { id: 3, title: 'c' },
49
+ { id: 4, title: 'd' },
50
+ ]
51
+ const ctx = makeCtx(rows, { ...P })
52
+ const h = createRowDrag(ctx)
53
+
54
+ h.onRowDragStart(fakeEvent(), 0) // drag "a"
55
+ ctx.rowDropSide = 'after'
56
+ h.onRowDrop(fakeEvent(), 2) // drop after "c"
57
+
58
+ expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['b', 'c', 'a', 'd'])
59
+ })
60
+
61
+ it('drops before the target when the side is "before"', () => {
62
+ const rows: Task[] = [
63
+ { id: 1, title: 'a' },
64
+ { id: 2, title: 'b' },
65
+ { id: 3, title: 'c' },
66
+ ]
67
+ const ctx = makeCtx(rows, { ...P })
68
+ const h = createRowDrag(ctx)
69
+ h.onRowDragStart(fakeEvent(), 2) // drag "c"
70
+ ctx.rowDropSide = 'before'
71
+ h.onRowDrop(fakeEvent(), 0) // before "a"
72
+ expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['c', 'a', 'b'])
73
+ })
74
+ })
75
+
76
+ describe('createRowDrag - grid-to-grid', () => {
77
+ it('moves a row from source into target when groups match', () => {
78
+ const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
79
+ const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'g', onRowDragEnd: vi.fn() })
80
+ const ha = createRowDrag(a)
81
+ const hb = createRowDrag(b)
82
+
83
+ ha.onRowDragStart(fakeEvent(), 1) // drag "a2" out of grid A
84
+ b.rowDropSide = 'before'
85
+ hb.onRowDrop(fakeEvent(), 0) // drop onto grid B before "b1"
86
+
87
+ expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a1'])
88
+ expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['a2', 'b1'])
89
+ expect(b.props.onRowDragEnd).toHaveBeenCalledWith(
90
+ expect.objectContaining({ sameGrid: false, toIndex: 0, row: expect.objectContaining({ title: 'a2' }) }),
91
+ )
92
+ })
93
+
94
+ it('does NOT accept a drop when groups differ', () => {
95
+ const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
96
+ const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'other' })
97
+ const ha = createRowDrag(a)
98
+ const hb = createRowDrag(b)
99
+
100
+ ha.onRowDragStart(fakeEvent(), 0)
101
+ const ev = fakeEvent()
102
+ hb.onRowDragOver(ev, 0)
103
+ expect(ev.preventDefault).not.toHaveBeenCalled() // over rejected
104
+ hb.onRowDrop(fakeEvent(), 0)
105
+ expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['b1']) // unchanged
106
+ expect((a.internalData as Task[]).length).toBe(2) // source untouched
107
+ })
108
+
109
+ it('appends to the target on an empty-space (container) drop', () => {
110
+ const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
111
+ const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'g' })
112
+ const ha = createRowDrag(a)
113
+ const hb = createRowDrag(b)
114
+ ha.onRowDragStart(fakeEvent(), 0) // drag "a1"
115
+ hb.onRowsContainerDrop(fakeEvent())
116
+ expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['b1', 'a1'])
117
+ expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a2'])
118
+ })
119
+ })
120
+
121
+ describe('createRowDrag - disabled', () => {
122
+ it('is inert when rowDragManaged is off', () => {
123
+ const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], {})
124
+ const h = createRowDrag(ctx)
125
+ h.onRowDragStart(fakeEvent(), 0)
126
+ ctx.rowDropSide = 'after'
127
+ h.onRowDrop(fakeEvent(), 1)
128
+ expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['a', 'b'])
129
+ })
130
+ })
131
+
132
+ describe('rowDropZone (external drop target)', () => {
133
+ function dropOn(el: HTMLElement) {
134
+ const ev = new Event('drop', { bubbles: true, cancelable: true })
135
+ el.dispatchEvent(ev)
136
+ }
137
+
138
+ it('removes the dragged row from its source grid and calls onDrop', () => {
139
+ const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
140
+ const ha = createRowDrag(a)
141
+ ha.onRowDragStart(fakeEvent(), 0) // start dragging "a1"
142
+
143
+ const el = document.createElement('div')
144
+ const dropped: any[] = []
145
+ const action = rowDropZone(el, { group: 'g', onDrop: (e) => dropped.push(e) })
146
+ dropOn(el)
147
+
148
+ expect(dropped.length).toBe(1)
149
+ expect(dropped[0].row.title).toBe('a1')
150
+ expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a2']) // removed from source
151
+ action.destroy()
152
+ })
153
+
154
+ it('ignores drops when the group does not match', () => {
155
+ const a = makeCtx([{ id: 1, title: 'a1' }], { ...P, rowDragGroup: 'g' })
156
+ const ha = createRowDrag(a)
157
+ ha.onRowDragStart(fakeEvent(), 0)
158
+
159
+ const el = document.createElement('div')
160
+ const dropped: any[] = []
161
+ const action = rowDropZone(el, { group: 'other', onDrop: (e) => dropped.push(e) })
162
+ dropOn(el)
163
+
164
+ expect(dropped.length).toBe(0)
165
+ expect((a.internalData as Task[]).length).toBe(1) // untouched
166
+ action.destroy()
167
+ })
168
+ })
169
+
170
+ /**
171
+ * #69 - the drop indicator vanished mid-drag under row virtualization.
172
+ *
173
+ * Scrolling to the viewport edge unmounts the row the pointer is over, which
174
+ * fires that row's `dragleave`. The replacement row does not fire `dragover`
175
+ * until the next frame, so a synchronous clear left the user with no indicator
176
+ * and no drop target until they moved the pointer.
177
+ */
178
+ describe('createRowDrag - drop indicator during virtualized scroll (#69)', () => {
179
+ const nextFrame = () => new Promise((r) => requestAnimationFrame(() => r(null)))
180
+
181
+ it('keeps the indicator when the hovered row unmounts and another takes over', async () => {
182
+ const rows: Task[] = [
183
+ { id: 1, title: 'a' },
184
+ { id: 2, title: 'b' },
185
+ { id: 3, title: 'c' },
186
+ ]
187
+ const ctx = makeCtx(rows, P)
188
+ const d = createRowDrag(ctx)
189
+
190
+ d.onRowDragStart(fakeEvent(), 0)
191
+ d.onRowDragOver(fakeEvent(30, 0, 40), 1)
192
+ expect(ctx.rowDropIndex).toBe(1)
193
+
194
+ // Virtualization unmounts row 1 from under the pointer, firing its leave.
195
+ d.onRowDragLeave(1)
196
+
197
+ // THIS is the bug: the replacement row has not fired `dragover` yet, and a
198
+ // synchronous clear leaves the user with no indicator and no drop target in
199
+ // the meantime. The indicator must survive the gap.
200
+ expect(ctx.rowDropIndex).toBe(1)
201
+ expect(ctx.rowDropSide).not.toBeNull()
202
+
203
+ // The row scrolled into its place then takes over on the next frame.
204
+ d.onRowDragOver(fakeEvent(30, 0, 40), 2)
205
+ await nextFrame()
206
+ await nextFrame()
207
+ expect(ctx.rowDropIndex).toBe(2)
208
+ expect(ctx.rowDropSide).not.toBeNull()
209
+ })
210
+
211
+ it('still clears once the pointer genuinely leaves the rows', async () => {
212
+ const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
213
+ const d = createRowDrag(ctx)
214
+
215
+ d.onRowDragStart(fakeEvent(), 0)
216
+ d.onRowDragOver(fakeEvent(30, 0, 40), 1)
217
+ expect(ctx.rowDropIndex).toBe(1)
218
+
219
+ d.onRowDragLeave(1)
220
+ // No dragover follows - the deferral must not turn into a stuck indicator.
221
+ await nextFrame()
222
+ await nextFrame()
223
+ expect(ctx.rowDropIndex).toBeNull()
224
+ expect(ctx.rowDropSide).toBeNull()
225
+ })
226
+
227
+ it('does not write indicator state after the grid is destroyed', async () => {
228
+ const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
229
+ const d = createRowDrag(ctx)
230
+
231
+ d.onRowDragStart(fakeEvent(), 0)
232
+ d.onRowDragOver(fakeEvent(30, 0, 40), 1)
233
+ d.onRowDragLeave(1)
234
+ d.destroyRowDrag()
235
+ ctx.rowDropIndex = 'sentinel'
236
+
237
+ await nextFrame()
238
+ await nextFrame()
239
+ // A frame that survived teardown would have nulled this.
240
+ expect(ctx.rowDropIndex).toBe('sentinel')
241
+ })
242
+ })
243
+
244
+ /**
245
+ * #66 - row drag was dead on touch: the whole feature rode on HTML5 DragEvent,
246
+ * which iOS Safari and Android Chrome never fire for touch input.
247
+ *
248
+ * The pointer path is a second INPUT onto the same model, so these tests drive
249
+ * the real handlers and assert on the same `bus` / indicator state the mouse
250
+ * path uses, then check the reorder actually happened.
251
+ */
252
+ describe('createRowDrag - touch (#66)', () => {
253
+ const wait = (ms: number) => new Promise((r) => setTimeout(r, ms))
254
+
255
+ // `row-drag.ts` fetches the touch module with import() on the first touch,
256
+ // and that fetch is not free: measured at ~190 ms the first time a worker
257
+ // loads it, against the 400 ms budget the tests below allow for a 350 ms
258
+ // press. That left 50 ms of headroom and made this the only flaky suite in
259
+ // the run - green alone, red once the other 200 files were competing for the
260
+ // same worker. Warming the module here means the waits below measure the
261
+ // long press, which is what they are for, instead of racing the loader.
262
+ // The press-clock behaviour that the cold fetch exposed has its own test at
263
+ // the bottom of this block.
264
+ beforeAll(async () => {
265
+ await import('./row-drag-touch')
266
+ })
267
+
268
+ // `stubRowAt` replaces a global. Without restoring it, every later test in
269
+ // the worker inherits a fake elementFromPoint - which showed up as an
270
+ // intermittent failure elsewhere in the suite, not here.
271
+ const realElementFromPoint = document.elementFromPoint
272
+ afterEach(() => {
273
+ ;(document as any).elementFromPoint = realElementFromPoint
274
+ })
275
+
276
+ function pointer(type: string, clientY: number, extra: AnyCtx = {}): any {
277
+ return {
278
+ pointerId: 1,
279
+ pointerType: type,
280
+ clientX: 10,
281
+ clientY,
282
+ preventDefault: vi.fn(),
283
+ currentTarget: { setPointerCapture: vi.fn(), closest: () => null },
284
+ ...extra,
285
+ }
286
+ }
287
+
288
+ /** Put row `index` under the pointer, the way elementFromPoint would. */
289
+ function stubRowAt(index: number, top: number, height = 40) {
290
+ const marker = { dataset: { svgridRow: String(index) } }
291
+ const tr = {
292
+ querySelector: () => marker,
293
+ getBoundingClientRect: () => ({ top, height, bottom: top + height }),
294
+ }
295
+ ;(document as any).elementFromPoint = () => ({ closest: (s: string) => (s === 'tr.sv-grid-row' ? tr : null) })
296
+ }
297
+
298
+ it('ignores mouse and pen so the HTML5 path keeps owning them', () => {
299
+ const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
300
+ const d = createRowDrag(ctx)
301
+ d.onRowPointerDown(pointer('mouse', 10), 0)
302
+ d.onRowPointerDown(pointer('pen', 10), 0)
303
+ expect(ctx.rowDragActive).toBe(false)
304
+ })
305
+
306
+ it('does not start until the long press elapses', async () => {
307
+ const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
308
+ const d = createRowDrag(ctx)
309
+ const pressedAt = performance.now()
310
+ d.onRowPointerDown(pointer('touch', 10), 0)
311
+ expect(ctx.rowDragActive).toBe(false)
312
+ await wait(400)
313
+ expect(ctx.rowDragActive).toBe(true)
314
+ // The name of this test is the assertion: it has to have WAITED. Without
315
+ // this line the test passes just as happily if the press threshold is
316
+ // deleted and the drag starts on contact.
317
+ expect(performance.now() - pressedAt).toBeGreaterThanOrEqual(340)
318
+ d.destroyRowDrag()
319
+ })
320
+
321
+ it('treats an early move as a scroll and never starts the drag', async () => {
322
+ const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
323
+ const d = createRowDrag(ctx)
324
+ d.onRowPointerDown(pointer('touch', 10), 0)
325
+ window.dispatchEvent(Object.assign(new Event('pointermove'), {
326
+ pointerId: 1, clientX: 10, clientY: 60, preventDefault() {},
327
+ }))
328
+ await wait(400)
329
+ expect(ctx.rowDragActive).toBe(false)
330
+ d.destroyRowDrag()
331
+ })
332
+
333
+ it('reorders on lift, through the same commit as the mouse path', async () => {
334
+ const rows: Task[] = [
335
+ { id: 1, title: 'a' },
336
+ { id: 2, title: 'b' },
337
+ { id: 3, title: 'c' },
338
+ ]
339
+ const onRowDragEnd = vi.fn()
340
+ const ctx = makeCtx(rows, { ...P, onRowDragEnd })
341
+ const d = createRowDrag(ctx)
342
+
343
+ d.onRowPointerDown(pointer('touch', 10), 0)
344
+ await wait(400)
345
+ expect(ctx.rowDragActive).toBe(true)
346
+
347
+ // Finger moves over the lower half of row 2.
348
+ stubRowAt(2, 80, 40)
349
+ window.dispatchEvent(Object.assign(new Event('pointermove'), {
350
+ pointerId: 1, clientX: 10, clientY: 115, preventDefault() {},
351
+ }))
352
+ expect(ctx.rowDropIndex).toBe(2)
353
+ expect(ctx.rowDropSide).toBe('after')
354
+
355
+ window.dispatchEvent(Object.assign(new Event('pointerup'), { pointerId: 1, clientY: 115 }))
356
+ expect((ctx.internalData as Task[]).map((r) => r.id)).toEqual([2, 3, 1])
357
+ expect(onRowDragEnd).toHaveBeenCalledTimes(1)
358
+ expect(ctx.rowDragActive).toBe(false)
359
+ })
360
+
361
+ it('cancels without reordering on pointercancel', async () => {
362
+ const rows: Task[] = [{ id: 1, title: 'a' }, { id: 2, title: 'b' }]
363
+ const ctx = makeCtx(rows, P)
364
+ const d = createRowDrag(ctx)
365
+ d.onRowPointerDown(pointer('touch', 10), 0)
366
+ await wait(400)
367
+ window.dispatchEvent(Object.assign(new Event('pointercancel'), { pointerId: 1 }))
368
+ expect((ctx.internalData as Task[]).map((r) => r.id)).toEqual([1, 2])
369
+ expect(ctx.rowDragActive).toBe(false)
370
+ })
371
+
372
+ // The press threshold is counted from the pointerdown, not from the moment
373
+ // the lazily-imported touch module finished loading. Driving createTouchDrag
374
+ // directly is the only way to state that: through createRowDrag the fetch
375
+ // latency is whatever the machine happens to do that run, which is exactly
376
+ // the non-determinism this behaviour exists to cancel out.
377
+ it('counts the long press from the pointerdown, not from when the module loaded', async () => {
378
+ const { createTouchDrag } = await import('./row-drag-touch')
379
+ const rows: Task[] = [{ id: 1, title: 'a' }, { id: 2, title: 'b' }]
380
+ const ctx = makeCtx(rows, P)
381
+ const handle = createTouchDrag({
382
+ ctx,
383
+ managed: () => true,
384
+ originalAt: (i: number) => (ctx.internalData as Task[])[i],
385
+ commitDropOnRow: () => {},
386
+ clearIndicators: () => {},
387
+ cancelPendingLeave: () => {},
388
+ openBus: () => {},
389
+ closeBus: () => {},
390
+ })
391
+
392
+ // 300 ms of the 350 ms press already went on fetching this module, so only
393
+ // ~50 ms of it is left. Before the fix the clock restarted here and the
394
+ // user paid 650 ms for their first drag of the session.
395
+ handle.start(pointer('touch', 10), 0, performance.now() - 300)
396
+ expect(ctx.rowDragActive).toBe(false)
397
+ await wait(150)
398
+ expect(ctx.rowDragActive).toBe(true)
399
+ handle.destroy()
400
+ })
401
+ })