@svgrid/grid 2.6.21 → 2.6.23

package/src/selection.ts

@@ -242,7 +242,23 @@ export function createSelection<
    * that contains the cell are returned (active range checked last so its
    * outline wins on overlap). Returns null when the cell is in no range.
    */
+  /** Could `getSelectionRects()` return anything? An anchored active range or
+   *  a committed one is the only way a rect can exist, and both are plain
+   *  property reads - so this is the cheap guard in front of anything that
+   *  would otherwise allocate a rect array to discover there is nothing. */
+  function hasAnySelectionRect() {
+    const active = ctx.selectionRange as SelectionRange | undefined;
+    const committed = ctx.selectionRanges as SelectionRange[] | undefined;
+    return Boolean(committed?.length) || Boolean(active?.anchor && active?.focus);
+  }
+
   function getCellRangeEdges(rowIndex: number, colIndex: number) {
+    // Bail before `getSelectionRects()`, which allocates an array and resolves
+    // every range. This runs once per rendered CELL on every render - about 250
+    // times per frame on a default grid - and with nothing selected it did all
+    // that work to return null every time.
+    if (!hasAnySelectionRect()) return null;
+
     for (const rect of getSelectionRects()) {
       if (
         rowIndex < rect.minRow ||
@@ -262,10 +278,40 @@ export function createSelection<
     return null;
   }
 
+  /**
+   * The rectangle a drag is currently promising, or null when no drag is in
+   * flight. A fill grows the source rectangle out to the pointer; a move
+   * detaches an identically-sized rectangle and drops it at the offset the
+   * pointer has travelled. Both feed the same preview tint and marquee, so a
+   * range move looks like the fill handle users already know.
+   */
+  function dragPreviewRect() {
+    const m = ctx.moveDrag;
+    if (m) return ctx.moveDestRect(m);
+    const d = ctx.fillDrag;
+    if (!d) return null;
+    return {
+      minRow: Math.min(d.sourceMinRow, d.targetRow),
+      maxRow: Math.max(d.sourceMaxRow, d.targetRow),
+      minCol: Math.min(d.sourceMinCol, d.targetCol),
+      maxCol: Math.max(d.sourceMaxCol, d.targetCol),
+    };
+  }
+
   /** Returns true when the given cell is inside the fill-drag preview
    *  range BUT outside the original source range. Used to paint a
    *  dashed-outline preview while the user is dragging the handle. */
   function isInFillPreview(rowIndex: number, colIndex: number) {
+    if (ctx.moveDrag) {
+      const rect = dragPreviewRect();
+      if (!rect) return false;
+      return (
+        rowIndex >= rect.minRow &&
+        rowIndex <= rect.maxRow &&
+        colIndex >= rect.minCol &&
+        colIndex <= rect.maxCol
+      );
+    }
     const d = ctx.fillDrag;
     if (!d) return false;
     const minR = Math.min(d.sourceMinRow, d.targetRow);
@@ -294,12 +340,12 @@ export function createSelection<
    * border. Returns null when the cell isn't on the rectangle's boundary.
    */
   function fillMarqueeEdges(rowIndex: number, colIndex: number) {
-    const d = ctx.fillDrag;
-    if (!d) return null;
-    const minR = Math.min(d.sourceMinRow, d.targetRow);
-    const maxR = Math.max(d.sourceMaxRow, d.targetRow);
-    const minC = Math.min(d.sourceMinCol, d.targetCol);
-    const maxC = Math.max(d.sourceMaxCol, d.targetCol);
+    // Cheap bail before the shared rect helper, which allocates: this runs
+    // once per rendered cell and no drag is in flight almost all the time.
+    if (!ctx.fillDrag && !ctx.moveDrag) return null;
+    const rect = dragPreviewRect();
+    if (!rect) return null;
+    const { minRow: minR, maxRow: maxR, minCol: minC, maxCol: maxC } = rect;
     if (rowIndex < minR || rowIndex > maxR || colIndex < minC || colIndex > maxC) {
       return null;
     }
@@ -326,6 +372,18 @@ export function createSelection<
     const row = ctx.allRows[rowIndex];
     const column = ctx.allColumns[colIndex];
     if (!row || !column || isGroupRow(row)) return;
+    // A pointerdown on the outer few pixels of a selection border grabs the
+    // range to move it. Checked before anything else, because everything below
+    // would first collapse the selection this drag is about to relocate.
+    // Returns false unless the pointer really was on the strip, so a click
+    // anywhere further inside falls straight through to the old behaviour.
+    if (ctx.startMoveDrag(event, rowIndex, colIndex)) {
+      // A grab that never moves still ends in a `click` on the cell under the
+      // border. Left alone that click would collapse the range the user was
+      // clearly reaching for, and on a checkbox column it would flip the value.
+      moveGrabSwallowsClick = true;
+      return;
+    }
     // NOTE: we no longer bail for checkbox columns. Bailing here meant a
     // range drag could never START on a checkbox cell. A plain click still
     // toggles the checkbox via onCellClick (a same-cell click), while a
@@ -360,27 +418,95 @@ export function createSelection<
     setActiveCell(rowIndex, colIndex);
   }
 
-  function endDragSelection() {
+  /** `event` is the window `pointerup` when this comes from the real gesture,
+   *  and absent when `onWindowPointerMove` calls it to recover from a release
+   *  it never saw. A range move reads its copy modifier from it, so holding
+   *  Ctrl between the last movement and the release still copies. */
+  function endDragSelection(event?: PointerEvent) {
     ctx.isDraggingSelection = false;
+    // Every drag shares one edge-scroll loop, and it exits on its own once no
+    // drag is live - but stopping it here cancels the pending frame rather
+    // than letting one more fire after the gesture is over.
+    ctx.stopEdgeScroll();
     // Also commit a fill-handle drag if one was in progress - the user
     // released the mouse, time to apply the pattern.
     if (ctx.fillDrag) ctx.onFillPointerUp();
+    if (ctx.moveDrag) ctx.onMovePointerUp(event);
   }
 
   function onWindowPointerMove(event: PointerEvent) {
+    if (ctx.moveDrag) {
+      ctx.onMovePointerMove(event);
+      return;
+    }
     if (ctx.fillDrag) {
       ctx.onFillPointerMove(event);
       return;
     }
-    if (!ctx.isDraggingSelection) return;
+    if (!ctx.isDraggingSelection) {
+      updateMoveGrabHover(event);
+      return;
+    }
     // Safety: if no mouse button is held the drag is over (we may have
     // missed pointerup because the user lifted outside the window).
     if (event.buttons === 0) {
       endDragSelection();
+      return;
     }
+    // Drag-select past the viewport edge scrolls the grid, same as the fill
+    // and move drags. Without it a range can only ever cover what was already
+    // on screen when the drag started. `onCellPointerEnter` keeps extending
+    // the range for cells the pointer actually crosses; this covers the case
+    // where the pointer has stopped at the edge and the CELLS are moving.
+    ctx.trackEdgeScroll(event);
   }
 
+  /**
+   * Switch the grid to a move cursor while the pointer sits on the grab strip
+   * of a selection border - without it the feature is invisible, since the
+   * border is painted, not a hit target.
+   *
+   * This runs on every window pointermove, so the order of the guards is the
+   * point: `moveCellsEffective` and the already-hovering flag are plain
+   * property reads, and `isOnMoveGrabStrip` bails on `getCellRangeEdges`
+   * before measuring anything when no range is selected.
+   */
+  function updateMoveGrabHover(event: PointerEvent) {
+    const wasHovering = ctx.moveGrabHover;
+    // Two property reads before anything touches the DOM. `closest()` walks
+    // ancestors on EVERY pointer move over the page, so it has to sit behind
+    // both "the feature is on" and "there is a range to grab".
+    if (!ctx.moveCellsEffective || !hasAnySelectionRect()) {
+      if (wasHovering) ctx.moveGrabHover = false;
+      return;
+    }
+    const target = event.target as HTMLElement | null;
+    const cell = target?.closest?.(
+      "td[data-svgrid-row][data-svgrid-col]",
+    ) as HTMLElement | null;
+    let hovering = false;
+    if (cell) {
+      const r = Number(cell.dataset.svgridRow);
+      const c = Number(cell.dataset.svgridCol);
+      if (Number.isFinite(r) && Number.isFinite(c)) {
+        hovering = ctx.isOnMoveGrabStrip(cell, r, c, event.clientX, event.clientY);
+      }
+    }
+    if (hovering !== wasHovering) ctx.moveGrabHover = hovering;
+  }
+
+  /** Set when a pointerdown started a range move, so the `click` that
+   *  follows a zero-distance grab is discarded instead of collapsing the
+   *  selection it grabbed. One gesture, one flag - cleared on the next click
+   *  whether or not the grab turned into a real drag. */
+  let moveGrabSwallowsClick = false;
+
   function onCellClick(rowIndex: number, colIndex: number) {
+    if (moveGrabSwallowsClick) {
+      moveGrabSwallowsClick = false;
+      ctx.gridRootEl?.focus({ preventScroll: true });
+      return;
+    }
     const row = ctx.allRows[rowIndex];
     const column = ctx.allColumns[colIndex];
     if (!row || !column) return;
@@ -480,6 +606,7 @@ export function createSelection<
     fillMarqueeEdges,
     getSelectionRects,
     isInFillPreview,
+    dragPreviewRect,
     findColumnById,
     onCellPointerDown,
     onCellPointerEnter,

package/src/spreadsheet.ts

@@ -57,7 +57,7 @@ export type SpanColumn<TData = Record<string, unknown>> = {
 /**
  * Turn declarative per-column `colSpan` / `rowSpan` callbacks into a
  * `MergeSpec[]` you can hand to `spreadsheetLayout` - so value-driven,
- * AG-Grid-style spanning runs on the SAME real colspan/rowspan merge engine
+ * Declarative spanning runs on the SAME real colspan/rowspan merge engine
  * instead of a second code path. Recompute after sort/filter (indexes are
  * display-row indexes). A common pattern is "merge runs of equal values":
  *

package/src/svgrid.filter-menu-listbox.svelte.test.ts

@@ -79,8 +79,10 @@ function mountGrid(data: Row[]) {
 }
 
 /** Open the funnel popover on the first column and return the menu element. */
-async function openFilterMenu(target: HTMLElement) {
-  const btn = target.querySelector('.sv-grid-col-filter-btn') as HTMLButtonElement
+async function openFilterMenu(target: HTMLElement, columnIndex = 0) {
+  const btn = target.querySelectorAll('.sv-grid-col-filter-btn')[
+    columnIndex
+  ] as HTMLButtonElement
   btn.click()
   // GridMenus is a lazy chunk, so poll until the popover mounts AND its value
   // checklist has rendered.
@@ -110,8 +112,21 @@ async function openFilterMenu(target: HTMLElement) {
   return target.querySelector('.sv-grid-filter-menu') as HTMLElement
 }
 
+// The LABEL only. The row also carries a trailing match count, which these
+// tests are not about - reading the whole row's text would couple them to it.
+const labelOf = (el: Element) =>
+  (el.querySelector('.sv-listbox__label') ?? el).textContent?.trim() ?? ''
+
 const optionLabels = (menu: HTMLElement) =>
-  Array.from(menu.querySelectorAll('[role="option"]')).map((el) => el.textContent?.trim() ?? '')
+  Array.from(menu.querySelectorAll('[role="option"]')).map(labelOf)
+
+const findOption = (menu: HTMLElement, label: string) => {
+  const hit = Array.from(menu.querySelectorAll('[role="option"]')).find(
+    (el) => labelOf(el) === label,
+  )
+  if (!hit) throw new Error(`no option labelled "${label}" in [${optionLabels(menu)}]`)
+  return hit as HTMLElement
+}
 
 describe('filter menu value checklist', () => {
   it('windows a high-cardinality column instead of mounting every value', async () => {
@@ -252,9 +267,7 @@ describe('filter menu value checklist', () => {
     expect(optionLabels(suggest).length).toBeGreaterThan(1)
 
     // Pick another: the fragment is consumed, not left beside it.
-    const pick = Array.from(suggest.querySelectorAll('[role="option"]')).find(
-      (el) => el.textContent?.trim() === 'SYM00005',
-    ) as HTMLElement
+    const pick = findOption(suggest, 'SYM00005')
     pick.click()
     await tick()
 
@@ -263,7 +276,7 @@ describe('filter menu value checklist', () => {
     // dropdown has no trailing separator, so anything that mistook the last
     // token for a half-typed fragment would show it unchecked.
     const checked = suggest.querySelectorAll('[role="option"][aria-selected="true"]')
-    expect(Array.from(checked).map((el) => el.textContent?.trim()).sort()).toEqual([
+    expect(Array.from(checked).map(labelOf).sort()).toEqual([
       'SYM00003',
       'SYM00005',
     ])
@@ -291,9 +304,7 @@ describe('filter menu value checklist', () => {
     await vi.waitFor(() => expect(target.querySelector('.sv-grid-in-suggest')).not.toBeNull())
     const suggest = target.querySelector('.sv-grid-in-suggest') as HTMLElement
 
-    const pick = Array.from(suggest.querySelectorAll('[role="option"]')).find(
-      (el) => el.textContent?.trim() === 'Aug 17, 2026',
-    ) as HTMLElement
+    const pick = findOption(suggest, 'Aug 17, 2026')
     pick.click()
     await tick()
 
@@ -328,4 +339,39 @@ describe('filter menu value checklist', () => {
 
     destroy()
   })
+
+  it('shows how many rows each value matches', async () => {
+    // 9 rows over teams A/B/C, so three each.
+    const { target, destroy } = await mountGrid(makeRows(9))
+    await tick()
+    const menu = await openFilterMenu(target, 1)
+    const rows = Array.from(menu.querySelectorAll('[role="option"]')).map((el) => ({
+      label: el.querySelector('.sv-listbox__label')?.textContent?.trim(),
+      hint: el.querySelector('.sv-listbox__hint')?.textContent?.trim(),
+    }))
+    expect(rows).toEqual([
+      { label: 'A', hint: '3' },
+      { label: 'B', hint: '3' },
+      { label: 'C', hint: '3' },
+    ])
+    destroy()
+  })
+
+  it('offers only the values still reachable under the other columns\' filters', async () => {
+    // Symbols SYM00000..2 are teams A, B, C in turn. Filtering Symbol down to
+    // one row must leave the Team list showing that row's team alone - the
+    // list used to be built from the whole dataset, so it offered every team
+    // and two of the three were a one-click route to an empty grid.
+    const { target, api, destroy } = await mountGrid(makeRows(9))
+    await tick()
+    api.setFilter('symbol', { operator: 'equals', value: 'SYM00001' })
+    await tick()
+    expect(api.getDisplayedRows().length).toBe(1)
+
+    const menu = await openFilterMenu(target, 1)
+    const labels = optionLabels(menu)
+    expect(labels).toEqual(['B'])
+
+    destroy()
+  })
 })

package/src/svgrid.in-suggest-snapshot.svelte.test.ts

@@ -0,0 +1,91 @@
+/**
+ * The `in` / `notIn` suggestions dropdown shares the facet scan with the
+ * filter menu's checklist. That scan now also runs the filter pipeline, to
+ * offer only values still reachable under the other columns' filters - which
+ * put an O(rows) pass on the typing path of the chip input, because the
+ * suggestions re-derive on every keystroke.
+ *
+ * They are snapshotted per open instead, the same way the menu's checklist is.
+ * This pins that: typing must not re-scan.
+ */
+import { describe, expect, it, vi } from 'vitest'
+import { mount, unmount } from 'svelte'
+import SvGrid from './SvGrid.svelte'
+import {
+  columnFilteringFeature,
+  rowSortingFeature,
+  tableFeatures,
+} from './index'
+import type { ColumnDef } from './index'
+
+type Row = { id: number; symbol: string }
+const features = tableFeatures({ rowSortingFeature, columnFilteringFeature })
+const tick = () => new Promise<void>((r) => setTimeout(r))
+
+describe('in/notIn suggestions', () => {
+  it('scans once per open, not once per keystroke', async () => {
+    const data: Row[] = Array.from({ length: 40 }, (_, i) => ({
+      id: i + 1,
+      symbol: `SYM${String(i).padStart(3, '0')}`,
+    }))
+
+    // Count reads of the accessor the facet scan goes through. A per-keystroke
+    // re-scan shows up here as another 40 reads per character typed.
+    let reads = 0
+    const columns: ColumnDef<typeof features, Row>[] = [
+      {
+        id: 'symbol',
+        header: 'Symbol',
+        width: 200,
+        fieldFn: (row: Row) => {
+          reads += 1
+          return row.symbol
+        },
+      },
+    ]
+
+    const target = document.createElement('div')
+    document.body.appendChild(target)
+    const app = mount(SvGrid<typeof features, Row>, {
+      target,
+      props: { data, columns, features, filterMode: 'row', height: 300 } as never,
+    })
+    await tick()
+
+    // Switch the column to `in`, which is what turns the filter-row box into a
+    // chip input with suggestions.
+    const operatorBtn = target.querySelector(
+      '.sv-grid-filter-operator-btn',
+    ) as HTMLButtonElement
+    operatorBtn.click()
+    await vi.waitFor(() => expect(document.querySelector('.sv-grid-operator-menu')).not.toBeNull())
+    const inItem = Array.from(
+      document.querySelectorAll('.sv-grid-operator-menu .sv-grid-menu-item'),
+    ).find((el) => el.textContent?.trim() === 'In') as HTMLElement
+    inItem.click()
+    await tick()
+
+    const input = target.querySelector(
+      '.sv-grid-filter-chip-input, .sv-grid-filter-value',
+    ) as HTMLInputElement
+    expect(input).not.toBeNull()
+    input.focus()
+    input.dispatchEvent(new Event('focus', { bubbles: true }))
+    await vi.waitFor(() => expect(document.querySelector('.sv-grid-in-suggest')).not.toBeNull())
+
+    const afterOpen = reads
+    expect(afterOpen).toBeGreaterThan(0)
+
+    // Type into the box: the list narrows from the snapshot, no fresh scan.
+    for (const text of ['S', 'SY', 'SYM', 'SYM0', 'SYM00']) {
+      input.value = text
+      input.dispatchEvent(new Event('input', { bubbles: true }))
+      await tick()
+    }
+    expect(document.querySelector('.sv-grid-in-suggest')).not.toBeNull()
+    expect(reads).toBe(afterOpen)
+
+    unmount(app)
+    target.remove()
+  })
+})

package/src/svgrid.menu-scroll-close.test.ts

@@ -0,0 +1,204 @@
+/**
+ * The scroll-close gate for the CELL CONTEXT MENU and the COMMENT EDITOR.
+ *
+ * Both are positioned from a one-time cursor measurement and rendered
+ * `position: fixed`, exactly like the column / filter / operator menus - but
+ * both were missing from the effect that closes those on an outside scroll, so
+ * after any scroll they floated over unrelated cells.
+ *
+ * The comment editor is closed by SAVING, not discarding. Backdrop-click and
+ * Escape throw the draft away and that is right, because both are the user
+ * saying "away with this". A scroll is not a dismissal gesture, so it must not
+ * destroy text the user has typed.
+ *
+ * The sibling file `svgrid.filter-menu-scroll.test.ts` covers the four menus
+ * that were already gated, including the must-NOT-close cases.
+ */
+import { describe, expect, it, vi } from 'vitest'
+import { mount, unmount } from 'svelte'
+import SvGrid from './SvGrid.svelte'
+import {
+  createCoreRowModel,
+  createFilteredRowModel,
+  createSortedRowModel,
+  rowSortingFeature,
+  sortFns,
+  tableFeatures,
+} from './index'
+import type { ColumnDef, SvGridApi } from './index'
+
+type Row = { id: number; name: string; team: string }
+const features = tableFeatures({ rowSortingFeature })
+const rows: Row[] = Array.from({ length: 6 }, (_, i) => ({
+  id: i + 1,
+  name: `Person ${i + 1}`,
+  team: ['A', 'B'][i % 2]!,
+}))
+const cols: ColumnDef<typeof features, Row>[] = [
+  { field: 'name', header: 'Name', width: 200, editorType: 'text' },
+  { field: 'team', header: 'Team', width: 160, editorType: 'text' },
+]
+
+/** Macrotask boundary - drains the overlay's lazy import() plus its flush. */
+const tick = () => new Promise<void>((r) => setTimeout(r))
+
+function mountGrid(extra: Record<string, unknown> = {}) {
+  return new Promise<{ api: SvGridApi<typeof features, Row>; target: HTMLElement; destroy: () => void }>(
+    (res, rej) => {
+      const target = document.createElement('div')
+      document.body.appendChild(target)
+      const app = mount(SvGrid, {
+        target,
+        props: {
+          data: rows,
+          columns: cols,
+          features,
+          _rowModels: {
+            coreRowModel: createCoreRowModel(),
+            filteredRowModel: createFilteredRowModel(),
+            sortedRowModel: createSortedRowModel(sortFns),
+          },
+          rowHeight: 32,
+          containerHeight: 240,
+          virtualization: false,
+          // `comment` is not one of the default items - ask for it by id so
+          // the comment editor is reachable at all.
+          contextMenu: ['copy', 'comment'],
+          onApiReady(api: SvGridApi<typeof features, Row>) {
+            res({ api, target, destroy: () => { unmount(app); target.remove() } })
+          },
+          ...extra,
+        } as any,
+      })
+      queueMicrotask(() => { if (!target.querySelector('[role="grid"]')) rej(new Error('no grid')) })
+    },
+  )
+}
+
+async function openContextMenu(target: HTMLElement) {
+  const cell = target.querySelector('.sv-grid-cell[data-svgrid-row]') as HTMLElement
+  const r = cell.getBoundingClientRect()
+  cell.dispatchEvent(
+    new MouseEvent('contextmenu', { bubbles: true, cancelable: true, clientX: r.x + 4, clientY: r.y + 4 }),
+  )
+  await vi.waitFor(() => {
+    const menu = target.querySelector('.sv-grid-context-menu')
+    expect(menu).not.toBeNull()
+    expect(menu!.querySelectorAll('.sv-grid-menu-item').length).toBeGreaterThan(0)
+  })
+  return target.querySelector('.sv-grid-context-menu') as HTMLElement
+}
+
+/** Right-click, then pick "Edit comment" to get the comment popover open. */
+async function openCommentEditor(target: HTMLElement) {
+  const menu = await openContextMenu(target)
+  const item = [...menu.querySelectorAll<HTMLElement>('.sv-grid-menu-item')].find((b) =>
+    (b.textContent ?? '').includes('Edit comment'),
+  )
+  expect(item, 'the "Edit comment" item should be in the configured menu').toBeTruthy()
+  item!.click()
+  await vi.waitFor(() => {
+    expect(target.querySelector('.sv-grid-comment-editor')).not.toBeNull()
+  })
+  return target.querySelector('.sv-grid-comment-editor') as HTMLElement
+}
+
+/** Scroll something that is NOT inside any menu. */
+function scrollOutside(target: HTMLElement) {
+  const viewport = target.querySelector('.sv-grid-viewport') ?? target
+  viewport.dispatchEvent(new Event('scroll'))
+}
+
+describe('cell context menu - scroll', () => {
+  it('closes when something outside it scrolls', async () => {
+    const { target, destroy } = await mountGrid()
+    await tick()
+    await openContextMenu(target)
+
+    scrollOutside(target)
+    await vi.waitFor(() => expect(target.querySelector('.sv-grid-context-menu')).toBeNull())
+
+    destroy()
+  })
+
+  it('stays open while the menu itself scrolls', async () => {
+    const { target, destroy } = await mountGrid()
+    await tick()
+    const menu = await openContextMenu(target)
+
+    menu.dispatchEvent(new Event('scroll'))
+    await tick()
+    expect(target.querySelector('.sv-grid-context-menu')).not.toBeNull()
+
+    destroy()
+  })
+
+  it('carries the grid id, so a second grid can tell whose menu it is', async () => {
+    const { target, destroy } = await mountGrid()
+    await tick()
+    const menu = await openContextMenu(target)
+
+    const id = menu.getAttribute('data-svgrid-menu')
+    expect(id).toBeTruthy()
+    // The same id the grid stamps on its cells, so the two are one grid.
+    const cellId = target.querySelector('.sv-grid-cell[id]')?.getAttribute('id')
+    expect(cellId).toContain(id!)
+
+    destroy()
+  })
+})
+
+describe('comment editor - scroll', () => {
+  it('closes when something outside it scrolls', async () => {
+    const { target, destroy } = await mountGrid()
+    await tick()
+    await openCommentEditor(target)
+
+    scrollOutside(target)
+    await vi.waitFor(() => expect(target.querySelector('.sv-grid-comment-editor')).toBeNull())
+
+    destroy()
+  })
+
+  it('SAVES the draft rather than throwing it away', async () => {
+    const changes: Array<{ note: string }> = []
+    const { target, destroy } = await mountGrid({
+      onNoteChange: (e: { note: string }) => changes.push(e),
+    })
+    await tick()
+    const editor = await openCommentEditor(target)
+
+    const textarea = editor.querySelector('textarea') as HTMLTextAreaElement
+    textarea.value = 'half-written thought'
+    textarea.dispatchEvent(new Event('input', { bubbles: true }))
+    await tick()
+
+    scrollOutside(target)
+    await vi.waitFor(() => expect(target.querySelector('.sv-grid-comment-editor')).toBeNull())
+
+    expect(changes.map((c) => c.note)).toContain('half-written thought')
+
+    destroy()
+  })
+
+  it('still DISCARDS on Escape, which is a real dismissal', async () => {
+    const changes: Array<{ note: string }> = []
+    const { target, destroy } = await mountGrid({
+      onNoteChange: (e: { note: string }) => changes.push(e),
+    })
+    await tick()
+    const editor = await openCommentEditor(target)
+
+    const textarea = editor.querySelector('textarea') as HTMLTextAreaElement
+    textarea.value = 'never mind'
+    textarea.dispatchEvent(new Event('input', { bubbles: true }))
+    await tick()
+
+    textarea.dispatchEvent(new KeyboardEvent('keydown', { key: 'Escape', bubbles: true }))
+    await vi.waitFor(() => expect(target.querySelector('.sv-grid-comment-editor')).toBeNull())
+
+    expect(changes).toHaveLength(0)
+
+    destroy()
+  })
+})