@svgrid/grid 2.6.17 → 2.6.19
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +346 -346
- package/README.md +199 -199
- package/dist/FlexRender.svelte +96 -96
- package/dist/GridFooter.svelte +181 -181
- package/dist/GridMenus.svelte +705 -705
- package/dist/SvAutoComplete.svelte +165 -165
- package/dist/SvAvatar.svelte +75 -75
- package/dist/SvCalendar.svelte +503 -503
- package/dist/SvCarousel.svelte +141 -141
- package/dist/SvCheckBox.svelte +102 -102
- package/dist/SvCircularProgress.svelte +109 -109
- package/dist/SvColorInput.svelte +181 -181
- package/dist/SvComboBox.svelte +275 -275
- package/dist/SvContextMenu.svelte +116 -116
- package/dist/SvCountryInput.svelte +163 -163
- package/dist/SvDrawer.svelte +254 -254
- package/dist/SvDropDownList.svelte +374 -374
- package/dist/SvDurationInput.svelte +126 -126
- package/dist/SvField.svelte +293 -293
- package/dist/SvForm.svelte +437 -437
- package/dist/SvGrid.css +2896 -2896
- package/dist/SvGrid.svelte +2956 -2956
- package/dist/SvGridCellEditor.svelte +662 -662
- package/dist/SvGridChart.svelte +1716 -1716
- package/dist/SvGridChartPanel.svelte +485 -485
- package/dist/SvGridChartView.svelte +70 -70
- package/dist/SvGridDropdown.svelte +728 -728
- package/dist/SvGridSelect.svelte +266 -266
- package/dist/SvGroupCell.svelte +116 -116
- package/dist/SvListBox.svelte +326 -326
- package/dist/SvMaskedInput.svelte +122 -122
- package/dist/SvMenu.svelte +124 -124
- package/dist/SvMenuList.svelte +146 -146
- package/dist/SvMultiSelect.svelte +289 -289
- package/dist/SvNumberInput.svelte +168 -168
- package/dist/SvOtpInput.svelte +158 -158
- package/dist/SvPasswordInput.svelte +151 -151
- package/dist/SvPhoneInput.svelte +133 -133
- package/dist/SvPopover.svelte +197 -197
- package/dist/SvProgress.svelte +116 -116
- package/dist/SvRadioGroup.svelte +107 -107
- package/dist/SvRating.svelte +112 -112
- package/dist/SvResult.svelte +73 -73
- package/dist/SvRichText.svelte +211 -211
- package/dist/SvRowGroupPanel.svelte +170 -170
- package/dist/SvScrollArea.svelte +61 -61
- package/dist/SvSlider.svelte +203 -203
- package/dist/SvSwitchButton.svelte +108 -108
- package/dist/SvTagsInput.svelte +115 -115
- package/dist/SvTextInput.svelte +147 -147
- package/dist/SvTimePicker.svelte +245 -245
- package/dist/SvToaster.svelte +159 -159
- package/dist/SvToggleButton.svelte +85 -85
- package/dist/SvTooltip.svelte +161 -161
- package/dist/SvTour.svelte +208 -208
- package/dist/SvTree.svelte +444 -444
- package/dist/SvTreeSelect.svelte +235 -235
- package/dist/cdn/{GridMenus-3kKYmYOE.js → GridMenus-B0F9iBrG.js} +2 -2
- package/dist/cdn/{GridMenus-BcDiwQ9U.js → GridMenus-IHK_l7m6.js} +2 -2
- package/dist/cdn/{SvDateTimePicker-DSUhIta8.js → SvDateTimePicker-CHnUkWcH.js} +2 -2
- package/dist/cdn/{SvDateTimePicker-h9kPyszT.js → SvDateTimePicker-CRQH_U7E.js} +2 -2
- package/dist/cdn/{SvGridCellEditor-DkyQO6FV.js → SvGridCellEditor-BGUCzuPB.js} +1 -1
- package/dist/cdn/{SvGridCellEditor-JpJSRhDx.js → SvGridCellEditor-G8IMWIws.js} +1 -1
- package/dist/cdn/{SvGridChart-CwhFz7GV.js → SvGridChart-BEJmNNx9.js} +1 -1
- package/dist/cdn/{SvGridChart-Bs2GIR2Q.js → SvGridChart-BwVos976.js} +1 -1
- package/dist/cdn/{SvGridChartPanel-1WXuStzM.js → SvGridChartPanel-BOknOkrP.js} +1 -1
- package/dist/cdn/{SvGridChartPanel-e5_nqNP9.js → SvGridChartPanel-D2PjII4O.js} +1 -1
- package/dist/cdn/{SvGridChartView-SmPW10dI.js → SvGridChartView-00LPUHL1.js} +1 -1
- package/dist/cdn/{SvGridChartView-eSPuJE6g.js → SvGridChartView-BhUEJ5ki.js} +1 -1
- package/dist/cdn/{SvGridDropdown-B1ZcLpgs.js → SvGridDropdown-D0VdjeR8.js} +1 -1
- package/dist/cdn/{SvGridDropdown-CtdbHcIS.js → SvGridDropdown-D13MtJ2j.js} +1 -1
- package/dist/cdn/{src-DMZZVVFd.js → src-B1TdiyS8.js} +26 -26
- package/dist/cdn/{src-D79V6bCA.js → src-Cd0tearp.js} +27 -27
- package/dist/cdn/svgrid.js +5 -5
- package/dist/cdn/svgrid.svelte-external.js +5 -5
- package/dist/chart-export.js +8 -8
- package/package.json +11 -11
- package/src/FlexRender.svelte +96 -96
- package/src/GridFooter.svelte +181 -181
- package/src/GridMenus.svelte +705 -705
- package/src/SvAutoComplete.svelte +165 -165
- package/src/SvAvatar.svelte +75 -75
- package/src/SvCalendar.svelte +503 -503
- package/src/SvCalendar.test.ts +226 -226
- package/src/SvCarousel.svelte +141 -141
- package/src/SvCheckBox.svelte +102 -102
- package/src/SvCircularProgress.svelte +109 -109
- package/src/SvColorInput.svelte +181 -181
- package/src/SvComboBox.svelte +275 -275
- package/src/SvContextMenu.svelte +116 -116
- package/src/SvCountryInput.svelte +163 -163
- package/src/SvDrawer.svelte +254 -254
- package/src/SvDropDownList.svelte +374 -374
- package/src/SvDurationInput.svelte +126 -126
- package/src/SvField.svelte +293 -293
- package/src/SvForm.svelte +437 -437
- package/src/SvForm.test.ts +411 -411
- package/src/SvGrid.controller.svelte.ts +3974 -3974
- package/src/SvGrid.css +2896 -2896
- package/src/SvGrid.svelte +2956 -2956
- package/src/SvGrid.types.ts +1790 -1790
- package/src/SvGridCellEditor.svelte +662 -662
- package/src/SvGridChart.svelte +1716 -1716
- package/src/SvGridChartPanel.svelte +485 -485
- package/src/SvGridChartView.svelte +70 -70
- package/src/SvGridDropdown.svelte +728 -728
- package/src/SvGridSelect.svelte +266 -266
- package/src/SvGroupCell.svelte +116 -116
- package/src/SvListBox.svelte +326 -326
- package/src/SvMaskedInput.svelte +122 -122
- package/src/SvMenu.svelte +124 -124
- package/src/SvMenu.test.ts +97 -97
- package/src/SvMenuList.svelte +146 -146
- package/src/SvMultiSelect.svelte +289 -289
- package/src/SvNumberInput.svelte +168 -168
- package/src/SvOtpInput.svelte +158 -158
- package/src/SvPasswordInput.svelte +151 -151
- package/src/SvPhoneInput.svelte +133 -133
- package/src/SvPopover.svelte +197 -197
- package/src/SvProgress.svelte +116 -116
- package/src/SvRadioGroup.svelte +107 -107
- package/src/SvRating.svelte +112 -112
- package/src/SvResult.svelte +73 -73
- package/src/SvRichText.svelte +211 -211
- package/src/SvRowGroupPanel.svelte +170 -170
- package/src/SvScrollArea.svelte +61 -61
- package/src/SvSlider.svelte +203 -203
- package/src/SvSwitchButton.svelte +108 -108
- package/src/SvTagsInput.svelte +115 -115
- package/src/SvTextInput.svelte +147 -147
- package/src/SvTimePicker.svelte +245 -245
- package/src/SvToaster.svelte +159 -159
- package/src/SvToaster.test.ts +95 -95
- package/src/SvToggleButton.svelte +85 -85
- package/src/SvTooltip.svelte +161 -161
- package/src/SvTour.svelte +208 -208
- package/src/SvTree.svelte +444 -444
- package/src/SvTreeSelect.svelte +235 -235
- package/src/a11y/dismissable.test.ts +119 -119
- package/src/a11y/dismissable.ts +114 -114
- package/src/a11y.contract.test.ts +49 -49
- package/src/a11y.test.ts +59 -59
- package/src/a11y.ts +61 -61
- package/src/ai.test.ts +502 -502
- package/src/ai.ts +1391 -1391
- package/src/build-api.coverage.test.ts +633 -633
- package/src/build-api.ts +846 -846
- package/src/builtin-editors.grid.test.ts +83 -83
- package/src/cell-formatting.ts +169 -169
- package/src/cell-render.test.ts +513 -513
- package/src/cell-render.ts +496 -496
- package/src/cell-values.ts +118 -118
- package/src/chart-export.ts +201 -201
- package/src/chart-view.svelte.ts +36 -36
- package/src/chart.ts +2295 -2295
- package/src/collaboration.test.ts +104 -104
- package/src/collaboration.ts +167 -167
- package/src/core.performance.test.ts +30 -30
- package/src/core.ts +1261 -1261
- package/src/createAutocomplete.svelte.ts +132 -132
- package/src/createCombobox.svelte.ts +191 -191
- package/src/createCountryInput.svelte.ts +157 -157
- package/src/createDropdownList.svelte.ts +168 -168
- package/src/createForm.svelte.ts +386 -386
- package/src/createGrid.svelte.ts +42 -42
- package/src/createGrid.test.ts +10 -10
- package/src/createGridState.svelte.ts +17 -17
- package/src/createListbox.svelte.ts +250 -250
- package/src/createMenu.svelte.ts +224 -224
- package/src/createPopoverSelect.svelte.ts +213 -213
- package/src/createSlider.svelte.ts +191 -191
- package/src/createTooltip.svelte.ts +144 -144
- package/src/createTree.svelte.ts +319 -319
- package/src/editing.test.ts +949 -949
- package/src/editing.ts +606 -606
- package/src/editor-contract.ts +170 -170
- package/src/editor-registry.grid.test.ts +144 -144
- package/src/editor-registry.ts +122 -122
- package/src/export-data-api.test.ts +126 -126
- package/src/export-format.test.ts +107 -107
- package/src/export-format.ts +601 -601
- package/src/filter-operators.ts +160 -160
- package/src/flex-render.ts +3 -3
- package/src/form-field.ts +127 -127
- package/src/group-display.test.ts +167 -167
- package/src/group-display.ts +200 -200
- package/src/headless.ts +87 -87
- package/src/index.ts +754 -754
- package/src/js-scroller.svelte.ts +173 -173
- package/src/keyboard-handlers.ts +270 -270
- package/src/keyboard.test.ts +59 -59
- package/src/keyboard.ts +97 -97
- package/src/list-nav.test.ts +49 -49
- package/src/list-nav.ts +29 -29
- package/src/list-option.test.ts +56 -56
- package/src/list-option.ts +172 -172
- package/src/menus.ts +567 -567
- package/src/merge-objects.ts +48 -48
- package/src/overlays.test.ts +90 -90
- package/src/render-component.ts +28 -28
- package/src/row-drag-touch.ts +211 -211
- package/src/row-drag.test.ts +353 -353
- package/src/row-drag.ts +415 -415
- package/src/row-resize.ts +210 -210
- package/src/scheduler-model.test.ts +562 -562
- package/src/scheduler-model.ts +872 -872
- package/src/selection.test.ts +754 -754
- package/src/selection.ts +491 -491
- package/src/server-data-source.test.ts +383 -383
- package/src/server-data-source.ts +469 -469
- package/src/sparkline.test.ts +68 -68
- package/src/sparkline.ts +169 -169
- package/src/spreadsheet.test.ts +488 -488
- package/src/spreadsheet.ts +312 -312
- package/src/static-functions.ts +11 -11
- package/src/subscribe.ts +38 -38
- package/src/svgrid-wrapper.types.ts +558 -558
- package/src/svgrid.async-editor-options.test.ts +273 -273
- package/src/svgrid.auto-row-height.test.ts +204 -204
- package/src/svgrid.behavior.test.ts +910 -910
- package/src/svgrid.charting.test.ts +534 -534
- package/src/svgrid.comments-autocomplete.test.ts +127 -127
- package/src/svgrid.context-menu.test.ts +147 -147
- package/src/svgrid.features.test.ts +157 -157
- package/src/svgrid.filter-depth.test.ts +163 -163
- package/src/svgrid.filter-menu-listbox.svelte.test.ts +331 -331
- package/src/svgrid.filter-menu-scroll.test.ts +112 -112
- package/src/svgrid.grand-total.test.ts +188 -188
- package/src/svgrid.group-display-mode.test.ts +171 -171
- package/src/svgrid.group-footers.test.ts +121 -121
- package/src/svgrid.group-pagination.test.ts +153 -153
- package/src/svgrid.new-features.wrapper.test.ts +251 -251
- package/src/svgrid.tree-data.test.ts +186 -186
- package/src/svgrid.wrapper.test.ts +63 -63
- package/src/svgriddropdown.async-panel.svelte.test.ts +195 -195
- package/src/test-setup.ts +62 -62
- package/src/themes/index.ts +288 -288
- package/src/toast-store.svelte.ts +246 -246
- package/src/toast-store.test.ts +147 -147
- package/src/tree-row-model.test.ts +168 -168
- package/src/ui-buttons.test.ts +144 -144
- package/src/ui-inputs.test.ts +118 -118
- package/src/ui-localization.test.ts +113 -113
- package/src/ui-range.test.ts +70 -70
- package/src/ui-selection.test.ts +155 -155
- package/src/ui-tier1.test.ts +142 -142
- package/src/virtual.test.ts +88 -88
- package/src/virtualization/column-virtualizer.test.ts +27 -27
- package/src/virtualization/column-virtualizer.ts +30 -30
- package/src/virtualization/svelte-virtualizer.svelte.ts +26 -26
- package/src/virtualization/types.ts +30 -30
- package/src/virtualization/virtualizer.test.ts +47 -47
- package/src/virtualization/virtualizer.ts +322 -322
package/src/row-drag.test.ts
CHANGED
|
@@ -1,353 +1,353 @@
|
|
|
1
|
-
/**
|
|
2
|
-
* Unit tests for the managed row-drag handlers produced by createRowDrag(ctx).
|
|
3
|
-
*
|
|
4
|
-
* createRowDrag is a factory closing over a mutable `ctx` handle and a
|
|
5
|
-
* module-level singleton "bus" that carries the dragged row between grids.
|
|
6
|
-
* Because the bus is shared, we can create TWO fake ctxs (two grids) and drive
|
|
7
|
-
* a genuine grid-to-grid move without mounting anything.
|
|
8
|
-
*/
|
|
9
|
-
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
10
|
-
import { createRowDrag, rowDropZone } from './row-drag'
|
|
11
|
-
|
|
12
|
-
type AnyCtx = Record<string, any>
|
|
13
|
-
type Task = { id: number; title: string }
|
|
14
|
-
|
|
15
|
-
function makeCtx(rows: Task[], props: AnyCtx = {}): AnyCtx {
|
|
16
|
-
return {
|
|
17
|
-
props,
|
|
18
|
-
internalData: rows,
|
|
19
|
-
get allRows() {
|
|
20
|
-
// allRows tracks internalData order; each Row wraps `.original`.
|
|
21
|
-
return (this.internalData as Task[]).map((r) => ({ original: r }))
|
|
22
|
-
},
|
|
23
|
-
rowDragActive: false,
|
|
24
|
-
rowDropIndex: null,
|
|
25
|
-
rowDropSide: null,
|
|
26
|
-
}
|
|
27
|
-
}
|
|
28
|
-
|
|
29
|
-
function fakeEvent(clientY = 0, rectTop = 0, rectHeight = 40): any {
|
|
30
|
-
return {
|
|
31
|
-
clientY,
|
|
32
|
-
preventDefault: vi.fn(),
|
|
33
|
-
stopPropagation: vi.fn(),
|
|
34
|
-
dataTransfer: { setData: vi.fn(), effectAllowed: '', dropEffect: '' },
|
|
35
|
-
currentTarget: {
|
|
36
|
-
getBoundingClientRect: () => ({ top: rectTop, height: rectHeight, bottom: rectTop + rectHeight, left: 0 }),
|
|
37
|
-
},
|
|
38
|
-
}
|
|
39
|
-
}
|
|
40
|
-
|
|
41
|
-
const P = { rowDragManaged: true }
|
|
42
|
-
|
|
43
|
-
describe('createRowDrag - same-grid reorder', () => {
|
|
44
|
-
it('moves a dragged row after the drop target', () => {
|
|
45
|
-
const rows: Task[] = [
|
|
46
|
-
{ id: 1, title: 'a' },
|
|
47
|
-
{ id: 2, title: 'b' },
|
|
48
|
-
{ id: 3, title: 'c' },
|
|
49
|
-
{ id: 4, title: 'd' },
|
|
50
|
-
]
|
|
51
|
-
const ctx = makeCtx(rows, { ...P })
|
|
52
|
-
const h = createRowDrag(ctx)
|
|
53
|
-
|
|
54
|
-
h.onRowDragStart(fakeEvent(), 0) // drag "a"
|
|
55
|
-
ctx.rowDropSide = 'after'
|
|
56
|
-
h.onRowDrop(fakeEvent(), 2) // drop after "c"
|
|
57
|
-
|
|
58
|
-
expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['b', 'c', 'a', 'd'])
|
|
59
|
-
})
|
|
60
|
-
|
|
61
|
-
it('drops before the target when the side is "before"', () => {
|
|
62
|
-
const rows: Task[] = [
|
|
63
|
-
{ id: 1, title: 'a' },
|
|
64
|
-
{ id: 2, title: 'b' },
|
|
65
|
-
{ id: 3, title: 'c' },
|
|
66
|
-
]
|
|
67
|
-
const ctx = makeCtx(rows, { ...P })
|
|
68
|
-
const h = createRowDrag(ctx)
|
|
69
|
-
h.onRowDragStart(fakeEvent(), 2) // drag "c"
|
|
70
|
-
ctx.rowDropSide = 'before'
|
|
71
|
-
h.onRowDrop(fakeEvent(), 0) // before "a"
|
|
72
|
-
expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['c', 'a', 'b'])
|
|
73
|
-
})
|
|
74
|
-
})
|
|
75
|
-
|
|
76
|
-
describe('createRowDrag - grid-to-grid', () => {
|
|
77
|
-
it('moves a row from source into target when groups match', () => {
|
|
78
|
-
const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
|
|
79
|
-
const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'g', onRowDragEnd: vi.fn() })
|
|
80
|
-
const ha = createRowDrag(a)
|
|
81
|
-
const hb = createRowDrag(b)
|
|
82
|
-
|
|
83
|
-
ha.onRowDragStart(fakeEvent(), 1) // drag "a2" out of grid A
|
|
84
|
-
b.rowDropSide = 'before'
|
|
85
|
-
hb.onRowDrop(fakeEvent(), 0) // drop onto grid B before "b1"
|
|
86
|
-
|
|
87
|
-
expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a1'])
|
|
88
|
-
expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['a2', 'b1'])
|
|
89
|
-
expect(b.props.onRowDragEnd).toHaveBeenCalledWith(
|
|
90
|
-
expect.objectContaining({ sameGrid: false, toIndex: 0, row: expect.objectContaining({ title: 'a2' }) }),
|
|
91
|
-
)
|
|
92
|
-
})
|
|
93
|
-
|
|
94
|
-
it('does NOT accept a drop when groups differ', () => {
|
|
95
|
-
const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
|
|
96
|
-
const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'other' })
|
|
97
|
-
const ha = createRowDrag(a)
|
|
98
|
-
const hb = createRowDrag(b)
|
|
99
|
-
|
|
100
|
-
ha.onRowDragStart(fakeEvent(), 0)
|
|
101
|
-
const ev = fakeEvent()
|
|
102
|
-
hb.onRowDragOver(ev, 0)
|
|
103
|
-
expect(ev.preventDefault).not.toHaveBeenCalled() // over rejected
|
|
104
|
-
hb.onRowDrop(fakeEvent(), 0)
|
|
105
|
-
expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['b1']) // unchanged
|
|
106
|
-
expect((a.internalData as Task[]).length).toBe(2) // source untouched
|
|
107
|
-
})
|
|
108
|
-
|
|
109
|
-
it('appends to the target on an empty-space (container) drop', () => {
|
|
110
|
-
const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
|
|
111
|
-
const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'g' })
|
|
112
|
-
const ha = createRowDrag(a)
|
|
113
|
-
const hb = createRowDrag(b)
|
|
114
|
-
ha.onRowDragStart(fakeEvent(), 0) // drag "a1"
|
|
115
|
-
hb.onRowsContainerDrop(fakeEvent())
|
|
116
|
-
expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['b1', 'a1'])
|
|
117
|
-
expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a2'])
|
|
118
|
-
})
|
|
119
|
-
})
|
|
120
|
-
|
|
121
|
-
describe('createRowDrag - disabled', () => {
|
|
122
|
-
it('is inert when rowDragManaged is off', () => {
|
|
123
|
-
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], {})
|
|
124
|
-
const h = createRowDrag(ctx)
|
|
125
|
-
h.onRowDragStart(fakeEvent(), 0)
|
|
126
|
-
ctx.rowDropSide = 'after'
|
|
127
|
-
h.onRowDrop(fakeEvent(), 1)
|
|
128
|
-
expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['a', 'b'])
|
|
129
|
-
})
|
|
130
|
-
})
|
|
131
|
-
|
|
132
|
-
describe('rowDropZone (external drop target)', () => {
|
|
133
|
-
function dropOn(el: HTMLElement) {
|
|
134
|
-
const ev = new Event('drop', { bubbles: true, cancelable: true })
|
|
135
|
-
el.dispatchEvent(ev)
|
|
136
|
-
}
|
|
137
|
-
|
|
138
|
-
it('removes the dragged row from its source grid and calls onDrop', () => {
|
|
139
|
-
const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
|
|
140
|
-
const ha = createRowDrag(a)
|
|
141
|
-
ha.onRowDragStart(fakeEvent(), 0) // start dragging "a1"
|
|
142
|
-
|
|
143
|
-
const el = document.createElement('div')
|
|
144
|
-
const dropped: any[] = []
|
|
145
|
-
const action = rowDropZone(el, { group: 'g', onDrop: (e) => dropped.push(e) })
|
|
146
|
-
dropOn(el)
|
|
147
|
-
|
|
148
|
-
expect(dropped.length).toBe(1)
|
|
149
|
-
expect(dropped[0].row.title).toBe('a1')
|
|
150
|
-
expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a2']) // removed from source
|
|
151
|
-
action.destroy()
|
|
152
|
-
})
|
|
153
|
-
|
|
154
|
-
it('ignores drops when the group does not match', () => {
|
|
155
|
-
const a = makeCtx([{ id: 1, title: 'a1' }], { ...P, rowDragGroup: 'g' })
|
|
156
|
-
const ha = createRowDrag(a)
|
|
157
|
-
ha.onRowDragStart(fakeEvent(), 0)
|
|
158
|
-
|
|
159
|
-
const el = document.createElement('div')
|
|
160
|
-
const dropped: any[] = []
|
|
161
|
-
const action = rowDropZone(el, { group: 'other', onDrop: (e) => dropped.push(e) })
|
|
162
|
-
dropOn(el)
|
|
163
|
-
|
|
164
|
-
expect(dropped.length).toBe(0)
|
|
165
|
-
expect((a.internalData as Task[]).length).toBe(1) // untouched
|
|
166
|
-
action.destroy()
|
|
167
|
-
})
|
|
168
|
-
})
|
|
169
|
-
|
|
170
|
-
/**
|
|
171
|
-
* #69 - the drop indicator vanished mid-drag under row virtualization.
|
|
172
|
-
*
|
|
173
|
-
* Scrolling to the viewport edge unmounts the row the pointer is over, which
|
|
174
|
-
* fires that row's `dragleave`. The replacement row does not fire `dragover`
|
|
175
|
-
* until the next frame, so a synchronous clear left the user with no indicator
|
|
176
|
-
* and no drop target until they moved the pointer.
|
|
177
|
-
*/
|
|
178
|
-
describe('createRowDrag - drop indicator during virtualized scroll (#69)', () => {
|
|
179
|
-
const nextFrame = () => new Promise((r) => requestAnimationFrame(() => r(null)))
|
|
180
|
-
|
|
181
|
-
it('keeps the indicator when the hovered row unmounts and another takes over', async () => {
|
|
182
|
-
const rows: Task[] = [
|
|
183
|
-
{ id: 1, title: 'a' },
|
|
184
|
-
{ id: 2, title: 'b' },
|
|
185
|
-
{ id: 3, title: 'c' },
|
|
186
|
-
]
|
|
187
|
-
const ctx = makeCtx(rows, P)
|
|
188
|
-
const d = createRowDrag(ctx)
|
|
189
|
-
|
|
190
|
-
d.onRowDragStart(fakeEvent(), 0)
|
|
191
|
-
d.onRowDragOver(fakeEvent(30, 0, 40), 1)
|
|
192
|
-
expect(ctx.rowDropIndex).toBe(1)
|
|
193
|
-
|
|
194
|
-
// Virtualization unmounts row 1 from under the pointer, firing its leave.
|
|
195
|
-
d.onRowDragLeave(1)
|
|
196
|
-
|
|
197
|
-
// THIS is the bug: the replacement row has not fired `dragover` yet, and a
|
|
198
|
-
// synchronous clear leaves the user with no indicator and no drop target in
|
|
199
|
-
// the meantime. The indicator must survive the gap.
|
|
200
|
-
expect(ctx.rowDropIndex).toBe(1)
|
|
201
|
-
expect(ctx.rowDropSide).not.toBeNull()
|
|
202
|
-
|
|
203
|
-
// The row scrolled into its place then takes over on the next frame.
|
|
204
|
-
d.onRowDragOver(fakeEvent(30, 0, 40), 2)
|
|
205
|
-
await nextFrame()
|
|
206
|
-
await nextFrame()
|
|
207
|
-
expect(ctx.rowDropIndex).toBe(2)
|
|
208
|
-
expect(ctx.rowDropSide).not.toBeNull()
|
|
209
|
-
})
|
|
210
|
-
|
|
211
|
-
it('still clears once the pointer genuinely leaves the rows', async () => {
|
|
212
|
-
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
213
|
-
const d = createRowDrag(ctx)
|
|
214
|
-
|
|
215
|
-
d.onRowDragStart(fakeEvent(), 0)
|
|
216
|
-
d.onRowDragOver(fakeEvent(30, 0, 40), 1)
|
|
217
|
-
expect(ctx.rowDropIndex).toBe(1)
|
|
218
|
-
|
|
219
|
-
d.onRowDragLeave(1)
|
|
220
|
-
// No dragover follows - the deferral must not turn into a stuck indicator.
|
|
221
|
-
await nextFrame()
|
|
222
|
-
await nextFrame()
|
|
223
|
-
expect(ctx.rowDropIndex).toBeNull()
|
|
224
|
-
expect(ctx.rowDropSide).toBeNull()
|
|
225
|
-
})
|
|
226
|
-
|
|
227
|
-
it('does not write indicator state after the grid is destroyed', async () => {
|
|
228
|
-
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
229
|
-
const d = createRowDrag(ctx)
|
|
230
|
-
|
|
231
|
-
d.onRowDragStart(fakeEvent(), 0)
|
|
232
|
-
d.onRowDragOver(fakeEvent(30, 0, 40), 1)
|
|
233
|
-
d.onRowDragLeave(1)
|
|
234
|
-
d.destroyRowDrag()
|
|
235
|
-
ctx.rowDropIndex = 'sentinel'
|
|
236
|
-
|
|
237
|
-
await nextFrame()
|
|
238
|
-
await nextFrame()
|
|
239
|
-
// A frame that survived teardown would have nulled this.
|
|
240
|
-
expect(ctx.rowDropIndex).toBe('sentinel')
|
|
241
|
-
})
|
|
242
|
-
})
|
|
243
|
-
|
|
244
|
-
/**
|
|
245
|
-
* #66 - row drag was dead on touch: the whole feature rode on HTML5 DragEvent,
|
|
246
|
-
* which iOS Safari and Android Chrome never fire for touch input.
|
|
247
|
-
*
|
|
248
|
-
* The pointer path is a second INPUT onto the same model, so these tests drive
|
|
249
|
-
* the real handlers and assert on the same `bus` / indicator state the mouse
|
|
250
|
-
* path uses, then check the reorder actually happened.
|
|
251
|
-
*/
|
|
252
|
-
describe('createRowDrag - touch (#66)', () => {
|
|
253
|
-
const wait = (ms: number) => new Promise((r) => setTimeout(r, ms))
|
|
254
|
-
|
|
255
|
-
// `stubRowAt` replaces a global. Without restoring it, every later test in
|
|
256
|
-
// the worker inherits a fake elementFromPoint - which showed up as an
|
|
257
|
-
// intermittent failure elsewhere in the suite, not here.
|
|
258
|
-
const realElementFromPoint = document.elementFromPoint
|
|
259
|
-
afterEach(() => {
|
|
260
|
-
;(document as any).elementFromPoint = realElementFromPoint
|
|
261
|
-
})
|
|
262
|
-
|
|
263
|
-
function pointer(type: string, clientY: number, extra: AnyCtx = {}): any {
|
|
264
|
-
return {
|
|
265
|
-
pointerId: 1,
|
|
266
|
-
pointerType: type,
|
|
267
|
-
clientX: 10,
|
|
268
|
-
clientY,
|
|
269
|
-
preventDefault: vi.fn(),
|
|
270
|
-
currentTarget: { setPointerCapture: vi.fn(), closest: () => null },
|
|
271
|
-
...extra,
|
|
272
|
-
}
|
|
273
|
-
}
|
|
274
|
-
|
|
275
|
-
/** Put row `index` under the pointer, the way elementFromPoint would. */
|
|
276
|
-
function stubRowAt(index: number, top: number, height = 40) {
|
|
277
|
-
const marker = { dataset: { svgridRow: String(index) } }
|
|
278
|
-
const tr = {
|
|
279
|
-
querySelector: () => marker,
|
|
280
|
-
getBoundingClientRect: () => ({ top, height, bottom: top + height }),
|
|
281
|
-
}
|
|
282
|
-
;(document as any).elementFromPoint = () => ({ closest: (s: string) => (s === 'tr.sv-grid-row' ? tr : null) })
|
|
283
|
-
}
|
|
284
|
-
|
|
285
|
-
it('ignores mouse and pen so the HTML5 path keeps owning them', () => {
|
|
286
|
-
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
287
|
-
const d = createRowDrag(ctx)
|
|
288
|
-
d.onRowPointerDown(pointer('mouse', 10), 0)
|
|
289
|
-
d.onRowPointerDown(pointer('pen', 10), 0)
|
|
290
|
-
expect(ctx.rowDragActive).toBe(false)
|
|
291
|
-
})
|
|
292
|
-
|
|
293
|
-
it('does not start until the long press elapses', async () => {
|
|
294
|
-
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
295
|
-
const d = createRowDrag(ctx)
|
|
296
|
-
d.onRowPointerDown(pointer('touch', 10), 0)
|
|
297
|
-
expect(ctx.rowDragActive).toBe(false)
|
|
298
|
-
await wait(400)
|
|
299
|
-
expect(ctx.rowDragActive).toBe(true)
|
|
300
|
-
d.destroyRowDrag()
|
|
301
|
-
})
|
|
302
|
-
|
|
303
|
-
it('treats an early move as a scroll and never starts the drag', async () => {
|
|
304
|
-
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
305
|
-
const d = createRowDrag(ctx)
|
|
306
|
-
d.onRowPointerDown(pointer('touch', 10), 0)
|
|
307
|
-
window.dispatchEvent(Object.assign(new Event('pointermove'), {
|
|
308
|
-
pointerId: 1, clientX: 10, clientY: 60, preventDefault() {},
|
|
309
|
-
}))
|
|
310
|
-
await wait(400)
|
|
311
|
-
expect(ctx.rowDragActive).toBe(false)
|
|
312
|
-
d.destroyRowDrag()
|
|
313
|
-
})
|
|
314
|
-
|
|
315
|
-
it('reorders on lift, through the same commit as the mouse path', async () => {
|
|
316
|
-
const rows: Task[] = [
|
|
317
|
-
{ id: 1, title: 'a' },
|
|
318
|
-
{ id: 2, title: 'b' },
|
|
319
|
-
{ id: 3, title: 'c' },
|
|
320
|
-
]
|
|
321
|
-
const onRowDragEnd = vi.fn()
|
|
322
|
-
const ctx = makeCtx(rows, { ...P, onRowDragEnd })
|
|
323
|
-
const d = createRowDrag(ctx)
|
|
324
|
-
|
|
325
|
-
d.onRowPointerDown(pointer('touch', 10), 0)
|
|
326
|
-
await wait(400)
|
|
327
|
-
expect(ctx.rowDragActive).toBe(true)
|
|
328
|
-
|
|
329
|
-
// Finger moves over the lower half of row 2.
|
|
330
|
-
stubRowAt(2, 80, 40)
|
|
331
|
-
window.dispatchEvent(Object.assign(new Event('pointermove'), {
|
|
332
|
-
pointerId: 1, clientX: 10, clientY: 115, preventDefault() {},
|
|
333
|
-
}))
|
|
334
|
-
expect(ctx.rowDropIndex).toBe(2)
|
|
335
|
-
expect(ctx.rowDropSide).toBe('after')
|
|
336
|
-
|
|
337
|
-
window.dispatchEvent(Object.assign(new Event('pointerup'), { pointerId: 1, clientY: 115 }))
|
|
338
|
-
expect((ctx.internalData as Task[]).map((r) => r.id)).toEqual([2, 3, 1])
|
|
339
|
-
expect(onRowDragEnd).toHaveBeenCalledTimes(1)
|
|
340
|
-
expect(ctx.rowDragActive).toBe(false)
|
|
341
|
-
})
|
|
342
|
-
|
|
343
|
-
it('cancels without reordering on pointercancel', async () => {
|
|
344
|
-
const rows: Task[] = [{ id: 1, title: 'a' }, { id: 2, title: 'b' }]
|
|
345
|
-
const ctx = makeCtx(rows, P)
|
|
346
|
-
const d = createRowDrag(ctx)
|
|
347
|
-
d.onRowPointerDown(pointer('touch', 10), 0)
|
|
348
|
-
await wait(400)
|
|
349
|
-
window.dispatchEvent(Object.assign(new Event('pointercancel'), { pointerId: 1 }))
|
|
350
|
-
expect((ctx.internalData as Task[]).map((r) => r.id)).toEqual([1, 2])
|
|
351
|
-
expect(ctx.rowDragActive).toBe(false)
|
|
352
|
-
})
|
|
353
|
-
})
|
|
1
|
+
/**
|
|
2
|
+
* Unit tests for the managed row-drag handlers produced by createRowDrag(ctx).
|
|
3
|
+
*
|
|
4
|
+
* createRowDrag is a factory closing over a mutable `ctx` handle and a
|
|
5
|
+
* module-level singleton "bus" that carries the dragged row between grids.
|
|
6
|
+
* Because the bus is shared, we can create TWO fake ctxs (two grids) and drive
|
|
7
|
+
* a genuine grid-to-grid move without mounting anything.
|
|
8
|
+
*/
|
|
9
|
+
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
10
|
+
import { createRowDrag, rowDropZone } from './row-drag'
|
|
11
|
+
|
|
12
|
+
type AnyCtx = Record<string, any>
|
|
13
|
+
type Task = { id: number; title: string }
|
|
14
|
+
|
|
15
|
+
function makeCtx(rows: Task[], props: AnyCtx = {}): AnyCtx {
|
|
16
|
+
return {
|
|
17
|
+
props,
|
|
18
|
+
internalData: rows,
|
|
19
|
+
get allRows() {
|
|
20
|
+
// allRows tracks internalData order; each Row wraps `.original`.
|
|
21
|
+
return (this.internalData as Task[]).map((r) => ({ original: r }))
|
|
22
|
+
},
|
|
23
|
+
rowDragActive: false,
|
|
24
|
+
rowDropIndex: null,
|
|
25
|
+
rowDropSide: null,
|
|
26
|
+
}
|
|
27
|
+
}
|
|
28
|
+
|
|
29
|
+
function fakeEvent(clientY = 0, rectTop = 0, rectHeight = 40): any {
|
|
30
|
+
return {
|
|
31
|
+
clientY,
|
|
32
|
+
preventDefault: vi.fn(),
|
|
33
|
+
stopPropagation: vi.fn(),
|
|
34
|
+
dataTransfer: { setData: vi.fn(), effectAllowed: '', dropEffect: '' },
|
|
35
|
+
currentTarget: {
|
|
36
|
+
getBoundingClientRect: () => ({ top: rectTop, height: rectHeight, bottom: rectTop + rectHeight, left: 0 }),
|
|
37
|
+
},
|
|
38
|
+
}
|
|
39
|
+
}
|
|
40
|
+
|
|
41
|
+
const P = { rowDragManaged: true }
|
|
42
|
+
|
|
43
|
+
describe('createRowDrag - same-grid reorder', () => {
|
|
44
|
+
it('moves a dragged row after the drop target', () => {
|
|
45
|
+
const rows: Task[] = [
|
|
46
|
+
{ id: 1, title: 'a' },
|
|
47
|
+
{ id: 2, title: 'b' },
|
|
48
|
+
{ id: 3, title: 'c' },
|
|
49
|
+
{ id: 4, title: 'd' },
|
|
50
|
+
]
|
|
51
|
+
const ctx = makeCtx(rows, { ...P })
|
|
52
|
+
const h = createRowDrag(ctx)
|
|
53
|
+
|
|
54
|
+
h.onRowDragStart(fakeEvent(), 0) // drag "a"
|
|
55
|
+
ctx.rowDropSide = 'after'
|
|
56
|
+
h.onRowDrop(fakeEvent(), 2) // drop after "c"
|
|
57
|
+
|
|
58
|
+
expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['b', 'c', 'a', 'd'])
|
|
59
|
+
})
|
|
60
|
+
|
|
61
|
+
it('drops before the target when the side is "before"', () => {
|
|
62
|
+
const rows: Task[] = [
|
|
63
|
+
{ id: 1, title: 'a' },
|
|
64
|
+
{ id: 2, title: 'b' },
|
|
65
|
+
{ id: 3, title: 'c' },
|
|
66
|
+
]
|
|
67
|
+
const ctx = makeCtx(rows, { ...P })
|
|
68
|
+
const h = createRowDrag(ctx)
|
|
69
|
+
h.onRowDragStart(fakeEvent(), 2) // drag "c"
|
|
70
|
+
ctx.rowDropSide = 'before'
|
|
71
|
+
h.onRowDrop(fakeEvent(), 0) // before "a"
|
|
72
|
+
expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['c', 'a', 'b'])
|
|
73
|
+
})
|
|
74
|
+
})
|
|
75
|
+
|
|
76
|
+
describe('createRowDrag - grid-to-grid', () => {
|
|
77
|
+
it('moves a row from source into target when groups match', () => {
|
|
78
|
+
const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
|
|
79
|
+
const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'g', onRowDragEnd: vi.fn() })
|
|
80
|
+
const ha = createRowDrag(a)
|
|
81
|
+
const hb = createRowDrag(b)
|
|
82
|
+
|
|
83
|
+
ha.onRowDragStart(fakeEvent(), 1) // drag "a2" out of grid A
|
|
84
|
+
b.rowDropSide = 'before'
|
|
85
|
+
hb.onRowDrop(fakeEvent(), 0) // drop onto grid B before "b1"
|
|
86
|
+
|
|
87
|
+
expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a1'])
|
|
88
|
+
expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['a2', 'b1'])
|
|
89
|
+
expect(b.props.onRowDragEnd).toHaveBeenCalledWith(
|
|
90
|
+
expect.objectContaining({ sameGrid: false, toIndex: 0, row: expect.objectContaining({ title: 'a2' }) }),
|
|
91
|
+
)
|
|
92
|
+
})
|
|
93
|
+
|
|
94
|
+
it('does NOT accept a drop when groups differ', () => {
|
|
95
|
+
const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
|
|
96
|
+
const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'other' })
|
|
97
|
+
const ha = createRowDrag(a)
|
|
98
|
+
const hb = createRowDrag(b)
|
|
99
|
+
|
|
100
|
+
ha.onRowDragStart(fakeEvent(), 0)
|
|
101
|
+
const ev = fakeEvent()
|
|
102
|
+
hb.onRowDragOver(ev, 0)
|
|
103
|
+
expect(ev.preventDefault).not.toHaveBeenCalled() // over rejected
|
|
104
|
+
hb.onRowDrop(fakeEvent(), 0)
|
|
105
|
+
expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['b1']) // unchanged
|
|
106
|
+
expect((a.internalData as Task[]).length).toBe(2) // source untouched
|
|
107
|
+
})
|
|
108
|
+
|
|
109
|
+
it('appends to the target on an empty-space (container) drop', () => {
|
|
110
|
+
const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
|
|
111
|
+
const b = makeCtx([{ id: 9, title: 'b1' }], { ...P, rowDragGroup: 'g' })
|
|
112
|
+
const ha = createRowDrag(a)
|
|
113
|
+
const hb = createRowDrag(b)
|
|
114
|
+
ha.onRowDragStart(fakeEvent(), 0) // drag "a1"
|
|
115
|
+
hb.onRowsContainerDrop(fakeEvent())
|
|
116
|
+
expect((b.internalData as Task[]).map((r) => r.title)).toEqual(['b1', 'a1'])
|
|
117
|
+
expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a2'])
|
|
118
|
+
})
|
|
119
|
+
})
|
|
120
|
+
|
|
121
|
+
describe('createRowDrag - disabled', () => {
|
|
122
|
+
it('is inert when rowDragManaged is off', () => {
|
|
123
|
+
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], {})
|
|
124
|
+
const h = createRowDrag(ctx)
|
|
125
|
+
h.onRowDragStart(fakeEvent(), 0)
|
|
126
|
+
ctx.rowDropSide = 'after'
|
|
127
|
+
h.onRowDrop(fakeEvent(), 1)
|
|
128
|
+
expect((ctx.internalData as Task[]).map((r) => r.title)).toEqual(['a', 'b'])
|
|
129
|
+
})
|
|
130
|
+
})
|
|
131
|
+
|
|
132
|
+
describe('rowDropZone (external drop target)', () => {
|
|
133
|
+
function dropOn(el: HTMLElement) {
|
|
134
|
+
const ev = new Event('drop', { bubbles: true, cancelable: true })
|
|
135
|
+
el.dispatchEvent(ev)
|
|
136
|
+
}
|
|
137
|
+
|
|
138
|
+
it('removes the dragged row from its source grid and calls onDrop', () => {
|
|
139
|
+
const a = makeCtx([{ id: 1, title: 'a1' }, { id: 2, title: 'a2' }], { ...P, rowDragGroup: 'g' })
|
|
140
|
+
const ha = createRowDrag(a)
|
|
141
|
+
ha.onRowDragStart(fakeEvent(), 0) // start dragging "a1"
|
|
142
|
+
|
|
143
|
+
const el = document.createElement('div')
|
|
144
|
+
const dropped: any[] = []
|
|
145
|
+
const action = rowDropZone(el, { group: 'g', onDrop: (e) => dropped.push(e) })
|
|
146
|
+
dropOn(el)
|
|
147
|
+
|
|
148
|
+
expect(dropped.length).toBe(1)
|
|
149
|
+
expect(dropped[0].row.title).toBe('a1')
|
|
150
|
+
expect((a.internalData as Task[]).map((r) => r.title)).toEqual(['a2']) // removed from source
|
|
151
|
+
action.destroy()
|
|
152
|
+
})
|
|
153
|
+
|
|
154
|
+
it('ignores drops when the group does not match', () => {
|
|
155
|
+
const a = makeCtx([{ id: 1, title: 'a1' }], { ...P, rowDragGroup: 'g' })
|
|
156
|
+
const ha = createRowDrag(a)
|
|
157
|
+
ha.onRowDragStart(fakeEvent(), 0)
|
|
158
|
+
|
|
159
|
+
const el = document.createElement('div')
|
|
160
|
+
const dropped: any[] = []
|
|
161
|
+
const action = rowDropZone(el, { group: 'other', onDrop: (e) => dropped.push(e) })
|
|
162
|
+
dropOn(el)
|
|
163
|
+
|
|
164
|
+
expect(dropped.length).toBe(0)
|
|
165
|
+
expect((a.internalData as Task[]).length).toBe(1) // untouched
|
|
166
|
+
action.destroy()
|
|
167
|
+
})
|
|
168
|
+
})
|
|
169
|
+
|
|
170
|
+
/**
|
|
171
|
+
* #69 - the drop indicator vanished mid-drag under row virtualization.
|
|
172
|
+
*
|
|
173
|
+
* Scrolling to the viewport edge unmounts the row the pointer is over, which
|
|
174
|
+
* fires that row's `dragleave`. The replacement row does not fire `dragover`
|
|
175
|
+
* until the next frame, so a synchronous clear left the user with no indicator
|
|
176
|
+
* and no drop target until they moved the pointer.
|
|
177
|
+
*/
|
|
178
|
+
describe('createRowDrag - drop indicator during virtualized scroll (#69)', () => {
|
|
179
|
+
const nextFrame = () => new Promise((r) => requestAnimationFrame(() => r(null)))
|
|
180
|
+
|
|
181
|
+
it('keeps the indicator when the hovered row unmounts and another takes over', async () => {
|
|
182
|
+
const rows: Task[] = [
|
|
183
|
+
{ id: 1, title: 'a' },
|
|
184
|
+
{ id: 2, title: 'b' },
|
|
185
|
+
{ id: 3, title: 'c' },
|
|
186
|
+
]
|
|
187
|
+
const ctx = makeCtx(rows, P)
|
|
188
|
+
const d = createRowDrag(ctx)
|
|
189
|
+
|
|
190
|
+
d.onRowDragStart(fakeEvent(), 0)
|
|
191
|
+
d.onRowDragOver(fakeEvent(30, 0, 40), 1)
|
|
192
|
+
expect(ctx.rowDropIndex).toBe(1)
|
|
193
|
+
|
|
194
|
+
// Virtualization unmounts row 1 from under the pointer, firing its leave.
|
|
195
|
+
d.onRowDragLeave(1)
|
|
196
|
+
|
|
197
|
+
// THIS is the bug: the replacement row has not fired `dragover` yet, and a
|
|
198
|
+
// synchronous clear leaves the user with no indicator and no drop target in
|
|
199
|
+
// the meantime. The indicator must survive the gap.
|
|
200
|
+
expect(ctx.rowDropIndex).toBe(1)
|
|
201
|
+
expect(ctx.rowDropSide).not.toBeNull()
|
|
202
|
+
|
|
203
|
+
// The row scrolled into its place then takes over on the next frame.
|
|
204
|
+
d.onRowDragOver(fakeEvent(30, 0, 40), 2)
|
|
205
|
+
await nextFrame()
|
|
206
|
+
await nextFrame()
|
|
207
|
+
expect(ctx.rowDropIndex).toBe(2)
|
|
208
|
+
expect(ctx.rowDropSide).not.toBeNull()
|
|
209
|
+
})
|
|
210
|
+
|
|
211
|
+
it('still clears once the pointer genuinely leaves the rows', async () => {
|
|
212
|
+
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
213
|
+
const d = createRowDrag(ctx)
|
|
214
|
+
|
|
215
|
+
d.onRowDragStart(fakeEvent(), 0)
|
|
216
|
+
d.onRowDragOver(fakeEvent(30, 0, 40), 1)
|
|
217
|
+
expect(ctx.rowDropIndex).toBe(1)
|
|
218
|
+
|
|
219
|
+
d.onRowDragLeave(1)
|
|
220
|
+
// No dragover follows - the deferral must not turn into a stuck indicator.
|
|
221
|
+
await nextFrame()
|
|
222
|
+
await nextFrame()
|
|
223
|
+
expect(ctx.rowDropIndex).toBeNull()
|
|
224
|
+
expect(ctx.rowDropSide).toBeNull()
|
|
225
|
+
})
|
|
226
|
+
|
|
227
|
+
it('does not write indicator state after the grid is destroyed', async () => {
|
|
228
|
+
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
229
|
+
const d = createRowDrag(ctx)
|
|
230
|
+
|
|
231
|
+
d.onRowDragStart(fakeEvent(), 0)
|
|
232
|
+
d.onRowDragOver(fakeEvent(30, 0, 40), 1)
|
|
233
|
+
d.onRowDragLeave(1)
|
|
234
|
+
d.destroyRowDrag()
|
|
235
|
+
ctx.rowDropIndex = 'sentinel'
|
|
236
|
+
|
|
237
|
+
await nextFrame()
|
|
238
|
+
await nextFrame()
|
|
239
|
+
// A frame that survived teardown would have nulled this.
|
|
240
|
+
expect(ctx.rowDropIndex).toBe('sentinel')
|
|
241
|
+
})
|
|
242
|
+
})
|
|
243
|
+
|
|
244
|
+
/**
|
|
245
|
+
* #66 - row drag was dead on touch: the whole feature rode on HTML5 DragEvent,
|
|
246
|
+
* which iOS Safari and Android Chrome never fire for touch input.
|
|
247
|
+
*
|
|
248
|
+
* The pointer path is a second INPUT onto the same model, so these tests drive
|
|
249
|
+
* the real handlers and assert on the same `bus` / indicator state the mouse
|
|
250
|
+
* path uses, then check the reorder actually happened.
|
|
251
|
+
*/
|
|
252
|
+
describe('createRowDrag - touch (#66)', () => {
|
|
253
|
+
const wait = (ms: number) => new Promise((r) => setTimeout(r, ms))
|
|
254
|
+
|
|
255
|
+
// `stubRowAt` replaces a global. Without restoring it, every later test in
|
|
256
|
+
// the worker inherits a fake elementFromPoint - which showed up as an
|
|
257
|
+
// intermittent failure elsewhere in the suite, not here.
|
|
258
|
+
const realElementFromPoint = document.elementFromPoint
|
|
259
|
+
afterEach(() => {
|
|
260
|
+
;(document as any).elementFromPoint = realElementFromPoint
|
|
261
|
+
})
|
|
262
|
+
|
|
263
|
+
function pointer(type: string, clientY: number, extra: AnyCtx = {}): any {
|
|
264
|
+
return {
|
|
265
|
+
pointerId: 1,
|
|
266
|
+
pointerType: type,
|
|
267
|
+
clientX: 10,
|
|
268
|
+
clientY,
|
|
269
|
+
preventDefault: vi.fn(),
|
|
270
|
+
currentTarget: { setPointerCapture: vi.fn(), closest: () => null },
|
|
271
|
+
...extra,
|
|
272
|
+
}
|
|
273
|
+
}
|
|
274
|
+
|
|
275
|
+
/** Put row `index` under the pointer, the way elementFromPoint would. */
|
|
276
|
+
function stubRowAt(index: number, top: number, height = 40) {
|
|
277
|
+
const marker = { dataset: { svgridRow: String(index) } }
|
|
278
|
+
const tr = {
|
|
279
|
+
querySelector: () => marker,
|
|
280
|
+
getBoundingClientRect: () => ({ top, height, bottom: top + height }),
|
|
281
|
+
}
|
|
282
|
+
;(document as any).elementFromPoint = () => ({ closest: (s: string) => (s === 'tr.sv-grid-row' ? tr : null) })
|
|
283
|
+
}
|
|
284
|
+
|
|
285
|
+
it('ignores mouse and pen so the HTML5 path keeps owning them', () => {
|
|
286
|
+
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
287
|
+
const d = createRowDrag(ctx)
|
|
288
|
+
d.onRowPointerDown(pointer('mouse', 10), 0)
|
|
289
|
+
d.onRowPointerDown(pointer('pen', 10), 0)
|
|
290
|
+
expect(ctx.rowDragActive).toBe(false)
|
|
291
|
+
})
|
|
292
|
+
|
|
293
|
+
it('does not start until the long press elapses', async () => {
|
|
294
|
+
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
295
|
+
const d = createRowDrag(ctx)
|
|
296
|
+
d.onRowPointerDown(pointer('touch', 10), 0)
|
|
297
|
+
expect(ctx.rowDragActive).toBe(false)
|
|
298
|
+
await wait(400)
|
|
299
|
+
expect(ctx.rowDragActive).toBe(true)
|
|
300
|
+
d.destroyRowDrag()
|
|
301
|
+
})
|
|
302
|
+
|
|
303
|
+
it('treats an early move as a scroll and never starts the drag', async () => {
|
|
304
|
+
const ctx = makeCtx([{ id: 1, title: 'a' }, { id: 2, title: 'b' }], P)
|
|
305
|
+
const d = createRowDrag(ctx)
|
|
306
|
+
d.onRowPointerDown(pointer('touch', 10), 0)
|
|
307
|
+
window.dispatchEvent(Object.assign(new Event('pointermove'), {
|
|
308
|
+
pointerId: 1, clientX: 10, clientY: 60, preventDefault() {},
|
|
309
|
+
}))
|
|
310
|
+
await wait(400)
|
|
311
|
+
expect(ctx.rowDragActive).toBe(false)
|
|
312
|
+
d.destroyRowDrag()
|
|
313
|
+
})
|
|
314
|
+
|
|
315
|
+
it('reorders on lift, through the same commit as the mouse path', async () => {
|
|
316
|
+
const rows: Task[] = [
|
|
317
|
+
{ id: 1, title: 'a' },
|
|
318
|
+
{ id: 2, title: 'b' },
|
|
319
|
+
{ id: 3, title: 'c' },
|
|
320
|
+
]
|
|
321
|
+
const onRowDragEnd = vi.fn()
|
|
322
|
+
const ctx = makeCtx(rows, { ...P, onRowDragEnd })
|
|
323
|
+
const d = createRowDrag(ctx)
|
|
324
|
+
|
|
325
|
+
d.onRowPointerDown(pointer('touch', 10), 0)
|
|
326
|
+
await wait(400)
|
|
327
|
+
expect(ctx.rowDragActive).toBe(true)
|
|
328
|
+
|
|
329
|
+
// Finger moves over the lower half of row 2.
|
|
330
|
+
stubRowAt(2, 80, 40)
|
|
331
|
+
window.dispatchEvent(Object.assign(new Event('pointermove'), {
|
|
332
|
+
pointerId: 1, clientX: 10, clientY: 115, preventDefault() {},
|
|
333
|
+
}))
|
|
334
|
+
expect(ctx.rowDropIndex).toBe(2)
|
|
335
|
+
expect(ctx.rowDropSide).toBe('after')
|
|
336
|
+
|
|
337
|
+
window.dispatchEvent(Object.assign(new Event('pointerup'), { pointerId: 1, clientY: 115 }))
|
|
338
|
+
expect((ctx.internalData as Task[]).map((r) => r.id)).toEqual([2, 3, 1])
|
|
339
|
+
expect(onRowDragEnd).toHaveBeenCalledTimes(1)
|
|
340
|
+
expect(ctx.rowDragActive).toBe(false)
|
|
341
|
+
})
|
|
342
|
+
|
|
343
|
+
it('cancels without reordering on pointercancel', async () => {
|
|
344
|
+
const rows: Task[] = [{ id: 1, title: 'a' }, { id: 2, title: 'b' }]
|
|
345
|
+
const ctx = makeCtx(rows, P)
|
|
346
|
+
const d = createRowDrag(ctx)
|
|
347
|
+
d.onRowPointerDown(pointer('touch', 10), 0)
|
|
348
|
+
await wait(400)
|
|
349
|
+
window.dispatchEvent(Object.assign(new Event('pointercancel'), { pointerId: 1 }))
|
|
350
|
+
expect((ctx.internalData as Task[]).map((r) => r.id)).toEqual([1, 2])
|
|
351
|
+
expect(ctx.rowDragActive).toBe(false)
|
|
352
|
+
})
|
|
353
|
+
})
|