@svgrid/grid 2.2.32 → 2.2.34

package/src/chart.ts

@@ -38,7 +38,6 @@ export type SeriesOverlay = 'linear' | `sma:${number}` | `ema:${number}`
 export type SeriesPattern = 'solid' | 'stripe' | 'crosshatch' | 'dots' | 'diagonal'
 /** Cycle used when `ChartSpec.patternFallback` is true and a series has no
  *  explicit `pattern` set. Skips `'solid'` so every series gets a texture. */
-const PATTERN_CYCLE: SeriesPattern[] = ['stripe', 'crosshatch', 'dots', 'diagonal']
 
 export type ChartSeries = {
   label: string
@@ -2254,7 +2253,7 @@ export function rowsToChartSpec<T extends Record<string, unknown>>(
     entries.reduce((sum, e) => sum + (Number.isFinite(e.values[i]!) ? e.values[i]! : 0), 0),
   )
   const sort = opts.sort ?? (opts.topN ? 'value-desc' : 'none')
-  let order = categories.map((_, i) => i)
+  const order = categories.map((_, i) => i)
   if (sort === 'value-desc') order.sort((a, b) => totals[b]! - totals[a]!)
   else if (sort === 'value-asc') order.sort((a, b) => totals[a]! - totals[b]!)
   else if (sort === 'category') order.sort((a, b) => categories[a]!.localeCompare(categories[b]!))

package/src/clipboard.ts

@@ -2,122 +2,20 @@
 // that read/write controller state via the `ctx` handle; the reactive core
 // ($state/$derived/$effect) stays in the controller.
 import {
-  applyExcelFilter,
-  normalizeForFilter,
-  createColumnVirtualizer,
-  createCoreRowModel,
-  createExpandedRowModel,
-  createFilteredRowModel,
-  createGroupedRowModel,
-  createPaginatedRowModel,
-  createSvelteVirtualizer,
-  createSortedRowModel,
-  createSvGrid,
-  filterFns,
-  getGridCellA11yProps,
-  getGridCellDomId,
-  getGridHeaderA11yProps,
-  getGridRootA11yProps,
-  getGridRowA11yProps,
   parseEditorValue,
-  normalizeEditorOptions,
-  sortFns,
-  tableFeatures,
-  rowSortingFeature,
-  columnFilteringFeature,
-  columnGroupingFeature,
-  type CellContext,
-  type EditorContext,
-  type CellEditorOption,
   type CellEditorType,
-  type CellFormatter,
-  type CellFormatConfig,
-  type Column,
-  type ColumnDef,
-  type Row,
   type RowData,
-  type SvGridApi,
   type TableFeatures,
 } from "./index";
 import "./sv-grid-scrollbar";
-import type { Snippet } from "svelte";
-import { getKeyboardIntent, getNextActiveCell } from "./keyboard";
-import {
-  formatNumericWithConfig,
-  getDateFormatter,
-  resolveDatePattern,
-} from "./cell-formatting";
-import {
-  RenderSnippetConfig,
-  RenderComponentConfig,
-} from "./render-component";
 import { buildFillPattern } from "./fill-patterns";
-import { buildSparkline, toSparklineValues } from "./sparkline";
-import {
-  resolveCellFormat,
-  computeColumnStat,
-  formatsNeedingStats,
-  type ColumnStat,
-  type ResolvedCellFormat,
-} from "./conditional-formatting";
-import SvGridDropdown from "./SvGridDropdown.svelte";
-import type {
-  Props,
-  SelectionPoint,
-  SelectionRange,
-  CellEditState,
-  FilterOperator,
-  FilterOption,
-  MenuPosition,
-} from "./SvGrid.types";
 import {
-  cfTextStyle,
-  fmtStat,
   getCellKey,
-  resolveClassList,
-  toDateInputValue,
-  toDateTimeLocalInputValue,
-  getEditableInputValue,
-  getEditorInputType,
-  toValueArray,
-  getOptionLabel,
-  getOptionColor,
-  colorfulChipStyle,
-  getEditorClass,
-  asDate,
-  clampMenuX,
-  cssEscape,
-  rawToNumber,
-  formatFacetNumber,
-  formatFacetDate,
 } from "./SvGrid.helpers";
-import {
-  filterOperatorOptions,
-  fallbackOperatorOption,
-  TEXT_OPERATORS,
-  NUMBER_OPERATORS,
-  DATE_OPERATORS,
-  CHECKBOX_OPERATORS,
-  operatorOption,
-  operatorsForColumn,
-  defaultOperatorFor,
-  operatorLabelFor,
-} from "./filter-operators";
-import {
-  type FacetBucket,
-  isBucketableColumn,
-  buildBuckets,
-  isInBucket,
-} from "./facet-buckets";
 import {
   getColumnBaseValue,
   isGroupRow,
   toolPanelHeaderLabel,
-  formatSummaryNumeric,
-  getColumnAlign,
-  getPinnedCellValue,
-  getColumnAccessorValue,
-  columnDefMatchesId,
 } from "./cell-values";
 
 export function createClipboard<

package/src/columns.ts

@@ -2,125 +2,10 @@
 // reading/writing controller state via the `ctx` handle; the reactive core
 // ($state/$derived/$effect) stays in the controller.
 import {
-  applyExcelFilter,
-  normalizeForFilter,
-  createColumnVirtualizer,
-  createCoreRowModel,
-  createExpandedRowModel,
-  createFilteredRowModel,
-  createGroupedRowModel,
-  createPaginatedRowModel,
-  createSvelteVirtualizer,
-  createSortedRowModel,
-  createSvGrid,
-  filterFns,
-  getGridCellA11yProps,
-  getGridCellDomId,
-  getGridHeaderA11yProps,
-  getGridRootA11yProps,
-  getGridRowA11yProps,
-  parseEditorValue,
-  normalizeEditorOptions,
-  sortFns,
-  tableFeatures,
-  rowSortingFeature,
-  columnFilteringFeature,
-  columnGroupingFeature,
-  type CellContext,
-  type EditorContext,
-  type CellEditorOption,
-  type CellEditorType,
-  type CellFormatter,
-  type CellFormatConfig,
-  type Column,
-  type ColumnDef,
-  type Row,
   type RowData,
-  type SvGridApi,
   type TableFeatures,
 } from "./index";
 import "./sv-grid-scrollbar";
-import type { Snippet } from "svelte";
-import { getKeyboardIntent, getNextActiveCell } from "./keyboard";
-import {
-  formatNumericWithConfig,
-  getDateFormatter,
-  resolveDatePattern,
-} from "./cell-formatting";
-import {
-  RenderSnippetConfig,
-  RenderComponentConfig,
-} from "./render-component";
-import { buildFillPattern } from "./fill-patterns";
-import { buildSparkline, toSparklineValues } from "./sparkline";
-import {
-  resolveCellFormat,
-  computeColumnStat,
-  formatsNeedingStats,
-  type ColumnStat,
-  type ResolvedCellFormat,
-} from "./conditional-formatting";
-import SvGridDropdown from "./SvGridDropdown.svelte";
-import type {
-  Props,
-  SelectionPoint,
-  SelectionRange,
-  CellEditState,
-  FilterOperator,
-  FilterOption,
-  MenuPosition,
-} from "./SvGrid.types";
-import {
-  cfTextStyle,
-  fmtStat,
-  getCellKey,
-  resolveClassList,
-  toDateInputValue,
-  toDateTimeLocalInputValue,
-  getEditableInputValue,
-  getEditorInputType,
-  toValueArray,
-  getOptionLabel,
-  getOptionColor,
-  colorfulChipStyle,
-  getEditorClass,
-  asDate,
-  clampMenuX,
-  cssEscape,
-  rawToNumber,
-  formatFacetNumber,
-  formatFacetDate,
-} from "./SvGrid.helpers";
-import { createGridApi } from "./build-api";
-import { createClipboard } from "./clipboard";
-import {
-  filterOperatorOptions,
-  fallbackOperatorOption,
-  TEXT_OPERATORS,
-  NUMBER_OPERATORS,
-  DATE_OPERATORS,
-  CHECKBOX_OPERATORS,
-  operatorOption,
-  operatorsForColumn,
-  defaultOperatorFor,
-  operatorLabelFor,
-} from "./filter-operators";
-import {
-  type FacetBucket,
-  isBucketableColumn,
-  buildBuckets,
-  isInBucket,
-} from "./facet-buckets";
-import {
-  getColumnBaseValue,
-  isGroupRow,
-  toolPanelHeaderLabel,
-  formatSummaryNumeric,
-  getColumnAlign,
-  getPinnedCellValue,
-  getColumnAccessorValue,
-  columnDefMatchesId,
-} from "./cell-values";
 
 export function createColumns<
   TFeatures extends TableFeatures = TableFeatures,
@@ -186,13 +71,18 @@ export function createColumns<
     if (!(ctx.props.enableColumnReorder ?? false)) return;
     ctx.colDragId = columnId;
     e.dataTransfer?.setData("text/plain", columnId);
-    e.dataTransfer!.effectAllowed = "move";
+    // Guarded, not asserted: `dataTransfer` is non-null in a real browser drag
+    // but null on a synthetic DragEvent. The `!` threw there, and because the
+    // throw landed after `colDragId` was set but before `colDropSide` was, the
+    // drop then silently no-op'd instead of surfacing the error. Matches the
+    // pattern row-drag.ts already uses.
+    if (e.dataTransfer) e.dataTransfer.effectAllowed = "move";
   }
 
   function onColumnHeaderDragOver(e: DragEvent, columnId: string) {
     if (!ctx.colDragId || ctx.colDragId === columnId) return;
     e.preventDefault();
-    e.dataTransfer!.dropEffect = "move";
+    if (e.dataTransfer) e.dataTransfer.dropEffect = "move";
     const rect = (e.currentTarget as HTMLElement).getBoundingClientRect();
     ctx.colDropSide = e.clientX < rect.left + rect.width / 2 ? "before" : "after";
     ctx.colDropOnId = columnId;

package/src/createMenu.svelte.ts

@@ -66,7 +66,6 @@ export type MenuItemProps = {
   onclick: () => void
 }
 
-let uid = 0
 
 export function createMenu(config: MenuConfig) {
   const items = () => config.items()

package/src/editing.ts

@@ -2,126 +2,23 @@
 // reading/writing controller state via the `ctx` handle; the reactive core
 // ($state/$derived/$effect) stays in the controller.
 import {
-  applyExcelFilter,
-  normalizeForFilter,
-  createColumnVirtualizer,
-  createCoreRowModel,
-  createExpandedRowModel,
-  createFilteredRowModel,
-  createGroupedRowModel,
-  createPaginatedRowModel,
-  createSvelteVirtualizer,
-  createSortedRowModel,
-  createSvGrid,
-  filterFns,
-  getGridCellA11yProps,
-  getGridCellDomId,
-  getGridHeaderA11yProps,
-  getGridRootA11yProps,
-  getGridRowA11yProps,
   parseEditorValue,
-  normalizeEditorOptions,
-  sortFns,
-  tableFeatures,
-  rowSortingFeature,
-  columnFilteringFeature,
-  columnGroupingFeature,
   type CellContext,
-  type EditorContext,
-  type CellEditorOption,
   type CellEditorType,
-  type CellFormatter,
-  type CellFormatConfig,
   type Column,
-  type ColumnDef,
   type Row,
   type RowData,
-  type SvGridApi,
   type TableFeatures,
 } from "./index";
 import "./sv-grid-scrollbar";
-import type { Snippet } from "svelte";
-import { getKeyboardIntent, getNextActiveCell } from "./keyboard";
+import { getNextActiveCell } from "./keyboard";
 import {
-  formatNumericWithConfig,
-  getDateFormatter,
-  resolveDatePattern,
-} from "./cell-formatting";
-import {
-  RenderSnippetConfig,
-  RenderComponentConfig,
-} from "./render-component";
-import { buildFillPattern } from "./fill-patterns";
-import { buildSparkline, toSparklineValues } from "./sparkline";
-import {
-  resolveCellFormat,
-  computeColumnStat,
-  formatsNeedingStats,
-  type ColumnStat,
-  type ResolvedCellFormat,
-} from "./conditional-formatting";
-import SvGridDropdown from "./SvGridDropdown.svelte";
-import type {
-  Props,
-  SelectionPoint,
-  SelectionRange,
-  CellEditState,
-  FilterOperator,
-  FilterOption,
-  MenuPosition,
-} from "./SvGrid.types";
-import {
-  cfTextStyle,
-  fmtStat,
   getCellKey,
-  resolveClassList,
-  toDateInputValue,
-  toDateTimeLocalInputValue,
-  getEditableInputValue,
-  getEditorInputType,
   toValueArray,
-  getOptionLabel,
-  getOptionColor,
-  colorfulChipStyle,
-  getEditorClass,
-  asDate,
-  clampMenuX,
-  cssEscape,
-  rawToNumber,
-  formatFacetNumber,
-  formatFacetDate,
 } from "./SvGrid.helpers";
-import { createSelection } from "./selection";
-import { createColumns } from "./columns";
-import { createGridApi } from "./build-api";
-import { createClipboard } from "./clipboard";
-import {
-  filterOperatorOptions,
-  fallbackOperatorOption,
-  TEXT_OPERATORS,
-  NUMBER_OPERATORS,
-  DATE_OPERATORS,
-  CHECKBOX_OPERATORS,
-  operatorOption,
-  operatorsForColumn,
-  defaultOperatorFor,
-  operatorLabelFor,
-} from "./filter-operators";
-import {
-  type FacetBucket,
-  isBucketableColumn,
-  buildBuckets,
-  isInBucket,
-} from "./facet-buckets";
 import {
   getColumnBaseValue,
   isGroupRow,
-  toolPanelHeaderLabel,
-  formatSummaryNumeric,
-  getColumnAlign,
-  getPinnedCellValue,
-  getColumnAccessorValue,
-  columnDefMatchesId,
 } from "./cell-values";
 
 type HistoryStep = {
@@ -224,7 +121,7 @@ export function createEditing<
     ) {
       return false;
     }
-    if (editorType === "number" && !/[0-9.+\-]/.test(char)) return false;
+    if (editorType === "number" && !/[0-9.+-]/.test(char)) return false;
     ctx.editorSelectAll = false;
     ctx.editingCell = {
       rowId: row.id,

package/src/editor-registry.grid.test.ts

@@ -73,7 +73,6 @@ afterEach(() => {
 
 describe('registry wiring in SvGrid', () => {
   it('mounts a registered component when a custom-editorType cell edits', async () => {
-    let committed: unknown = undefined
     registerCellEditor('stars', {
       component: SvRating,
       props: (ctx) => ({
@@ -90,7 +89,6 @@ describe('registry wiring in SvGrid', () => {
       // The registered SvRating editor is mounted in the editing overlay.
       const rating = target.querySelector('.sv-rating')
       expect(rating).not.toBeNull()
-      void committed
     } finally {
       destroy()
     }

package/src/export-format.ts

@@ -521,6 +521,9 @@ const XML_ESCAPE: Record<string, string> = {
 }
 function xmlText(value: unknown): string {
   const s = value == null ? '' : value instanceof Date ? value.toISOString() : String(value)
+  // Stripping control characters is the point: XML 1.0 forbids them outright,
+  // so a stray \x00 from a data source would produce an unopenable file.
+  // eslint-disable-next-line no-control-regex
   return s.replace(/[\x00-\x08\x0B\x0C\x0E-\x1F]/g, '').replace(/[&<>"']/g, (c) => XML_ESCAPE[c]!)
 }
 /** Coerce a field name into a valid XML element name. */

package/src/features.ts

@@ -2,104 +2,14 @@
 // reading/writing controller state via the `ctx` handle; the reactive core
 // ($state/$derived/$effect) stays in the controller.
 import {
-    applyExcelFilter,
-    normalizeForFilter,
-    createColumnVirtualizer,
-    createCoreRowModel,
-    createExpandedRowModel,
-    createFilteredRowModel,
-    createGroupedRowModel,
-    createSvelteVirtualizer,
-    createSortedRowModel,
-    createSvGrid,
-    getGridCellDomId,
-    sortFns,
     tableFeatures,
     rowSortingFeature,
     columnFilteringFeature,
     columnGroupingFeature,
-    type CellEditorOption,
-    type Column,
-    type ColumnDef,
-    type Row,
     type RowData,
     type TableFeatures,
   } from "./index";
 import "./sv-grid-scrollbar";
-import {
-    computeColumnStat,
-    formatsNeedingStats,
-    type ColumnStat,
-  } from "./conditional-formatting";
-import SvGridDropdown from "./SvGridDropdown.svelte";
-import type {
-    Props,
-    SelectionRange,
-    CellEditState,
-    FilterOperator,
-    MenuPosition,
-  } from "./SvGrid.types";
-import {
-    rawToNumber,
-  } from "./SvGrid.helpers";
-import {
-    createScrollSync,
-  } from "./scroll-sync";
-import {
-    createKeyboard,
-  } from "./keyboard-handlers";
-import {
-    createSummaries,
-  } from "./summaries";
-import {
-    createMenus,
-  } from "./menus";
-import {
-    createCellRender,
-  } from "./cell-render";
-import {
-    createEditing,
-  } from "./editing";
-import {
-    createSelection,
-  } from "./selection";
-import {
-    createColumns,
-  } from "./columns";
-import {
-    createGridApi,
-  } from "./build-api";
-import {
-    createClipboard,
-  } from "./clipboard";
-import {
-    filterOperatorOptions,
-    fallbackOperatorOption,
-    TEXT_OPERATORS,
-    NUMBER_OPERATORS,
-    DATE_OPERATORS,
-    CHECKBOX_OPERATORS,
-    operatorOption,
-    operatorsForColumn,
-    defaultOperatorFor,
-    operatorLabelFor,
-  } from "./filter-operators";
-import {
-    type FacetBucket,
-    isBucketableColumn,
-    buildBuckets,
-    isInBucket,
-  } from "./facet-buckets";
-import {
-    getColumnBaseValue,
-    isGroupRow,
-    toolPanelHeaderLabel,
-    formatSummaryNumeric,
-    getColumnAlign,
-    getPinnedCellValue,
-    getColumnAccessorValue,
-    columnDefMatchesId,
-  } from "./cell-values";
 
 export function createFeatures<
   TFeatures extends TableFeatures = TableFeatures,

package/src/keyboard-handlers.coverage.test.ts

@@ -1,4 +1,4 @@
-import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { describe, expect, it, vi } from 'vitest'
 import { createKeyboard } from './keyboard-handlers'
 
 // createKeyboard returns imperative handlers that read/write a controller

package/src/keyboard-handlers.ts

@@ -2,130 +2,10 @@
 // reading/writing controller state via the `ctx` handle; the reactive core
 // ($state/$derived/$effect) stays in the controller.
 import {
-  applyExcelFilter,
-  normalizeForFilter,
-  createColumnVirtualizer,
-  createCoreRowModel,
-  createExpandedRowModel,
-  createFilteredRowModel,
-  createGroupedRowModel,
-  createPaginatedRowModel,
-  createSvelteVirtualizer,
-  createSortedRowModel,
-  createSvGrid,
-  filterFns,
-  getGridCellA11yProps,
-  getGridCellDomId,
-  getGridHeaderA11yProps,
-  getGridRootA11yProps,
-  getGridRowA11yProps,
-  parseEditorValue,
-  normalizeEditorOptions,
-  sortFns,
-  tableFeatures,
-  rowSortingFeature,
-  columnFilteringFeature,
-  columnGroupingFeature,
-  type CellContext,
-  type EditorContext,
-  type CellEditorOption,
-  type CellEditorType,
-  type CellFormatter,
-  type CellFormatConfig,
-  type Column,
-  type ColumnDef,
-  type Row,
   type RowData,
-  type SvGridApi,
   type TableFeatures,
 } from "./index";
 import "./sv-grid-scrollbar";
-import type { Snippet } from "svelte";
-import {
-  formatNumericWithConfig,
-  getDateFormatter,
-  resolveDatePattern,
-} from "./cell-formatting";
-import {
-  RenderSnippetConfig,
-  RenderComponentConfig,
-} from "./render-component";
-import { buildFillPattern } from "./fill-patterns";
-import { buildSparkline, toSparklineValues } from "./sparkline";
-import {
-  resolveCellFormat,
-  computeColumnStat,
-  formatsNeedingStats,
-  type ColumnStat,
-  type ResolvedCellFormat,
-} from "./conditional-formatting";
-import SvGridDropdown from "./SvGridDropdown.svelte";
-import type {
-  Props,
-  SelectionPoint,
-  SelectionRange,
-  CellEditState,
-  FilterOperator,
-  FilterOption,
-  MenuPosition,
-} from "./SvGrid.types";
-import {
-  cfTextStyle,
-  fmtStat,
-  getCellKey,
-  resolveClassList,
-  toDateInputValue,
-  toDateTimeLocalInputValue,
-  getEditableInputValue,
-  getEditorInputType,
-  toValueArray,
-  getOptionLabel,
-  getOptionColor,
-  colorfulChipStyle,
-  getEditorClass,
-  asDate,
-  clampMenuX,
-  cssEscape,
-  rawToNumber,
-  formatFacetNumber,
-  formatFacetDate,
-} from "./SvGrid.helpers";
-import { createSummaries } from "./summaries";
-import { createMenus } from "./menus";
-import { createCellRender } from "./cell-render";
-import { createEditing } from "./editing";
-import { createSelection } from "./selection";
-import { createColumns } from "./columns";
-import { createGridApi } from "./build-api";
-import { createClipboard } from "./clipboard";
-import {
-  filterOperatorOptions,
-  fallbackOperatorOption,
-  TEXT_OPERATORS,
-  NUMBER_OPERATORS,
-  DATE_OPERATORS,
-  CHECKBOX_OPERATORS,
-  operatorOption,
-  operatorsForColumn,
-  defaultOperatorFor,
-  operatorLabelFor,
-} from "./filter-operators";
-import {
-  type FacetBucket,
-  isBucketableColumn,
-  buildBuckets,
-  isInBucket,
-} from "./facet-buckets";
-import {
-  getColumnBaseValue,
-  isGroupRow,
-  toolPanelHeaderLabel,
-  formatSummaryNumeric,
-  getColumnAlign,
-  getPinnedCellValue,
-  getColumnAccessorValue,
-  columnDefMatchesId,
-} from "./cell-values";
 
 import { getKeyboardIntent, getNextActiveCell } from "./keyboard";
 

package/src/menus.test.ts

@@ -597,7 +597,6 @@ describe('createMenus - contextMenuItems', () => {
       internalData: [rowA, rowB],
       contextMenuFor: { rowIndex: 1, colIndex: 0, columnId: 'name', rowId: 'r1', row: rowB },
     }))
-    const ctx2 = (m2 as any)
     const removeItem = m2.contextMenuItems().find((i) => i.key === 'remove_row')!
     removeItem.run!()
   })