@sveltejs/vite-plugin-svelte 6.1.4 → 6.2.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sveltejs/vite-plugin-svelte",
-  "version": "6.1.4",
+  "version": "6.2.1",
   "license": "MIT",
   "author": "dominikg",
   "files": [

package/src/utils/log.js

@@ -1,5 +1,6 @@
 /* eslint-disable no-console */
 
+// eslint-disable-next-line n/no-unsupported-features/node-builtins
 import { styleText } from 'node:util';
 const cyan = (/** @type {string} */ txt) => styleText('cyan', txt);
 const yellow = (/** @type {string} */ txt) => styleText('yellow', txt);
@@ -145,9 +146,7 @@ export function logCompilerWarnings(svelteRequest, warnings, options) {
 	let warn = isBuild ? warnBuild : warnDev;
 	/** @type {import('svelte/compiler').Warning[]} */
 	const handledByDefaultWarn = [];
-	const notIgnored = warnings?.filter((w) => !ignoreCompilerWarning(w, isBuild, emitCss));
-	const extra = buildExtraWarnings(warnings, isBuild);
-	const allWarnings = [...notIgnored, ...extra];
+	const allWarnings = warnings?.filter((w) => !ignoreCompilerWarning(w, isBuild, emitCss));
 	if (sendViaWS) {
 		const _warn = warn;
 		/** @type {(w: import('svelte/compiler').Warning) => void} */
@@ -202,31 +201,6 @@ function isNoScopableElementWarning(warning) {
 	return warning.code === 'css_unused_selector' && warning.message.includes('"*"');
 }
 
-/**
- *
- * @param {import('svelte/compiler').Warning[]} warnings
- * @param {boolean} isBuild
- * @returns {import('svelte/compiler').Warning[]}
- */
-function buildExtraWarnings(warnings, isBuild) {
-	const extraWarnings = [];
-	if (!isBuild) {
-		const noScopableElementWarnings = warnings.filter((w) => isNoScopableElementWarning(w));
-		if (noScopableElementWarnings.length > 0) {
-			// in case there are multiple, use last one as that is the one caused by our *{} rule
-			const noScopableElementWarning =
-				noScopableElementWarnings[noScopableElementWarnings.length - 1];
-			extraWarnings.push({
-				...noScopableElementWarning,
-				code: 'vite-plugin-svelte-css-no-scopable-elements',
-				message:
-					"No scopable elements found in template. If you're using global styles in the style tag, you should move it into an external stylesheet file and import it in JS. See https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#where-should-i-put-my-global-styles."
-			});
-		}
-	}
-	return extraWarnings;
-}
-
 /**
  * @param {import('svelte/compiler').Warning} w
  */

package/src/utils/options.js

@@ -6,7 +6,9 @@ const {
 	defaultClientConditions,
 	defaultServerConditions,
 	normalizePath,
-	searchForWorkspaceRoot
+	searchForWorkspaceRoot,
+	// @ts-ignore
+	rolldownVersion
 } = vite;
 import { log } from './log.js';
 import { loadSvelteConfig } from './load-svelte-config.js';
@@ -418,6 +420,20 @@ function validateViteConfig(extraViteConfig, config, options) {
 			);
 		}
 	}
+	if (rolldownVersion && isBuild) {
+		// read user config inlineConst value
+		const inlineConst =
+			//@ts-ignore optimization only exists in rolldown-vite
+			config.build?.rolldownOptions?.optimization?.inlineConst ??
+			//@ts-ignore optimization only exists in rolldown-vite
+			config.build?.rollupOptions?.optimization?.inlineConst;
+
+		if (inlineConst === false) {
+			log.warn(
+				'Your rolldown config contains `optimization.inlineConst: false`. This can lead to increased bundle size and leaked server code in client build.'
+			);
+		}
+	}
 }
 
 /**

package/src/utils/svelte-version.js

@@ -6,15 +6,34 @@ import { VERSION } from 'svelte/compiler';
 export const isSvelteWithAsync = gte(VERSION, '5.36.0');
 
 /**
- * compare semver versions, does not include comparing tags (-next.xy is ignored)
+ * split semver string and convert to number, ignores non digits in tag
+ * @param {string} semver
+ * @return {number[]} [major,minor,patch,tag]
+ */
+function splitToNumbers(semver) {
+	const num = semver
+		.replace(/[^\d.-]/g, '')
+		.split(/[.-]+/, 4)
+		.map(Number);
+	while (num.length < 3) {
+		num.push(0);
+	}
+	if (num.length < 4) {
+		num.push(Infinity);
+	}
+	return num;
+}
+
+/**
+ * compare semver versions, tags are compared by their numeric part only
  *
  * @param {string} a semver version
  * @param {string} b semver version
  * @return {boolean} true if a is greater or equal to b
  */
 export function gte(a, b) {
-	const aNum = a.split(/[.-]/, 3).map(Number);
-	const bNum = b.split(/[.-]/, 3).map(Number);
+	const aNum = splitToNumbers(a);
+	const bNum = splitToNumbers(b);
 	for (let i = 0; i < aNum.length; i++) {
 		if (aNum[i] < bNum[i]) {
 			return false;