@sveltejs/kit 3.0.0-next.1 → 3.0.0-next.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sveltejs/kit",
-  "version": "3.0.0-next.1",
+  "version": "3.0.0-next.3",
   "description": "SvelteKit is the fastest way to build Svelte apps",
   "keywords": [
     "framework",
@@ -37,7 +37,7 @@
     "dts-buddy": "^0.8.0",
     "jsdom": "^29.1.1",
     "rolldown": "^1.0.0-rc.6",
-    "svelte": "^5.55.7",
+    "svelte": "^5.56.3",
     "svelte-preprocess": "^6.0.5",
     "typescript": "~6.0.0",
     "vite": "^8.0.10",

package/src/core/postbuild/analyse.js

@@ -10,7 +10,6 @@ import { has_server_load, resolve_route } from '../../utils/routing.js';
 import { check_feature } from '../../utils/features.js';
 import { createReadableStream } from '@sveltejs/kit/node';
 import { PageNodes } from '../../utils/page_nodes.js';
-import { build_server_nodes } from '../../exports/vite/build/build_server.js';
 
 export default forked(import.meta.url, analyse);
 
@@ -22,9 +21,7 @@ export default forked(import.meta.url, analyse);
  *   server_manifest: import('vite').Manifest;
  *   tracked_features: Record<string, string[]>;
  *   env: Record<string, string>;
- *   out: string;
  *   remotes: RemoteChunk[];
- *   root: string;
  *   vite_config_file: string | undefined;
  * }} opts
  */
@@ -35,9 +32,7 @@ async function analyse({
 	server_manifest,
 	tracked_features,
 	env,
-	out,
 	remotes,
-	root,
 	vite_config_file
 }) {
 	/** @type {import('@sveltejs/kit').SSRManifest} */
@@ -67,9 +62,6 @@ async function analyse({
 	internal.set_manifest(manifest);
 	internal.set_read_implementation((file) => createReadableStream(`${server_root}/server/${file}`));
 
-	// first, build server nodes without the client manifest so we can analyse it
-	build_server_nodes(out, config, manifest_data, server_manifest, null, null, null, root);
-
 	/** @type {import('types').ServerMetadata} */
 	const metadata = {
 		nodes: [],

package/src/core/postbuild/prerender.js

@@ -210,6 +210,8 @@ async function prerender({ hash, out, manifest_path, metadata, verbose, env, vit
 
 	const seen = new Set();
 	const written = new Set();
+
+	/** @type {Map<string, Promise<any>>} */
 	const remote_responses = new Map();
 
 	/** @type {Map<string, Set<string>>} */

package/src/core/sync/create_manifest_data/index.js

@@ -32,6 +32,7 @@ export default function create_manifest_data({
 	const matchers = create_matchers(config, cwd);
 	const { nodes, routes } = create_routes_and_nodes(cwd, config, fallback);
 
+	// validate matcher names used in parameterised routes
 	for (const route of routes) {
 		for (const param of route.params) {
 			if (param.matcher && !matchers[param.matcher]) {
@@ -50,6 +51,7 @@ export default function create_manifest_data({
 }
 
 /**
+ * Returns a list of files in the `static` directory.
  * @param {import('types').ValidatedConfig} config
  */
 export function create_assets(config) {
@@ -130,6 +132,7 @@ function create_routes_and_nodes(cwd, config, fallback) {
 	/** @type {import('types').PageNode[]} */
 	const nodes = [];
 
+	// create route data by processing files in `src/routes`
 	if (fs.existsSync(config.kit.files.routes)) {
 		/**
 		 * @param {number} depth
@@ -388,6 +391,7 @@ function create_routes_and_nodes(cwd, config, fallback) {
 
 	prevent_conflicts(routes);
 
+	// fallback root layout and root error components
 	const root = routes[0];
 
 	if (!root.layout?.component) {
@@ -396,10 +400,11 @@ function create_routes_and_nodes(cwd, config, fallback) {
 	}
 
 	if (!root.error?.component) {
-		if (!root.error) root.error = { depth: 0 };
+		if (!root.error) root.error = { depth: 0, parent: root.layout };
 		root.error.component = posixify(path.relative(cwd, `${fallback}/error.svelte`));
 	}
 
+	// populate the page nodes list
 	// we do layouts/errors first as they are more likely to be reused,
 	// and smaller indexes take fewer bytes. also, this guarantees that
 	// the default error/layout are 0/1
@@ -421,6 +426,7 @@ function create_routes_and_nodes(cwd, config, fallback) {
 
 	const node_analyser = create_node_analyser(cwd);
 
+	// add the related layout, page, and error nodes for a route
 	for (const route of routes) {
 		if (!route.leaf) continue;
 
@@ -465,6 +471,22 @@ function create_routes_and_nodes(cwd, config, fallback) {
 		}
 	}
 
+	// add parents to error nodes so that we can compute which page options apply to them
+	for (const route of routes) {
+		if (!route.error) continue;
+
+		/** @type {import('types').RouteData | null} */
+		let current_route = route;
+		while (current_route) {
+			if (current_route.layout) {
+				route.error.parent = current_route.layout;
+				break;
+			}
+			current_route = current_route.parent;
+		}
+	}
+
+	// compute the final page options for each page node
 	for (const node of nodes) {
 		node.page_options = node_analyser.get_page_options(node);
 	}
@@ -482,6 +504,7 @@ function create_routes_and_nodes(cwd, config, fallback) {
 }
 
 /**
+ * Determine if and how the file is relevant to the routing system.
  * @param {string} project_relative
  * @param {string} file
  * @param {string[]} component_extensions

package/src/core/sync/write_env.js

@@ -2,6 +2,7 @@
 import path from 'node:path';
 import { create_explicit_env_types } from '../env.js';
 import { write_if_changed } from './utils.js';
+import { posixify } from '../../utils/os.js';
 
 const DOCS = '// See https://svelte.dev/docs/kit/environment-variables for more information';
 
@@ -18,7 +19,7 @@ export function write_env(kit, entry, env_config) {
 	const out = path.join(kit.outDir, 'env.d.ts');
 
 	if (entry && env_config) {
-		const relative = path.relative(kit.outDir, entry);
+		const relative = posixify(path.relative(kit.outDir, entry));
 		content.push(
 			`// This file is generated from ${relative}.\n${DOCS}`,
 			create_explicit_env_types(env_config, relative, 'private'),

package/src/exports/internal/env.js

@@ -1,7 +1,7 @@
 /** @import { StandardSchemaV1 } from '@standard-schema/spec' */
 /** @import { EnvVarConfig } from '@sveltejs/kit' */
 
-import { stackless } from '../vite/utils.js';
+import { stackless } from '../../utils/error.js';
 
 const MISSING = {
 	message: `Value is missing. If it is optional, add a Standard Schema validator declaring it as such.`

package/src/exports/public.d.ts

@@ -1655,7 +1655,7 @@ export interface SSRManifest {
 
 	/** private fields */
 	_: {
-		client: NonNullable<BuildData['client']>;
+		client: BuildData['client'];
 		nodes: SSRNodeLoader[];
 		/** hashed filename -> import to that file */
 		remotes: Record<string, () => Promise<any>>;

package/src/exports/vite/build/build_server.js

@@ -16,39 +16,16 @@ import { fix_css_urls } from '../../../utils/css.js';
 import { escape_for_interpolation } from '../../../utils/escape.js';
 
 /**
- * @overload Build without the client manifest so we can analyse the nodes.
  * @param {string} out
  * @param {ValidatedKitConfig} kit
  * @param {ManifestData} manifest_data
  * @param {Manifest} server_manifest
- * @param {null} client_manifest
- * @param {null} assets_path
- * @param {null} client_chunks
- * @param {string} root
- * @returns {void}
- */
-/**
- * @overload Or build with the client manifest
- * @param {string} out
- * @param {ValidatedKitConfig} kit
- * @param {ManifestData} manifest_data
- * @param {Manifest} server_manifest
- * @param {Manifest} client_manifest
+ * @param {Manifest | null} client_manifest
  * @param {string} assets_path
- * @param {Rolldown.RolldownOutput['output']} client_chunks
+ * @param {(Rolldown.OutputAsset | Rolldown.OutputChunk)[]} chunks
  * @param {string} root
  * @returns {void}
  */
-/**
- * @param {string} out
- * @param {ValidatedKitConfig} kit
- * @param {ManifestData} manifest_data
- * @param {Manifest} server_manifest
- * @param {Manifest | null} client_manifest
- * @param {string | null} assets_path
- * @param {Rolldown.RolldownOutput['output'] | null} client_chunks
- * @param {string} root
- */
 export function build_server_nodes(
 	out,
 	kit,
@@ -56,7 +33,7 @@ export function build_server_nodes(
 	server_manifest,
 	client_manifest,
 	assets_path,
-	client_chunks,
+	chunks,
 	root
 ) {
 	mkdirp(`${out}/server/nodes`);
@@ -75,8 +52,8 @@ export function build_server_nodes(
 	 */
 	let prepare_css_for_inlining = (css) => s(css);
 
-	if (client_chunks && kit.inlineStyleThreshold > 0 && kit.output.bundleStrategy === 'split') {
-		for (const chunk of client_chunks) {
+	if (chunks && kit.inlineStyleThreshold > 0 && kit.output.bundleStrategy === 'split') {
+		for (const chunk of chunks) {
 			if (chunk.type !== 'asset' || !chunk.fileName.endsWith('.css')) {
 				continue;
 			}
@@ -132,6 +109,9 @@ export function build_server_nodes(
 		}
 	}
 
+	/** path to the `.svelte-kit` directory */
+	const out_dir = normalizePath(kit.outDir);
+
 	for (let i = 0; i < manifest_data.nodes.length; i++) {
 		const node = manifest_data.nodes[i];
 
@@ -155,7 +135,11 @@ export function build_server_nodes(
 		/** @type {Set<string>} */
 		const eager_assets = new Set();
 
-		if (node.component && client_manifest) {
+		const uses_server_component = node.child_pages
+			? node.child_pages.some((child) => child.page_options?.ssr !== false)
+			: node.page_options?.ssr !== false;
+
+		if (node.component && uses_server_component) {
 			exports.push(
 				'let component_cache;',
 				`export const component = async () => component_cache ??= (await import('../${
@@ -185,18 +169,7 @@ export function build_server_nodes(
 			exports.push(`export const server_id = ${s(node.server)};`);
 		}
 
-		if (
-			client_manifest &&
-			(node.universal || node.component) &&
-			kit.output.bundleStrategy === 'split'
-		) {
-			const entry_path = `${normalizePath(kit.outDir)}/generated/client-optimized/nodes/${i}.js`;
-			const entry = find_deps(client_manifest, entry_path, true, root);
-
-			// Eagerly load client stylesheets and fonts imported by the SSR-ed page to avoid FOUC.
-			// However, if it is not used during SSR (not present in the server manifest),
-			// then it can be lazily loaded in the browser.
-
+		if ((node.universal || node.component) && kit.output.bundleStrategy === 'split') {
 			/** @type {AssetDependencies | undefined} */
 			let component;
 			if (node.component) {
@@ -209,25 +182,41 @@ export function build_server_nodes(
 				universal = find_deps(server_manifest, node.universal, true, root);
 			}
 
-			/** @type {Set<string>} */
-			const eager_css = new Set();
+			if (client_manifest) {
+				const entry_path = `${out_dir}/generated/client-optimized/nodes/${i}.js`;
+				const entry = find_deps(client_manifest, entry_path, true, root);
 
-			entry.stylesheet_map.forEach((value, filepath) => {
-				// pages and layouts are renamed to node indexes when optimised for the client
-				// so we use the original filename instead to check against the server manifest
-				if (filepath === entry_path) {
-					filepath = node.component ?? filepath;
-				}
+				// Eagerly load client stylesheets and fonts imported by the SSR-ed page to avoid FOUC.
+				// However, if it is not used during SSR (not present in the server manifest),
+				// then it can be lazily loaded in the browser.
 
-				if (component?.stylesheet_map.has(filepath) || universal?.stylesheet_map.has(filepath)) {
-					value.css.forEach((file) => eager_css.add(file));
-					value.assets.forEach((file) => eager_assets.add(file));
-				}
-			});
+				/** @type {Set<string>} */
+				const eager_css = new Set();
+
+				entry.stylesheet_map.forEach((value, filepath) => {
+					// pages and layouts are renamed to node indexes when optimised for the client
+					// so we use the original filename instead to check against the server manifest
+					if (filepath === entry_path) {
+						filepath = node.component ?? filepath;
+					}
+
+					if (component?.stylesheet_map.has(filepath) || universal?.stylesheet_map.has(filepath)) {
+						value.css.forEach((file) => eager_css.add(file));
+						value.assets.forEach((file) => eager_assets.add(file));
+					}
+				});
 
-			imported = entry.imports;
-			stylesheets = Array.from(eager_css);
-			fonts = filter_fonts(Array.from(eager_assets));
+				imported = entry.imports;
+				stylesheets = Array.from(eager_css);
+				fonts = filter_fonts(Array.from(eager_assets));
+			} else {
+				for (const entry of [component, universal]) {
+					if (!entry) continue;
+					imported.push(...entry.imports);
+					stylesheets.push(...entry.stylesheets);
+					fonts.push(...entry.fonts);
+				}
+			}
 		}
 
 		exports.push(
@@ -244,7 +233,7 @@ export function build_server_nodes(
 
 		// Keep track of Vite asset filenames so that we avoid touching unrelated ones
 		// when adjusting the inlined CSS
-		if (stylesheets_to_inline.size && assets_path && eager_assets.size) {
+		if (stylesheets_to_inline.size && eager_assets.size) {
 			vite_assets = new Set(
 				Array.from(eager_assets).map((asset) => {
 					return decodeURIComponent(asset.replace(`${assets_path}/`, ''));

package/src/exports/vite/build/remote.js

@@ -13,7 +13,7 @@ import { posixify } from '../../../utils/os.js';
  * @param {Array<{ hash: string, file: string }>} remotes
  * @param {ServerMetadata} metadata
  * @param {string} cwd
- * @param {Rolldown.RolldownOutput} server_bundle
+ * @param {(Rolldown.OutputAsset | Rolldown.OutputChunk)[]} server_chunks
  * @param {NonNullable<import('vitest/config').ViteUserConfig['build']>['sourcemap']} sourcemap
  */
 export async function treeshake_prerendered_remotes(
@@ -22,11 +22,14 @@ export async function treeshake_prerendered_remotes(
 	remotes,
 	metadata,
 	cwd,
-	server_bundle,
+	server_chunks,
 	sourcemap
 ) {
 	if (remotes.length === 0) return;
 
+	/** @type {string[]} */
+	const chunk_paths = [];
+
 	for (const remote of remotes) {
 		const exports_map = metadata.remotes.get(remote.hash);
 		if (!exports_map) continue;
@@ -45,7 +48,7 @@ export async function treeshake_prerendered_remotes(
 		// remove file extension
 		const remote_filename = path.basename(remote.file).split('.').slice(0, -1).join('.');
 
-		const remote_chunk = Object.values(server_bundle).find((chunk) => {
+		const remote_chunk = server_chunks.find((chunk) => {
 			return chunk.name === remote_filename;
 		});
 
@@ -88,8 +91,13 @@ export async function treeshake_prerendered_remotes(
 
 		const stubbed = modified_code.toString();
 		fs.writeFileSync(chunk_path, stubbed);
+		chunk_paths.push(chunk_path);
+	}
+
+	if (!chunk_paths.length) return;
 
-		const bundle = /** @type {import('vite').Rolldown.RolldownOutput} */ (
+	for (const chunk_path of chunk_paths) {
+		const bundle = /** @type {Rolldown.RolldownOutput} */ (
 			await vite.build({
 				configFile: false,
 				build: {
@@ -97,7 +105,7 @@ export async function treeshake_prerendered_remotes(
 					ssr: true,
 					target: 'esnext',
 					sourcemap,
-					rollupOptions: {
+					rolldownOptions: {
 						// avoid resolving imports
 						external: (id) => !id.endsWith(chunk_path),
 						input: {
@@ -108,14 +116,13 @@ export async function treeshake_prerendered_remotes(
 			})
 		);
 
-		const chunk = bundle.output.find(
-			(output) => output.type === 'chunk' && output.name === 'treeshaken'
-		);
-		if (chunk && chunk.type === 'chunk') {
-			fs.writeFileSync(chunk_path, chunk.code);
+		for (const output of bundle.output) {
+			if (output.type !== 'chunk' || output.name !== 'treeshaken') return;
+
+			fs.writeFileSync(chunk_path, output.code);
 
 			const chunk_sourcemap = bundle.output.find(
-				(output) => output.type === 'asset' && output.fileName === chunk.fileName + '.map'
+				(o) => o.type === 'asset' && o.fileName === output.fileName + '.map'
 			);
 			if (chunk_sourcemap && chunk_sourcemap.type === 'asset') {
 				fs.writeFileSync(chunk_path + '.map', chunk_sourcemap.source);

package/src/exports/vite/build/utils.js

@@ -124,14 +124,6 @@ export function filter_fonts(assets) {
 	return assets.filter((asset) => /\.(woff2?|ttf|otf)$/.test(asset));
 }
 
-/**
- * @param {import('types').ValidatedKitConfig} config
- * @returns {string}
- */
-export function assets_base(config) {
-	return (config.paths.assets || config.paths.base || '.') + '/';
-}
-
 /**
  * Writes a function with arguments used by a template literal.
  * This helps us store strings in a module and inject values at runtime.