@sveltejs/kit 1.0.0-next.298 → 1.0.0-next.299

package/assets/client/start.js

@@ -2,7 +2,7 @@ import { onMount, tick } from 'svelte';
 import { writable } from 'svelte/store';
 import { assets, set_paths } from '../paths.js';
 import Root from '__GENERATED__/root.svelte';
-import { routes, fallback } from '__GENERATED__/manifest.js';
+import { components, dictionary, validators } from '__GENERATED__/client-manifest.js';
 import { init } from './singletons.js';
 
 /**
@@ -250,9 +250,108 @@ function initial_fetch(resource, opts) {
 	return fetch(resource, opts);
 }
 
+/** @param {string} key */
+function parse_route_id(key) {
+	/** @type {string[]} */
+	const names = [];
+
+	/** @type {string[]} */
+	const types = [];
+
+	const pattern =
+		key === ''
+			? /^\/$/
+			: new RegExp(
+					`^${decodeURIComponent(key)
+						.split('/')
+						.map((segment) => {
+							// special case — /[...rest]/ could contain zero segments
+							const match = /^\[\.\.\.(\w+)(?:=\w+)?\]$/.exec(segment);
+							if (match) {
+								names.push(match[1]);
+								types.push(match[2]);
+								return '(?:/(.*))?';
+							}
+
+							return (
+								'/' +
+								segment.replace(/\[(\.\.\.)?(\w+)(?:=(\w+))?\]/g, (m, rest, name, type) => {
+									names.push(name);
+									types.push(type);
+									return rest ? '(.*?)' : '([^/]+?)';
+								})
+							);
+						})
+						.join('')}/?$`
+			  );
+
+	return { pattern, names, types };
+}
+
+/**
+ * @param {RegExpMatchArray} match
+ * @param {string[]} names
+ * @param {string[]} types
+ * @param {Record<string, import('types').ParamValidator>} validators
+ */
+function exec(match, names, types, validators) {
+	/** @type {Record<string, string>} */
+	const params = {};
+
+	for (let i = 0; i < names.length; i += 1) {
+		const name = names[i];
+		const type = types[i];
+		const value = match[i + 1] || '';
+
+		if (type) {
+			const validator = validators[type];
+			if (!validator) throw new Error(`Missing "${type}" param validator`); // TODO do this ahead of time?
+
+			if (!validator(value)) return;
+		}
+
+		params[name] = value;
+	}
+
+	return params;
+}
+
+/**
+ * @param {import('types').CSRComponentLoader[]} components
+ * @param {Record<string, [number[], number[], 1?]>} dictionary
+ * @param {Record<string, (param: string) => boolean>} validators
+ * @returns {import('types').CSRRoute[]}
+ */
+function parse(components, dictionary, validators) {
+	const routes = Object.entries(dictionary).map(([id, [a, b, has_shadow]]) => {
+		const { pattern, names, types } = parse_route_id(id);
+
+		return {
+			id,
+			/** @param {string} path */
+			exec: (path) => {
+				const match = pattern.exec(path);
+				if (match) return exec(match, names, types, validators);
+			},
+			a: a.map((n) => components[n]),
+			b: b.map((n) => components[n]),
+			has_shadow: !!has_shadow
+		};
+	});
+
+	return routes;
+}
+
 const SCROLL_KEY = 'sveltekit:scroll';
 const INDEX_KEY = 'sveltekit:index';
 
+const routes = parse(components, dictionary, validators);
+
+// we import the root layout/error components eagerly, so that
+// connectivity errors after initialisation don't nuke the app
+const default_layout = components[0]();
+const default_error = components[1]();
+
 // We track the scroll position associated with each history entry in sessionStorage,
 // rather than on history.state itself, because when navigation is driven by
 // popstate it's too late to update the scroll position associated with the
@@ -339,8 +438,7 @@ function create_client({ target, session, base, trailing_slash }) {
 		if (!ready) return;
 		session_id += 1;
 
-		const intent = get_navigation_intent(new URL(location.href));
-		update(intent, [], true);
+		update(new URL(location.href), [], true);
 	});
 	ready = true;
 
@@ -405,29 +503,31 @@ function create_client({ target, session, base, trailing_slash }) {
 
 	/** @param {URL} url */
 	async function prefetch(url) {
-		if (!owns(url)) {
+		const intent = get_navigation_intent(url);
+
+		if (!intent) {
 			throw new Error('Attempted to prefetch a URL that does not belong to this app');
 		}
 
-		const intent = get_navigation_intent(url);
-
-		load_cache.promise = get_navigation_result(intent, false);
+		load_cache.promise = load_route(intent, false);
 		load_cache.id = intent.id;
 
 		return load_cache.promise;
 	}
 
 	/**
-	 * @param {import('./types').NavigationIntent} intent
+	 * @param {URL} url
 	 * @param {string[]} redirect_chain
 	 * @param {boolean} no_cache
 	 * @param {{hash?: string, scroll: { x: number, y: number } | null, keepfocus: boolean, details: { replaceState: boolean, state: any } | null}} [opts]
 	 */
-	async function update(intent, redirect_chain, no_cache, opts) {
+	async function update(url, redirect_chain, no_cache, opts) {
+		const intent = get_navigation_intent(url);
+
 		const current_token = (token = {});
-		let navigation_result = await get_navigation_result(intent, no_cache);
+		let navigation_result = intent && (await load_route(intent, no_cache));
 
-		if (!navigation_result && intent.url.pathname === location.pathname) {
+		if (!navigation_result && url.pathname === location.pathname) {
 			// this could happen in SPA fallback mode if the user navigated to
 			// `/non-existent-page`. if we fall back to reloading the page, it
 			// will create an infinite loop. so whereas we normally handle
@@ -435,13 +535,14 @@ function create_client({ target, session, base, trailing_slash }) {
 			// we render a client-side error page instead
 			navigation_result = await load_root_error_page({
 				status: 404,
-				error: new Error(`Not found: ${intent.url.pathname}`),
-				url: intent.url
+				error: new Error(`Not found: ${url.pathname}`),
+				url,
+				routeId: null
 			});
 		}
 
 		if (!navigation_result) {
-			await native_navigation(intent.url);
+			await native_navigation(url);
 			return; // unnecessary, but TypeScript prefers it this way
 		}
 
@@ -451,17 +552,18 @@ function create_client({ target, session, base, trailing_slash }) {
 		invalidated.clear();
 
 		if (navigation_result.redirect) {
-			if (redirect_chain.length > 10 || redirect_chain.includes(intent.url.pathname)) {
+			if (redirect_chain.length > 10 || redirect_chain.includes(url.pathname)) {
 				navigation_result = await load_root_error_page({
 					status: 500,
 					error: new Error('Redirect loop'),
-					url: intent.url
+					url,
+					routeId: null
 				});
 			} else {
 				if (router_enabled) {
-					goto(new URL(navigation_result.redirect, intent.url).href, {}, [
+					goto(new URL(navigation_result.redirect, url).href, {}, [
 						...redirect_chain,
-						intent.url.pathname
+						url.pathname
 					]);
 				} else {
 					await native_navigation(new URL(navigation_result.redirect, location.href));
@@ -472,7 +574,7 @@ function create_client({ target, session, base, trailing_slash }) {
 		} else if (navigation_result.props?.page?.status >= 400) {
 			const updated = await stores.updated.check();
 			if (updated) {
-				await native_navigation(intent.url);
+				await native_navigation(url);
 			}
 		}
 
@@ -482,7 +584,7 @@ function create_client({ target, session, base, trailing_slash }) {
 			const { details } = opts;
 			const change = details.replaceState ? 0 : 1;
 			details.state[INDEX_KEY] = current_history_index += change;
-			history[details.replaceState ? 'replaceState' : 'pushState'](details.state, '', intent.url);
+			history[details.replaceState ? 'replaceState' : 'pushState'](details.state, '', url);
 		}
 
 		if (started) {
@@ -522,7 +624,7 @@ function create_client({ target, session, base, trailing_slash }) {
 			await tick();
 
 			if (autoscroll) {
-				const deep_linked = intent.url.hash && document.getElementById(intent.url.hash.slice(1));
+				const deep_linked = url.hash && document.getElementById(url.hash.slice(1));
 				if (scroll) {
 					scrollTo(scroll.x, scroll.y);
 				} else if (deep_linked) {
@@ -575,36 +677,6 @@ function create_client({ target, session, base, trailing_slash }) {
 		}
 	}
 
-	/**
-	 * @param {import('./types').NavigationIntent} intent
-	 * @param {boolean} no_cache
-	 */
-	async function get_navigation_result(intent, no_cache) {
-		if (load_cache.id === intent.id && load_cache.promise) {
-			return load_cache.promise;
-		}
-
-		for (let i = 0; i < intent.routes.length; i += 1) {
-			const route = intent.routes[i];
-
-			// load code for subsequent routes immediately, if they are as
-			// likely to match the current path/query as the current one
-			let j = i + 1;
-			while (j < intent.routes.length) {
-				const next = intent.routes[j];
-				if (next[0].toString() === route[0].toString()) {
-					next[1].forEach((loader) => loader());
-					j += 1;
-				} else {
-					break;
-				}
-			}
-
-			const result = await load_route(route, intent, no_cache);
-			if (result) return result;
-		}
-	}
-
 	/**
 	 *
 	 * @param {{
@@ -614,9 +686,18 @@ function create_client({ target, session, base, trailing_slash }) {
 	 *   branch: Array<import('./types').BranchNode | undefined>;
 	 *   status: number;
 	 *   error?: Error;
+	 *   routeId: string | null;
 	 * }} opts
 	 */
-	async function get_navigation_result_from_branch({ url, params, stuff, branch, status, error }) {
+	async function get_navigation_result_from_branch({
+		url,
+		params,
+		stuff,
+		branch,
+		status,
+		error,
+		routeId
+	}) {
 		const filtered = /** @type {import('./types').BranchNode[] } */ (branch.filter(Boolean));
 		const redirect = filtered.find((f) => f.loaded?.redirect);
 
@@ -640,7 +721,7 @@ function create_client({ target, session, base, trailing_slash }) {
 		}
 
 		if (!current.url || url.href !== current.url.href) {
-			result.props.page = { url, params, status, error, stuff };
+			result.props.page = { error, params, routeId, status, stuff, url };
 
 			// TODO remove this for 1.0
 			/**
@@ -699,9 +780,10 @@ function create_client({ target, session, base, trailing_slash }) {
 	 *   params: Record<string, string>;
 	 *   stuff: Record<string, any>;
 	 *   props?: Record<string, any>;
+	 *   routeId: string | null;
 	 * }} options
 	 */
-	async function load_node({ status, error, module, url, params, stuff, props }) {
+	async function load_node({ status, error, module, url, params, stuff, props, routeId }) {
 		/** @type {import('./types').BranchNode} */
 		const node = {
 			module,
@@ -738,6 +820,7 @@ function create_client({ target, session, base, trailing_slash }) {
 		if (module.load) {
 			/** @type {import('types').LoadInput | import('types').ErrorLoadInput} */
 			const load_input = {
+				routeId,
 				params: uses_params,
 				props: props || {},
 				get url() {
@@ -791,21 +874,20 @@ function create_client({ target, session, base, trailing_slash }) {
 	}
 
 	/**
-	 * @param {import('types').CSRRoute} route
 	 * @param {import('./types').NavigationIntent} intent
 	 * @param {boolean} no_cache
 	 */
-	async function load_route(route, { id, url, path, routes }, no_cache) {
+	async function load_route({ id, url, params, route }, no_cache) {
+		if (load_cache.id === id && load_cache.promise) {
+			return load_cache.promise;
+		}
+
 		if (!no_cache) {
 			const cached = cache.get(id);
 			if (cached) return cached;
 		}
 
-		const [pattern, a, b, get_params, shadow_key] = route;
-		const params = get_params
-			? // the pattern is for the route which we've already matched to this path
-			  get_params(/** @type {RegExpExecArray} */ (pattern.exec(path)))
-			: {};
+		const { a, b, has_shadow } = route;
 
 		const changed = current.url && {
 			url: id !== current.url.pathname + current.url.search,
@@ -852,14 +934,14 @@ function create_client({ target, session, base, trailing_slash }) {
 					/** @type {Record<string, any>} */
 					let props = {};
 
-					const is_shadow_page = shadow_key !== undefined && i === a.length - 1;
+					const is_shadow_page = has_shadow && i === a.length - 1;
 
 					if (is_shadow_page) {
 						const res = await fetch(
 							`${url.pathname}${url.pathname.endsWith('/') ? '' : '/'}__data.json${url.search}`,
 							{
 								headers: {
-									'x-sveltekit-load': /** @type {string} */ (shadow_key)
+									'x-sveltekit-load': 'true'
 								}
 							}
 						);
@@ -875,15 +957,7 @@ function create_client({ target, session, base, trailing_slash }) {
 								};
 							}
 
-							if (res.status === 204) {
-								if (route !== routes[routes.length - 1]) {
-									// fallthrough
-									return;
-								}
-								props = {};
-							} else {
-								props = await res.json();
-							}
+							props = res.status === 204 ? {} : await res.json();
 						} else {
 							status = res.status;
 							error = new Error('Failed to load data');
@@ -896,7 +970,8 @@ function create_client({ target, session, base, trailing_slash }) {
 							url,
 							params,
 							props,
-							stuff
+							stuff,
+							routeId: route.id
 						});
 					}
 
@@ -906,9 +981,14 @@ function create_client({ target, session, base, trailing_slash }) {
 						}
 
 						if (node.loaded) {
+							// TODO remove for 1.0
+							// @ts-expect-error
 							if (node.loaded.fallthrough) {
-								return;
+								throw new Error(
+									'fallthrough is no longer supported. Use validators instead: https://kit.svelte.dev/docs/routing#advanced-routing-validation'
+								);
 							}
+
 							if (node.loaded.error) {
 								status = node.loaded.status;
 								error = node.loaded.error;
@@ -954,7 +1034,8 @@ function create_client({ target, session, base, trailing_slash }) {
 								module: await b[i](),
 								url,
 								params,
-								stuff: node_loaded.stuff
+								stuff: node_loaded.stuff,
+								routeId: route.id
 							});
 
 							if (error_loaded?.loaded?.error) {
@@ -979,7 +1060,8 @@ function create_client({ target, session, base, trailing_slash }) {
 				return await load_root_error_page({
 					status,
 					error,
-					url
+					url,
+					routeId: route.id
 				});
 			} else {
 				if (node?.loaded?.stuff) {
@@ -999,7 +1081,8 @@ function create_client({ target, session, base, trailing_slash }) {
 			stuff,
 			branch,
 			status,
-			error
+			error,
+			routeId: route.id
 		});
 	}
 
@@ -1008,26 +1091,29 @@ function create_client({ target, session, base, trailing_slash }) {
 	 *   status: number;
 	 *   error: Error;
 	 *   url: URL;
+	 *   routeId: string | null
 	 * }} opts
 	 */
-	async function load_root_error_page({ status, error, url }) {
+	async function load_root_error_page({ status, error, url, routeId }) {
 		/** @type {Record<string, string>} */
 		const params = {}; // error page does not have params
 
 		const root_layout = await load_node({
-			module: await fallback[0],
+			module: await default_layout,
 			url,
 			params,
-			stuff: {}
+			stuff: {},
+			routeId
 		});
 
 		const root_error = await load_node({
 			status,
 			error,
-			module: await fallback[1],
+			module: await default_error,
 			url,
 			params,
-			stuff: (root_layout && root_layout.loaded && root_layout.loaded.stuff) || {}
+			stuff: (root_layout && root_layout.loaded && root_layout.loaded.stuff) || {},
+			routeId
 		});
 
 		return await get_navigation_result_from_branch({
@@ -1039,28 +1125,32 @@ function create_client({ target, session, base, trailing_slash }) {
 			},
 			branch: [root_layout, root_error],
 			status,
-			error
+			error,
+			routeId
 		});
 	}
 
-	/** @param {URL} url */
-	function owns(url) {
-		return url.origin === location.origin && url.pathname.startsWith(base);
-	}
-
 	/** @param {URL} url */
 	function get_navigation_intent(url) {
+		if (url.origin !== location.origin || !url.pathname.startsWith(base)) return;
+
 		const path = decodeURI(url.pathname.slice(base.length) || '/');
 
-		/** @type {import('./types').NavigationIntent} */
-		const intent = {
-			id: url.pathname + url.search,
-			routes: routes.filter(([pattern]) => pattern.test(path)),
-			url,
-			path
-		};
+		for (const route of routes) {
+			const params = route.exec(path);
+
+			if (params) {
+				/** @type {import('./types').NavigationIntent} */
+				const intent = {
+					id: url.pathname + url.search,
+					route,
+					params,
+					url
+				};
 
-		return intent;
+				return intent;
+			}
+		}
 	}
 
 	/**
@@ -1094,14 +1184,8 @@ function create_client({ target, session, base, trailing_slash }) {
 			return;
 		}
 
-		if (!owns(url)) {
-			await native_navigation(url);
-		}
-
 		const pathname = normalize_path(url.pathname, trailing_slash);
-		url = new URL(url.origin + pathname + url.search + url.hash);
-
-		const intent = get_navigation_intent(url);
+		const normalized = new URL(url.origin + pathname + url.search + url.hash);
 
 		update_scroll_positions(current_history_index);
 
@@ -1114,11 +1198,11 @@ function create_client({ target, session, base, trailing_slash }) {
 		if (started) {
 			stores.navigating.set({
 				from: current.url,
-				to: intent.url
+				to: normalized
 			});
 		}
 
-		await update(intent, redirect_chain, false, {
+		await update(normalized, redirect_chain, false, {
 			scroll,
 			keepfocus,
 			details
@@ -1130,7 +1214,7 @@ function create_client({ target, session, base, trailing_slash }) {
 		if (navigating_token !== current_navigating_token) return;
 
 		if (!navigating) {
-			const navigation = { from, to: url };
+			const navigation = { from, to: normalized };
 			callbacks.after_navigate.forEach((fn) => fn(navigation));
 
 			stores.navigating.set(null);
@@ -1190,8 +1274,7 @@ function create_client({ target, session, base, trailing_slash }) {
 
 			if (!invalidating) {
 				invalidating = Promise.resolve().then(async () => {
-					const intent = get_navigation_intent(new URL(location.href));
-					await update(intent, [], true);
+					await update(new URL(location.href), [], true);
 
 					invalidating = null;
 				});
@@ -1208,10 +1291,10 @@ function create_client({ target, session, base, trailing_slash }) {
 		// TODO rethink this API
 		prefetch_routes: async (pathnames) => {
 			const matching = pathnames
-				? routes.filter((route) => pathnames.some((pathname) => route[0].test(pathname)))
+				? routes.filter((route) => pathnames.some((pathname) => route.exec(pathname)))
 				: routes;
 
-			const promises = matching.map((r) => Promise.all(r[1].map((load) => load())));
+			const promises = matching.map((r) => Promise.all(r.a.map((load) => load())));
 
 			await Promise.all(promises);
 		},
@@ -1389,7 +1472,7 @@ function create_client({ target, session, base, trailing_slash }) {
 			});
 		},
 
-		_hydrate: async ({ status, error, nodes, params }) => {
+		_hydrate: async ({ status, error, nodes, params, routeId }) => {
 			const url = new URL(location.href);
 
 			/** @type {Array<import('./types').BranchNode | undefined>} */
@@ -1423,7 +1506,8 @@ function create_client({ target, session, base, trailing_slash }) {
 						stuff,
 						status: is_leaf ? status : undefined,
 						error: is_leaf ? error : undefined,
-						props
+						props,
+						routeId
 					});
 
 					if (props) {
@@ -1439,7 +1523,8 @@ function create_client({ target, session, base, trailing_slash }) {
 							error_args = {
 								status: node.loaded.status,
 								error: node.loaded.error,
-								url
+								url,
+								routeId
 							};
 						} else if (node.loaded.stuff) {
 							stuff = {
@@ -1458,7 +1543,8 @@ function create_client({ target, session, base, trailing_slash }) {
 							stuff,
 							branch,
 							status,
-							error
+							error,
+							routeId
 					  });
 			} catch (e) {
 				if (error) throw e;
@@ -1466,7 +1552,8 @@ function create_client({ target, session, base, trailing_slash }) {
 				result = await load_root_error_page({
 					status: 500,
 					error: coalesce_to_error(e),
-					url
+					url,
+					routeId
 				});
 			}
 
@@ -1497,6 +1584,7 @@ function create_client({ target, session, base, trailing_slash }) {
  *     error: Error;
  *     nodes: Array<Promise<import('types').CSRComponent>>;
  *     params: Record<string, string>;
+ *     routeId: string | null;
  *   };
  * }} opts
  */