@suss/checker-intent 0.21.0 → 0.21.1

package/dist/index.cjs

@@ -33,6 +33,7 @@ function checkIntentAgreement(intents, code) {
   const unchecked = [];
   const codeByBoundary = indexCodeByBoundary(code);
   const boundaryByName = indexBoundaryIntentsByName(intents);
+  const deploymentOfUnit = (0, import_behavioral_ir.deploymentOf)(code);
   for (const intent of intents) {
     if (intent.kind === "prd") {
       const result2 = checkPrdCoverage(intent, boundaryByName);
@@ -40,7 +41,11 @@ function checkIntentAgreement(intents, code) {
       checked.push(result2.checked);
       continue;
     }
-    const result = checkBoundaryIntent(intent, codeByBoundary);
+    const result = checkBoundaryIntent(
+      intent,
+      codeByBoundary,
+      deploymentOfUnit
+    );
     findings.push(...withProvenance(result.findings, intent.source));
     checked.push(...result.checked);
     unchecked.push(...result.unchecked);
@@ -83,7 +88,7 @@ function checkOutcomesDescribed(intents) {
   }
   return findings;
 }
-function checkBoundaryIntent(intent, codeByBoundary) {
+function checkBoundaryIntent(intent, codeByBoundary, deploymentOfUnit) {
   const key = (0, import_ir_core.pairingKey)(intent.boundary);
   if (key === null) {
     return {
@@ -136,7 +141,9 @@ function checkBoundaryIntent(intent, codeByBoundary) {
   }
   const findings = [];
   for (const impl of impls) {
-    findings.push(...compareIntentToImpl(intent, impl, label));
+    findings.push(
+      ...compareIntentToImpl(intent, impl, label, deploymentOfUnit(impl))
+    );
   }
   return {
     findings,
@@ -320,12 +327,14 @@ function indexCodeByBoundary(code) {
   }
   return byKey;
 }
-function compareIntentToImpl(intent, impl, boundary) {
+function compareIntentToImpl(intent, impl, boundary, deployment) {
   const findings = [];
   const ref = codeRef(impl);
   const calls = (0, import_behavioral_ir.boundaryCalls)(impl);
-  const codeOutcomes = impl.transitions.map((t) => toCodeOutcome(t, calls)).filter((o) => o !== null);
-  const everyEffect = impl.transitions.flatMap(codeEffectsOf);
+  const codeOutcomes = impl.transitions.map((t) => toCodeOutcome(t, calls, deployment)).filter((o) => o !== null);
+  const everyEffect = impl.transitions.flatMap(
+    (t) => codeEffectsOf(t, deployment)
+  );
   for (const outcome of intent.outcomes) {
     const reached = outcome.kind === "effect" ? everyEffect : codeOutcomes.filter((co) => outcomeMatches(outcome, co)).flatMap((co) => co.effects);
     for (const effect of outcome.effects) {
@@ -338,7 +347,7 @@ function compareIntentToImpl(intent, impl, boundary) {
         boundary,
         intent: { name: intent.name, outcomeId: outcome.id },
         code: ref,
-        message: `Intent "${intent.name}" declares that ${outcome.id} results in ${describeEffect(effect)} at ${boundary}; no transition of ${impl.identity.name} does that.`
+        message: `Intent "${intent.name}" declares that ${outcome.id} results in ${describeEffect(effect)} at ${boundary}; no transition of ${impl.identity.name} does that.${unsettledNote(reached, effect, deployment)}`
       });
     }
     if (outcome.kind === "effect") {
@@ -438,6 +447,21 @@ function compareIntentToImpl(intent, impl, boundary) {
   }
   return findings;
 }
+function unsettledNote(reached, declared, deployment) {
+  const variables = /* @__PURE__ */ new Set();
+  for (const made of reached) {
+    const reference = (0, import_ir_core.nameReference)(made.binding);
+    const variable = reference === null ? null : deployment.variableFor(reference);
+    if (made.does === declared.does && variable !== null) {
+      variables.add(variable);
+    }
+  }
+  if (variables.size === 0) {
+    return "";
+  }
+  const named = [...variables].sort().join(", ");
+  return ` The code says which one through ${named}, and nothing in this run says what that is set to. Read the deployment that sets it in and check again.`;
+}
 function effectMatches(declared, made) {
   return declared.does === made.does && (0, import_ir_core.namesBoundary)(declared.names, made.binding) && statesAll(declared.fields, made.fields) && statesAll(declared.by, made.by);
 }
@@ -452,10 +476,13 @@ function conditionMet(declared, turnsOn) {
     (guard) => guard.does === declared.at.does && (0, import_ir_core.namesBoundary)(declared.at.names, guard.binding) && (declared.finds === null || declared.finds === guard.polarity)
   );
 }
-function toCodeOutcome(t, calls) {
+function toCodeOutcome(t, calls, deployment) {
   const output = t.output;
-  const effects = codeEffectsOf(t);
-  const turnsOn = (0, import_behavioral_ir.boundaryGuardsOf)(t, calls);
+  const effects = codeEffectsOf(t, deployment);
+  const turnsOn = (0, import_behavioral_ir.boundaryGuardsOf)(t, calls).map((guard) => ({
+    ...guard,
+    binding: (0, import_behavioral_ir.groundBinding)(guard.binding, deployment)
+  }));
   if (output.type === "response") {
     const status = output.statusCode !== null && output.statusCode.type === "literal" ? Number(output.statusCode.value) : null;
     return {
@@ -489,7 +516,7 @@ function toCodeOutcome(t, calls) {
   }
   return null;
 }
-function codeEffectsOf(t) {
+function codeEffectsOf(t, deployment) {
   const reached = [];
   for (const effect of t.effects) {
     if (effect.type !== "interaction") {
@@ -498,10 +525,11 @@ function codeEffectsOf(t) {
     if ((0, import_behavioral_ir.goesThroughRelation)(effect.interaction)) {
       continue;
     }
-    const label = (0, import_ir_core.displayLabel)(effect.binding);
+    const binding = (0, import_behavioral_ir.groundBinding)(effect.binding, deployment);
+    const label = (0, import_ir_core.displayLabel)(binding);
     const touched = accessDetail(effect.interaction);
     for (const does of (0, import_behavioral_ir.relationsOf)(effect.interaction)) {
-      reached.push({ does, binding: effect.binding, label, ...touched });
+      reached.push({ does, binding, label, ...touched });
     }
   }
   return reached;

package/dist/index.js

@@ -3,7 +3,9 @@ import {
   BOUNDARY_ROLE,
   boundaryCalls,
   boundaryGuardsOf,
+  deploymentOf,
   goesThroughRelation,
+  groundBinding,
   relationsOf,
   summaryRef,
   withDeclaredDelivery
@@ -14,6 +16,7 @@ import {
   boundaryKey,
   displayLabel,
   EVERY_FIELD,
+  nameReference,
   namesBoundary,
   pairingKey,
   ruleBoundaryMatchesKey,
@@ -25,6 +28,7 @@ function checkIntentAgreement(intents, code) {
   const unchecked = [];
   const codeByBoundary = indexCodeByBoundary(code);
   const boundaryByName = indexBoundaryIntentsByName(intents);
+  const deploymentOfUnit = deploymentOf(code);
   for (const intent of intents) {
     if (intent.kind === "prd") {
       const result2 = checkPrdCoverage(intent, boundaryByName);
@@ -32,7 +36,11 @@ function checkIntentAgreement(intents, code) {
       checked.push(result2.checked);
       continue;
     }
-    const result = checkBoundaryIntent(intent, codeByBoundary);
+    const result = checkBoundaryIntent(
+      intent,
+      codeByBoundary,
+      deploymentOfUnit
+    );
     findings.push(...withProvenance(result.findings, intent.source));
     checked.push(...result.checked);
     unchecked.push(...result.unchecked);
@@ -75,7 +83,7 @@ function checkOutcomesDescribed(intents) {
   }
   return findings;
 }
-function checkBoundaryIntent(intent, codeByBoundary) {
+function checkBoundaryIntent(intent, codeByBoundary, deploymentOfUnit) {
   const key = pairingKey(intent.boundary);
   if (key === null) {
     return {
@@ -128,7 +136,9 @@ function checkBoundaryIntent(intent, codeByBoundary) {
   }
   const findings = [];
   for (const impl of impls) {
-    findings.push(...compareIntentToImpl(intent, impl, label));
+    findings.push(
+      ...compareIntentToImpl(intent, impl, label, deploymentOfUnit(impl))
+    );
   }
   return {
     findings,
@@ -312,12 +322,14 @@ function indexCodeByBoundary(code) {
   }
   return byKey;
 }
-function compareIntentToImpl(intent, impl, boundary) {
+function compareIntentToImpl(intent, impl, boundary, deployment) {
   const findings = [];
   const ref = codeRef(impl);
   const calls = boundaryCalls(impl);
-  const codeOutcomes = impl.transitions.map((t) => toCodeOutcome(t, calls)).filter((o) => o !== null);
-  const everyEffect = impl.transitions.flatMap(codeEffectsOf);
+  const codeOutcomes = impl.transitions.map((t) => toCodeOutcome(t, calls, deployment)).filter((o) => o !== null);
+  const everyEffect = impl.transitions.flatMap(
+    (t) => codeEffectsOf(t, deployment)
+  );
   for (const outcome of intent.outcomes) {
     const reached = outcome.kind === "effect" ? everyEffect : codeOutcomes.filter((co) => outcomeMatches(outcome, co)).flatMap((co) => co.effects);
     for (const effect of outcome.effects) {
@@ -330,7 +342,7 @@ function compareIntentToImpl(intent, impl, boundary) {
         boundary,
         intent: { name: intent.name, outcomeId: outcome.id },
         code: ref,
-        message: `Intent "${intent.name}" declares that ${outcome.id} results in ${describeEffect(effect)} at ${boundary}; no transition of ${impl.identity.name} does that.`
+        message: `Intent "${intent.name}" declares that ${outcome.id} results in ${describeEffect(effect)} at ${boundary}; no transition of ${impl.identity.name} does that.${unsettledNote(reached, effect, deployment)}`
       });
     }
     if (outcome.kind === "effect") {
@@ -430,6 +442,21 @@ function compareIntentToImpl(intent, impl, boundary) {
   }
   return findings;
 }
+function unsettledNote(reached, declared, deployment) {
+  const variables = /* @__PURE__ */ new Set();
+  for (const made of reached) {
+    const reference = nameReference(made.binding);
+    const variable = reference === null ? null : deployment.variableFor(reference);
+    if (made.does === declared.does && variable !== null) {
+      variables.add(variable);
+    }
+  }
+  if (variables.size === 0) {
+    return "";
+  }
+  const named = [...variables].sort().join(", ");
+  return ` The code says which one through ${named}, and nothing in this run says what that is set to. Read the deployment that sets it in and check again.`;
+}
 function effectMatches(declared, made) {
   return declared.does === made.does && namesBoundary(declared.names, made.binding) && statesAll(declared.fields, made.fields) && statesAll(declared.by, made.by);
 }
@@ -444,10 +471,13 @@ function conditionMet(declared, turnsOn) {
     (guard) => guard.does === declared.at.does && namesBoundary(declared.at.names, guard.binding) && (declared.finds === null || declared.finds === guard.polarity)
   );
 }
-function toCodeOutcome(t, calls) {
+function toCodeOutcome(t, calls, deployment) {
   const output = t.output;
-  const effects = codeEffectsOf(t);
-  const turnsOn = boundaryGuardsOf(t, calls);
+  const effects = codeEffectsOf(t, deployment);
+  const turnsOn = boundaryGuardsOf(t, calls).map((guard) => ({
+    ...guard,
+    binding: groundBinding(guard.binding, deployment)
+  }));
   if (output.type === "response") {
     const status = output.statusCode !== null && output.statusCode.type === "literal" ? Number(output.statusCode.value) : null;
     return {
@@ -481,7 +511,7 @@ function toCodeOutcome(t, calls) {
   }
   return null;
 }
-function codeEffectsOf(t) {
+function codeEffectsOf(t, deployment) {
   const reached = [];
   for (const effect of t.effects) {
     if (effect.type !== "interaction") {
@@ -490,10 +520,11 @@ function codeEffectsOf(t) {
     if (goesThroughRelation(effect.interaction)) {
       continue;
     }
-    const label = displayLabel(effect.binding);
+    const binding = groundBinding(effect.binding, deployment);
+    const label = displayLabel(binding);
     const touched = accessDetail(effect.interaction);
     for (const does of relationsOf(effect.interaction)) {
-      reached.push({ does, binding: effect.binding, label, ...touched });
+      reached.push({ does, binding, label, ...touched });
     }
   }
   return reached;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@suss/checker-intent",
-  "version": "0.21.0",
+  "version": "0.21.1",
   "type": "module",
   "description": "Pair team-authored intent (IntentSummary) against derived code (BehavioralSummary) and report where they diverge.",
   "keywords": [
@@ -47,9 +47,9 @@
     "zod": "^4.0.0"
   },
   "dependencies": {
-    "@suss/behavioral-ir": "0.21.0",
-    "@suss/intent-ir": "0.21.0",
-    "@suss/ir-core": "0.21.0"
+    "@suss/behavioral-ir": "0.21.1",
+    "@suss/intent-ir": "0.21.1",
+    "@suss/ir-core": "0.21.1"
   },
   "devDependencies": {
     "tsup": "*",