@supersoniks/concorde 4.9.1 → 4.9.3

package/src/core/components/ui/icon/icons.ts

@@ -43,22 +43,38 @@ const libraries = {
 type Libraries = typeof libraries;
 type LibraryKey = keyof Libraries;
 type Library = Partial<{ url: string; defaultPrefix: string }>;
-let hasEnabledCustomLibrary = false;
-function enableCustomLibrary() {
-  if (hasEnabledCustomLibrary) return;
 
-  libraries.custom.url =
-    document
-      .querySelector("[customIconLibraryPath]")
-      ?.getAttribute("customIconLibraryPath") || "";
-  libraries.custom.defaultPrefix =
-    document
-      .querySelector("[customIconDefaultPrefix]")
-      ?.getAttribute("customIconDefaultPrefix") || "";
+function resolveCustomLibraryConfig(params: IconConf): Library {
+  let url = params.customLibraryPath;
+  let defaultPrefix = params.customLibraryDefaultPrefix;
 
-  if (libraries.custom.url) {
-    hasEnabledCustomLibrary = true;
+  // Attribut optionnel : peut être défini sur un ancêtre (scope / theme) ou,
+  // en secours, n'importe où dans le document (ex. config globale au boot).
+  if (url == null) {
+    const globalEl = document.querySelector("[customIconLibraryPath]");
+    url = globalEl?.getAttribute("customIconLibraryPath") ?? "";
+    if (defaultPrefix == null) {
+      defaultPrefix =
+        globalEl?.getAttribute("customIconDefaultPrefix") ??
+        document
+          .querySelector("[customIconDefaultPrefix]")
+          ?.getAttribute("customIconDefaultPrefix") ??
+        "";
+    }
   }
+
+  return {
+    url: url || "",
+    defaultPrefix: defaultPrefix || "",
+  };
+}
+
+function resolveLibraryItem(library: string, params: IconConf): Library | null {
+  if (!(library in libraries)) return null;
+  if (library !== "custom") {
+    return libraries[library as LibraryKey] as Library;
+  }
+  return resolveCustomLibraryConfig(params);
 }
 const iconCachStr = sessionStorage.getItem("sonicIconsCache");
 const iconCache = iconCachStr
@@ -70,6 +86,8 @@ export declare type IconConf = {
   name: string;
   prefix?: string;
   library?: string;
+  customLibraryPath?: string | null;
+  customLibraryDefaultPrefix?: string | null;
 };
 export default class Icons {
   static default = {
@@ -81,15 +99,23 @@ export default class Icons {
       /**
        * SVGS en ligne
        */
-      if (library == "custom") {
-        enableCustomLibrary();
+      if (!library) {
+        return unsafeHTML(iconsAsRecord["core"][params.name] || "");
       }
-      if (library && library in libraries) {
-        const libraryItem = libraries[library as LibraryKey] as Library;
+      const libraryItem = resolveLibraryItem(library, params);
+      if (libraryItem) {
+        // Pas d'URL encore (ancêtre ou config globale pas prête) : on attend
+        // sans fetch ni cache ; @ancestorAttribute relancera le chargement.
+        if (library === "custom" && !libraryItem.url) {
+          return "";
+        }
         const prefix: string = params.prefix || libraryItem.defaultPrefix || "";
         const libIcons = iconsAsRecord[library] || ({} as Library);
         iconsAsRecord[library] = libIcons;
-        const libIconsKey = prefix + "-" + name;
+        const libIconsKey =
+          library === "custom"
+            ? `${libraryItem.url}|${prefix}-${name}`
+            : `${prefix}-${name}`;
 
         /**
          * Si l'icone a déjà été chargée on ne la recharge pas

package/src/core/decorators/subscriber/ancestorAttribute.spec.ts

@@ -55,6 +55,25 @@ describe("ancestorAttribute", () => {
     expect(el.dataProvider).toBe("scope-a");
   });
 
+  it("assigne une chaine vide si l'attribut ancêtre est présent sans valeur (mode statique)", () => {
+    const tag = "test-ancestor-attr-static-empty";
+    class C extends HTMLElement {
+      @ancestorAttribute("is_guichet")
+      isGuichet: string | null = null;
+    }
+    if (!customElements.get(tag)) {
+      customElements.define(tag, C);
+    }
+
+    const wrap = document.createElement("div");
+    wrap.setAttribute("is_guichet", "");
+    const el = document.createElement(tag) as InstanceType<typeof C>;
+    wrap.appendChild(el);
+    document.body.appendChild(wrap);
+
+    expect(el.isGuichet).toBe("");
+  });
+
   it("met à jour la propriété quand un ancêtre change (mode dynamique)", async () => {
     const tag = "test-ancestor-attr-dynamic-mutation";
     class C extends HTMLElement {
@@ -101,6 +120,29 @@ describe("ancestorAttribute", () => {
     expect(el.dataProvider).toBeNull();
   });
 
+  it("met à jour avec une chaine vide si l'attribut ancêtre devient présent sans valeur (mode dynamique)", async () => {
+    const tag = "test-ancestor-attr-dynamic-empty";
+    class C extends HTMLElement {
+      @ancestorAttribute("is_guichet", { dynamic: true })
+      isGuichet: string | null = null;
+    }
+    if (!customElements.get(tag)) {
+      customElements.define(tag, C);
+    }
+
+    const wrap = document.createElement("div");
+    const el = document.createElement(tag) as InstanceType<typeof C>;
+    wrap.appendChild(el);
+    document.body.appendChild(wrap);
+
+    expect(el.isGuichet).toBeNull();
+
+    wrap.setAttribute("is_guichet", "");
+    await flushFrames();
+
+    expect(el.isGuichet).toBe("");
+  });
+
   it("retombe sur l'ancêtre suivant quand le plus proche perd l'attribut", async () => {
     const tag = "test-ancestor-attr-dynamic-fallback";
     class C extends HTMLElement {

package/src/core/utils/HTML.ts

@@ -71,10 +71,9 @@ class HTML {
   ): string | null {
     for (const attrName of HTML.scopeAttributeNames(attributeName)) {
       if (element.hasAttribute(attrName)) {
-        const attr = element.getAttribute(attrName);
-        if (attr != null && attr.length > 0) {
-          return attr;
-        }
+        // Un attribut HTML peut exister sans valeur (ex: <x is_guichet>),
+        // on retourne donc "" plutôt que null pour préserver ce cas.
+        return element.getAttribute(attrName) ?? "";
       }
     }
     return null;
@@ -94,7 +93,7 @@ class HTML {
     while (current) {
       if (current instanceof HTMLElement) {
         const value = HTML.readScopeAttributeOnElement(current, attributeName);
-        if (value != null && value.length > 0) {
+        if (value != null) {
           return value;
         }
       }

package/src/docs/search/docs-search.json

@@ -4759,6 +4759,51 @@
       }
     }
   },
+  {
+    "search": "Same pattern as @post: a publisher acts as a signal, independent of the response payload.\n",
+    "files": {
+      "docs/_decorators/get.md": {
+        "title": "@get",
+        "hashes": {
+          "manual-refetch-triggerkey": {
+            "count": 1,
+            "title": "Manual refetch (`triggerKey`)",
+            "type": "paragraph"
+          }
+        }
+      }
+    }
+  },
+  {
+    "search": "Prefer triggerKey over mutating the API configuration publisher when you only want to reload the same URL — no need to touch serviceURL, tokens, etc.\n",
+    "files": {
+      "docs/_decorators/get.md": {
+        "title": "@get",
+        "hashes": {
+          "manual-refetch-triggerkey": {
+            "count": 1,
+            "title": "Manual refetch (`triggerKey`)",
+            "type": "paragraph"
+          }
+        }
+      }
+    }
+  },
+  {
+    "search": "The docs mock adds an X-Fetched-At response header on /docs-mock-api/geo/communes so live demos can show when the last fetch happened (response.headers.get("X-Fetched-At")).\n",
+    "files": {
+      "docs/_decorators/get.md": {
+        "title": "@get",
+        "hashes": {
+          "manual-refetch-triggerkey": {
+            "count": 1,
+            "title": "Manual refetch (`triggerKey`)",
+            "type": "paragraph"
+          }
+        }
+      }
+    }
+  },
   {
     "search": "Same demo service as sonic-queue (/docs-mock-api/geo/). Publisher setup lives in decorators-demo-geo.ts and decorators-demo-subscribe-publish-get-demos.ts.\n",
     "files": {
@@ -4775,7 +4820,22 @@
     }
   },
   {
-    "search": "Dynamic config and endpoint path (demo-api-get-configuration-key in doc sources):\n",
+    "search": "@get with triggerKey — refresh button + X-Fetched-At timestamp in the UI:\n",
+    "files": {
+      "docs/_decorators/get.md": {
+        "title": "@get",
+        "hashes": {
+          "live-demos": {
+            "count": 1,
+            "title": "Live demos",
+            "type": "paragraph"
+          }
+        }
+      }
+    }
+  },
+  {
+    "search": "Dynamic config and endpoint path. Manual refetch is triggered from a separate component (same triggerKey publisher):\n",
     "files": {
       "docs/_decorators/get.md": {
         "title": "@get",