@superhero/http-server 4.1.0 → 4.2.0

package/config.json

@@ -6,9 +6,9 @@
   "locator":
   {
     "@superhero/http-server": true,
-    "@superhero/http-server/middleware/*/*": "./middleware/*/*.js",
-    "@superhero/http-server/middleware/*/*/*": "./middleware/*/*/*.js",
-    "@superhero/http-server/middleware/*/*/*/*/*": "./middleware/*/*/*/*/*.js"
+    "@superhero/http-server/dispatcher/*/*": "./dispatcher/*/*.js",
+    "@superhero/http-server/dispatcher/*/*/*": "./dispatcher/*/*/*.js",
+    "@superhero/http-server/dispatcher/*/*/*/*/*": "./dispatcher/*/*/*/*/*.js"
   },
   "http-server":
   {

package/{middleware → dispatcher}/upstream/header/accept.js

@@ -1,13 +1,22 @@
 /**
- * @memberof @superhero/http-server:middleware/upstream/header
+ * @memberof @superhero/http-server:dispatcher/upstream/header
  */
-export default new class AcceptHeaderUpstreamMiddleware
+export default new class AcceptHeaderUpstreamDispatcher
 {
   #listFormat = new Intl.ListFormat('en', { style:'long', type:'disjunction' })
   #normalize  = (route) => route.replace('accept.', '').trim()
 
   dispatch(request, session)
   {
+    if(false === !!request.headers['accept'])
+    {
+      const error   = new Error(`The requested resource "${request.method} ${request.url}" requires a accept header`)
+      error.code    = 'E_HTTP_SERVER_ACCEPT_HEADER_MISSING'
+      error.status  = 406
+      error.cause   = `The requested resource requires a accept header to be set`
+      return session.abortion.abort(error)
+    }
+
     const
       splitHeader = request.headers['accept']?.toLowerCase().split(',') || [],
       accepts     = splitHeader.map(this.#normalize),
@@ -42,7 +51,7 @@ export default new class AcceptHeaderUpstreamMiddleware
       allowed = supports.map(([ supported ]) => supported),
       error   = new Error(`The requested resource "${request.method} ${request.url}" can not be delivered in requested header accept media types: ${this.#listFormat.format(accepts) || 'none are defined'}`)
 
-    error.code    = 'E_HTTP_SERVER_MIDDLEWARE_ACCEPT_HEADER_NO_MATCHING_DISPATCHER'
+    error.code    = 'E_HTTP_SERVER_ACCEPT_HEADER_NO_ROUTE'
     error.status  = 406
     error.headers = { accept:allowed.join(',') }
     error.cause   = `Supported accept header media types are: ${this.#listFormat.format(allowed) || 'none are defined'}`

package/{middleware → dispatcher}/upstream/header/content-type/application/json.js

@@ -1,9 +1,9 @@
 /**
  * Does not validate headers, just assumes that the body is a JSON string
  * 
- * @memberof @superhero/http-server:middleware/upstream/header/content-type/application
+ * @memberof @superhero/http-server:dispatcher/upstream/header/content-type/application
  */
-export default new class ContentTypeApplicationJsonHeaderUpstreamMiddleware
+export default new class ContentTypeApplicationJsonHeaderUpstreamDispatcher
 {
   async dispatch(request, session)
   {
@@ -18,7 +18,7 @@ export default new class ContentTypeApplicationJsonHeaderUpstreamMiddleware
       catch(reason)
       {
         const error   = new Error('The body is not a valid JSON string')
-        error.code    = 'E_HTTP_SERVER_MIDDLEWARE_CONTENT_TYPE_APPLICATION_JSON_INVALID_BODY'
+        error.code    = 'E_HTTP_SERVER_CONTENT_TYPE_HEADER_APPLICATION_JSON'
         error.status  = 400
         error.cause   = 'The buffered body could not be parsed as a JSON string'
 

package/{middleware → dispatcher}/upstream/header/content-type.js

@@ -1,14 +1,23 @@
 /**
- * @memberof @superhero/http-server:middleware/upstream/header
+ * @memberof @superhero/http-server:dispatcher/upstream/header
  */
-export default new class ContentTypeHeaderUpstreamMiddleware
+export default new class ContentTypeHeaderUpstreamDispatcher
 {
   #listFormat = new Intl.ListFormat('en', { style:'long', type:'disjunction' })
 
   dispatch(request, session)
   {
+    if(false === !!request.headers['content-type'])
+    {
+      const error   = new Error(`The requested resource "${request.method} ${request.url}" requires a content-type header`)
+      error.code    = 'E_HTTP_SERVER_CONTENT_TYPE_HEADER_MISSING'
+      error.status  = 415
+      error.cause   = `The requested resource requires a content-type header to be set`
+      return session.abortion.abort(error)
+    }
+
     const
-      contentType = request.headers['content-type']?.toLowerCase().split(';')[0].split('*')[0].trim(),
+      contentType = request.headers['content-type'].toLowerCase().split(';')[0].split('*')[0].trim(),
       routes      = Object.keys(session.route).filter((key) => key.startsWith('content-type.') && session.route[key]),
       supports    = routes.map((route) => [route.replace('content-type.', '').trim(), route])
 
@@ -30,12 +39,12 @@ export default new class ContentTypeHeaderUpstreamMiddleware
         return
       }
     }
-    
+
     const
       allowed = supports.map(([ supported ]) => supported),
       error   = new Error(`The requested resource "${request.method} ${request.url}" does not support content-type "${request.headers['content-type']}"`)
 
-    error.code    = 'E_HTTP_SERVER_MIDDLEWARE_CONTENT_TYPE_NO_MATCHING_DISPATCHER'
+    error.code    = 'E_HTTP_SERVER_CONTENT_TYPE_HEADER_NO_ROUTE'
     error.status  = 415
     error.headers = { accept:allowed.join(',') }
     error.cause   = `Supported content-type headers are: ${this.#listFormat.format(allowed) || 'none are defined'}`

package/{middleware → dispatcher}/upstream/method.js

@@ -1,7 +1,7 @@
 /**
- * @memberof @superhero/http-server:middleware/upstream
+ * @memberof @superhero/http-server:dispatcher/upstream
  */
-export default new class MethodUpstreamMiddleware
+export default new class MethodUpstreamDispatcher
 {
   #listFormat = new Intl.ListFormat('en', { style:'long', type:'disjunction' })
 
@@ -28,7 +28,7 @@ export default new class MethodUpstreamMiddleware
       allowed  = supports.map((supported) => supported.replace('method.', '').toUpperCase()).sort(),
       error    = new Error(`The requested resource "${request.url}" does not support method "${request.method}"`)
 
-    error.code    = 'E_HTTP_SERVER_MIDDLEWARE_METHOD_NO_MATCHING_DISPATCHER'
+    error.code    = 'E_HTTP_SERVER_METHOD_NO_ROUTE'
     error.status  = 405
     error.headers = { allow:allowed.join(',') }
     error.cause   = `Supported methods are: ${this.#listFormat.format(allowed) || 'none are defined'}`

package/index.test.js

@@ -75,12 +75,12 @@ suite('@superhero/http-server', () =>
       assert.ok(config.find('http-server/router/routes'))
 
       await locator.eagerload(config.find('locator'))
-      
+
       assert.ok(locator.has('@superhero/http-server'))
-      assert.ok(locator.has('@superhero/http-server/middleware/upstream/method'))
-      assert.ok(locator.has('@superhero/http-server/middleware/upstream/header/accept'))
-      assert.ok(locator.has('@superhero/http-server/middleware/upstream/header/content-type'))
-      assert.ok(locator.has('@superhero/http-server/middleware/upstream/header/content-type/application/json'))
+      assert.ok(locator.has('@superhero/http-server/dispatcher/upstream/method'))
+      assert.ok(locator.has('@superhero/http-server/dispatcher/upstream/header/accept'))
+      assert.ok(locator.has('@superhero/http-server/dispatcher/upstream/header/content-type'))
+      assert.ok(locator.has('@superhero/http-server/dispatcher/upstream/header/content-type/application/json'))
     })
 
     test('Listens and closes the server as expected', async () => 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@superhero/http-server",
-  "version": "4.1.0",
+  "version": "4.2.0",
   "description": "HTTP(S) server component supporting both HTTP 1.1 and HTTP 2.0",
   "keywords": [
     "http server",