@superfluid-finance/ethereum-contracts 1.4.1 → 1.4.2-dev.e06ddfc.0

package/build/contracts/UUPSUtils.json

@@ -15,15 +15,15 @@
     "absolutePath": "project:/contracts/upgradability/UUPSUtils.sol",
     "exportedSymbols": {
       "UUPSUtils": [
-        37593
+        37600
       ]
     },
-    "id": 37594,
+    "id": 37601,
     "license": "AGPLv3",
     "nodeType": "SourceUnit",
     "nodes": [
       {
-        "id": 37571,
+        "id": 37578,
         "literals": [
           "solidity",
           "0.8",
@@ -39,15 +39,15 @@
         "contractDependencies": [],
         "contractKind": "library",
         "documentation": {
-          "id": 37572,
+          "id": 37579,
           "nodeType": "StructuredDocumentation",
           "src": "60:76:95",
           "text": " @title UUPS (Universal Upgradeable Proxy Standard) Shared Library"
         },
         "fullyImplemented": true,
-        "id": 37593,
+        "id": 37600,
         "linearizedBaseContracts": [
-          37593
+          37600
         ],
         "name": "UUPSUtils",
         "nameLocation": "145:9:95",
@@ -56,17 +56,17 @@
           {
             "constant": true,
             "documentation": {
-              "id": 37573,
+              "id": 37580,
               "nodeType": "StructuredDocumentation",
               "src": "162:288:95",
               "text": " @dev Implementation slot constant.\n Using https://eips.ethereum.org/EIPS/eip-1967 standard\n Storage slot 0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc\n (obtained as bytes32(uint256(keccak256('eip1967.proxy.implementation')) - 1))."
             },
-            "id": 37576,
+            "id": 37583,
             "mutability": "constant",
             "name": "_IMPLEMENTATION_SLOT",
             "nameLocation": "481:20:95",
             "nodeType": "VariableDeclaration",
-            "scope": 37593,
+            "scope": 37600,
             "src": "455:115:95",
             "stateVariable": true,
             "storageLocation": "default",
@@ -75,7 +75,7 @@
               "typeString": "bytes32"
             },
             "typeName": {
-              "id": 37574,
+              "id": 37581,
               "name": "bytes32",
               "nodeType": "ElementaryTypeName",
               "src": "455:7:95",
@@ -86,7 +86,7 @@
             },
             "value": {
               "hexValue": "307833363038393461313362613161333231303636376338323834393264623938646361336532303736636333373335613932306133636135303564333832626263",
-              "id": 37575,
+              "id": 37582,
               "isConstant": false,
               "isLValue": false,
               "isPure": true,
@@ -104,7 +104,7 @@
           },
           {
             "body": {
-              "id": 37583,
+              "id": 37590,
               "nodeType": "Block",
               "src": "681:107:95",
               "statements": [
@@ -145,33 +145,33 @@
                   "evmVersion": "london",
                   "externalReferences": [
                     {
-                      "declaration": 37576,
+                      "declaration": 37583,
                       "isOffset": false,
                       "isSlot": false,
                       "src": "751:20:95",
                       "valueSize": 1
                     },
                     {
-                      "declaration": 37580,
+                      "declaration": 37587,
                       "isOffset": false,
                       "isSlot": false,
                       "src": "737:4:95",
                       "valueSize": 1
                     }
                   ],
-                  "id": 37582,
+                  "id": 37589,
                   "nodeType": "InlineAssembly",
                   "src": "691:91:95"
                 }
               ]
             },
             "documentation": {
-              "id": 37577,
+              "id": 37584,
               "nodeType": "StructuredDocumentation",
               "src": "577:36:95",
               "text": "@dev Get implementation address."
             },
-            "id": 37584,
+            "id": 37591,
             "implemented": true,
             "kind": "function",
             "modifiers": [],
@@ -179,23 +179,23 @@
             "nameLocation": "627:14:95",
             "nodeType": "FunctionDefinition",
             "parameters": {
-              "id": 37578,
+              "id": 37585,
               "nodeType": "ParameterList",
               "parameters": [],
               "src": "641:2:95"
             },
             "returnParameters": {
-              "id": 37581,
+              "id": 37588,
               "nodeType": "ParameterList",
               "parameters": [
                 {
                   "constant": false,
-                  "id": 37580,
+                  "id": 37587,
                   "mutability": "mutable",
                   "name": "impl",
                   "nameLocation": "675:4:95",
                   "nodeType": "VariableDeclaration",
-                  "scope": 37584,
+                  "scope": 37591,
                   "src": "667:12:95",
                   "stateVariable": false,
                   "storageLocation": "default",
@@ -204,7 +204,7 @@
                     "typeString": "address"
                   },
                   "typeName": {
-                    "id": 37579,
+                    "id": 37586,
                     "name": "address",
                     "nodeType": "ElementaryTypeName",
                     "src": "667:7:95",
@@ -219,7 +219,7 @@
               ],
               "src": "666:14:95"
             },
-            "scope": 37593,
+            "scope": 37600,
             "src": "618:170:95",
             "stateMutability": "view",
             "virtual": false,
@@ -227,7 +227,7 @@
           },
           {
             "body": {
-              "id": 37591,
+              "id": 37598,
               "nodeType": "Block",
               "src": "896:171:95",
               "statements": [
@@ -266,33 +266,33 @@
                   "evmVersion": "london",
                   "externalReferences": [
                     {
-                      "declaration": 37576,
+                      "declaration": 37583,
                       "isOffset": false,
                       "isSlot": false,
                       "src": "988:20:95",
                       "valueSize": 1
                     },
                     {
-                      "declaration": 37587,
+                      "declaration": 37594,
                       "isOffset": false,
                       "isSlot": false,
                       "src": "1026:11:95",
                       "valueSize": 1
                     }
                   ],
-                  "id": 37590,
+                  "id": 37597,
                   "nodeType": "InlineAssembly",
                   "src": "906:155:95"
                 }
               ]
             },
             "documentation": {
-              "id": 37585,
+              "id": 37592,
               "nodeType": "StructuredDocumentation",
               "src": "794:40:95",
               "text": "@dev Set new implementation address."
             },
-            "id": 37592,
+            "id": 37599,
             "implemented": true,
             "kind": "function",
             "modifiers": [],
@@ -300,17 +300,17 @@
             "nameLocation": "848:17:95",
             "nodeType": "FunctionDefinition",
             "parameters": {
-              "id": 37588,
+              "id": 37595,
               "nodeType": "ParameterList",
               "parameters": [
                 {
                   "constant": false,
-                  "id": 37587,
+                  "id": 37594,
                   "mutability": "mutable",
                   "name": "codeAddress",
                   "nameLocation": "874:11:95",
                   "nodeType": "VariableDeclaration",
-                  "scope": 37592,
+                  "scope": 37599,
                   "src": "866:19:95",
                   "stateVariable": false,
                   "storageLocation": "default",
@@ -319,7 +319,7 @@
                     "typeString": "address"
                   },
                   "typeName": {
-                    "id": 37586,
+                    "id": 37593,
                     "name": "address",
                     "nodeType": "ElementaryTypeName",
                     "src": "866:7:95",
@@ -335,19 +335,19 @@
               "src": "865:21:95"
             },
             "returnParameters": {
-              "id": 37589,
+              "id": 37596,
               "nodeType": "ParameterList",
               "parameters": [],
               "src": "896:0:95"
             },
-            "scope": 37593,
+            "scope": 37600,
             "src": "839:228:95",
             "stateMutability": "nonpayable",
             "virtual": false,
             "visibility": "internal"
           }
         ],
-        "scope": 37594,
+        "scope": 37601,
         "src": "137:933:95",
         "usedErrors": []
       }
@@ -360,7 +360,7 @@
   },
   "networks": {},
   "schemaVersion": "3.4.9",
-  "updatedAt": "2022-09-21T07:45:09.817Z",
+  "updatedAt": "2022-09-21T11:06:18.589Z",
   "devdoc": {
     "kind": "dev",
     "methods": {},

package/build/contracts-sizes.txt

@@ -5,7 +5,7 @@ SuperToken.sol : 18114 (6462)
 SuperfluidToken.sol : 2 (24574)
 InstantDistributionAgreementV1.sol : 21380 (3196)
 AgreementLibrary.sol : 143 (24433)
-ConstantFlowAgreementV1.sol : 20592 (3984)
+ConstantFlowAgreementV1.sol : 20609 (3967)
 AgreementBase.sol : 2 (24574)
 SuperfluidGovernanceII.sol : 8155 (16421)
 SuperfluidGovernanceBase.sol : 2 (24574)

package/contracts/agreements/ConstantFlowAgreementV1.sol

@@ -1433,6 +1433,10 @@ contract ConstantFlowAgreementV1 is
         internal pure
         returns (bool)
     {
+        if (signedTotalCFADeposit == 0) {
+            return false;
+        }
+
         int256 totalRewardLeft = availableBalance + signedTotalCFADeposit;
         int256 totalCFAOutFlowrate = signedTotalCFADeposit / int256(liquidationPeriod);
         // divisor cannot be zero with existing outflow

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@superfluid-finance/ethereum-contracts",
-    "version": "1.4.1",
+    "version": "1.4.2-dev.e06ddfc.0",
     "description": " Ethereum contracts implementation for the Superfluid Protocol",
     "homepage": "https://github.com/superfluid-finance/protocol-monorepo/tree/dev/packages/ethereum-contracts#readme",
     "repository": {
@@ -27,7 +27,7 @@
         "run-hardhat": "IS_HARDHAT=true hardhat",
         "run-truffle": "IS_TRUFFLE=true truffle",
         "run-forge": "IS_FOUNDRY=true forge",
-        "run-nodemon": "nodemon -e sol,js,ts -i build -x",
+        "run-nodemon": "nodemon -e sol,js,ts -x",
         "build": "run-s build:*",
         "build:contracts": "rm -f build/contracts/*;yarn run-truffle compile",
         "build:hardhat": "yarn run-hardhat compile",
@@ -37,7 +37,7 @@
         "testenv:deploy": "yarn run-truffle exec scripts/deploy-test-environment.js : TEST",
         "pretest": "{ yarn testenv:start > /dev/null& } && sleep 5",
         "test": "run-s test:*:*",
-        "test:contracts:hardhat": "yarn run-hardhat test testsuites/all-contracts.js",
+        "test:contracts:hardhat": "yarn run-hardhat test testsuites/all-contracts.ts",
         "test:contracts:foundry": "yarn run-forge test --hardhat",
         "test:contracts:solc-compatibility": "test/test-solc-compatibility.sh",
         "test:deployment:scripts-js-hardhat": "yarn run-hardhat test test/scripts/deployment.test.js",
@@ -48,6 +48,10 @@
         "lint": "run-s lint:*",
         "lint:sol": "solhint -w 0 contracts/*.sol contracts/*/*.sol && echo '✔  Your .sol files look good.'",
         "lint:js-eslint": "eslint . --max-warnings=0 --report-unused-disable-directives && echo '✔  Your .js files look good.'",
+        "lint-ts": "eslint test -c .eslintrc.ts.json --ext .ts",
+        "lint:ts-eslint": "yarn lint-ts --max-warnings=0 --report-unused-disable-directives && echo '✔  Your .ts files look good.'",
+        "fix": "run-s fix:*",
+        "fix:eslint": "yarn lint-ts --fix",
         "lint:check-no-focused-tests": "grep -FR .only test || { echo 'No test is focused.';exit 0; } && { echo '✘ You have focused tests.'; exit 1; }",
         "pre-commit": "if [ ! -z \"$(git status -s .)\" ];then run-s pre-commit:*;else true;fi",
         "pre-commit:lint": "yarn lint",
@@ -65,14 +69,14 @@
         "stack-trace": "0.0.10"
     },
     "devDependencies": {
-        "@nomiclabs/hardhat-truffle5": "^2.0.6",
+        "@nomiclabs/hardhat-truffle5": "^2.0.7",
         "async": "^3.2.4",
         "csv-writer": "^1.6.0",
         "ganache-time-traveler": "1.0.16",
         "mochawesome": "^7.1.3",
         "readline": "1.3.0",
         "solhint": "3.3.7",
-        "solidity-coverage": "0.7.21",
+        "solidity-coverage": "0.8.0",
         "solidity-docgen": "^0.6.0-beta.25",
         "truffle-flattener": "^1.6.0",
         "truffle-plugin-verify": "0.5.28"