@superblocksteam/vite-plugin-file-sync 1.99.99-next.2 → 2.0.0-SNAPSHOT.2143e2e95d0107ab

package/dist/ai-service/state-machine/handlers/post-processing.js

@@ -1,76 +1,183 @@
+import { debugCache } from "../../agent/tools/debug-cache.js";
 import { Paths } from "../../const.js";
-import { AddMetadataToApiYamlTransformer } from "../../transform/add-metadata-to-api-yaml/transformer.js";
-import { ApiBuilderToYamlTransformer } from "../../transform/api-builder/to-yaml-transformer.js";
-import { RemoveApiBuilderImportsTransformer } from "../../transform/remove-api-builder-imports/transformer.js";
-import { applyFileTransformations, matchPath } from "../../transform/shared.js";
-import { WorkaroundMissingSbApiTransformer } from "../../transform/workaround-missing-sbapi/transformer.js";
-import { LLM_FINISHED, POST_PROCESSING_ERRORED, POST_PROCESSING_FINISHED, } from "../clark-fsm.js";
+import { matchMultiplePaths } from "../../transform/shared.js";
+import { APP_RUNTIME_UPDATED_WITHOUT_EDITS, LLM_FINISHED, POST_PROCESSING_ERRORED, POST_PROCESSING_FINISHED, } from "../clark-fsm.js";
+import { sendChangeInfoHelper } from "../helpers/change-info.js";
+import { classificationHelper } from "../helpers/classification.js";
 import { sendUserMessageChannel } from "../helpers/peer.js";
 import { transitionFrom } from "../helpers/transition.js";
-export const doPostProcessing = (clark, { applicationId, organizationId, draftInterface, templateRenderer, appShell, }) => {
+export const doPostProcessing = (clark, { draftInterface, appShell, chatSessionStore, signals, }) => {
     const transitionTo = transitionFrom(clark);
-    const sendUserMessage = sendUserMessageChannel(clark);
-    const createDraftFiles = (files) => {
-        return Promise.all(files.map((file) => draftInterface.createDraftFile(file.filePath, file.content)));
+    const sendChangeInfo = sendChangeInfoHelper(clark, chatSessionStore);
+    const sendUserMessage = sendUserMessageChannel(clark, chatSessionStore);
+    const { isFullAppOrBroadUpdate } = classificationHelper(clark);
+    const createDraftFiles = async (files) => {
+        for (const file of files) {
+            // ui > page/api change infos: ready dot
+            void sendChangeInfo({
+                type: "ready",
+                filePath: file.filePath,
+            });
+        }
+        await Promise.all(files.map((file) => draftInterface.createDraftFile(file.filePath, file.content)));
+        // Immediately invalidate TypeScript cache since we just wrote files
+        if (files.length > 0) {
+            debugCache.invalidateTypeScript();
+            // Update last modification time
+            clark.updateContext({
+                lastFileModificationTime: Date.now(),
+            });
+        }
+    };
+    // send ui messages and invoke package installer
+    const handleDependencies = async (_packageJson) => {
+        // NOTE(colin): change info for packages is disabled for the demo
+        // const packageChanges = await parsePackageJsonChanges(
+        //   draftInterface,
+        //   packageJson.content,
+        // );
+        // ui > deps change infos: spin
+        // for (const change of packageChanges) {
+        //   void sendChangeInfo({
+        //     type: "pending",
+        //     filePath: renderPath(DependencyInfoPath, {
+        //       packageName: change.package,
+        //     }),
+        //     action: change.type,
+        //   });
+        // }
+        // any previous package changes that are still marked ready
+        // should be treated as deleted
+        // const previousReadyChanges = Object.values(
+        //   clark.context.generatedChangeInfo ?? {},
+        // ).filter(
+        //   (change) =>
+        //     change.status === "ready" &&
+        //     change.action !== "delete" &&
+        //     change.filePath.startsWith(DependencyInfoPath),
+        // );
+        // // ui > deps change infos: delete
+        // for (const change of previousReadyChanges) {
+        //   sendChangeInfo({
+        //     type: "ready",
+        //     filePath: change.filePath,
+        //     action: "delete",
+        //   });
+        // }
+        await appShell.runNpmInstall(clark.context.abortController?.signal);
+        // ui > deps change infos: checkmark
+        // for (const change of packageChanges) {
+        //   sendChangeInfo({
+        //     type: "validated",
+        //     filePath: renderPath(DependencyInfoPath, {
+        //       packageName: change.package,
+        //     }),
+        //   });
+        // }
     };
     return async ({ event }) => {
         switch (event.type) {
             case LLM_FINISHED: {
                 const { files } = event;
+                // we have already drafted the generated apis into yaml at this point,
+                // but the api builder files are still in the event's files list
+                const scopePaths = matchMultiplePaths(Paths.PageScopes, Paths.AppScope);
+                const pageAndComponentPaths = matchMultiplePaths(Paths.PageIndexes, Paths.ComponentsFile, Paths.ComponentsFolder);
                 try {
-                    const transformed = await applyFileTransformations(files, [
-                        new ApiBuilderToYamlTransformer({
-                            skipCleanup: true,
-                            templateRenderer,
-                        }),
-                        new AddMetadataToApiYamlTransformer({
-                            applicationId,
-                            organizationId,
-                        }),
-                        new RemoveApiBuilderImportsTransformer(),
-                        new WorkaroundMissingSbApiTransformer(),
-                    ]);
-                    const scopePathMatcher = matchPath(Paths.AllScopes);
-                    const apiPathMatcher = matchPath(Paths.ApiYamls);
-                    // bucket files because order matters
-                    const { packageJson, scopes, apiYamls, otherArtifacts } = transformed.reduce((acc, file) => {
-                        if (file.filePath === "package.json") {
+                    const { packageJson, scopes, pagesAndComponents, themeFiles } = files.reduce((acc, file) => {
+                        if (file.filePath === Paths.PackageJson) {
                             acc.packageJson = file;
                         }
-                        else if (scopePathMatcher(file.filePath).matched) {
+                        else if (scopePaths(file.filePath).matched) {
                             acc.scopes.push(file);
                         }
-                        else if (apiPathMatcher(file.filePath).matched) {
-                            acc.apiYamls.push(file);
+                        else if (pageAndComponentPaths(file.filePath).matched) {
+                            acc.pagesAndComponents.push(file);
                         }
-                        else {
-                            acc.otherArtifacts.push(file);
+                        else if (file.filePath === Paths.AppTheme) {
+                            acc.themeFiles.push(file);
                         }
                         return acc;
                     }, {
                         packageJson: null,
-                        apiYamls: [],
                         scopes: [],
-                        otherArtifacts: [],
+                        pagesAndComponents: [],
+                        themeFiles: [],
                     });
-                    if (packageJson) {
-                        sendUserMessage({
-                            text: "Installing dependencies…",
+                    const useSecurityAgent = !clark.context.usedDebugging && isFullAppOrBroadUpdate();
+                    if (useSecurityAgent) {
+                        void sendUserMessage({
+                            type: "text",
+                            role: "assistant",
+                            group: "agent-engineer",
+                            content: "Okay, my first pass at this app is complete. Let me pass off to the Security Agent to review.",
                         });
+                        // ui > control message A: spin
+                        void sendUserMessage({
+                            type: "control",
+                            role: "assistant",
+                            group: "agent-security/libraries",
+                            status: "pending",
+                            content: "Checking external libraries",
+                        }, 500);
+                        // ui > control message A: checkmark
+                        void sendUserMessage({
+                            type: "control",
+                            role: "assistant",
+                            group: "agent-security/libraries",
+                            status: "validated",
+                            content: "Checking external libraries",
+                        }, 1000);
+                    }
+                    if (packageJson) {
                         await createDraftFiles([packageJson]);
-                        await appShell.runNpmInstall(clark.context.abortController?.signal);
+                        await handleDependencies(packageJson);
                     }
                     await createDraftFiles(scopes);
-                    await createDraftFiles(apiYamls);
-                    await createDraftFiles(otherArtifacts);
-                    transitionTo({
+                    await createDraftFiles(pagesAndComponents);
+                    await createDraftFiles(themeFiles);
+                    if (packageJson &&
+                        scopes.length === 0 &&
+                        pagesAndComponents.length === 0) {
+                        // there were no changes
+                        void transitionTo({
+                            type: APP_RUNTIME_UPDATED_WITHOUT_EDITS,
+                        });
+                    }
+                    if (useSecurityAgent) {
+                        // ui > control message B: spin
+                        void sendUserMessage({
+                            type: "control",
+                            role: "assistant",
+                            group: "agent-security/authz",
+                            status: "pending",
+                            content: "Reviewing authorization logic",
+                        });
+                        // ui > control message B: checkmark
+                        void sendUserMessage({
+                            type: "control",
+                            role: "assistant",
+                            group: "agent-security/authz",
+                            status: "validated",
+                            content: "Reviewing authorization logic",
+                        }, 1000);
+                        void sendUserMessage({
+                            type: "text",
+                            role: "assistant",
+                            group: "agent-security",
+                            content: "Looks good to me! Handing off to the QA agent to review the functionality.",
+                        });
+                    }
+                    void transitionTo({
                         type: POST_PROCESSING_FINISHED,
-                        files: transformed,
+                        files: files,
                     });
                 }
                 catch (err) {
                     const error = err instanceof Error ? err : new Error("Unknown error");
-                    transitionTo({
+                    // Emit failure event
+                    signals.emit("generationFailed", error);
+                    void transitionTo({
                         type: POST_PROCESSING_ERRORED,
                         error,
                     });
@@ -82,4 +189,88 @@ export const doPostProcessing = (clark, { applicationId, organizationId, draftIn
         }
     };
 };
+// get dependency changes to be shown in the ui
+export const parsePackageJsonChanges = async (draftInterface, updatedPackageJsonContent) => {
+    // TODO: as an optimization, we could get the datastructure diff form rather than string
+    const diff = await draftInterface.getDraftDiff([Paths.PackageJson]);
+    if (!diff) {
+        return [];
+    }
+    let updatedPackageJson;
+    try {
+        updatedPackageJson = JSON.parse(updatedPackageJsonContent);
+    }
+    catch {
+        return [];
+    }
+    const allCurrentPackages = new Set([
+        // we only surface packages in the dependencies object
+        ...Object.keys(updatedPackageJson.dependencies || {}),
+    ]);
+    const changes = [];
+    const lines = diff.split("\n");
+    const addedPackages = new Set();
+    const removedPackages = new Set();
+    const packageRegex = /^\s*"([^"]+)":\s*"[^"]*",?$/;
+    for (const line of lines) {
+        // Skip non-diff content lines
+        if (!line.startsWith("+") && !line.startsWith("-")) {
+            continue;
+        }
+        // Skip diff metadata lines (like +++ or ---)
+        if (line.startsWith("+++") || line.startsWith("---")) {
+            continue;
+        }
+        const lineContent = line.slice(1); // Remove +, -, or space prefix
+        const match = lineContent.match(packageRegex);
+        if (match) {
+            const packageName = match[1];
+            if (!packageName) {
+                continue;
+            }
+            if (line.startsWith("+")) {
+                // For additions, verify the package is actually in the final dependencies
+                if (allCurrentPackages.has(packageName)) {
+                    addedPackages.add(packageName);
+                }
+            }
+            else if (line.startsWith("-")) {
+                // For removals, exclude obvious top-level package.json fields
+                if (!commonTopLevelPackageJsonFields.has(packageName)) {
+                    removedPackages.add(packageName);
+                }
+            }
+        }
+    }
+    // Determine the type of change for each package
+    for (const packageName of addedPackages) {
+        if (removedPackages.has(packageName)) {
+            // Package appears in both add and remove = edit
+            changes.push({ type: "edit", package: packageName });
+        }
+        else {
+            // Package only appears in add = addition
+            changes.push({ type: "create", package: packageName });
+        }
+    }
+    for (const packageName of removedPackages) {
+        if (!addedPackages.has(packageName)) {
+            changes.push({ type: "delete", package: packageName });
+        }
+    }
+    return changes;
+};
+const commonTopLevelPackageJsonFields = new Set([
+    "name",
+    "version",
+    "description",
+    "main",
+    "scripts",
+    "keywords",
+    "author",
+    "license",
+    "repository",
+    "homepage",
+    "bugs",
+]);
 //# sourceMappingURL=post-processing.js.map

package/dist/ai-service/state-machine/handlers/post-processing.js.map

@@ -1 +1 @@
-{"version":3,"file":"post-processing.js","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/handlers/post-processing.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,gBAAgB,CAAC;AACvC,OAAO,EAAE,+BAA+B,EAAE,MAAM,yDAAyD,CAAC;AAC1G,OAAO,EAAE,2BAA2B,EAAE,MAAM,oDAAoD,CAAC;AACjG,OAAO,EAAE,kCAAkC,EAAE,MAAM,2DAA2D,CAAC;AAC/G,OAAO,EAAE,wBAAwB,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AAChF,OAAO,EAAE,iCAAiC,EAAE,MAAM,yDAAyD,CAAC;AAC5G,OAAO,EACL,YAAY,EACZ,uBAAuB,EACvB,wBAAwB,GACzB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,sBAAsB,EAAE,MAAM,oBAAoB,CAAC;AAC5D,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAW1D,MAAM,CAAC,MAAM,gBAAgB,GAAG,CAC9B,KAAY,EACZ,EACE,aAAa,EACb,cAAc,EACd,cAAc,EACd,gBAAgB,EAChB,QAAQ,GACgB,EAC1B,EAAE;IACF,MAAM,YAAY,GAAG,cAAc,CAAkB,KAAK,CAAC,CAAC;IAC5D,MAAM,eAAe,GAAG,sBAAsB,CAAC,KAAK,CAAC,CAAC;IACtD,MAAM,gBAAgB,GAAG,CAAC,KAAqB,EAAE,EAAE;QACjD,OAAO,OAAO,CAAC,GAAG,CAChB,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CACjB,cAAc,CAAC,eAAe,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,CAAC,OAAO,CAAC,CAC5D,CACF,CAAC;IACJ,CAAC,CAAC;IAEF,OAAO,KAAK,EAAE,EAAE,KAAK,EAAmB,EAAiB,EAAE;QACzD,QAAQ,KAAK,CAAC,IAAI,EAAE,CAAC;YACnB,KAAK,YAAY,CAAC,CAAC,CAAC;gBAClB,MAAM,EAAE,KAAK,EAAE,GAAG,KAAK,CAAC;gBACxB,IAAI,CAAC;oBACH,MAAM,WAAW,GAAG,MAAM,wBAAwB,CAAC,KAAK,EAAE;wBACxD,IAAI,2BAA2B,CAAC;4BAC9B,WAAW,EAAE,IAAI;4BACjB,gBAAgB;yBACjB,CAAC;wBACF,IAAI,+BAA+B,CAAC;4BAClC,aAAa;4BACb,cAAc;yBACf,CAAC;wBACF,IAAI,kCAAkC,EAAE;wBACxC,IAAI,iCAAiC,EAAE;qBACxC,CAAC,CAAC;oBAEH,MAAM,gBAAgB,GAAG,SAAS,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;oBACpD,MAAM,cAAc,GAAG,SAAS,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC;oBACjD,qCAAqC;oBACrC,MAAM,EAAE,WAAW,EAAE,MAAM,EAAE,QAAQ,EAAE,cAAc,EAAE,GACrD,WAAW,CAAC,MAAM,CAChB,CAAC,GAAG,EAAE,IAAI,EAAE,EAAE;wBACZ,IAAI,IAAI,CAAC,QAAQ,KAAK,cAAc,EAAE,CAAC;4BACrC,GAAG,CAAC,WAAW,GAAG,IAAI,CAAC;wBACzB,CAAC;6BAAM,IAAI,gBAAgB,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,OAAO,EAAE,CAAC;4BACnD,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;wBACxB,CAAC;6BAAM,IAAI,cAAc,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,OAAO,EAAE,CAAC;4BACjD,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;wBAC1B,CAAC;6BAAM,CAAC;4BACN,GAAG,CAAC,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;wBAChC,CAAC;wBACD,OAAO,GAAG,CAAC;oBACb,CAAC,EACD;wBACE,WAAW,EAAE,IAAI;wBACjB,QAAQ,EAAE,EAAE;wBACZ,MAAM,EAAE,EAAE;wBACV,cAAc,EAAE,EAAE;qBAMnB,CACF,CAAC;oBAEJ,IAAI,WAAW,EAAE,CAAC;wBAChB,eAAe,CAAC;4BACd,IAAI,EAAE,0BAA0B;yBACjC,CAAC,CAAC;wBAEH,MAAM,gBAAgB,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC;wBAEtC,MAAM,QAAQ,CAAC,aAAa,CAAC,KAAK,CAAC,OAAO,CAAC,eAAe,EAAE,MAAM,CAAC,CAAC;oBACtE,CAAC;oBAED,MAAM,gBAAgB,CAAC,MAAM,CAAC,CAAC;oBAC/B,MAAM,gBAAgB,CAAC,QAAQ,CAAC,CAAC;oBACjC,MAAM,gBAAgB,CAAC,cAAc,CAAC,CAAC;oBAEvC,YAAY,CAAoB;wBAC9B,IAAI,EAAE,wBAAwB;wBAC9B,KAAK,EAAE,WAAW;qBACnB,CAAC,CAAC;gBACL,CAAC;gBAAC,OAAO,GAAG,EAAE,CAAC;oBACb,MAAM,KAAK,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,eAAe,CAAC,CAAC;oBACtE,YAAY,CAAiB;wBAC3B,IAAI,EAAE,uBAAuB;wBAC7B,KAAK;qBACN,CAAC,CAAC;gBACL,CAAC;gBACD,MAAM;YACR,CAAC;YAED;gBACE,MAAM,IAAI,KAAK,CAAC,oBAAoB,KAAK,EAAE,CAAC,CAAC;QACjD,CAAC;IACH,CAAC,CAAC;AACJ,CAAC,CAAC"}
+{"version":3,"file":"post-processing.js","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/handlers/post-processing.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,UAAU,EAAE,MAAM,kCAAkC,CAAC;AAC9D,OAAO,EAAE,KAAK,EAAE,MAAM,gBAAgB,CAAC;AACvC,OAAO,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAC;AAE/D,OAAO,EACL,iCAAiC,EACjC,YAAY,EACZ,uBAAuB,EACvB,wBAAwB,GACzB,MAAM,iBAAiB,CAAC;AAUzB,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,oBAAoB,EAAE,MAAM,8BAA8B,CAAC;AACpE,OAAO,EAAE,sBAAsB,EAAE,MAAM,oBAAoB,CAAC;AAC5D,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAE1D,MAAM,CAAC,MAAM,gBAAgB,GAAG,CAC9B,KAAY,EACZ,EACE,cAAc,EACd,QAAQ,EACR,gBAAgB,EAChB,OAAO,GACiB,EAC1B,EAAE;IACF,MAAM,YAAY,GAAG,cAAc,CAAkB,KAAK,CAAC,CAAC;IAC5D,MAAM,cAAc,GAAG,oBAAoB,CAAC,KAAK,EAAE,gBAAgB,CAAC,CAAC;IACrE,MAAM,eAAe,GAAG,sBAAsB,CAAC,KAAK,EAAE,gBAAgB,CAAC,CAAC;IACxE,MAAM,EAAE,sBAAsB,EAAE,GAAG,oBAAoB,CAAC,KAAK,CAAC,CAAC;IAC/D,MAAM,gBAAgB,GAAG,KAAK,EAAE,KAAqB,EAAE,EAAE;QACvD,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACzB,wCAAwC;YACxC,KAAK,cAAc,CAAC;gBAClB,IAAI,EAAE,OAAO;gBACb,QAAQ,EAAE,IAAI,CAAC,QAAQ;aACxB,CAAC,CAAC;QACL,CAAC;QAED,MAAM,OAAO,CAAC,GAAG,CACf,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CACjB,cAAc,CAAC,eAAe,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,CAAC,OAAO,CAAC,CAC5D,CACF,CAAC;QAEF,oEAAoE;QACpE,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACrB,UAAU,CAAC,oBAAoB,EAAE,CAAC;YAElC,gCAAgC;YAChC,KAAK,CAAC,aAAa,CAAC;gBAClB,wBAAwB,EAAE,IAAI,CAAC,GAAG,EAAE;aACrC,CAAC,CAAC;QACL,CAAC;IACH,CAAC,CAAC;IAEF,gDAAgD;IAChD,MAAM,kBAAkB,GAAG,KAAK,EAAE,YAA0B,EAAE,EAAE;QAC9D,iEAAiE;QAEjE,wDAAwD;QACxD,oBAAoB;QACpB,yBAAyB;QACzB,KAAK;QAEL,+BAA+B;QAC/B,yCAAyC;QACzC,0BAA0B;QAC1B,uBAAuB;QACvB,iDAAiD;QACjD,qCAAqC;QACrC,UAAU;QACV,2BAA2B;QAC3B,QAAQ;QACR,IAAI;QAEJ,2DAA2D;QAC3D,+BAA+B;QAC/B,8CAA8C;QAC9C,6CAA6C;QAC7C,YAAY;QACZ,gBAAgB;QAChB,mCAAmC;QACnC,oCAAoC;QACpC,sDAAsD;QACtD,KAAK;QAEL,oCAAoC;QACpC,+CAA+C;QAC/C,qBAAqB;QACrB,qBAAqB;QACrB,iCAAiC;QACjC,wBAAwB;QACxB,QAAQ;QACR,IAAI;QAEJ,MAAM,QAAQ,CAAC,aAAa,CAAC,KAAK,CAAC,OAAO,CAAC,eAAe,EAAE,MAAM,CAAC,CAAC;QAEpE,oCAAoC;QACpC,yCAAyC;QACzC,qBAAqB;QACrB,yBAAyB;QACzB,iDAAiD;QACjD,qCAAqC;QACrC,UAAU;QACV,QAAQ;QACR,IAAI;IACN,CAAC,CAAC;IAEF,OAAO,KAAK,EAAE,EAAE,KAAK,EAAmB,EAAiB,EAAE;QACzD,QAAQ,KAAK,CAAC,IAAI,EAAE,CAAC;YACnB,KAAK,YAAY,CAAC,CAAC,CAAC;gBAClB,MAAM,EAAE,KAAK,EAAE,GAAG,KAAK,CAAC;gBACxB,sEAAsE;gBACtE,gEAAgE;gBAChE,MAAM,UAAU,GAAG,kBAAkB,CAAC,KAAK,CAAC,UAAU,EAAE,KAAK,CAAC,QAAQ,CAAC,CAAC;gBACxE,MAAM,qBAAqB,GAAG,kBAAkB,CAC9C,KAAK,CAAC,WAAW,EACjB,KAAK,CAAC,cAAc,EACpB,KAAK,CAAC,gBAAgB,CACvB,CAAC;gBAEF,IAAI,CAAC;oBACH,MAAM,EAAE,WAAW,EAAE,MAAM,EAAE,kBAAkB,EAAE,UAAU,EAAE,GAC3D,KAAK,CAAC,MAAM,CACV,CAAC,GAAG,EAAE,IAAI,EAAE,EAAE;wBACZ,IAAI,IAAI,CAAC,QAAQ,KAAK,KAAK,CAAC,WAAW,EAAE,CAAC;4BACxC,GAAG,CAAC,WAAW,GAAG,IAAI,CAAC;wBACzB,CAAC;6BAAM,IAAI,UAAU,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,OAAO,EAAE,CAAC;4BAC7C,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;wBACxB,CAAC;6BAAM,IAAI,qBAAqB,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,OAAO,EAAE,CAAC;4BACxD,GAAG,CAAC,kBAAkB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;wBACpC,CAAC;6BAAM,IAAI,IAAI,CAAC,QAAQ,KAAK,KAAK,CAAC,QAAQ,EAAE,CAAC;4BAC5C,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;wBAC5B,CAAC;wBACD,OAAO,GAAG,CAAC;oBACb,CAAC,EACD;wBACE,WAAW,EAAE,IAA2B;wBACxC,MAAM,EAAE,EAAoB;wBAC5B,kBAAkB,EAAE,EAAoB;wBACxC,UAAU,EAAE,EAAoB;qBACjC,CACF,CAAC;oBAEJ,MAAM,gBAAgB,GACpB,CAAC,KAAK,CAAC,OAAO,CAAC,aAAa,IAAI,sBAAsB,EAAE,CAAC;oBAE3D,IAAI,gBAAgB,EAAE,CAAC;wBACrB,KAAK,eAAe,CAAC;4BACnB,IAAI,EAAE,MAAM;4BACZ,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,gBAAgB;4BACvB,OAAO,EACL,+FAA+F;yBAClG,CAAC,CAAC;wBAEH,+BAA+B;wBAC/B,KAAK,eAAe,CAClB;4BACE,IAAI,EAAE,SAAS;4BACf,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,0BAA0B;4BACjC,MAAM,EAAE,SAAS;4BACjB,OAAO,EAAE,6BAA6B;yBACvC,EACD,GAAG,CACJ,CAAC;wBAEF,oCAAoC;wBACpC,KAAK,eAAe,CAClB;4BACE,IAAI,EAAE,SAAS;4BACf,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,0BAA0B;4BACjC,MAAM,EAAE,WAAW;4BACnB,OAAO,EAAE,6BAA6B;yBACvC,EACD,IAAI,CACL,CAAC;oBACJ,CAAC;oBAED,IAAI,WAAW,EAAE,CAAC;wBAChB,MAAM,gBAAgB,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC;wBACtC,MAAM,kBAAkB,CAAC,WAAW,CAAC,CAAC;oBACxC,CAAC;oBAED,MAAM,gBAAgB,CAAC,MAAM,CAAC,CAAC;oBAC/B,MAAM,gBAAgB,CAAC,kBAAkB,CAAC,CAAC;oBAC3C,MAAM,gBAAgB,CAAC,UAAU,CAAC,CAAC;oBAEnC,IACE,WAAW;wBACX,MAAM,CAAC,MAAM,KAAK,CAAC;wBACnB,kBAAkB,CAAC,MAAM,KAAK,CAAC,EAC/B,CAAC;wBACD,wBAAwB;wBACxB,KAAK,YAAY,CAAQ;4BACvB,IAAI,EAAE,iCAAiC;yBACxC,CAAC,CAAC;oBACL,CAAC;oBAED,IAAI,gBAAgB,EAAE,CAAC;wBACrB,+BAA+B;wBAC/B,KAAK,eAAe,CAAC;4BACnB,IAAI,EAAE,SAAS;4BACf,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,sBAAsB;4BAC7B,MAAM,EAAE,SAAS;4BACjB,OAAO,EAAE,+BAA+B;yBACzC,CAAC,CAAC;wBAEH,oCAAoC;wBACpC,KAAK,eAAe,CAClB;4BACE,IAAI,EAAE,SAAS;4BACf,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,sBAAsB;4BAC7B,MAAM,EAAE,WAAW;4BACnB,OAAO,EAAE,+BAA+B;yBACzC,EACD,IAAI,CACL,CAAC;wBAEF,KAAK,eAAe,CAAC;4BACnB,IAAI,EAAE,MAAM;4BACZ,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,gBAAgB;4BACvB,OAAO,EACL,4EAA4E;yBAC/E,CAAC,CAAC;oBACL,CAAC;oBAED,KAAK,YAAY,CAAoB;wBACnC,IAAI,EAAE,wBAAwB;wBAC9B,KAAK,EAAE,KAAK;qBACb,CAAC,CAAC;gBACL,CAAC;gBAAC,OAAO,GAAG,EAAE,CAAC;oBACb,MAAM,KAAK,GAAG,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,KAAK,CAAC,eAAe,CAAC,CAAC;oBAEtE,qBAAqB;oBACrB,OAAO,CAAC,IAAI,CAAC,kBAAkB,EAAE,KAAK,CAAC,CAAC;oBAExC,KAAK,YAAY,CAAiB;wBAChC,IAAI,EAAE,uBAAuB;wBAC7B,KAAK;qBACN,CAAC,CAAC;gBACL,CAAC;gBACD,MAAM;YACR,CAAC;YAED;gBACE,MAAM,IAAI,KAAK,CAAC,oBAAoB,KAAK,EAAE,CAAC,CAAC;QACjD,CAAC;IACH,CAAC,CAAC;AACJ,CAAC,CAAC;AAEF,+CAA+C;AAC/C,MAAM,CAAC,MAAM,uBAAuB,GAAG,KAAK,EAC1C,cAA8B,EAC9B,yBAAiC,EAMjC,EAAE;IACF,wFAAwF;IACxF,MAAM,IAAI,GAAG,MAAM,cAAc,CAAC,YAAY,CAAC,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC,CAAC;IAEpE,IAAI,CAAC,IAAI,EAAE,CAAC;QACV,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,IAAI,kBAGH,CAAC;IACF,IAAI,CAAC;QACH,kBAAkB,GAAG,IAAI,CAAC,KAAK,CAAC,yBAAyB,CAAC,CAAC;IAC7D,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,EAAE,CAAC;IACZ,CAAC;IAED,MAAM,kBAAkB,GAAG,IAAI,GAAG,CAAS;QACzC,sDAAsD;QACtD,GAAG,MAAM,CAAC,IAAI,CAAC,kBAAkB,CAAC,YAAY,IAAI,EAAE,CAAC;KACtD,CAAC,CAAC;IAEH,MAAM,OAAO,GAA8D,EAAE,CAAC;IAC9E,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAE/B,MAAM,aAAa,GAAG,IAAI,GAAG,EAAU,CAAC;IACxC,MAAM,eAAe,GAAG,IAAI,GAAG,EAAU,CAAC;IAE1C,MAAM,YAAY,GAAG,6BAA6B,CAAC;IAEnD,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,8BAA8B;QAC9B,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;YACnD,SAAS;QACX,CAAC;QAED,6CAA6C;QAC7C,IAAI,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,EAAE,CAAC;YACrD,SAAS;QACX,CAAC;QAED,MAAM,WAAW,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,+BAA+B;QAClE,MAAM,KAAK,GAAG,WAAW,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC;QAE9C,IAAI,KAAK,EAAE,CAAC;YACV,MAAM,WAAW,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC;YAE7B,IAAI,CAAC,WAAW,EAAE,CAAC;gBACjB,SAAS;YACX,CAAC;YAED,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;gBACzB,0EAA0E;gBAC1E,IAAI,kBAAkB,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;oBACxC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;gBACjC,CAAC;YACH,CAAC;iBAAM,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;gBAChC,8DAA8D;gBAC9D,IAAI,CAAC,+BAA+B,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;oBACtD,eAAe,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC;gBACnC,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,gDAAgD;IAChD,KAAK,MAAM,WAAW,IAAI,aAAa,EAAE,CAAC;QACxC,IAAI,eAAe,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YACrC,gDAAgD;YAChD,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,CAAC;QACvD,CAAC;aAAM,CAAC;YACN,yCAAyC;YACzC,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,CAAC;QACzD,CAAC;IACH,CAAC;IACD,KAAK,MAAM,WAAW,IAAI,eAAe,EAAE,CAAC;QAC1C,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YACpC,OAAO,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,CAAC;QACzD,CAAC;IACH,CAAC;IAED,OAAO,OAAO,CAAC;AACjB,CAAC,CAAC;AAEF,MAAM,+BAA+B,GAAG,IAAI,GAAG,CAAC;IAC9C,MAAM;IACN,SAAS;IACT,aAAa;IACb,MAAM;IACN,SAAS;IACT,UAAU;IACV,QAAQ;IACR,SAAS;IACT,YAAY;IACZ,UAAU;IACV,MAAM;CACP,CAAC,CAAC"}

package/dist/ai-service/state-machine/handlers/runtime-reviewing.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"runtime-reviewing.d.ts","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/handlers/runtime-reviewing.ts"],"names":[],"mappings":"AAQA,OAAO,KAAK,EAKV,KAAK,EACL,eAAe,EAChB,MAAM,iBAAiB,CAAC;AACzB,OAAO,KAAK,EAAE,uBAAuB,EAAE,MAAM,iBAAiB,CAAC;AAE/D,eAAO,MAAM,kBAAkB,GAC7B,OAAO,KAAK,EACZ,QAAQ,uBAAuB,MAIjB,WAAW,eAAe,KAAG,OAAO,CAAC,IAAI,CAwCxD,CAAC"}
+{"version":3,"file":"runtime-reviewing.d.ts","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/handlers/runtime-reviewing.ts"],"names":[],"mappings":"AAUA,OAAO,KAAK,EAKV,KAAK,EACL,eAAe,EAChB,MAAM,iBAAiB,CAAC;AACzB,OAAO,KAAK,EAAE,uBAAuB,EAAE,MAAM,iBAAiB,CAAC;AAK/D,eAAO,MAAM,kBAAkB,GAC7B,OAAO,KAAK,EACZ,QAAQ,uBAAuB,MASjB,WAAW,eAAe,KAAG,OAAO,CAAC,IAAI,CA0LxD,CAAC"}

package/dist/ai-service/state-machine/handlers/runtime-reviewing.js

@@ -1,32 +1,142 @@
+import { Paths } from "../../const.js";
+import { getIntegrationErrorsInFiles } from "../../integration-validator.js";
+import { matchMultiplePaths, matchPath } from "../../transform/shared.js";
 import { APP_RUNTIME_UPDATED_WITHOUT_EDITS, POST_PROCESSING_FINISHED, RUNTIME_REVIEW_ERRORED, RUNTIME_REVIEW_FINISHED, USER_REJECTED_DRAFT, } from "../clark-fsm.js";
+import { sendChangeInfoHelper } from "../helpers/change-info.js";
+import { sendUserMessageChannel } from "../helpers/peer.js";
 import { transitionFrom } from "../helpers/transition.js";
 export const doRuntimeReviewing = (clark, params) => {
     const transitionTo = transitionFrom(clark);
+    const sendChangeInfo = sendChangeInfoHelper(clark, params.chatSessionStore);
+    const sendUserMessage = sendUserMessageChannel(clark, params.chatSessionStore);
     return async ({ event }) => {
         switch (event.type) {
             case USER_REJECTED_DRAFT:
+                console.log(`[doRuntimeReviewing] USER_REJECTED_DRAFT`, event);
+                if (!event.silently) {
+                    const chatmessageId = await params.chatSessionStore.recordUserRejection();
+                    if (chatmessageId) {
+                        clark.updateContext({
+                            chatmessageId,
+                        });
+                    }
+                }
+                await params.appShell.clearScratchDirectory();
                 // the draft is reverting now...
-                // in the future we would do a runtime check to make sure nothing exploded
-                transitionTo({
+                void transitionTo({
                     type: APP_RUNTIME_UPDATED_WITHOUT_EDITS,
                 });
                 break;
             case POST_PROCESSING_FINISHED:
                 {
                     const { files } = event;
+                    // AI-1053: always use debug loop for now
+                    // const useDebugLoop =
+                    //   await clark.context.promptInterpretTask?.isFullAppOrBroadUpdate();
+                    const useDebugLoop = true;
                     clark.updateContext((context) => ({
                         ...context,
                         hasSuggestions: context.hasSuggestions || files.length > 0,
                     }));
+                    if (!useDebugLoop) {
+                        for (const filePath of Object.keys(clark.context.generatedChangeInfo ?? {})) {
+                            void sendChangeInfo({
+                                type: "validated",
+                                filePath,
+                            });
+                        }
+                        void transitionTo({
+                            type: RUNTIME_REVIEW_FINISHED,
+                        });
+                        break;
+                    }
+                    if (!clark.context.usedDebugging) {
+                        void sendUserMessage({
+                            type: "text",
+                            role: "assistant",
+                            group: "agent-qa",
+                            content: "Great, I'll confirm this app works as expected.",
+                        });
+                    }
+                    void sendUserMessage({
+                        type: "control",
+                        role: "assistant",
+                        group: "agent-qa/code-errors",
+                        status: "pending",
+                        content: "Identifying code errors",
+                    });
+                    void sendUserMessage({
+                        type: "control",
+                        role: "assistant",
+                        group: "agent-qa/user-flows",
+                        status: "pending",
+                        content: "Validating user flows",
+                    });
+                    void sendUserMessage({
+                        type: "control",
+                        role: "assistant",
+                        group: "agent-qa/design-system",
+                        status: "pending",
+                        content: "Validating design system adherence",
+                    });
+                    const lintable = matchMultiplePaths(Paths.PageIndexes, Paths.ComponentsFile, Paths.ComponentsFolder, Paths.AppScope, Paths.PageScopes);
+                    const lintErrorsByPath = await params.appShell.runLinter(files
+                        .map((file) => file.filePath)
+                        .filter((filePath) => lintable(filePath).matched), clark.context.abortController?.signal);
+                    // n.b. don't race these because we want to typecheck after potential lint autofixes
                     const tsErrorsByPath = await params.appShell.runTypecheck(clark.context.abortController?.signal);
-                    if (tsErrorsByPath) {
-                        transitionTo({
+                    // Validate integration references - only on API files
+                    const availableIntegrations = clark.context.availableIntegrations ?? [];
+                    const apiMatcher = matchPath(Paths.GeneratedApis);
+                    const apiFiles = files.filter((file) => apiMatcher(file.filePath).matched);
+                    const integrationErrorsByPath = getIntegrationErrorsInFiles(apiFiles, availableIntegrations);
+                    if (tsErrorsByPath || lintErrorsByPath || integrationErrorsByPath) {
+                        void transitionTo({
                             type: RUNTIME_REVIEW_ERRORED,
-                            tsErrorsByPath,
+                            tsErrorsByPath: tsErrorsByPath ?? {},
+                            lintErrorsByPath: lintErrorsByPath ?? {},
+                            integrationErrorsByPath: integrationErrorsByPath ?? {},
                         });
                     }
                     else {
-                        transitionTo({
+                        for (const filePath of Object.keys(clark.context.generatedChangeInfo ?? {})) {
+                            void sendChangeInfo({
+                                type: "validated",
+                                filePath,
+                            });
+                        }
+                        let delay = 500;
+                        if (clark.context.usedDebugging) {
+                            void sendUserMessage({
+                                type: "text",
+                                role: "assistant",
+                                group: "agent-qa",
+                                content: "Looks like the Engineer Agent has fixed the bugs I've reported. We're good to go!",
+                            });
+                            delay = 0;
+                        }
+                        void sendUserMessage({
+                            type: "control",
+                            role: "assistant",
+                            group: "agent-qa/code-errors",
+                            status: "validated",
+                            content: "Identifying code errors",
+                        }, delay);
+                        void sendUserMessage({
+                            type: "control",
+                            role: "assistant",
+                            group: "agent-qa/user-flows",
+                            status: "validated",
+                            content: "Validating user flows",
+                        }, delay + 500);
+                        void sendUserMessage({
+                            type: "control",
+                            role: "assistant",
+                            group: "agent-qa/design-system",
+                            status: "validated",
+                            content: "Validating design system adherence",
+                        }, delay + 1000);
+                        void transitionTo({
                             type: RUNTIME_REVIEW_FINISHED,
                         });
                     }

package/dist/ai-service/state-machine/handlers/runtime-reviewing.js.map

@@ -1 +1 @@
-{"version":3,"file":"runtime-reviewing.js","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/handlers/runtime-reviewing.ts"],"names":[],"mappings":"AAAA,OAAO,EACL,iCAAiC,EACjC,wBAAwB,EACxB,sBAAsB,EACtB,uBAAuB,EACvB,mBAAmB,GACpB,MAAM,iBAAiB,CAAC;AACzB,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAW1D,MAAM,CAAC,MAAM,kBAAkB,GAAG,CAChC,KAAY,EACZ,MAA+B,EAC/B,EAAE;IACF,MAAM,YAAY,GAAG,cAAc,CAAoB,KAAK,CAAC,CAAC;IAE9D,OAAO,KAAK,EAAE,EAAE,KAAK,EAAmB,EAAiB,EAAE;QACzD,QAAQ,KAAK,CAAC,IAAI,EAAE,CAAC;YACnB,KAAK,mBAAmB;gBACtB,gCAAgC;gBAChC,0EAA0E;gBAC1E,YAAY,CAAQ;oBAClB,IAAI,EAAE,iCAAiC;iBACxC,CAAC,CAAC;gBACH,MAAM;YAER,KAAK,wBAAwB;gBAC3B,CAAC;oBACC,MAAM,EAAE,KAAK,EAAE,GAAG,KAAK,CAAC;oBAExB,KAAK,CAAC,aAAa,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;wBAChC,GAAG,OAAO;wBACV,cAAc,EAAE,OAAO,CAAC,cAAc,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC;qBAC3D,CAAC,CAAC,CAAC;oBAEJ,MAAM,cAAc,GAAG,MAAM,MAAM,CAAC,QAAQ,CAAC,YAAY,CACvD,KAAK,CAAC,OAAO,CAAC,eAAe,EAAE,MAAM,CACtC,CAAC;oBAEF,IAAI,cAAc,EAAE,CAAC;wBACnB,YAAY,CAAiB;4BAC3B,IAAI,EAAE,sBAAsB;4BAC5B,cAAc;yBACf,CAAC,CAAC;oBACL,CAAC;yBAAM,CAAC;wBACN,YAAY,CAAgB;4BAC1B,IAAI,EAAE,uBAAuB;yBAC9B,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;gBACD,MAAM;YAER;gBACE,MAAM,IAAI,KAAK,CAAC,oBAAoB,KAAK,EAAE,CAAC,CAAC;QACjD,CAAC;IACH,CAAC,CAAC;AACJ,CAAC,CAAC"}
+{"version":3,"file":"runtime-reviewing.js","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/handlers/runtime-reviewing.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,gBAAgB,CAAC;AACvC,OAAO,EAAE,2BAA2B,EAAE,MAAM,gCAAgC,CAAC;AAC7E,OAAO,EAAE,kBAAkB,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AAC1E,OAAO,EACL,iCAAiC,EACjC,wBAAwB,EACxB,sBAAsB,EACtB,uBAAuB,EACvB,mBAAmB,GACpB,MAAM,iBAAiB,CAAC;AAUzB,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AACjE,OAAO,EAAE,sBAAsB,EAAE,MAAM,oBAAoB,CAAC;AAC5D,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAE1D,MAAM,CAAC,MAAM,kBAAkB,GAAG,CAChC,KAAY,EACZ,MAA+B,EAC/B,EAAE;IACF,MAAM,YAAY,GAAG,cAAc,CAAoB,KAAK,CAAC,CAAC;IAC9D,MAAM,cAAc,GAAG,oBAAoB,CAAC,KAAK,EAAE,MAAM,CAAC,gBAAgB,CAAC,CAAC;IAC5E,MAAM,eAAe,GAAG,sBAAsB,CAC5C,KAAK,EACL,MAAM,CAAC,gBAAgB,CACxB,CAAC;IAEF,OAAO,KAAK,EAAE,EAAE,KAAK,EAAmB,EAAiB,EAAE;QACzD,QAAQ,KAAK,CAAC,IAAI,EAAE,CAAC;YACnB,KAAK,mBAAmB;gBACtB,OAAO,CAAC,GAAG,CAAC,0CAA0C,EAAE,KAAK,CAAC,CAAC;gBAC/D,IAAI,CAAC,KAAK,CAAC,QAAQ,EAAE,CAAC;oBACpB,MAAM,aAAa,GACjB,MAAM,MAAM,CAAC,gBAAgB,CAAC,mBAAmB,EAAE,CAAC;oBACtD,IAAI,aAAa,EAAE,CAAC;wBAClB,KAAK,CAAC,aAAa,CAAC;4BAClB,aAAa;yBACd,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;gBACD,MAAM,MAAM,CAAC,QAAQ,CAAC,qBAAqB,EAAE,CAAC;gBAC9C,gCAAgC;gBAChC,KAAK,YAAY,CAAQ;oBACvB,IAAI,EAAE,iCAAiC;iBACxC,CAAC,CAAC;gBACH,MAAM;YAER,KAAK,wBAAwB;gBAC3B,CAAC;oBACC,MAAM,EAAE,KAAK,EAAE,GAAG,KAAK,CAAC;oBACxB,yCAAyC;oBACzC,uBAAuB;oBACvB,uEAAuE;oBACvE,MAAM,YAAY,GAAG,IAAI,CAAC;oBAE1B,KAAK,CAAC,aAAa,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;wBAChC,GAAG,OAAO;wBACV,cAAc,EAAE,OAAO,CAAC,cAAc,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC;qBAC3D,CAAC,CAAC,CAAC;oBAEJ,IAAI,CAAC,YAAY,EAAE,CAAC;wBAClB,KAAK,MAAM,QAAQ,IAAI,MAAM,CAAC,IAAI,CAChC,KAAK,CAAC,OAAO,CAAC,mBAAmB,IAAI,EAAE,CACxC,EAAE,CAAC;4BACF,KAAK,cAAc,CAAC;gCAClB,IAAI,EAAE,WAAW;gCACjB,QAAQ;6BACT,CAAC,CAAC;wBACL,CAAC;wBACD,KAAK,YAAY,CAAgB;4BAC/B,IAAI,EAAE,uBAAuB;yBAC9B,CAAC,CAAC;wBACH,MAAM;oBACR,CAAC;oBAED,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,aAAa,EAAE,CAAC;wBACjC,KAAK,eAAe,CAAC;4BACnB,IAAI,EAAE,MAAM;4BACZ,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,UAAU;4BACjB,OAAO,EAAE,iDAAiD;yBAC3D,CAAC,CAAC;oBACL,CAAC;oBAED,KAAK,eAAe,CAAC;wBACnB,IAAI,EAAE,SAAS;wBACf,IAAI,EAAE,WAAW;wBACjB,KAAK,EAAE,sBAAsB;wBAC7B,MAAM,EAAE,SAAS;wBACjB,OAAO,EAAE,yBAAyB;qBACnC,CAAC,CAAC;oBAEH,KAAK,eAAe,CAAC;wBACnB,IAAI,EAAE,SAAS;wBACf,IAAI,EAAE,WAAW;wBACjB,KAAK,EAAE,qBAAqB;wBAC5B,MAAM,EAAE,SAAS;wBACjB,OAAO,EAAE,uBAAuB;qBACjC,CAAC,CAAC;oBAEH,KAAK,eAAe,CAAC;wBACnB,IAAI,EAAE,SAAS;wBACf,IAAI,EAAE,WAAW;wBACjB,KAAK,EAAE,wBAAwB;wBAC/B,MAAM,EAAE,SAAS;wBACjB,OAAO,EAAE,oCAAoC;qBAC9C,CAAC,CAAC;oBAEH,MAAM,QAAQ,GAAG,kBAAkB,CACjC,KAAK,CAAC,WAAW,EACjB,KAAK,CAAC,cAAc,EACpB,KAAK,CAAC,gBAAgB,EACtB,KAAK,CAAC,QAAQ,EACd,KAAK,CAAC,UAAU,CACjB,CAAC;oBAEF,MAAM,gBAAgB,GAAG,MAAM,MAAM,CAAC,QAAQ,CAAC,SAAS,CACtD,KAAK;yBACF,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC;yBAC5B,MAAM,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,EACnD,KAAK,CAAC,OAAO,CAAC,eAAe,EAAE,MAAM,CACtC,CAAC;oBACF,oFAAoF;oBACpF,MAAM,cAAc,GAAG,MAAM,MAAM,CAAC,QAAQ,CAAC,YAAY,CACvD,KAAK,CAAC,OAAO,CAAC,eAAe,EAAE,MAAM,CACtC,CAAC;oBAEF,sDAAsD;oBACtD,MAAM,qBAAqB,GACzB,KAAK,CAAC,OAAO,CAAC,qBAAqB,IAAI,EAAE,CAAC;oBAC5C,MAAM,UAAU,GAAG,SAAS,CAAC,KAAK,CAAC,aAAa,CAAC,CAAC;oBAClD,MAAM,QAAQ,GAAG,KAAK,CAAC,MAAM,CAC3B,CAAC,IAAI,EAAE,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,OAAO,CAC5C,CAAC;oBACF,MAAM,uBAAuB,GAAG,2BAA2B,CACzD,QAAQ,EACR,qBAAqB,CACtB,CAAC;oBAEF,IAAI,cAAc,IAAI,gBAAgB,IAAI,uBAAuB,EAAE,CAAC;wBAClE,KAAK,YAAY,CAAiB;4BAChC,IAAI,EAAE,sBAAsB;4BAC5B,cAAc,EAAE,cAAc,IAAI,EAAE;4BACpC,gBAAgB,EAAE,gBAAgB,IAAI,EAAE;4BACxC,uBAAuB,EAAE,uBAAuB,IAAI,EAAE;yBACvD,CAAC,CAAC;oBACL,CAAC;yBAAM,CAAC;wBACN,KAAK,MAAM,QAAQ,IAAI,MAAM,CAAC,IAAI,CAChC,KAAK,CAAC,OAAO,CAAC,mBAAmB,IAAI,EAAE,CACxC,EAAE,CAAC;4BACF,KAAK,cAAc,CAAC;gCAClB,IAAI,EAAE,WAAW;gCACjB,QAAQ;6BACT,CAAC,CAAC;wBACL,CAAC;wBACD,IAAI,KAAK,GAAG,GAAG,CAAC;wBAEhB,IAAI,KAAK,CAAC,OAAO,CAAC,aAAa,EAAE,CAAC;4BAChC,KAAK,eAAe,CAAC;gCACnB,IAAI,EAAE,MAAM;gCACZ,IAAI,EAAE,WAAW;gCACjB,KAAK,EAAE,UAAU;gCACjB,OAAO,EACL,mFAAmF;6BACtF,CAAC,CAAC;4BAEH,KAAK,GAAG,CAAC,CAAC;wBACZ,CAAC;wBAED,KAAK,eAAe,CAClB;4BACE,IAAI,EAAE,SAAS;4BACf,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,sBAAsB;4BAC7B,MAAM,EAAE,WAAW;4BACnB,OAAO,EAAE,yBAAyB;yBACnC,EACD,KAAK,CACN,CAAC;wBAEF,KAAK,eAAe,CAClB;4BACE,IAAI,EAAE,SAAS;4BACf,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,qBAAqB;4BAC5B,MAAM,EAAE,WAAW;4BACnB,OAAO,EAAE,uBAAuB;yBACjC,EACD,KAAK,GAAG,GAAG,CACZ,CAAC;wBAEF,KAAK,eAAe,CAClB;4BACE,IAAI,EAAE,SAAS;4BACf,IAAI,EAAE,WAAW;4BACjB,KAAK,EAAE,wBAAwB;4BAC/B,MAAM,EAAE,WAAW;4BACnB,OAAO,EAAE,oCAAoC;yBAC9C,EACD,KAAK,GAAG,IAAI,CACb,CAAC;wBAEF,KAAK,YAAY,CAAgB;4BAC/B,IAAI,EAAE,uBAAuB;yBAC9B,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;gBACD,MAAM;YAER;gBACE,MAAM,IAAI,KAAK,CAAC,oBAAoB,KAAK,EAAE,CAAC,CAAC;QACjD,CAAC;IACH,CAAC,CAAC;AACJ,CAAC,CAAC"}

package/dist/ai-service/state-machine/helpers/background-chat-record-metrics.d.ts

@@ -0,0 +1,7 @@
+type ChatRecordDropReason = "stale_turn";
+type ChatRecordFailureReason = "callback_error" | "record_error";
+export declare function recordChatRecordDrop(reason: ChatRecordDropReason): void;
+export declare function recordChatRecordFailure(reason: ChatRecordFailureReason): void;
+export declare function _resetChatRecordMetricsForTesting(): void;
+export {};
+//# sourceMappingURL=background-chat-record-metrics.d.ts.map

package/dist/ai-service/state-machine/helpers/background-chat-record-metrics.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"background-chat-record-metrics.d.ts","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/helpers/background-chat-record-metrics.ts"],"names":[],"mappings":"AAEA,KAAK,oBAAoB,GAAG,YAAY,CAAC;AAEzC,KAAK,uBAAuB,GAAG,gBAAgB,GAAG,cAAc,CAAC;AAsDjE,wBAAgB,oBAAoB,CAAC,MAAM,EAAE,oBAAoB,GAAG,IAAI,CAEvE;AAED,wBAAgB,uBAAuB,CAAC,MAAM,EAAE,uBAAuB,GAAG,IAAI,CAE7E;AAED,wBAAgB,iCAAiC,IAAI,IAAI,CAExD"}

package/dist/ai-service/state-machine/helpers/background-chat-record-metrics.js

@@ -0,0 +1,47 @@
+import { metrics } from "@opentelemetry/api";
+const METER_NAME = "superblocks.clark.chat";
+const METRIC_RECORD_DROPS = "superblocks.clark.chat.record_drops";
+const METRIC_RECORD_FAILURES = "superblocks.clark.chat.record_failures";
+class ChatRecordMetrics {
+    cachedMeter;
+    cachedInstruments;
+    getInstruments() {
+        const meter = metrics.getMeter(METER_NAME);
+        if (meter === this.cachedMeter && this.cachedInstruments) {
+            return this.cachedInstruments;
+        }
+        this.cachedMeter = meter;
+        this.cachedInstruments = {
+            dropCounter: meter.createCounter(METRIC_RECORD_DROPS, {
+                description: "Background chat-record results dropped before they could update the current turn.",
+                unit: "1",
+            }),
+            failureCounter: meter.createCounter(METRIC_RECORD_FAILURES, {
+                description: "Background chat-record write or callback failures that did not block the current turn.",
+                unit: "1",
+            }),
+        };
+        return this.cachedInstruments;
+    }
+    recordDrop(reason) {
+        this.getInstruments().dropCounter.add(1, { reason });
+    }
+    recordFailure(reason) {
+        this.getInstruments().failureCounter.add(1, { reason });
+    }
+    _resetForTesting() {
+        this.cachedMeter = undefined;
+        this.cachedInstruments = undefined;
+    }
+}
+const chatRecordMetrics = new ChatRecordMetrics();
+export function recordChatRecordDrop(reason) {
+    chatRecordMetrics.recordDrop(reason);
+}
+export function recordChatRecordFailure(reason) {
+    chatRecordMetrics.recordFailure(reason);
+}
+export function _resetChatRecordMetricsForTesting() {
+    chatRecordMetrics._resetForTesting();
+}
+//# sourceMappingURL=background-chat-record-metrics.js.map

package/dist/ai-service/state-machine/helpers/background-chat-record-metrics.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"background-chat-record-metrics.js","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/helpers/background-chat-record-metrics.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,OAAO,EAAc,MAAM,oBAAoB,CAAC;AAMzD,MAAM,UAAU,GAAG,wBAAwB,CAAC;AAC5C,MAAM,mBAAmB,GAAG,qCAAqC,CAAC;AAClE,MAAM,sBAAsB,GAAG,wCAAwC,CAAC;AASxE,MAAM,iBAAiB;IACb,WAAW,CAAoB;IAC/B,iBAAiB,CAA0B;IAE3C,cAAc;QACpB,MAAM,KAAK,GAAG,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAC;QAC3C,IAAI,KAAK,KAAK,IAAI,CAAC,WAAW,IAAI,IAAI,CAAC,iBAAiB,EAAE,CAAC;YACzD,OAAO,IAAI,CAAC,iBAAiB,CAAC;QAChC,CAAC;QACD,IAAI,CAAC,WAAW,GAAG,KAAK,CAAC;QACzB,IAAI,CAAC,iBAAiB,GAAG;YACvB,WAAW,EAAE,KAAK,CAAC,aAAa,CAAC,mBAAmB,EAAE;gBACpD,WAAW,EACT,mFAAmF;gBACrF,IAAI,EAAE,GAAG;aACV,CAAC;YACF,cAAc,EAAE,KAAK,CAAC,aAAa,CAAC,sBAAsB,EAAE;gBAC1D,WAAW,EACT,wFAAwF;gBAC1F,IAAI,EAAE,GAAG;aACV,CAAC;SACH,CAAC;QACF,OAAO,IAAI,CAAC,iBAAiB,CAAC;IAChC,CAAC;IAED,UAAU,CAAC,MAA4B;QACrC,IAAI,CAAC,cAAc,EAAE,CAAC,WAAW,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,MAAM,EAAE,CAAC,CAAC;IACvD,CAAC;IAED,aAAa,CAAC,MAA+B;QAC3C,IAAI,CAAC,cAAc,EAAE,CAAC,cAAc,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,MAAM,EAAE,CAAC,CAAC;IAC1D,CAAC;IAED,gBAAgB;QACd,IAAI,CAAC,WAAW,GAAG,SAAS,CAAC;QAC7B,IAAI,CAAC,iBAAiB,GAAG,SAAS,CAAC;IACrC,CAAC;CACF;AAED,MAAM,iBAAiB,GAAG,IAAI,iBAAiB,EAAE,CAAC;AAElD,MAAM,UAAU,oBAAoB,CAAC,MAA4B;IAC/D,iBAAiB,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;AACvC,CAAC;AAED,MAAM,UAAU,uBAAuB,CAAC,MAA+B;IACrE,iBAAiB,CAAC,aAAa,CAAC,MAAM,CAAC,CAAC;AAC1C,CAAC;AAED,MAAM,UAAU,iCAAiC;IAC/C,iBAAiB,CAAC,gBAAgB,EAAE,CAAC;AACvC,CAAC"}

package/dist/ai-service/state-machine/helpers/background-chat-record.d.ts

@@ -0,0 +1,33 @@
+/** Minimal slice of the Clark FSM needed to apply a chat-record result. */
+interface ChatRecordingClark {
+    context: {
+        promptId?: string;
+    };
+    updateContext(update: {
+        chatmessageId: string;
+    }): void;
+}
+/**
+ * Persist a chat message without blocking the turn that produced it.
+ *
+ * The server push behind `ChatSessionStore` runs at ~250ms p99 (12s max,
+ * `WS SERVER v1.ai.chat.pushMessage`) and used to be awaited before
+ * generation could start. Instead the write runs in the background and the
+ * server-assigned chatmessageId is applied to FSM context when it resolves —
+ * in practice well before the first LLM call reads it for usage attribution,
+ * since the integration fetch and prompt assembly run in between.
+ *
+ * If a newer prompt has started by the time the write resolves, the id is
+ * dropped: attributing the new turn's LLM usage to the previous turn's chat
+ * message would be worse than attributing it to none. Failures are swallowed
+ * (`ChatSessionStore` already degrades to an empty id) — losing a chat
+ * record must never fail the turn.
+ */
+export declare function recordChatMessageInBackground(options: {
+    clark: ChatRecordingClark;
+    record: () => Promise<string | undefined>;
+    /** Runs only when the write produced an id and the turn is still current. */
+    onRecorded?: (chatmessageId: string) => void;
+}): void;
+export {};
+//# sourceMappingURL=background-chat-record.d.ts.map

package/dist/ai-service/state-machine/helpers/background-chat-record.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"background-chat-record.d.ts","sourceRoot":"","sources":["../../../../src/ai-service/state-machine/helpers/background-chat-record.ts"],"names":[],"mappings":"AAMA,2EAA2E;AAC3E,UAAU,kBAAkB;IAC1B,OAAO,EAAE;QAAE,QAAQ,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC;IAC/B,aAAa,CAAC,MAAM,EAAE;QAAE,aAAa,EAAE,MAAM,CAAA;KAAE,GAAG,IAAI,CAAC;CACxD;AAED;;;;;;;;;;;;;;;GAeG;AACH,wBAAgB,6BAA6B,CAAC,OAAO,EAAE;IACrD,KAAK,EAAE,kBAAkB,CAAC;IAC1B,MAAM,EAAE,MAAM,OAAO,CAAC,MAAM,GAAG,SAAS,CAAC,CAAC;IAC1C,6EAA6E;IAC7E,UAAU,CAAC,EAAE,CAAC,aAAa,EAAE,MAAM,KAAK,IAAI,CAAC;CAC9C,GAAG,IAAI,CAoDP"}