@supaku/agentfactory-linear 0.7.47 → 0.7.49

package/dist/src/defaults/prompts.d.ts

@@ -6,6 +6,7 @@
  */
 import type { AgentWorkType, SubIssueStatus } from '../types.js';
 export declare const WORK_RESULT_MARKER_INSTRUCTION = "\n\nMANDATORY \u2014 Structured Result Marker:\nYou MUST include exactly one of these HTML comment markers in your final output:\n- On pass: <!-- WORK_RESULT:passed -->\n- On fail: <!-- WORK_RESULT:failed -->\nWithout this marker, the orchestrator CANNOT detect your result and the issue status will NOT be updated. Even if you encounter errors, always emit <!-- WORK_RESULT:failed -->.";
+export declare const READ_ONLY_CONSTRAINT = "\n\nCRITICAL CONSTRAINT \u2014 READ-ONLY ROLE:\nYou are a VALIDATION agent, NOT a development agent. You MUST NOT modify any source code, configuration files, migration files, or project files. Your role is strictly to READ, VALIDATE, and REPORT.\nFORBIDDEN actions: creating files, editing files, writing code, committing changes, patching snapshots, fixing bugs, resolving errors in code.\nALLOWED actions: reading files, running tests, running builds, checking CI status, posting comments, merging PRs (acceptance only), updating Linear status.\nIf you discover issues (missing files, broken builds, failing tests), REPORT them in your result comment and emit WORK_RESULT:failed. Do NOT attempt to fix them.";
 export declare const PR_SELECTION_GUIDANCE = "\n\nPR Selection (Multi-PR Handling):\nIssues may have multiple PRs. Select the correct one:\n1. Check linked PRs in the issue attachments/links for GitHub PR URLs\n2. Filter by state \u2014 prefer OPEN over MERGED over CLOSED: gh pr view NNN --json state\n3. If multiple OPEN PRs, pick the most recently created one\n4. Fallback search by branch: gh pr list --head \"$(git branch --show-current)\" --state open\n5. Last resort search by issue ID: gh pr list --state open --search \"[issue-id]\"\n6. If no PR found, emit WORK_RESULT:failed with explanation";
 /**
  * Context from the workflow state machine for retry enrichment.

package/dist/src/defaults/prompts.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"prompts.d.ts","sourceRoot":"","sources":["../../../src/defaults/prompts.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,KAAK,EAAE,aAAa,EAAE,cAAc,EAAE,MAAM,aAAa,CAAA;AAahE,eAAO,MAAM,8BAA8B,uYAMsI,CAAA;AAEjL,eAAO,MAAM,qBAAqB,ijBAS0B,CAAA;AAE5D;;;GAGG;AACH,MAAM,WAAW,eAAe;IAC9B,UAAU,EAAE,MAAM,CAAA;IAClB,QAAQ,EAAE,MAAM,CAAA;IAChB,cAAc,EAAE,MAAM,GAAG,IAAI,CAAA;IAC7B,cAAc,CAAC,EAAE,MAAM,CAAA;CACxB;AAED;;GAEG;AACH,wBAAgB,wBAAwB,CACtC,QAAQ,EAAE,aAAa,EACvB,OAAO,EAAE,eAAe,GACvB,MAAM,CA0DR;AAED;;;;;;;GAOG;AACH,wBAAgB,qBAAqB,CACnC,UAAU,EAAE,MAAM,EAClB,QAAQ,EAAE,aAAa,EACvB,cAAc,CAAC,EAAE,MAAM,EACvB,eAAe,CAAC,EAAE,eAAe,GAChC,MAAM,CAuFR;AAED;;GAEG;AACH,wBAAgB,2BAA2B,CACzC,eAAe,EAAE,MAAM,EACvB,gBAAgB,EAAE,cAAc,EAAE,GACjC,MAAM,CAoBR;AAED;;GAEG;AACH,wBAAgB,mCAAmC,CACjD,eAAe,EAAE,MAAM,EACvB,gBAAgB,EAAE,cAAc,EAAE,GACjC,MAAM,CAmBR"}
+{"version":3,"file":"prompts.d.ts","sourceRoot":"","sources":["../../../src/defaults/prompts.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,KAAK,EAAE,aAAa,EAAE,cAAc,EAAE,MAAM,aAAa,CAAA;AAahE,eAAO,MAAM,8BAA8B,uYAMsI,CAAA;AAEjL,eAAO,MAAM,oBAAoB,2sBAMiI,CAAA;AAElK,eAAO,MAAM,qBAAqB,ijBAS0B,CAAA;AAE5D;;;GAGG;AACH,MAAM,WAAW,eAAe;IAC9B,UAAU,EAAE,MAAM,CAAA;IAClB,QAAQ,EAAE,MAAM,CAAA;IAChB,cAAc,EAAE,MAAM,GAAG,IAAI,CAAA;IAC7B,cAAc,CAAC,EAAE,MAAM,CAAA;CACxB;AAED;;GAEG;AACH,wBAAgB,wBAAwB,CACtC,QAAQ,EAAE,aAAa,EACvB,OAAO,EAAE,eAAe,GACvB,MAAM,CA0DR;AAED;;;;;;;GAOG;AACH,wBAAgB,qBAAqB,CACnC,UAAU,EAAE,MAAM,EAClB,QAAQ,EAAE,aAAa,EACvB,cAAc,CAAC,EAAE,MAAM,EACvB,eAAe,CAAC,EAAE,eAAe,GAChC,MAAM,CAiJR;AAED;;GAEG;AACH,wBAAgB,2BAA2B,CACzC,eAAe,EAAE,MAAM,EACvB,gBAAgB,EAAE,cAAc,EAAE,GACjC,MAAM,CAoBR;AAED;;GAEG;AACH,wBAAgB,mCAAmC,CACjD,eAAe,EAAE,MAAM,EACvB,gBAAgB,EAAE,cAAc,EAAE,GACjC,MAAM,CAmBR"}

package/dist/src/defaults/prompts.js

@@ -21,6 +21,13 @@ You MUST include exactly one of these HTML comment markers in your final output:
 - On pass: <!-- WORK_RESULT:passed -->
 - On fail: <!-- WORK_RESULT:failed -->
 Without this marker, the orchestrator CANNOT detect your result and the issue status will NOT be updated. Even if you encounter errors, always emit <!-- WORK_RESULT:failed -->.`;
+export const READ_ONLY_CONSTRAINT = `
+
+CRITICAL CONSTRAINT — READ-ONLY ROLE:
+You are a VALIDATION agent, NOT a development agent. You MUST NOT modify any source code, configuration files, migration files, or project files. Your role is strictly to READ, VALIDATE, and REPORT.
+FORBIDDEN actions: creating files, editing files, writing code, committing changes, patching snapshots, fixing bugs, resolving errors in code.
+ALLOWED actions: reading files, running tests, running builds, checking CI status, posting comments, merging PRs (acceptance only), updating Linear status.
+If you discover issues (missing files, broken builds, failing tests), REPORT them in your result comment and emit WORK_RESULT:failed. Do NOT attempt to fix them.`;
 export const PR_SELECTION_GUIDANCE = `
 
 PR Selection (Multi-PR Handling):
@@ -123,6 +130,7 @@ Do NOT wait for user approval - create issues automatically.`;
             break;
         case 'qa':
             basePrompt = `QA ${identifier}. Validate the implementation against acceptance criteria.
+${READ_ONLY_CONSTRAINT}
 ${WORK_RESULT_MARKER_INSTRUCTION}
 ${PR_SELECTION_GUIDANCE}
 
@@ -136,6 +144,7 @@ Validation Steps:
             break;
         case 'acceptance':
             basePrompt = `Process acceptance for ${identifier}. Validate development and QA work is complete, verify PR is ready to merge (CI passing, no conflicts), merge the PR, and clean up local resources.
+${READ_ONLY_CONSTRAINT}
 ${WORK_RESULT_MARKER_INSTRUCTION}
 ${PR_SELECTION_GUIDANCE}
 
@@ -150,8 +159,32 @@ Acceptance Steps:
         case 'refinement':
             basePrompt = `Refine ${identifier} based on rejection feedback. Read comments, update requirements, then return to Backlog.`;
             break;
-        case 'coordination':
-            basePrompt = `Coordinate sub-issue execution for parent issue ${identifier}. Fetch sub-issues with dependency graph, create tasks mapping to each sub-issue, spawn sub-agents for unblocked sub-issues in parallel, monitor completion, and create a single PR with all changes when done.
+        case 'coordination': {
+            const isRetry = workflowContext && workflowContext.cycleCount > 0;
+            if (isRetry) {
+                basePrompt = `Fix issues found during QA for parent issue ${identifier}.
+
+REWORK MODE — DO NOT re-coordinate sub-issues from scratch.
+All sub-issues are already Finished and a PR already exists. QA failed and specific fixes are needed.
+
+MANDATORY FIRST STEPS:
+1. Read the most recent QA failure comments: pnpm af-linear list-comments ${identifier}
+2. Identify the SPECIFIC fixes needed from the QA failure details below
+3. Apply fixes directly — do NOT re-spawn sub-agents for already-complete work
+4. Commit fixes, push to the existing PR branch
+5. Run full validation: pnpm typecheck && pnpm build && pnpm test
+6. Update parent issue status to Finished
+
+COMMON REWORK FIXES:
+- Missing migration .json snapshots: Find .ts migrations without .json, patch the latest snapshot
+- TypeScript errors: Read the error details, fix the type issues
+- Missing API fields: Update route handlers to include missing fields
+- Build failures: Run pnpm build, diagnose, fix
+
+If the existing PR branch is checked out, work directly on it. Do not create a new branch or PR.`;
+            }
+            else {
+                basePrompt = `Coordinate sub-issue execution for parent issue ${identifier}. Fetch sub-issues with dependency graph, create tasks mapping to each sub-issue, spawn sub-agents for unblocked sub-issues in parallel, monitor completion, and create a single PR with all changes when done.
 
 SUB-ISSUE STATUS MANAGEMENT:
 Update sub-issue statuses in Linear as work progresses:
@@ -162,14 +195,47 @@ Update sub-issue statuses in Linear as work progresses:
 COMPLETION VERIFICATION:
 Before marking the parent issue as complete, verify ALL sub-issues are in Finished status.
 If any sub-issue is not Finished, report the failure and do not mark the parent as complete.`;
+            }
             break;
+        }
         case 'qa-coordination':
-            basePrompt = `Coordinate QA across sub-issues for parent issue ${identifier}. Fetch sub-issues, spawn QA sub-agents in parallel for each sub-issue, collect pass/fail results, and roll up to parent. ALL sub-issues must pass QA for the parent to pass.
-${WORK_RESULT_MARKER_INSTRUCTION}`;
+            basePrompt = `Coordinate QA across sub-issues for parent issue ${identifier}. Fetch sub-issues, validate each against acceptance criteria, collect pass/fail results, and roll up to parent.
+${READ_ONLY_CONSTRAINT}
+${WORK_RESULT_MARKER_INSTRUCTION}
+${PR_SELECTION_GUIDANCE}
+
+QA Coordination Steps:
+1. Find and validate the correct PR (see PR selection above)
+2. Fetch all sub-issues and verify each is in Finished or later status
+3. Run tests scoped to the affected packages
+4. Verify the build passes (pnpm typecheck && pnpm build)
+5. Review changes against each sub-issue's acceptance criteria
+6. Verify cross-cutting concerns: shared types, API contracts, data flow between sub-issues
+7. Check deployment status (CI checks on the PR)
+
+Pass/Fail:
+- PASS (emit <!-- WORK_RESULT:passed -->): ALL tests pass, build succeeds, all sub-issues implemented, deployment healthy
+- FAIL (emit <!-- WORK_RESULT:failed -->): ANY test failure, build error, missing implementation, deployment failure
+Post a result comment listing per-sub-issue findings, then emit the marker.`;
             break;
         case 'acceptance-coordination':
-            basePrompt = `Coordinate acceptance across sub-issues for parent issue ${identifier}. Verify all sub-issues are Delivered, validate the PR (CI passing, no conflicts), merge the PR, and bulk-update sub-issues to Accepted.
-${WORK_RESULT_MARKER_INSTRUCTION}`;
+            basePrompt = `Coordinate acceptance across sub-issues for parent issue ${identifier}. Verify all sub-issues are Delivered, validate the PR, merge it, and bulk-update sub-issues to Accepted.
+${READ_ONLY_CONSTRAINT}
+${WORK_RESULT_MARKER_INSTRUCTION}
+${PR_SELECTION_GUIDANCE}
+
+Acceptance Coordination Steps:
+1. Find and validate the correct PR (see PR selection above)
+2. Verify ALL sub-issues are in Delivered or Accepted status
+3. Verify CI is passing and there are no merge conflicts
+4. Merge the PR
+5. Delete the remote branch after successful merge
+6. Post result comment with per-sub-issue status, then emit the marker
+
+Pass/Fail:
+- PASS (emit <!-- WORK_RESULT:passed -->): All sub-issues Delivered, CI passing, PR merged successfully
+- FAIL (emit <!-- WORK_RESULT:failed -->): Incomplete sub-issues, CI failure, merge conflicts, merge failed
+If ANY issue prevents merging, do NOT attempt to fix it — emit WORK_RESULT:failed with details.`;
             break;
     }
     basePrompt += HUMAN_BLOCKER_INSTRUCTION;

package/dist/src/defaults/prompts.test.js

@@ -52,6 +52,16 @@ describe('buildFailureContextBlock', () => {
             expect(result).toContain('retry #2');
         });
     });
+    describe('qa-coordination work type', () => {
+        it('returns empty string when no failure summary', () => {
+            expect(buildFailureContextBlock('qa-coordination', { ...baseContext, failureSummary: null })).toBe('');
+        });
+        it('includes previous QA results when failure summary exists', () => {
+            const result = buildFailureContextBlock('qa-coordination', baseContext);
+            expect(result).toContain('Previous QA Results');
+            expect(result).toContain('TypeError in UserService');
+        });
+    });
     describe('qa work type', () => {
         it('returns empty string when no failure summary', () => {
             expect(buildFailureContextBlock('qa', { ...baseContext, failureSummary: null })).toBe('');
@@ -128,3 +138,126 @@ describe('defaultGeneratePrompt with workflowContext', () => {
         expect(result).toContain('Please focus on the API layer');
     });
 });
+describe('defaultGeneratePrompt read-only constraint', () => {
+    const readOnlyWorkTypes = ['qa', 'acceptance', 'qa-coordination', 'acceptance-coordination'];
+    for (const workType of readOnlyWorkTypes) {
+        it(`includes READ-ONLY constraint for ${workType}`, () => {
+            const result = defaultGeneratePrompt('PROJ-123', workType);
+            expect(result).toContain('READ-ONLY ROLE');
+            expect(result).toContain('MUST NOT modify any source code');
+            expect(result).toContain('WORK_RESULT:failed');
+        });
+    }
+    const writableWorkTypes = ['development', 'coordination', 'refinement', 'research', 'backlog-creation', 'inflight'];
+    for (const workType of writableWorkTypes) {
+        it(`does NOT include READ-ONLY constraint for ${workType}`, () => {
+            const result = defaultGeneratePrompt('PROJ-123', workType);
+            expect(result).not.toContain('READ-ONLY ROLE');
+        });
+    }
+});
+describe('defaultGeneratePrompt coordination prompts have steps', () => {
+    it('qa-coordination includes numbered steps and pass/fail criteria', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'qa-coordination');
+        expect(result).toContain('QA Coordination Steps:');
+        expect(result).toContain('1. Find and validate the correct PR');
+        expect(result).toContain('Pass/Fail:');
+        expect(result).toContain('WORK_RESULT:passed');
+        expect(result).toContain('WORK_RESULT:failed');
+        expect(result).toContain('PR Selection');
+    });
+    it('acceptance-coordination includes numbered steps and pass/fail criteria', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'acceptance-coordination');
+        expect(result).toContain('Acceptance Coordination Steps:');
+        expect(result).toContain('1. Find and validate the correct PR');
+        expect(result).toContain('Merge the PR');
+        expect(result).toContain('Pass/Fail:');
+        expect(result).toContain('WORK_RESULT:passed');
+        expect(result).toContain('WORK_RESULT:failed');
+        expect(result).toContain('do NOT attempt to fix it');
+        expect(result).toContain('PR Selection');
+    });
+});
+describe('defaultGeneratePrompt coordination retry', () => {
+    it('uses fresh coordination prompt when no workflowContext', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination');
+        expect(result).toContain('Coordinate sub-issue execution for parent issue PROJ-100');
+        expect(result).toContain('Fetch sub-issues with dependency graph');
+        expect(result).not.toContain('REWORK MODE');
+    });
+    it('uses fresh coordination prompt when cycleCount is 0', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination', undefined, {
+            cycleCount: 0,
+            strategy: 'normal',
+            failureSummary: null,
+        });
+        expect(result).toContain('Coordinate sub-issue execution for parent issue PROJ-100');
+        expect(result).not.toContain('REWORK MODE');
+    });
+    it('switches to rework mode when cycleCount > 0', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination', undefined, {
+            cycleCount: 1,
+            strategy: 'context-enriched',
+            failureSummary: '2 migrations missing .json snapshots',
+        });
+        expect(result).toContain('REWORK MODE');
+        expect(result).toContain('Fix issues found during QA for parent issue PROJ-100');
+        expect(result).toContain('DO NOT re-coordinate sub-issues from scratch');
+        expect(result).toContain('pnpm af-linear list-comments PROJ-100');
+        expect(result).not.toContain('Fetch sub-issues with dependency graph');
+    });
+    it('includes common rework fixes in rework mode', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination', undefined, {
+            cycleCount: 2,
+            strategy: 'context-enriched',
+            failureSummary: 'Build failed',
+        });
+        expect(result).toContain('Missing migration .json snapshots');
+        expect(result).toContain('TypeScript errors');
+        expect(result).toContain('Missing API fields');
+        expect(result).toContain('Build failures');
+    });
+    it('appends failure context block in rework mode', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination', undefined, {
+            cycleCount: 2,
+            strategy: 'context-enriched',
+            failureSummary: 'Tests failed: missing snapshot for 20260308_migration.ts',
+        });
+        expect(result).toContain('REWORK MODE');
+        expect(result).toContain('Retry Context');
+        expect(result).toContain('retry #2');
+        expect(result).toContain('missing snapshot for 20260308_migration.ts');
+    });
+    it('includes mention context alongside rework mode', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination', 'Focus on the migration snapshots', {
+            cycleCount: 1,
+            strategy: 'normal',
+            failureSummary: 'Missing .json snapshots',
+        });
+        expect(result).toContain('REWORK MODE');
+        expect(result).toContain('Focus on the migration snapshots');
+    });
+    it('instructs agent to use existing PR branch', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination', undefined, {
+            cycleCount: 1,
+            strategy: 'normal',
+            failureSummary: null,
+        });
+        expect(result).toContain('Do not create a new branch or PR');
+        expect(result).toContain('push to the existing PR branch');
+    });
+    it('includes sub-issue status management in fresh coordination', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination');
+        expect(result).toContain('SUB-ISSUE STATUS MANAGEMENT');
+        expect(result).toContain('COMPLETION VERIFICATION');
+    });
+    it('does not include sub-issue status management in rework mode', () => {
+        const result = defaultGeneratePrompt('PROJ-100', 'coordination', undefined, {
+            cycleCount: 1,
+            strategy: 'normal',
+            failureSummary: 'QA failed',
+        });
+        expect(result).not.toContain('SUB-ISSUE STATUS MANAGEMENT');
+        expect(result).not.toContain('COMPLETION VERIFICATION');
+    });
+});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@supaku/agentfactory-linear",
-  "version": "0.7.47",
+  "version": "0.7.49",
   "type": "module",
   "description": "Linear issue tracker integration for AgentFactory — status transitions, agent sessions, work routing",
   "author": "Supaku (https://supaku.com)",