@sungen/driver-ui 3.2.19 → 3.2.20-beta.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sungen/driver-ui",
-  "version": "3.2.19",
+  "version": "3.2.20-beta.2",
   "description": "Sungen UI capability (Playwright) — step patterns, viewpoint gate, and phase hooks. Plugs into @sun-asterisk/sungen via the capability SPI.",
   "main": "src/index.ts",
   "types": "src/index.ts",
@@ -13,7 +13,7 @@
   "author": "eqe team (engineer & quality) — Sun Asterisk",
   "license": "MIT",
   "dependencies": {
-    "@sun-asterisk/sungen": "3.2.19"
+    "@sun-asterisk/sungen": "3.2.20-beta.2"
   },
   "peerDependencies": {
     "@playwright/test": "^1.57.0"

package/src/patterns/assertion-patterns.ts

@@ -134,7 +134,9 @@ export const assertionPatterns: StepPattern[] = [
       const withSuffix = step.dataRef ? ` with ${step.dataRef}` : '';
       return {
         templateName: 'page-assertion',
-        data: { pathRegex, query },
+        // `dataRef` rides along so a runtime failure can name the test-data key an author must go
+        // fix — an empty/absent value is otherwise the hardest kind of red to trace.
+        data: { pathRegex, query, dataRef: step.dataRef || '' },
         comment: step.selectorRef ? `Assert on ${step.selectorRef} page${withSuffix}` : `Assert on page${withSuffix}`,
       };
     },

package/src/patterns/navigation-patterns.ts

@@ -27,7 +27,13 @@ export const navigationPatterns: StepPattern[] = [
           const resolved = context.selectorResolver.resolveSelector(
             step.selectorRef, context.featureName, step.elementType, step.nth
           );
-          path = resolved.value || pathFallback;
+          // Only a `page`-type entry carries a URL in `value` — the same guard the `see [X] page`
+          // twin has carried since the key-collision fix (assertion-patterns.ts). Without it a
+          // colliding non-page entry (a `type: role` whose value is 'button') was used verbatim as
+          // the path, so the step asserted `^button/?$` — a wrong, specific path rather than the
+          // documented fallback. These two resolvers have drifted apart twice already; keep them
+          // spelling the same rule.
+          path = resolved.selectorType === 'page' ? (resolved.value || pathFallback) : pathFallback;
         } catch (error) {
           path = pathFallback;
         }
@@ -60,14 +66,19 @@ export const navigationPatterns: StepPattern[] = [
         // the wildcard the `see [X] page` twin already produced.
         return {
           templateName: 'route-assertion',
-          data: { pathRegex: pathToRegexSource(path), query },
+          // `dataRef` rides along so a runtime failure names the test-data key (see the `see` twin).
+          data: { pathRegex: pathToRegexSource(path), query, dataRef: step.dataRef || '' },
           comment: step.selectorRef ? `Assert on ${step.selectorRef} page${withSuffix}` : `Assert page route`,
         };
       }
 
       return {
         templateName: 'navigation',
-        data: { baseURL: isAbsoluteUrl ? undefined : context.baseURL, path: finalPath + query },
+        // `query` stays SEPARATE from `path` rather than concatenated here: in runtime-data mode
+        // the value is still a `__SUNGEN_TD$…$__` marker at this point, so the compiler cannot see
+        // whether it carries its own path. Deciding that is therefore a runtime job — the template
+        // hands both parts to joinPath(). Concatenating here is what produced `/vi/search/vi/search`.
+        data: { baseURL: isAbsoluteUrl ? undefined : context.baseURL, path: finalPath, query },
         comment: step.selectorRef ? `Open ${step.selectorRef} page${withSuffix}` : `Navigate to page`,
       };
     },