@sun-asterisk/sunlint 1.3.33 → 1.3.35

package/engines/impact/index.js

@@ -0,0 +1,135 @@
+#!/usr/bin/env node
+
+/**
+ * Impact Analyzer - Main Entry Point
+ * Orchestrates the entire impact analysis workflow
+ */
+
+import { CLI } from './cli.js';
+import { loadConfig } from './config/default-config.js';
+import { ChangeDetector } from './core/change-detector.js';
+import { ImpactAnalyzer } from './core/impact-analyzer.js';
+import { ReportGenerator } from './core/report-generator.js';
+import { GitUtils } from './core/utils/git-utils.js';
+import fs from 'fs';
+import path from 'path';
+
+async function main() {
+  const cli = new CLI(process.argv);
+
+  // Show help if requested
+  if (cli.hasArg('help') || cli.hasArg('h')) {
+    cli.showHelp();
+    process.exit(0);
+  }
+
+  // Load configuration
+  const config = loadConfig(cli);
+  const absoluteSourceDir = path.resolve(config.sourceDir);
+
+  console.log('🚀 Starting Impact Analysis...\n');
+  console.log('Configuration:');
+  console.log(`  Source Dir: ${config.sourceDir}`);
+  console.log(`  Absolute Path: ${absoluteSourceDir}`);
+  console.log(`  Base Ref: ${config.baseRef}`);
+  console.log(`  Head Ref: ${config.headRef}`);
+  console.log(`  Exclude: ${config.excludePaths.join(', ')}`);
+  console.log('');
+
+  try {
+    // ============================================
+    // Validation
+    // ============================================
+
+    // Check if source directory exists
+    if (! fs.existsSync(absoluteSourceDir)) {
+      throw new Error(`Source directory does not exist: ${absoluteSourceDir}`);
+    }
+
+    // Check if it's a git repository
+    if (!GitUtils.isGitRepo(absoluteSourceDir)) {
+      throw new Error(`Source directory is not a git repository: ${absoluteSourceDir}`);
+    }
+
+    // Check if refs exist
+    if (!GitUtils.refExists(config.baseRef, absoluteSourceDir)) {
+      throw new Error(`Base ref does not exist: ${config.baseRef}`);
+    }
+
+    console.log('✓ Validation passed\n');
+
+    // ============================================
+    // Step 1: Detect Changes
+    // ============================================
+    console.log('📝 Step 1: Detecting changes...');
+    const detector = new ChangeDetector(config);
+
+    const changedFiles = detector.detectChangedFiles();
+    console.log(`   ✓ Found ${changedFiles.length} changed files`);
+
+    const changedSymbols = detector.detectChangedSymbols(changedFiles);
+    console.log(`   ✓ Found ${changedSymbols.length} changed symbols\n`);
+
+    const changes = {
+      changedFiles,
+      changedSymbols,
+    };
+
+    // ============================================
+    // Step 2: Analyze Impact
+    // ============================================
+    console.log('🔍 Step 2: Analyzing impact...');
+    const analyzer = new ImpactAnalyzer(config);
+    
+    // Initialize method-level call graph for precise tracking
+    await analyzer.initializeMethodCallGraph();
+    
+    const impact = await analyzer.analyzeImpact(changes);
+    console.log(`   ✓ Impact score: ${impact.impactScore}`);
+    console.log(`   ✓ Severity: ${impact.severity.toUpperCase()}\n`);
+
+    // ============================================
+    // Step 3: Generate Reports
+    // ============================================
+    console.log('📄 Step 3: Generating reports...\n');
+    const reporter = new ReportGenerator();
+
+    // Console report
+    reporter.generateConsoleReport(changes, impact);
+
+    // Markdown report
+    const markdownReport = reporter.generateMarkdownReport(changes, impact);
+
+    // Save to file
+    const outputFile = cli.getArg('output', 'impact-report.md');
+    fs.writeFileSync(outputFile, markdownReport);
+    console.log(`✅ Report saved to: ${outputFile}\n`);
+
+    // JSON output (optional)
+    if (cli.hasArg('json')) {
+      const jsonOutput = cli.getArg('json');
+      const jsonReport = reporter.generateJSONReport(changes, impact);
+      fs.writeFileSync(jsonOutput, JSON.stringify(jsonReport, null, 2));
+      console.log(`✅ JSON report saved to: ${jsonOutput}\n`);
+    }
+
+    // Exit with code based on severity
+    if (impact.severity === 'critical' && ! cli.hasArg('no-fail')) {
+      console.log('⚠️  Critical impact detected - exiting with error code');
+      process.exit(1);
+    }
+
+    console.log('✨ Analysis completed successfully!\n');
+    process.exit(0);
+
+  } catch (error) {
+    console.error('❌ Error during analysis:', error.message);
+    if (cli.hasArg('verbose')) {
+      console.error(error.stack);
+    }
+    process.exit(1);
+  }
+}
+
+// Run if executed directly
+main();

package/engines/impact/package.json

@@ -0,0 +1,29 @@
+{
+  "name": "@sunlint/impact-analyzer",
+  "version": "1.0.7",
+  "private": true,
+  "description": "Automated impact analysis for TypeScript/JavaScript projects (internal - bundled into sunlint)",
+  "main": "index.js",
+  "type": "module",
+  "bin": {
+    "impact-analyzer": "./index.js"
+  },
+  "scripts": {
+    "build": "echo 'No build required (pure Node.js)'",
+    "test": "echo 'No tests yet'",
+    "analyze": "node index.js"
+  },
+  "keywords": [
+    "impact-analysis",
+    "code-analysis",
+    "ci-cd"
+  ],
+  "author": "",
+  "license": "MIT",
+  "dependencies": {
+    "@babel/parser": "^7.23.0",
+    "@babel/traverse": "^7.23.0",
+    "glob": "^10.3.0",
+    "ts-morph": "^27.0.2"
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sun-asterisk/sunlint",
-  "version": "1.3.33",
+  "version": "1.3.35",
   "description": "☀️ SunLint - Multi-language static analysis tool for code quality and security | Sun* Engineering Standards",
   "main": "cli.js",
   "bin": {
@@ -15,46 +15,6 @@
     "registry": "https://registry.npmjs.org",
     "access": "public"
   },
-  "scripts": {
-    "test": "node examples/run-tests.js",
-    "test:examples": "node examples/integration-tests/examples-integration-test.js",
-    "test:architecture": "node examples/integration-tests/core-architecture-test.js",
-    "test:integration": "echo 'Temporarily disabled - config extension issue'",
-    "test:realworld": "node examples/integration-tests/realworld-integration-test.js",
-    "test:cli": "node examples/integration-tests/direct-cli-test.js",
-    "test:performance": "node test/performance-test.js",
-    "test:c019": "node cli.js --rule=C019 --input=examples/test-fixtures --format=eslint",
-    "test:c006": "node cli.js --rule=C006 --input=examples/test-fixtures --format=eslint",
-    "test:c029": "node cli.js --rule=C029 --input=examples/test-fixtures --format=eslint",
-    "test:multi": "node cli.js --rules=C019,C006,C029 --input=examples/test-fixtures --format=eslint",
-    "test:all": "node cli.js --all --input=examples/test-fixtures --format=eslint",
-    "test:quality": "node cli.js --category=quality --input=examples/test-fixtures --format=eslint",
-    "test:security": "node cli.js --category=security --input=examples/test-fixtures --format=eslint",
-    "demo": "./demo.sh",
-    "demo:single": "node cli.js --rule=C019 --input=examples/test-fixtures/typescript --format=eslint",
-    "demo:multi": "node cli.js --rules=C019,C006 --input=test/fixtures --format=summary",
-    "demo:quality": "node cli.js --quality --input=test/fixtures --format=summary",
-    "demo:security": "node cli.js --security --input=test/fixtures --format=summary",
-    "demo:all": "node cli.js --all --input=test/fixtures --format=summary",
-    "demo:config": "node cli.js --config=.sunlint.json --input=test/fixtures",
-    "demo:eslint-integration": "./demo-eslint-integration.sh",
-    "demo:file-targeting": "./demo-file-targeting.sh",
-    "lint": "node cli.js --config=.sunlint.json --input=.",
-    "lint:eslint-integration": "node cli.js --all --eslint-integration --input=.",
-    "build": "npm run copy-rules && npm run generate-registry && npm run copy-arch-detect && echo 'Build completed'",
-    "copy-rules": "node scripts/copy-rules.js",
-    "generate-registry": "node scripts/generate-rules-registry.js",
-    "copy-arch-detect": "node scripts/copy-arch-detect.js",
-    "clean": "rm -rf coverage/ *.log reports/ *.tgz engines/arch-detect",
-    "postpack": "echo '📦 Package created successfully! Size: ' && ls -lh *.tgz | awk '{print $5}'",
-    "start": "node cli.js --help",
-    "version": "node cli.js --version",
-    "pack": "npm run build && npm pack",
-    "publish:github": "npm publish --registry=https://npm.pkg.github.com",
-    "publish:npmjs": "npm publish --registry=https://registry.npmjs.org",
-    "publish:test": "npm publish --dry-run --registry=https://registry.npmjs.org",
-    "prepublishOnly": "npm run clean && npm run build"
-  },
   "keywords": [
     "linting",
     "code-quality",
@@ -79,6 +39,7 @@
     "integrations/",
     "rules/",
     "scripts/",
+    "templates/",
     "docs/",
     ".sunlint.json",
     "README.md",
@@ -139,5 +100,19 @@
   "bugs": {
     "url": "https://github.com/sun-asterisk/engineer-excellence/issues"
   },
-  "homepage": "https://github.com/sun-asterisk/engineer-excellence/tree/main/coding-quality/extensions/sunlint#readme"
-}
+  "homepage": "https://github.com/sun-asterisk/engineer-excellence/tree/main/coding-quality/extensions/sunlint#readme",
+  "scripts": {
+    "test": "node examples/run-tests.js",
+    "test:perf": "node test/performance-test.js",
+    "lint": "node cli.js --all --input=. --format=summary",
+    "build": "pnpm run copy-rules && pnpm run generate-registry && pnpm run copy-arch-detect && pnpm run copy-impact",
+    "copy-rules": "node scripts/copy-rules.js",
+    "generate-registry": "node scripts/generate-rules-registry.js",
+    "copy-arch-detect": "node scripts/copy-arch-detect.js",
+    "copy-impact": "node scripts/copy-impact-analyzer.js",
+    "clean": "rm -rf coverage/ *.log reports/ *.tgz engines/arch-detect engines/impact",
+    "pack": "pnpm run build && pnpm pack",
+    "publish:npmjs": "pnpm publish --registry=https://registry.npmjs.org --no-git-checks",
+    "publish:test": "pnpm publish --dry-run --registry=https://registry.npmjs.org --no-git-checks"
+  }
+}

package/rules/common/C002_no_duplicate_code/config.json

@@ -1,23 +1,15 @@
 {
-  "id": "C002_no_duplicate_code",
-  "name": "C002_no_duplicate_code",
-  "category": "coding",
-  "description": "C002_no_duplicate_code heuristic rule - migrated from ESLint",
-  "severity": "error",
-  "enabled": true,
-  "migration": {
-    "from_eslint": "c002-no-duplicate-code",
-    "compatibility": "partial",
-    "status": "pending"
+  "id": "C002",
+  "name": "No Duplicate Code",
+  "description": "Không để trùng lặp code > 10 dòng - Tránh code rối, khó refactor và áp dụng DRY principle",
+  "category": "complexity",
+  "severity": "warning",
+  "languages": ["typescript", "javascript", "dart"],
+  "config": {
+    "minLines": 10,
+    "similarityThreshold": 0.95
   },
-  "patterns": {
-    "include": [
-      "**/*.js",
-      "**/*.ts"
-    ],
-    "exclude": [
-      "**/*.test.*",
-      "**/*.spec.*"
-    ]
-  }
+  "references": [
+    "https://en.wikipedia.org/wiki/Don%27t_repeat_yourself"
+  ]
 }

package/rules/common/C002_no_duplicate_code/dart/analyzer.js

@@ -0,0 +1,53 @@
+/**
+ * C002 Dart Analyzer - No Duplicate Code (> 10 lines)
+ *
+ * This is a JS wrapper that delegates to DartAnalyzer binary.
+ * Actual implementation: dart_analyzer/lib/rules/duplicate_code_analyzer.dart
+ *
+ * Rule: Không để trùng lặp code > 10 dòng
+ */
+
+class DartC002Analyzer {
+  constructor() {
+    this.ruleId = 'C002';
+    this.language = 'dart';
+  }
+
+  /**
+   * Get rule metadata
+   */
+  getMetadata() {
+    return {
+      ruleId: 'C002',
+      name: 'No Duplicate Code',
+      language: 'dart',
+      delegateTo: 'dart_analyzer',
+      description: 'Detect duplicate code blocks > 10 lines'
+    };
+  }
+
+  /**
+   * Get default configuration
+   */
+  getConfig() {
+    return {
+      minLines: 10,
+      similarityThreshold: 0.95,
+      severity: 'warning'
+    };
+  }
+
+  /**
+   * Analysis is delegated to DartAnalyzer via heuristic-engine.js
+   */
+  async analyze(files, language, options) {
+    // Delegated to DartAnalyzer binary via heuristic-engine.js
+    return [];
+  }
+
+  supportsLanguage(language) {
+    return language === 'dart';
+  }
+}
+
+module.exports = DartC002Analyzer;

package/rules/common/C002_no_duplicate_code/index.js

@@ -0,0 +1,93 @@
+/**
+ * C002 Rule Router - No Duplicate Code (> 10 lines)
+ *
+ * Routes analysis to the appropriate language-specific analyzer.
+ * Supports: TypeScript, JavaScript, Dart
+ *
+ * Rule: Không để trùng lặp code > 10 dòng
+ * - Cảnh báo nếu trùng lặp >= 10 dòng trong các function/class
+ * - Extract common logic thành functions hoặc utilities
+ */
+
+const path = require('path');
+
+class C002Router {
+  constructor() {
+    this.analyzers = new Map();
+    this.ruleId = 'C002';
+  }
+
+  getAnalyzer(language) {
+    const normalizedLang = this.normalizeLanguage(language);
+
+    if (!this.analyzers.has(normalizedLang)) {
+      try {
+        const analyzerPath = path.join(__dirname, normalizedLang, 'analyzer.js');
+        const AnalyzerClass = require(analyzerPath);
+        this.analyzers.set(normalizedLang, new AnalyzerClass());
+      } catch (error) {
+        return null;
+      }
+    }
+
+    return this.analyzers.get(normalizedLang);
+  }
+
+  normalizeLanguage(language) {
+    // Handle case where language might not be a string
+    if (typeof language !== 'string') {
+      return 'typescript'; // Default fallback
+    }
+    const languageMap = {
+      'typescript': 'typescript',
+      'javascript': 'typescript',
+      'ts': 'typescript',
+      'js': 'typescript',
+      'dart': 'dart'
+    };
+    return languageMap[language.toLowerCase()] || language.toLowerCase();
+  }
+
+  supportsLanguage(language) {
+    if (typeof language !== 'string') return false;
+    const supported = ['typescript', 'javascript', 'ts', 'js', 'dart'];
+    return supported.includes(language.toLowerCase());
+  }
+
+  getSupportedLanguages() {
+    return ['typescript', 'javascript', 'dart'];
+  }
+
+  async analyze(files, language, options = {}) {
+    const analyzer = this.getAnalyzer(language);
+    if (!analyzer) return [];
+    if (typeof analyzer.analyze === 'function') {
+      return analyzer.analyze(files, language, options);
+    }
+    return [];
+  }
+
+  async initialize(semanticEngineOrLanguage = null, semanticEngine = null) {
+    // Handle both signatures:
+    // 1. initialize(semanticEngine) - called by heuristic engine
+    // 2. initialize(language, semanticEngine) - original signature
+    let engine = semanticEngine;
+    let lang = null;
+
+    if (typeof semanticEngineOrLanguage === 'string') {
+      lang = semanticEngineOrLanguage;
+    } else if (semanticEngineOrLanguage && typeof semanticEngineOrLanguage === 'object') {
+      engine = semanticEngineOrLanguage;
+    }
+
+    // If language specified, initialize only that analyzer
+    if (lang) {
+      const analyzer = this.getAnalyzer(lang);
+      if (analyzer && typeof analyzer.initialize === 'function') {
+        await analyzer.initialize(engine);
+      }
+    }
+  }
+}
+
+module.exports = new C002Router();

package/rules/common/C003_no_vague_abbreviations/config.json

@@ -4,7 +4,7 @@
   "description": "Clear variable names, avoid arbitrary abbreviations",
   "category": "naming",
   "severity": "warning",
-  "language": ["typescript", "javascript"],
+  "languages": ["typescript", "javascript", "dart"],
   "engine": "heuristic",
   "meta": {
     "docs": {

package/rules/common/C003_no_vague_abbreviations/dart/analyzer.js

@@ -0,0 +1,54 @@
+/**
+ * C003 Dart Analyzer - No Vague Abbreviations
+ *
+ * This is a JS wrapper that delegates to DartAnalyzer binary.
+ * Actual implementation: dart_analyzer/lib/rules/vague_abbreviations_analyzer.dart
+ *
+ * Rule: Clear variable names, avoid arbitrary abbreviations
+ */
+
+class DartC003Analyzer {
+  constructor() {
+    this.ruleId = 'C003';
+    this.language = 'dart';
+  }
+
+  /**
+   * Get rule metadata
+   */
+  getMetadata() {
+    return {
+      ruleId: 'C003',
+      name: 'No Vague Abbreviations',
+      language: 'dart',
+      delegateTo: 'dart_analyzer',
+      description: 'Ensure clear variable names without arbitrary abbreviations'
+    };
+  }
+
+  /**
+   * Get default configuration
+   */
+  getConfig() {
+    return {
+      minLength: 2,
+      allowedSingleChar: ['i', 'j', 'k', 'x', 'y', 'z', 'e', '_'],
+      allowedAbbreviations: ['id', 'url', 'api', 'io', 'db', 'ui', 'ok'],
+      severity: 'warning'
+    };
+  }
+
+  /**
+   * Analysis is delegated to DartAnalyzer via heuristic-engine.js
+   */
+  async analyze(files, language, options) {
+    // Delegated to DartAnalyzer binary via heuristic-engine.js
+    return [];
+  }
+
+  supportsLanguage(language) {
+    return language === 'dart';
+  }
+}
+
+module.exports = DartC003Analyzer;

package/rules/common/C003_no_vague_abbreviations/index.js

@@ -0,0 +1,93 @@
+/**
+ * C003 Rule Router - No Vague Abbreviations
+ *
+ * Routes analysis to the appropriate language-specific analyzer.
+ * Supports: TypeScript, JavaScript, Dart
+ *
+ * Rule: Clear variable names, avoid arbitrary abbreviations
+ * - Ensure clear, understandable variable names
+ * - Avoid vague/unclear abbreviations
+ */
+
+const path = require('path');
+
+class C003Router {
+  constructor() {
+    this.analyzers = new Map();
+    this.ruleId = 'C003';
+  }
+
+  getAnalyzer(language) {
+    const normalizedLang = this.normalizeLanguage(language);
+
+    if (!this.analyzers.has(normalizedLang)) {
+      try {
+        const analyzerPath = path.join(__dirname, normalizedLang, 'analyzer.js');
+        const AnalyzerClass = require(analyzerPath);
+        this.analyzers.set(normalizedLang, new AnalyzerClass());
+      } catch (error) {
+        return null;
+      }
+    }
+
+    return this.analyzers.get(normalizedLang);
+  }
+
+  normalizeLanguage(language) {
+    // Handle case where language might not be a string
+    if (typeof language !== 'string') {
+      return 'typescript'; // Default fallback
+    }
+    const languageMap = {
+      'typescript': 'typescript',
+      'javascript': 'typescript',
+      'ts': 'typescript',
+      'js': 'typescript',
+      'dart': 'dart'
+    };
+    return languageMap[language.toLowerCase()] || language.toLowerCase();
+  }
+
+  supportsLanguage(language) {
+    if (typeof language !== 'string') return false;
+    const supported = ['typescript', 'javascript', 'ts', 'js', 'dart'];
+    return supported.includes(language.toLowerCase());
+  }
+
+  getSupportedLanguages() {
+    return ['typescript', 'javascript', 'dart'];
+  }
+
+  async analyze(files, language, options = {}) {
+    const analyzer = this.getAnalyzer(language);
+    if (!analyzer) return [];
+    if (typeof analyzer.analyze === 'function') {
+      return analyzer.analyze(files, language, options);
+    }
+    return [];
+  }
+
+  async initialize(semanticEngineOrLanguage = null, semanticEngine = null) {
+    // Handle both signatures:
+    // 1. initialize(semanticEngine) - called by heuristic engine
+    // 2. initialize(language, semanticEngine) - original signature
+    let engine = semanticEngine;
+    let lang = null;
+
+    if (typeof semanticEngineOrLanguage === 'string') {
+      lang = semanticEngineOrLanguage;
+    } else if (semanticEngineOrLanguage && typeof semanticEngineOrLanguage === 'object') {
+      engine = semanticEngineOrLanguage;
+    }
+
+    // If language specified, initialize only that analyzer
+    if (lang) {
+      const analyzer = this.getAnalyzer(lang);
+      if (analyzer && typeof analyzer.initialize === 'function') {
+        await analyzer.initialize(engine);
+      }
+    }
+  }
+}
+
+module.exports = new C003Router();

package/rules/common/C006_function_naming/dart/analyzer.js

@@ -0,0 +1,40 @@
+/**
+ * C006 Dart Analyzer - Function Naming Convention
+ *
+ * This is a JS wrapper that delegates to DartAnalyzer binary.
+ * Actual implementation: dart_analyzer/lib/rules/C006_function_naming.dart
+ */
+
+class DartC006Analyzer {
+  constructor() {
+    this.ruleId = 'C006';
+    this.language = 'dart';
+  }
+
+  getMetadata() {
+    return {
+      ruleId: 'C006',
+      name: 'Function Naming Convention',
+      language: 'dart',
+      delegateTo: 'dart_analyzer',
+      description: 'Tên hàm phải là động từ/verb-noun pattern'
+    };
+  }
+
+  getConfig() {
+    return {
+      severity: 'warning'
+    };
+  }
+
+  async analyze(files, language, options) {
+    // Delegated to DartAnalyzer binary via heuristic-engine.js
+    return [];
+  }
+
+  supportsLanguage(language) {
+    return language === 'dart';
+  }
+}
+
+module.exports = DartC006Analyzer;