@sun-asterisk/sunlint 1.1.5 → 1.1.6

package/config/rules/rules-registry.json

@@ -745,7 +745,7 @@
     }
   },
   "metadata": {
-    "version": "1.1.5",
+    "version": "1.1.6",
     "lastUpdated": "2025-07-24",
     "totalRules": 44,
     "qualityRules": 33,

package/engines/eslint-engine.js

@@ -66,22 +66,14 @@ class ESLintEngine extends AnalysisEngineInterface {
       // Check for ESLint dependencies first
       dependencyChecker.checkAndNotify('eslint');
       
-      // Dynamically import ESLint
-      const { ESLint } = await this.loadESLint();
+      // Store config for later use in analyze()
+      this.config = config;
+      this.eslint = null; // Initialize later in analyze() with project path
       
-      // Initialize ESLint with base configuration (v9+ compatible)
-      this.eslint = new ESLint({
-        overrideConfigFile: null, // ESLint 9.x requires null instead of true
-        overrideConfig: this.createBaseConfig(),
-        fix: config?.fix || false,
-        cache: config?.cache || false,
-        cwd: process.cwd()
-      });
-
       // Rule mapping already loaded in constructor
       if (this.verbose) {
         console.log(`🔧 [ESLintEngine] Initialize: Rule mapping size = ${this.ruleMapping.size}`);
-        console.log(`🔧 ESLint engine initialized`);
+        console.log(`🔧 ESLint engine initialized (ESLint instance will be created per-project)`);
       }
       
       this.initialized = true;
@@ -116,6 +108,126 @@ class ESLintEngine extends AnalysisEngineInterface {
     }
   }
 
+  /**
+   * Check for ESLint config files in project
+   * Following Rule C006: Verb-noun naming
+   * @param {string} projectPath - Path to the project being analyzed
+   * @returns {Object} Config file detection results
+   */
+  detectESLintConfig(projectPath) {
+    const fs = require('fs');
+    const path = require('path');
+    
+    const configFiles = {
+      flat: ['eslint.config.js', 'eslint.config.mjs'],
+      legacy: ['.eslintrc.js', '.eslintrc.json', '.eslintrc.yml', '.eslintrc.yaml', '.eslintrc'],
+      packageJson: 'package.json'
+    };
+    
+    const results = {
+      hasFlatConfig: false,
+      hasLegacyConfig: false,
+      hasPackageConfig: false,
+      foundFiles: []
+    };
+    
+    // Check for flat config files
+    for (const file of configFiles.flat) {
+      const filePath = path.join(projectPath, file);
+      if (fs.existsSync(filePath)) {
+        results.hasFlatConfig = true;
+        results.foundFiles.push(file);
+      }
+    }
+    
+    // Check for legacy config files
+    for (const file of configFiles.legacy) {
+      const filePath = path.join(projectPath, file);
+      if (fs.existsSync(filePath)) {
+        results.hasLegacyConfig = true;
+        results.foundFiles.push(file);
+      }
+    }
+    
+    // Check for package.json eslintConfig
+    const packagePath = path.join(projectPath, configFiles.packageJson);
+    if (fs.existsSync(packagePath)) {
+      try {
+        const packageJson = JSON.parse(fs.readFileSync(packagePath, 'utf8'));
+        if (packageJson.eslintConfig) {
+          results.hasPackageConfig = true;
+          results.foundFiles.push('package.json (eslintConfig)');
+        }
+      } catch (error) {
+        // Ignore package.json parsing errors
+      }
+    }
+    
+    return results;
+  }
+
+  /**
+   * Create ESLint instance with proper configuration
+   * Following Rule C006: Verb-noun naming
+   * @param {string} projectPath - Path to the project being analyzed
+   * @returns {Promise<Object>} Configured ESLint instance
+   */
+  async createESLintInstance(projectPath) {
+    try {
+      const { ESLint } = await this.loadESLint();
+      
+      // Detect existing config
+      const configDetection = this.detectESLintConfig(projectPath);
+      console.log(`🔍 [ESLintEngine] Config detection for ${projectPath}:`, configDetection);
+      
+      let eslintOptions;
+      
+      if (configDetection.hasFlatConfig) {
+        // Use flat config (ESLint v9+ preferred)
+        eslintOptions = {
+          overrideConfigFile: null,     // Let ESLint find flat config automatically
+          overrideConfig: this.createBaseConfig(),
+          fix: this.config?.fix || false,
+          cache: this.config?.cache || false,
+          cwd: projectPath
+        };
+        console.log(`✅ [ESLintEngine] Using flat config (modern ESLint v9+)`);
+      } else if (configDetection.hasLegacyConfig || configDetection.hasPackageConfig) {
+        // Use legacy config for compatibility - but ESLint v9+ only supports flat config
+        // We'll convert legacy to flat config on-the-fly
+        eslintOptions = {
+          overrideConfigFile: null,     // Force flat config mode
+          overrideConfig: this.createBaseConfig(),
+          fix: this.config?.fix || false,
+          cache: this.config?.cache || false,
+          cwd: projectPath
+        };
+        console.log(`✅ [ESLintEngine] Legacy config detected, but using flat config mode (ESLint v9+ requirement)`);
+      } else {
+        // No config found - use SunLint's base config only, create empty config file
+        eslintOptions = {
+          overrideConfig: this.createBaseConfig(),
+          fix: this.config?.fix || false,
+          cache: this.config?.cache || false,
+          cwd: projectPath
+        };
+        console.log(`⚠️ [ESLintEngine] No ESLint config found, using SunLint base config only`);
+      }
+
+      if (this.verbose) {
+        console.log(`📋 [ESLintEngine] ESLint options:`, JSON.stringify(eslintOptions, null, 2));
+      }
+
+      const eslint = new ESLint(eslintOptions);
+      console.log(`✅ [ESLintEngine] ESLint instance created successfully`);
+      
+      return eslint;
+    } catch (error) {
+      console.error('Failed to create ESLint instance:', error.message);
+      throw error;
+    }
+  }
+
   /**
    * Create base ESLint configuration
    * Following Rule C006: Verb-noun naming
@@ -336,19 +448,41 @@ class ESLintEngine extends AnalysisEngineInterface {
         return results;
       }
 
-      // Reconfigure ESLint with analysis-specific rules (v9+ compatible)
+      // Reconfigure ESLint with analysis-specific rules and detect project config
+      const path = require('path');
+      const projectPath = path.dirname(jstsFiles[0]) || process.cwd();
+      
+      const eslintInstance = await this.createESLintInstance(projectPath);
+      
+      // Override config for analysis-specific rules
+      const analysisConfig = {
+        ...this.createBaseConfig(),
+        ...eslintConfig
+      };
+      
+      // Re-create instance with analysis config
       const { ESLint } = await this.loadESLint();
-      const eslintInstance = new ESLint({
-        overrideConfigFile: null,
-        overrideConfig: {
-          ...this.createBaseConfig(),
-          ...eslintConfig
-        },
-        cwd: process.cwd()
-      });
+      const configDetection = this.detectESLintConfig(projectPath);
+      
+      let finalESLintOptions;
+      if (configDetection.hasFlatConfig) {
+        finalESLintOptions = {
+          overrideConfigFile: null,
+          overrideConfig: analysisConfig,
+          cwd: projectPath
+        };
+      } else {
+        // For legacy config or no config, omit overrideConfigFile to use default behavior
+        finalESLintOptions = {
+          overrideConfig: analysisConfig,
+          cwd: projectPath
+        };
+      }
+      
+      const finalESLintInstance = new ESLint(finalESLintOptions);
 
       // Run ESLint analysis
-      const eslintResults = await eslintInstance.lintFiles(jstsFiles);
+      const eslintResults = await finalESLintInstance.lintFiles(jstsFiles);
       
       // Convert ESLint results to SunLint format
       results.results = this.convertESLintResults(eslintResults, rules);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sun-asterisk/sunlint",
-  "version": "1.1.5",
+  "version": "1.1.6",
   "description": "☀️ SunLint - Multi-language static analysis tool for code quality and security | Sun* Engineering Standards",
   "main": "cli.js",
   "bin": {