@sun-asterisk/sungen 3.2.33 → 3.2.34-beta.1

package/src/orchestrator/viewpoint-pattern-catalog.ts

@@ -0,0 +1,61 @@
+/**
+ * The sungen-viewpoint pattern catalog by number — the `## N. <Name>` headings of
+ * `templates/ai-src/skills/sungen-viewpoint/group-*.md` — for the "UI Patterns Identified" table
+ * `sungen add` scaffolds into `test-viewpoint.md` (#842).
+ *
+ * The scaffold used to hard-code its own ten rows: eight of them numbered differently from the
+ * catalog (Data Table 2 vs 7, Modal 9 vs 12…), plus a "Pagination" pattern the catalog does not
+ * have, so authors copied the wrong numbers next to a skill that cites the right ones.
+ * `tests/harness/viewpoint-comments-and-patterns.run.ts` pins this list to the catalog headings.
+ */
+export interface ViewpointPattern {
+  n: number;
+  name: string;
+  /** Group F — native-app patterns, read IN ADDITION to 1–17 for a mobile screen. */
+  mobile?: boolean;
+}
+
+export const VIEWPOINT_PATTERNS: readonly ViewpointPattern[] = [
+  { n: 1, name: 'Form & Inputs' },
+  { n: 2, name: 'File Upload' },
+  { n: 3, name: 'Import / Export' },
+  { n: 4, name: 'Create / Add' },
+  { n: 5, name: 'Update / Edit' },
+  { n: 6, name: 'Delete' },
+  { n: 7, name: 'Data Table' },
+  { n: 8, name: 'Search' },
+  { n: 9, name: 'Filter' },
+  { n: 10, name: 'List / Card View' },
+  { n: 11, name: 'Chart / Analytics' },
+  { n: 12, name: 'Modal / Dialog' },
+  { n: 13, name: 'Navigation' },
+  { n: 14, name: 'Notification / Toast / Alert' },
+  { n: 15, name: 'Login / Logout' },
+  { n: 16, name: 'Register' },
+  { n: 17, name: 'Password Management' },
+  { n: 18, name: 'Bottom Sheet', mobile: true },
+  { n: 19, name: 'Tab Bar / Bottom Navigation', mobile: true },
+  { n: 20, name: 'Swipe-to-Delete Row', mobile: true },
+  { n: 21, name: 'Native Picker', mobile: true },
+  { n: 22, name: 'Permission Dialog', mobile: true },
+  { n: 23, name: 'Biometric Prompt', mobile: true },
+  { n: 24, name: 'Camera / Gallery Picker', mobile: true },
+  { n: 25, name: 'Push Notification', mobile: true },
+  { n: 26, name: 'Deep-link Entry', mobile: true },
+  { n: 27, name: 'Offline Banner', mobile: true },
+  { n: 28, name: 'Onboarding Carousel', mobile: true },
+  { n: 29, name: 'Pull-to-Refresh List', mobile: true },
+  { n: 30, name: 'Soft-Keyboard Overlap', mobile: true },
+  { n: 31, name: 'Settings Toggle List', mobile: true },
+  { n: 32, name: 'App Lifecycle & Orientation', mobile: true },
+];
+
+/**
+ * The scaffold's pattern-table rows: 1–17 for every screen, plus Group F on a mobile project.
+ * `Áp dụng?` is left empty for the QA to mark ✅ / ❌, as the QA template does.
+ */
+export function uiPatternRows(isMobile: boolean): string[] {
+  return VIEWPOINT_PATTERNS
+    .filter((p) => isMobile || !p.mobile)
+    .map((p) => `| ${p.n} | ${p.name} | | |`);
+}

package/src/orchestrator/viewpoint-scaffold.ts

@@ -0,0 +1,36 @@
+/**
+ * The `requirements/test-viewpoint.md` that `sungen add` and `sungen add-flow` write.
+ *
+ * It IS the QA template the AI drafts from (`skills/sungen-viewpoint/viewpoint-template.md`), read
+ * at run time so QA and AI always start from the same file. Two substitutions only: the title, and
+ * the template's sample UI-pattern rows → the full catalog for the project's platform (#842).
+ *
+ * Every sample row sits inside `<!-- -->`, so an untouched scaffold declares no viewpoint and the
+ * audit reports VIEWPOINT-MISSING instead of measuring the suite against samples (#841). The
+ * scaffold never carries an active `drafted-by: ai` line: that marks an AI draft, and this is not one.
+ */
+import * as fs from 'fs';
+import * as path from 'path';
+import { uiPatternRows } from './viewpoint-pattern-catalog';
+
+export const VIEWPOINT_TEMPLATE_PATH = path.join(
+  __dirname, 'templates', 'ai-src', 'skills', 'sungen-viewpoint', 'viewpoint-template.md',
+);
+
+/** A UI-pattern row: `| 12 | Modal / Dialog | … |`. Only section 1 of the template has them. */
+const PATTERN_ROW = /^\|\s*\d+\s*\|/;
+
+export function viewpointScaffold(title: string, isMobile: boolean): string {
+  const lines = fs.readFileSync(VIEWPOINT_TEMPLATE_PATH, 'utf-8').replace(/\r\n?/g, '\n').split('\n');
+  const titleAt = lines.findIndex((l) => l.startsWith('# '));
+  const rowsAt = lines.findIndex((l) => PATTERN_ROW.test(l));
+  // A template edit that drops either anchor must fail here, not ship a scaffold without them.
+  if (titleAt < 0 || rowsAt < 0) {
+    throw new Error(`viewpoint-template.md has no title or no UI-pattern sample rows: ${VIEWPOINT_TEMPLATE_PATH}`);
+  }
+  let rowsEnd = rowsAt;
+  while (rowsEnd < lines.length && PATTERN_ROW.test(lines[rowsEnd])) rowsEnd++;
+  lines[titleAt] = `# Test Viewpoint — ${title}`;
+  lines.splice(rowsAt, rowsEnd - rowsAt, ...uiPatternRows(isMobile));
+  return lines.join('\n');
+}