@sun-asterisk/sungen 3.2.32 → 3.2.33

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (243) hide show
  1. package/dist/cli/commands/audit.d.ts +1 -0
  2. package/dist/cli/commands/audit.d.ts.map +1 -1
  3. package/dist/cli/commands/audit.js +10 -1
  4. package/dist/cli/commands/audit.js.map +1 -1
  5. package/dist/cli/commands/capability.d.ts.map +1 -1
  6. package/dist/cli/commands/capability.js +35 -17
  7. package/dist/cli/commands/capability.js.map +1 -1
  8. package/dist/cli/commands/delivery.d.ts.map +1 -1
  9. package/dist/cli/commands/delivery.js +39 -18
  10. package/dist/cli/commands/delivery.js.map +1 -1
  11. package/dist/cli/commands/generate.d.ts.map +1 -1
  12. package/dist/cli/commands/generate.js +14 -7
  13. package/dist/cli/commands/generate.js.map +1 -1
  14. package/dist/cli/commands/results-merge.d.ts.map +1 -1
  15. package/dist/cli/commands/results-merge.js +2 -12
  16. package/dist/cli/commands/results-merge.js.map +1 -1
  17. package/dist/cli/commands/results-sanitize.d.ts.map +1 -1
  18. package/dist/cli/commands/results-sanitize.js +2 -13
  19. package/dist/cli/commands/results-sanitize.js.map +1 -1
  20. package/dist/dashboard/snapshot-builder.d.ts.map +1 -1
  21. package/dist/dashboard/snapshot-builder.js +6 -10
  22. package/dist/dashboard/snapshot-builder.js.map +1 -1
  23. package/dist/exporters/feature-parser.d.ts +21 -0
  24. package/dist/exporters/feature-parser.d.ts.map +1 -1
  25. package/dist/exporters/feature-parser.js +32 -1
  26. package/dist/exporters/feature-parser.js.map +1 -1
  27. package/dist/exporters/locale-variants.d.ts +7 -1
  28. package/dist/exporters/locale-variants.d.ts.map +1 -1
  29. package/dist/exporters/locale-variants.js +23 -16
  30. package/dist/exporters/locale-variants.js.map +1 -1
  31. package/dist/exporters/matrix/build.d.ts.map +1 -1
  32. package/dist/exporters/matrix/build.js +13 -7
  33. package/dist/exporters/matrix/build.js.map +1 -1
  34. package/dist/exporters/matrix/carry-manual-results.d.ts +70 -0
  35. package/dist/exporters/matrix/carry-manual-results.d.ts.map +1 -0
  36. package/dist/exporters/matrix/carry-manual-results.js +232 -0
  37. package/dist/exporters/matrix/carry-manual-results.js.map +1 -0
  38. package/dist/exporters/matrix/export.d.ts +2 -0
  39. package/dist/exporters/matrix/export.d.ts.map +1 -1
  40. package/dist/exporters/matrix/export.js +7 -1
  41. package/dist/exporters/matrix/export.js.map +1 -1
  42. package/dist/exporters/matrix/wording.d.ts +7 -0
  43. package/dist/exporters/matrix/wording.d.ts.map +1 -1
  44. package/dist/exporters/matrix/wording.js +27 -1
  45. package/dist/exporters/matrix/wording.js.map +1 -1
  46. package/dist/exporters/xlsx-exporter.d.ts +2 -0
  47. package/dist/exporters/xlsx-exporter.d.ts.map +1 -1
  48. package/dist/exporters/xlsx-exporter.js +7 -2
  49. package/dist/exporters/xlsx-exporter.js.map +1 -1
  50. package/dist/generators/test-generator/adapters/appium/templates/steps/actions/reinstall-app-action.hbs +2 -2
  51. package/dist/generators/test-generator/adapters/appium/templates/steps/assertions/label-value-assertion.hbs +8 -2
  52. package/dist/generators/test-generator/adapters/appium/templates/steps/assertions/visible-with-role-variable-assertion.hbs +7 -3
  53. package/dist/generators/test-generator/adapters/appium/templates/test-file.hbs +68 -4
  54. package/dist/generators/test-generator/adapters/playwright/templates/steps/assertions/label-value-assertion.hbs +7 -1
  55. package/dist/generators/test-generator/adapters/playwright/templates/steps/assertions/visible-with-role-variable-assertion.hbs +8 -4
  56. package/dist/generators/test-generator/adapters/playwright/templates/steps/partials/url-assertion.hbs +5 -1
  57. package/dist/generators/test-generator/code-generator.d.ts +2 -1
  58. package/dist/generators/test-generator/code-generator.d.ts.map +1 -1
  59. package/dist/generators/test-generator/code-generator.js +67 -3
  60. package/dist/generators/test-generator/code-generator.js.map +1 -1
  61. package/dist/generators/test-generator/diagnostics.d.ts +33 -4
  62. package/dist/generators/test-generator/diagnostics.d.ts.map +1 -1
  63. package/dist/generators/test-generator/diagnostics.js +32 -3
  64. package/dist/generators/test-generator/diagnostics.js.map +1 -1
  65. package/dist/generators/test-generator/patterns/index.d.ts +12 -2
  66. package/dist/generators/test-generator/patterns/index.d.ts.map +1 -1
  67. package/dist/generators/test-generator/patterns/index.js +15 -9
  68. package/dist/generators/test-generator/patterns/index.js.map +1 -1
  69. package/dist/generators/test-generator/patterns/types.d.ts +15 -0
  70. package/dist/generators/test-generator/patterns/types.d.ts.map +1 -1
  71. package/dist/generators/test-generator/patterns/with-parent-scope.d.ts +5 -0
  72. package/dist/generators/test-generator/patterns/with-parent-scope.d.ts.map +1 -1
  73. package/dist/generators/test-generator/patterns/with-parent-scope.js +6 -0
  74. package/dist/generators/test-generator/patterns/with-parent-scope.js.map +1 -1
  75. package/dist/generators/test-generator/step-mapper.d.ts +46 -0
  76. package/dist/generators/test-generator/step-mapper.d.ts.map +1 -1
  77. package/dist/generators/test-generator/step-mapper.js +84 -9
  78. package/dist/generators/test-generator/step-mapper.js.map +1 -1
  79. package/dist/generators/test-generator/utils/data-resolver.d.ts +25 -0
  80. package/dist/generators/test-generator/utils/data-resolver.d.ts.map +1 -1
  81. package/dist/generators/test-generator/utils/data-resolver.js +39 -8
  82. package/dist/generators/test-generator/utils/data-resolver.js.map +1 -1
  83. package/dist/generators/test-generator/utils/selector-entry-fields.d.ts.map +1 -1
  84. package/dist/generators/test-generator/utils/selector-entry-fields.js +1 -0
  85. package/dist/generators/test-generator/utils/selector-entry-fields.js.map +1 -1
  86. package/dist/generators/test-generator/utils/selector-resolver.d.ts +37 -4
  87. package/dist/generators/test-generator/utils/selector-resolver.d.ts.map +1 -1
  88. package/dist/generators/test-generator/utils/selector-resolver.js +212 -79
  89. package/dist/generators/test-generator/utils/selector-resolver.js.map +1 -1
  90. package/dist/harness/audit.d.ts.map +1 -1
  91. package/dist/harness/audit.js +12 -4
  92. package/dist/harness/audit.js.map +1 -1
  93. package/dist/harness/capability.d.ts +7 -1
  94. package/dist/harness/capability.d.ts.map +1 -1
  95. package/dist/harness/capability.js +15 -12
  96. package/dist/harness/capability.js.map +1 -1
  97. package/dist/harness/catalog/universal-viewpoints.yaml +5 -5
  98. package/dist/harness/config-file.d.ts +17 -0
  99. package/dist/harness/config-file.d.ts.map +1 -0
  100. package/dist/harness/config-file.js +100 -0
  101. package/dist/harness/config-file.js.map +1 -0
  102. package/dist/harness/depth-lint.d.ts.map +1 -1
  103. package/dist/harness/depth-lint.js +2 -1
  104. package/dist/harness/depth-lint.js.map +1 -1
  105. package/dist/harness/flow-check.d.ts.map +1 -1
  106. package/dist/harness/flow-check.js +6 -2
  107. package/dist/harness/flow-check.js.map +1 -1
  108. package/dist/harness/keyword-match.d.ts +59 -0
  109. package/dist/harness/keyword-match.d.ts.map +1 -0
  110. package/dist/harness/keyword-match.js +86 -0
  111. package/dist/harness/keyword-match.js.map +1 -0
  112. package/dist/harness/perf.d.ts +7 -1
  113. package/dist/harness/perf.d.ts.map +1 -1
  114. package/dist/harness/perf.js +13 -10
  115. package/dist/harness/perf.js.map +1 -1
  116. package/dist/harness/quality-gates.d.ts +9 -2
  117. package/dist/harness/quality-gates.d.ts.map +1 -1
  118. package/dist/harness/quality-gates.js +16 -4
  119. package/dist/harness/quality-gates.js.map +1 -1
  120. package/dist/harness/query-catalog.js +0 -0
  121. package/dist/harness/query-catalog.js.map +1 -1
  122. package/dist/harness/read-text.d.ts +6 -0
  123. package/dist/harness/read-text.d.ts.map +1 -1
  124. package/dist/harness/read-text.js +7 -1
  125. package/dist/harness/read-text.js.map +1 -1
  126. package/dist/harness/secret-scan.d.ts +27 -1
  127. package/dist/harness/secret-scan.d.ts.map +1 -1
  128. package/dist/harness/secret-scan.js +57 -4
  129. package/dist/harness/secret-scan.js.map +1 -1
  130. package/dist/harness/sensors.d.ts +12 -0
  131. package/dist/harness/sensors.d.ts.map +1 -1
  132. package/dist/harness/sensors.js +41 -18
  133. package/dist/harness/sensors.js.map +1 -1
  134. package/dist/harness/spec-branches.d.ts +0 -18
  135. package/dist/harness/spec-branches.d.ts.map +1 -1
  136. package/dist/harness/spec-branches.js +23 -2
  137. package/dist/harness/spec-branches.js.map +1 -1
  138. package/dist/harness/spec-coverage.d.ts.map +1 -1
  139. package/dist/harness/spec-coverage.js +14 -4
  140. package/dist/harness/spec-coverage.js.map +1 -1
  141. package/dist/harness/viewpoint-ledger.d.ts.map +1 -1
  142. package/dist/harness/viewpoint-ledger.js +2 -1
  143. package/dist/harness/viewpoint-ledger.js.map +1 -1
  144. package/dist/harness/write-atomic.d.ts +2 -0
  145. package/dist/harness/write-atomic.d.ts.map +1 -0
  146. package/dist/harness/write-atomic.js +62 -0
  147. package/dist/harness/write-atomic.js.map +1 -0
  148. package/dist/orchestrator/ai-skills/writer.d.ts.map +1 -1
  149. package/dist/orchestrator/ai-skills/writer.js +15 -7
  150. package/dist/orchestrator/ai-skills/writer.js.map +1 -1
  151. package/dist/orchestrator/assets-drift.d.ts.map +1 -1
  152. package/dist/orchestrator/assets-drift.js +11 -6
  153. package/dist/orchestrator/assets-drift.js.map +1 -1
  154. package/dist/orchestrator/project-deps-sync.d.ts.map +1 -1
  155. package/dist/orchestrator/project-deps-sync.js +22 -1
  156. package/dist/orchestrator/project-deps-sync.js.map +1 -1
  157. package/dist/orchestrator/project-initializer.d.ts +8 -0
  158. package/dist/orchestrator/project-initializer.d.ts.map +1 -1
  159. package/dist/orchestrator/project-initializer.js +49 -7
  160. package/dist/orchestrator/project-initializer.js.map +1 -1
  161. package/dist/orchestrator/security-overrides-catalog.d.ts +39 -0
  162. package/dist/orchestrator/security-overrides-catalog.d.ts.map +1 -0
  163. package/dist/orchestrator/security-overrides-catalog.js +63 -0
  164. package/dist/orchestrator/security-overrides-catalog.js.map +1 -0
  165. package/dist/orchestrator/security-overrides.d.ts +51 -0
  166. package/dist/orchestrator/security-overrides.d.ts.map +1 -0
  167. package/dist/orchestrator/security-overrides.js +165 -0
  168. package/dist/orchestrator/security-overrides.js.map +1 -0
  169. package/dist/orchestrator/templates/ai-src/skills/sungen-delivery/SKILL.md +14 -0
  170. package/dist/orchestrator/templates/ai-src/skills/sungen-error-mapping/SKILL.md +3 -1
  171. package/dist/orchestrator/templates/ai-src/skills/sungen-gherkin-syntax/SKILL.md +9 -0
  172. package/dist/orchestrator/templates/ai-src/skills/sungen-selector-keys/SKILL.md +13 -1
  173. package/dist/orchestrator/templates/specs-locale-fixture.ts +21 -9
  174. package/dist/orchestrator/templates/specs-pw-shape-reporter.ts +0 -0
  175. package/dist/orchestrator/templates/specs-url-assert.d.ts +17 -1
  176. package/dist/orchestrator/templates/specs-url-assert.d.ts.map +1 -1
  177. package/dist/orchestrator/templates/specs-url-assert.js +14 -2
  178. package/dist/orchestrator/templates/specs-url-assert.js.map +1 -1
  179. package/dist/orchestrator/templates/specs-url-assert.ts +24 -2
  180. package/dist/orchestrator/templates/wdio.conf.ts +24 -1
  181. package/package.json +3 -3
  182. package/src/cli/commands/audit.ts +10 -2
  183. package/src/cli/commands/capability.ts +51 -18
  184. package/src/cli/commands/delivery.ts +38 -16
  185. package/src/cli/commands/generate.ts +15 -7
  186. package/src/cli/commands/results-merge.ts +2 -8
  187. package/src/cli/commands/results-sanitize.ts +2 -9
  188. package/src/dashboard/snapshot-builder.ts +6 -8
  189. package/src/exporters/feature-parser.ts +32 -2
  190. package/src/exporters/locale-variants.ts +23 -17
  191. package/src/exporters/matrix/build.ts +14 -8
  192. package/src/exporters/matrix/carry-manual-results.ts +229 -0
  193. package/src/exporters/matrix/export.ts +10 -4
  194. package/src/exporters/matrix/wording.ts +26 -1
  195. package/src/exporters/xlsx-exporter.ts +7 -2
  196. package/src/generators/test-generator/adapters/adapter-interface.ts +2 -2
  197. package/src/generators/test-generator/adapters/appium/templates/steps/actions/reinstall-app-action.hbs +2 -2
  198. package/src/generators/test-generator/adapters/appium/templates/steps/assertions/label-value-assertion.hbs +8 -2
  199. package/src/generators/test-generator/adapters/appium/templates/steps/assertions/visible-with-role-variable-assertion.hbs +7 -3
  200. package/src/generators/test-generator/adapters/appium/templates/test-file.hbs +68 -4
  201. package/src/generators/test-generator/adapters/playwright/templates/steps/assertions/label-value-assertion.hbs +7 -1
  202. package/src/generators/test-generator/adapters/playwright/templates/steps/assertions/visible-with-role-variable-assertion.hbs +8 -4
  203. package/src/generators/test-generator/adapters/playwright/templates/steps/partials/url-assertion.hbs +5 -1
  204. package/src/generators/test-generator/code-generator.ts +54 -3
  205. package/src/generators/test-generator/diagnostics.ts +33 -4
  206. package/src/generators/test-generator/patterns/index.ts +15 -8
  207. package/src/generators/test-generator/patterns/types.ts +15 -0
  208. package/src/generators/test-generator/patterns/with-parent-scope.ts +6 -0
  209. package/src/generators/test-generator/step-mapper.ts +90 -8
  210. package/src/generators/test-generator/utils/data-resolver.ts +41 -12
  211. package/src/generators/test-generator/utils/selector-entry-fields.ts +1 -0
  212. package/src/generators/test-generator/utils/selector-resolver.ts +238 -82
  213. package/src/harness/audit.ts +17 -7
  214. package/src/harness/capability.ts +23 -12
  215. package/src/harness/catalog/universal-viewpoints.yaml +5 -5
  216. package/src/harness/config-file.ts +66 -0
  217. package/src/harness/depth-lint.ts +2 -1
  218. package/src/harness/flow-check.ts +6 -2
  219. package/src/harness/keyword-match.ts +85 -0
  220. package/src/harness/perf.ts +15 -7
  221. package/src/harness/quality-gates.ts +16 -4
  222. package/src/harness/query-catalog.ts +0 -0
  223. package/src/harness/read-text.ts +7 -1
  224. package/src/harness/secret-scan.ts +60 -4
  225. package/src/harness/sensors.ts +50 -19
  226. package/src/harness/spec-branches.ts +5 -2
  227. package/src/harness/spec-coverage.ts +14 -4
  228. package/src/harness/viewpoint-ledger.ts +2 -1
  229. package/src/harness/write-atomic.ts +22 -0
  230. package/src/orchestrator/ai-skills/writer.ts +18 -3
  231. package/src/orchestrator/assets-drift.ts +10 -5
  232. package/src/orchestrator/project-deps-sync.ts +23 -1
  233. package/src/orchestrator/project-initializer.ts +54 -6
  234. package/src/orchestrator/security-overrides-catalog.ts +69 -0
  235. package/src/orchestrator/security-overrides.ts +149 -0
  236. package/src/orchestrator/templates/ai-src/skills/sungen-delivery/SKILL.md +14 -0
  237. package/src/orchestrator/templates/ai-src/skills/sungen-error-mapping/SKILL.md +3 -1
  238. package/src/orchestrator/templates/ai-src/skills/sungen-gherkin-syntax/SKILL.md +9 -0
  239. package/src/orchestrator/templates/ai-src/skills/sungen-selector-keys/SKILL.md +13 -1
  240. package/src/orchestrator/templates/specs-locale-fixture.ts +21 -9
  241. package/src/orchestrator/templates/specs-pw-shape-reporter.ts +0 -0
  242. package/src/orchestrator/templates/specs-url-assert.ts +24 -2
  243. package/src/orchestrator/templates/wdio.conf.ts +24 -1
@@ -6,7 +6,7 @@ import { readYaml, readYamlIfExists } from '../../../utils/yaml-io';
6
6
 
7
7
  import { SelectorType } from '../../../utils/selector-types';
8
8
  import { DataResolver } from './data-resolver';
9
- import { DiagnosticsCollector } from '../diagnostics';
9
+ import { DiagnosticsCollector, type DiagnosticCode } from '../diagnostics';
10
10
  import { DEFAULT_CONTENT_NAMED_ROLES } from '../app-profile';
11
11
  import { reportUnknownEntryFields } from './selector-entry-fields';
12
12
  import { reportUnknownSelectorTypes } from './selector-type-validation';
@@ -33,6 +33,25 @@ interface SelectorEntry {
33
33
  // that bounces the user after the URL has already matched turns the step red instead of green.
34
34
  anchor?: SelectorEntry;
35
35
 
36
+ // === Page query identity (#748) ===
37
+ // For a `type: page` entry: `any` means the query string is NOT part of this page's identity.
38
+ //
39
+ // A bare `see [X] page` asserts that the URL carries NO query at all (#464 — a filter/search
40
+ // regression read as green while the query was wrong or gone). That is right for a page whose
41
+ // identity IS its path, and unsatisfiable for one keyed by a query — `/admins/detail?id=5`,
42
+ // where the id comes from the row the previous step clicked and is unknowable when the scenario
43
+ // is written. `with {{v}}` cannot rescue it: that asserts a LITERAL value.
44
+ //
45
+ // Declared on the ENTRY rather than added to the step grammar because it is a fact about the
46
+ // PAGE — every step targeting it needs the same reading — and because `wait for [X] page`
47
+ // already ignores the query. A step-form escape hatch would serve only the Then side and widen
48
+ // the very drift the shared url-assertion partial was written to end.
49
+ //
50
+ // It does NOT weaken a step that declares its own query: `with {{v}}` still asserts every
51
+ // declared param. This changes only what SILENCE means — from "there must be no query" to
52
+ // "the query is not mine to judge".
53
+ query?: 'any';
54
+
36
55
  // === Mobile per-platform variant (issue #392) ===
37
56
  // `android:`/`ios:` sub-selectors for one logical element whose locator differs per OS (composite
38
57
  // content-desc, partial/dynamic text, native predicate). Each is a full SelectorEntry.
@@ -166,12 +185,114 @@ export interface ResolvedSelector {
166
185
  checkedClass?: string;
167
186
  checkedAttribute?: string;
168
187
  anchor?: ResolvedSelector; // page entries only — the rendered-content proof behind `see [X] page` (#662)
188
+ query?: 'any'; // page entries only — the query is not part of this page's identity (#748)
169
189
  }
170
190
 
171
191
  /**
172
192
  * SelectorResolver - Resolves selector references to direct Playwright locator code
173
193
  * Supports natural language references with auto-generated keys
174
194
  */
195
+ /**
196
+ * Read an OWN property of a lookup table, or undefined.
197
+ *
198
+ * Every type table here — the alias map, the strategy map, the reverse index, and the parsed
199
+ * selectors.yaml itself — is a bare object literal, so it inherits Object.prototype and answers for
200
+ * keys it does not have. `elementType` is whatever word the author wrote after `]`, and the three
201
+ * readers failed three different ways on an inherited one: normalizeElementType is declared
202
+ * `: string` and returned a FUNCTION to be interpolated into a selector key; inferFromElementType
203
+ * CALLED that function with no receiver and crashed the compiler with "Cannot convert undefined or
204
+ * null to object"; and `ALIAS_SPELLINGS[t] ?? []` sailed past its own `??` guard, because a
205
+ * function is neither null nor undefined, and died on `.map`.
206
+ *
207
+ * No real feature file says `[X] valueOf`. The rule is the point: a lookup table must not answer
208
+ * for a key it does not have, and one helper is cheaper to keep right than four call sites.
209
+ */
210
+ function own<T>(table: Record<string, T>, key: string): T | undefined {
211
+ return Object.prototype.hasOwnProperty.call(table, key) ? table[key] : undefined;
212
+ }
213
+
214
+ /**
215
+ * Gherkin element-type spelling → the canonical suffix used in selectors.yaml keys.
216
+ *
217
+ * Module-scope so the table has exactly ONE reader-facing definition and the reverse index below
218
+ * can be DERIVED from it. A second, hand-written reverse table is the failure mode issue #728
219
+ * recorded: a hand-maintained mirror of something the source already states drifts, quietly, for
220
+ * months. Declaration order is meaningful — it decides which alias wins when a selectors.yaml
221
+ * declares two spellings of one canonical type (see ALIAS_SPELLINGS).
222
+ */
223
+ const ELEMENT_TYPE_ALIASES: Record<string, string> = {
224
+ // Text-like aliases → "text"
225
+ 'title': 'text',
226
+ 'label': 'text',
227
+ 'caption': 'text',
228
+ // Heading aliases → "heading" (role-based)
229
+ 'heading': 'heading',
230
+ 'header': 'heading',
231
+ 'message': 'text',
232
+ // Table-related aliases
233
+ 'column': 'columnheader',
234
+ // List-related aliases
235
+ 'list-item': 'listitem',
236
+ // Image aliases
237
+ 'logo': 'img',
238
+ 'image': 'img',
239
+ 'icon': 'img',
240
+ // Button aliases
241
+ 'btn': 'button',
242
+ // Field aliases
243
+ 'input': 'field',
244
+ 'textbox': 'field',
245
+ 'textarea': 'field',
246
+ 'editor': 'field',
247
+ // Search alias → searchbox role
248
+ 'search': 'searchbox',
249
+ // Toggle alias → switch role
250
+ 'toggle': 'switch',
251
+ // Alert alias → alertdialog role.
252
+ // UNREACHABLE in practice, kept for the same reason it is not changed: in sungen's grammar
253
+ // `alert` means the BROWSER system dialog, so `see [X] alert` matches a dedicated step pattern
254
+ // and compiles to `page.on('dialog', …)` without ever entering the selector resolver
255
+ // (verified by compiling the step; target-dictionary.mdx documents it as `page.on('dialog')`).
256
+ // This entry only answers a step form that reaches the resolver with the type `alert`, and
257
+ // none does. Removing it would be a behaviour change with no caller to benefit, so it stays.
258
+ 'alert': 'alertdialog',
259
+ // Modal/drawer alias → dialog role
260
+ 'modal': 'dialog',
261
+ 'drawer': 'dialog',
262
+ // Dropdown/select alias -> combobox role
263
+ 'dropdown': 'combobox',
264
+ 'select': 'combobox',
265
+ // Data aliases
266
+ 'item': 'listitem',
267
+ 'card': 'article',
268
+ 'cell': 'cell',
269
+ 'section': 'region',
270
+ // Feedback aliases
271
+ 'badge': 'text',
272
+ 'tooltip': 'text',
273
+ 'tag': 'text',
274
+ // Trigger aliases
275
+ 'menuitem': 'menuitem',
276
+ // System aliases
277
+ 'progressbar': 'progressbar',
278
+ 'spinner': 'status',
279
+ 'breadcrumb': 'navigation',
280
+ };
281
+
282
+ /**
283
+ * Canonical type → every alias spelling that normalizes to it, in ELEMENT_TYPE_ALIASES declaration
284
+ * order. Derived, never authored. Identity entries ('heading': 'heading') are excluded: they are
285
+ * already covered by the canonical candidate and would only duplicate a lookup.
286
+ */
287
+ const ALIAS_SPELLINGS: Record<string, string[]> = (() => {
288
+ const out: Record<string, string[]> = {};
289
+ for (const [alias, canonical] of Object.entries(ELEMENT_TYPE_ALIASES)) {
290
+ if (alias === canonical) continue;
291
+ (out[canonical] ??= []).push(alias);
292
+ }
293
+ return out;
294
+ })();
295
+
175
296
  export class SelectorResolver {
176
297
  private selectorCache = new Map<string, SelectorFile | LegacySelectorFile>();
177
298
  private selectorsDir: string;
@@ -393,69 +514,54 @@ export class SelectorResolver {
393
514
  'navigation': () => ({ strategy: 'role', role: 'navigation', name: label, value: 'navigation' }),
394
515
  };
395
516
 
396
- const factory = strategyMap[normalized];
517
+ const factory = own(strategyMap, normalized);
397
518
  return factory ? factory() : null;
398
519
  }
399
520
 
521
+ /**
522
+ * Does the compiler have an OPINION about this element type — is it an alias it normalizes, or a
523
+ * type auto-infer can serve?
524
+ *
525
+ * The distinction decides whether the last-resort sweep may run, and it exists because
526
+ * `step.elementType` is not always an element type. The parser takes the first word after `]`
527
+ * (gherkin-parser/index.ts), so `see [Quick Panel] is hidden` arrives here with the "type" `is`
528
+ * and `drag [Item] to [Drop Zone]` with `to`. Nine such function words appear across the shipped
529
+ * features. A word the compiler cannot reason about carries no type information at all, so it must
530
+ * not be treated as a narrowing signal — a step like that has to keep the same open fallback a
531
+ * bare `[Ref]` gets, or a project whose label needs suffixed keys loses every state-clause step.
532
+ *
533
+ * Derived from the two maps rather than listed, so a new alias or strategy is known here the day
534
+ * it is added. tests/docs/element-type-vocabulary-parity.run.ts pins the maps against the parser's
535
+ * own list and the published table.
536
+ */
537
+ private static isKnownElementType(elementType: string): boolean {
538
+ if (own(ELEMENT_TYPE_ALIASES, elementType) !== undefined) return true;
539
+ return SelectorResolver.inferFromElementType(elementType, '') !== null;
540
+ }
541
+
542
+ /**
543
+ * Every selectors.yaml key that could legitimately hold the entry for `[label] <elementType>`.
544
+ *
545
+ * Shared by the lookup and by the not-found message, so the error can never advertise a key the
546
+ * resolver did not actually try — the two drifting apart is how #752 stayed invisible: the throw
547
+ * that would have named the missing key was unreachable, and when it did fire it listed two
548
+ * candidates while the resolver had its own idea of which to check.
549
+ */
550
+ private static typedKeyCandidates(key: string, elementType: string, normalizedType: string): string[] {
551
+ return [...new Set([
552
+ `${key}--${normalizedType}`,
553
+ `${key}--${elementType}`,
554
+ ...(own(ALIAS_SPELLINGS, normalizedType) ?? []).map((alias) => `${key}--${alias}`),
555
+ ])];
556
+ }
557
+
400
558
  /**
401
559
  * Normalize elementType aliases to canonical YAML suffix
402
560
  * Gherkin writers may use: title, label, heading, text → all map to "text"
403
561
  * Similarly: btn → button, link → link, input/field → field
404
562
  */
405
563
  private static normalizeElementType(elementType: string): string {
406
- const aliasMap: Record<string, string> = {
407
- // Text-like aliases → "text"
408
- 'title': 'text',
409
- 'label': 'text',
410
- 'caption': 'text',
411
- // Heading aliases → "heading" (role-based)
412
- 'heading': 'heading',
413
- 'header': 'heading',
414
- 'message': 'text',
415
- // Table-related aliases
416
- 'column': 'columnheader',
417
- // List-related aliases
418
- 'list-item': 'listitem',
419
- // Image aliases
420
- 'logo': 'img',
421
- 'image': 'img',
422
- 'icon': 'img',
423
- // Button aliases
424
- 'btn': 'button',
425
- // Field aliases
426
- 'input': 'field',
427
- 'textbox': 'field',
428
- 'textarea': 'field',
429
- 'editor': 'field',
430
- // Search alias → searchbox role
431
- 'search': 'searchbox',
432
- // Toggle alias → switch role
433
- 'toggle': 'switch',
434
- // Alert alias → alertdialog role
435
- 'alert': 'alertdialog',
436
- // Modal/drawer alias → dialog role
437
- 'modal': 'dialog',
438
- 'drawer': 'dialog',
439
- // Dropdown/select alias -> combobox role
440
- 'dropdown': 'combobox',
441
- 'select': 'combobox',
442
- // Data aliases
443
- 'item': 'listitem',
444
- 'card': 'article',
445
- 'cell': 'cell',
446
- 'section': 'region',
447
- // Feedback aliases
448
- 'badge': 'text',
449
- 'tooltip': 'text',
450
- 'tag': 'text',
451
- // Trigger aliases
452
- 'menuitem': 'menuitem',
453
- // System aliases
454
- 'progressbar': 'progressbar',
455
- 'spinner': 'status',
456
- 'breadcrumb': 'navigation',
457
- };
458
- return aliasMap[elementType] || elementType;
564
+ return own(ELEMENT_TYPE_ALIASES, elementType) ?? elementType;
459
565
  }
460
566
 
461
567
  /**
@@ -475,33 +581,37 @@ export class SelectorResolver {
475
581
  // Try nth-suffixed key first: hay.gui.loi.cam.on--3
476
582
  if (nth && nth > 0) {
477
583
  const nthKey = `${key}--${nth}`;
478
- const nthEntry = selectorFile[nthKey];
584
+ const nthEntry = own(selectorFile, nthKey);
479
585
  if (nthEntry) {
480
586
  return this.resolveFromEntry(nthEntry, displayLabel);
481
587
  }
482
588
  }
483
589
 
484
- // Try type-suffixed key first: add.campaign--button, add.campaign--text
590
+ // Try type-suffixed keys: add.campaign--button, add.campaign--text
591
+ //
592
+ // EVERY spelling of the step's type is tried, not just the two the step itself could have been
593
+ // written with (#752). The alias table maps a Gherkin spelling onto a canonical one, but it was
594
+ // only ever applied to the STEP; the file's keys were compared raw. So `confirm--modal` was
595
+ // invisible to `[Confirm] dialog` while `confirm--dialog` resolved for `[Confirm] modal` —
596
+ // the mapping is one-directional and the lookup inherited that. The hole was not specific to
597
+ // modal/drawer: all 30 non-identity aliases had it.
598
+ //
599
+ // Order is deterministic and NOT file order: canonical first (the spelling the compiler thinks
600
+ // in), then whatever the author literally typed, then the remaining aliases in alias-table
601
+ // declaration order. A file declaring both `--modal` and `--drawer` therefore resolves the same
602
+ // way on every machine.
485
603
  if (elementType) {
486
604
  const normalizedType = SelectorResolver.normalizeElementType(elementType);
487
- const typedKey = `${key}--${normalizedType}`;
488
- const typedEntry = selectorFile[typedKey];
489
- if (typedEntry) {
490
- return this.resolveFromEntry(typedEntry, displayLabel);
491
- }
492
-
493
- // If normalized differs from original, also try original as-is
494
- if (normalizedType !== elementType) {
495
- const originalKey = `${key}--${elementType}`;
496
- const originalEntry = selectorFile[originalKey];
497
- if (originalEntry) {
498
- return this.resolveFromEntry(originalEntry, displayLabel);
605
+ for (const candidate of SelectorResolver.typedKeyCandidates(key, elementType, normalizedType)) {
606
+ const typedEntry = own(selectorFile, candidate);
607
+ if (typedEntry) {
608
+ return this.resolveFromEntry(typedEntry, displayLabel);
499
609
  }
500
610
  }
501
611
  }
502
612
 
503
613
  // Fallback to base key
504
- const entry = selectorFile[key];
614
+ const entry = own(selectorFile, key);
505
615
  if (entry) {
506
616
  return this.resolveFromEntry(entry, displayLabel);
507
617
  }
@@ -545,20 +655,30 @@ export class SelectorResolver {
545
655
  }
546
656
  }
547
657
 
548
- // Last resort: find any suffixed key matching key--*
549
- const suffixedKeys = Object.keys(selectorFile).filter(k => k.startsWith(`${key}--`));
550
- if (suffixedKeys.length > 0) {
551
- return this.resolveFromEntry(selectorFile[suffixedKeys[0]], displayLabel);
552
- }
553
-
554
- const tried: string[] = [];
555
- if (elementType) {
556
- const normalizedType = SelectorResolver.normalizeElementType(elementType);
557
- tried.push(`${key}--${normalizedType}`);
558
- if (normalizedType !== elementType) {
559
- tried.push(`${key}--${elementType}`);
658
+ // Last resort: any suffixed key matching key--*, for a [Ref] the compiler could not type.
659
+ //
660
+ // Two cases reach here and they are the same case: a bare [Ref] with no word after it, and a
661
+ // [Ref] followed by a word that is not an element type. The parser cannot tell the two apart —
662
+ // it takes the FIRST word after `]`, so `see [Quick Panel] is hidden` arrives typed `is`. In
663
+ // both, nothing is known about what kind of element is wanted, so any suffixed key is as good a
664
+ // guess as the next, and a project whose label needs suffixed keys keeps its state-clause steps.
665
+ //
666
+ // A step the compiler CAN type gets no such guess. The candidate scan above already tried every
667
+ // spelling that normalizes to that type, so whatever is still sitting under `key--` is a
668
+ // DIFFERENT element, and handing it back is the silent-wrong-answer shape of #752 itself.
669
+ // Falling through to the throw is better: it names the keys that were tried, and "add an entry"
670
+ // is an instruction the author can act on.
671
+ if (!elementType || !SelectorResolver.isKnownElementType(elementType)) {
672
+ const suffixedKeys = Object.keys(selectorFile).filter(k => k.startsWith(`${key}--`));
673
+ if (suffixedKeys.length > 0) {
674
+ return this.resolveFromEntry(selectorFile[suffixedKeys[0]], displayLabel);
560
675
  }
561
676
  }
677
+
678
+ const tried: string[] = elementType
679
+ ? SelectorResolver.typedKeyCandidates(
680
+ key, elementType, SelectorResolver.normalizeElementType(elementType))
681
+ : [];
562
682
  const suffix = tried.length > 0 ? ` (also tried ${tried.join(', ')})` : '';
563
683
  throw new Error(
564
684
  `Selector "${label}" (key: ${key}) not found in ${featureName}.yaml${suffix}. ` +
@@ -751,6 +871,20 @@ export class SelectorResolver {
751
871
  return out.class || out.attribute ? out : undefined;
752
872
  }
753
873
 
874
+ /**
875
+ * Report a selectors.yaml problem ONCE per entry+field, not once per step that resolves it.
876
+ *
877
+ * An entry is resolved again for every step that names it, so an unguarded `diagnostics.add`
878
+ * here repeats the same sentence a dozen times for one typo and buries everything else in the
879
+ * channel. `warnedContentNamed` is the existing de-dupe set; `key` namespaces the callers so two
880
+ * diagnostics about one entry cannot silence each other.
881
+ */
882
+ private warnOnce(key: string, code: DiagnosticCode, message: string): void {
883
+ if (this.warnedContentNamed.has(key)) return;
884
+ this.warnedContentNamed.add(key);
885
+ this.diagnostics?.add(code, message, { feature: this.featureName });
886
+ }
887
+
754
888
  /**
755
889
  * Resolve a selectors.yaml entry that is NOT reachable by key — a `columns.<col>.elements.cell`
756
890
  * declaration, which lives nested under a table entry. Public for that one caller; everything
@@ -824,6 +958,28 @@ export class SelectorResolver {
824
958
  // The anchor is a selector in its own right; it must not inherit the PAGE's label as its
825
959
  // accessible name, so it resolves against its own name (or nothing).
826
960
  if (entry.anchor) v2Fields.anchor = this.resolveFromEntry(entry.anchor, entry.anchor.name ?? '');
961
+ // Gated on the entry KIND, like the value check below: `query:` means nothing on a non-page
962
+ // entry, and both the field and its diagnostic are worded purely in page terms. Today's two
963
+ // consumers re-check `selectorType === 'page'` at the read site (the `anchor:` precedent), so
964
+ // this is belt-and-braces — but a third consumer that forgets the guard would otherwise inherit
965
+ // a field that was never meant for it.
966
+ if (type === 'page' && entry.query !== undefined) {
967
+ const declared = String(entry.query).trim().toLowerCase();
968
+ // Exactly one value is legal today. A typo must NOT read as the permissive form: it would
969
+ // silently turn off the bare-page query assertion (#464) on a page the author meant to keep
970
+ // strict, which is the class of quiet weakening this whole diagnostic channel exists for.
971
+ if (declared === 'any') v2Fields.query = 'any';
972
+ else this.warnOnce(`w037:${originalLabel}:query`, 'SG-W037',
973
+ `selector "${originalLabel}": query: ${JSON.stringify(String(entry.query))} is not a query rule — the only value is \`any\` ("the query is not part of this page's identity"). The declaration is ignored, so a bare \`see [${originalLabel}] page\` still requires the URL to carry NO query at all.`);
974
+ }
975
+ // A page `value` is the PATH only — pathToRegexSource strips a `?`/`#` before building the
976
+ // pattern. Silently, until now: an author who hit the bare-page query rule (#464) and reached
977
+ // for the obvious workaround got byte-identical output and no hint why, which is exactly how
978
+ // #748 was misdiagnosed in the field as a regex-escaping bug.
979
+ if (type === 'page' && typeof entry.value === 'string' && /[?#]/.test(entry.value)) {
980
+ this.warnOnce(`w037:${originalLabel}:value`, 'SG-W037',
981
+ `selector "${originalLabel}": the page value ${JSON.stringify(entry.value)} carries a query/fragment, which is DROPPED — a page value is the path only, and the pattern is matched against \`u.pathname\`, which never holds one. Writing it here changes nothing. To assert the query, declare it on the step (\`see [${originalLabel}] page with {{v}}\`); to say the query is not part of this page's identity, add \`query: any\` to the entry.`);
982
+ }
827
983
 
828
984
  // Helper to attach v2 fields and inputMethod
829
985
  const withExtras = (resolved: ResolvedSelector): ResolvedSelector => {
@@ -227,7 +227,12 @@ export function runAudit(screenDir: string, screenName: string): AuditReport {
227
227
  if (flowScenarios.length) {
228
228
  for (const c of flowCoveredThemes(gate.gaps, flowScenarios)) {
229
229
  const i = gate.gaps.findIndex((g) => g.theme === c.theme);
230
- if (i >= 0) { gate.gaps.splice(i, 1); gate.themesCovered++; flowCredits.push(c); }
230
+ if (i >= 0) {
231
+ gate.gaps.splice(i, 1); gate.themesCovered++; flowCredits.push(c);
232
+ // Keep the claim-proof list in step with the count (#776) — a theme credited to a flow
233
+ // must SAY it came from a flow, or the evidence lines silently under-report the total.
234
+ gate.coveredBy.push({ theme: c.theme, by: `(flow) ${c.flow}`, keyword: '—' });
235
+ }
231
236
  }
232
237
  gate.coverageRatio = gate.themesTotal ? gate.themesCovered / gate.themesTotal : 1;
233
238
  }
@@ -292,12 +297,16 @@ export function runAudit(screenDir: string, screenName: string): AuditReport {
292
297
  // #569 — handoff integrity: a flow's depth is also whether each cross-screen transition
293
298
  // is followed by an assertion on the carried state (same floor discipline as the other caps).
294
299
  const HANDOFF_FLOOR = 0.5;
295
- const businessDepth = Math.min(
300
+ // Each FLOOR is a floor on the CAP, not on the result — an out-of-range input ratio walks
301
+ // straight through it (a -1.5 oracle ratio yielded businessDepth -0.25 and crashed the CLI's
302
+ // bar renderer, #762). The axis is declared `0..1` above and weighted `critical`, so a negative
303
+ // value would also drag `score.overall` below zero. Clamp once, here, where the axis is formed.
304
+ const businessDepth = Math.max(0, Math.min(1, Math.min(
296
305
  depth.bcDepthRatio,
297
306
  flowDepth.stateful ? FLOW_DEPTH_FLOOR + (1 - FLOW_DEPTH_FLOOR) * flowDepth.ratio : 1,
298
- oracle.weak.length ? ORACLE_FLOOR + (1 - ORACLE_FLOOR) * oracle.ratio : 1,
307
+ oracle.weakFacet ? ORACLE_FLOOR + (1 - ORACLE_FLOOR) * oracle.ratio : 1,
299
308
  flowQ.hasContract && flowQ.handoffs.total > 0 ? HANDOFF_FLOOR + (1 - HANDOFF_FLOOR) * flowQ.handoffs.ratio : 1,
300
- );
309
+ )));
301
310
  // When the taxonomy drifted (most scenarios unclassified), the balance axis is unreliable — cap it
302
311
  // at 0.5 instead of awarding a vacuous 1.0 so a stale taxonomy fails loudly, not silently (H1).
303
312
  const balanceScore = balance.unclassifiedRatio > 0.4
@@ -594,12 +603,13 @@ export function runAudit(screenDir: string, screenName: string): AuditReport {
594
603
  `add data assertions (\`... with {{value}}\`, \`see all ... contain {{v}}\`) or, if cross-screen, defer to a flow with @manual + reason.`,
595
604
  );
596
605
  }
597
- // H5 — state isolation: a @parallel stateful flow that mutates the cart needs per-scenario
598
- // isolation, else count/quantity asserts go flaky. Warn (advisory) when no mitigation is present
606
+ // H5 — state isolation: a stateful flow that mutates the cart needs per-scenario isolation, else
607
+ // count/quantity asserts go flaky. Warn (advisory) when no mitigation is present
599
608
  // (@cleanup:cart / @isolate / a "Given … empty cart" background / fresh context).
609
+ // #759 — scoped by the ABSENCE of @serial, not the presence of @parallel: parallel is the default.
600
610
  if (isoRisk) {
601
611
  const what = flowQ.contract?.stateful ?? 'cart';
602
- findings.push(`ISOLATION-RISK: this @parallel flow mutates ${what} but has no per-scenario isolation → count/quantity/state asserts can go flaky when scenarios share it. Add \`@cleanup:${what}\` (or \`@isolate\`, a fresh context, or \`{{$timestamp}}\` data) so each scenario starts clean.`);
612
+ findings.push(`ISOLATION-RISK: this flow mutates ${what} but has no per-scenario isolation → count/quantity/state asserts can go flaky when scenarios share it. Add \`@cleanup:${what}\` (or \`@isolate\`, a fresh context, or \`{{$timestamp}}\` data) so each scenario starts clean.`);
603
613
  }
604
614
  // #414 — serial-cascade masking: an @serial suite of independent (re-navigating) scenarios hides
605
615
  // failures, because Playwright's describe.serial SKIPS everything after the first red. Isolation is
@@ -11,6 +11,7 @@
11
11
  import * as fs from 'fs';
12
12
  import * as path from 'path';
13
13
  import { parse as parseYaml, stringify as stringifyYaml } from 'yaml';
14
+ import { readYamlConfig, warnUnreadableConfig } from './config-file';
14
15
 
15
16
  export interface CapabilityProfile {
16
17
  platform?: string; // web | mobile | … (the runtime adapter)
@@ -23,7 +24,13 @@ export interface CapabilityProfile {
23
24
  * never asked for.
24
25
  */
25
26
  verification?: string[];
26
- source: 'capabilities.yaml' | 'absent';
27
+ /**
28
+ * Where the profile came from. `'unreadable'` is NOT `'absent'`: the file exists and says
29
+ * something, we just cannot read it. Callers that WRITE capabilities.yaml must branch on this —
30
+ * scaffolding a default over a file whose contents we failed to parse destroys the user's
31
+ * declaration (see `cli/commands/generate.ts`).
32
+ */
33
+ source: 'capabilities.yaml' | 'absent' | 'unreadable';
27
34
  }
28
35
 
29
36
  export type VerifyLayer = 'ui' | 'api' | 'db';
@@ -119,18 +126,22 @@ export function capabilitiesPath(cwd: string): string {
119
126
 
120
127
  export function readCapabilities(cwd: string): CapabilityProfile {
121
128
  const p = capabilitiesPath(cwd);
122
- if (!fs.existsSync(p)) return { platform: undefined, enabled: [], source: 'absent' };
123
- try {
124
- const y = parseYaml(fs.readFileSync(p, 'utf-8')) || {};
125
- return {
126
- platform: typeof y.platform === 'string' ? y.platform : undefined,
127
- enabled: Array.isArray(y.enabled) ? y.enabled.map(String) : [],
128
- verification: Array.isArray(y.verification) ? y.verification.map(String) : undefined,
129
- source: 'capabilities.yaml',
130
- };
131
- } catch {
132
- return { platform: undefined, enabled: [], source: 'absent' };
129
+ const read = readYamlConfig<Record<string, unknown> | null>(p);
130
+ if (read.state === 'absent') return { platform: undefined, enabled: [], source: 'absent' };
131
+ if (read.state === 'unreadable') {
132
+ // The profile decides the runtime adapter, the driver set and the verification scope. Reporting
133
+ // it once here covers all fifteen call sites; what each does about it is still its own choice.
134
+ warnUnreadableConfig(p, read.error,
135
+ 'this run cannot tell which platform or drivers the project declares, and falls back to none');
136
+ return { platform: undefined, enabled: [], source: 'unreadable' };
133
137
  }
138
+ const y = (read.value || {}) as Record<string, unknown>;
139
+ return {
140
+ platform: typeof y.platform === 'string' ? y.platform : undefined,
141
+ enabled: Array.isArray(y.enabled) ? y.enabled.map(String) : [],
142
+ verification: Array.isArray(y.verification) ? y.verification.map(String) : undefined,
143
+ source: 'capabilities.yaml',
144
+ };
134
145
  }
135
146
 
136
147
  export function writeCapabilities(cwd: string, profile: { platform?: string; enabled: string[]; verification?: string[] }): string {
@@ -24,7 +24,7 @@ page_types:
24
24
  detect_keywords: [cart, product, checkout, catalog, brand, category, "add to cart"]
25
25
  must_cover:
26
26
  - theme: list-data
27
- keywords: [list, displayed, card, "product card", grid]
27
+ keywords: ["product list", displayed, card, "product card", grid]
28
28
  depth:
29
29
  requires: data-assertion
30
30
  cross_screen: false
@@ -38,7 +38,7 @@ page_types:
38
38
  keywords: ["product detail", "detail page", "same product name", "matching name", "consistency", "same price"]
39
39
  template: "User remember [Product Name] text as {{v}} … User see [Detail Product Name] header with {{v}}"
40
40
  - theme: cart-correctness
41
- keywords: ["cart contains", quantity, "price", subtotal, "in cart", "cart content", "cart product"]
41
+ keywords: ["cart contains", "cart quantity", "cart price", subtotal, "in cart", "cart content", "cart product"]
42
42
  depth:
43
43
  requires: data-assertion
44
44
  cross_screen: true
@@ -77,7 +77,7 @@ page_types:
77
77
  keywords: ["required", "must be", "error message", "validation message"]
78
78
  template: "User see [Field Error] message with {{error_text}}"
79
79
  - theme: format-boundary
80
- keywords: [format, invalid, boundary, length, range]
80
+ keywords: [format, invalid, boundary, "max length", "min length", range]
81
81
  depth:
82
82
  requires: data-assertion
83
83
  cross_screen: false
@@ -125,10 +125,10 @@ page_types:
125
125
  # suite, which is a scoring decision for an owner, not a drive-by. `viewpoint-ledger` already
126
126
  # covers the dangerous half by refusing `tap [Back]` as an answer to an OS-back viewpoint item.
127
127
  mobile-list:
128
- detect_keywords: [feed, "pull to refresh", "infinite scroll", "load more", "list item", "list row"]
128
+ detect_keywords: ["feed item", "pull to refresh", "infinite scroll", "load more", "list item", "list row"]
129
129
  must_cover:
130
130
  - theme: list-data
131
- keywords: [list, feed, row, "list item", displayed]
131
+ keywords: ["feed item", row, "list item", displayed]
132
132
  depth:
133
133
  requires: data-assertion
134
134
  cross_screen: false
@@ -0,0 +1,66 @@
1
+ /**
2
+ * Reading a config file has THREE outcomes, not two: absent, parsed, and present-but-unreadable.
3
+ *
4
+ * Collapsing the third into the first is the defect class #782 catalogues. The shape recurs because
5
+ * it looks harmless: an `fs.existsSync` guard already answers absence, so the `catch` below it only
6
+ * ever fires for CORRUPTION — and returning the absent value there is the one case that must not be
7
+ * silent. A file that is absent was never written; a file that is broken WAS written, by someone who
8
+ * believes it is in effect.
9
+ *
10
+ * `run-manifest.ts:hashTopLevel` already draws the distinction for its own reader (`__unparseable__`
11
+ * rather than `{}`); this is that idea as a seam every config reader can share, so the next one does
12
+ * not have to rediscover it.
13
+ *
14
+ * Nothing here throws: the caller owns the consequence, because only the caller knows it. What the
15
+ * type removes is the option of not deciding.
16
+ */
17
+ import * as fs from 'fs';
18
+ import { parse as parseYaml } from 'yaml';
19
+
20
+ export type ConfigRead<T> =
21
+ | { state: 'absent' }
22
+ | { state: 'ok'; value: T }
23
+ | { state: 'unreadable'; error: string };
24
+
25
+ const message = (e: unknown): string => (e instanceof Error ? e.message.split('\n')[0] : String(e));
26
+
27
+ /** Read + parse a YAML config. An empty or comment-only file parses to null — that is `ok`, not broken. */
28
+ export function readYamlConfig<T>(file: string): ConfigRead<T> {
29
+ if (!fs.existsSync(file)) return { state: 'absent' };
30
+ try {
31
+ return { state: 'ok', value: (parseYaml(fs.readFileSync(file, 'utf-8')) ?? null) as T };
32
+ } catch (e) {
33
+ return { state: 'unreadable', error: message(e) };
34
+ }
35
+ }
36
+
37
+ /** Read + parse a JSON config. Unlike YAML, an empty file is NOT valid JSON and reads as unreadable. */
38
+ export function readJsonConfig<T>(file: string): ConfigRead<T> {
39
+ if (!fs.existsSync(file)) return { state: 'absent' };
40
+ try {
41
+ return { state: 'ok', value: JSON.parse(fs.readFileSync(file, 'utf-8')) as T };
42
+ } catch (e) {
43
+ return { state: 'unreadable', error: message(e) };
44
+ }
45
+ }
46
+
47
+ /**
48
+ * One line to stderr naming the file, the parse error, and WHAT THE RUN WILL DO INSTEAD — the last
49
+ * part is the whole point: "capabilities.yaml is broken" leaves the reader guessing; "…so this run
50
+ * treats the project as web" tells them why their mobile suite just compiled wrong.
51
+ *
52
+ * At most once per file per process. `readCapabilities` alone has fifteen call sites, and a warning
53
+ * repeated fifteen times reads as noise — which is its own way of being ignored.
54
+ */
55
+ const warned = new Set<string>();
56
+
57
+ export function warnUnreadableConfig(file: string, error: string, consequence: string): void {
58
+ if (warned.has(file)) return;
59
+ warned.add(file);
60
+ console.error(`⚠️ ${file}: unreadable (${error}) — ${consequence}`);
61
+ }
62
+
63
+ /** Test seam: the dedup set is process-global, so a suite exercising several cases must clear it. */
64
+ export function resetUnreadableConfigWarnings(): void {
65
+ warned.clear();
66
+ }
@@ -15,6 +15,7 @@ import * as fs from 'fs';
15
15
  import * as path from 'path';
16
16
  import { loadUnitScenarios, parseViewpointOverview, ScenarioInfo, ViewpointEntry } from './parse';
17
17
  import { loadCatalog, viewpointGate, assertionDepth, dataThemesFor, CatalogTheme } from './sensors';
18
+ import { keywordHit } from './keyword-match';
18
19
 
19
20
  export type DepthAction = 'deepen' | 'defer';
20
21
 
@@ -45,7 +46,7 @@ export interface DepthLintReport {
45
46
  function matchTheme(s: ScenarioInfo, dataThemes: CatalogTheme[]): CatalogTheme | undefined {
46
47
  return dataThemes.find((t) => {
47
48
  const kws = t.depth?.keywords?.length ? t.depth.keywords : t.keywords;
48
- return kws.some((k) => s.haystack.includes(k.toLowerCase()));
49
+ return kws.some((k) => keywordHit(s.haystack, k));
49
50
  });
50
51
  }
51
52