@sun-asterisk/sungen 3.2.31 → 3.2.33

package/src/exporters/feature-parser.ts

@@ -3,9 +3,39 @@
  * Reuses the existing GherkinParser.
  */
 
-import { GherkinParser, ParsedFeature, ParsedScenario } from '../generators/gherkin-parser';
+import { GherkinParser, ParsedDataTable, ParsedFeature, ParsedScenario } from '../generators/gherkin-parser';
 import { FeatureMetadata, OrderedStep, ScenarioMetadata } from './types';
 
+/**
+ * Fold a step's data table into the text the exporters carry (#771). The table
+ * IS the step's content — `tab order:` names every stop, `table match data:`
+ * every expected row — so without it a delivered case says "See tab order:."
+ * and a table edit leaves the scenario fingerprint unchanged.
+ *
+ * Folded once, here, so every consumer (matrix + legacy cells, fingerprint,
+ * oracle shape) sees the same thing. A step with no table keeps its text
+ * byte-identical: no existing fingerprint moves on upgrade.
+ *
+ *   `tab order:` | Ref | [A] | [B] |  → `tab order: [A] → [B]`   (order is the meaning;
+ *                                         `Ref` is a keyword header, not a column name)
+ *   any other    | Name | Age | …      → `…: Name: Alice, Age: 30; Name: Bob, Age: 25`
+ *                (one column too: `Title: x; Title: y` — its header names what x is)
+ *
+ * A blank cell renders as `(empty)` — the matrix's data-fidelity word. Left blank it would
+ * read `Age: ;`, indistinguishable from the truncation this fixes, and in `table match
+ * data:` a blank cell is itself an assertion (the cell is empty).
+ */
+export function withDataTable(text: string, table: ParsedDataTable | undefined): string {
+  if (!table || table.rows.length === 0) return text;
+  const base = text.replace(/\s*:\s*$/, '');
+  const cell = (v: string | undefined): string => (v === undefined || v.trim() === '' ? '(empty)' : v);
+  // Only `tab order` is a sequence of refs — the one shape matrix/wording.ts reads as `→`.
+  const body = /\btab order$/i.test(base)
+    ? table.rows.map((r) => cell(r.cells[0])).join(' → ')
+    : table.rows.map((r) => table.headers.map((h, i) => `${h}: ${cell(r.cells[i])}`).join(', ')).join('; ');
+  return `${base}: ${body}`;
+}
+
 /**
  * Variables referenced in a scenario: find all {{var_name}} in step text.
  */
@@ -60,7 +90,7 @@ function classifySteps(scenario: ParsedScenario): OrderedStep[] {
     else if (keyword === 'Then') currentBucket = 'then';
     // And / But → inherit currentBucket
 
-    ordered.push({ text: step.text, bucket: currentBucket });
+    ordered.push({ text: withDataTable(step.text, step.dataTable), bucket: currentBucket });
   }
 
   return ordered;

package/src/exporters/locale-variants.ts

@@ -34,7 +34,7 @@
  */
 import * as fs from 'fs';
 import * as path from 'path';
-import { parse as parseYaml } from 'yaml';
+import { readYamlConfig, warnUnreadableConfig } from '../harness/config-file';
 
 export interface LocaleVariant {
   /** Result-file suffix as found on disk ('' = base). */
@@ -65,23 +65,29 @@ export interface LocaleConfig {
 
 export const DEFAULT_BASE_LOCALE = 'en';
 
-/** Read the i18n declaration from qa/capabilities.yaml (absent → no locales, base 'en'). */
+/**
+ * Read the i18n declaration from qa/capabilities.yaml (absent → no locales, base 'en').
+ *
+ * An unreadable file previously took the same path as an absent one — the `existsSync` check sat
+ * INSIDE the try, so a parse error fell through to the same "undeclared" return. Every declared
+ * locale then dropped out of the deliverable with no line anywhere saying why.
+ */
 export function readLocaleConfig(cwd: string): LocaleConfig {
-  try {
-    const p = path.join(cwd, 'qa', 'capabilities.yaml');
-    if (fs.existsSync(p)) {
-      const parsed = parseYaml(fs.readFileSync(p, 'utf-8')) as
-        { locales?: unknown; base_locale?: unknown } | null;
-      const locales = Array.isArray(parsed?.locales)
-        ? parsed!.locales!.filter((l): l is string => typeof l === 'string' && l.length > 0)
-        : [];
-      const baseLocale = typeof parsed?.base_locale === 'string' && parsed.base_locale
-        ? parsed.base_locale
-        : DEFAULT_BASE_LOCALE;
-      return { baseLocale, locales };
-    }
-  } catch { /* malformed yaml → behave as undeclared */ }
-  return { baseLocale: DEFAULT_BASE_LOCALE, locales: [] };
+  const p = path.join(cwd, 'qa', 'capabilities.yaml');
+  const read = readYamlConfig<{ locales?: unknown; base_locale?: unknown } | null>(p);
+  if (read.state === 'absent') return { baseLocale: DEFAULT_BASE_LOCALE, locales: [] };
+  if (read.state === 'unreadable') {
+    warnUnreadableConfig(p, read.error, 'no locale variants are discovered — the deliverable covers the base locale only');
+    return { baseLocale: DEFAULT_BASE_LOCALE, locales: [] };
+  }
+  const parsed = read.value;
+  const locales = Array.isArray(parsed?.locales)
+    ? parsed!.locales!.filter((l): l is string => typeof l === 'string' && l.length > 0)
+    : [];
+  const baseLocale = typeof parsed?.base_locale === 'string' && parsed.base_locale
+    ? parsed.base_locale
+    : DEFAULT_BASE_LOCALE;
+  return { baseLocale, locales };
 }
 
 const OS_SUFFIX = /^(android|ios)(\.|$)/;

package/src/exporters/matrix/build.ts

@@ -19,7 +19,7 @@ import {
 import { getCasesDatasetRows, resolveResultVariants } from '../result-variants';
 import { renderDynamicTokens } from '../test-data-resolver';
 import { maskCredentialValue } from '../sensitive-key';
-import { classifyManualComments, renderAction, renderExpected, renderPrecondition, renderSetupInstruction, runtimeVarsOf } from './wording';
+import { afterSubstitution, classifyManualComments, renderAction, renderExpected, renderPrecondition, renderSetupInstruction, runtimeVarsOf } from './wording';
 import { scenarioFingerprint, combinedFingerprint, mapContentFingerprint } from './fingerprint';
 import {
   CoverageVariant,
@@ -251,10 +251,16 @@ export function deriveVariants(inputs: Pick<BuildInputs, 'feature' | 'merged' |
       verification: manual?.verification.map((t) => sentenceOf(t)) ?? [],
     };
 
-    /** Render the display cells for one data context (vars resolved first). */
+    /**
+     * Render the display cells for one data context. Steps are worded FIRST and values
+     * substituted AFTER (#772): wording strips the DSL's `[Ref]` brackets, and a value
+     * such as `^[A-Za-z]{3}` or `[E2E-01] title` must never be mistaken for one.
+     * Preconditions (rendered at build time above) already went in this order.
+     */
     const renderCells = (vars: Record<string, string>): { trigger: string[]; oracle: string[]; precondition: string[]; verification: string[] } => {
       const sub = (s: string): string => substituteDisplayVars(s, vars, runtimeVars);
-      const preconditionOut = precondition.map(sub);
+      const fill = (rendered: string): string => afterSubstitution(sub(rendered));
+      const preconditionOut = precondition.map(fill);
       const verificationOut = base.verification.map(sub);
       if (procedureProfile === 'sequence' && !manual) {
         // Ordered flow (review B-03): keep the event order — actions stay numbered in
@@ -266,9 +272,9 @@ export function deriveVariants(inputs: Pick<BuildInputs, 'feature' | 'merged' |
         const trigger: string[] = [];
         const oracle: string[] = [];
         steps.forEach((s, i) => {
-          if (i > lastActionIdx) oracle.push(renderExpected(sub(s.text)));           // trailing Then block
-          else if (s.bucket === 'then') trigger.push(`Verify: ${renderExpected(sub(s.text))}`);
-          else if (s.bucket === 'when') trigger.push(renderAction(sub(s.text)));
+          if (i > lastActionIdx) oracle.push(fill(renderExpected(s.text)));           // trailing Then block
+          else if (s.bucket === 'then') trigger.push(`Verify: ${fill(renderExpected(s.text))}`);
+          else if (s.bucket === 'when') trigger.push(fill(renderAction(s.text)));
           // leading given steps already live in the precondition
         });
         return { trigger, oracle, precondition: preconditionOut, verification: verificationOut };
@@ -277,8 +283,8 @@ export function deriveVariants(inputs: Pick<BuildInputs, 'feature' | 'merged' |
       // Method/API/Header/Body lines are already reader-facing, not step DSL).
       const trigger = apiCallsAreTrigger
         ? apiRequestLines.map(sub)
-        : rawTrigger.map((s) => renderAction(sub(s)));
-      const oracle = rawOracle.map((s) => renderExpected(sub(s)));
+        : rawTrigger.map((s) => fill(renderAction(s)));
+      const oracle = rawOracle.map((s) => fill(renderExpected(s)));
       return {
         // A pure-render check (Given + Then only) is checked on page load — say so
         // in words instead of a placeholder token (review §10.3).

package/src/exporters/matrix/carry-manual-results.ts

@@ -0,0 +1,229 @@
+/**
+ * Carry a tester's hand-entered Manual results across a `sungen delivery` re-run (#756).
+ *
+ * The matrix workbook is rebuilt from scratch on every run, and a manual variant has no
+ * run-report entry, so its Result cell renders `Pending` and M–P render blank. Without
+ * this step the re-run overwrote the file and the tester's record was gone.
+ *
+ * Before the new workbook is written, the existing file's Manual sheet is read, and each
+ * variant sub-row's L–P cells (Test Result, Executed Date, Test Executor, Test Environment,
+ * Note) are carried into the new workbook by `v.ref` — column A.
+ *
+ * A result is only true of the procedure it was executed against, so every write stamps
+ * `ref → fingerprint` into a veryHidden sheet. The next run carries a result only while the
+ * stamp still matches; a changed procedure resets it to `Pending` and keeps the previous
+ * values in Note. Spec: docs/spec/delivery-coverage-matrix-spec.md §8.4.
+ *
+ * Manual sheet only: on Auto the run report is the source of truth for Result.
+ */
+
+import * as fs from 'fs';
+import * as ExcelJS from 'exceljs';
+import { MatrixModel } from './types';
+import { HEADER_ROW, RESULT_COL } from './render-testcase-sheet';
+
+const MANUAL_SHEET = 'Manual';
+/** veryHidden: Excel's UI cannot unhide it, so a tester cannot edit the guard by accident. */
+export const STAMP_SHEET = '_sungen_manual';
+/** L..P — the tester-owned columns of a variant sub-row. */
+const CARRIED_COLS = [RESULT_COL, RESULT_COL + 1, RESULT_COL + 2, RESULT_COL + 3, RESULT_COL + 4];
+const NOTE_INDEX = 4;
+const RESET_MARKER = '[sungen] Procedure changed since this result was recorded';
+
+interface CarriedCell { value: ExcelJS.CellValue; numFmt?: string }
+
+interface PriorRow { cells: CarriedCell[] }
+
+export interface PriorManualResults {
+  rows: Map<string, PriorRow>;
+  /** Later copies of a ref already read — only the first is carried, so these are reported. */
+  duplicates: { ref: string; result: string }[];
+  /** `ref → fingerprint` from the stamp sheet; null when the file predates #756. */
+  stamps: Map<string, string> | null;
+}
+
+export interface ManualCarryReport {
+  /** Carried with a matching fingerprint. */
+  carried: number;
+  /** Carried from a file with no stamp — no drift check was possible. */
+  unchecked: number;
+  /** Result reset to Pending because the procedure changed. */
+  reset: string[];
+  /** Prior rows with an entry that no longer match any manual variant. */
+  notPlaced: { ref: string; result: string }[];
+  /** Prior rows with an entry that repeat a ref above them — not carried. */
+  duplicates: { ref: string; result: string }[];
+}
+
+function isFormula(v: ExcelJS.CellValue): boolean {
+  return typeof v === 'object' && v !== null && ('formula' in v || 'sharedFormula' in v);
+}
+
+function cellText(v: ExcelJS.CellValue): string {
+  if (v === null || v === undefined) return '';
+  if (v instanceof Date) return isNaN(v.getTime()) ? '' : v.toISOString().slice(0, 10);
+  if (typeof v === 'object') {
+    if ('richText' in v) return v.richText.map((r) => r.text).join('').trim();
+    if ('text' in v) return String(v.text).trim();
+    if ('result' in v) return cellText(v.result as ExcelJS.CellValue);
+  }
+  return String(v).trim();
+}
+
+/**
+ * ExcelJS reads a formula's text result under a date format as an Invalid Date. Drop that
+ * cached result — Excel recomputes it on open — instead of writing NaN back into the file.
+ */
+function readable(v: ExcelJS.CellValue): ExcelJS.CellValue {
+  if (isFormula(v)) {
+    const { result, ...formula } = v as ExcelJS.CellFormulaValue;
+    if (result instanceof Date && isNaN(result.getTime())) return formula as ExcelJS.CellValue;
+  }
+  return v;
+}
+
+/** A row still at the rendered default carries nothing. */
+function isUntouched(cells: CarriedCell[]): boolean {
+  const [result, ...rest] = cells.map((c) => cellText(c.value));
+  return (result === '' || result === 'Pending') && rest.every((t) => t === '');
+}
+
+/**
+ * Variant sub-rows of a Manual sheet, in row order: `[ref, row]`. Either signal is enough:
+ * the renderer puts variants on outline level 1, and a parent's Result is a roll-up formula.
+ * Outline levels are lost by some spreadsheet tools on save, and a tester can paste a
+ * formula into a variant's Result, so relying on one alone would hide the row silently.
+ */
+function variantRows(ws: ExcelJS.Worksheet): [string, ExcelJS.Row][] {
+  const out: [string, ExcelJS.Row][] = [];
+  for (let r = HEADER_ROW + 1; r <= ws.rowCount; r++) {
+    const row = ws.getRow(r);
+    const ref = cellText(row.getCell(1).value);
+    if (ref && (row.outlineLevel === 1 || !isFormula(row.getCell(RESULT_COL).value))) out.push([ref, row]);
+  }
+  return out;
+}
+
+/**
+ * Read the Manual results of the workbook about to be overwritten. Returns null when there is
+ * no such file. A file that exists but cannot be read THROWS: overwriting it would destroy the
+ * very record this step exists to keep.
+ */
+export async function readPriorManualResults(file: string): Promise<PriorManualResults | null> {
+  if (!fs.existsSync(file)) return null;
+  const wb = new ExcelJS.Workbook();
+  try {
+    await wb.xlsx.readFile(file);
+  } catch (e) {
+    throw new Error(
+      `cannot read ${file} to carry its Manual results (${(e as Error).message}). ` +
+      'Close it in Excel, or move it aside to start a fresh workbook, then re-run.',
+    );
+  }
+
+  // Every workbook sungen writes has a Manual sheet, even an empty one. Without it the
+  // tester's results cannot be located — carrying nothing would look like a clean run.
+  const ws = wb.getWorksheet(MANUAL_SHEET);
+  if (!ws) {
+    throw new Error(
+      `${file} has no "${MANUAL_SHEET}" sheet, so its Manual results cannot be carried. ` +
+      `Rename the sheet back to "${MANUAL_SHEET}", or move the file aside to start a fresh workbook, then re-run.`,
+    );
+  }
+
+  const rows = new Map<string, PriorRow>();
+  const duplicates: PriorManualResults['duplicates'] = [];
+  for (const [ref, row] of variantRows(ws)) {
+    const cells = CARRIED_COLS.map((c) => {
+      const cell = row.getCell(c);
+      return { value: readable(cell.value), ...(cell.numFmt ? { numFmt: cell.numFmt } : {}) };
+    });
+    if (!rows.has(ref)) rows.set(ref, { cells });
+    else if (!isUntouched(cells)) duplicates.push({ ref, result: cellText(cells[0].value) || '(no result)' });
+  }
+
+  const stampWs = wb.getWorksheet(STAMP_SHEET);
+  let stamps: Map<string, string> | null = null;
+  if (stampWs) {
+    stamps = new Map();
+    stampWs.eachRow((row, n) => {
+      if (n > 1) stamps!.set(cellText(row.getCell(1).value), cellText(row.getCell(2).value));
+    });
+  }
+  return { rows, duplicates, stamps };
+}
+
+/**
+ * Note for a reset row: what was invalidated, then whatever the tester had written. A note
+ * that is a hyperlink (evidence, a defect ticket) stays one — only its text gains the marker.
+ */
+function resetNote(prior: CarriedCell[]): ExcelJS.CellValue {
+  const [result, date, executor] = prior.map((c) => cellText(c.value));
+  const was = [result, date, executor].filter(Boolean).join(' · ');
+  const header = `${RESET_MARKER} — previous: ${was}. Re-run required.`;
+  const note = prior[NOTE_INDEX].value;
+  const own = cellText(note);
+  if (typeof note === 'object' && note !== null && 'hyperlink' in note) {
+    return { ...note, text: `${header}\n${own}` };
+  }
+  return own ? `${header}\n${own}` : header;
+}
+
+/**
+ * Carry `prior` into the freshly rendered `wb`, then stamp every manual variant's fingerprint.
+ * Only the Manual sheet's variant sub-rows are touched.
+ */
+export function carryManualResults(
+  wb: ExcelJS.Workbook,
+  model: MatrixModel,
+  prior: PriorManualResults | null,
+): ManualCarryReport {
+  const report: ManualCarryReport = { carried: 0, unchecked: 0, reset: [], notPlaced: [], duplicates: prior?.duplicates ?? [] };
+  const fingerprints = new Map(
+    model.items.flatMap((i) => i.variants).filter((v) => v.mode === 'manual').map((v) => [v.ref, v.fingerprint]),
+  );
+
+  const ws = wb.getWorksheet(MANUAL_SHEET);
+  const placed = new Set<string>();
+  if (ws && prior) {
+    for (const [ref, row] of variantRows(ws)) {
+      const before = prior.rows.get(ref);
+      if (!before) continue;
+      placed.add(ref);
+      if (isUntouched(before.cells)) continue;
+
+      const stamped = prior.stamps?.get(ref);
+      // Only a recorded result is a claim about the procedure. A row with no result (a
+      // blocker note, or one already reset) is carried as-is, so a second procedure
+      // change does not stack a second marker on it.
+      const hasResult = !['', 'Pending'].includes(cellText(before.cells[0].value));
+      if (stamped !== undefined && stamped !== fingerprints.get(ref) && hasResult) {
+        row.getCell(RESULT_COL).value = 'Pending';
+        row.getCell(CARRIED_COLS[NOTE_INDEX]).value = resetNote(before.cells);
+        report.reset.push(ref);
+        continue;
+      }
+
+      CARRIED_COLS.forEach((c, i) => {
+        const cell = row.getCell(c);
+        cell.value = before.cells[i].value;
+        if (before.cells[i].numFmt) cell.numFmt = before.cells[i].numFmt!;
+      });
+      if (stamped === undefined) report.unchecked++;
+      else report.carried++;
+    }
+  }
+
+  if (prior) {
+    for (const [ref, before] of prior.rows) {
+      if (!placed.has(ref) && !isUntouched(before.cells)) {
+        report.notPlaced.push({ ref, result: cellText(before.cells[0].value) || '(no result)' });
+      }
+    }
+  }
+
+  const stampWs = wb.addWorksheet(STAMP_SHEET, { state: 'veryHidden' });
+  stampWs.addRow(['ref', 'fingerprint']);
+  for (const [ref, fp] of fingerprints) stampWs.addRow([ref, fp]);
+  return report;
+}

package/src/exporters/matrix/export.ts

@@ -16,7 +16,8 @@ import { loadPlaywrightReport } from '../playwright-report-parser';
 import { mergeFeatureAndSpec } from '../scenario-merger';
 import { getPackageVersion } from '../package-info';
 import { writeCsv } from '../csv-exporter';
-import { writeXlsx } from '../xlsx-exporter';
+import { deliverableXlsxPath, writeXlsx } from '../xlsx-exporter';
+import { carryManualResults, ManualCarryReport, readPriorManualResults } from './carry-manual-results';
 import { loadPerfConfig, perfVerdict } from '../../harness/perf';
 import { loadDeliveryMap, writeDeliveryMap } from './map-loader';
 import { mapContentFingerprint } from './fingerprint';
@@ -163,13 +164,18 @@ export async function writeMatrixDeliverables(
   paths: MatrixTargetPaths,
   model: MatrixModel,
   format: MatrixFormat = 'xlsx',
-): Promise<{ csvPath?: string; xlsxPath?: string }> {
-  const out: { csvPath?: string; xlsxPath?: string } = {};
+): Promise<{ csvPath?: string; xlsxPath?: string; manualCarry?: ManualCarryReport }> {
+  const out: { csvPath?: string; xlsxPath?: string; manualCarry?: ManualCarryReport } = {};
+  const xlsx = format === 'xlsx' || format === 'both';
+  // Read the workbook about to be overwritten BEFORE writing anything, so the tester's Manual
+  // results survive (#756) and a refusal leaves no half-written target behind.
+  const prior = xlsx ? await readPriorManualResults(deliverableXlsxPath(paths.cwd, paths.unit)) : null;
   if (format === 'csv' || format === 'both') {
     out.csvPath = writeCsv(paths.cwd, paths.unit, renderMatrixCsv(model));
   }
-  if (format === 'xlsx' || format === 'both') {
+  if (xlsx) {
     const wb = renderMatrixXlsx(model, getPackageVersion());
+    out.manualCarry = carryManualResults(wb, model, prior);
     out.xlsxPath = await writeXlsx(paths.cwd, paths.unit, wb);
   }
   return out;

package/src/exporters/matrix/wording.ts

@@ -40,8 +40,25 @@ export function runtimeVarsOf(stepTexts: string[], tags: string[]): Set<string>
 }
 
 // `[Email] field` → `Email field` (the visible label + its element type).
+// Only the DSL's own refs: a `"quoted literal"` and a `{{token}}` are data, so their
+// brackets stay (#772) — `"[DRAFT] report"`, `{{q.rows[0].id}}`. Callers render BEFORE
+// substituting values, so a value's brackets (`^[A-Za-z]{3}`) never reach this.
+// A literal opens only where a word does not end: in free text (manual procedures) `5"`
+// is an inch mark, and two of them must not shield the `[Ref]` between them.
 function deRef(text: string): string {
-  return text.replace(/\[([^\]]+)\]/g, '$1');
+  return text.replace(/(?<![\p{L}\p{N}])"[^"]*"|\{\{[^}]*\}\}|\[([^\]]+)\]/gu, (m, ref?: string) => ref ?? m);
+}
+
+/**
+ * Finish a cell rendered with `{{tokens}}` still in it, once the values are substituted
+ * (#772: render first, substitute after, so deRef never sees a value). Keeps what
+ * `sentence()` did when values went in first: a leading value is capitalised, and a
+ * value that already ends a sentence does not gain a second mark (`value..`).
+ */
+export function afterSubstitution(text: string): string {
+  if (!text) return text;
+  const s = text.charAt(0).toUpperCase() + text.slice(1);
+  return s.replace(/([.!?…"])\.$/, '$1');
 }
 
 function sentence(text: string): string {
@@ -115,7 +132,15 @@ export function renderExpected(raw: string): string {
   if (RUNTIME_CAPTURE.test(raw) && /\bas\s+\{\{/.test(raw)) return renderAction(raw);
   let s = raw.trim().replace(/^(User|The user)\s+/i, '');
 
+  // `table match data:` rows (folded in by feature-parser, #771) are the EXPECTED VALUES —
+  // `[E2E-01] Q1` is data, not a ref — so only the table's own ref is de-ref'd (#772).
+  const md = s.match(/^sees? \[([^\]]+)\]\s*table match(?:es)? data: (.+)$/i);
+  if (md) return sentence(`The ${md[1]} table shows these rows: ${md[2]}`);
+
   const rules: Array<[RegExp, (m: RegExpMatchArray) => string]> = [
+    // tab order: (#771) row 1 is the focused origin, each later row is one Tab press —
+    // its cells ARE refs, so they are de-ref'd like any step's.
+    [/^sees? tab order: (.+)$/i, (m) => `Pressing Tab moves focus in this order: ${m[1]}`],
     // expect A is (not) B — comparing two captured values (order matters: "is not" first)
     [/^expects? (.+?) is not (.+)$/i, (m) => `${m[1]} differs from ${m[2]}`],
     [/^expects? (.+?) is (.+)$/i, (m) => `${m[1]} equals ${m[2]}`],

package/src/exporters/xlsx-exporter.ts

@@ -113,15 +113,20 @@ export function buildApiDetailRows(
  * used by the multi-locale delivery aggregator. Pass `null` / empty string
  * to force the base (no suffix) variant.
  */
+/** Where `writeXlsx` puts a unit's workbook — shared so a reader targets the identical file. */
+export function deliverableXlsxPath(cwd: string, screen: string, locale?: string | null): string {
+  return path.join(cwd, 'qa', 'deliverables', `${deliverableBasename(screen, locale)}.xlsx`);
+}
+
 export async function writeXlsx(
   cwd: string,
   screen: string,
   wb: ExcelJS.Workbook,
   locale?: string | null,
 ): Promise<string> {
-  const outDir = path.join(cwd, 'qa', 'deliverables');
+  const outPath = deliverableXlsxPath(cwd, screen, locale);
+  const outDir = path.dirname(outPath);
   if (!fs.existsSync(outDir)) fs.mkdirSync(outDir, { recursive: true });
-  const outPath = path.join(outDir, `${deliverableBasename(screen, locale)}.xlsx`);
   const buffer = await wb.xlsx.writeBuffer();
   const locked = await lockEmbeddedImages(Buffer.from(buffer as ArrayBuffer));
   fs.writeFileSync(outPath, locked);

package/src/generators/test-generator/adapters/adapter-interface.ts

@@ -42,7 +42,7 @@ export interface TestFileData {
   runtimeData?: boolean; // --runtime-data flag: testData.get() instead of hardcoded values
   screenName?: string; // Screen name for TestDataLoader.load()
   featureFileName?: string; // Feature file name for TestDataLoader.load()
-  isParallel?: boolean; // @parallel tag: fresh page per test (opt-out from serial default)
+  isParallel?: boolean; // !@serial: fresh page per test. Parallel is the default; @parallel only names it
   flowMode?: boolean;   // flow: cross-screen → longer per-test timeout (bug #243)
   platform?: string;    // mobile @platform:* value (mobile|android|ios) → `// sungen:platform=` marker for wdio per-OS routing
   cleanup?: { overlay?: boolean; forms?: boolean; scroll?: boolean; storage?: boolean };
@@ -65,7 +65,7 @@ export interface ScenarioData {
   scenarioName: string;
   steps: Array<{ comment?: string; code: string }>;
   authRole?: string; // Auth role for storage state
-  isParallel?: boolean; // @parallel: use fresh page from fixture
+  isParallel?: boolean; // !@serial: use fresh page from fixture
   tags?: string; // Pass-through tags for Playwright { tag: [...] }, e.g. "'@smoke', '@high'"
   casesDataset?: string; // @cases:<dataset> — emit one test() per row of the runtime dataset
   resetTier?: string; // Mobile (appium): scenario-level `@reset:` override; raises (never lowers) the feature tier for this scenario only

package/src/generators/test-generator/adapters/appium/templates/steps/actions/reinstall-app-action.hbs

@@ -2,8 +2,8 @@
 // Persistence oracles (dismissals, pins) hinge on what survives a reinstall.
 await (async () => {
   const __pkg = __resolveAppId();
-  const __caps = (driver.requestedCapabilities || {}) as Record<string, string>;
-  const __appPath = __caps['appium:app'] || __caps['app'];
+  // Same reader the reset tiers use — one place decides what "the session has a build file" means.
+  const __appPath = __appBuildPath();
   if (!__appPath) {
     throw new Error('reinstall the app: the session must install from a build file — set APP_APK (Android) / IOS_APP (iOS) so the appium:app capability is present.');
   }

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/all-contain-assertion.hbs

@@ -2,8 +2,7 @@
       as contain-text-assertion), substring check on every match — no CSS filter() combinator
       exists on Appium, so this loop replaces it. --}}
 {
-  const __items_{{stepCounter}} = await $$({{> appium-selector-expr}});
-  if (__items_{{stepCounter}}.length === 0) throw new Error('[sungen] Expected at least one [{{escapeQuotes selectorRef}}]');
+  const __items_{{stepCounter}} = {{> await-elements mustExist=true}};
   const __expected_{{stepCounter}} = String('{{escapeQuotes expectedText}}').trim();
   for (const __el_{{stepCounter}} of __items_{{stepCounter}}) {
     const __sources_{{stepCounter}} = driver.isIOS

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/all-contain-element.hbs

@@ -1,12 +1,15 @@
 {{!-- Q2 all-card structural assertion (mobile): every container element must hold the child.
       WebdriverIO's $$() returns a live element ARRAY, not a lazy Locator — there is no `.nth()`
       (that is Playwright's API). Enumerate by index and chain off the array element itself via
-      `.$()` (WDIO findElementFromElement). --}}
+      `.$()` (WDIO findElementFromElement).
+
+      `appium-selector-expr`, not a hand-quoted `appium-selector`: the expr partial emits its own
+      quotes, and it is the only form that can carry a per-OS `android:`/`ios:` entry (it renders
+      that as a runtime ternary). The raw partial silently emitted the Android side alone, so an
+      iOS run drove Android selectors; wrapping the expr output in quotes of our own instead
+      produces `$$(''~card'')`, a syntax error that costs the WHOLE .spec.ts, not just this step. --}}
 {
-  const {{containerVar}} = await $$('{{> appium-selector}}');
-  if ({{containerVar}}.length === 0) {
-    throw new Error('[sungen] Expected at least one [{{escapeQuotes selectorRef}}]');
-  }
+  const {{containerVar}} = {{> await-elements mustExist=true}};
   for (let {{containerIndexVar}} = 0; {{containerIndexVar}} < {{containerVar}}.length; {{containerIndexVar}}++) {
     await expect({{#with child}}{{> locator parentLocator=(add (add (add ../containerVar "[") ../containerIndexVar) "]")}}{{/with}}).toBeDisplayed();
   }

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/count-assertion.hbs

@@ -1 +1,5 @@
-await expect($$('{{> appium-selector}}')).toBeElementsArrayOfSize({{expectedCount}});
+{{!-- `appium-selector-expr` emits its own quotes and is the only form that can carry a per-OS
+      `android:`/`ios:` entry (rendered as a runtime ternary). The raw partial silently emitted the
+      Android side alone; quoting the expr output by hand instead produces `$$(''~card'')`, a syntax
+      error that costs the whole .spec.ts. --}}
+await expect($$({{> appium-selector-expr}})).toBeElementsArrayOfSize({{expectedCount}});

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/disabled-with-filter-assertion.hbs

@@ -13,7 +13,7 @@
       has no such exemption — absent is not disabled.) --}}
 {
   const __expected = String('{{escapeQuotes dataValue}}').trim();
-  const __items = await $$({{> appium-selector-expr}});
+  const __items = {{> await-elements mustExist=true}};
   let __found = false;
   for (const __el of __items) {
     const __sources = driver.isIOS

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/disabled-with-role-variable-assertion.hbs

@@ -5,7 +5,7 @@
 {{#if name}}
 {
   const __expected = String('{{escapeQuotes dataValue}}').trim();
-  const __items = await $$('~{{escapeQuotes name}}');
+  const __items = {{> await-elements useRoleName=true mustExist=true}};
   let __found = false;
   for (const __el of __items) {
     const __s = driver.isIOS ? [await __el.getAttribute('label'), await __el.getAttribute('value')] : [await __el.getText(), await __el.getAttribute('content-desc')];

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/hidden-with-filter-assertion.hbs

@@ -3,7 +3,7 @@
       is hand-rolled. Assert none of the matching elements is displayed. --}}
 {
   const __expected = String('{{escapeQuotes dataValue}}').trim();
-  const __items = await $$({{> appium-selector-expr}});
+  const __items = {{> await-elements}};
   for (const __el of __items) {
     const __sources = driver.isIOS
       ? [await __el.getAttribute('label'), await __el.getAttribute('value')]

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/hidden-with-role-variable-assertion.hbs

@@ -6,7 +6,7 @@
 {{#if name}}
 {
   const __expected = String('{{escapeQuotes dataValue}}').trim();
-  const __items = await $$('~{{escapeQuotes name}}');
+  const __items = {{> await-elements useRoleName=true}};
   for (const __el of __items) {
     const __s = driver.isIOS ? [await __el.getAttribute('label'), await __el.getAttribute('value')] : [await __el.getText(), await __el.getAttribute('content-desc')];
     if (String(__s.find(s => s && String(s).trim() !== '') ?? '').trim() === __expected) await expect(__el).not.toBeDisplayed();

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/label-value-assertion.hbs

@@ -9,12 +9,18 @@
       Flutter screen; UiSelector has no OR, hence the xpath. iOS scatters it across
       label/value, which the predicate already ORs.
 
+      SCOPE (#747): an `in [Parent] <type>` clause chains this under the parent element. The android
+      xpath must go RELATIVE (`.//`) to do so — a child xpath beginning with `//` is ABSOLUTE in
+      Appium even when chained, so keeping it would emit code that LOOKS scoped and searches the whole
+      screen, which is the same silent widening the scope clause exists to prevent. The iOS predicate
+      carries no such trap and chains as written.
+
       The expected value must stay a standalone quoted literal so the runtime-data transform
       can swap it for testData.get(...). --}}
 {
   const __expected = String('{{escapeQuotes dataValue}}').trim();
   const __sel = driver.isIOS
     ? `-ios predicate string:label == "${__expected}" OR value == "${__expected}"`
-    : `//*[@text="${__expected}" or @content-desc="${__expected}"]`;
-  await expect($(__sel)).toBeDisplayed();
+    : `{{#if parentLocator}}.{{/if}}//*[@text="${__expected}" or @content-desc="${__expected}"]`;
+  await expect({{#if parentLocator}}{{parentLocator}}.$(__sel){{else}}$(__sel){{/if}}).toBeDisplayed();
 }

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/list-item-count-assertion.hbs

@@ -1,2 +1,5 @@
-{{!-- Count the elements matching the list locator (mobile has no role="listitem"). --}}
-await expect($$('{{> appium-selector}}')).toBeElementsArrayOfSize({{expectedCount}});
+{{!-- Count the elements matching the list locator (mobile has no role="listitem").
+      `appium-selector-expr` emits its own quotes and is the only form that can carry a per-OS
+      `android:`/`ios:` entry; quoting it by hand produced `$$(''~card'')`, a syntax error that
+      takes the whole .spec.ts down. --}}
+await expect($$({{> appium-selector-expr}})).toBeElementsArrayOfSize({{expectedCount}});

package/src/generators/test-generator/adapters/appium/templates/steps/assertions/state-with-filter-assertion.hbs

@@ -7,7 +7,7 @@
       house style. --}}
 {
   const __expected = String('{{escapeQuotes dataValue}}').trim();
-  const __items = await $$({{> appium-selector-expr}});
+  const __items = {{> await-elements mustExist=true}};
   let __el: WebdriverIO.Element | undefined;
   for (const __c of __items) {
     const __s = driver.isIOS ? [await __c.getAttribute('label'), await __c.getAttribute('value')] : [await __c.getText(), await __c.getAttribute('content-desc')];