@sun-asterisk/sungen 2.6.12 → 2.6.15

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (107) hide show
  1. package/dist/cli/commands/delivery.d.ts.map +1 -1
  2. package/dist/cli/commands/delivery.js +215 -65
  3. package/dist/cli/commands/delivery.js.map +1 -1
  4. package/dist/cli/index.js +1 -1
  5. package/dist/dashboard/snapshot-builder.d.ts.map +1 -1
  6. package/dist/dashboard/snapshot-builder.js +173 -32
  7. package/dist/dashboard/snapshot-builder.js.map +1 -1
  8. package/dist/dashboard/templates/index.html +84 -84
  9. package/dist/dashboard/types.d.ts +35 -0
  10. package/dist/dashboard/types.d.ts.map +1 -1
  11. package/dist/exporters/csv-exporter.d.ts +24 -3
  12. package/dist/exporters/csv-exporter.d.ts.map +1 -1
  13. package/dist/exporters/csv-exporter.js +28 -7
  14. package/dist/exporters/csv-exporter.js.map +1 -1
  15. package/dist/exporters/json-exporter.d.ts +15 -0
  16. package/dist/exporters/json-exporter.d.ts.map +1 -1
  17. package/dist/exporters/json-exporter.js +7 -2
  18. package/dist/exporters/json-exporter.js.map +1 -1
  19. package/dist/exporters/playwright-report-parser.d.ts +7 -0
  20. package/dist/exporters/playwright-report-parser.d.ts.map +1 -1
  21. package/dist/exporters/playwright-report-parser.js +20 -0
  22. package/dist/exporters/playwright-report-parser.js.map +1 -1
  23. package/dist/exporters/selector-key-resolver.d.ts +55 -0
  24. package/dist/exporters/selector-key-resolver.d.ts.map +1 -0
  25. package/dist/exporters/selector-key-resolver.js +208 -0
  26. package/dist/exporters/selector-key-resolver.js.map +1 -0
  27. package/dist/exporters/test-data-resolver.d.ts +15 -2
  28. package/dist/exporters/test-data-resolver.d.ts.map +1 -1
  29. package/dist/exporters/test-data-resolver.js +61 -8
  30. package/dist/exporters/test-data-resolver.js.map +1 -1
  31. package/dist/exporters/types.d.ts +1 -0
  32. package/dist/exporters/types.d.ts.map +1 -1
  33. package/dist/exporters/xlsx-exporter.d.ts +28 -3
  34. package/dist/exporters/xlsx-exporter.d.ts.map +1 -1
  35. package/dist/exporters/xlsx-exporter.js +34 -6
  36. package/dist/exporters/xlsx-exporter.js.map +1 -1
  37. package/dist/generators/test-generator/code-generator.d.ts.map +1 -1
  38. package/dist/generators/test-generator/code-generator.js +13 -0
  39. package/dist/generators/test-generator/code-generator.js.map +1 -1
  40. package/dist/orchestrator/ai-rules-updater.d.ts.map +1 -1
  41. package/dist/orchestrator/ai-rules-updater.js +4 -0
  42. package/dist/orchestrator/ai-rules-updater.js.map +1 -1
  43. package/dist/orchestrator/templates/ai-instructions/claude-cmd-add-screen.md +48 -14
  44. package/dist/orchestrator/templates/ai-instructions/claude-cmd-dashboard.md +4 -1
  45. package/dist/orchestrator/templates/ai-instructions/claude-cmd-delivery.md +22 -11
  46. package/dist/orchestrator/templates/ai-instructions/claude-cmd-locale.md +71 -0
  47. package/dist/orchestrator/templates/ai-instructions/claude-cmd-review.md +23 -8
  48. package/dist/orchestrator/templates/ai-instructions/claude-cmd-run-test.md +45 -6
  49. package/dist/orchestrator/templates/ai-instructions/claude-config.md +4 -1
  50. package/dist/orchestrator/templates/ai-instructions/claude-skill-locale.md +316 -0
  51. package/dist/orchestrator/templates/ai-instructions/copilot-cmd-add-screen.md +50 -13
  52. package/dist/orchestrator/templates/ai-instructions/copilot-cmd-dashboard.md +4 -1
  53. package/dist/orchestrator/templates/ai-instructions/copilot-cmd-delivery.md +20 -9
  54. package/dist/orchestrator/templates/ai-instructions/copilot-cmd-locale.md +70 -0
  55. package/dist/orchestrator/templates/ai-instructions/copilot-cmd-review.md +23 -8
  56. package/dist/orchestrator/templates/ai-instructions/copilot-cmd-run-test.md +44 -6
  57. package/dist/orchestrator/templates/ai-instructions/copilot-config.md +4 -1
  58. package/dist/orchestrator/templates/ai-instructions/github-skill-sungen-locale.md +291 -0
  59. package/dist/orchestrator/templates/playwright.config.ts +25 -8
  60. package/dist/orchestrator/templates/specs-base.ts +9 -0
  61. package/dist/orchestrator/templates/specs-locale-fixture.ts +105 -0
  62. package/package.json +1 -1
  63. package/src/cli/commands/delivery.ts +256 -65
  64. package/src/cli/index.ts +1 -1
  65. package/src/dashboard/snapshot-builder.ts +207 -32
  66. package/src/dashboard/templates/index.html +84 -84
  67. package/src/dashboard/types.ts +40 -3
  68. package/src/exporters/csv-exporter.ts +36 -7
  69. package/src/exporters/json-exporter.ts +22 -2
  70. package/src/exporters/playwright-report-parser.ts +20 -0
  71. package/src/exporters/selector-key-resolver.ts +190 -0
  72. package/src/exporters/test-data-resolver.ts +65 -7
  73. package/src/exporters/types.ts +1 -0
  74. package/src/exporters/xlsx-exporter.ts +61 -7
  75. package/src/generators/test-generator/code-generator.ts +14 -0
  76. package/src/orchestrator/ai-rules-updater.ts +4 -0
  77. package/src/orchestrator/templates/ai-instructions/claude-cmd-add-screen.md +48 -14
  78. package/src/orchestrator/templates/ai-instructions/claude-cmd-dashboard.md +4 -1
  79. package/src/orchestrator/templates/ai-instructions/claude-cmd-delivery.md +22 -11
  80. package/src/orchestrator/templates/ai-instructions/claude-cmd-locale.md +71 -0
  81. package/src/orchestrator/templates/ai-instructions/claude-cmd-review.md +23 -8
  82. package/src/orchestrator/templates/ai-instructions/claude-cmd-run-test.md +45 -6
  83. package/src/orchestrator/templates/ai-instructions/claude-config.md +4 -1
  84. package/src/orchestrator/templates/ai-instructions/claude-skill-locale.md +316 -0
  85. package/src/orchestrator/templates/ai-instructions/copilot-cmd-add-screen.md +50 -13
  86. package/src/orchestrator/templates/ai-instructions/copilot-cmd-dashboard.md +4 -1
  87. package/src/orchestrator/templates/ai-instructions/copilot-cmd-delivery.md +20 -9
  88. package/src/orchestrator/templates/ai-instructions/copilot-cmd-locale.md +70 -0
  89. package/src/orchestrator/templates/ai-instructions/copilot-cmd-review.md +23 -8
  90. package/src/orchestrator/templates/ai-instructions/copilot-cmd-run-test.md +44 -6
  91. package/src/orchestrator/templates/ai-instructions/copilot-config.md +4 -1
  92. package/src/orchestrator/templates/ai-instructions/github-skill-sungen-locale.md +291 -0
  93. package/src/orchestrator/templates/playwright.config.ts +25 -8
  94. package/src/orchestrator/templates/specs-base.ts +9 -0
  95. package/src/orchestrator/templates/specs-locale-fixture.ts +105 -0
  96. package/dist/orchestrator/templates/playwright.config.d.ts +0 -10
  97. package/dist/orchestrator/templates/playwright.config.d.ts.map +0 -1
  98. package/dist/orchestrator/templates/playwright.config.js +0 -104
  99. package/dist/orchestrator/templates/playwright.config.js.map +0 -1
  100. package/dist/orchestrator/templates/specs-base.d.ts +0 -14
  101. package/dist/orchestrator/templates/specs-base.d.ts.map +0 -1
  102. package/dist/orchestrator/templates/specs-base.js +0 -77
  103. package/dist/orchestrator/templates/specs-base.js.map +0 -1
  104. package/dist/orchestrator/templates/specs-test-data.d.ts +0 -16
  105. package/dist/orchestrator/templates/specs-test-data.d.ts.map +0 -1
  106. package/dist/orchestrator/templates/specs-test-data.js +0 -151
  107. package/dist/orchestrator/templates/specs-test-data.js.map +0 -1
@@ -0,0 +1,316 @@
1
+ ---
2
+ name: sungen-locale
3
+ description: 'Bootstrap i18n for a screen/flow — audit hardcoded selector text, detect locale-switch mechanism via live Playwright, generate test-data overlay file. Auto-loaded by /sungen:locale command.'
4
+ user-invocable: false
5
+ ---
6
+
7
+ ## Goal
8
+
9
+ Take a screen/flow whose `selectors/*.yaml` and `.feature` files were authored against the default locale (usually Vietnamese) and prepare it to run against a second locale. Output:
10
+
11
+ 1. `selectors/<feature>.yaml` — hardcoded `name`/`value` replaced with `{{var}}`
12
+ 2. `test-data/<feature>.yaml` — base locale, complete with all new keys
13
+ 3. `test-data/<feature>.<locale>.yaml` — overlay with only the keys that change
14
+ 4. (Optional) `selectors/<feature>.yaml` Pages block updated when locale uses URL prefix or query param
15
+
16
+ After this skill finishes, `sungen run-test <name> --env <locale>` Just Works.
17
+
18
+ ## Run mode — Live (preferred) vs Offline (fallback)
19
+
20
+ Pick mode **once at start**, based on whether MCP Playwright can reach the page.
21
+
22
+ ```
23
+ Try: browser_navigate(baseURL)
24
+ → succeeds + page renders content → LIVE MODE (all 6 phases)
25
+ → fails (auth blocked, network down, app broken) → OFFLINE MODE
26
+ (audit + scaffold template + ask user to fill, skip detection phases)
27
+ ```
28
+
29
+ **Live mode is the value-add** — it auto-detects locale switch mechanism and auto-fills translations. Offline mode just makes the file structure right; user fills in text manually.
30
+
31
+ Announce which mode is being used before Phase 1.
32
+
33
+ ## Phase 1 — Audit selectors (always, no MCP)
34
+
35
+ For each `.feature` file under the screen, read the matching `selectors/<feature>.yaml`. List every entry whose `name` or `value` field contains literal text WITHOUT `{{…}}` AND is not a CSS/href selector.
36
+
37
+ Classify each candidate:
38
+ - **`name` field of `role`-type selector** → very likely locale-dependent
39
+ - **`value` field of `text`-type selector** → very likely locale-dependent
40
+ - **`value` of `locator`-type selector** that contains `:has-text("…")` → check if the text is in target language
41
+ - **`value` of `page`-type selector** → URL — handled separately in Phase 3
42
+ - **CSS / href / attribute selectors** (e.g. `a[href="/awards"]`) → skip, locale-invariant
43
+
44
+ Print the candidate list as a table:
45
+
46
+ ```
47
+ selector key | field | hardcoded value | classification
48
+ -------------------+-------+---------------------------+------------------
49
+ nav about | name | Giới thiệu SAA 2025 | locale-dependent
50
+ nav awards | name | Thông tin giải thưởng | locale-dependent
51
+ event date | name | 26/12/2025 | maybe (date format)
52
+ nav kudos | name | Sun* Kudos | brand — skip
53
+ ```
54
+
55
+ If there are zero candidates and no `{{var}}` either, the screen has no localizable text → tell user and stop.
56
+
57
+ ## Phase 2 — Capture base locale (LIVE only)
58
+
59
+ 1. Read `playwright.config.ts` for `baseURL`. Read `Path:` from `.feature` for the entry-point path.
60
+ 2. If the screen has `@auth:<role>` tags, load `specs/.auth/<role>.json` via `browser_set_storage_state` first.
61
+ 3. `browser_navigate(baseURL + entryPath)` then `browser_wait_for` something stable.
62
+ 4. Capture:
63
+ - `browser_snapshot()` — DOM accessibility tree
64
+ - `browser_evaluate(() => location.href)` — full URL
65
+ - `browser_evaluate(() => ({ localStorage: {...localStorage}, cookies: document.cookie }))` — storage state hash
66
+ 5. For each candidate from Phase 1: verify the hardcoded text actually appears on the page (string contains check against snapshot text). Drop candidates that don't appear (probably stale selectors or false positives).
67
+
68
+ Save state to memory as `baseLocale = { url, snapshot, storage }`.
69
+
70
+ If page redirects to `/login` (auth blocker) → stop. Print: *"Auth blocked — cannot capture live page. Fall back to OFFLINE mode by re-running once auth works, or pick `Offline-only` next time."*
71
+
72
+ ## Phase 3 — Switch locale (LIVE only) — detect mechanism + storage delta
73
+
74
+ Goal: identify (a) HOW to switch the app to the target locale, and (b) WHAT app-side storage state ends up holding the locale preference so a fresh BrowserContext can be primed identically without driving the UI.
75
+
76
+ Before triggering the switch, capture full storage baseline:
77
+
78
+ ```js
79
+ const before = await browser_evaluate(() => ({
80
+ sessionStorage: { ...sessionStorage },
81
+ localStorage: { ...localStorage },
82
+ cookies: document.cookie,
83
+ url: location.href,
84
+ }));
85
+ ```
86
+
87
+ Then try mechanisms in order. First one that produces visibly different text wins. For EACH attempt, capture `after` state and diff against `before`.
88
+
89
+ **3a. URL prefix**
90
+ - `browser_navigate(baseURL + '/' + locale + entryPath)` (e.g. `https://saa-2025.../en/`)
91
+ - Wait, snapshot
92
+ - Compare text content with baseLocale snapshot for a known-changed element
93
+ - If text differs and page didn't 404 → **URL prefix mechanism**. Save `localePrefix = '/' + locale`.
94
+
95
+ **3b. Query param** (only if 3a failed)
96
+ - `browser_navigate(baseURL + entryPath + '?lang=' + locale)` (also try `?locale=`, `?lng=`, `?l=`, `?language=`)
97
+ - Same diff check
98
+ - If text differs → **Query param mechanism**. Save `localeQuery = '?lang=' + locale` (or whichever variant worked).
99
+
100
+ **3c. Language switcher UI** (only if 3a + 3b failed)
101
+ - Look in base-locale snapshot for buttons/links matching: `'Select language'`, `'Language'`, `'言語'`, `'Ngôn ngữ'`, role=combobox
102
+ - If found, ask user: *"Detected possible language switcher: [X]. Click it and proceed?"*
103
+ - On confirm: `browser_click` the switcher, then `browser_click` the locale option
104
+ - Verify text changed
105
+ - If yes → **UI switcher mechanism**. Save selector + option details.
106
+
107
+ **3d. None detected**
108
+ - AskUserQuestion: *"Couldn't auto-detect locale switching. Either (a) demo it for me in browser then I'll snapshot, (b) provide locale URL manually, (c) skip — assume URL prefix `/<locale>`."*
109
+
110
+ ### Phase 3.5 — Storage diff (always run after Phase 3 succeeds)
111
+
112
+ After locale text confirmed switched, capture `after` state and diff:
113
+
114
+ ```js
115
+ const after = await browser_evaluate(() => ({
116
+ sessionStorage: { ...sessionStorage },
117
+ localStorage: { ...localStorage },
118
+ cookies: document.cookie,
119
+ url: location.href,
120
+ }));
121
+
122
+ // Diff each storage area:
123
+ const sessionDiff = diffEntries(before.sessionStorage, after.sessionStorage);
124
+ const localDiff = diffEntries(before.localStorage, after.localStorage);
125
+ const cookieDiff = diffCookies(before.cookies, after.cookies);
126
+ ```
127
+
128
+ **Filter noise** — only keep entries where:
129
+ - Key name contains `lang|locale|language|i18n|intl` (case-insensitive), OR
130
+ - Value matches a locale code pattern: `^[a-z]{2}(-[A-Z]{2})?$` or matches the target locale code exactly
131
+
132
+ Drop known noise:
133
+ - Auth tokens: `sb-*`, `*-token`, `*-jwt`, `*-session-id`
134
+ - Analytics: `_ga*`, `_gid`, `_fbp`
135
+ - App state: `csrf*`, `last-*`, `visit-*`
136
+
137
+ **Auto-confidence scoring** per remaining entry:
138
+ - High confidence: key name contains locale-related word AND value is a locale code matching target → KEEP, no user prompt
139
+ - Medium: only one signal matches → present to user for confirmation
140
+ - Low: neither matches but key changed → present to user, default to skip
141
+
142
+ ### Phase 3.6 — Verification (always run after Phase 3.5)
143
+
144
+ For each high/medium-confidence storage entry, verify by replaying in a FRESH context:
145
+
146
+ ```js
147
+ // 1. Capture current page state (have JWT in memory) — note: can't replay JWT separately
148
+ // 2. Open new browser_navigate to baseURL but pre-set the detected key via addInitScript
149
+ // 3. Snapshot new page and confirm a known target-locale string appears
150
+
151
+ // Pseudo-code — real impl uses Playwright MCP `browser_evaluate` with init pattern
152
+ ```
153
+
154
+ Actually since MCP browser sessions don't expose `addInitScript` directly, use a softer verification:
155
+ - Manually set the candidate key via `browser_evaluate(() => sessionStorage.setItem('key', 'value'))`
156
+ - Hard reload the page: `browser_navigate(baseURL)` to force re-init
157
+ - Snapshot, look for known target-locale text
158
+ - Caveat: hard reload kills any in-memory JWT — auth blocker amplifies failure surface. Skip verification if the screen has `@auth:*` tags and the staging app has known JWT-persistence issues.
159
+
160
+ If verification fails / can't run → drop confidence by one tier, ask user.
161
+
162
+ Save mechanism + verified storage delta to memory for use in Phase 6.
163
+
164
+ ## Phase 4 — Diff base ↔ target (LIVE only)
165
+
166
+ For each candidate from Phase 1 that survived Phase 2:
167
+ - Find the SAME element in the target-locale snapshot (match by `role`+position, by `aria-label` if available, by neighbor structure)
168
+ - Extract its text → `targetText`
169
+ - Pair: `(selectorKey, hardcoded baseText, observed targetText)`
170
+
171
+ If matching fails for a candidate → mark as "needs manual" — flag for user input rather than skip.
172
+
173
+ Result: list of triples `{ selectorKey, baseText, targetText, confidence }`.
174
+
175
+ ## Phase 5 — Confirm + edit (always)
176
+
177
+ Present the proposal table:
178
+
179
+ ```
180
+ selector key | base text | target text | proposed var | apply?
181
+ -------------------+--------------------------+----------------------+------------------+-------
182
+ nav about | Giới thiệu SAA 2025 | About SAA 2025 | nav_about | [✓]
183
+ nav awards | Thông tin giải thưởng | Awards Info | nav_awards | [✓]
184
+ event location | Au Co Arts Centre, Hanoi | Au Co Arts Centre… | event_location | (already has {{}})
185
+ nav kudos | Sun* Kudos | Sun* Kudos | — | [skip — same]
186
+ event date | 26/12/2025 | 26/12/2025 | — | [skip — same]
187
+ ```
188
+
189
+ Propose **var names** by snake_casing the selector key. Avoid collisions with existing test-data keys.
190
+
191
+ Auto-skip rows where `baseText === targetText` (brand names, dates that don't change between locales).
192
+
193
+ Ask user via AskUserQuestion: *"Review the table above. Confirm to apply / edit individual rows / re-run capture / cancel."*
194
+
195
+ If user wants to edit a row → fall through to a per-row prompt asking for `var name` or `targetText` correction.
196
+
197
+ In OFFLINE mode this phase is the same table but `target text` column is blank — user fills via subsequent prompts or by editing the overlay file after the skill finishes.
198
+
199
+ ## Phase 6 — Apply changes (always, after confirmation)
200
+
201
+ For each confirmed row:
202
+
203
+ **6a. Update `selectors/<feature>.yaml`**
204
+
205
+ Replace `name: '<baseText>'` with `name: '{{<varName>}}'`. Preserve quoting style.
206
+
207
+ **6b. Update `test-data/<feature>.yaml`** (base locale, complete dictionary)
208
+
209
+ Append new keys at the end, grouped under a `# === i18n: <screen> ===` comment. Example:
210
+
211
+ ```yaml
212
+ # === i18n: home ===
213
+ nav_about: 'Giới thiệu SAA 2025'
214
+ nav_awards: 'Thông tin giải thưởng'
215
+ ```
216
+
217
+ **6c. Create `test-data/<feature>.<locale>.yaml`** (overlay, only diffs)
218
+
219
+ ```yaml
220
+ # home — <locale> overlay. Only keys that change vs base.
221
+ # Run with: SUNGEN_ENV=<locale> npx playwright test ...
222
+
223
+ nav_about: 'About SAA 2025'
224
+ nav_awards: 'Awards Info'
225
+ ```
226
+
227
+ **6d. (URL/query mechanism only) Update Pages selectors**
228
+
229
+ If Phase 3 detected URL prefix:
230
+
231
+ ```yaml
232
+ # selectors/<feature>.yaml — Pages block becomes locale-aware
233
+ home:
234
+ type: 'page'
235
+ value: '{{base_path}}/'
236
+ awards:
237
+ type: 'page'
238
+ value: '{{base_path}}/awards'
239
+ ```
240
+
241
+ And add to test-data:
242
+ ```yaml
243
+ # test-data/<feature>.yaml (base)
244
+ base_path: ''
245
+
246
+ # test-data/<feature>.<locale>.yaml (overlay)
247
+ base_path: '/en'
248
+ ```
249
+
250
+ If Phase 3 detected query param: similar but with `query_suffix: ''` / `query_suffix: '?lang=en'` appended to each page value.
251
+
252
+ If Phase 3 detected UI switcher: do NOT modify Pages. Instead, write the storage delta from Phase 3.5 into `specs/generated/locale-config.json` (sibling of `specs/generated/base.ts` + `specs/generated/locale-fixture.ts`) (see 6f below).
253
+
254
+ **6f. Storage injection config — `specs/generated/locale-config.json` (sibling of `specs/generated/base.ts` + `specs/generated/locale-fixture.ts`)**
255
+
256
+ Always write `specs/generated/locale-config.json` (sibling of `specs/generated/base.ts` + `specs/generated/locale-fixture.ts`) with the verified storage delta from Phase 3.5/3.6. This file is consumed by `specs/locale-fixture.ts` (auto-generated alongside `specs/base.ts`) — the fixture wraps Playwright's context, calls `addInitScript` to seed sessionStorage / localStorage, and `addCookies` for any cookies, BEFORE the first page navigation. Without this file, `SUNGEN_ENV=<locale>` only swaps test-data overlay — the browser would still boot in base locale.
257
+
258
+ Schema (only include areas that actually changed):
259
+
260
+ ```json
261
+ {
262
+ "$schema": "sungen-locale-config-v1",
263
+ "sessionStorage": {
264
+ "saa-language-preference": "${SUNGEN_ENV}"
265
+ },
266
+ "localStorage": {},
267
+ "cookies": [],
268
+ "notes": "Detected by /sungen:locale on YYYY-MM-DD. App persists locale in sessionStorage; initial trigger uses ?language=<code> query param."
269
+ }
270
+ ```
271
+
272
+ Notes on the schema:
273
+ - Use the literal placeholder `"${SUNGEN_ENV}"` (or `"{{SUNGEN_ENV}}"`) when the stored value equals the locale code itself. The fixture substitutes `process.env.SUNGEN_ENV` at runtime, so the same file works for `en`, `ja`, etc.
274
+ - Use a hardcoded literal (e.g. `"en_US"`) when the stored value is fixed regardless of which locale runs.
275
+ - `cookies[]` entries need either `domain` or `url`. Other fields (`path`, `httpOnly`, `secure`, `sameSite`) are optional and pass through to `context.addCookies()`.
276
+ - Do not commit auth tokens / session IDs into this file even if they showed up in the Phase 3.5 diff — they are noise. The skill's Phase 3.5 filter must drop them; if one slipped through, edit it out before applying.
277
+ - `notes` is free-form, informational; the fixture ignores it.
278
+
279
+ Multi-locale projects: the same `locale-config.json` works for every locale because the value templating uses `${SUNGEN_ENV}`. No per-locale file needed.
280
+
281
+ The file lives at `specs/generated/locale-config.json` (sibling of `specs/generated/base.ts` + `specs/generated/locale-fixture.ts`) (sibling of `specs/base.ts`). If a different output directory is used, mirror the existing `specs/base.ts` location.
282
+
283
+ **6e. Compile**
284
+
285
+ Run `sungen generate --screen <name>` (or `--flow`) and report any compile errors back to the user. The selectors changed so compile must succeed before run-test.
286
+
287
+ ## Phase 7 — Hand off
288
+
289
+ Print summary:
290
+ - N selectors converted to `{{var}}`
291
+ - M base keys added to `test-data/<feature>.yaml`
292
+ - K overlay keys written to `test-data/<feature>.<locale>.yaml`
293
+ - Pages selectors updated: yes/no
294
+ - Locale-switching mechanism: URL prefix `/en` / query `?lang=en` / UI switcher / manual
295
+
296
+ Suggest:
297
+
298
+ ```
299
+ /sungen:run-test <name> --env <locale>
300
+ ```
301
+
302
+ ## Multi-feature screens
303
+
304
+ If the screen has multiple `.feature` files (e.g. `home.feature` + `home-modal.feature`), repeat Phase 1 → Phase 6 for each feature file with its own selectors + test-data pair. Phase 2 + 3 (live capture + locale switch detection) run **once per screen** — the mechanism is the same. Phase 4 (text diff) runs per feature because each has its own scope of UI.
305
+
306
+ ## What NOT to do
307
+
308
+ - Do not edit `.feature` files. The i18n shape is already correct there (`{{var}}` was the convention from the start). Only selectors + test-data need surgery.
309
+ - Do not write a separate selectors file per locale (`home.en.yaml`). One selectors file with `{{var}}` works across all locales — that's the whole point.
310
+ - Do not delete keys from the base `test-data/<feature>.yaml`. Always append. Existing tests rely on base values being complete.
311
+ - Do not run tests in this skill. Hand off to `/sungen:run-test` for execution.
312
+ - Do not commit. Hand off to user.
313
+
314
+ ## Memory link
315
+
316
+ Related: [[saa-auth-blocker]] — Live mode will not work on SAA staging while the upstream Supabase `persistSession: false` issue is open. Default to Offline mode on SAA until that ships.
@@ -1,41 +1,59 @@
1
1
  ---
2
2
  name: sungen-add-screen
3
- description: 'Add a new Sungen screen — scaffolds directories, helps fill spec.md, and can auto-capture a live-page screenshot via Playwright MCP'
4
- argument-hint: '[screen-name] [url-path] [--figma <url>]'
3
+ description: 'Add a new Sungen screen or a sub-feature to an existing one — scaffolds directories, helps fill spec.md, and can auto-capture a live-page screenshot via Playwright MCP'
4
+ argument-hint: '[screen-name] [url-path] [--feature <name>] [--figma <url>]'
5
5
  agent: 'agent'
6
6
  tools: [vscode, execute, read, agent, edit, search, web, browser, todo, 'playwright/*']
7
7
  ---
8
8
 
9
9
  **Input**: Screen name and URL path (e.g., `/sungen-add-screen login /login`).
10
10
  Optionally include a Figma URL: `/sungen-add-screen login /login --figma https://www.figma.com/design/...`.
11
+ To add a sub-feature file to an existing screen: `/sungen-add-screen awards --feature modal`.
11
12
 
12
- You are adding a new Sungen screen for test generation.
13
+ You are adding a new Sungen screen for test generation, or extending an existing screen with an additional `.feature` file (sub-feature).
13
14
 
14
15
  ## Parameters
15
16
 
16
17
  - **screen** — ${input:screen:screen name (e.g., login, dashboard)}
17
- - **path** — ${input:path:URL path (e.g., /login, /dashboard)} — optional when --figma is provided
18
- - **--figma \<url\>**Figma share URL (optional)
19
- - **--refresh**bypass Figma cache and re-fetch (optional, use with --figma)
20
- - **--scale \<n\>** PNG export scale factor, default 2 (optional)
21
- - **--hi-res** — export at 4× scale, shorthand for --scale 4 (optional)
18
+ - **path** — ${input:path:URL path (e.g., /login, /dashboard)} — optional when --figma is provided or when adding a sub-feature
19
+ - **`--feature <name>`**sub-feature name to add to an existing screen (e.g., `modal`, `filter`, `create-flow`). Creates `<screen>-<feature>.feature` + matching `selectors/<screen>-<feature>.yaml` + `test-data/<screen>-<feature>.yaml` without touching the screen's other files. Use this when one screen has multiple `.feature` files.
20
+ - **`--figma <url>`** — Figma share URL (optional)
21
+ - **`--refresh`**bypass Figma cache and re-fetch (optional, use with --figma)
22
+ - **`--scale <n>`** PNG export scale factor, default 2 (optional)
23
+ - **`--hi-res`** — export at 4× scale, shorthand for --scale 4 (optional)
24
+
25
+ **Mode detection** — before invoking the CLI, check whether `qa/screens/<screen>/` already exists:
26
+ - Screen does NOT exist → fresh screen creation (need `--path` unless `--figma` provided)
27
+ - Screen exists AND `--feature <name>` provided → sub-feature mode (skip spec.md, only generate the 3 new files)
28
+ - Screen exists AND no `--feature` → ask the user whether they meant to add a sub-feature (offer `--feature <suggested-name>`) or refresh visuals only (with `--figma`)
22
29
 
23
30
  ## Steps
24
31
 
25
- ### 1. Scaffold the screen
32
+ ### 1. Scaffold the screen (or sub-feature)
26
33
 
27
- **Standard path (no --figma):**
34
+ **Standard path (no --figma, no --feature):**
28
35
 
29
36
  Run with #tool:terminal:
30
37
  ```bash
31
38
  sungen add --screen ${input:screen} --path ${input:path}
32
39
  ```
33
40
 
41
+ **Sub-feature mode (`--feature <name>` provided):**
42
+
43
+ Run with #tool:terminal:
44
+ ```bash
45
+ sungen add --screen ${input:screen} --feature <name> [--path ${input:path}]
46
+ # Generates qa/screens/${input:screen}/{features,selectors,test-data}/${input:screen}-<name>.{feature,yaml,yaml}
47
+ # Existing screen files (spec.md, awards.feature, …) are untouched.
48
+ # --path is optional — defaults to /${input:screen} when omitted.
49
+ ```
50
+
34
51
  **Figma branch (when --figma \<url\> is provided):**
35
52
 
36
53
  Run with #tool:terminal:
37
54
  ```bash
38
- sungen add --screen ${input:screen} --figma <figma-url> [--path ${input:path}] [--refresh] [--scale <n>]
55
+ sungen add --screen ${input:screen} --figma <figma-url> [--path ${input:path}] [--feature <name>] [--refresh] [--scale <n>]
56
+ # --feature can be combined with --figma when the new sub-feature has its own Figma frame.
39
57
  ```
40
58
 
41
59
  This CLI command automatically:
@@ -82,13 +100,32 @@ Each capture skill writes outputs into `qa/screens/${input:screen}/requirements/
82
100
 
83
101
  ### 3. Fill spec.md
84
102
 
85
- Ask: *"Fill `spec.md` now? (You can reference the captured visuals)"* offer **1) Yes, fill now (Recommended)** / **2) Skip, fill later**.
103
+ **Skip this step when `--feature` was used** — the screen's existing `spec.md` is reused for all sub-features; only suggest the user append a new section for the sub-feature if useful (e.g. `## Modal Confirm Withdrawal`).
104
+
105
+ For fresh screen creation, ask: *"Fill `spec.md` now? (You can reference the captured visuals)"* — offer **1) Yes, fill now (Recommended)** / **2) Skip, fill later**.
86
106
 
87
107
  If yes → open `qa/screens/${input:screen}/requirements/spec.md` and help the user fill sections, fields, validation rules, business rules, and states. Reference the captured visuals from Step 2 to suggest field names, form elements, and UI states. Especially prompt for the optional **Figma URL** and **Live URL** fields in Overview — those unlock auto-capture without re-asking next run.
88
108
 
89
109
  ### 4. Next steps
90
110
 
91
- Tell the user what was created and offer next steps:
111
+ Tell the user what was created. When `--feature` was used, list the 3 new files explicitly (`features/${input:screen}-<name>.feature`, `selectors/${input:screen}-<name>.yaml`, `test-data/${input:screen}-<name>.yaml`) and remind that `/sungen-create-test` currently operates at the screen level — it will see both the parent feature and the new sub-feature and ask which one to update.
112
+
113
+ Then offer next steps:
92
114
 
93
115
  - **`/sungen-create-test ${input:screen}`** — Create test cases from requirements/designs (Recommended)
94
116
  - **Done for now** — I'll come back later
117
+
118
+ ## CLI Reference
119
+
120
+ ```
121
+ sungen add --screen <name>
122
+ [-p, --path <path>] URL route (e.g., /awards). Required for capture; defaults to /<screen> when omitted.
123
+ [-f, --feature <name>] Add a sub-feature .feature file to an existing screen.
124
+ Output filename = <screen>-<feature>.{feature,yaml,yaml}.
125
+ [-c, --capture] Auto-capture a live screenshot to requirements/ui/ (needs --path).
126
+ [-d, --description <text>] Screen description (used in spec.md stub).
127
+ [--figma <url>] Figma share URL — generates spec_figma.md + ui/*.png.
128
+ [--refresh] Bypass Figma cache (use with --figma).
129
+ [--scale <n>] PNG export scale (default 2).
130
+ [--hi-res] Shorthand for --scale 4.
131
+ ```
@@ -19,8 +19,11 @@ Parse **screens** from `$ARGUMENTS`:
19
19
 
20
20
  ### 1. Invoke the CLI
21
21
 
22
+ Prefer the local `./bin/sungen.js` when it exists (sungen monorepo dev). Fall back to `npx sungen` for downstream projects.
23
+
22
24
  ```bash
23
- npx sungen dashboard <screens>
25
+ # Local-first dispatcher — works in both monorepo and consumer projects:
26
+ [ -x ./bin/sungen.js ] && ./bin/sungen.js dashboard <screens> || npx sungen dashboard <screens>
24
27
  ```
25
28
 
26
29
  - No args → all screens + flows.
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  name: sungen-delivery
3
3
  description: 'Export Gherkin scenarios + Playwright results to CSV test case file for QA delivery.'
4
- argument-hint: "[name...] (omit for all screens and flows)"
4
+ argument-hint: "[name...] [--env <locale>] (omit names for all targets; --env for locale-specific export)"
5
5
  tools: [read, execute, edit, vscode/askQuestions]
6
6
  ---
7
7
 
@@ -11,9 +11,11 @@ You are a **QA Test Delivery Engineer**. Your job is to invoke the deterministic
11
11
 
12
12
  ## Parameters
13
13
 
14
- Parse **names** from `$ARGUMENTS`:
15
- - If empty → CLI will process **all** screens in `qa/screens/` and flows in `qa/flows/`
16
- - If provided pass them through to the CLI (auto-detects screen vs flow per name)
14
+ Parse from `$ARGUMENTS`:
15
+ - **names** zero or more screen/flow names. Empty → CLI processes all targets in `qa/screens/` + `qa/flows/`.
16
+ - **`--env <locale>`** optional. Sets `SUNGEN_ENV=<locale>` for the run so the CLI merges `<name>.<locale>.yaml` over the base test-data and writes `<name>-testcases.<locale>.csv` / `.xlsx`. Accept `--locale <locale>` as an alias.
17
+
18
+ If `--env` is passed but no value follows, ask the user which locale to use.
17
19
 
18
20
  ## Steps
19
21
 
@@ -22,18 +24,22 @@ Parse **names** from `$ARGUMENTS`:
22
24
  Run via Bash (single command, no extra parsing):
23
25
 
24
26
  ```bash
25
- npx sungen delivery <names>
27
+ # No env — local-first dispatcher:
28
+ [ -x ./bin/sungen.js ] && ./bin/sungen.js delivery <names> || npx sungen delivery <names>
29
+
30
+ # Locale-specific:
31
+ [ -x ./bin/sungen.js ] && SUNGEN_ENV=<locale> ./bin/sungen.js delivery <names> || SUNGEN_ENV=<locale> npx sungen delivery <names>
26
32
  ```
27
33
 
28
- - If no args → just run `npx sungen delivery` (exports all screens + flows)
29
- - If args → pass them as positional arguments (auto-detects screen vs flow)
34
+ - If no name args → omit `<names>` (CLI processes all targets).
35
+ - If `--env <locale>` was provided prepend `SUNGEN_ENV=<locale>` to the command. Do NOT pass `--env` to the CLI itself it's not a CLI flag, only a slash-command convenience.
30
36
 
31
37
  The CLI handles:
32
38
  - Scope detection (all screens + flows vs specific names)
33
39
  - Auto-detect: `qa/flows/<name>/` → flow, `qa/screens/<name>/` → screen
34
40
  - Pre-flight source checks with colorful output
35
- - Parsing `.feature`, `.spec.ts`, `test-data.yaml`, `test-results/results.json`
36
- - Generating CSV at `qa/deliverables/<name>-testcases.csv`
41
+ - Parsing `.feature`, `.spec.ts`, `test-data.yaml` (+ `<name>.<env>.yaml` overlay when `SUNGEN_ENV` is set), and per-target `<name>-test-result[.<env>].json`
42
+ - Generating CSV/XLSX at `qa/deliverables/<name>-testcases[.<env>].csv` / `.xlsx`
37
43
  - Printing summary table
38
44
 
39
45
  ### 2. Handle pre-flight failures (if CLI exits non-zero)
@@ -69,4 +75,9 @@ Forward the CLI's summary table to the user verbatim. Then use `AskUserQuestion`
69
75
  sungen delivery [names...]
70
76
  [--skip-preflight] Skip pre-flight checks (not recommended)
71
77
  [--continue-on-missing] Skip targets with blocking misses
78
+
79
+ # Locale-aware export (env var, not a CLI flag):
80
+ SUNGEN_ENV=<locale> sungen delivery [names...]
81
+ → reads <name>.<locale>.yaml overlay, picks <name>-test-result.<locale>.json,
82
+ writes <name>-testcases.<locale>.csv / .xlsx
72
83
  ```
@@ -0,0 +1,70 @@
1
+ ---
2
+ name: sungen-locale
3
+ description: 'Bootstrap i18n for a screen/flow — audit selectors, detect locale switch mechanism via Playwright, generate test-data overlay so `sungen:run-test --env <locale>` works.'
4
+ argument-hint: "<name> <locale> [--base-locale <code>] [--offline]"
5
+ tools: [read, execute, edit, vscode/askQuestions, playwright/*]
6
+ ---
7
+
8
+ ## Role
9
+
10
+ You are a **Senior QA Localization Engineer**. Use the `sungen-locale` skill — it contains the full phased strategy. Your job in this command is parameter parsing, context detection, and final hand-off.
11
+
12
+ ## Parameters
13
+
14
+ Parse from `$ARGUMENTS`:
15
+ - **name** — screen or flow name (e.g. `home`, `awards`). If missing, ask the user.
16
+ - **locale** — target locale code (e.g. `en`, `ja`, `en-US`, `staging-ja`). If missing, ask. This becomes the suffix in `test-data/<feature>.<locale>.yaml` and `SUNGEN_ENV=<locale>` at run time.
17
+ - **`--base-locale <code>`** — optional. Locale of the existing `test-data/<feature>.yaml`. Default `vi`. Reporting only — files are never renamed.
18
+ - **`--offline`** — force OFFLINE mode (skip Playwright capture). Useful when you know the live page can't be reached.
19
+
20
+ Reject if name == locale.
21
+
22
+ ## Auto-detect context
23
+
24
+ Same as `/sungen:run-test`:
25
+ - `qa/flows/<name>/` exists → flow mode (base path: `qa/flows/<name>/`)
26
+ - Else `qa/screens/<name>/` exists → screen mode (base path: `qa/screens/<name>/`)
27
+ - Neither → tell user and stop
28
+
29
+ ## Steps
30
+
31
+ The `sungen-locale` skill defines 7 phases. Execute them in order:
32
+
33
+ 1. **Phase 1 — Selector audit** (always, no MCP)
34
+ 2. **Phase 2 — Capture base locale** (Live mode only)
35
+ 3. **Phase 3 — Switch locale + detect mechanism** (Live mode only)
36
+ 4. **Phase 4 — Diff base ↔ target** (Live mode only)
37
+ 5. **Phase 5 — Confirm proposal** (always)
38
+ 6. **Phase 6 — Apply files** (always, after confirmation)
39
+ 7. **Phase 7 — Hand off** (always)
40
+
41
+ **Mode selection** happens at the start of Phase 2:
42
+
43
+ - If `--offline` flag → OFFLINE mode (skip Phases 2-4).
44
+ - Else try `browser_navigate(baseURL)` — succeeds + page renders content → LIVE mode.
45
+ - If navigate fails / page redirects to login / shows blocker → fall back to OFFLINE mode automatically. Announce the fallback clearly.
46
+
47
+ ## Enumerate features
48
+
49
+ Multi-feature screens (e.g. `home` has `home.feature` + `home-modal.feature`): run Phases 1, 4, 6 **per feature file**; Phases 2 & 3 (live capture + mechanism detection) **once per screen** — the locale mechanism is the same.
50
+
51
+ ```bash
52
+ ls qa/screens/<name>/features/*.feature
53
+ # or
54
+ ls qa/flows/<name>/features/*.feature
55
+ ```
56
+
57
+ ## After Phase 7
58
+
59
+ Offer the user:
60
+
61
+ - **`/sungen:run-test <name> --env <locale>`** — Run tests against the new locale (Recommended)
62
+ - **`/sungen:locale <name> <other-locale>`** — Bootstrap another locale
63
+ - **Open the overlay file** for review/edit
64
+ - **Done**
65
+
66
+ ## Notes
67
+
68
+ - Do NOT run tests yourself. `/sungen:run-test` is the executor; this command only PREPS files.
69
+ - Do NOT modify `.feature` files. Localization lives in `selectors/*.yaml` + `test-data/*.yaml` only.
70
+ - Auth blocked? Use `--offline`.
@@ -20,13 +20,28 @@ You are a **Senior QA Reviewer**. You evaluate Gherkin test cases using the `sun
20
20
 
21
21
  ## Steps
22
22
 
23
- 1. Read `<base>/<name>/features/<name>.feature` and `<base>/<name>/test-data/<name>.yaml`. If missing → `/sungen-create-test` first.
24
- 2. Follow the `sungen-tc-review` skillscore 3 dimensions: Syntax (30pts), Coverage (40pts), Viewpoint (30pts). **For flows**, also apply the "Flow Review Additions" section. Use `sungen-viewpoint` for pattern checklists.
25
- 3. **Unverified Selectors check** — if `<base>/<name>/selectors/<name>.yaml` exists, count lines matching `@needs-live-verify`. Include in the review report as a non-scoring metric. Does NOT affect the 60% threshold.
26
- 4. Output review report per `sungen-tc-review` format. **>= 60%**: PASS. **< 60%**: FAIL with recommendations.
27
- 5. If FAIL and user confirms update test cases following `sungen-gherkin-syntax` and `sungen-tc-generation` skills, then re-review.
28
- 6. After PASS (or user decides to proceed), offer next steps:
29
-
30
- - **`/sungen-run-test ${input:name}`** — Generate selectors, compile, and run tests (Recommended)
23
+ 1. **Enumerate feature files** — glob `<base>/<name>/features/*.feature`. A screen may have one main file (`<name>.feature`) plus sub-features (`<name>-<sub>.feature` like `awards-modal.feature`); a flow has a single `<name>.feature`. If zero `.feature` files found → `/sungen-create-test` first.
24
+ 2. **Review every feature file**for each `<basename>.feature` discovered in step 1:
25
+ - Read `<basename>.feature` and the matching `test-data/<basename>.yaml`.
26
+ - Apply the `sungen-tc-review` skill — score 3 dimensions: Syntax (30pts), Coverage (40pts), Viewpoint (30pts). **For flows**, also apply the "Flow Review Additions" section. Use `sungen-viewpoint` for pattern checklists.
27
+ - Apply the **Unverified Selectors check** if `<base>/<name>/selectors/<basename>.yaml` exists, count lines matching `@needs-live-verify`. Include in the per-file report as a non-scoring metric. Does NOT affect the 60% threshold.
28
+ 3. **Aggregated output** present scores in a per-feature table, then a screen-level rollup:
29
+
30
+ ```
31
+ Feature Syntax Coverage Viewpoint Total Verdict
32
+ ──────────────────────────────────────────────────────────────────
33
+ home.feature 28/30 36/40 27/30 91% PASS
34
+ home-modal.feature 26/30 24/40 22/30 72% PASS
35
+ ──────────────────────────────────────────────────────────────────
36
+ Screen rollup (mean) 27/30 30/40 24.5/30 81.5% PASS
37
+ ```
38
+
39
+ - **>= 60% per file**: PASS that file.
40
+ - **< 60% per file**: FAIL that file with recommendations.
41
+ - Show the full per-file report (recommendations, top issues) **only for files that fail**, or when the user asks for the deep report.
42
+ 4. If any file is FAIL and user confirms → update that file's test cases following `sungen-gherkin-syntax` and `sungen-tc-generation` skills, then re-review **only the failing files** (skip already-passing ones to save time).
43
+ 5. After all files PASS (or user decides to proceed), offer next steps:
44
+
45
+ - **`/sungen-run-test ${input:name}`** — Generate selectors, compile, and run tests for **every feature** in this screen (Recommended)
31
46
  - **`/sungen-create-test ${input:name}`** — Add more test cases before running
32
47
  - **Done for now** — I'll come back later