@sun-asterisk/sungen 2.5.0 → 2.5.2

package/src/orchestrator/templates/ai-instructions/copilot-cmd-run-test.md

@@ -1,8 +1,8 @@
 ---
-name: run-test
+name: sungen-run-test
 description: 'Generate selectors + auth state via Playwright MCP, compile, and run Playwright tests — auto-fixes selectors on failure'
-argument-hint: [screen-name]
-allowed-tools: Read, Grep, Bash, Glob, Edit, Write, AskUserQuestion, mcp__playwright__browser_navigate, mcp__playwright__browser_snapshot, mcp__playwright__browser_take_screenshot, mcp__playwright__browser_wait_for, mcp__playwright__browser_evaluate, mcp__playwright__browser_run_code, mcp__playwright__browser_storage_state, mcp__playwright__browser_set_storage_state
+argument-hint: '[screen-name]'
+tools: [read, execute, edit, vscode/askQuestions, playwright/*]
 ---
 
 ## Role
@@ -16,7 +16,39 @@ Parse **screen** from `$ARGUMENTS`. If missing, ask the user.
 ## Pre-run (phased — per `sungen-selector-fix` skill)
 
 1. Verify `qa/screens/<screen>/` has `.feature` + `test-data.yaml`.
-2. **Phase 0 — Selector Pre-gen**: if `selectors.yaml` is missing/empty or doesn't cover the feature file's `[Reference]`s, run Phase 0 from `sungen-selector-fix` — confirm with user, `browser_navigate` → one `browser_snapshot` → merge YAML entries.
+2. **Phase 0 — Selector Pre-gen**: if `selectors.yaml` is missing/empty or doesn't cover the feature file's `[Reference]`s, apply the following decision tree before running Phase 0 from `sungen-selector-fix`:
+
+   ```
+   Phase 0 — Selector Generation decision tree
+
+   Live page reachable? (URL provided and loads without error)
+     YES → existing flow: browser_navigate → one browser_snapshot → generate selectors.yaml (verified entries)
+     NO  → spec_figma.md exists in requirements/?
+             YES → provisional flow (sungen-figma-source + sungen-selector-fix skills):
+                   1. Read filtered Figma node data from spec_figma.md (## Components + ## Text Inventory)
+                   2. Apply selector heuristics from sungen-figma-source skill (testid > role+name > placeholder > label > locator > text)
+                   3. Write selectors.yaml — every provisional entry gets this comment on the line above:
+                          # @needs-live-verify source=figma node_id=<id>
+                   4. Compile: sungen generate --screen <screen> — must succeed
+                   5. Phase 1 smoke check runs; tests using unverified selectors may fail
+                      → auto-fix triggers on next run-test invocation when a live page is available
+             NO  → hard stop: print the following message and stop:
+                   "Cannot generate selectors: no live page URL and no spec_figma.md found.
+                    Options:
+                    • Provide the live URL so Playwright MCP can snapshot the page, OR
+                    • Run: sungen add --screen <screen> --figma <figma-url>  to generate spec_figma.md first"
+   ```
+
+   **Auto-fix on subsequent runs**: when `run-test` is invoked again with a reachable live page, Phase 0 compares the DOM snapshot against existing `selectors.yaml` entries. Entries tagged `# @needs-live-verify` are treated as candidates — if the actual selector differs, the entry is replaced and the comment removed (entry becomes verified). Entries that already match are also promoted to verified (comment removed).
+
+   **`@needs-live-verify` comment format** (one comment line, directly above the YAML key):
+   ```yaml
+   # @needs-live-verify source=figma node_id=<figma-node-id>
+   submit-button:
+     type: role
+     value: button
+     name: "Submit"
+   ```
 3. **Phase 0.5 — Auth Persistence**: if the feature has `@auth:<role>` tags and `specs/.auth/<role>.json` is missing/expired, run Phase 0.5 from `sungen-selector-fix` — user logs in manually in MCP browser → `browser_storage_state` → `specs/.auth/<role>.json`. Offer `sungen makeauth <role>` as CLI fallback only if `browser_storage_state` isn't available in this MCP version.
 4. Compile: `sungen generate --screen <screen>` (default: runtime data loading from YAML). Use `--inline-data` only if user requests compile-time hardcoded values.
 

package/src/orchestrator/templates/ai-instructions/copilot-config.md

@@ -19,6 +19,7 @@ You generate 3 files for sungen — a Gherkin compiler that produces Playwright
 | `sungen-capture-figma` | Fetch design context + PNG from a Figma frame URL via Figma Dev Mode MCP |
 | `sungen-capture-local` | Load existing UI assets (screenshots, mockups, Figma exports) from `requirements/ui/` |
 | `sungen-capture-live` | Capture a live running page via Playwright MCP (snapshot + screenshot) |
+| `sungen-figma-source` | Figma URL → spec_figma.md + ui/*.png + provisional selectors |
 
 ## Workflow (5 AI commands)
 

package/src/orchestrator/templates/ai-instructions/copilot-skill-figma-source.md

@@ -0,0 +1,151 @@
+---
+name: sungen-figma-source
+description: 'Figma URL → spec_figma.md envelope + LLM-synthesized narrative from cached raw node JSON. Auto-loaded when --figma flag present or spec_figma.md exists.'
+user-invocable: false
+---
+
+## When This Skill Loads
+
+Auto-load triggers (any one is sufficient):
+
+- Any sungen AI command invoked with `--figma` flag
+- `requirements/spec_figma.md` exists in the screen directory
+- User mentions a Figma URL or says "generate from Figma"
+
+---
+
+## Prerequisites
+
+- [ ] `sungen figma auth check` succeeds — PAT is stored and valid
+- [ ] Figma file URL is available (shared file or frame link)
+- [ ] If auth missing → run `sungen figma auth set` and follow the walkthrough
+
+**Never paste the PAT into any transcript, spec file, or commit.**
+
+---
+
+## Two-Layer Architecture
+
+`spec_figma.md` has two layers separated by the `<!-- SYNTHESIS-BELOW -->` marker:
+
+| Layer | Producer | Overwrite Rule |
+|---|---|---|
+| **Envelope** (above marker) | sungen CLI | Regenerated each `sungen figma` run — deterministic |
+| **Narrative** (below marker) | This skill (LLM) | Replaced on re-synthesis — everything from marker to EOF |
+
+The envelope contains: YAML frontmatter, Frame metadata, Screenshots. The narrative is synthesized by YOU from the cached raw Figma node JSON.
+
+---
+
+## Inputs You Read
+
+The scaffolder persists a raw (unfiltered) Figma node tree to:
+
+```
+.sungen/figma-cache/<fileKey>/<versionId>/<nodeId>-raw.json
+```
+
+Read this file + the envelope frontmatter of `requirements/spec_figma.md` + any PNGs under `requirements/ui/`. You MUST NOT call the Figma REST API directly — the PAT is not available to you.
+
+---
+
+## Synthesis Task
+
+Append 7 narrative sections below `<!-- SYNTHESIS-BELOW -->`. Each section is inferred from the raw node tree (names, types, `characters`, layout bounds, auto-layout direction, componentProperties):
+
+### 1. Purpose
+One paragraph. What screen is this? Primary user goal? Infer from frame name + top-level text + dominant CTA.
+
+### 2. ASCII Layout
+Rough spatial sketch using box characters. Reflect top-bottom / left-right ordering from absoluteBoundingBox. Keep under ~20 lines. Example:
+
+```
+┌──────────────────────────────────────┐
+│ [Logo]                     [Sign In] │
+├──────────────────────────────────────┤
+│  Welcome back                        │
+│  ┌────────────────────────────────┐  │
+│  │ email@example.com              │  │
+│  └────────────────────────────────┘  │
+│  [ Continue ]                        │
+└──────────────────────────────────────┘
+```
+
+### 3. Regions
+Bulleted list of the major layout regions (header, sidebar, main, footer, modal, etc.) with a one-line purpose each. Use auto-layout frames as region hints.
+
+### 4. Actions
+Every interactive element the user can trigger. Derive from nodes whose name/type suggests a button, link, icon-button, menu-item, toggle, etc. Format:
+
+```
+- **<Action name>** — <what it does> (source: <node name>)
+```
+
+### 5. Form Fields
+Every input the user can fill. Include label, type (text/email/password/select/checkbox/radio/textarea/date), required hint if inferable, and placeholder.
+
+```
+| Label | Type | Required | Placeholder |
+|---|---|---|---|
+```
+
+Omit entirely (write `_none_`) if no inputs exist.
+
+### 6. Data Columns
+If the screen shows a table, list, or card grid — enumerate the columns/fields displayed per row. Otherwise write `_none_`.
+
+### 7. Navigation
+Outgoing links, tab bars, breadcrumbs, back buttons — anything that moves the user to another screen. Include both explicit navigation components and implicit CTAs that navigate.
+
+---
+
+## Synthesis Workflow
+
+1. Read `requirements/spec_figma.md` — note `file_key`, `node_id`, `figma_version_id` from frontmatter
+2. Read `.sungen/figma-cache/<file_key>/<figma_version_id>/<safe_node_id>-raw.json` (colons in node_id become underscores)
+3. Traverse the tree. Collect: names, types, `characters`, `componentProperties`, `absoluteBoundingBox`
+4. Produce the 7 sections above
+5. **Locate the insertion point** in `spec_figma.md`:
+   - **If `<!-- SYNTHESIS-BELOW -->` is present** → replace everything from the marker (inclusive) to EOF with: the marker line, a blank line, then the 7 sections.
+   - **If the marker is NOT present** (older `spec_figma.md` pre-envelope-refactor, or hand-edited file) → locate the last non-empty line of the envelope (usually the end of `## Screenshots`), append a blank line, then write the marker, another blank line, then the 7 sections. Do NOT delete any existing envelope content.
+   - **If the file is missing entirely** → advise the user to re-run `sungen add --screen <screen> --figma <url> --refresh` to regenerate the envelope first. Do not fabricate one.
+6. Preserve the envelope (frontmatter + Frame + Screenshots) byte-for-byte. Never touch content above the marker.
+
+---
+
+## Re-synthesis
+
+- If the envelope's `figma_version_id` changed → envelope is fresh; re-run synthesis
+- If only the narrative is stale (user wants a rewrite) → truncate from marker to EOF and regenerate
+- Never edit content ABOVE the marker — that is the scaffolder's territory
+
+---
+
+## Selector Heuristics (for downstream `run-test`)
+
+During `run-test` Phase 0, provisional selectors can be seeded from the raw JSON:
+
+| Figma Signal | Provisional YAML Entry |
+|---|---|
+| Node name ends `Button`, has text | `role: button` + `name: "<text>"` |
+| Node name ends `Input`/`Field` | `placeholder: "<placeholder text>"` |
+| Node name ends `Link`, has text | `role: link` + `name: "<text>"` |
+| componentProperties has `data-testid` | `testid: <value>` |
+| Plain text leaf (outside interactive) | `text: "<content>"` |
+| Node name ends `Icon` | `role: img` + `name: "<accessible name>"` |
+
+Every provisional entry MUST carry:
+
+```
+# @needs-live-verify source=figma node_id=<id>
+```
+
+Provisional selectors feed `selectors.yaml` as candidates. `run-test` Phase 0 verifies them against the live page and overwrites incorrect entries.
+
+---
+
+## Security
+
+- Never include the PAT in `spec_figma.md`, selectors, test data, or any committed file
+- Never log or echo the PAT in terminal output
+- Read only from `.sungen/figma-cache/` and screen directories — never from `.env`

package/src/orchestrator/templates/ai-instructions/github-skill-sungen-figma-source.md

@@ -0,0 +1,151 @@
+---
+name: sungen-figma-source
+description: 'Figma URL → spec_figma.md envelope + LLM-synthesized narrative from cached raw node JSON. Auto-loaded when --figma flag present or spec_figma.md exists.'
+user-invocable: false
+---
+
+## When This Skill Loads
+
+Auto-load triggers (any one is sufficient):
+
+- Any sungen AI command invoked with `--figma` flag
+- `requirements/spec_figma.md` exists in the screen directory
+- User mentions a Figma URL or says "generate from Figma"
+
+---
+
+## Prerequisites
+
+- [ ] `sungen figma auth check` succeeds — PAT is stored and valid
+- [ ] Figma file URL is available (shared file or frame link)
+- [ ] If auth missing → run `sungen figma auth set` and follow the walkthrough
+
+**Never paste the PAT into any transcript, spec file, or commit.**
+
+---
+
+## Two-Layer Architecture
+
+`spec_figma.md` has two layers separated by the `<!-- SYNTHESIS-BELOW -->` marker:
+
+| Layer | Producer | Overwrite Rule |
+|---|---|---|
+| **Envelope** (above marker) | sungen CLI | Regenerated each `sungen figma` run — deterministic |
+| **Narrative** (below marker) | This skill (LLM) | Replaced on re-synthesis — everything from marker to EOF |
+
+The envelope contains: YAML frontmatter, Frame metadata, Screenshots. The narrative is synthesized by YOU from the cached raw Figma node JSON.
+
+---
+
+## Inputs You Read
+
+The scaffolder persists a raw (unfiltered) Figma node tree to:
+
+```
+.sungen/figma-cache/<fileKey>/<versionId>/<nodeId>-raw.json
+```
+
+Read this file + the envelope frontmatter of `requirements/spec_figma.md` + any PNGs under `requirements/ui/`. You MUST NOT call the Figma REST API directly — the PAT is not available to you.
+
+---
+
+## Synthesis Task
+
+Append 7 narrative sections below `<!-- SYNTHESIS-BELOW -->`. Each section is inferred from the raw node tree (names, types, `characters`, layout bounds, auto-layout direction, componentProperties):
+
+### 1. Purpose
+One paragraph. What screen is this? Primary user goal? Infer from frame name + top-level text + dominant CTA.
+
+### 2. ASCII Layout
+Rough spatial sketch using box characters. Reflect top-bottom / left-right ordering from absoluteBoundingBox. Keep under ~20 lines. Example:
+
+```
+┌──────────────────────────────────────┐
+│ [Logo]                     [Sign In] │
+├──────────────────────────────────────┤
+│  Welcome back                        │
+│  ┌────────────────────────────────┐  │
+│  │ email@example.com              │  │
+│  └────────────────────────────────┘  │
+│  [ Continue ]                        │
+└──────────────────────────────────────┘
+```
+
+### 3. Regions
+Bulleted list of the major layout regions (header, sidebar, main, footer, modal, etc.) with a one-line purpose each. Use auto-layout frames as region hints.
+
+### 4. Actions
+Every interactive element the user can trigger. Derive from nodes whose name/type suggests a button, link, icon-button, menu-item, toggle, etc. Format:
+
+```
+- **<Action name>** — <what it does> (source: <node name>)
+```
+
+### 5. Form Fields
+Every input the user can fill. Include label, type (text/email/password/select/checkbox/radio/textarea/date), required hint if inferable, and placeholder.
+
+```
+| Label | Type | Required | Placeholder |
+|---|---|---|---|
+```
+
+Omit entirely (write `_none_`) if no inputs exist.
+
+### 6. Data Columns
+If the screen shows a table, list, or card grid — enumerate the columns/fields displayed per row. Otherwise write `_none_`.
+
+### 7. Navigation
+Outgoing links, tab bars, breadcrumbs, back buttons — anything that moves the user to another screen. Include both explicit navigation components and implicit CTAs that navigate.
+
+---
+
+## Synthesis Workflow
+
+1. Read `requirements/spec_figma.md` — note `file_key`, `node_id`, `figma_version_id` from frontmatter
+2. Read `.sungen/figma-cache/<file_key>/<figma_version_id>/<safe_node_id>-raw.json` (colons in node_id become underscores)
+3. Traverse the tree. Collect: names, types, `characters`, `componentProperties`, `absoluteBoundingBox`
+4. Produce the 7 sections above
+5. **Locate the insertion point** in `spec_figma.md`:
+   - **If `<!-- SYNTHESIS-BELOW -->` is present** → replace everything from the marker (inclusive) to EOF with: the marker line, a blank line, then the 7 sections.
+   - **If the marker is NOT present** (older `spec_figma.md` pre-envelope-refactor, or hand-edited file) → locate the last non-empty line of the envelope (usually the end of `## Screenshots`), append a blank line, then write the marker, another blank line, then the 7 sections. Do NOT delete any existing envelope content.
+   - **If the file is missing entirely** → advise the user to re-run `sungen add --screen <screen> --figma <url> --refresh` to regenerate the envelope first. Do not fabricate one.
+6. Preserve the envelope (frontmatter + Frame + Screenshots) byte-for-byte. Never touch content above the marker.
+
+---
+
+## Re-synthesis
+
+- If the envelope's `figma_version_id` changed → envelope is fresh; re-run synthesis
+- If only the narrative is stale (user wants a rewrite) → truncate from marker to EOF and regenerate
+- Never edit content ABOVE the marker — that is the scaffolder's territory
+
+---
+
+## Selector Heuristics (for downstream `run-test`)
+
+During `run-test` Phase 0, provisional selectors can be seeded from the raw JSON:
+
+| Figma Signal | Provisional YAML Entry |
+|---|---|
+| Node name ends `Button`, has text | `role: button` + `name: "<text>"` |
+| Node name ends `Input`/`Field` | `placeholder: "<placeholder text>"` |
+| Node name ends `Link`, has text | `role: link` + `name: "<text>"` |
+| componentProperties has `data-testid` | `testid: <value>` |
+| Plain text leaf (outside interactive) | `text: "<content>"` |
+| Node name ends `Icon` | `role: img` + `name: "<accessible name>"` |
+
+Every provisional entry MUST carry:
+
+```
+# @needs-live-verify source=figma node_id=<id>
+```
+
+Provisional selectors feed `selectors.yaml` as candidates. `run-test` Phase 0 verifies them against the live page and overwrites incorrect entries.
+
+---
+
+## Security
+
+- Never include the PAT in `spec_figma.md`, selectors, test data, or any committed file
+- Never log or echo the PAT in terminal output
+- Read only from `.sungen/figma-cache/` and screen directories — never from `.env`

package/src/orchestrator/templates/ai-instructions/github-skill-sungen-selector-fix.md

@@ -52,6 +52,67 @@ If existing selectors already cover the feature file, **skip Phase 0** and go st
 
 ---
 
+## Phase 0 (Provisional): Figma-Only Selector Generation (no live page)
+
+**Trigger**: Phase 0 decision tree (in `run-test` command) determined the live page is not reachable AND `requirements/spec_figma.md` exists.
+
+**Goal**: produce a compilable `selectors.yaml` seeded from Figma node data so that `sungen generate` succeeds and the test suite can run. Every entry is provisional — it must be verified against a real DOM when the page becomes available.
+
+### Inputs
+
+- `requirements/spec_figma.md` — specifically:
+  - `## Components` table (Name, Type, Role, Text, Variants columns)
+  - `## Text Inventory` list (node_id → label text pairs)
+
+### Steps
+
+1. **Parse references**: collect every `[Reference]` element from the `.feature` file (same as live Phase 0 step 2).
+2. **Match to Figma nodes**: for each `[Reference]`, find the best matching entry in `spec_figma.md` by comparing the reference name against component names and text labels (case-insensitive, partial match allowed).
+3. **Apply heuristic priority** (same order as live Phase 0 — use first applicable):
+
+   | Priority | Type | Figma Signal |
+   |---|---|---|
+   | 1 | `testid` | Dev annotation `data-testid=X` in component metadata |
+   | 2 | `role` + name | Component type is Button/Link + has text label |
+   | 3 | `placeholder` | Component type is Input/Field + has placeholder text |
+   | 4 | `label` | Component has associated label text (not placeholder) |
+   | 5 | `locator` (CSS) | No accessible name derivable from Figma data |
+   | 6 | `text` | Plain text node (not inside interactive component) |
+
+   See `sungen-figma-source` skill for the authoritative heuristics table mapping Figma signals to YAML entry types.
+
+4. **Write entries**: add each entry to `selectors.yaml`, prefixed with the required comment:
+   ```yaml
+   # @needs-live-verify source=figma node_id=<figma-node-id>
+   submit-button:
+     type: role
+     value: button
+     name: "Submit"
+   ```
+   - Key naming follows `sungen-selector-keys` conventions (lowercase, Unicode preserved, `--type` / `--N` suffixes).
+   - Copy text character-for-character from `## Text Inventory`. Never infer from the Gherkin label.
+   - Merge, don't overwrite — preserve the page selector and any user-authored entries.
+
+5. **Compile**: `sungen generate --screen <screen>` — must succeed before Phase 1.
+
+### Auto-fix on live page (subsequent run-test invocations)
+
+When `run-test` is called again and the live page is now reachable:
+- Phase 0 takes ONE `browser_snapshot`.
+- For each entry tagged `# @needs-live-verify` in `selectors.yaml`:
+  - Compare the provisional selector against the actual DOM element found in the snapshot.
+  - If match → remove the comment line (entry promoted to verified).
+  - If mismatch → replace the YAML value with the snapshot-derived selector, then remove the comment (entry corrected and verified).
+- Entries with no corresponding DOM element → log as unresolved, leave comment in place for manual inspection.
+
+### Pitfalls
+
+- Inferring selector names from Gherkin labels instead of Figma `## Text Inventory` → mismatch on live verification.
+- Omitting `# @needs-live-verify` comment → reviewer has no way to count unverified selectors.
+- Overwriting user-authored selectors during merge → always check for existing keys before adding.
+
+---
+
 ## Phase 0.5: Auth Persistence (MCP alternative to `sungen makeauth`)
 
 Capture an authenticated session from the MCP browser into `specs/.auth/<role>.json` — the same path `sungen makeauth` writes to, which compiled tests already reference via `test.use({ storageState })` based on `@auth:<role>` tags. No `playwright.config.ts` edits needed. Run once per auth lifetime, not on every selector fix.

package/src/orchestrator/templates/ai-instructions/github-skill-sungen-tc-generation.md

@@ -6,14 +6,25 @@ user-invocable: false
 
 ## Goal
 
-Generate **focused test cases per screen section** with **20+ scenarios per viewpoint**. Output `.feature` + `test-data.yaml` only — selectors are deferred to `/sungen:run-test`.
+Generate **focused test cases per screen section** using a **tier-based approach** for faster results. Output `.feature` + `test-data.yaml` only — selectors are deferred to `/sungen:run-test`.
+
+### Tier System
+
+| Tier | Priority | What to generate | When |
+|---|---|---|---|
+| **Tier 1** (default) | `@critical` + `@high` | Happy paths, required validation, core business rules, security basics | First run of `create-test` |
+| **Tier 2** (expand) | `@normal` + `@low` | UI presence, optional validation, edge cases, cosmetic checks | User runs `create-test` again with "Add viewpoints" mode |
+
+**Round 1 (Tier 1)** targets **~10-15 scenarios per section** — enough to cover critical flows and catch real bugs. This is the default behavior.
+
+**Round 2 (Tier 2)** expands to full coverage when the user explicitly chooses "Add viewpoints" or "Add new sections" update mode. Only then generate `@normal` + `@low` scenarios to fill coverage gaps.
 
 ## Update Mode
 
 When `.feature` already has scenarios, summarize and ask:
-1. **Add new sections** — append, continue numbering
-2. **Add viewpoints** — add to existing sections
-3. **Replace all** — overwrite
+1. **Add new sections** — append new sections with Tier 2 (`@normal` + `@low`) scenarios, continue numbering
+2. **Add viewpoints** — expand existing sections with Tier 2 (`@normal` + `@low`) scenarios
+3. **Replace all** — overwrite with fresh Tier 1 (`@critical` + `@high`) generation
 
 For append: read highest `VP-<CAT>-<NNN>`, continue from next number. Never modify existing scenarios.
 
@@ -28,14 +39,28 @@ Requirements improve every viewpoint: exact error messages for VAL, business rul
 
 If also exploring live page: verify spec vs actual, flag mismatches, capture exact text.
 
+### Figma supplement (`spec_figma.md`)
+
+When `requirements/spec_figma.md` is present alongside `spec.md`, treat it as a **secondary input** with these rules:
+
+- **Never override `spec.md`**: `spec.md` is authoritative for all business rules, field constraints, and behavior. `spec_figma.md` only supplements with visual/text data that `spec.md` may lack.
+- **`## Text Inventory` → literal strings**: use text label values from this section verbatim in `test-data.yaml` (button labels, input placeholders, error messages shown in Figma). Do not paraphrase or invent alternatives.
+- **`## Interaction States` → state coverage checkpoints**: use the listed variants (e.g., empty, loading, error, success) as a checklist for state-coverage scenarios. Only generate scenarios for states that are either (a) confirmed in both `spec.md` and `spec_figma.md`, or (b) explicitly documented in one source without contradiction from the other.
+- **Flag disagreements**: if a field name, label, or behavior in `spec_figma.md` contradicts `spec.md`, insert an HTML comment at the top of the `.feature` file:
+  ```gherkin
+  <!-- FIGMA-SPEC CONFLICT: <brief description> — using spec.md value -->
+  ```
+  Then proceed using the `spec.md` value.
+
 ## Screen Input Sources
 
-**Recommended** (in priority order):
-1. **Figma designs** — use Figma MCP to read design context, screenshots, and component metadata
-2. **UI images** — screenshots or mockups in `qa/screens/<screen>/requirements/ui/`
-3. **`spec.md`** — written specification with sections, fields, validation rules
+**Auto-detect** — the parent command (`create-test`) resolves visual sources before invoking this skill. By the time generation starts, the available sources are already determined:
+- `spec.md` — primary, always read if present
+- `spec_figma.md` — Figma supplement, read if present (PAT flow already completed)
+- `ui/*.png` — visual context, read if present
+- `test-viewpoint.md` — edge cases and known issues, read if present
 
-**Optional**: **Live page scan** via Playwright MCP — useful to verify specs vs actual UI, capture real data (error messages, labels). If auth needed → ask user to log in manually via MCP browser.
+**IMPORTANT:** If `spec_figma.md` exists, do NOT call any `mcp__figma__*` tool. The PAT flow is complete — just read the file.
 
 **Single screen focus**: one URL = one screen. Don't explore sibling paths. Modals on same page = part of this screen.
 
@@ -76,7 +101,9 @@ Apply `sungen-test-design-techniques` to spec-extracted conditions:
 
 Use `sungen-viewpoint` skill for per-pattern checklists across 4 viewpoints: UI/UX, Data & Validate, Logic, Security.
 
-Add scenarios for generic UI coverage that spec didn't explicitly state (empty states, loading states, keyboard nav, hover effects). Skip viewpoints truly N/A.
+**Tier-aware gap filling:**
+- **Tier 1 (first run)**: only add `@critical` and `@high` items from the checklists — core security checks (VP-SEC), required field validation (VP-VAL), key state transitions (VP-LOGIC). Skip `@normal`/`@low` items like hover states, empty states, tooltips.
+- **Tier 2 (expand run)**: add `@normal` + `@low` scenarios — UI presence, optional validation, edge cases, cosmetic checks, keyboard nav, hover effects.
 
 **Validation rule**: capture actual error messages from live page or spec.md. Use `User see {{error_var}}` — never assert just "is visible".
 
@@ -168,13 +195,14 @@ Feature: <Screen> Screen
     When User click [Create] button
     Then User see [Form] dialog
 
-  # --- Section: Create User Form ---
+  # --- Section: Create User Form (Tier 1: @critical + @high) ---
 
-  @normal @extend:open_form
-  Scenario: VP-UI-001 Form displays all fields with correct defaults
+  @critical @extend:open_form
+  Scenario: VP-LOGIC-001 Submit form with valid data creates record
     Given User is on [Form] dialog
-    Then User see [Name] field
-    And User see [Submit] button is disabled
+    When User fill [Name] field with {{valid_name}}
+    And User click [Submit] button
+    Then User see {{success_message}} message
 
   @high @extend:open_form
   Scenario: VP-VAL-001 Submit with all empty fields shows errors
@@ -182,11 +210,7 @@ Feature: <Screen> Screen
     When User click [Submit] button
     Then User see [Name error] message with {{name_required_error}}
 
-  # --- Section: User Table ---
-
-  @normal
-  Scenario: VP-UI-010 Table displays all columns
-    Then User see [Name] column in [Users] table
+  # --- Section: User Table (Tier 1: @critical + @high) ---
 
   @high
   Scenario: VP-VAL-010 Table displays correct data
@@ -194,13 +218,15 @@ Feature: <Screen> Screen
       | Name       | Email        |
       | {{name_1}} | {{email_1}}  |
 
-  @high
-  Scenario: VP-VAL-011 Edit button targets correct row
-    Given User see [Target] row in [Users] table with {{name_1}}
-    When User click [Edit] button in [Users] table with {{name_1}}
-    Then User see [Name] field with {{name_1}}
+  @critical
+  Scenario: VP-SEC-010 Unauthorized user cannot access page
+    Given User is not logged in
+    When User navigate to [Screen] page
+    Then User is on [Login] page
 ```
 
+**Tier 2 (expand run)** adds `@normal` + `@low` scenarios like UI field presence, hover states, tooltips, empty states.
+
 ### When to use DataTable vs Row Scope
 
 | Pattern | Use when |

package/src/orchestrator/templates/ai-instructions/github-skill-sungen-tc-review.md

@@ -43,6 +43,8 @@ Score: `(dimensions_covered / 6) * 40`. Validate technique application with `sun
 
 **Classification**: UI = static/always-same appearance. VAL = input validation/errors. LOGIC = behavior/state changes (includes persisted state without When). SEC = auth/permissions.
 
+**Tier-aware scoring**: If the feature file only contains `@critical` + `@high` scenarios (Tier 1), do NOT penalize for missing VP-UI viewpoint — UI scenarios are intentionally deferred to Tier 2. Score "All applicable VP present" based on Tier 1-relevant viewpoints only (VAL, LOGIC, SEC). Note in the review output: *"VP-UI deferred to Tier 2 — run create-test with 'Add viewpoints' to expand."*
+
 ---
 
 ## Quality Rules
@@ -87,6 +89,21 @@ Do NOT mark `@manual` when data is visible in snapshot or documented in spec —
 
 ---
 
+## Unverified Selectors metric
+
+**When to check**: if `qa/screens/<screen>/selectors/<screen>.yaml` exists, count lines matching the pattern `@needs-live-verify`.
+
+| Metric | Source | Scoring impact |
+|---|---|---|
+| Unverified Selectors | Count of `@needs-live-verify` comment lines in `selectors.yaml` | None — non-blocking |
+
+- If count > 0: include the following line in the review report summary (after the score table, before Issues):
+  `⚠ <N> selectors flagged @needs-live-verify — run run-test against live URL when available.`
+- Does NOT reduce the score or block the 60% threshold. The suite can PASS with unverified selectors.
+- If `selectors.yaml` does not exist yet (not yet generated): omit this metric entirely.
+
+---
+
 ## Output Format
 
 ```markdown
@@ -99,6 +116,9 @@ Do NOT mark `@manual` when data is visible in snapshot or documented in spec —
 | Viewpoint | <n> | 30 |
 | **Total** | **<n>%** | **100** |
 
+⚠ <N> selectors flagged @needs-live-verify — run run-test against live URL when available.
+<!-- omit this line if selectors.yaml doesn't exist or @needs-live-verify count = 0 -->
+
 ### Issues
 1. [SYNTAX] ...
 2. [COVERAGE] ...