@sun-asterisk/sungen 2.4.1 → 2.4.3

package/src/orchestrator/templates/ai-instructions/claude-skill-gherkin-syntax.md

@@ -27,150 +27,68 @@ AND    →  inherits from preceding keyword
 
 ## Step Patterns (70 patterns)
 
-### Setup
+### Setup / Form / Interaction
 
 ```
-User is on [T] page                              # navigate to page
-User is on [T] page with {{v}}                   # navigate with data (e.g., detail page with ID)
-User is on [T] dialog                            # enter dialog scope
+User is on [T] page | page with {{v}} | dialog
+User fill [T] field | textarea | search | slider | date-picker with {{v}}
+User fill [T] uploader with {{f}}
+User clear [T] field
+User check [T] checkbox | toggle | radio
+User uncheck [T] checkbox | toggle
+User select [T] dropdown with {{v}}
+User click [T] button | tab | column | breadcrumb
+User click [T] row with {{v}}
+User double click [T] element
+User hover [T] icon | row
+User drag [T] to [T2]
+User expand | collapse [T] row
 ```
 
-### Form
+**click + with {{Value}} rule**: NO value for static (`button`, `link`, `icon`, `tab`). WITH value only for dynamic lists (`row`, `item`, `card`, `option`).
 
-```
-User fill [T] field with {{v}}                   # text input
-User fill [T] textarea with {{v}}                # multiline input
-User fill [T] search with {{v}}                  # search input
-User fill [T] slider with {{v}}                  # set slider value
-User fill [T] date picker with {{v}}             # date input
-User clear [T] field                             # clear input
-User check [T] checkbox                          # check
-User check [T] toggle                            # toggle on (same as check)
-User check [T] radio                             # select radio
-User uncheck [T] checkbox                        # uncheck
-User uncheck [T] toggle                          # toggle off
-User select [T] dropdown with {{v}}              # select option
-User fill [T] uploader with {{f}}                # file upload
-```
-
-### Interaction
-
-```
-User click [T] button                            # click (static element, no value)
-User click [T] row with {{v}}                    # click dynamic list item (row/item/card/option)
-User click [T] tab                               # switch tab
-User click [T] column                            # sort column
-User click [T] breadcrumb                        # navigate breadcrumb
-User double click [T] element                    # double click
-User hover [T] icon                              # hover (must have see/click after)
-User hover [T] row                               # hover row for hidden actions
-User drag [T] to [T2]                            # drag and drop
-User expand [T] row                              # expand (aria-expanded)
-User collapse [T] row                            # collapse (aria-expanded)
-```
-
-#### click + with {{Value}} rule
-
-- **NO value** for static elements: `button`, `link`, `icon`, `tab`, `toggle`
-- **WITH value** only for dynamic lists: `row`, `item`, `card`, `option`
-
-### Browser Alert (system dialog)
+### Alert / Keyboard / Wait / Scroll
 
 ```
-User click [OK] alert                            # accept (OK/Accept/Yes/Confirm)
-User click [Cancel] alert                        # dismiss (Cancel/Dismiss/No)
-User fill [T] alert with {{v}}                   # fill prompt + accept
-User see [message text] alert                    # assert dialog message
+User click [OK | Cancel] alert
+User fill [T] alert with {{v}}
+User see [message text] alert
+User press Escape key | Enter on [T] field
+User wait for N seconds | [T] dialog | [T] dialog is STATE | [T] page
+User scroll to [T] section
+User switch to [T] frame | [main] frame
 ```
 
 > Alert steps must appear BEFORE the action that triggers the dialog.
 
-### Keyboard
-
-```
-User press Escape key                            # global key press
-User press Enter on [T] field                    # key on element
-```
-
-### Wait
-
-```
-User wait for N seconds                          # wait timeout
-User wait for [T] dialog                         # wait for element
-User wait for [T] dialog is STATE                # wait for state
-User wait for [T] dialog with {{v}}              # wait for element with text
-User wait for [T] page                           # wait for navigation
-User wait for [T] message                        # wait for toast/feedback
-User wait for [T] button                         # wait for button to appear
-```
-
-### Scroll & Frame
-
-```
-User scroll to [T] section                       # scroll into view
-User switch to [T] frame                         # enter iframe
-User switch to [main] frame                      # exit iframe
-```
-
-### Assertions (8 verify patterns)
+### Assertions (8 patterns → determines Playwright assertion)
 
 ```
-# 1. Visibility
-User see [T] message                             # visible (default — NEVER add "is visible")
-User see [T] modal is hidden                     # hidden
-
-# 2. Text Content (exact full match — toHaveText)
-User see [T] message with {{v}}                  # exact text match
-User see [T] header with {{v}}                   # heading text
-User see [T] label with {{v}}                    # label text
-
-# 3. Partial Text Match (toContainText)
-User see [T] text contains {{v}}                 # partial text match
-
-# 4. Input Value (toHaveValue)
-User see [T] field with {{v}}                    # input value
-User see [T] dropdown with {{v}}                 # selected value
-User see [T] date picker with {{v}}              # date value
-User see [T] search with {{v}}                   # search input value
-User see [T] slider with {{v}}                   # slider value
-
-# 5. Component State
-User see [T] button is disabled                  # state assertion
-User see [T] checkbox is checked                 # checked state
-User see [T] toggle is unchecked                 # unchecked state
-User see [T] dialog with {{v}} is hidden         # text + state combined
-
-# 6. Attribute (toHaveAttribute — when selector YAML has `attribute` field)
-User see [T] image with {{v}}                    # image src
-User see [T] link with {{v}}                     # link href
-
-# 7. Count
-User see [T] row with {{count}}                  # element count
-
-# 8. Page Context
-User see [T] page                                # URL assertion
+# 1. Visibility: User see [T] type (NEVER add "is visible") | is hidden
+# 2. Text (toHaveText): User see [T] message | header | label with {{v}}
+# 3. Partial (toContainText): User see [T] text contains {{v}}
+# 4. Input (toHaveValue): User see [T] field | dropdown | date-picker | search | slider with {{v}}
+# 5. State: User see [T] button is disabled | checkbox is checked | dialog with {{v}} is hidden
+# 6. Attribute (toHaveAttribute): User see [T] image | link with {{v}}
+# 7. Count: User see [T] row with {{count}}
+# 8. Page: User see [T] page
 ```
 
 ### Table
 
 ```
-User see [Col] column in [Table] table                          # column exists
-User see [Ref] row in [Table] table with {{v}}                  # row exists (enters row scope)
-User see [Ref] row in [Table] table with {{v}} is hidden        # row hidden
-User see [Table] table with {{count}}                           # row count
-User see [Table] table is empty                                 # empty table
-User see [Col] column with {{v}}                                # cell value (row scoped)
-User click [Act] button in [Table] table with {{v}}             # action in row
-User see [Table] table match data:                              # exact table match (inline DataTable)
+User see [Col] column in [Table] table
+User see [Ref] row in [Table] table with {{v}}
+User see [Ref] row in [Table] table with {{v}} is hidden
+User see [Table] table with {{count}} | is empty
+User see [Col] column with {{v}}
+User click [Act] button in [Table] table with {{v}}
+User see [Table] table match data:
     | Header1    | Header2    |
     | {{value1}} | {{value2}} |
 ```
 
-**Priority**: Use row scope patterns for single-row verification + actions. Use `table match data` only when verifying multiple rows at once.
-
-Row scope: `see [Ref] row in [Table] table with {{v}}` defines `tableRow`. Subsequent `see [Col] column with {{v}}` checks the cell in that row. With `columns` config → exact `nth(index)`, without → `filter({ hasText })`.
-
-Table match data: `see [Table] table match data:` followed by a Cucumber DataTable. First row = headers, remaining rows = expected data. Uses **filter-based matching** — verifies rows containing expected values exist, resilient to data changes, extra rows, and row reordering. Use `{{variable}}` for cell values.
+Row scope: `see [Ref] row in [Table] table with {{v}}` enters scope. Subsequent `see [Col] column with {{v}}` checks cell in that row. Use `table match data:` for multi-row verification.
 
 ### States
 
@@ -223,6 +141,10 @@ Options: `nth` `exact` `scope` `match` `variant` `frame` `contenteditable` `colu
 | `@auto` | Standard scenario, ready for automation |
 | `@manual` | Skip in generation |
 | `@smoke` / `@regression` | Test suite grouping |
+| `@critical` | Priority: system unusable if fails (login, auth, core CRUD) |
+| `@high` | Priority: major feature broken (required validation, key business rules) |
+| `@normal` | Priority: degraded experience (UI layout, secondary flows) |
+| `@low` | Priority: minor/cosmetic (tooltips, hover states, empty states) |
 | `@auth:role` | Use auth storage state for role |
 | `@no-auth` | Disable inherited auth |
 | `@steps:name` | Define reusable step block (base scenario) |
@@ -232,6 +154,8 @@ Options: `nth` `exact` `scope` `match` `variant` `frame` `contenteditable` `colu
 
 - Tool executes **only Given→When** of `@steps` scenario (skips Then)
 - The `Given` in `@extend` scenario is the **entry assertion** (confirms state after base steps)
+- **Entry assertion MUST use `Given User is on [X] type`** — NEVER `Given User see [X] type`
+- `Given` keyword ONLY allows `is on` action. `see` = `Then` only.
 - If `@steps` scenario fails, `@extend` scenario is **skipped**
 - Name format: `snake_case` or `kebab-case` with module prefix: `@steps:kudos__open_modal`
 
@@ -240,6 +164,8 @@ Options: `nth` `exact` `scope` `match` `variant` `frame` `contenteditable` `colu
 | Error | Wrong | Correct |
 |---|---|---|
 | Wrong keyword | `Given User click [T] button` | `When User click [T] button` |
+| `see` after Given | `Given User see [T] heading with {{v}}` | `Then User see [T] heading with {{v}}` (or `Given User is on [T] page` for entry assertion) |
+| Name ≠ step type | Scenario name says "modal" but step uses `dialog` | Use the **same element type** in both: "...dialog opens" + `[X] dialog` |
 | Wrong action for type | `When User click [T] checkbox` | `When User check [T] checkbox` |
 | press wrong target | `When User press [Submit] button` | `When User press Enter key` |
 | uncheck radio | `When User uncheck [Male] radio` | `When User check [Female] radio` |
@@ -247,3 +173,39 @@ Options: `nth` `exact` `scope` `match` `variant` `frame` `contenteditable` `colu
 | Missing `is` for state | `with {{text}} hidden` | `with {{text}} is hidden` |
 | State as value | `with {{disabled}}` | `is disabled` |
 | Missing target type | `fill [email] with {{v}}` | `fill [email] field with {{v}}` |
+| Using Background | `Background: Given User is on...` | Use `@steps` + `@extend` instead |
+| `is on` after When | `When ... And User is on [X] dialog` | `And User see [X] dialog` or separate Given |
+
+## Background vs @steps/@extend
+
+**Do NOT use `Background:` block.** Use `@steps` + `@extend` instead.
+
+**Why:**
+- `Background` runs before EVERY scenario but cannot set dialog/frame scope correctly
+- `Background` with `When` + `And User is on [X] dialog` creates keyword mismatch (`is on` = Given, not When)
+- `@steps` + `@extend` gives explicit control: base steps run Given→When, extending scenario starts with `Given User is on [X] dialog` (correct scope setup)
+
+**Wrong:**
+```gherkin
+Background:
+  Given User is on [Kudos] page
+  When User click [Open] button
+  And User is on [Modal] dialog    ← keyword mismatch
+
+Scenario: VP-UI-001 Title visible
+  Then User see [Title] heading
+```
+
+**Correct:**
+```gherkin
+@steps:open_modal
+Scenario: Open modal
+  Given User is on [Kudos] page
+  When User click [Open] button
+  Then User see [Modal] dialog
+
+@extend:open_modal
+Scenario: VP-UI-001 Title visible
+  Given User is on [Modal] dialog
+  Then User see [Title] heading
+```

package/src/orchestrator/templates/ai-instructions/claude-skill-selector-fix.md

@@ -1,20 +1,80 @@
 ---
 name: sungen-selector-fix
-description: 'Selector fixing strategy — diagnose failures, explore live page targeted, fix broken selectors. Auto-loaded by run-test command.'
+description: 'Selector fixing strategy — phased execution, priority-first diagnosis, targeted MCP exploration. Auto-loaded by run-test command.'
 user-invocable: false
 ---
 
-## Strategy: Fix Only What Breaks
+## Strategy: Phased Execution
 
-Most selectors auto-infer from Gherkin element types (see `sungen-selector-keys` skill). Only add YAML entries for selectors that fail during test execution.
+Run tests in priority waves — catch fundamental issues early, fix critical paths first, let shared fixes cascade to lower-priority tests.
 
-**Minimal `selectors.yaml`**: page selectors (required), overrides for elements where auto-infer doesn't work. Never generate a full page catalog upfront.
+**Never run all tests blindly.** Always start with a smoke check.
 
 ---
 
-## Step 1: Diagnose Failures
+## Phase 1: Smoke Check (catch fundamentals)
 
-Parse Playwright error output to categorize failures:
+Run **up to 5 scenarios** — pick the first `@critical` or `@high` scenarios in the feature file.
+
+```bash
+npx playwright test --grep "VP-.*-001|VP-.*-002|VP-.*-003|VP-.*-004|VP-.*-005" --reporter=line
+```
+
+**Purpose:** Detect broken fundamentals before running 50+ tests:
+- Page selector wrong → ALL tests would fail (1 fix, not 50 diagnoses)
+- Auth redirect → need `@no-auth` or user login
+- Base `@steps:` scenario broken → all `@extend:` scenarios would fail
+
+**If all 5 pass** → skip to Phase 2.
+**If failures** → diagnose and fix (see Diagnosis & Fix below), then re-run smoke. Max 2 attempts here.
+
+---
+
+## Phase 2: Priority Wave (@critical + @high)
+
+Run all `@critical` and `@high` scenarios:
+
+```bash
+npx playwright test --grep "@critical|@high" --reporter=line
+```
+
+If your Playwright config doesn't support tag grep, use scenario name grep from the feature file — collect VP IDs of `@critical` and `@high` scenarios.
+
+**Fix only failures from this wave.** Most shared selectors (buttons, headings, navigation) get fixed here because critical/high scenarios exercise them.
+
+Max 2 fix attempts in this phase.
+
+---
+
+## Phase 3: Full Run (@normal + @low)
+
+Run remaining scenarios:
+
+```bash
+npx playwright test --reporter=line
+```
+
+Many selectors already fixed from Phase 2 (shared elements). Only diagnose **new** failures — selectors that only appear in lower-priority scenarios.
+
+Max 1 fix attempt. If `@low` scenarios still fail after fix → **report and move on**, don't loop.
+
+---
+
+## Phase 4: Regression
+
+One final full run to confirm all phases together:
+
+```bash
+npx playwright test --reporter=line
+```
+
+Report results. Do NOT enter another fix loop here.
+
+---
+
+## Diagnosis & Fix (used in each phase)
+
+### Step 1: Parse Failures
 
 | Error pattern | Root cause | Fix target |
 |---|---|---|
@@ -28,9 +88,7 @@ Parse Playwright error output to categorize failures:
 
 **Check `test-results/` first** — Playwright captures failure screenshots automatically. Use these to diagnose before any MCP exploration.
 
----
-
-## Step 2: Targeted MCP Exploration
+### Step 2: Targeted MCP Exploration
 
 Only when `test-results/` screenshots are insufficient:
 
@@ -41,11 +99,7 @@ Only when `test-results/` screenshots are insufficient:
 
 **Never use `sungen makeauth`.** Never use `browser_evaluate` to inject cookies.
 
----
-
-## Step 3: Fix Broken Selectors
-
-For each failed selector, find the correct locator from the snapshot:
+### Step 3: Fix Broken Selectors
 
 Selector priority (use first applicable):
 
@@ -73,9 +127,18 @@ Common fixes:
 - Element in iframe → add `frame` field
 - Dynamic content → use `testid` or structural `role` + `nth`
 
+### Step 4: Recompile After Fix
+
+Always recompile before re-running:
+```bash
+sungen generate --screen <screen>
+```
+
+Then re-run only the current phase's failing tests, not all tests.
+
 ---
 
-## Step 4: Table Selectors
+## Table Selectors
 
 For table patterns, add table selectors with `columns` config:
 
@@ -100,7 +163,7 @@ users:
 
 ---
 
-## Step 5: Detail Screens with Dynamic IDs
+## Detail Screens with Dynamic IDs
 
 For screens like `/admin/users/:id`:
 1. Navigate to list page via MCP to find a real record ID
@@ -114,12 +177,13 @@ user detail:
 
 ---
 
-## Step 6: Fix Loop
+## Attempt Budget Summary
 
-After fixing selectors:
-1. Recompile: `sungen generate --screen <screen>`
-2. Re-run only failing tests: `npx playwright test --grep "VP-XXX-001|VP-XXX-002" --reporter=line`
-3. If new failures → repeat (max 3 attempts)
-4. After all fixes → run ALL tests once for regression check
+| Phase | What runs | Max fix attempts | On failure after max |
+|---|---|---|---|
+| 1. Smoke | First 5 @critical/@high | 2 | Ask user — fundamentals broken |
+| 2. Priority | All @critical + @high | 2 | Report failures, continue to Phase 3 |
+| 3. Full | All tests | 1 | Report @low/@normal failures, continue |
+| 4. Regression | All tests | 0 | Report final results |
 
-If still failing after 3 attempts → ask user for guidance.
+**Total worst case: 5 fix attempts** (2+2+1), not unbounded loops.

package/src/orchestrator/templates/ai-instructions/claude-skill-tc-generation.md

@@ -22,7 +22,7 @@ For append: read highest `VP-<CAT>-<NNN>`, continue from next number. Never modi
 When `qa/screens/<screen>/requirements/` exists:
 - **`spec.md`** — primary: sections, field constraints, validation messages, business rules, states
 - **`ui/`** — supplementary: screenshots for layout/visual context
-- **`notes.md`** — supplementary: edge cases, known issues
+- **`test-viewpoint.md`** — supplementary: edge cases, known issues
 
 Requirements improve every viewpoint: exact error messages for VAL, business rules for LOGIC, role permissions for SEC.
 
@@ -47,16 +47,64 @@ When exploring live page or reading Figma designs, actively collect to hardcode
 
 ## Section Identification
 
-Identify sections from page patterns. Use `sungen-viewpoint` skill for the 7 pattern types (Form, Table, Search, Filter, Pagination, Modal, List/Card). Present sections and ask user which to focus on.
+Identify sections from page patterns. Use `sungen-viewpoint` skill for the 10 pattern types (Form & Inputs, Data Table, Create/Add, Update/Edit, Delete, Search, Filter, Pagination, Modal/Dialog, List/Card). Present sections and ask user which to focus on.
 
-## Viewpoint & Coverage
+## Test Generation Strategy
+
+### Step 1 — Spec-first extraction (always do this first)
+
+Before applying any checklist, extract test conditions from `spec.md` (and `test-viewpoint.md` if present):
+- **Validation rules**: field constraints, error messages, required/optional
+- **Business rules**: eligibility, calculation logic, permission-based behavior
+- **State lifecycle**: allowed transitions, blocked transitions
+- **Edge cases**: boundary values, empty states, concurrent conditions
+
+These spec-extracted conditions drive **which scenarios exist** — `sungen-viewpoint` only supplements with generic web UI coverage that spec doesn't explicitly state.
+
+### Step 2 — Apply test design techniques
+
+Apply `sungen-test-design-techniques` to spec-extracted conditions:
+
+| Technique | Apply when spec mentions |
+|---|---|
+| EP | Valid/invalid ranges, categories → **one** scenario per class, not per value |
+| BVA | Numeric range, string length → `min-1`, `min`, `max`, `max+1` (compact 4-point default) |
+| Decision Table | 2+ dependent conditions → one scenario per combination (cap at distinct outcomes if >3 conditions) |
+| State Transition | Entity lifecycle → one scenario per valid transition + key invalid transitions |
+
+### Step 3 — Fill coverage gaps with viewpoint checklists
 
 Use `sungen-viewpoint` skill for per-pattern checklists across 4 viewpoints: UI/UX, Data & Validate, Logic, Security.
 
-Generate **20+ scenarios per applicable viewpoint**. Skip viewpoints truly N/A.
+Add scenarios for generic UI coverage that spec didn't explicitly state (empty states, loading states, keyboard nav, hover effects). Skip viewpoints truly N/A.
 
 **Validation rule**: capture actual error messages from live page or spec.md. Use `User see {{error_var}}` — never assert just "is visible".
 
+## Priority Tags (auto-assign)
+
+Every scenario **MUST** have exactly one priority tag. Add it before the scenario line (after `@extend:` if present).
+
+| Tag | When to use |
+|---|---|
+| `@critical` | System unusable if fails — login/logout, authentication redirect, main create/submit/delete, permission denied |
+| `@high` | Major feature broken — required field validation, core business rules, data displays correctly, key navigation |
+| `@normal` | Degraded experience — UI layout/element presence, secondary flows, optional field validation, search/filter |
+| `@low` | Minor/cosmetic — tooltips, hover states, empty states, default sort, placeholder text |
+
+### Auto-assign heuristics
+
+| Viewpoint + Pattern | Default priority |
+|---|---|
+| VP-SEC-* (all security scenarios) | `@critical` |
+| VP-LOGIC-* with create/submit/delete/login | `@critical` |
+| VP-LOGIC-* other state changes | `@high` |
+| VP-VAL-* required field / submit empty | `@high` |
+| VP-VAL-* format, boundary, optional fields | `@normal` |
+| VP-UI-* form fields present, table columns | `@normal` |
+| VP-UI-* hover, tooltip, empty state, placeholder | `@low` |
+
+**`@steps:` scenarios** do NOT get a priority tag (they are setup blocks, not test cases).
+
 ## SPA Wait-For Steps
 
 ```gherkin
@@ -68,51 +116,44 @@ And User wait for [Page Title] heading is visible
 
 **Feature file** — `qa/screens/<screen>/features/<screen>.feature`
 
+**Never use `Background:`.** Use `@steps` + `@extend` for shared setup (see `sungen-gherkin-syntax` skill).
+
 ```gherkin
 @auth:role
 Feature: <Screen> Screen
 
-  # ============================================================
-  # Section: Create User Form
-  # ============================================================
+  # Shared setup — NO priority tag on @steps
+  @steps:open_form
+  Scenario: Open form
+    Given User is on [Screen] page
+    When User click [Create] button
+    Then User see [Form] dialog
 
-  # --- UI/UX ---
+  # --- Section: Create User Form ---
 
+  @normal @extend:open_form
   Scenario: VP-UI-001 Form displays all fields with correct defaults
-    Given User is on [Create User] page
+    Given User is on [Form] dialog
     Then User see [Name] field
-    And User see [Email] field
     And User see [Submit] button is disabled
 
-  # --- Validation ---
-
+  @high @extend:open_form
   Scenario: VP-VAL-001 Submit with all empty fields shows errors
+    Given User is on [Form] dialog
     When User click [Submit] button
     Then User see [Name error] message with {{name_required_error}}
 
-  # ============================================================
-  # Section: User Table
-  # ============================================================
-
-  # --- UI/UX ---
+  # --- Section: User Table ---
 
+  @normal
   Scenario: VP-UI-010 Table displays all columns
     Then User see [Name] column in [Users] table
-    And User see [Email] column in [Users] table
-    And User see [Status] column in [Users] table
-
-  # --- Data & Validate ---
 
+  @high
   Scenario: VP-VAL-010 Table displays correct data
     Then User see [Users] table match data:
-      | Name         | Email          | Status       |
-      | {{name_1}}   | {{email_1}}    | {{status_1}} |
-      | {{name_2}}   | {{email_2}}    | {{status_2}} |
-
-  Scenario: VP-VAL-011 Edit button targets correct row
-    Given User see [Target] row in [Users] table with {{name_1}}
-    When User click [Edit] button in [Users] table with {{name_1}}
-    Then User see [Name] field with {{name_1}}
+      | Name       | Email        |
+      | {{name_1}} | {{email_1}}  |
 ```
 
 ### When to use DataTable vs Row Scope
@@ -122,7 +163,7 @@ Feature: <Screen> Screen
 | `table match data:` + DataTable | Verifying **multiple rows** exist with expected values |
 | `row in [Table] table with {{v}}` + `column with {{v}}` | Checking **single row** details or **acting** on a row (click, edit) |
 
-**Naming**: `VP-<CATEGORY>-<NNN>` prefix.
+**Naming**: `VP-<CATEGORY>-<NNN>` prefix. Scenario name must use the **same element type** as the steps — e.g., if the step uses `dialog`, write "dialog opens" not "modal opens".
 
 **Test data** — `qa/screens/<screen>/test-data/<screen>.yaml`, grouped by section.
 

package/src/orchestrator/templates/ai-instructions/claude-skill-tc-review.md

@@ -20,16 +20,16 @@ user-invocable: false
 
 ### Coverage (40 pts)
 
-| Dimension | Pts | Min scenarios |
-|---|---|---|
-| Happy paths | 8 | 3-5 |
-| Negative cases | 8 | 3-5 |
-| Edge cases | 8 | 5-8 |
-| Boundary values | 6 | 3-5 |
-| State transitions | 5 | 2-4 |
-| Combinatorial | 5 | 2-4 |
+| Dimension | Technique | Pts | What to check |
+|---|---|---|---|
+| Happy paths | — | 8 | Core success flows exist |
+| Negative cases | EP | 8 | One scenario per invalid class, no redundant same-class scenarios |
+| Edge cases | EP | 6 | Empty, null, whitespace, special chars covered |
+| Boundary values | BVA | 8 | `min-1`, `min`, `max`, `max+1` for each spec range |
+| State transitions | ST | 5 | Valid transitions + key blocked paths from spec |
+| Condition combos | DT | 5 | Dependent conditions covered, distinct outcomes tested |
 
-Score: `(dimensions_covered / 6) * 40`. Per-pattern checklists → `sungen-viewpoint` skill.
+Score: `(dimensions_covered / 6) * 40`. Validate technique application with `sungen-test-design-techniques`. Per-pattern checklists → `sungen-viewpoint` skill.
 
 ### Viewpoint (30 pts)
 
@@ -37,7 +37,8 @@ Score: `(dimensions_covered / 6) * 40`. Per-pattern checklists → `sungen-viewp
 |---|---|
 | All applicable VP present (UI/VAL/LOGIC/SEC) | 10 |
 | Correct classification | 8 |
-| `VP-<CAT>-<NNN>` naming + section grouping | 8 |
+| `VP-<CAT>-<NNN>` naming + section grouping | 4 |
+| Priority tag present and correct (`@critical`/`@high`/`@normal`/`@low`) | 4 |
 | Assertion quality (see rules below) | 4 |
 
 **Classification**: UI = static/always-same appearance. VAL = input validation/errors. LOGIC = behavior/state changes (includes persisted state without When). SEC = auth/permissions.
@@ -58,6 +59,7 @@ Score: `(dimensions_covered / 6) * 40`. Per-pattern checklists → `sungen-viewp
 2. **`When fill [X]`** → Then must assert the **visible result** (search results, validation error). Don't re-assert the field value.
 3. **UI-only scenarios** (no action needed) → use Given + Then without When.
 4. **Scenario name must match the assertion**, not the action.
+5. **Scenario name must use the same element type as the steps** — e.g., "dialog opens" + `[X] dialog`, never "modal opens" + `[X] dialog`.
 
 ### @manual Rules
 
@@ -72,13 +74,16 @@ Do NOT mark `@manual` when data is visible in snapshot or documented in spec —
 
 ## Checklist (auto-fix on detection)
 
-1. **Redundant scenarios** — keep stronger assertion, remove weaker duplicate
+1. **Redundant scenarios (EP violation)** — multiple scenarios testing same equivalence class? Keep one representative, remove rest
 2. **Misclassified VP** — UI tests behavior? Move to LOGIC. Logic tests appearance? Move to UI
 3. **Dynamic content** — exact match on counters/timestamps? Use `contains` instead
 4. **Duplicate across sections** — SEC scenario identical to UI? Remove duplicate
-5. **Always-enabled elements** — `is enabled` on never-disabled element? Remove
-6. **Test-data completeness** — every `{{var}}` must exist in test-data.yaml
-7. **Missing negative/boundary** — every form section needs at least: empty field, invalid format, boundary value
+5. **Missing/wrong priority tag** — every non-`@steps` scenario needs exactly one of `@critical`/`@high`/`@normal`/`@low`. SEC→`@critical`, VAL required→`@high`, UI layout→`@normal`, hover/tooltip→`@low`
+6. **Always-enabled elements** — `is enabled` on never-disabled element? Remove
+7. **Test-data completeness** — every `{{var}}` must exist in test-data.yaml
+8. **Missing BVA boundaries** — spec defines min/max range but scenarios only test midpoint? Add `min-1`, `min`, `max`, `max+1`
+9. **Missing state transitions** — spec defines lifecycle states but only happy path tested? Add blocked transitions
+10. **Uncovered condition combos** — spec has 2+ dependent conditions but only partial combinations tested? Build decision table
 
 ---