@sun-asterisk/sungen 2.2.2 → 2.2.3

package/src/orchestrator/templates/ai-instructions/github-skill-sungen-selector-fix.md

@@ -168,9 +168,16 @@ Many elements don't need a YAML entry — sungen auto-infers from the Gherkin la
 |---|---|
 | `[Submit] button` | `getByRole('button', { name: 'Submit' })` |
 | `[Home] link` | `getByRole('link', { name: 'Home' })` |
-| `[Welcome] heading` | `getByRole('heading', { name: 'Welcome' })` |
+| `[Welcome] heading` / `header` | `getByRole('heading', { name: 'Welcome' })` |
 | `[Email] field` | `getByPlaceholder('Email')` |
-| `[Success] text` | `getByText('Success')` |
+| `[Success] text` / `message` / `label` | `getByText('Success')` |
+| `[Terms] checkbox` | `getByRole('checkbox', { name: 'Terms' })` |
+| `[Global] search` | `getByRole('searchbox', { name: 'Global' })` |
+| `[Vietnam] option` | `getByRole('option', { name: 'Vietnam' })` |
+| `[Price] slider` | `getByRole('slider', { name: 'Price' })` |
+| `[Notification] toggle` | `getByRole('switch', { name: 'Notification' })` |
+| `[Profile] tab` | `getByRole('tab', { name: 'Profile' })` |
+| `[Confirm] dialog` / `modal` / `drawer` | `getByRole('dialog', { name: 'Confirm' })` |
 
 **Only add a YAML entry when auto-infer won't work:**
 - The accessible name differs from the Gherkin label
@@ -181,19 +188,52 @@ Many elements don't need a YAML entry — sungen auto-infers from the Gherkin la
 
 ---
 
-### Fix Loop on Test Failure
+### Fix Loop on Test Failure (Batched Strategy)
 
+Running all tests every iteration is slow. Use a batched approach to fix faster:
+
+```
+1. INITIAL RUN — run ALL tests, collect full failure list
+     npx playwright test <spec> --reporter=line
+
+2. BATCHED FIX LOOP (max 5 attempts):
+     a. Read test output → group failures by root cause:
+        - Same selector broken → 1 fix covers many tests
+        - Same error type (strict mode, timeout, text mismatch)
+     b. Fix selectors.yaml or test-data.yaml for current batch
+     c. Recompile: sungen generate --screen <screen>
+     d. Re-run ONLY previously-failing tests (max 20):
+        npx playwright test <spec> --grep "VP-UI-001|VP-UI-002|VP-VAL-001" --reporter=line
+     e. If batch passes → pick next batch of remaining failures
+     f. If batch still fails → fix and retry (counts toward max 5)
+
+3. FINAL CONFIRMATION — run ALL tests once:
+     npx playwright test <spec> --reporter=line
+     This catches regressions from selector changes.
+
+4. If still failing after 5 fix attempts → ask user about direct .spec.ts fix
 ```
-attempt = 0
-while attempt < 5:
-    compile → run test
-    if pass → done
-    read error-context.md in test-results/ → check exact snapshot state at failure time
-    fix selectors.yaml or test-data.yaml
-    recompile → attempt++
-if still failing → ask user about direct .spec.ts fix
+
+#### Building the `--grep` pattern
+
+Extract scenario names from the failure output and join with `|`:
+```bash
+# Example: re-run only 3 failing tests
+npx playwright test <spec> --grep "VP-VAL-001|VP-VAL-002|VP-VAL-003" --reporter=line
 ```
 
+- Max 20 test names per `--grep` to keep the pattern manageable
+- If >20 failures share the same root cause, fix the cause and run the first 20 to verify
+
+#### Grouping failures by root cause
+
+Common patterns where 1 fix resolves many failures:
+- **Same selector** — e.g., all `[Email Error]` tests fail → fix `email error` in selectors.yaml once
+- **Same error type** — e.g., all `strict mode violation` → add `exact: true` or `nth`
+- **Same assertion** — e.g., all `toHaveText` on inputs fail → change Gherkin pattern (inputs have no text)
+
+Fix the root cause first, verify with the batch, then move on.
+
 **Always read the error context snapshot first** — it shows the exact page state when the test failed, which is more reliable than re-navigating with MCP.
 
 ---

package/src/orchestrator/templates/ai-instructions/github-skill-sungen-selector-keys.md

@@ -51,6 +51,10 @@ Type aliases (normalized automatically):
 | logo, image, icon | `img` |
 | btn | `button` |
 | input, textbox, textarea, editor | `field` |
+| search | `searchbox` |
+| toggle | `switch` |
+| alert | `alertdialog` |
+| modal, drawer | `dialog` |
 | column | `columnheader` |
 | list-item | `listitem` |
 
@@ -83,10 +87,20 @@ If no YAML key exists, the resolver infers from the Gherkin element type:
 |---|---|
 | `[X] button` | `getByRole('button', { name: 'X' })` |
 | `[X] link` | `getByRole('link', { name: 'X' })` |
-| `[X] heading` | `getByRole('heading', { name: 'X' })` |
+| `[X] heading` / `header` | `getByRole('heading', { name: 'X' })` |
 | `[X] checkbox` | `getByRole('checkbox', { name: 'X' })` |
+| `[X] radio` | `getByRole('radio', { name: 'X' })` |
 | `[X] field` | `getByPlaceholder('X')` |
-| `[X] text` | `getByText('X')` |
+| `[X] text` / `message` / `label` | `getByText('X')` |
 | `[X] logo/image/icon` | `getByRole('img', { name: 'X' })` |
+| `[X] search` | `getByRole('searchbox', { name: 'X' })` |
+| `[X] option` | `getByRole('option', { name: 'X' })` |
+| `[X] slider` | `getByRole('slider', { name: 'X' })` |
+| `[X] toggle` | `getByRole('switch', { name: 'X' })` |
+| `[X] tab` | `getByRole('tab', { name: 'X' })` |
+| `[X] table` | `getByRole('table', { name: 'X' })` |
+| `[X] list` | `getByRole('list', { name: 'X' })` |
+| `[X] column` | `getByRole('columnheader', { name: 'X' })` |
+| `[X] dialog` / `modal` / `drawer` | `getByRole('dialog', { name: 'X' })` |
 
 **Only add a YAML entry when** the auto-inferred locator won't work (wrong name, need testid, need nth, etc.).